[PATCH] drm: Fix timestamp docs for variable refresh properties.

2019-04-18 Thread Mario Kleiner
behaviour present in Linux 5.0/5.1. Fixes: ab7a664f7a2d ("drm: Document variable refresh properties") Link: https://patchwork.freedesktop.org/patch/285333/ Signed-off-by: Mario Kleiner --- drivers/gpu/drm/drm_connector.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drive

[PATCH 4/4] drm/amd/display: Compensate for pre-DCE12 BTR-VRR hw limitations.

2019-04-17 Thread Mario Kleiner
ons (low fps to high fps) < DCE-12 is a little bit improved, although by far not as much as for up-sweeps and constant fps. Signed-off-by: Mario Kleiner --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 32 ++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/d

[PATCH 2/4] drm/amd/display: Fix and simplify apply_below_the_range()

2019-04-17 Thread Mario Kleiner
The comparison of inserted_frame_duration_in_us against a duration calculated from max_refresh_in_uhz is both wrong in its math and not needed, as the min_duration_in_us value is already cached in in_out_vrr for reuse. No need to recalculate it wrongly at each invocation. Signed-off-by: Mario

[PATCH 1/4] drm/amd/display: Add some debug output for VRR BTR.

2019-04-17 Thread Mario Kleiner
Helps with debugging issues with low framerate compensation. Signed-off-by: Mario Kleiner --- .../amd/display/modules/freesync/freesync.c| 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd

Improvements to VRR below-the-range/low framerate compensation.

2019-04-17 Thread Mario Kleiner
Hi This patch-series tries to improve amdgpu's below-the-range behaviour with Freesync, hopefully not only for my use case, but also for games etc. Patch 1/4 adds a bit of debug output i found very useful, so maybe worth adding? Patch 2/4 fixes a bug i found when reading over the freesync code.

[PATCH 3/4] drm/amd/display: Enter VRR BTR earlier.

2019-04-17 Thread Mario Kleiner
and prevents missed vblanks at the border between non-BTR and BTR. Testing on DCE-8, DCE-11 and DCN-1.0 shows that this more often avoids skipped frames when moving across the BTR boundary, especially on DCE-8 and DCE-11 with the followup commit for dealing with pre-DCE-12 hw. Signed-off-by: Mario Kleiner

[PATCH 5/5] drm/amd/display: Make pageflip event delivery compatible with VRR.

2019-03-29 Thread Mario Kleiner
if we are in case a) or b), we check the current scanout position against the boundary of front-porch. In non-VRR mode we just do what we did in the past. Signed-off-by: Mario Kleiner Reviewed-by: Nicholas Kazlauskas --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 68 +++ 1

[PATCH 2/5] drm/amd/display: Prevent vblank irq disable while VRR is active. (v3)

2019-03-29 Thread Mario Kleiner
-by: Mario Kleiner --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 36 +++ 1 file changed, 36 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6528258f8975..6c413bc012af 100644 --- a/drivers

[PATCH 4/5] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank. (v2)

2019-03-29 Thread Mario Kleiner
. v2: Implement feedback by Nicholas and Paul Menzel. Signed-off-by: Mario Kleiner Acked-by: Harry Wentland Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 128 +- .../gpu/drm/amd

[PATCH 3/5] drm/amd/display: Rework vrr flip throttling for late vblank irq.

2019-03-29 Thread Mario Kleiner
after it, without a negative impact on flip throttling, so followup patches can shift the vblank core handling trigger point wherever they need it. Signed-off-by: Mario Kleiner Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +- .../gpu/drm/amd/display

[PATCH 1/5] drm/amd/display: Update VRR state earlier in atomic_commit_tail.

2019-03-29 Thread Mario Kleiner
at the beginning of commit tail before the vrr transition handling, and a late part that must run after vrr transition handling inside the commit planes code for enabled crtc's. Suggested by Nicholas Kazlauskas. Signed-off-by: Mario Kleiner --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 61

AMD Freesync patches v3

2019-03-29 Thread Mario Kleiner
The hopefully final patch series, with feedback applied and r-b / acked-by tags added. Rebased to current agd5f/drm-5.2-wip branch. Numbering has slightly changed. Patches 3-5 are identical to last series. Patch 2/5 v3 (the former 1/4 v2) trivially rebased on top of the new 1/5. Patch 1/5 is new

[PATCH 3/4] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank. (v2)

2019-03-22 Thread Mario Kleiner
. v2: Implement feedback by Nicholas and Paul Menzel. Signed-off-by: Mario Kleiner Acked-by: Harry Wentland --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 128 +- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 9

AMD Freesync patches v2

2019-03-22 Thread Mario Kleiner
The current patch series, with feedback from Paul, Nicholas and Harry applied and r-b / acked-by tags added. Thanks for the feedback. Rebased to current drm-5.2-wip branch. Patch 1/4 is still the same though. Don't know if i or Nicholas could fix it in a followup patch, or this one needs more

[PATCH 1/4] drm/amd/display: Prevent vblank irq disable while VRR is active. (v2)

2019-03-22 Thread Mario Kleiner
refresh rate non-VRR mode. v2: Make sure transition is also handled if vrr is disabled and stream gets disabled in the same atomic commit. Suggested by Nicholas. Signed-off-by: Mario Kleiner --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 36 +++ 1 file changed, 36

[PATCH 4/4] drm/amd/display: Make pageflip event delivery compatible with VRR.

2019-03-22 Thread Mario Kleiner
if we are in case a) or b), we check the current scanout position against the boundary of front-porch. In non-VRR mode we just do what we did in the past. Signed-off-by: Mario Kleiner Reviewed-by: Nicholas Kazlauskas --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 68 +++ 1

[PATCH 2/4] drm/amd/display: Rework vrr flip throttling for late vblank irq.

2019-03-22 Thread Mario Kleiner
after it, without a negative impact on flip throttling, so followup patches can shift the vblank core handling trigger point wherever they need it. Signed-off-by: Mario Kleiner Reviewed-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +- .../gpu/drm/amd/display

Re: [PATCH 3/4] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank.

2019-03-21 Thread Mario Kleiner
On Wed, Mar 20, 2019 at 1:53 PM Kazlauskas, Nicholas wrote: > > On 3/20/19 3:51 AM, Mario Kleiner wrote: > > Ok, fixed all the style issues and ran checkpatch over the patches. Thanks. > > > > On Tue, Mar 19, 2019 at 2:32 PM Kazlauskas, Nicholas > > wrote

Re: [PATCH 1/4] drm/amd/display: Prevent vblank irq disable while VRR is active. (v2)

2019-03-21 Thread Mario Kleiner
On Wed, Mar 20, 2019 at 2:11 PM Kazlauskas, Nicholas wrote: > > On 3/20/19 4:12 AM, Mario Kleiner wrote: > > During VRR mode we can not allow vblank irq dis-/enable > > transitions, as an enable after a disable can happen at > > an arbitrary time during the

Re: [PATCH 1/4] drm/amd/display: Prevent vblank irq disable while VRR is active.

2019-03-20 Thread Mario Kleiner
On Mon, Mar 18, 2019 at 6:29 PM Kazlauskas, Nicholas wrote: > > On 3/18/19 1:19 PM, Mario Kleiner wrote: > > During VRR mode we can not allow vblank irq dis-/enable > > transitions, as an enable after a disable can happen at > > an arbitrary time during the

[PATCH 1/4] drm/amd/display: Prevent vblank irq disable while VRR is active. (v2)

2019-03-20 Thread Mario Kleiner
refresh rate non-VRR mode. v2: Make sure transition is also handled if vrr is disabled and stream gets disabled in the same atomic commit. Suggested by Nicholas. Signed-off-by: Mario Kleiner --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 36 +++ 1 file changed

Re: [PATCH 3/4] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank.

2019-03-20 Thread Mario Kleiner
Ok, fixed all the style issues and ran checkpatch over the patches. Thanks. On Tue, Mar 19, 2019 at 2:32 PM Kazlauskas, Nicholas wrote: > > On 3/19/19 9:23 AM, Kazlauskas, Nicholas wrote: > > On 3/18/19 1:19 PM, Mario Kleiner wrote: > >> In VRR mode, proper vblank/pagefli

[PATCH 4/4] drm/amd/display: Make pageflip event delivery compatible with VRR.

2019-03-18 Thread Mario Kleiner
if we are in case a) or b), we check the current scanout position against the boundary of front-porch. In non-VRR mode we just do what we did in the past. Signed-off-by: Mario Kleiner --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 68 ++- 1 file changed, 55 insertions

[PATCH 3/4] drm/amd/display: In VRR mode, do DRM core vblank handling at end of vblank.

2019-03-18 Thread Mario Kleiner
. Signed-off-by: Mario Kleiner --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 129 - drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 9 ++ .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 22

[PATCH 2/4] drm/amd/display: Rework vrr flip throttling for late vblank irq.

2019-03-18 Thread Mario Kleiner
after it, without a negative impact on flip throttling, so followup patches can shift the vblank core handling trigger point wherever they need it. Signed-off-by: Mario Kleiner --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 2 +- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23

[PATCH 1/4] drm/amd/display: Prevent vblank irq disable while VRR is active.

2019-03-18 Thread Mario Kleiner
refresh rate non-VRR mode. Signed-off-by: Mario Kleiner --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index

AMD Freesync patches for proper vblank and pageflip timestamping in VRR mode.

2019-03-18 Thread Mario Kleiner
Hi This series implements properly working vblank and pageflip completion timestamping for amdgpu in VRR / FreeSync mode. Now pageflip timestamps for pageflip events always carry the vblank timestamp of the vblank in which the flip completed, and the vblank timestamp is as accurate as in fixed

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Mario Kleiner via dri-devel
> > > >> On 2/13/19 4:50 AM, Daniel Vetter wrote: > > >>> On Tue, Feb 12, 2019 at 10:32:31PM +0100, Mario Kleiner wrote: > > >>>> On Mon, Feb 11, 2019 at 6:04 PM Daniel Vetter wrote: > > >>>>> > > >>>>

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Mario Kleiner via dri-devel
On Wed, Feb 13, 2019 at 10:50 AM Daniel Vetter wrote: > > On Tue, Feb 12, 2019 at 10:32:31PM +0100, Mario Kleiner wrote: > > On Mon, Feb 11, 2019 at 6:04 PM Daniel Vetter wrote: > > > > > > On Mon, Feb 11, 2019 at 4:01 PM Kazlauskas, Nicholas > > > wr

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-13 Thread Mario Kleiner via dri-devel
On Wed, Feb 13, 2019 at 10:56 AM Chris Wilson wrote: > > Quoting Daniel Vetter (2019-02-13 09:50:55) > > On Tue, Feb 12, 2019 at 10:32:31PM +0100, Mario Kleiner wrote: > > > I think all kms drivers try to call drm_crtc_handle_vblank() at start > > > of vbl

Re: [PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-12 Thread Mario Kleiner via dri-devel
On Mon, Feb 11, 2019 at 6:04 PM Daniel Vetter wrote: > > On Mon, Feb 11, 2019 at 4:01 PM Kazlauskas, Nicholas > wrote: > > > > On 2/11/19 3:35 AM, Daniel Vetter wrote: > > > On Mon, Feb 11, 2019 at 04:22:24AM +0100, Mario Kleiner wrote: > > >> The

Re: [PATCH] drm/amd/display: Use vrr friendly pageflip throttling in DC.

2019-02-12 Thread Mario Kleiner via dri-devel
On Mon, Feb 11, 2019 at 7:44 PM Kazlauskas, Nicholas wrote: > > On 2/11/19 10:01 AM, Michel Dänzer wrote: > > On 2019-02-09 7:52 a.m., Mario Kleiner wrote: > >> In VRR mode, keep track of the vblank count of the last > >> completed pageflip in amdgpu_crtc->l

Re: [PATCH] drm/amd/display: Use vrr friendly pageflip throttling in DC.

2019-02-12 Thread Mario Kleiner via dri-devel
Oops, dropped the mailing ist from my reply, so again... On Mon, Feb 11, 2019 at 4:01 PM Michel Dänzer wrote: > > On 2019-02-09 7:52 a.m., Mario Kleiner wrote: > > In VRR mode, keep track of the vblank count of the last > > completed pageflip in amdgpu_crtc->last_flip_vb

[PATCH 1/3] drm/amdgpu: Fix get_crtc_scanoutpos behavior in vrr when vpos >= vtotal.

2019-02-10 Thread Mario Kleiner
e stable timestamp for future improvements of the pageflip timestamping under vrr. Fixes: 520f08df45fb ("drm/amdgpu: Correct get_crtc_scanoutpos behavior when vpos >= vtotal") Signed-off-by: Mario Kleiner Cc: Cc: Nicholas Kazlauskas Cc: Harry Wentland Cc: Alex Deucher

Some VRR vblank/pageflip timestamping fixes.

2019-02-10 Thread Mario Kleiner
These fix the currently broken vblank timestamping in VRR mode and broken pageflip timestamping in VRR mode. The unfixed implementation can provide timestamps that are off by dozens of milliseconds and thereby make VRR unusable for any application that needs at least millisecond precision in

[PATCH 3/3] drm/amd/display: Provide more accurate pageflip timestamps in vrr mode.

2019-02-10 Thread Mario Kleiner
potentially dozens of milliseconds to probably less than 2 msecs in the common case, given the fixed and short back-porch duration and the usually low interrupt dispatch delay from pageflip interrupt. Signed-off-by: Mario Kleiner Cc: Nicholas Kazlauskas Cc: Harry Wentland Cc: Alex Deucher

[PATCH 2/3] drm: Add basic helper to allow precise pageflip timestamps in vrr.

2019-02-10 Thread Mario Kleiner
he exact end time of vblank. Signed-off-by: Mario Kleiner Cc: Nicholas Kazlauskas Cc: Harry Wentland Cc: Alex Deucher --- drivers/gpu/drm/drm_vblank.c | 49 +++- include/drm/drm_vblank.h | 8 ++ 2 files changed, 56 insertions(+), 1 deletion(-) diff --git

[PATCH] drm/amd/display: Use vrr friendly pageflip throttling in DC.

2019-02-08 Thread Mario Kleiner
ate. Fixes: bb47de736661 ("drm/amdgpu: Set FreeSync state using drm VRR properties") Signed-off-by: Mario Kleiner Cc: Cc: Nicholas Kazlauskas Cc: Harry Wentland Cc: Alex Deucher Cc: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 1 + .../gpu/drm/amd/display/amdgpu_d

Re: nouveau 30bpp / deep color status

2018-03-08 Thread Mario Kleiner
Cc'ing mesa-dev, which was left out. On 03/05/2018 01:40 PM, Ilia Mirkin wrote: On Mon, Mar 5, 2018 at 2:25 AM, Mario Kleiner <mario.kleiner...@gmail.com> wrote: On 02/05/2018 12:50 AM, Ilia Mirkin wrote: In case anyone's curious about 30bpp framebuffer support, here's the current

Re: nouveau 30bpp / deep color status

2018-03-04 Thread Mario Kleiner
On 02/05/2018 12:50 AM, Ilia Mirkin wrote: In case anyone's curious about 30bpp framebuffer support, here's the current status: Kernel: Ben and I have switched the code to using a 256-based LUT for Kepler+, and I've also written a patch to cause the addfb ioctl to use the proper format. You

Re: [PATCH] drm/edid: Add 6 bpc quirk for CPT panel in Asus UX303LA

2018-02-18 Thread Mario Kleiner
"AEO", 0, EDID_QUIRK_FORCE_6BPC }, + /* CPT panel of Asus UX303LA reports 8 bpc, but is a 6 bpc panel */ + { "CPT", 0x17df, EDID_QUIRK_FORCE_6BPC }, + /* Belinea 10 15 55 */ { "MAX", 1516, EDID_QUIRK_PREFER_LARGE_60 }, { "MAX&qu

Re: [PATCH 2/2] drm/i915: Add module parameter to en-/disable hw color correction.

2017-09-29 Thread Mario Kleiner
On 09/26/2017 07:05 AM, Daniel Vetter wrote: On Fri, Sep 15, 2017 at 05:48:25PM +0200, Mario Kleiner wrote: The new module parameter enable_hw_color_correction defaults to true, to retain the current behaviour. If set to false, it will disable all hardware color correction, like gamma/degamma

[PATCH 1/2] drm/i915: Add module parameter to force en-/disable dithering.

2017-09-15 Thread Mario Kleiner
, to have an override for DE's which may not expose such properties via some standard protocol in a user-controllable way, e.g., afaik all currently existing Wayland compositors. Tested on Ironlake, IvyBridge, Haswell, Skylake. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- d

[PATCH 2/2] drm/i915: Add module parameter to en-/disable hw color correction.

2017-09-15 Thread Mario Kleiner
ts the effective output precision to 8 bit, while an auto-bypassed precision lut doesn't restrict precision. Iow. this patch is needed even with XR30 fb's for actual 10 bit precision output, even though the hw seems to sort of ignore the tested gamma tables for XR30 fb's. Signed-off-b

Module parameters to override color management/dithering.

2017-09-15 Thread Mario Kleiner
Hi, so these two patches add i915 module parameters to globally override how the driver handles dithering and gamma/csc conversion. They serve two purposes: First as debug aid and "airbag" for working around potential precision problems in getting pixels from rendering to the display outputs.

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-07-24 Thread Mario Kleiner
On 07/24/2017 03:45 PM, Florian Echtler wrote: Hello Lukas, On 17.07.2017 11:02, Lukas Wunner wrote: On Fri, Jun 02, 2017 at 06:47:07PM +0200, Florian Echtler wrote: Sorry for the delay Florian. Commit 564d8a2cf3ab by Mario Kleiner (+cc) landed in Linus' tree last week and is included

[PATCH] drm/radeon: Fix eDP for single-display iMac10,1 (v2)

2017-07-06 Thread Mario Kleiner
eak other DCE3.2 systems. Use dmi_match() to apply this special encoder assignment only for the Apple iMac 10,1 from late 2009. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: Michel Dänzer <michel.daen...@amd.c

Re: [PATCH 1/4] drm/vc4: Allow vblank_disable_immediate on non-fw-kms.

2017-06-21 Thread Mario Kleiner
On 06/21/2017 06:19 PM, Eric Anholt wrote: Mario Kleiner <mario.kleiner...@gmail.com> writes: With instantaneous high precision vblank timestamping that updates at leading edge of vblank, the emulated "hw vblank counter" from vblank timestamping which increments at leadin

[PATCH] drm/vc4: Allow vblank_disable_immediate on non-fw-kms. (v2)

2017-06-21 Thread Mario Kleiner
offdelay=0 would keep vblank irqs on to approximate old behavior. v2: Respin onto drm-misc-next, per Eric's suggestion. Drop !vc4->firmware_kms check, as the firmware_kms implementation does not exist in upstream. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com>

[PATCH 2/4] drm/radeon: Allow vblank_disable_immediate.

2017-06-20 Thread Mario Kleiner
(or echo 0 > /sys/module/drm/parameters/vblankoffdelay) would keep vblank irqs permanently on to approximate old behavior. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: Michel Dänzer <michel.daen...@amd.com> --- d

[PATCH 1/4] drm/vc4: Allow vblank_disable_immediate on non-fw-kms.

2017-06-20 Thread Mario Kleiner
offdelay=0 would keep vblank irqs on to approximate old behavior. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Eric Anholt <e...@anholt.net> --- drivers/gpu/drm/vc4/vc4_kms.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers

[PATCH 4/4] drm/nouveau/kms/nv50-: Allow vblank_disable_immediate.

2017-06-20 Thread Mario Kleiner
ith kernel cmdline option drm.vblankoffdelay=0 (or echo 0 > /sys/module/drm/parameters/vblankoffdelay) would keep vblank irqs permanently on to approximate old behavior. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Ben Skeggs <bske...@redhat.com> --- drivers/gpu/drm/n

[PATCH 3/4] drm/amdgpu: Allow vblank_disable_immediate.

2017-06-20 Thread Mario Kleiner
drm.vblankoffdelay=0 (or echo 0 > /sys/module/drm/parameters/vblankoffdelay) would keep vblank irqs permanently on to approximate old behavior. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: Michel Dänzer <michel.daen...@amd.com

Enable vblank_disable_immediate on more drivers.

2017-06-20 Thread Mario Kleiner
This patch series sets dev->vblank_disable_immediate = true on radeon/amdgpu-kms, nouveau-kms for nv50+, and vc4 for the real kms driver (as opposed to dispmanx firmware backed kms). All the drivers should be ready in theory, given their implementation, for fast vblank disable/enable. In

[PATCH 2/2] drm/radeon: Fix overflow of watermark calcs at > 4k resolutions.

2017-06-12 Thread Mario Kleiner
and division. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reported-by: Ben Hutchings <ben.hutchi...@codethink.co.uk> Fixes: e6b9a6c84b93 ("drm/radeon: Make display watermark calculations more accurate") Cc: Ben Hutchings <ben.hutchi...@codethink.co.uk> Cc

[PATCH 1/2] drm/amdgpu: Fix overflow of watermark calcs at > 4k resolutions.

2017-06-12 Thread Mario Kleiner
r u64 casting and division. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Reported-by: Ben Hutchings <ben.hutchi...@codethink.co.uk> Fixes: d63c277dc672 ("drm/amdgpu: Make display watermark calculations more accurate") Cc: Ben Hutchings <ben.hutchi...@codethink.c

Re: PROBLEM: EDID regression results in color banding on Lenovo G50 series laptops [fix proposition]

2017-05-15 Thread Mario Kleiner
ed out that the problem had been introduced by commit 210a021dab639694600450c14b877bf3e3240adc commit 210a021dab639694600450c14b877bf3e3240adc Author: Mario Kleiner <mario.kleiner...@gmail.com> Date: Wed Jul 6 12:05:48 2016 +0200 drm/edid: Set 8 bpc color depth for displays with "DFP 1.x com

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-05-06 Thread Mario Kleiner
On 05/05/2017 04:25 PM, Keith Packard wrote: Pekka Paalanen writes: I disagree on the details, more below. Such a RandR request is something I would not like to have to replicate on Wayland. The display server contains the policy, it should not just expose everything

Re: [PATCH 1/3] RFC: drm: Restrict vblank ioctl to master

2017-05-05 Thread Mario Kleiner
On 05/05/2017 09:35 PM, Daniel Vetter wrote: On Mon, Jul 25, 2016 at 1:15 PM, Rainer Hochecker wrote: Am 25.07.2016 08:38 schrieb "Michel Dänzer" : On 13.07.2016 18:49, Rainer Hochecker wrote: We have been using this for years now and did not observe

[PATCH] drm/nouveau/fb/gf100-: Fix 32 bit wraparound in new ram detection

2017-04-28 Thread Mario Kleiner
A missing u64 cast causes a 32-Bit wraparound from 4096 MiB to 0 MiB and therefore total 0 MiB VRAM detected if card has 4096 Mib per FBP. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgf100.c | 2 +- 1 file changed, 1 insertion

[PATCH 2/2] drm/amd/display: Prevent premature pageflip when comitting in vblank. (v3)

2017-04-24 Thread Mario Kleiner
ing or flip completion timestamps. Tested on R9 380 Tonga. v2: Add acked/r-b by Harry and Michel. v3: Feedback from Andrey: Must not wait an extra frame for DRM_MODE_PAGE_FLIP_ASYNC flips. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Acked-by: Harry Wentland <harry.went

[PATCH 2/2] drm/amd/display: Prevent premature pageflip when comitting in vblank. (v2)

2017-04-24 Thread Mario Kleiner
off-by: Mario Kleiner <mario.kleiner...@gmail.com> Acked-by: Harry Wentland <harry.wentl...@amd.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> Cc: Harry Wentland <harry.wentl...@amd.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: Michel Dänzer <michel.d

[PATCH 1/2] drm/amd/display: Fix race between vblank irq and pageflip irq. (v2)

2017-04-24 Thread Mario Kleiner
agraph about problem already fixed in 2nd patch of the series. Add acked/r-b by Harry and Michel. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Acked-by: Harry Wentland <harry.wentl...@amd.com> Reviewed-by: Michel Dänzer <michel.daen...@amd.com> Cc: Andrey Gro

[PATCH] drm/nouveau/kms: Increase max retries in scanout position queries.

2017-04-23 Thread Mario Kleiner
of uptime in a hard to reproduce manner. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Ben Skeggs <bske...@redhat.com> --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_

[PATCH 2/2] drm/radeon: Make display watermark calculations more accurate

2017-04-23 Thread Mario Kleiner
ned-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/radeon/cik.c | 10 +- drivers/gpu/drm/radeon/evergreen.c | 10 +- drivers/gpu/drm/radeon/si.c| 10 +- 3 files changed, 15 in

[PATCH 1/2] drm/radeon: Avoid overflows/divide-by-zero in latency_watermark calculations.

2017-04-23 Thread Mario Kleiner
rom dce-8 and si from dce-6, with a slightly simpler variant for evergreen dce-4/5. Only tested on DCE-4 evergreen with a Radeon HD-5770. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Alex Deucher <alexander.deuc...@amd.com> --- drivers/gpu/drm/radeon/c

Port of amdgpu watermark improvements to radeon-kms.

2017-04-23 Thread Mario Kleiner
Hi, a direct port of the patches we already have in amdgpu, for completeness. These are tested on an old HD-5770, DCE4 only. -mario ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] drm/amdgpu: Add missing lb_vblank_lead_lines setup to DCE-6 path.

2017-04-23 Thread Mario Kleiner
This apparently got lost when implementing the new DCE-6 support and would cause failures in pageflip scheduling and timestamping. Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: sta...@vger.kernel.org --- drivers/gpu/dr

Pageflip fixes for the amd dal/dc staging tree.

2017-04-21 Thread Mario Kleiner
Hi These two patches were written and tested against Harry's hwentland amd-staging-dc-drm-next branch from a few days ago. Not sure if that is the right one to base dal/dc patches against, but it looks recent and active enough? They fix pageflip scheduling to always flip at the right target

[PATCH 2/2] drm/amd/display: Prevent premature pageflip when comitting in vblank.

2017-04-21 Thread Mario Kleiner
ank event, which itself gets dispatched inside the vblank one frame before the target_msc vblank. Testing with this patch does no longer show any problems with OML_sync_control swap scheduling or flip completion timestamps. Tested on R9 380 Tonga. Signed-off-by: Mario Kleiner <mario.k

[PATCH 1/2] drm/amd/display: Fix race between vblank irq and pageflip irq.

2017-04-21 Thread Mario Kleiner
mdgpu_dm_do_flip(). Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> Cc: Harry Wentland <harry.wentl...@amd.com> Cc: Andrey Grodzovsky <andrey.grodzov...@amd.com> Cc: Alex Deucher <alexander.deuc...@amd.com> Cc: Michel Dänzer <michel.daen...@amd.com> --- drivers

[PATCH] drm/edid: Add 10 bpc quirk for LGD 764 panel in HP zBook 17 G2

2017-04-21 Thread Mario Kleiner
Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com> --- drivers/gpu/drm/drm_edid.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index fad3d44..2e55599 100644 --- a/drivers/gpu/drm/drm_edid.c +++ b/drivers/g

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-10 Thread Mario Kleiner
On 04/10/2017 08:11 PM, Keith Packard wrote: Mario Kleiner <mario.kleiner...@gmail.com> writes: as input from a highly interested future user of such api's: Thanks much for taking a look at this. My use cases run about 98% of the time in fullscreen exclusive mode and want as

Re: Proposal for RandR version 1.6, Leases and EDID-based output grabs

2017-04-10 Thread Mario Kleiner
On 04/04/2017 06:48 PM, Keith Packard wrote: Daniel Vetter writes: Yeah I think that's a pretty neat idea to reduce the lease complexity even more. If the VR compositor is unhappy and wants a different mode, it can simply nuke the lease and as for a new one. Forgot to say

[PATCH 1/2] drm/amdgpu: Make display watermark calculations more accurate

2017-03-29 Thread Mario Kleiner
Avoid big roundoff errors in scanline/hactive durations for high pixel clocks, especially for >= 500 Mhz, and thereby program more accurate display fifo watermarks. Implemented here for DCE 6,8,10,11. Successfully tested on DCE 10 with AMD R9 380 Tonga. Signed-off-by: Mario Klei

[PATCH 2/2] drm/amdgpu: Avoid overflows/divide-by-zero in latency_watermark calculations.

2017-03-29 Thread Mario Kleiner
happened, e.g., on AMD Tonga Pro under DCE-10, on a Displayport panel when trying to set a video mode of 2560x1440 at 165 Hz vrefresh with a dot clock of 635.540 Mhz. Refine calculations to avoid the overflows. Tested for DCE-10 with R9 380 Tonga + ASUS ROG PG279 panel. Signed-off-by: Mario

amdgpu fixes for display watermark calculations.

2017-03-29 Thread Mario Kleiner
Hi, attached two patches for amdgpu to improve the accuracy of display wm calculations, and to avoid some overflow and divide-by-zero errors which can cause the driver to die. Both are tested for the DCE-10 code path with a AMD R9 380 Tonga Pro on two different panels and their various modes.

Re: [PATCH] drm: Make the decision to keep vblank irq enabled earlier

2017-03-23 Thread Mario Kleiner
ntel.com> Cc: Daniel Vetter <dan...@ffwll.ch> Cc: Michel Dänzer <mic...@daenzer.net> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Cc: Dave Airlie <airl...@redhat.com>, Cc: Mario Kleiner <mario.kleiner...@gmail.com> --- drivers/gpu/drm/drm_irq.c | 18

Re: [PATCH 1/3] drm: Defer disabling the vblank IRQ until the next interrupt (for instant-off)

2017-03-22 Thread Mario Kleiner
following the wait completion. However, if the user is simply querying the current vblank counter and timestamp, the interrupt will be disabled after every IRQ and the user will enabled it again on the first query following the IRQ. v2: Mario Kleiner - After testing this, one more thing that would make

Re: [PATCH 2/2] drm/nouveau: Queue hpd_work on (runtime) resume

2017-01-23 Thread Mario Kleiner
On 11/21/2016 05:50 PM, Hans de Goede wrote: We need to call drm_helper_hpd_irq_event() on resume to properly detect monitor connection / disconnection on some laptops, use hpd_work for this to avoid deadlocks. Hi, this seems to introduce a hang of nouveau in 4.10-rc if the gpu is runtime

[PATCH] drm/nouveau/kms/nv50: Fix atomic pageflip events.

2016-11-23 Thread Mario Kleiner
-off-by: Mario Kleiner Cc: Ben Skeggs --- drivers/gpu/drm/nouveau/nv50_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c index a9855a4..ad9aedb 100644 --- a/drivers/gpu/drm/nouveau/nv50_display.c +++ b

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v5)

2016-11-09 Thread Mario Kleiner
from our exported bo. - Also switch to exclusive fence for prime imported bo's. v5: - Drop lret, instead use int ret -> long ret, as proposed by Christian. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95472 Tested-by: Mike Lothian (v1) Signed-off-by: Mario Kleiner Revie

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v4)

2016-11-08 Thread Mario Kleiner
from our exported bo. - Also switch to exclusive fence for prime imported bo's. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95472 Tested-by: Mike Lothian (v1) Signed-off-by: Mario Kleiner Cc: Christian König Cc: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu.h

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v3)

2016-11-07 Thread Mario Kleiner
On 11/07/2016 08:55 AM, Christian König wrote: > Am 07.11.2016 um 04:29 schrieb Michel Dänzer: >> On 07/11/16 11:47 AM, Mario Kleiner wrote: >>> External clients which import our bo's wait only >>> for exclusive dmabuf-fences, not on shared ones, >>>

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v3)

2016-11-07 Thread Mario Kleiner
://bugs.freedesktop.org/show_bug.cgi?id=95472 (v1) Tested-by: Mike Lothian Signed-off-by: Mario Kleiner Cc: Christian König Cc: Michel Dänzer --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_prime.c | 14

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v2)

2016-11-05 Thread Mario Kleiner
On 11/05/2016 01:06 PM, Christian König wrote: > Am 05.11.2016 um 01:56 schrieb Mario Kleiner: >> External clients which import our bo's wait only >> for exclusive dmabuf-fences, not on shared ones, >> so attach fences on such exported buffers as >> exclusive ones. >

[PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-11-05 Thread Mario Kleiner
On 10/28/2016 07:48 PM, Christian König wrote: > Am 28.10.2016 um 19:37 schrieb Mario Kleiner: >> >> >> On 10/28/2016 03:34 AM, Michel Dänzer wrote: >>> On 27/10/16 10:33 PM, Mike Lothian wrote: >>>> >>>> Just another gentle ping to see w

[PATCH] drm/amdgpu: Attach exclusive fence to prime exported bo's. (v2)

2016-11-05 Thread Mario Kleiner
as DRI3/Present Prime render offload, and with the Tonga standalone as primary gpu. v2: Add a wait for all shared fences before prime export, as suggested by Christian Koenig. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95472 (v1) Tested-by: Mike Lothian Signed-off-by: Mario

[PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-10-28 Thread Mario Kleiner
On 10/28/2016 03:34 AM, Michel Dänzer wrote: > On 27/10/16 10:33 PM, Mike Lothian wrote: >> >> Just another gentle ping to see where you are with this? > > I haven't got a chance to look into this any further. > > Fwiw., as a proof of concept, the attached experimental patch does work as

[PATCH 18/28] drm: avoid uninitialized timestamp use in wait_vblank

2016-10-18 Thread Mario Kleiner
unt; > unsigned int seq; > > - if (WARN_ON(pipe >= dev->num_crtcs)) > + if (WARN_ON(pipe >= dev->num_crtcs)) { > + *vblanktime = (struct timeval) { 0 }; > return 0; > + } > > do { > seq = read_seqbegin(>seqlock); > Looks good to me. Reviewed-by: Mario Kleiner -mario

[PATCH 4/6] drm/radeon: Provide page_flip_target hook

2016-09-17 Thread Mario Kleiner
Hi Michel, all your patches, both the already merged kernel bits in radeon/amdgpu and also all the userspace bits in libdrm/ati-ddx/amdgpu-ddx are all Reviewed-and-tested-by: Mario Kleiner I successfully tested with old/current userspace and the new userspace patches from your own libdrm/ati

[PATCH 2/2] drm/radeon: Prevent races on pre DCE4 between flip submission and completion.

2016-09-17 Thread Mario Kleiner
ere in vblank. Therefore delay the actual flip programming until after vblank on pre-AVIVO. Signed-off-by: Mario Kleiner --- drivers/gpu/drm/radeon/atombios_crtc.c | 4 ++-- drivers/gpu/drm/radeon/radeon_display.c | 17 ++--- drivers/gpu/drm/radeon/rv515.c | 3 ++- 3 fi

[PATCH 1/2] drm/radeon: Slightly more robust flip completion handling for < DCE-4

2016-09-17 Thread Mario Kleiner
threshold. This completion path is still prone to some races in corner cases, especially on pre-AVIVO hardware, so document them a bit better in the code comments. Signed-off-by: Mario Kleiner --- drivers/gpu/drm/radeon/radeon_display.c | 30 ++ 1 file changed, 22

Patches to go on top of Michels page_flip_target patches.

2016-09-17 Thread Mario Kleiner
Hi, testing on "simulated" pre-DCE4 radeon hw (via setting the module parameter radeon.use_pflipirq=0 to avoid use of pflip irqs) showed we need some adjustments on top of Michel's page_flip_target patches on these old asics. Patch 2/2: Essentially disabling the ability to flip anywhere in

[PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-09-08 Thread Mario Kleiner
On 09/08/2016 08:30 AM, Chris Wilson wrote: > On Thu, Sep 08, 2016 at 02:14:43AM +0200, Mario Kleiner wrote: >> amdgpu-kms uses shared fences for its prime exported dmabufs, >> instead of an exclusive fence. Therefore we need to wait for >> all fences of the dmabuf reservat

[PATCH] drm/i915: Before pageflip, also wait for shared dmabuf fences.

2016-09-08 Thread Mario Kleiner
-kms for correct prime sync during pageflipping under DRI3/Present. Should fix https://bugs.freedesktop.org/show_bug.cgi?id=95472 at least for page-flipped presentation. Suggested-by: Michel Dänzer Signed-off-by: Mario Kleiner Cc: Michel Dänzer Cc: Chris Wilson Cc: Daniel Vetter Cc: David

[PATCH] drm/atomic: Don't potentially reset color_mgmt_changed on successive property updates.

2016-08-27 Thread Mario Kleiner
property updates. Signed-off-by: Mario Kleiner Cc: Daniel Vetter Cc: # v4.6+ --- drivers/gpu/drm/drm_atomic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 8d2f111..3a985d6 100644 --- a/drivers/gpu/drm

"Fixes" for page flipping under PRIME on AMD & nouveau

2016-08-26 Thread Mario Kleiner
On 08/18/2016 09:21 PM, Marek Olšák wrote: > On Thu, Aug 18, 2016 at 4:23 AM, Michel Dänzer wrote: >> Maybe the rasterization as two triangles results in bad PCIe bandwidth >> utilization. Using the asynchronous DMA engine for these transfers would >> probably be ideal, but having the 3D

"Fixes" for page flipping under PRIME on AMD & nouveau

2016-08-26 Thread Mario Kleiner
On 08/18/2016 04:32 AM, Michel Dänzer wrote: > On 18/08/16 08:51 AM, Mario Kleiner wrote: >> >> That's what the ati-ddx/amdgpu-ddx does at the moment, as it detects the >> mismatch in tiling flags and uses the DRI3/Present copy path instead of >> the pageflip path. The

"Fixes" for page flipping under PRIME on AMD & nouveau

2016-08-26 Thread Mario Kleiner
To pick this up again after a week of manic testing :) On 08/18/2016 04:23 AM, Michel Dänzer wrote: > On 18/08/16 01:12 AM, Mario Kleiner wrote: >> >> Intel as display gpu + nouveau for render offload worked nicely >> on intel-ddx with page flipping, proper timing, dmabuf

  1   2   3   4   5   >