Re: [PATCH] drm/gamma: Clarify gamma lut uapi

2019-03-29 Thread Matt Roper
fect > rounding of 0x. > > Cc: Uma Shankar > Cc: Ville Syrjälä > Cc: Shashank Sharma > Cc: "Kumar, Kiran S" > Cc: Kausal Malladi > Cc: Lionel Landwerlin > Cc: Matt Roper > Cc: Rob Bradford > Cc: Daniel Stone > Cc: Stefan Schake > Cc: Eric

Re: [PATCH v6 1/3] drm: Add CRTC background color property (v5)

2019-02-26 Thread Matt Roper
On Tue, Feb 26, 2019 at 08:26:36AM +0100, Maarten Lankhorst wrote: > Hey, > > Op 21-02-2019 om 01:28 schreef Matt Roper: > > Some display controllers can be programmed to present non-black colors > > for pixels not covered by any plane (or pixels covered by the > > tr

[PATCH v6 0/3] CRTC background color

2019-02-20 Thread Matt Roper
. Matt Roper (3): drm: Add CRTC background color property (v5) drm/i915/gen9+: Add support for pipe background color (v6) drm/i915: Add background color hardware readout and state check drivers/gpu/drm/drm_atomic_uapi.c| 4 drivers/gpu/drm/drm_blend.c | 41

[PATCH v6 1/3] drm: Add CRTC background color property (v5)

2019-02-20 Thread Matt Roper
org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Cc: Sean Paul Cc: Brian Starkey Cc: Eric Anholt Cc: Stéphane Marchesin Cc: Daniel Vetter Signed-off-by: Matt Roper Reviewed-by(v2): Sean Paul Reviewed-by: Brian Starkey --- drivers/gpu/drm/drm_atomic_uapi.

[PATCH v6 3/3] drm/i915: Add background color hardware readout and state check

2019-02-20 Thread Matt Roper
the pipe color is already sanitized to full black as required by ABI, so the new readout here won't break that requirement. Suggested-by: Ville Syrjälä Cc: Ville Syrjälä Signed-off-by: Matt Roper Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 32

[PATCH v6 2/3] drm/i915/gen9+: Add support for pipe background color (v6)

2019-02-20 Thread Matt Roper
: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Signed-off-by: Matt Roper Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 9 + drivers/gpu/drm/i915/intel_color.c | 11 --- drivers/gpu/drm/i915/intel_display.c | 11 +++ 3 files

[PATCH] drm: Trivial comment grammar cleanups

2019-02-01 Thread Matt Roper
Most of these are just cases where code comments used contractions (it's, who's) where they actually mean to use a possessive pronoun (its, whose) or vice-versa. Signed-off-by: Matt Roper --- A couple of these were bugging me enough that I did a quick search for other similar mistakes in the DRM

Re: [Intel-gfx] [PATCH v4.1 0/3] CRTC background color

2019-02-01 Thread Matt Roper
On Fri, Feb 01, 2019 at 06:13:48PM +0100, Daniel Vetter wrote: > On Wed, Jan 30, 2019 at 03:48:50PM -0800, Matt Roper wrote: > > On Wed, Jan 30, 2019 at 09:57:10PM +0100, Daniel Vetter wrote: > > > On Wed, Jan 30, 2019 at 10:56:26AM -0800, Matt Roper wrote: > > > >

[PATCH v5 2/3] drm/i915/gen9+: Add support for pipe background color (v5)

2019-01-31 Thread Matt Roper
write. (Ville) - Minor parameter rename for consistency. (Ville) v4: - Removed use of bgcolor_changed flag. v5: - s/uint64_t/u64/ Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Signed-off-by: Matt Roper Reviewed-by: Ville Syrjälä

[PATCH v5 1/3] drm: Add CRTC background color property (v5)

2019-01-31 Thread Matt Roper
org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Cc: Sean Paul Cc: Brian Starkey Cc: Eric Anholt Cc: Stéphane Marchesin Cc: Daniel Vetter Signed-off-by: Matt Roper Reviewed-by(v2): Sean Paul Reviewed-by: Brian Starkey --- drivers/gpu/drm/drm_atomic_uapi.

Re: [PATCH v4.1 2/3] drm: Add CRTC background color property (v4)

2019-01-30 Thread Matt Roper
On Wed, Jan 30, 2019 at 11:01:25PM +0200, Ville Syrjälä wrote: > On Wed, Jan 30, 2019 at 10:51:21AM -0800, Matt Roper wrote: > > Some display controllers can be programmed to present non-black colors > > for pixels not covered by any plane (or pixels covered by the > >

Re: [Intel-gfx] [PATCH v4.1 0/3] CRTC background color

2019-01-30 Thread Matt Roper
On Wed, Jan 30, 2019 at 09:57:10PM +0100, Daniel Vetter wrote: > On Wed, Jan 30, 2019 at 10:56:26AM -0800, Matt Roper wrote: > > On Wed, Jan 30, 2019 at 10:51:19AM -0800, Matt Roper wrote: > > > Previous patch series was here: > > > > > > https://lists.fre

Re: [PATCH v4.1 0/3] CRTC background color

2019-01-30 Thread Matt Roper
On Wed, Jan 30, 2019 at 10:51:19AM -0800, Matt Roper wrote: > Previous patch series was here: > https://lists.freedesktop.org/archives/dri-devel/2018-December/201949.html > > I'm told the ChromeOS userspace code to make use of the background color > has been reviewed and i

[PATCH v4.1 2/3] drm: Add CRTC background color property (v4)

2019-01-30 Thread Matt Roper
writeback connectors are used (Brian Starkey / Eric Anholt) Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Cc: Sean Paul Cc: Brian Starkey Cc: Eric Anholt Cc: Stéphane Marchesin Cc: Daniel Vetter Signed-off-by: Matt Roper Reviewed-by(v2

[PATCH v4.1 3/3] drm/i915/gen9+: Add support for pipe background color (v4)

2019-01-30 Thread Matt Roper
write. (Ville) - Minor parameter rename for consistency. (Ville) v4: - Removed use of bgcolor_changed flag. Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_debugfs.c | 9

[PATCH v4.1 0/3] CRTC background color

2019-01-30 Thread Matt Roper
. Matt Roper (3): drm/i915: Force background color to black for gen9+ (v2) drm: Add CRTC background color property (v4) drm/i915/gen9+: Add support for pipe background color (v4) drivers/gpu/drm/drm_atomic_uapi.c| 4 drivers/gpu/drm/drm_blend.c | 27

[PATCH v4.1 1/3] drm/i915: Force background color to black for gen9+ (v2)

2019-01-30 Thread Matt Roper
transformations that a plane with black pixels would. v2: Rename register to SKL_BOTTOM_COLOR to more closely follow bspec naming. (Ville) Cc: Ville Syrjälä Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_reg.h | 6 ++ drivers/gpu/drm/i915/intel_display.c | 19

Re: [PATCH v4 1/2] drm: Add color management LUT validation helper (v4)

2019-01-23 Thread Matt Roper
On Sat, Jan 12, 2019 at 01:07:14PM +0100, Daniel Vetter wrote: > On Fri, Jan 11, 2019 at 02:27:00PM -0800, Matt Roper wrote: > > Dave, Daniel - any concerns if we merge this drm core patch through the > > Intel tree? The second patch in the series doesn't apply cleanly in &g

Re: [PATCH v4 1/2] drm: Add color management LUT validation helper (v4)

2019-01-11 Thread Matt Roper
Dave, Daniel - any concerns if we merge this drm core patch through the Intel tree? The second patch in the series doesn't apply cleanly in drm-misc-next. Matt On Mon, Dec 17, 2018 at 02:44:14PM -0800, Matt Roper wrote: > Some hardware may place additional restrictions on the gamma/dega

Re: [v4 10/12] drm/i915: Add HLG EOTF

2019-01-08 Thread Matt Roper
F_BT_2100_HLG, > }; > > struct hdmi_avi_infoframe { > -- > 1.9.1 > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Matt Roper Graphics Softwar

[PATCH v4 3/3] drm/i915/gen9+: Add support for pipe background color (v4)

2018-12-28 Thread Matt Roper
write. (Ville) - Minor parameter rename for consistency. (Ville) v4: - Removed use of bgcolor_changed flag. Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_debugfs.c | 9

[PATCH v4 2/3] drm: Add CRTC background color property (v4)

2018-12-28 Thread Matt Roper
writeback connectors are used (Brian Starkey / Eric Anholt) Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Cc: Sean Paul Cc: Brian Starkey Cc: Eric Anholt Cc: Stéphane Marchesin Cc: Daniel Vetter Signed-off-by: Matt Roper Reviewed-by(v2

[PATCH v4 0/3] CRTC background color

2018-12-28 Thread Matt Roper
, but I'm not sure what the status of that work is. Matt Roper (3): drm/i915: Force background color to black for gen9+ (v2) drm: Add CRTC background color property (v4) drm/i915/gen9+: Add support for pipe background color (v4) drivers/gpu/drm/drm_atomic_uapi.c| 4 drivers/gpu/drm

[PATCH v4 1/3] drm/i915: Force background color to black for gen9+ (v2)

2018-12-28 Thread Matt Roper
transformations that a plane with black pixels would. v2: Rename register to SKL_BOTTOM_COLOR to more closely follow bspec naming. (Ville) Cc: Ville Syrjälä Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_reg.h | 6 ++ drivers/gpu/drm/i915/intel_display.c | 19

Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color

2018-12-28 Thread Matt Roper
On Fri, Dec 28, 2018 at 06:14:40PM +0100, Daniel Vetter wrote: > On Fri, Dec 28, 2018 at 5:35 PM Matt Roper wrote: > > > > On Fri, Dec 28, 2018 at 12:53:29PM +0100, Daniel Vetter wrote: > > > Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin > > > geschrieben:

Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color

2018-12-28 Thread Matt Roper
On Fri, Dec 28, 2018 at 12:53:29PM +0100, Daniel Vetter wrote: > Am Fr., 28. Dez. 2018, 02:09 hat Stéphane Marchesin > geschrieben: > > On Thu, Dec 27, 2018 at 4:45 PM Matt Roper > > wrote: > > > > > > On Thu, Dec 27, 2018 at 04:22:28PM -0800, Stéphane Mar

Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color

2018-12-27 Thread Matt Roper
C > > ; dri-devel > > Subject: Re: [Intel-gfx] [PATCH v3 0/3] CRTC background color > > > > Hey, > > > > Is there anything missing on the Chrome side to move forward with this > > series? > > > > Stéphane > > > >

[PATCH v4 1/2] drm: Add color management LUT validation helper (v4)

2018-12-17 Thread Matt Roper
/DRM_COLOR_LUT_INCREASING/DRM_COLOR_LUT_NON_DECREASING/. (Ville) Cc: Uma Shankar Cc: Swati Sharma Cc: Brian Starkey Cc: Daniel Vetter Cc: Ville Syrjälä Signed-off-by: Matt Roper Reviewed-by(v1): Brian Starkey Reviewed-by: Alexandru Gheorghe Reviewed-by: Uma Shankar --- drivers/gpu/drm

[PATCH v4 2/2] drm/i915: Validate userspace-provided color management LUT's (v3)

2018-12-17 Thread Matt Roper
don't have any additional hardware constraints for that LUT. Cc: Uma Shankar Cc: Swati Sharma Signed-off-by: Matt Roper Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/intel_color.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_color.c b

[PATCH v3 1/2] drm: Add color management LUT validation helper (v3)

2018-12-14 Thread Matt Roper
ARM driver) v3: - Drop the LUT size check again since drm_atomic_replace_property_blob_from_id() already covers this for us. (Alexandru Gheorghe) Cc: Uma Shankar Cc: Swati Sharma Cc: Brian Starkey Signed-off-by: Matt Roper Reviewed-by(v1): Brian Starkey Reviewed-by: Alexandru

[PATCH v3 2/2] drm/i915: Validate userspace-provided color management LUT's (v3)

2018-12-14 Thread Matt Roper
don't have any additional hardware constraints for that LUT. Cc: Uma Shankar Cc: Swati Sharma Signed-off-by: Matt Roper Reviewed-By: Uma Shankar --- drivers/gpu/drm/i915/intel_color.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_color.c b

[PATCH v3 0/2] Add gamma/degamma LUT validation helper

2018-12-14 Thread Matt Roper
Previous version of the series was here: https://lists.freedesktop.org/archives/dri-devel/2018-December/200505.html The only change in this version is dropping the extra LUT size test I added in v2; Alexandru pointed out that that already gets tested when a new atomic blob is uploaded. Matt

Re: [PATCH v2 1/2] drm: Add color management LUT validation helper (v2)

2018-12-14 Thread Matt Roper
es, > > enum drm_color_encoding default_encoding, > > enum drm_color_range default_range); > > + > > +#define DRM_COLOR_LUT_EQUAL_CHANNELS BIT(0) > > +#define DRM_COLOR_LUT_INCREASING BIT(1) > > +int drm_color

[PATCH v2 0/2] Add gamma/degamma LUT validation helper

2018-12-13 Thread Matt Roper
the separate helpers into a single function that takes a bitmask of tests to apply. It also adds an additional LUT size test inspired by the ARM malidp driver. Matt Roper (2): drm: Add color management LUT validation helper (v2) drm/i915: Validate userspace-provided color management LUT's (v2

[PATCH v2 1/2] drm: Add color management LUT validation helper (v2)

2018-12-13 Thread Matt Roper
ARM driver) Cc: Uma Shankar Cc: Swati Sharma Cc: Brian Starkey Signed-off-by: Matt Roper Reviewed-by(v1): Brian Starkey --- drivers/gpu/drm/drm_color_mgmt.c | 64 include/drm/drm_color_mgmt.h | 5 2 files changed, 69 insertions(+) diff

[PATCH v2 2/2] drm/i915: Validate userspace-provided color management LUT's (v2)

2018-12-13 Thread Matt Roper
: - Use new API (single check function with bitmask of tests to apply) - Call helper for our gamma table as well (with no additional tests specified) so that the table size will be validated. Cc: Uma Shankar Cc: Swati Sharma Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_color.c | 19

[PATCH 2/2] drm/i915: Validate userspace-provided color management LUT's

2018-12-11 Thread Matt Roper
Shankar Cc: Swati Sharma Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/intel_color.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index 1d572e83db7f..041bb5d6a6cd 100644 --- a/drivers/gpu/drm

[PATCH 0/2] Add gamma/degamma LUT validation helpers

2018-12-11 Thread Matt Roper
degamma support for those two platforms hasn't landed yet, but there's work in flight by Uma and Swati to add it, so we might as well get the checks ready early). Matt Roper (2): drm: Add color management LUT validation helpers drm/i915: Validate userspace-provided color management LUT's drivers

[PATCH 1/2] drm: Add color management LUT validation helpers

2018-12-11 Thread Matt Roper
-provided LUT doesn't violate hardware requirements. Cc: Uma Shankar Cc: Swati Sharma Signed-off-by: Matt Roper --- drivers/gpu/drm/drm_color_mgmt.c | 53 include/drm/drm_color_mgmt.h | 3 +++ 2 files changed, 56 insertions(+) diff --git a/drivers/gpu

Re: [PATCH] drm/i915: Fix IGT kms_color/gamma subtest SKIP for GLK

2018-12-06 Thread Matt Roper
; /* Keep in gen based order, and chronological order within a gen */ > > -- > 1.9.1 > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel --

Re: [Intel-gfx] [PATCH RFC 2/5] cgroup: Add mechanism to register vendor specific DRM devices

2018-12-03 Thread Matt Roper
On Mon, Dec 03, 2018 at 06:46:01AM +, Ho, Kenny wrote: > Hey Matt, > > On Fri, Nov 30, 2018 at 5:22 PM Matt Roper wrote: > > I think Joonas is describing something closer in > > design to the cgroup-v2 "cpu" controller, which partitions the general > &g

Re: [Intel-gfx] [PATCH RFC 2/5] cgroup: Add mechanism to register vendor specific DRM devices

2018-11-30 Thread Matt Roper
t; > > Do what the intel driver or bpf is doing? It's not difficult to hook > > > > > into cgroup for identification purposes. > > > > > > > > > > Thanks. > > > > > > > > > > -- > > > > > teju

[PATCH v3 2/3] drm: Add CRTC background color property (v3)

2018-11-15 Thread Matt Roper
...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Cc: Sean Paul Signed-off-by: Matt Roper Reviewed-by(v2): Sean Paul --- drivers/gpu/drm/drm_atomic_state_helper.c | 1 + drivers/gpu/drm/drm_atomic_uapi.c | 5 + drivers/gpu/drm/drm_blend.c | 21

[PATCH v3 3/3] drm/i915/gen9+: Add support for pipe background color (v3)

2018-11-15 Thread Matt Roper
write. (Ville) - Minor parameter rename for consistency. (Ville) Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_debugfs.c | 9 + drivers/gpu/drm/i915/intel_display.c | 37

[PATCH v3 2/3] drm: Add CRTC background color property (v2)

2018-11-15 Thread Matt Roper
: harish.krupo@intel.com Cc: Ville Syrjälä Cc: Sean Paul Signed-off-by: Matt Roper Reviewed-by(v2): Sean Paul --- drivers/gpu/drm/drm_atomic_state_helper.c | 1 + drivers/gpu/drm/drm_atomic_uapi.c | 5 + drivers/gpu/drm/drm_blend.c | 21

[PATCH v3 0/3] CRTC background color

2018-11-15 Thread Matt Roper
patches still need to wait for opensource userspace to be ready before merging (there's ChromeOS work underway). Cc: dri-devel@lists.freedesktop.org Cc: Wei C Li Cc: Sean Paul Cc: Ville Syrjälä Matt Roper (3): drm/i915: Force background color to black for gen9+ (v2) drm: Add CRTC background

Re: [PATCH v2 2/3] drm: Add CRTC background color property (v2)

2018-11-14 Thread Matt Roper
On Wed, Nov 14, 2018 at 11:17:25AM -0500, Sean Paul wrote: > On Tue, Nov 13, 2018 at 03:21:48PM -0800, Matt Roper wrote: > > Some display controllers can be programmed to present non-black colors > > for pixels not covered by any plane (or pixels covered by the > > transpar

Re: [PATCH v2 2/3] drm: Add CRTC background color property (v2)

2018-11-14 Thread Matt Roper
On Wed, Nov 14, 2018 at 07:20:36PM +0200, Ville Syrjälä wrote: > On Tue, Nov 13, 2018 at 03:21:48PM -0800, Matt Roper wrote: ... > > > > +/* > > + * Put RGBA values into a standard 64-bit representation that can be used > > + * for ioctl parameters, inter

Re: [Intel-gfx] [RFC v5 2/8] drm: Add Plane Degamma properties

2018-11-13 Thread Matt Roper
m_property_blob *degamma_lut; > + > /** >* @commit: Tracks the pending commit to prevent use-after-free > conditions, >* and for async plane updates. > @@ -192,6 +200,8 @@ struct drm_plane_state { > > /** @state: backpointer to global drm_atomic_s

[PATCH v2 3/3] drm/i915/gen9+: Add support for pipe background color (v2)

2018-11-13 Thread Matt Roper
Cc: Ville Syrjälä Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_debugfs.c | 9 + drivers/gpu/drm/i915/intel_display.c | 35 --- 2 files changed, 37 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm

[PATCH v2 0/3] CRTC background color

2018-11-13 Thread Matt Roper
support for background color functionality, but I couldn't find the register layout details for that platform, so I haven't added support for it yet. Cc: dri-devel@lists.freedesktop.org Cc: Wei C Li Cc: Sean Paul Cc: Ville Syrjälä Matt Roper (3): drm/i915: Force background color to black for gen9

[PATCH v2 2/3] drm: Add CRTC background color property (v2)

2018-11-13 Thread Matt Roper
and value storage field. (Sean Paul) - Add a convenience function to attach property to a given crtc. Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Cc: Ville Syrjälä Cc: Sean Paul Signed-off-by: Matt Roper --- drivers/gpu/drm/drm_atomic_state_helper.c

Re: [Intel-gfx] [RFC v5 1/8] drm: Add Enhanced Gamma LUT precision structure

2018-11-05 Thread Matt Roper
ed; > +}; > + > #define DRM_MODE_PAGE_FLIP_EVENT 0x01 > #define DRM_MODE_PAGE_FLIP_ASYNC 0x02 > #define DRM_MODE_PAGE_FLIP_TARGET_ABSOLUTE 0x4 > -- > 1.9.1 > > ___ > Intel-gfx mailing list > intel-...@lists.freedesktop.org > https://

Re: [RFC] Generic cgroup controller for the gpu/drm subsystem

2018-11-01 Thread Matt Roper
+dri-devel list since a lot of the relevant audience is on that list. On Mon, Oct 29, 2018 at 07:49:13PM -0400, Kenny Ho wrote: > (Resending in plain text) > > Hi, > > We are thinking of using cgroup to manage resources in GPUs. I > believe Matt Roper from Intel has been tryi

Re: [PATCH v10 2/2] drm/i915: Adding YUV444 packed format support for skl+

2018-10-24 Thread Matt Roper
RMAT_YVYU, > > DRM_FORMAT_UYVY, > > DRM_FORMAT_VYUY, > > + DRM_FORMAT_XYUV, > > }; > > > > static uint32_t skl_planar_formats[] = { > > @@ -1279,6 +1280,7 @@ static uint32_t skl_planar_formats[] = { > > DRM_FORMAT_UYVY, > > DRM_FORMAT_VYUY, > > DRM_FORMAT_NV12, > > + DRM_FORMAT_XYUV, > > }; > > > > static const uint64_t skl_plane_format_modifiers_noccs[] = { > > @@ -1420,6 +1422,7 @@ static bool skl_plane_format_mod_supported(struct > > drm_plane *_plane, > > case DRM_FORMAT_UYVY: > > case DRM_FORMAT_VYUY: > > case DRM_FORMAT_NV12: > > + case DRM_FORMAT_XYUV: > > if (modifier == I915_FORMAT_MOD_Yf_TILED) > > return true; > > /* fall through */ > > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] drm: Add CRTC background color property

2018-10-10 Thread Matt Roper
in this standard format with varying component precision values. Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Signed-off-by: Matt Roper --- drivers/gpu/drm/drm_atomic_state_helper.c | 1 + drivers/gpu/drm/drm_atomic_uapi.c | 5 + drivers/gpu/drm

[PATCH 0/2] CRTC background color

2018-10-10 Thread Matt Roper
posted (and reviewed) somewhere public before we actually merge these kernel patches. Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Matt Roper (2): drm: Add CRTC background color property drm/i915/gen9+: Add support for pipe background color drivers

[PATCH 2/2] drm/i915/gen9+: Add support for pipe background color

2018-10-10 Thread Matt Roper
Gen9+ platforms allow CRTC's to be programmed with a background/canvas color below the programmable planes. Let's expose this for use by compositors. Cc: dri-devel@lists.freedesktop.org Cc: wei.c...@intel.com Cc: harish.krupo@intel.com Signed-off-by: Matt Roper --- drivers/gpu/drm/i915

Re: [PATCH] drm/i915: Add plane alpha blending support, v2.

2018-08-22 Thread Matt Roper
; Signed-off-by: Maarten Lankhorst One question and one minor suggestion inline below, but otherwise, Reviewed-by: Matt Roper > --- > drivers/gpu/drm/i915/i915_drv.h | 2 + > drivers/gpu/drm/i915/i915_reg.h | 2 + > drivers/gpu/drm/i915/intel_display.c | 58 ++

Re: [RfC PATCH] Add udmabuf misc device

2018-04-05 Thread Matt Roper
rts. > > > >> Overall I like the idea, but too lazy to review. > > > > Cool. General comments on the idea was all I was looking for for the > > moment. Spare yor review cycles for the next version ;) > > > >&g

Re: DRM cgroups integration (Was: Re: [PATCH v4 0/8] cgroup private data and DRM/i915 integration)

2018-04-05 Thread Matt Roper
Just realized Joonas had some other comments down at the bottom that I missed originally... On Thu, Apr 05, 2018 at 08:06:23AM -0700, Matt Roper wrote: > On Thu, Apr 05, 2018 at 07:49:44AM -0700, Matt Roper wrote: > > On Thu, Apr 05, 2018 at 05:15:13PM +0300, Joonas Lahtinen wrote: >

Re: DRM cgroups integration (Was: Re: [PATCH v4 0/8] cgroup private data and DRM/i915 integration)

2018-04-05 Thread Matt Roper
On Thu, Apr 05, 2018 at 07:49:44AM -0700, Matt Roper wrote: > On Thu, Apr 05, 2018 at 05:15:13PM +0300, Joonas Lahtinen wrote: > > + Some more Cc's based on IRC discussion > > > > Quoting Joonas Lahtinen (2018-04-05 16:46:51) > > > + Dave for commenting from DRM sub

Re: DRM cgroups integration (Was: Re: [PATCH v4 0/8] cgroup private data and DRM/i915 integration)

2018-04-05 Thread Matt Roper
a cgroup is important as well. Matt > > > > Quoting Matt Roper (2018-03-30 03:43:13) > > > On Mon, Mar 26, 2018 at 10:30:23AM +0300, Joonas Lahtinen wrote: > > > > Quoting Matt Roper (2018-03-23 17:46:16) > > > > > On Fri, Mar

Re: [PATCH v4 0/8] cgroup private data and DRM/i915 integration

2018-03-29 Thread Matt Roper
On Mon, Mar 26, 2018 at 10:30:23AM +0300, Joonas Lahtinen wrote: > Quoting Matt Roper (2018-03-23 17:46:16) > > On Fri, Mar 23, 2018 at 02:15:38PM +0200, Joonas Lahtinen wrote: > > > Quoting Matt Roper (2018-03-17 02:08:57) > > > > This is the fourth iteration of t

Re: [PATCH v4 0/8] cgroup private data and DRM/i915 integration

2018-03-23 Thread Matt Roper
On Fri, Mar 23, 2018 at 02:15:38PM +0200, Joonas Lahtinen wrote: > Quoting Matt Roper (2018-03-17 02:08:57) > > This is the fourth iteration of the work previously posted here: > > (v1) > > https://lists.freedesktop.org/archives/intel-gfx/2018-January/153156.html

[PATCH v4.5 7/8] drm/i915: Introduce per-cgroup display boost setting

2018-03-21 Thread Matt Roper
;ch...@chris-wilson.co.uk> Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_cgroup.c | 17 + drivers/gpu/drm/i915/i915_drv.h | 6 ++ drivers/gpu/drm/i915/i915_request.h | 1 + drivers/gpu/drm/i915/intel_display.c | 5 +++-- incl

[PATCH v4.5 6/8] drm/i915: Introduce 'priority offset' for GPU contexts (v4)

2018-03-21 Thread Matt Roper
- checkpatch warning fixes (Intel CI) Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_cgroup.c | 54 +++-- drivers/gpu/drm/i915/i915_drv.h | 7 + drivers/gpu/dr

[PATCH v4.5 8/8] drm/i915: Add context priority & priority offset to debugfs (v2)

2018-03-21 Thread Matt Roper
Update i915_context_status to include priority information. v2: - Clarify that the offset is based on cgroup (Chris) Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/dr

[PATCH v4.5 2/8] cgroup: Introduce task_get_dfl_cgroup() (v2)

2018-03-21 Thread Matt Roper
Wraps task_dfl_cgroup() to also take a reference to the cgroup. v2: - Eliminate cgroup_mutex and make lighter-weight (Tejun) Cc: Tejun Heo <t...@kernel.org> Cc: cgro...@vger.kernel.org Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- include/linux/c

[PATCH v4.5 3/8] cgroup: Introduce cgroup_priv_get_current

2018-03-21 Thread Matt Roper
Getting cgroup private data for the current process' cgroup is such a common pattern that we should add a convenience wrapper for it. Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- include/linux/cgroup.h | 1 + kernel/cgroup/cgroup.c | 23 +++ 2 files chang

[PATCH v4.5 1/8] cgroup: Allow registration and lookup of cgroup private data (v3)

2018-03-21 Thread Matt Roper
b.com> Cc: cgro...@vger.kernel.org Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> fixup! cgroup: Allow registration and lookup of cgroup private data (v2) --- include/linux/cgroup-defs.h | 10 +++ include/linux/cgroup.h | 7 ++ kernel/cg

[PATCH v4.5 5/8] drm/i915: cgroup integration (v4)

2018-03-21 Thread Matt Roper
: - Another rebase/rewrite for ida-based keys and kref-based storage - Access control no longer follows cgroup filesystem permissions; instead we restrict access to either DRM master or capable(CAP_SYS_RESOURCE). v4: - Fix checkpatch warnings (Intel CI) Signed-off-by: Matt Roper <matthew.d

[PATCH v4.5 4/8] drm/i915: Adjust internal priority definitions (v2)

2018-03-21 Thread Matt Roper
In preparation for adding cgroup-based priority adjustments, let's define the driver's priority values a little more clearly. v2: - checkpatch warning fix (Intel CI) Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/

[PATCH v4.5 0/8] cgroup private data and DRM/i915 integration

2018-03-21 Thread Matt Roper
://lists.freedesktop.org/archives/intel-gfx/2018-January/153156.html (v2) https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg208170.html (v3) https://lists.freedesktop.org/archives/intel-gfx/2018-March/157928.html (v4) https://lists.freedesktop.org/archives/intel-gfx/2018-March/159222.html Matt Roper (8

[PATCH v4 8/8] drm/i915: Add context priority & priority offset to debugfs (v2)

2018-03-16 Thread Matt Roper
Update i915_context_status to include priority information. v2: - Clarify that the offset is based on cgroup (Chris) Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/dr

[PATCH v4 7/8] drm/i915: Introduce per-cgroup display boost setting

2018-03-16 Thread Matt Roper
;ch...@chris-wilson.co.uk> Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_cgroup.c | 17 + drivers/gpu/drm/i915/i915_drv.h | 6 ++ drivers/gpu/drm/i915/i915_request.h | 1 + drivers/gpu/drm/i915/intel_display.c | 5 +++-- incl

[PATCH v4 2/8] cgroup: Introduce task_get_dfl_cgroup() (v2)

2018-03-16 Thread Matt Roper
Wraps task_dfl_cgroup() to also take a reference to the cgroup. v2: - Eliminate cgroup_mutex and make lighter-weight (Tejun) Cc: Tejun Heo <t...@kernel.org> Cc: cgro...@vger.kernel.org Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- include/linux/c

[PATCH v4 6/8] drm/i915: Introduce 'priority offset' for GPU contexts (v3)

2018-03-16 Thread Matt Roper
Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_cgroup.c | 52 +++-- drivers/gpu/drm/i915/i915_drv.h | 15 +- drivers/gpu/drm/i915/i915_gem_context.c | 7 ++

[PATCH v4 3/8] cgroup: Introduce cgroup_priv_get_current

2018-03-16 Thread Matt Roper
Getting cgroup private data for the current process' cgroup is such a common pattern that we should add a convenience wrapper for it. Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- include/linux/cgroup.h | 1 + kernel/cgroup/cgroup.c | 23 +++ 2 files chang

[PATCH v4 4/8] drm/i915: Adjust internal priority definitions

2018-03-16 Thread Matt Roper
In preparation for adding cgroup-based priority adjustments, let's define the driver's priority values a little more clearly. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/

[PATCH v4 5/8] drm/i915: cgroup integration (v3)

2018-03-16 Thread Matt Roper
: - Another rebase/rewrite for ida-based keys and kref-based storage - Access control no longer follows cgroup filesystem permissions; instead we restrict access to either DRM master or capable(CAP_SYS_RESOURCE). Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/dr

[PATCH v4 1/8] cgroup: Allow registration and lookup of cgroup private data (v2)

2018-03-16 Thread Matt Roper
- Private data is registered via kref, allowing a single private data structure to potentially be assigned to multiple cgroups. Cc: Tejun Heo <t...@kernel.org> Cc: Alexei Starovoitov <a...@fb.com> Cc: Roman Gushchin <g...@fb.com> Cc: cgro...@vger.kernel.org Signed-

[PATCH v4 0/8] cgroup private data and DRM/i915 integration

2018-03-16 Thread Matt Roper
b.com> Cc: Roman Gushchin <g...@fb.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Matt Roper (8): cgroup: Allow registration and lookup of cgroup private data (v2) cgroup: Introduce task_get_dfl_cgroup() (v2) cgroup: Introduce cgroup_priv_get_current drm/i915: Adjust inter

Re: [PATCH v3 5/6] drm/i915: Introduce 'priority offset' for GPU contexts (v2)

2018-03-08 Thread Matt Roper
On Thu, Mar 08, 2018 at 06:55:34PM +, Chris Wilson wrote: > Quoting Chris Wilson (2018-03-08 18:48:51) > > Quoting Matt Roper (2018-03-08 18:22:06) > > > * Option 2: Allow priority offset to be set in a much larger range > > >(e.g., [SHRT_MIN+1023,SHRT_MAX-1

Re: [PATCH v3 5/6] drm/i915: Introduce 'priority offset' for GPU contexts (v2)

2018-03-08 Thread Matt Roper
On Thu, Mar 08, 2018 at 01:11:33PM +, Chris Wilson wrote: > Quoting Chris Wilson (2018-03-08 11:32:04) > > Quoting Matt Roper (2018-03-06 23:46:59) > > > There are cases where a system integrator may wish to raise/lower the > > > priority of GPU workloads being submi

[PATCH v3 5/6] drm/i915: Introduce 'priority offset' for GPU contexts (v2)

2018-03-06 Thread Matt Roper
t to subtract priority offset in context_getparam ioctl to make it match setparam behavior. (Chris) Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_cgroup.c | 47 + drivers/gpu/drm/i915/i915_drv.h | 15 ++---

[PATCH v3 6/6] drm/i915: Add context priority & priority offset to debugfs (v2)

2018-03-06 Thread Matt Roper
Update i915_context_status to include priority information. v2: - Clarify that the offset is based on cgroup (Chris) Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/dr

[PATCH v3 1/6] cgroup: Allow registration and lookup of cgroup private data

2018-03-06 Thread Matt Roper
data. This function will be called automatically if the underlying cgroup is destroyed. Cc: Tejun Heo <t...@kernel.org> Cc: cgro...@vger.kernel.org Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- include/linux/cgroup-defs.h | 38 ++ include/linux/cgroup

[PATCH v3 3/6] cgroup: Introduce cgroup_permission()

2018-03-06 Thread Matt Roper
Non-controller kernel subsystems may base access restrictions for cgroup-related syscalls/ioctls on a process' access to the cgroup. Let's make it easy for other parts of the kernel to check these cgroup permissions. Cc: Tejun Heo <t...@kernel.org> Cc: cgro...@vger.kernel.org Signed-off-by

[PATCH v3 4/6] drm/i915: cgroup integration (v2)

2018-03-06 Thread Matt Roper
-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_cgroup.c | 167 + drivers/gpu/drm/i915/i915_drv.c| 5 ++ drivers/gpu/drm/i915/i915_drv.h| 24 ++ include/uapi/drm/i915

[PATCH v3 2/6] cgroup: Introduce task_get_dfl_cgroup()

2018-03-06 Thread Matt Roper
Wraps task_dfl_cgroup() to also take a reference to the cgroup. Cc: Tejun Heo <t...@kernel.org> Cc: cgro...@vger.kernel.org Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- include/linux/cgroup.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/i

[PATCH v3 0/6] DRM/i915 cgroup integration

2018-03-06 Thread Matt Roper
l, but that's intetional; the "real" userspace consumer of this work would usually be something like a sysv-init script or systemd recipe that would call that simple tool in an appropriate way to accomplish the desired policy for a specific system. Matt Roper (6): cgroup: Allow registrati

Re: [Intel-gfx] [IGT PATCH RFC] tools: Introduce intel_cgroup tool

2018-02-01 Thread Matt Roper
+cgroups list since this discussion goes back to the general design On Thu, Feb 01, 2018 at 08:27:33PM +, Chris Wilson wrote: > Quoting Matt Roper (2018-02-01 19:56:15) > > intel_cgroup is used to modify i915 cgroup parameters. At the moment only a > > single parameter is

Re: [Intel-gfx] [PATCH RFC v2 3/7] cgroup: Add interface to allow drivers to lookup process cgroup membership

2018-02-01 Thread Matt Roper
On Thu, Feb 01, 2018 at 08:49:32PM +, Chris Wilson wrote: > Quoting Matt Roper (2018-02-01 19:53:11) ... > > +struct cgroup * > > +cgroup_for_driver_process(struct pid *pid) > > +{ > > + struct task_struct *task = pid_task(pid, PIDTYPE_PID); > >

[IGT PATCH RFC] tools: Introduce intel_cgroup tool

2018-02-01 Thread Matt Roper
intel_cgroup is used to modify i915 cgroup parameters. At the moment only a single parameter is supported (GPU priority offset). In the future the driver may support additional parameters as well (e.g., limits on memory usage). Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> ---

[PATCH RFC v2 6/7] drm/i915: Introduce 'priority offset' for GPU contexts

2018-02-01 Thread Matt Roper
h a cgroup will only affect new context creation and will not alter the behavior of existing contexts previously created by the process. Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_cgroup.c | 46 + drivers/gpu/drm

[PATCH RFC v2 7/7] drm/i915: Add context priority & priority offset to debugfs

2018-02-01 Thread Matt Roper
Update i915_context_status to include priority information. Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/i915_debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c

[PATCH RFC v2 5/7] drm/i915: cgroup integration

2018-02-01 Thread Matt Roper
Register i915 as a consumer of the cgroup_driver framework and add an ioctl to allow userspace to set i915-specific parameters associated with cgroups. Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- drivers/gpu/drm/i915/Kconfig | 1 + drivers/gpu/drm/i915/Makefile

[PATCH RFC v2 4/7] drm: Add helper to obtain cgroup of drm_file's owning process

2018-02-01 Thread Matt Roper
Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- include/drm/drm_file.h| 20 kernel/cgroup/cgroup_driver.c | 12 ++-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_file.h b/include/drm/drm_file.h index 0e0c86

[PATCH RFC v2 2/7] kernfs: Export kernfs_get_inode

2018-02-01 Thread Matt Roper
Drivers may wish to access a cgroup's inode to perform permission checks on driver-specific operations. Cc: Tejun Heo <t...@kernel.org> Cc: cgro...@vger.kernel.org Signed-off-by: Matt Roper <matthew.d.ro...@intel.com> --- fs/kernfs/inode.c | 1 + 1 file changed, 1 insertion(+) dif

  1   2   3   4   >