[PATCH v14 08/10] drm: Expose modes with aspect ratio, only if requested

2018-05-08 Thread Nautiyal, Ankit K
From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regardless of whether user space requested this information or not. This patch: -prunes the modes with aspect-ratio

[PATCH v14 06/10] drm: Add DRM client cap for aspect-ratio

2018-05-08 Thread Nautiyal, Ankit K
From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing non-atomic user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a

[PATCH v14 05/10] video/hdmi: Reject illegal picture aspect ratios

2018-05-08 Thread Nautiyal, Ankit K
From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

[PATCH v14 07/10] drm: Handle aspect ratio info in legacy modeset path

2018-05-08 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v14 10/10] drm: Add and handle new aspect ratios in DRM layer

2018-05-08 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v14 09/10] drm: Add aspect ratio parsing in DRM layer

2018-05-08 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v14 03/10] drm/edid: Fix cea mode aspect ratio handling

2018-05-08 Thread Nautiyal, Ankit K
From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v14 04/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2018-05-08 Thread Nautiyal, Ankit K
From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[PATCH v14 02/10] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

2018-05-08 Thread Nautiyal, Ankit K
From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v14 00/10] Aspect ratio support in DRM layer

2018-05-08 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

[PATCH v14 01/10] drm/modes: Introduce drm_mode_match()

2018-05-08 Thread Nautiyal, Ankit K
From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

Re: [PATCH v13 08/10] drm: Expose modes with aspect ratio, only if requested

2018-05-07 Thread Nautiyal, Ankit K
On 5/7/2018 5:58 PM, Ville Syrjälä wrote: On Mon, May 07, 2018 at 10:34:53AM +0530, Nautiyal, Ankit K wrote: On 5/5/2018 1:49 AM, Ville Syrjälä wrote: On Thu, May 03, 2018 at 08:26:26AM +0200, Daniel Vetter wrote: On Wed, May 02, 2018 at 12:20:20PM +0530, Nautiyal, Ankit K wrote: From

Re: [PATCH v13 08/10] drm: Expose modes with aspect ratio, only if requested

2018-05-06 Thread Nautiyal, Ankit K
On 5/5/2018 1:49 AM, Ville Syrjälä wrote: On Thu, May 03, 2018 at 08:26:26AM +0200, Daniel Vetter wrote: On Wed, May 02, 2018 at 12:20:20PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> We parse the EDID and add all the modes in the connector's mo

[PATCH v13 10/10] drm: Add and handle new aspect ratios in DRM layer

2018-05-02 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v13 09/10] drm: Add aspect ratio parsing in DRM layer

2018-05-02 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v13 05/10] video/hdmi: Reject illegal picture aspect ratios

2018-05-02 Thread Nautiyal, Ankit K
From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

[PATCH v13 08/10] drm: Expose modes with aspect ratio, only if requested

2018-05-02 Thread Nautiyal, Ankit K
From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regardless of whether user space requested this information or not. This patch: -prunes the modes with aspect-ratio

[PATCH v13 00/10] Aspect ratio support in DRM layer

2018-05-02 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

[PATCH v13 07/10] drm: Handle aspect ratio info in legacy modeset path

2018-05-02 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v13 06/10] drm: Add DRM client cap for aspect-ratio

2018-05-02 Thread Nautiyal, Ankit K
From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing non-atomic user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a

[PATCH v13 04/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2018-05-02 Thread Nautiyal, Ankit K
From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[PATCH v13 02/10] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

2018-05-02 Thread Nautiyal, Ankit K
From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v13 03/10] drm/edid: Fix cea mode aspect ratio handling

2018-05-02 Thread Nautiyal, Ankit K
From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v13 01/10] drm/modes: Introduce drm_mode_match()

2018-05-02 Thread Nautiyal, Ankit K
From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

Re: [PATCH v12 08/10] drm: Expose modes with aspect ratio, only if requested

2018-04-30 Thread Nautiyal, Ankit K
On 4/27/2018 7:35 PM, Ville Syrjälä wrote: On Fri, Apr 27, 2018 at 05:44:54PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, reg

Re: [PATCH v12 07/10] drm: Handle aspect ratio info in legacy modeset path

2018-04-30 Thread Nautiyal, Ankit K
On 4/27/2018 7:24 PM, Ville Syrjälä wrote: On Fri, Apr 27, 2018 at 05:44:53PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the

[PATCH v12 10/10] drm: Add and handle new aspect ratios in DRM layer

2018-04-27 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v12 03/10] drm/edid: Fix cea mode aspect ratio handling

2018-04-27 Thread Nautiyal, Ankit K
From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v12 04/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2018-04-27 Thread Nautiyal, Ankit K
From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[PATCH v12 09/10] drm: Add aspect ratio parsing in DRM layer

2018-04-27 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v12 08/10] drm: Expose modes with aspect ratio, only if requested

2018-04-27 Thread Nautiyal, Ankit K
From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[PATCH v12 07/10] drm: Handle aspect ratio info in legacy modeset path

2018-04-27 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v12 00/10] Aspect ratio support in DRM layer

2018-04-27 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

[PATCH v12 01/10] drm/modes: Introduce drm_mode_match()

2018-04-27 Thread Nautiyal, Ankit K
From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[PATCH v12 05/10] video/hdmi: Reject illegal picture aspect ratios

2018-04-27 Thread Nautiyal, Ankit K
From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

[PATCH v12 06/10] drm: Add DRM client cap for aspect-ratio

2018-04-27 Thread Nautiyal, Ankit K
From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing non-atomic user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a

[PATCH v12 02/10] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

2018-04-27 Thread Nautiyal, Ankit K
From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

Re: [PATCH v11 07/11] drm: Add helper functions to handle aspect-ratio flag bits

2018-04-23 Thread Nautiyal, Ankit K
On 4/23/2018 3:43 PM, Ville Syrjälä wrote: On Mon, Apr 23, 2018 at 10:55:54AM +0530, Nautiyal, Ankit K wrote: On 4/20/2018 7:42 PM, Ville Syrjälä wrote: On Fri, Apr 20, 2018 at 07:01:47PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> This patc

Re: [PATCH v11 07/11] drm: Add helper functions to handle aspect-ratio flag bits

2018-04-23 Thread Nautiyal, Ankit K
On 4/23/2018 3:52 PM, Jani Nikula wrote: On Mon, 23 Apr 2018, "Nautiyal, Ankit K" <ankit.k.nauti...@intel.com> wrote: On 4/20/2018 7:42 PM, Ville Syrjälä wrote: On Fri, Apr 20, 2018 at 07:01:47PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti.

Re: [PATCH v11 09/11] drm: Expose modes with aspect ratio, only if requested

2018-04-22 Thread Nautiyal, Ankit K
On 4/20/2018 7:52 PM, Ville Syrjälä wrote: On Fri, Apr 20, 2018 at 07:01:49PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio informati

Re: [PATCH v11 07/11] drm: Add helper functions to handle aspect-ratio flag bits

2018-04-22 Thread Nautiyal, Ankit K
On 4/20/2018 7:42 PM, Ville Syrjälä wrote: On Fri, Apr 20, 2018 at 07:01:47PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> This patch adds helper functions for determining if aspect-ratio is expected in user-mode and for allowing/disallowing the

Re: [PATCH v11 06/11] drm: Add DRM client cap for aspect-ratio

2018-04-22 Thread Nautiyal, Ankit K
On 4/20/2018 7:37 PM, Ville Syrjälä wrote: On Fri, Apr 20, 2018 at 07:01:46PM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in ex

[PATCH v11 02/11] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

2018-04-20 Thread Nautiyal, Ankit K
From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v11 09/11] drm: Expose modes with aspect ratio, only if requested

2018-04-20 Thread Nautiyal, Ankit K
From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regardless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[PATCH v11 04/11] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2018-04-20 Thread Nautiyal, Ankit K
From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[PATCH v11 05/11] video/hdmi: Reject illegal picture aspect ratios

2018-04-20 Thread Nautiyal, Ankit K
From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

[PATCH v11 06/11] drm: Add DRM client cap for aspect-ratio

2018-04-20 Thread Nautiyal, Ankit K
From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm

[PATCH v11 11/11] drm: Add and handle new aspect ratios in DRM layer

2018-04-20 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v11 01/11] drm/modes: Introduce drm_mode_match()

2018-04-20 Thread Nautiyal, Ankit K
From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[PATCH v11 08/11] drm: Handle aspect ratio info in legacy and atomic modeset paths

2018-04-20 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v11 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-20 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v11 00/11] Aspect ratio support in DRM layer

2018-04-20 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

[PATCH v11 03/11] drm/edid: Fix cea mode aspect ratio handling

2018-04-20 Thread Nautiyal, Ankit K
From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v11 07/11] drm: Add helper functions to handle aspect-ratio flag bits

2018-04-20 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch adds helper functions for determining if aspect-ratio is expected in user-mode and for allowing/disallowing the aspect-ratio, if its not expected. Signed-off-by: Ankit Nautiyal ---

Re: [Intel-gfx] [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-18 Thread Nautiyal, Ankit K
On 4/17/2018 11:17 PM, Ville Syrjälä wrote: On Tue, Apr 17, 2018 at 10:45:07AM +0530, Nautiyal, Ankit K wrote: On 4/6/2018 11:14 PM, Ville Syrjälä wrote: On Fri, Apr 06, 2018 at 10:55:14PM +0530, Nautiyal, Ankit K wrote: This patch is causing failure of IGT test kms_3d. The kms_3d test

Re: [Intel-gfx] [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-16 Thread Nautiyal, Ankit K
On 4/6/2018 11:14 PM, Ville Syrjälä wrote: On Fri, Apr 06, 2018 at 10:55:14PM +0530, Nautiyal, Ankit K wrote: This patch is causing failure of IGT test kms_3d. The kms_3d test expects the no. of 3d modes to be 13. (The test has hard-coded value for expected no. of 3d modes as 13) But due

Re: [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-06 Thread Nautiyal, Ankit K
of modes in the connector modelist is increased by 2, resulting in failure of assertion 'mode_count==13'. Perhaps this need to be handled in the test. -Regards, Ankit On 4/6/2018 10:34 PM, Nautiyal, Ankit K wrote: From: "Sharma, Shashank" <shashank.sha...@intel.com> Current DRM layer fu

[PATCH v10 11/11] drm: Add and handle new aspect ratios in DRM layer

2018-04-06 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v10 07/11] drm: Add helper functions to handle aspect-ratio flag bits

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch adds helper functions for determining if aspect-ratio is expected in user-mode and for allowing/disallowing the aspect-ratio, if its not expected. Signed-off-by: Ankit Nautiyal ---

[PATCH v10 08/11] drm: Handle aspect ratio info in legacy and atomic modeset paths

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v10 09/11] drm: Expose modes with aspect ratio, only if requested

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-06 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v10 04/11] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[PATCH v10 06/11] drm: Add DRM client cap for aspect-ratio

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm

[PATCH v10 02/11] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v10 03/11] drm/edid: Fix cea mode aspect ratio handling

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v10 05/11] video/hdmi: Reject illegal picture aspect ratios

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

[PATCH v10 01/11] drm/modes: Introduce drm_mode_match()

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[PATCH v10 00/11] Aspect ratio support in DRM layer

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

[PATCH v9 06/11] drm: Add DRM client cap for aspect-ratio

2018-03-22 Thread Nautiyal, Ankit K
From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm

[PATCH v9 09/11] drm: Expose modes with aspect ratio, only if requested

2018-03-22 Thread Nautiyal, Ankit K
From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[PATCH v9 05/11] video/hdmi: Reject illegal picture aspect ratios

2018-03-22 Thread Nautiyal, Ankit K
From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

[PATCH v9 11/11] drm: Add and handle new aspect ratios in DRM layer

2018-03-22 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v9 01/11] drm/modes: Introduce drm_mode_match()

2018-03-22 Thread Nautiyal, Ankit K
From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[PATCH v9 00/11] Aspect ratio support in DRM layer

2018-03-22 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

[PATCH v9 04/11] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2018-03-22 Thread Nautiyal, Ankit K
From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[PATCH v9 08/11] drm: Handle aspect ratio info in legacy and atomic modeset paths

2018-03-22 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v9 03/11] drm/edid: Fix cea mode aspect ratio handling

2018-03-22 Thread Nautiyal, Ankit K
From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v9 10/11] drm: Add aspect ratio parsing in DRM layer

2018-03-22 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v9 07/11] drm: Handle aspect-ratio info in getblob

2018-03-22 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect-ratio information in the blob data. Currently for a given blob id, there is no way to determine if the blob stores

[PATCH v9 02/11] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

2018-03-22 Thread Nautiyal, Ankit K
From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v8 11/11] drm: Add and handle new aspect ratios in DRM layer

2018-03-14 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v8 10/11] drm: Add aspect ratio parsing in DRM layer

2018-03-14 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[PATCH v8 09/11] drm: Expose modes with aspect ratio, only if requested

2018-03-14 Thread Nautiyal, Ankit K
From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[PATCH v8 02/11] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

2018-03-14 Thread Nautiyal, Ankit K
From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[PATCH v8 07/11] drm: Handle aspect-ratio info in getblob

2018-03-14 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect-ratio information in the blob data. Currently for a given blob id, there is no way to determine if the blob stores

[PATCH v8 08/11] drm: Handle aspect ratio info in legacy and atomic modeset paths

2018-03-14 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v8 04/11] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2018-03-14 Thread Nautiyal, Ankit K
From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[PATCH v8 06/11] drm: Add DRM client cap for aspect-ratio

2018-03-14 Thread Nautiyal, Ankit K
From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm

[PATCH v8 05/11] video/hdmi: Reject illegal picture aspect ratios

2018-03-14 Thread Nautiyal, Ankit K
From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

[PATCH v8 03/11] drm/edid: Fix cea mode aspect ratio handling

2018-03-14 Thread Nautiyal, Ankit K
From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[PATCH v8 01/11] drm/modes: Introduce drm_mode_match()

2018-03-14 Thread Nautiyal, Ankit K
From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[PATCH v8 00/11] Aspect ratio support in DRM layer

2018-03-14 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

Re: [PATCH v7 5/9] drm: Handle aspect-ratio info in getblob

2018-03-12 Thread Nautiyal, Ankit K
On 3/9/2018 6:40 PM, Ville Syrjälä wrote: On Fri, Mar 09, 2018 at 11:07:14AM +0530, Nautiyal, Ankit K wrote: From: Ankit Nautiyal <ankit.k.nauti...@intel.com> If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect

[PATCH v7 5/9] drm: Handle aspect-ratio info in getblob

2018-03-08 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect-ratio information in the blob data. Currently for a given blob id, there is no way to determine if the blob stores

[PATCH v6 9/9] drm: Add and handle new aspect ratios in DRM layer

2018-03-06 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[PATCH v6 5/9] drm: Handle aspect-ratio info in getblob

2018-03-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, then getblob called with the blob id of a user-mode, should clear the aspect-ratio information in the blob data. Currently for a given blob id, there is no way to determine if the blob stores

[PATCH v6 7/9] drm: Expose modes with aspect ratio, only if requested

2018-03-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[PATCH v6 6/9] drm: Handle aspect ratio info in legacy and atomic modeset paths

2018-03-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[PATCH v6 8/9] drm: Add aspect ratio parsing in DRM layer

2018-03-06 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

  1   2   >