Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Robert Foss
Hey, On 3/18/19 2:11 PM, Mauro Rossi wrote: Hi, On Mon, Mar 18, 2019 at 10:58 AM Robert Foss wrote: Hey Mauro, On 3/18/19 9:38 AM, Mauro Rossi wrote: Hi Robert, On Mon, Mar 18, 2019 at 9:21 AM Robert Foss wrote: On a second note, this does not apply on libdrm/master due

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Robert Foss
Hey Mauro, On 3/18/19 9:38 AM, Mauro Rossi wrote: Hi Robert, On Mon, Mar 18, 2019 at 9:21 AM Robert Foss wrote: On a second note, this does not apply on libdrm/master due to: LOCAL_SHARED_LIBRARIES := \ libcutils Sorry, we have an additional Google patch, not present in libdrm

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Robert Foss
On a second note, this does not apply on libdrm/master due to: LOCAL_SHARED_LIBRARIES := \ libcutils My thinking is that libcutils probably can be replaced with liblog, but I'm not 100% sure. Rob. On 3/18/19 9:09 AM, Robert Foss wrote: This is probably a good idea! Reviewed

Re: [PATCH] android: libdrm_platform: add liblog shared dependency

2019-03-18 Thread Robert Foss
This is probably a good idea! Reviewed-by: Robert Foss On 3/17/19 9:54 PM, Mauro Rossi wrote: Hi, I used the option --subject-prefix="PATCH libdrm" but it did not go as expected. Anyway, the patch is for Android build of mesa/drm Mauro On Sun, Mar 17, 2019 at 9:50 PM Mauro Ro

Re: [PATCH] virtgpu: Update kernel header

2019-03-04 Thread Robert Foss
Hey Gurchetan, Thanks for sending this in! Reviewed-by: Robert Foss On 2/28/19 1:52 AM, Gurchetan Singh wrote: Generated using make headers_install. This brings in the in/out fence support for explicit synchronization. v2: don't use experimental kernel branch Signed-off-by: Gurchetan

Re: [Bug 109060] android-x86 64bit builds crashes due to android/gralloc_handle.h

2018-12-18 Thread Robert Foss
Hey Chih-Wei & Mauro, This fix looks good to me. Cleaned up patch name and pushed to repo. Rob. On 2018-12-14 01:05, bugzilla-dae...@freedesktop.org wrote: Bug ID 109060 Summary android-x86 64bit builds crashes due to

Re: [RESEND PATCH v3] drm/msm: Move fence put to where failure occurs

2018-12-05 Thread Robert Foss
On 2018-12-04 21:21, Rob Clark wrote: On Tue, Dec 4, 2018 at 11:56 AM Robert Foss wrote: If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss

[RESEND PATCH v3] drm/msm: Move fence put to where failure occurs

2018-12-04 Thread Robert Foss
If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss Reviewed-by: Chris Wilson Cc: sta...@vger.kernel.org --- drivers/gpu/drm/msm/msm_gem_submit.c

Re: [PATCH 0/2] drm/virtio: fence cleanups

2018-11-28 Thread Robert Foss
Hey Gerd, I was looking at making these changes too, thanks for submitting this. This series has been: Reviewed-by: Robert Foss Rob. On 2018-11-28 16:10, Gerd Hoffmann wrote: Gerd Hoffmann (2): drm/virtio: fence: pass plain pointer drm/virtio: virtio_gpu_cmd_resource_create_3d

Re: [PATCH v3] drm/msm: Move fence put to where failure occurs

2018-11-15 Thread Robert Foss
Hey, I think this patch is ready for inclusion. Rob. On 2018-11-05 11:13, Robert Foss wrote: If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert

[PATCH v5 2/4] drm/virtio: add uapi for in and out explicit fences

2018-11-12 Thread Robert Foss
passing an in-fence fd. * VIRTGPU_EXECBUF_FENCE_FD_OUT to be used when requesting an out-fence fd The execbuffer IOCTL is now read-write to allow the userspace to read the out-fence. On error -1 should be returned in the fence_fd field. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss

[PATCH v5 4/4] drm/virtio: bump driver version after explicit synchronization addition

2018-11-12 Thread Robert Foss
From: Gustavo Padovan To reflect the (backward compatible) changes in the uabi we are bumping the driver's version. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Reviewed-by: Emil Velikov --- Changes since v3: - Emil: Added r-b drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- 1

[PATCH v5 1/4] drm/virtio: add virtio_gpu_alloc_fence()

2018-11-12 Thread Robert Foss
. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring --- Changes since v3: - Gerd: Clarified and extended commit message - Emil: Fixed whitespace issue - Emil: Changed label name from fail_fence to fail_backoff - Emil: Remove special case for !fence->

[PATCH v5 0/4] virgl: fence fd support

2018-11-12 Thread Robert Foss
plicit synchronization Gustavo Padovan (1): drm/virtio: bump driver version after explicit synchronization addition Robert Foss (3): drm/virtio: add virtio_gpu_alloc_fence() drm/virtio: add uapi for in and out explicit fences drm/virtio: add in/out fence support for explicit synchroni

[PATCH v5 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Robert Foss
is returned to userspace. VIRTGPU_EXECBUF_FENCE_FD_IN & VIRTGPU_EXECBUF_FENCE_FD_OUT are supported at the simultaneously and can be flagged for simultaneously. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring Reviewed-by: Emil Velikov --- Changes sinc

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Robert Foss
On 2018-11-12 12:11, Gerd Hoffmann wrote: On Mon, Nov 12, 2018 at 11:30:57AM +0100, Robert Foss wrote: Hey Gerd On 2018-11-12 10:10, Gerd Hoffmann wrote: On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-12 Thread Robert Foss
Hey Gerd On 2018-11-12 10:10, Gerd Hoffmann wrote: On Fri, Nov 09, 2018 at 06:13:52PM +0100, Robert Foss wrote: Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-09 Thread Robert Foss
Hey Gerd, On 2018-11-09 11:13, Gerd Hoffmann wrote: On Mon, Nov 05, 2018 at 05:25:05PM +, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting

Re: [PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-05 Thread Robert Foss
Heya, On 2018-11-05 18:25, Emil Velikov wrote: On Mon, 5 Nov 2018 at 11:42, Robert Foss wrote: When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting the draw call. On the out-fence side we get fence returned

[PATCH v4 2/4] drm/virtio: add uapi for in and out explicit fences

2018-11-05 Thread Robert Foss
passing an in-fence fd. * VIRTGPU_EXECBUF_FENCE_FD_OUT to be used when requesting an out-fence fd The execbuffer IOCTL is now read-write to allow the userspace to read the out-fence. On error -1 should be returned in the fence_fd field. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss

[PATCH v4 0/4] virgl: fence fd support

2018-11-05 Thread Robert Foss
fix compilation issues - drm/virtio: add uapi for in and out explicit fences - Check exbuf->flags for unsupported flags - drm/virtio: add in-fences support for explicit synchronization Gustavo Padovan (1): drm/virtio: bump driver version after explicit synchronization addition Robert F

[PATCH v4 1/4] drm/virtio: add virtio_gpu_alloc_fence()

2018-11-05 Thread Robert Foss
. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring --- Changes since v3: - Gerd: Clarified and extended commit message - Emil: Fixed whitespace issue - Emil: Changed label name from fail_fence to fail_backoff - Emil: Remove special case for !fence->

[PATCH v4 4/4] drm/virtio: bump driver version after explicit synchronization addition

2018-11-05 Thread Robert Foss
From: Gustavo Padovan To reflect the (backward compatible) changes in the uabi we are bumping the driver's version. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Reviewed-by: Emil Velikov --- Changes since v3: - Emil: Added r-b drivers/gpu/drm/virtio/virtgpu_drv.h | 4

[PATCH v4 3/4] drm/virtio: add in/out fence support for explicit synchronization

2018-11-05 Thread Robert Foss
is returned to userspace. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring Reviewed-by: Emil Velikov --- Changes since v3: - Move all in_fence handling to the same VIRTGPU_EXECBUF_FENCE_FD_IN block - Emil: Make sure to always call dma_fence_put() - Emil

[PATCH v3] drm/msm: Move fence put to where failure occurs

2018-11-05 Thread Robert Foss
If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss Reviewed-by: Chris Wilson Cc: sta...@vger.kernel.org --- Changes since v2: - Chris Wilson

Re: [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences

2018-11-02 Thread Robert Foss
Hey Emil, On 2018-11-02 14:34, Emil Velikov wrote: On Thu, 1 Nov 2018 at 12:56, Robert Foss wrote: On 2018-10-31 10:38, Emil Velikov wrote: Hi Rob, On Thu, 25 Oct 2018 at 19:38, Robert Foss wrote: Add a new field called fence_fd that will be used by userspace to send in-fences

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Robert Foss
Hey Chris, On 2018-11-02 13:16, Chris Wilson wrote: Quoting Robert Foss (2018-11-02 12:13:13) If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss

Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Robert Foss
+stable On 2018-11-02 13:13, Robert Foss wrote: If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss --- Changes since v1: - Chris Wilson: Make

[PATCH v2] drm/msm: Move fence put to where failure occurs

2018-11-02 Thread Robert Foss
If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss --- Changes since v1: - Chris Wilson: Make sure that dma_fence_put() is always executed

Re: [PATCH v1] drm/msm: Move fence put to where failure occurs

2018-11-01 Thread Robert Foss
Hey Chris, On 2018-11-01 17:26, Chris Wilson wrote: Quoting Robert Foss (2018-11-01 16:12:28) If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss

[PATCH v1] drm/msm: Move fence put to where failure occurs

2018-11-01 Thread Robert Foss
If dma_fence_wait fails to wait for a supplied in-fence in msm_ioctl_gem_submit, make sure we release that in-fence. Also remove this dma_fence_put() from the 'out' label. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/msm_gem_submit.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [PATCH 2/5] drm/virtio: add uapi for in and out explicit fences

2018-11-01 Thread Robert Foss
On 2018-10-31 10:38, Emil Velikov wrote: Hi Rob, On Thu, 25 Oct 2018 at 19:38, Robert Foss wrote: Add a new field called fence_fd that will be used by userspace to send in-fences to the kernel and receive out-fences created by the kernel. This uapi enables virtio to take advantage

Re: [PATCH 1/5] drm/virtio: add virtio_gpu_alloc_fence()

2018-11-01 Thread Robert Foss
Hey Emil, On 2018-10-31 10:38, Emil Velikov wrote: Hi Rob, On Thu, 25 Oct 2018 at 19:38, Robert Foss wrote: From: Gustavo Padovan Refactor fence creation to remove the potential allocation failure from the cmd_submit and atomic_commit paths. Now the fence should be allocated first

[PATCH 3/5] drm/virtio: add in-fences support for explicit synchronization

2018-10-25 Thread Robert Foss
From: Gustavo Padovan When the execbuf call receives an in-fence it will get the dma_fence related to that fence fd and wait on it before submitting the draw call. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring --- drivers/gpu/drm/virtio/virtgpu_ioctl.c

[PATCH 1/5] drm/virtio: add virtio_gpu_alloc_fence()

2018-10-25 Thread Robert Foss
From: Gustavo Padovan Refactor fence creation to remove the potential allocation failure from the cmd_submit and atomic_commit paths. Now the fence should be allocated first and just after we should proceed with the rest of the execution. Signed-off-by: Gustavo Padovan Signed-off-by: Robert

[PATCH 5/5] drm/virtio: bump driver version after explicit synchronization addition

2018-10-25 Thread Robert Foss
From: Gustavo Padovan To reflect the (backward compatible) changes in the uabi we are bumping the driver's version. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 4/5] drm/virtio: add out-fences support for explicit synchronization

2018-10-25 Thread Robert Foss
From: Gustavo Padovan On the out-fence side we get fence returned by the submitted draw call and attach it to a sync_file and send the sync_file fd to userspace. On error -1 is returned to userspace. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss Suggested-by: Rob Herring

[PATCH 0/5] virgl: fence fd support

2018-10-25 Thread Robert Foss
out-fences support for explicit synchronization drm/virtio: bump driver version after explicit synchronization addition Robert Foss (1): drm/virtio: add uapi for in and out explicit fences drivers/gpu/drm/virtio/virtgpu_drv.h | 22 +++-- drivers/gpu/drm/virtio/virtgpu_fence.c |

[PATCH 2/5] drm/virtio: add uapi for in and out explicit fences

2018-10-25 Thread Robert Foss
passing an in-fence fd. * VIRTGPU_EXECBUF_FENCE_FD_OUT to be used when requesting an out-fence fd The execbuffer IOCTL is now read-write to allow the userspace to read the out-fence. On error -1 should be returned in the fence_fd field. Signed-off-by: Gustavo Padovan Signed-off-by: Robert Foss

[RFC] drm: Allow DRM_IOCTL_MODE_MAP_DUMB for render nodes

2018-07-24 Thread Robert Foss
simplifies the stack. Signed-off-by: Tomasz Figa Reviewed-by: Zach Reizner Signed-off-by: Nicolas Norvez Reviewed-by: Tomasz Figa Signed-off-by: Robert Foss --- I've been looking into enabling a kms_swrast based driver for mesa on the Android platform[1]. But have come up against the issue

Re: [PATCH libdrm v2 04/10] xf86drm: Allocate drmDevicePtr's on stack

2018-06-29 Thread Robert Foss
to simplify the error handling and even shed a few bytes off the final binary. v2: - add a define & description behind the magic 256 (Rob) - report error to strerr and skip when over 256 device nodes (Rob) Cc: Robert Foss Signed-off-by: Emil Velikov Tested-by: Robert Foss (v1) Revi

Re: [PATCH libdrm 10/10] drmdevice: print the correct host1x information

2018-06-28 Thread Robert Foss
Nice catch! Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov While fairly close, the host1x and platform are two separate things. Signed-off-by: Emil Velikov --- tests/drmdevice.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH libdrm 09/10] drmdevice: convert the tabbed output into a tree

2018-06-28 Thread Robert Foss
Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Making the output a little bit easier to parse by human beings. Signed-off-by: Emil Velikov --- tests/drmdevice.c | 78 +++ 1 file changed, 39

Re: [PATCH libdrm 08/10] tests/drmdevice: add a couple of printf headers

2018-06-28 Thread Robert Foss
Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Add a few printf statements, which should make the output easier to parse. Signed-off-by: Emil Velikov --- tests/drmdevice.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

Re: [PATCH libdrm 07/10] tests/drmdevices: install alongside other utilities

2018-06-28 Thread Robert Foss
Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov It's mildly useful program, to ship it when the user wants the "tests" installed. Obviously the "tests" in the name is a misnomer. Signed-off-by: Emil Velikov --- tests/Makefile.am | 9

Re: [PATCH libdrm 06/10] xf86drm: Add drmDevice support for virtio_gpu

2018-06-28 Thread Robert Foss
Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov The GPU almost exclusively lives on the PCI bus, so we expose it as a normal PCI one. This allows any existing drmDevice users to work without any changes. One could wonder why a separate

Re: [PATCH libdrm 05/10] xf86drm: introduce a get_real_pci_path() helper

2018-06-28 Thread Robert Foss
Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Introduce a helper which gets the real sysfs path for the given pci device. In other words, instead opening the /sys/dev/char/*/device symlink, we opt for the actual /sys/devices/pci*/*/ It

Re: [PATCH libdrm 04/10] xf86drm: Allocate drmDevicePtr's on stack

2018-06-28 Thread Robert Foss
Hey Emil, On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Currently we dynamically allocate 16 pointers and reallocate more as needed. Instead, allocate the maximum number (256) on stack - the number is small enough and is unlikely to change in the foreseeable future. This

Re: [PATCH libdrm 03/10] xf86drm: Fold drmDevice processing into process_device() helper

2018-06-28 Thread Robert Foss
Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Don't the duplicate (nearly) identical code across the two call sites. It improves legibility and the diff stat seems nice. Signed-off-by: Emil Velikov --- xf86drm.c | 159

Re: [PATCH libdrm 02/10] xf86drm: introduce drm_device_has_rdev() helper

2018-06-28 Thread Robert Foss
Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Currently we match the opened drmDevice fd with each drmDevice we process. Move that after all the devices are processed and folded, via the drm_device_has_rdev(). This makes the code easier to

Re: [PATCH libdrm 01/10] xf86drm: drmGetDevice2: error out if the fd has unknown subsys

2018-06-28 Thread Robert Foss
Feel free to add my r-b to this patch. On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Currently one can open() any /dev node. If it's unknown drmParseSubsystemType() will return an error. Track that and bail as needed. Signed-off-by: Emil Velikov --- xf86drm.c | 2 ++ 1

Re: [PATCH libdrm 01/10] xf86drm: drmGetDevice2: error out if the fd has unknown subsys

2018-06-28 Thread Robert Foss
This series has been: Tested-by: Robert Foss On 2018-06-25 19:36, Emil Velikov wrote: From: Emil Velikov Currently one can open() any /dev node. If it's unknown drmParseSubsystemType() will return an error. Track that and bail as needed. Signed-off-by: Emil Velikov --- xf86drm.c | 2

Re: [drm_hwc] PSA: drm_hwc submissions via gitlab

2018-05-04 Thread Robert Foss
Heya, On 2018-05-04 12:51, Daniel Stone wrote: Hi, On 3 May 2018 at 20:12, Sean Paul wrote: On Thu, May 03, 2018 at 08:30:18PM +0200, Daniel Vetter wrote: On Thu, May 3, 2018 at 5:04 PM, Sean Paul wrote: If you're still reading, I'll point out

Re: [drm_hwc] PSA: drm_hwc submissions via gitlab

2018-05-04 Thread Robert Foss
Hey Sean, On 2018-05-03 17:04, Sean Paul wrote: Hey all, Apologies for the direct ping. I've harvested your emails from drm_hwc git logs, and didn't want to leave anyone out. The good news is that your email address will forever be remembered in the annals of drm_hwcomposer! Anyways, back to

Re: [PATCH v1] xf86drm: Add drmHandleMatch func

2018-04-30 Thread Robert Foss
Hey Emil, On 27.04.2018 15:48, Emil Velikov wrote: On 27 April 2018 at 12:31, Robert Foss <robert.f...@collabora.com> wrote: drmHandleMatch is intended to allow for userspace to filter out devices that it does not want to open. Opening specific devices using paths alone is not a reliab

Re: [PATCH hwc 4/4] drm_hwcomposer: Fall back to client compositon if the gl precompostior fails

2018-04-27 Thread Robert Foss
This patch is: Acked-by: Robert Foss <robert.f...@collabora.com> I'll push this series upstream in a few minutes. On 04/26/2018 09:05 PM, John Stultz wrote: If the gl precompositor isn't being used, we cannot accept every layer as a device composited layer. Thus this patch adds some

[PATCH v1] xf86drm: Add drmHandleMatch func

2018-04-27 Thread Robert Foss
filter based on anything. But for the sake of convenience a few other simple filters have been included. If the function pointer filter ends up being called with a boilerplate fp by mutliple libdrm users, perhaps that funtion could be moved into libdrm at a future date. Signed-off-by: Robert Foss

Re: [PATCH hwc 3/4] drm_hwcomposer: Cleanup gl precompositor init and provide uses_GL flag

2018-04-26 Thread Robert Foss
This patch is: Acked-by: Robert Foss <robert.f...@collabora.com> On 04/26/2018 09:05 PM, John Stultz wrote: The drm_hwcomposer has its own GL pre-compositor which is used to squish layers when there are more layers then planes on the display hardware. In many ways this duplicates the

Re: [PATCH hwc 2/4] drm_hwcomposer: Use log/log.h instead of cutils/log.h

2018-04-26 Thread Robert Foss
This patch is: Acked-by: Robert Foss <robert.f...@collabora.com> On 04/26/2018 09:05 PM, John Stultz wrote: When enabling Treble, Android builds are complaining about using cutils/log.h so instead use log/log.h Cc: Marissa Wall <maris...@google.com> Cc: Sean Paul <seanp...

Re: [PATCH hwc 1/4] drm_hwcomposer: Andorid.mk : Mark libdrmhwc_utils as vendor module

2018-04-26 Thread Robert Foss
This patch is: Acked-by: Robert Foss <robert.f...@collabora.com> On 04/26/2018 09:05 PM, John Stultz wrote: From: Sumit Semwal <sumit.sem...@linaro.org> To allow drm_hwcomposer to build with Treble, set the libdrmhwc_utils library as a vendor module. Cc: Marissa Wall <maris...

Re: [PATCH hwc v2 04/18] drm_hwcomposer: Add resource manager class

2018-04-18 Thread Robert Foss
On 04/18/2018 12:12 PM, Alexandru-Cosmin Gheorghe wrote: On Tue, Apr 17, 2018 at 06:08:06PM +0200, Robert Foss wrote: Hey, On 04/17/2018 05:33 PM, Sean Paul wrote: On Wed, Apr 11, 2018 at 04:22:15PM +0100, Alexandru Gheorghe wrote: Add a resource manager object that is responsible

Re: [PATCH hwc v2 04/18] drm_hwcomposer: Add resource manager class

2018-04-17 Thread Robert Foss
Hey, On 04/17/2018 05:33 PM, Sean Paul wrote: On Wed, Apr 11, 2018 at 04:22:15PM +0100, Alexandru Gheorghe wrote: Add a resource manager object that is responsible for detecting all kms devices and allocates unique display numbers for every detected display. This is controlled by the value of

Re: [PATCH hwc v2 03/18] drm_hwcomposer: drmeventlistener: Set nl_pid to 0

2018-04-16 Thread Robert Foss
Hey Alexandru, Feel free to add my SoB to this patch: Signed-off-by: Robert Foss <robert.f...@collabora.com> Rob. On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote: By setting nl_pid to 0, we let the kernel to assign a port for us. In the current implementation there is no way we could

Re: [PATCH hwc v2 02/18] drm_hwcomposer: vsyncworker: Fix deadlock on exit path

2018-04-16 Thread Robert Foss
Hey Alexandru, Feel free my SoB on this patch: Signed-off-by: Robert Foss <robert.f...@collabora.com> Rob. On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote: vsyncworker::Routine assumes that when -EINTR is returned by WaitForSignalOrExitLocked the lock as been released, which is no

Re: [PATCH hwc v2 01/18] drm_hwcomposer: vsyncworker: Fix uninitialized enabled_ field

2018-04-16 Thread Robert Foss
Hey Alexandru, Feel free to add: Signed-off-by: Robert Foss <robert.f...@collabora.com> Rob. On 04/11/2018 05:22 PM, Alexandru Gheorghe wrote: Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheor...@arm.com> --- vsyncworker.cpp | 1 + 1 file changed, 1 insertion(+)

[RFC 0/1] DRM Node Probing functionality

2018-04-11 Thread Robert Foss
ties and allowing the caller to supply a list of properties that are interesting and their values. In terms of long-term maintainership this might be less pleasant than the approach of the current implementation. Robert Foss (1): xf86drm: Add drmHandleMatch func xf86drm.h | 2 ++ xf86drmMode.c

[RFC 1/1] xf86drm: Add drmHandleMatch func

2018-04-11 Thread Robert Foss
the already existing drmVersion and drmDevice structs. Most fields of drmVersion and drmDevice can be used for comparing between the target device and the actual FD that has been provided. Signed-off-by: Robert Foss <robert.f...@collabora.com> --- xf86drm.h | 2 ++ xf86drmMode.

[RFC 0/1] DRM Node Probing functionality

2018-04-11 Thread Robert Foss
list of properties that are interesting and their values. In terms of long-term maintainership this might be less pleasant than the approach of the current implementation. Robert Foss (1): xf86drm: Add drmHandleMatch func xf86drm.h | 2 ++ xf86drmMode.c

Re: [RFC][PATCH v2] drm_hwcomposer: Rework platformdrmgeneric.cpp to use libdrm's gralloc handle

2018-04-04 Thread Robert Foss
/master branch. Similar changes may also be needed to gbm_gralloc and other projects not used in AOSP. Mostly just sending this out for review feedback. Cc: Robert Foss <robert.f...@collabora.com> Cc: Rob Herring <rob.herr...@linaro.org> Cc: Sean Paul <seanp...@google.com> Cc: St

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-04-03 Thread Robert Foss
Hey Chih-Wei, Thanks for the poke, the patch has been pushed now. Rob. On 04/03/2018 04:58 AM, Chih-Wei Huang wrote: 2018-03-28 23:22 GMT+08:00 Rob Herring : On Wed, Mar 28, 2018 at 10:19 AM, Rob Herring wrote: On Sat, Mar 17, 2018 at 2:33 PM, Stefan

Re: [PATCH v2] libdrm: gralloc_handle.h: Fix build issue with Android

2018-04-03 Thread Robert Foss
Hey again, Actually, I might as well just push this fix. Pushed! Rob. On 04/03/2018 10:18 AM, Robert Foss wrote: Hey John, This looks good to me, feel free to add my: Reviewed-by: Robert Foss <robert.f...@collabora.com> On 04/03/2018 05:37 AM, John Stultz wrote: In trying to int

Re: [PATCH v2] libdrm: gralloc_handle.h: Fix build issue with Android

2018-04-03 Thread Robert Foss
Hey John, This looks good to me, feel free to add my: Reviewed-by: Robert Foss <robert.f...@collabora.com> On 04/03/2018 05:37 AM, John Stultz wrote: In trying to integrate the new gralloc_handle.h with the drm_hwcomposer, I started seeing the following compilation errors: In file in

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-19 Thread Robert Foss
). But it seems something like this is needed. Cc: Robert Foss <robert.f...@collabora.com> Cc: Rob Herring <r...@kernel.org> Cc: Sean Paul <seanp...@google.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- android/gralloc_handle.h | 3 +-- 1 file changed, 1 insertion(

Re: [PATCH v5] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

2018-03-14 Thread Robert Foss
min.gheor...@arm.com> Cc: Alistair Strachan <astrac...@google.com> Acked-by: Robert Foss <robert.f...@collabora.com> Signed-off-by: John Stultz <john.stu...@linaro.org> --- v2: * Make platformhisi and the generic importer exclusive in the build * Fixup vendor check v3: * Unify form

Re: [RFC][PATCH 2/2 v4] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

2018-03-12 Thread Robert Foss
Hey John, Feel free to add my ACK. Rob. On 03/08/2018 11:08 PM, John Stultz wrote: On Thu, Mar 8, 2018 at 3:16 AM, Robert Foss <robert.f...@collabora.com> wrote: Hey John, This patch looks good to me. I have yet to build it, and I haven't brought my HiKey960 up for testing qui

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-09 Thread Robert Foss
Hey, On 03/09/2018 10:55 AM, Alexandru-Cosmin Gheorghe wrote: Hi Daniel, On Fri, Mar 09, 2018 at 09:29:24AM +, Daniel Stone wrote: Hi John, On 8 March 2018 at 19:43, John Stultz <john.stu...@linaro.org> wrote: On Thu, Mar 8, 2018 at 3:10 AM, Robert Foss <robert.f...@coll

Re: [RFC][PATCH 2/2 v4] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

2018-03-08 Thread Robert Foss
tions" -> "implementations" Cc: Marissa Wall <maris...@google.com> Cc: Sean Paul <seanp...@google.com> Cc: Dmitry Shmidt <dimitr...@google.com> Cc: Robert Foss <robert.f...@collabora.com> Cc: Matt Szczesiak <matt.szczes...@arm.com> Cc: Liviu Du

Re: [RFC][PATCH 1/2] drm_hwcomposer: Error out on YUV layer as it would fail for single planes

2018-03-08 Thread Robert Foss
ConvertHALFormatToDrm and checking it's return code. So this patch tries to do this. Cc: Marissa Wall <maris...@google.com> Cc: Sean Paul <seanp...@google.com> Cc: Dmitry Shmidt <dimitr...@google.com> Cc: Robert Foss <robert.f...@collabora.com> Cc: Matt Szczesiak <matt.szczes.

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-07 Thread Robert Foss
(rather then returning the gralloc_handle_t's embadedded native_handle_t ptr). But it seems something like this is needed. Cc: Robert Foss <robert.f...@collabora.com> Cc: Rob Herring <r...@kernel.org> Signed-off-by: John Stultz <john.stu...@linaro.org> --- android/gralloc_ha

Re: [RFC PATCH hwc] drm_hwcomposer: set CRTC background color when available

2018-03-02 Thread Robert Foss
Ack, thanks for the heads up! Rob. On 03/02/2018 01:41 AM, Stefan Schake wrote: Hey Rob, On Wed, Feb 28, 2018 at 11:53 AM, Robert Foss <robert.f...@collabora.com> wrote: Hey, Stefan: Are you looking at an entirely kernel side fix now, or are you pushing this series forward? I've se

Re: [PATCH hwc RFC] drm_hwcomposer: Enable and refactor Separate Rects test

2018-02-28 Thread Robert Foss
Hey Rhys, Pushed! Change-ID tag was dropped. Rob. On 02/26/2018 07:18 AM, Rhys Kidd wrote: Plumb through the existing test based on known sample data for the Separate Rect algorithm via Android's NATIVE_TEST harness. Change-Id: I82b5ab8ed97e338fd20b7e38b4b35ac8c53f4d2d Signed-off-by: Rhys

Re: [PATCH hwc v1] drm_hwcomposer: Fix comment on worker_test

2018-02-28 Thread Robert Foss
Thanks Rhys! Pushed. I removed the Change-Id field though. Rob. On 02/26/2018 07:17 AM, Rhys Kidd wrote: Reflect the boolean logic of the accompanying code, which is run after Worker.InitWorker() has completed in test setup. Change-Id: If5187bdaa944c5d74a70c55b5b5e58e1baa20511

Re: [RFC PATCH hwc] drm_hwcomposer: set CRTC background color when available

2018-02-28 Thread Robert Foss
Hey, On 02/23/2018 03:34 PM, Stefan Schake wrote: Hey Eric, On Thu, Feb 22, 2018 at 9:47 PM, Eric Anholt wrote: Stefan Schake writes: Android assumes an implicit black background layer is always present behind all layers it specifies for composition.

Re: [RFC PATCH hwc] drm_hwcomposer: set CRTC background color when available

2018-02-22 Thread Robert Foss
Hey Stefan, On 02/22/2018 04:54 AM, Stefan Schake wrote: Android assumes an implicit black background layer is always present behind all layers it specifies for composition. drm_hwcomposer currently punts responsibility for this to the kernel/DRM platform and puts layers with per-pixel alpha

Re: [PATCH libdrm 0/4] gralloc handle fixes

2018-02-15 Thread Robert Foss
Hey Rob, Thanks for ironing out the kinks, and the new helper. If you need reviews for any of the related changes, CC me. This all looks good to me. Feel free to add my r-b. Rob. On 02/15/2018 02:59 PM, Rob Herring wrote: The recently committed gralloc handle definition has a few issues

Re: [PATCH] drm_hwcomposer: fix check for valid fence fd for in fences

2018-02-14 Thread Robert Foss
Hey Rob, This looks good to me, feel free to add my r-b. Reviewed-by: Robert Foss <robert.f...@collabora.com> Rob. On 02/13/2018 11:11 PM, Rob Herring wrote: The check for a valid fence fd is inverted, so we're failing to pass IN_FENCE_FD's to the kernel when we have a valid fence. Re

Re: [RFC][PATCH 2/4 v2] drm_hwcomposer: Add platformhisi buffer importer for hikey and hikey960

2018-01-29 Thread Robert Foss
gt; wrote: On Tue, Jan 23, 2018 at 03:16:37PM -0800, John Stultz wrote: This allows for importing buffers allocated from the hikey and hikey960 gralloc implelementations. Cc: Marissa Wall <maris...@google.com> Cc: Sean Paul <seanp...@google.com> Cc: Dmitry Shmidt <dimitr...@goog

Re: [drm_hwcomposer] [PATCH] Update external connectors list

2018-01-08 Thread Robert Foss
Hey Mauro, This patch looks good to me apart from the commit message formatting. If you tell me I can add your SOB, I'll merge it with the below commit message. On 1/6/18 12:59 AM, Mauro Rossi wrote: > DVID, DVII and VGA are required by discrete and integrated GPUs I would expect something

Re: [drm_hwcomposer] [PATCH] Take Connection state into account. (v2)

2018-01-08 Thread Robert Foss
Hey Mauro! Thanks for the v2, I would like to merge this, but the commit message is a little bit wonky still :) Let me clean it up for you, and if you're fine with me adding your S-o-B I'll push it. Also, if you want to avoid the slow mailing list back and forth, I would happily help out

Re: [drm_hwcomposer PATCH] Take Connection state into account. (v2)

2018-01-03 Thread Robert Foss
Hey Mauro, On Wed, 2018-01-03 at 13:40 +0100, Mauro Rossi wrote: > > > 2018-01-03 12:16 GMT+01:00 Robert Foss <robert.f...@collabora.com>: > > Hey Mauro, > > / > > Thanks for the patch! It builds and looks good to me, but I have > > some > > suggesti

Re: [drm_hwcomposer PATCH] Take Connection state into account. (v2)

2018-01-03 Thread Robert Foss
Hey Mauro, Thanks for the patch! It builds and looks good to me, but I have some suggestions however. On Wed, 2018-01-03 at 11:10 +0100, Mauro Rossi wrote: > These changes avoid following logcat error on integrated and > dedicated GPUs: > > ... 2245 2245 E hwc-drm-resources: Could not find a

Re: [PATCH hwc] drm_hwcomposer: fix warnings on unused variables and parameters

2017-11-30 Thread Robert Foss
Hey Rob, I applied and tested this patch, and it looks good to me. Feel free to add my SB/TB. Rob. On Wed, 2017-11-29 at 10:21 -0600, Rob Herring wrote: > AOSP master now builds by default with -Werror, so fix all the > warnings. > All the warnings are related to unused variables and

Re: Android i.mx6 drm_hwcomposer

2017-11-17 Thread Robert Foss
t; already > opened the device. > > Adding a patch similar to: > > commit 4f4cb902517f5caacea075fb9724e4ce0c435e3d > Author: Robert Foss <robert.f...@collabora.com> > Date: Wed May 17 18:08:14 2017 -0400 > > drm_hwcomposer: Get KMS FD from gbm_gralloc > &

Re: [PATCH hwc] Android: add CleanSpec.mk

2017-11-06 Thread Robert Foss
Hey Rob, On Fri, 2017-11-03 at 07:35 -0500, Rob Herring wrote: > On Thu, Nov 2, 2017 at 11:45 PM, Chih-Wei Huang org> wrote: > > The file contains rules that are executed on incremental builds. > > Since commit 4f7dc9b6 the library was moved to /vendor so > > the old file

Re: [PATCH hwc] drm_hwcomposer: Add HDMI connector as a valid type

2017-11-01 Thread Robert Foss
Hi Rob, Pushed to master. Rob. On Wed, 2017-11-01 at 12:50 -0500, Rob Herring wrote: > From: Robert Foss <robert.f...@collabora.com> > > Accept DRM_MODE_CONNECTOR_HDMIA connector type. > > Look for primary DrmConnector amongst external connectors > after looking for

Re: [PATCH hwc] drm_hwcomposer: correct handling of DRM_MODE_ROTATE_0

2017-11-01 Thread Robert Foss
Hi Rob, On Wed, 2017-11-01 at 12:50 -0500, Rob Herring wrote: > On Wed, Nov 1, 2017 at 11:37 AM, Rob Herring wrote: > > If the rotation property is supported for a plane, then the > > rotation > > value must be non-zero. For the case of 0 degree rotation, > > DRM_MODE_ROTATE_0

Re: [PATCH v2 hwc] drm_hwcomposer: provide a common gralloc handle definition

2017-10-31 Thread Robert Foss
On Tue, 2017-10-31 at 17:44 +0100, Daniel Vetter wrote: > On Tue, Oct 31, 2017 at 09:59:20AM -0500, Rob Herring wrote: > > EGL, gralloc, and HWC must all have a common definition of fd's and > > int's > > in native_handle_t to share the fd and width, height, format, etc. > > of a > > dmabuf. > >

Re: [RFC PATCH hwc] drm_hwcomposer: provide a common gralloc handle definition

2017-10-26 Thread Robert Foss
Hey Rob, On Tue, 2017-10-24 at 18:40 -0500, Rob Herring wrote: > EGL, gralloc, and HWC must all have a common definition of fd's and > int's > in native_handle_t to share the fd and width, height, format, etc. > of a dmabuf. > > Move the definition into HWC so we aren't dependent on a specific >

Re: [PATCH hwc] drm_hwcomposer: make sure primary plane is allocated for squash

2017-10-17 Thread Robert Foss
Hey Adrian, This looks good to me. Pushed! Sorry about the late reply, I was under the weather for a bit. Would you be interested in commit rights to this project? Rob. On Mon, 2017-10-02 at 11:31 -0700, Adrian Salido wrote: > There are instances where the primary plane may have been

Re: [PATCH hwc] drm_hwcomposer: use upstream DRM_MODE_{ROTATE, REFLECT} defines

2017-10-09 Thread Robert Foss
Hey Thierry, On Sat, 2017-10-07 at 01:29 +0200, Thierry Reding wrote: > On Fri, Oct 06, 2017 at 04:46:48PM -0500, Rob Herring wrote: > > The DRM_REFLECT_* and DRM_ROTATE_* defines were not upstream, but > > now > > they are. Convert to using the upstream version which are defined > > as a > > bit

  1   2   >