RE: [PATCH v15 00/16] drm/i915: Implement HDCP2.2

2019-02-25 Thread Winkler, Tomas
; v15 is now part of github. I'm okay to go with this. Thanks Tomas > > > > Best Regards, > > Ramalingam C > > > > > > > -Original Message- > > > From: Winkler, Tomas > > > Sent: Monday, February 25, 2019 1:45 AM > > > To: C, Ramalingam

RE: [PATCH v15 00/16] drm/i915: Implement HDCP2.2

2019-02-24 Thread Winkler, Tomas
Have you fixed the lkp issue? I didn't see you pushed the code to github. Thanks > -Original Message- > From: C, Ramalingam > Sent: Sunday, February 24, 2019 18:33 > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > daniel.vet...@ffwll.ch; Winkler,

RE: [PATCH v14 27/33] misc/mei/hdcp: Prepare Session Key

2019-02-21 Thread Winkler, Tomas
> > Request to ME to prepare the encrypted session key. > > On Success, ME provides Encrypted session key. Function populates the > HDCP2.2 authentication msg SKE_Send_Eks. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] > Redundant comments and cast are removed [Tomas]

RE: [PATCH v14 31/33] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session

2019-02-21 Thread Winkler, Tomas
> Request the ME to terminate the HDCP2.2 session for a port. > > On Success, ME FW will mark the intel port as Deauthenticated and terminate > the wired HDCP2.2 Tx session started due to the cmd > WIRED_INITIATE_HDCP2_SESSION. > > v2: Rebased. > v3: > cldev is passed as first parameter

RE: [PATCH v14 30/33] misc/mei/hdcp: Enabling the HDCP authentication

2019-02-21 Thread Winkler, Tomas
> > Request to ME to configure a port as authenticated. > > On Success, ME FW will mark the port as authenticated and provides HDCP > cipher with the encryption keys. > > Enabling the Authentication can be requested once all stages of > HDCP2.2 authentication is completed by interacting with ME

RE: [PATCH v14 28/33] misc/mei/hdcp: Repeater topology verification and ack

2019-02-21 Thread Winkler, Tomas
> ack > > Request ME to verify the downstream topology information received. > > ME FW will validate the Repeaters receiver id list and downstream topology. > > On Success ME FW will provide the Least Significant 128bits of VPrime, which > forms the repeater ack. > > v2: Rebased. > v3: >

RE: [PATCH v14 19/33] misc/mei/hdcp: Client driver for HDCP application

2019-02-21 Thread Winkler, Tomas
> > ME FW contributes a vital role in HDCP2.2 authentication. > HDCP2.2 driver needs to communicate to ME FW for each step of the > HDCP2.2 authentication. > > ME FW prepare and HDCP2.2 authentication parameters and encrypt them as > per spec. With such parameter Driver prepares HDCP2.2 auth

RE: [PATCH v14 24/33] misc/mei/hdcp: Store the HDCP Pairing info

2019-02-21 Thread Winkler, Tomas
> > Provides Pairing info to ME to store. > > Pairing is a process to fast track the subsequent authentication with the same > HDCP sink. > > On Success, received HDCP pairing info is stored in non-volatile memory of ME. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] >

RE: [PATCH v14 29/33] misc/mei/hdcp: Verify M_prime

2019-02-21 Thread Winkler, Tomas
> > Request to ME to verify the M_Prime received from the HDCP sink. > > ME FW will calculate the M and compare with M_prime received as part of > RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg. > > On successful completion of this stage, downstream propagation of the stream >

RE: [PATCH v14 25/33] misc/mei/hdcp: Initiate Locality check

2019-02-21 Thread Winkler, Tomas
> Requests ME to start the second stage of HDCP2.2 authentication, called > Locality Check. > > On Success, ME FW will provide LC_Init message to send to hdcp sink. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] > Redundant comments and cast are removed [Tomas] > v4: >

RE: [PATCH v14 26/33] misc/mei/hdcp: Verify L_prime

2019-02-21 Thread Winkler, Tomas
> Request to ME to verify the LPrime received from HDCP sink. > > On Success, ME FW will verify the received Lprime by calculating and > comparing with L. > > This represents the completion of Locality Check. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] > Redundant

RE: [PATCH v14 22/33] misc/mei/hdcp: Verify Receiver Cert and prepare km

2019-02-21 Thread Winkler, Tomas
> Requests for verification for receiver certification and also the preparation > for > next AKE auth message with km. > > On Success ME FW validate the HDCP2.2 receivers certificate and do the > revocation check on the receiver ID. AKE_Stored_Km will be prepared if the > receiver is already

RE: [PATCH v14 23/33] misc/mei/hdcp: Verify H_prime

2019-02-21 Thread Winkler, Tomas
> Requests for the verification of AKE_Send_H_prime. > > ME will calculate the H and comparing it with received H_Prime. > The result will be returned as status. > > Here AKE_Send_H_prime is a HDCP2.2 Authentication msg. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] >

RE: [PATCH v14 21/33] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-21 Thread Winkler, Tomas
> On Success, ME FW will start a HDCP2.2 session for the port and provides the > content for HDCP2.2 AKE_Init message. > > v2: Rebased. > v3: > cldev is add as a separate parameter [Tomas] > Redundant comment and typecast are removed [Tomas] > v4: > %zd is used for size [Alexander] >

RE: [PATCH v14 23/33] misc/mei/hdcp: Verify H_prime

2019-02-21 Thread Winkler, Tomas
> > Requests for the verification of AKE_Send_H_prime. > > ME will calculate the H and comparing it with received H_Prime. > The result will be returned as status. > > Here AKE_Send_H_prime is a HDCP2.2 Authentication msg. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] >

RE: [PATCH v14 20/33] misc/mei/hdcp: Define ME FW interface for HDCP2.2

2019-02-21 Thread Winkler, Tomas
> > Defines the HDCP specific ME FW interfaces such as Request CMDs, payload > structure for CMDs and their response status codes. > > This patch defines payload size(Excluding the Header)for each WIRED > HDCP2.2 CMDs. > > v2: Rebased. > v3: > Extra comments are removed. > v4: >

RE: [PATCH v14 32/33] misc/mei/hdcp: Component framework for I915 Interface

2019-02-21 Thread Winkler, Tomas
> > Mei hdcp driver is designed as component slave for the I915 component > master. > > v2: Rebased. > v3: > Notifier chain is adopted for cldev state update [Tomas] > v4: > Made static dummy functions as inline in mei_hdcp.h > API for polling client device status > IS_ENABLED used in

RE: [PATCH v12 32/38] misc/mei/hdcp: Verify M_prime

2019-02-11 Thread Winkler, Tomas
> > Request to ME to verify the M_Prime received from the HDCP sink. > > ME FW will calculate the M and compare with M_prime received as part of > RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg. > > On successful completion of this stage, downstream propagation of the stream >

RE: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-10 Thread Winkler, Tomas
> > > > On 2/10/2019 1:55 PM, Winkler, Tomas wrote: > >> On 2/9/2019 9:39 PM, Winkler, Tomas wrote: > >>>> Request ME FW to start the HDCP2.2 session for an intel port. > >>>> Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and &

RE: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-10 Thread Winkler, Tomas
> > On 2/9/2019 9:39 PM, Winkler, Tomas wrote: > >> Request ME FW to start the HDCP2.2 session for an intel port. > >> Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and > sends > >> to ME FW. > >> > >> On Success, ME FW will

RE: [PATCH v12 24/38] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-09 Thread Winkler, Tomas
> Request ME FW to start the HDCP2.2 session for an intel port. > Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends > to ME FW. > > On Success, ME FW will start a HDCP2.2 session for the port and provides the > content for HDCP2.2 AKE_Init message. > > v2: Rebased. > v3: >

RE: [PATCH v12 21/38] mei: me: add ice lake point device id.

2019-02-09 Thread Winkler, Tomas
> > On Sat, Feb 09, 2019 at 12:42:50PM +0530, Ramalingam C wrote: > > From: Tomas Winkler > > > > Add icelake mei device id. > > > > Cc: > > Signed-off-by: Tomas Winkler > > Signed-off-by: Greg Kroah-Hartman > > Cherry-picked from > >

RE: [PATCH v11 39/42] misc/mei/hdcp: Component framework for I915 Interface

2019-02-07 Thread Winkler, Tomas
> Mei hdcp driver is designed as component slave for the I915 component > master. > > v2: Rebased. > v3: > Notifier chain is adopted for cldev state update [Tomas] > v4: > Made static dummy functions as inline in mei_hdcp.h > API for polling client device status > IS_ENABLED used in

RE: [PATCH v11 36/42] misc/mei/hdcp: Verify M_prime

2019-02-07 Thread Winkler, Tomas
> > Request to ME to verify the M_Prime received from the HDCP sink. > > ME FW will calculate the M and compare with M_prime received as part of > RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg. > > On successful completion of this stage, downstream propagation of the stream >

RE: [PATCH v11 38/42] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session

2019-02-07 Thread Winkler, Tomas
> > Request the ME to terminate the HDCP2.2 session for a port. > > On Success, ME FW will mark the intel port as Deauthenticated and terminate > the wired HDCP2.2 Tx session started due to the cmd > WIRED_INITIATE_HDCP2_SESSION. > > v2: Rebased. > v3: > cldev is passed as first parameter

RE: [PATCH v11 37/42] misc/mei/hdcp: Enabling the HDCP authentication

2019-02-07 Thread Winkler, Tomas
> > Request to ME to configure a port as authenticated. > > On Success, ME FW will mark the port as authenticated and provides HDCP > cipher with the encryption keys. > > Enabling the Authentication can be requested once all stages of > HDCP2.2 authentication is completed by interacting with ME

RE: [PATCH v11 34/42] misc/mei/hdcp: Prepare Session Key

2019-02-07 Thread Winkler, Tomas
> > Request to ME to prepare the encrypted session key. > > On Success, ME provides Encrypted session key. Function populates the > HDCP2.2 authentication msg SKE_Send_Eks. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] > Redundant comments and cast are removed [Tomas]

RE: [PATCH v11 35/42] misc/mei/hdcp: Repeater topology verification and ack

2019-02-07 Thread Winkler, Tomas
> Request ME to verify the downstream topology information received. > > ME FW will validate the Repeaters receiver id list and downstream topology. > > On Success ME FW will provide the Least Significant 128bits of VPrime, which > forms the repeater ack. > > v2: Rebased. > v3: > cldev is

RE: [PATCH v11 33/42] misc/mei/hdcp: Verify L_prime

2019-02-07 Thread Winkler, Tomas
> Request to ME to verify the LPrime received from HDCP sink. > > On Success, ME FW will verify the received Lprime by calculating and > comparing with L. > > This represents the completion of Locality Check. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] > Redundant

RE: [PATCH v11 31/42] misc/mei/hdcp: Store the HDCP Pairing info

2019-02-07 Thread Winkler, Tomas
> Provides Pairing info to ME to store. > > Pairing is a process to fast track the subsequent authentication with the same > HDCP sink. > > On Success, received HDCP pairing info is stored in non-volatile memory of ME. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] >

RE: [PATCH v11 32/42] misc/mei/hdcp: Initiate Locality check

2019-02-07 Thread Winkler, Tomas
> > Requests ME to start the second stage of HDCP2.2 authentication, called > Locality Check. > > On Success, ME FW will provide LC_Init message to send to hdcp sink. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] > Redundant comments and cast are removed [Tomas] > v4:

RE: [PATCH v11 30/42] misc/mei/hdcp: Verify H_prime

2019-02-07 Thread Winkler, Tomas
> > Requests for the verification of AKE_Send_H_prime. > > ME will calculate the H and comparing it with received H_Prime. > The result will be returned as status. > > Here AKE_Send_H_prime is a HDCP2.2 Authentication msg. > > v2: Rebased. > v3: > cldev is passed as first parameter [Tomas] >

RE: [PATCH v11 28/42] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-07 Thread Winkler, Tomas
> Request ME FW to start the HDCP2.2 session for an intel port. > Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends > to ME FW. > > On Success, ME FW will start a HDCP2.2 session for the port and provides the > content for HDCP2.2 AKE_Init message. > > v2: Rebased. > v3: >

RE: [PATCH v11 29/42] misc/mei/hdcp: Verify Receiver Cert and prepare km

2019-02-07 Thread Winkler, Tomas
> -Original Message- > From: C, Ramalingam > Sent: Wednesday, February 06, 2019 23:04 > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, > Uma > Cc: C, Ramalingam > Subject: [PATCH v11 29/4

RE: [PATCH v11 26/42] misc/mei/hdcp: Client driver for HDCP application

2019-02-07 Thread Winkler, Tomas
> ME FW contributes a vital role in HDCP2.2 authentication. > HDCP2.2 driver needs to communicate to ME FW for each step of the > HDCP2.2 authentication. > > ME FW prepare and HDCP2.2 authentication parameters and encrypt them as > per spec. With such parameter Driver prepares HDCP2.2 auth

RE: [PATCH v11 07/42] drm/i915: Initialize HDCP2.2

2019-02-07 Thread Winkler, Tomas
> v2: > mei interface handle is protected with mutex. [Chris Wilson] > v3: > Notifiers are used for the mei interface state. > v4: > Poll for mei client device state > Error msg for out of mem [Uma] > Inline req for init function removed [Uma] > v5: > Rebase as Part of reordering. >

RE: [PATCH v11 06/42] drm: header for i915 - MEI_HDCP interface

2019-02-07 Thread Winkler, Tomas
> > Header defines the interface for the I915 and MEI_HDCP drivers. > This interface is specific to the usage of mei_hdcp from gen9+ platforms for > ME FW based HDCP2.2 services. > > And Generic HDCP2.2 protocol specific definitions are added at > drm/drm_hdcp.h. > > v2: > Commit msg is

RE: [PATCH v11 05/42] drm/i915: Gathering the HDCP1.4 routines together

2019-02-07 Thread Winkler, Tomas
> All HDCP1.4 routines are gathered together, followed by the generic functions > those can be extended for HDCP2.2 too. > > Signed-off-by: Ramalingam C > Acked-by: Daniel Vetter > Reviewed-by: Uma Shankar Reviewed-by: Tomas Winkler > --- > drivers/gpu/drm/i915/intel_hdcp.c | 118

RE: [PATCH v11 01/42] component: Add documentation

2019-02-07 Thread Winkler, Tomas
> > From: Daniel Vetter > > While typing these I think doing an s/component_master/aggregate/ would be > useful: > - it's shorter :-) > - I think component/aggregate is much more meaningful naming than > component/puppetmaster or something like that. At least to my > English ear

RE: [PATCH v11 24/42] mei: me: add ice lake point device ids

2019-02-06 Thread Winkler, Tomas
> > From: Tomas Winkler > > Add icelake device ids: ICP LP, N and H > > Signed-off-by: Tomas Winkler NACK, this goes via mei driver submission process. Please drop it from the series. > --- > drivers/misc/mei/hw-me-regs.h | 4 > drivers/misc/mei/pci-me.c | 4 > 2 files

RE: [PATCH v10 25/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-06 Thread Winkler, Tomas
> > > >Request ME FW to start the HDCP2.2 session for an intel port. > > >Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and > sends > > to > > >ME FW. > > > > > >On Success, ME FW will start a HDCP2.2 session for the port and > > >provides the content for HDCP2.2 AKE_Init message. >

RE: [PATCH v10 26/40] misc/mei/hdcp: Verify Receiver Cert and prepare km

2019-02-06 Thread Winkler, Tomas
> > >Requests for verification for receiver certification and also the > >preparation for next AKE auth message with km. > > > >On Success ME FW validate the HDCP2.2 receivers certificate and do the > >revocation check on the receiver ID. AKE_Stored_Km will be prepared if > >the receiver is

RE: [PATCH v10 25/40] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2019-02-05 Thread Winkler, Tomas
> >Request ME FW to start the HDCP2.2 session for an intel port. > >Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sends > to > >ME FW. > > > >On Success, ME FW will start a HDCP2.2 session for the port and > >provides the content for HDCP2.2 AKE_Init message. > > > >v2: Rebased.

RE: [PATCH v10 24/40] misc/mei/hdcp: Define ME FW interface for HDCP2.2

2019-02-05 Thread Winkler, Tomas
> > >-Original Message- > >From: C, Ramalingam > >Sent: Thursday, January 31, 2019 12:30 PM > >To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > >daniel.vet...@ffwll.ch; Winkler, Tomas ; > >Shankar, Uma > >Cc: C, Ramal

RE: [PATCH v10 23/40] misc/mei/hdcp: Client driver for HDCP application

2019-02-05 Thread Winkler, Tomas
> > ME FW is contributes a vital role in HDCP2.2 authentication. > HDCP2.2 driver needs to communicate to ME FW for each step of the > HDCP2.2 authentication. > > ME FW prepare and HDCP2.2 authentication parameters and encrypt them as > per spec. With such parameter Driver prepares HDCP2.2 auth

RE: [PATCH v10 19/40] drm/i915: Add HDCP2.2 support for DP connectors

2019-02-04 Thread Winkler, Tomas
> -Original Message- > From: C, Ramalingam > Sent: Thursday, January 31, 2019 09:00 > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > daniel.vet...@ffwll.ch; Winkler, Tomas ; Shankar, > Uma > Cc: C, Ramalingam > Subject: [PATCH v10 19/4

RE: [PATCH v10 20/40] drm/i915: Add HDCP2.2 support for HDMI connectors

2019-02-04 Thread Winkler, Tomas
> > On HDMI connector init, intel_hdcp_init is passed with a flag for hdcp2.2 > support based on the platform capability. > > v2: > Rebased. > v3: > Collected the reviewed-by received. > > Signed-off-by: Ramalingam C > Reviewed-by: Uma Shankar > --- > drivers/gpu/drm/i915/intel_hdmi.c |

RE: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-20 Thread Winkler, Tomas
From: C, Ramalingam Sent: Thursday, December 20, 2018 18:00 To: Daniel Vetter ; Winkler, Tomas Cc: Greg KH ; Rafael J. Wysocki ; intel-gfx ; dri-devel ; Sean Paul ; Shankar, Uma ; Syrjala, Ville ; Chris Wilson Subject: Re: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915

RE: [Intel-gfx] [PATCH v9 10/39] drm/i915: Implement HDCP2.2 receiver authentication

2018-12-20 Thread Winkler, Tomas
> On Wed, 19 Dec 2018, "Winkler, Tomas" wrote: > >> > >> On Wed, 19 Dec 2018, "C, Ramalingam" wrote: > >> > On 12/19/2018 8:05 PM, Daniel Vetter wrote: > >> >> On Thu, Dec 13, 2018 at 09:31:12AM +0530, Ramalingam C wrote:

RE: [Intel-gfx] [PATCH v9 10/39] drm/i915: Implement HDCP2.2 receiver authentication

2018-12-19 Thread Winkler, Tomas
> > On Wed, 19 Dec 2018, "C, Ramalingam" wrote: > > On 12/19/2018 8:05 PM, Daniel Vetter wrote: > >> On Thu, Dec 13, 2018 at 09:31:12AM +0530, Ramalingam C wrote: > >>> struct intel_hdcp { > >>> @@ -414,6 +430,24 @@ struct intel_hdcp { > >>>*/ > >>> u8 content_type; >

RE: [PATCH v9 02/39] drm: header for i915 - MEI_HDCP interface

2018-12-17 Thread Winkler, Tomas
> > On Mon, Dec 17, 2018 at 12:28 PM Winkler, Tomas > wrote: > > > > > > > > Header defines the interface for the I915 and MEI_HDCP drivers. > > > > > > Signed-off-by: Ramalingam C > > > --- > > > include/drm/i915_mei_hdc

RE: [PATCH v9 02/39] drm: header for i915 - MEI_HDCP interface

2018-12-17 Thread Winkler, Tomas
> > Header defines the interface for the I915 and MEI_HDCP drivers. > > Signed-off-by: Ramalingam C > --- > include/drm/i915_mei_hdcp_interface.h | 132 > ++ > 1 file changed, 132 insertions(+) > create mode 100644 include/drm/i915_mei_hdcp_interface.h > >

RE: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-17 Thread Winkler, Tomas
> On Sat, Dec 15, 2018 at 09:20:38PM +0000, Winkler, Tomas wrote: > > > > > > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas > > > > > > wrote: > > > > > > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam &g

RE: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-15 Thread Winkler, Tomas
> > On Thu, Dec 13, 2018 at 5:27 PM Winkler, Tomas > wrote: > > > > > On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam > > > > > > wrote: > > > > > > > > Tomas and Daniel, > > > > > > > > We got an i

RE: [PATCH v9 35/39] misc/mei/hdcp: Component framework for I915 Interface

2018-12-13 Thread Winkler, Tomas
> On Thu, Dec 13, 2018 at 1:36 PM C, Ramalingam > wrote: > > > > Tomas and Daniel, > > > > We got an issue here. > > > > The relationship that we try to build between I915 and mei_hdcp is as > > follows: > > > > We are using the components to establish the relationship. > > I915 is component

RE: [PATCH v9 12/39] drm/i915: Implement HDCP2.2 repeater authentication

2018-12-13 Thread Winkler, Tomas
> > Implements the HDCP2.2 repeaters authentication steps such as verifying the > downstream topology and sending stream management information. > > v2: Rebased. > v3: > -EINVAL is returned for topology error and rollover scenario. > Endianness conversion func from drm_hdcp.h is used [Uma] >

RE: [PATCH v9 01/39] drm/i915: Gathering the HDCP1.4 routines together

2018-12-13 Thread Winkler, Tomas
> > All HDCP1.4 routines are gathered together, followed by the generic functions > those can be extended for HDCP2.2 too. > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/i915/intel_hdcp.c | 118 +++-- > - > 1 file changed, 59 insertions(+), 59

RE: [PATCH v8 03/35] linux/mei: Header for mei_hdcp driver interface

2018-12-08 Thread Winkler, Tomas
> On Fri, Dec 07, 2018 at 07:23:06PM +0530, C, Ramalingam wrote: > > Hi, > > > > In one of the offline discussion Tomas has shared his review comments on v8. > > Let's please have all review here on the mailing list for better coordination. > Playing a game of telephone isn't efficient. It's not

RE: [PATCH v8 04/35] drm/i915: Initialize HDCP2.2

2018-12-08 Thread Winkler, Tomas
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Friday, December 07, 2018 16:17 > To: C, Ramalingam > Cc: Daniel Vetter ; intel-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; daniel.vet...

RE: [PATCH v2 10/42] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2018-03-12 Thread Winkler, Tomas
> > > > On Thursday 08 March 2018 06:47 PM, Winkler, Tomas wrote: > >> Request ME FW to start the HDCP2.2 session for a intel port. > >> Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and > sent > >> to ME FW. > >> > >>

RE: [PATCH v2 04/42] misc/mei/hdcp: Client driver for HDCP application

2018-03-12 Thread Winkler, Tomas
> >> +MODULE_AUTHOR("Intel Corporation"); > >> +MODULE_LICENSE("GPL"); > > > > Dual License > > MODULE_LICENSE("GPL-2.0+ OR BSD-3-Clause"); > > Will this work? No, it should be MODULE_LICENSE("Dual BSD/GPL"); Tomas ___ dri-devel mailing list

RE: [PATCH v2 10/42] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2018-03-08 Thread Winkler, Tomas
> > Request ME FW to start the HDCP2.2 session for a intel port. > Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sent > to ME FW. > > On Success, ME FW will start a HDCP2.2 session for the port and provides the > content for HDCP2.2 AKE_Init message. > > v2: > Rebased. > >

RE: [PATCH v2 09/42] linux/mei: Header for mei_hdcp driver interface

2018-03-08 Thread Winkler, Tomas
> Data structures and Enum for the I915-MEI_HDCP interface are defined at > > > v2: > Rebased. > > Signed-off-by: Ramalingam C > --- > include/linux/mei_hdcp.h | 71 > > 1 file changed, 71 insertions(+) > > diff --git

RE: [PATCH v2 07/42] misc/mei/hdcp: Get & Put for mei cl_device

2018-03-08 Thread Winkler, Tomas
> Interfaces to obtain and release the cl_device reference is developed. > Using these interfaces intel hdcp driver will get the reference to the mei > client devices, so that hdcp2.2 service calls can be routed to that client > device. > > During registration, call back function will be

RE: [PATCH v2 04/42] misc/mei/hdcp: Client driver for HDCP application

2018-03-08 Thread Winkler, Tomas
> Subject: [PATCH v2 04/42] misc/mei/hdcp: Client driver for HDCP application I prefer this will be squashed together with [PATCH v2 05/42] misc/mei/hdcp: Add KBuild for mei hdcp driver so it can be compiled. > > ME FW is contributes a vital role in HDCP2.2 authentication. > HDCP2.2 driver

RE: [PATCH v2 06/42] misc/mei/hdcp: Verify mei client device status

2018-03-08 Thread Winkler, Tomas
> > v2: > Rebased. > > Signed-off-by: Ramalingam C > --- > drivers/misc/mei/hdcp/mei_hdcp.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c > b/drivers/misc/mei/hdcp/mei_hdcp.c > index aa211763e520..25df7034cfb4

RE: [PATCH v2 00/42] drm/i915: Implement HDCP2.2

2018-03-08 Thread Winkler, Tomas
> -Original Message- > From: C, Ramalingam > Sent: Thursday, March 08, 2018 13:58 > To: intel-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; > seanp...@chromium.org; ch...@chris-wilson.co.uk; Winkler, Tomas > <tomas.wink...@intel.com>; jani.nik...@li

RE: [PATCH 05/15] mei: make device_type const

2017-08-19 Thread Winkler, Tomas
> Subject: [PATCH 05/15] mei: make device_type const > > Make this const as it is only stored in the type field of a device structure, > which is const. > Done using Coccinelle. > > Signed-off-by: Bhumika Goyal > --- > drivers/misc/mei/bus.c | 2 +- > 1 file changed, 1