Re: linux-next: merge conflict between drm-misc and sound trees

2018-03-14 Thread Stephen Rothwell
Hi Lukas, On Wed, 14 Mar 2018 07:38:01 +0100 Lukas Wunner wrote: > > when rebuilding linux-next you're going to see a merge conflict in: > > sound/pci/hda/hda_intel.c > > betwen commit: > > 1ba8f9d30817 ("ALSA: hda: Add a power_save blacklist") > > from the sound tree

Re: [PATCH] ARM: dts: sun8i-h3: Add Mali node

2018-03-14 Thread Maxime Ripard
On Tue, Mar 13, 2018 at 11:16:45AM +0100, Giulio Benetti wrote: > The H3 has an ARM Mali 400 GPU, so add binding to our DT. > > Signed-off-by: Giulio Benetti How was this tested? Is there any specific reason not to share it with the H5? Maxime -- Maxime

Re: [PATCH v3 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-14 Thread Simon Horman
On Tue, Mar 13, 2018 at 03:30:25PM +0100, Jacopo Mondi wrote: > The R-Car V3M Eagle board includes a transparent THC63LVD1024 LVDS > decoder, connected to the on-chip LVDS encoder output on one side > and to HDMI encoder ADV7511w on the other one. > > As the decoder does not need any

Re: [RFC PATCH 00/13] SVM (share virtual memory) with HMM in nouveau

2018-03-14 Thread Matthew Wilcox
On Mon, Mar 12, 2018 at 11:14:47PM -0700, John Hubbard wrote: > Yes, on NVIDIA GPUs, the Host/FIFO unit is limited to 40-bit addresses, so > things such as the following need to be below (1 << 40), and also accessible > to both CPU (user space) and GPU hardware. > -- command buffers (CPU

Re: [PATCH] drm/meson: Add support for DMT modes on HDMI

2018-03-14 Thread Jerome Brunet
On Tue, 2018-03-13 at 11:07 +0100, Neil Armstrong wrote: > This patch adds support for DMT display modes over HDMI. > The modes timings configurations are from the Amlogic Vendor linux tree > and tested over multiples monitors. > Previously only a selected number of CEA modes were supported. > >

Re: [PATCH v3 04/10] otm

2018-03-14 Thread Patrice CHOTARD
Hi Yannick There is a problem with patch 4. I received two patches 04/10, this one and [PATCH v3 04/10] video: add support of panel OTM8009A. Patrice On 03/13/2018 02:50 PM, yannick fertre wrote: > --- > drivers/video/orisetech_otm8009a.c | 4 +++- > 1 file changed, 3 insertions(+), 1

[PATCH] drm/nouveau/secboot: remove VLA usage

2018-03-14 Thread Gustavo A. R. Silva
In preparation to enabling -Wvla, remove VLA. In this particular case directly use macro NVKM_MSGQUEUE_CMDLINE_SIZE instead of local variable cmdline_size. Also, remove cmdline_size as it is not actually useful anymore. The use of stack Variable Length Arrays needs to be avoided, as they can be a

Re: [RfC PATCH] Add udmabuf misc device

2018-03-14 Thread Gerd Hoffmann
Hi, > Either mlock account (because it's mlocked defacto), and get_user_pages > won't do that for you. > > Or you write the full-blown userptr implementation, including mmu_notifier > support (see i915 or amdgpu), but that also requires Christian Königs > latest ->invalidate_mapping RFC for

[PATCH] drm/i915: drop various VLAs in i915_debugfs.c

2018-03-14 Thread Salvatore Mesoraca
Avoid 3 VLAs[1] by using real constant expressions instead of variables. The compiler should be able to optimize the original code and avoid using any actual VLAs. Anyway this change is useful because it will avoid a false positives with -Wvla, it might also help the compiler generating better

[PATCH v3 2/3] drm: bridge: Add thc63lvd1024 LVDS decoder driver

2018-03-14 Thread Jacopo Mondi
Add DRM bridge driver for Thine THC63LVD1024 LVDS to digital parallel output decoder. Signed-off-by: Jacopo Mondi --- drivers/gpu/drm/bridge/Kconfig| 7 + drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge/thc63lvd1024.c | 241

[PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-03-14 Thread Gustavo A. R. Silva
In preparation to enabling -Wvla, remove VLA. In this particular case directly use macro NVKM_MSGQUEUE_CMDLINE_SIZE instead of local variable cmdline_size. Also, remove cmdline_size as it is not actually useful anymore. The use of stack Variable Length Arrays needs to be avoided, as they can be a

[PATCH v3 3/3] arm64: dts: renesas: Add LVDS decoder to R-Car V3M Eagle

2018-03-14 Thread Jacopo Mondi
The R-Car V3M Eagle board includes a transparent THC63LVD1024 LVDS decoder, connected to the on-chip LVDS encoder output on one side and to HDMI encoder ADV7511w on the other one. As the decoder does not need any configuration it has been so-far omitted from DTS. Now that a driver is available,

Re: [PATCH v2 07/10] video: add support of panel rm68200

2018-03-14 Thread Patrice CHOTARD
Hi yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Support for Raydium rm68200 720p dsi 2dl video mode panel. > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig | 8 + > drivers/video/Makefile | 1 + >

Re: [PATCH v2 06/10] video: add support of STM32 MIPI DSI controller driver

2018-03-14 Thread Patrice CHOTARD
Hi yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Add the STM32 DSI controller driver that uses the Synopsys DesignWare > MIPI DSI host controller bridge. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/Kconfig | 10 + >

RE: [PATCH] drm/nouveau/secboot: remove VLA usage

2018-03-14 Thread David Laight
From: Gustavo A. R. Silva > Sent: 13 March 2018 14:48 > In preparation to enabling -Wvla, remove VLA. In this particular > case directly use macro NVKM_MSGQUEUE_CMDLINE_SIZE instead of local > variable cmdline_size. Also, remove cmdline_size as it is not > actually useful anymore. ... > diff --git

Re: [PATCH v3 00/10] splash screen on the stm32f769 disco board

2018-03-14 Thread Anatolij Gustschin
On Tue, 13 Mar 2018 16:23:10 +0100 Daniel Vetter dan...@ffwll.ch wrote: ... > Shouldn't we patch the drivers/gpu/drm/stm driver instead of the > drivers/video one? fbdev is kinda a dead end and not for adding new hw > support ... this patch series adds display driver to U-Boot project, I don't

Re: [PATCH v3 02/10] video: add support of MIPI DSI interface

2018-03-14 Thread Simon Glass
Hi, On 13 March 2018 at 07:50, yannick fertre wrote: > > Mipi_display.c contains a set of dsi helpers. > This file is a copy of file drm_mipi_dsi.c (linux kernel). > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig| 7 + >

[PATCH DRM] drm: Introduce drm_global_item_{get/put}()

2018-03-14 Thread Haneen Mohammed
For consistency with other reference counting APIs in the kernel, introduce drm_global_item_{get/put} functions instead of drm_global_item_{ref/unref}. Compatibility aliases are added to keep existing code working. The semantic patch scripts/coccinelle/api/drm-get-put.cocci has been extended to

Re: [PATCH v2 04/10] video: add support of panel OTM8009A

2018-03-14 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Support for Orise Tech otm8009a 480p dsi 2dl video mode panel. > > Signed-off-by: yannick fertre > --- > drivers/video/Kconfig | 8 + > drivers/video/Makefile | 1 + >

[PATCH v3 1/3] dt-bindings: display: bridge: Document THC63LVD1024 LVDS decoder

2018-03-14 Thread Jacopo Mondi
Document Thine THC63LVD1024 LVDS decoder device tree bindings. Signed-off-by: Jacopo Mondi --- .../bindings/display/bridge/thine,thc63lvd1024.txt | 63 ++ 1 file changed, 63 insertions(+) create mode 100644

Re: [PATCH] drm/nouveau/secboot: remove VLA usage

2018-03-14 Thread Gustavo A. R. Silva
Hi David, On 03/13/2018 11:10 AM, David Laight wrote: From: Gustavo A. R. Silva Sent: 13 March 2018 14:48 In preparation to enabling -Wvla, remove VLA. In this particular case directly use macro NVKM_MSGQUEUE_CMDLINE_SIZE instead of local variable cmdline_size. Also, remove cmdline_size as it

[PATCH] drm/vc4_validate: Remove VLA usage

2018-03-14 Thread Gustavo A. R. Silva
In preparation to enabling -Wvla, remove VLA. In this particular case use macro ARRAY_SIZE so the length of array _bo_ can be computed at preprocessing time. The use of stack Variable Length Arrays needs to be avoided, as they can be a vector for stack exhaustion, which can be both a runtime bug

Re: [PATCH v2 02/10] video: stm32: stm32_ltdc: update debug log

2018-03-14 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Replace macro debug by pr_error, pr_warn or pr_info. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/stm32_ltdc.c | 62 > > 1 file changed, 31

Re: [Freedreno] [PATCH 2/2] arm64: dts: sdm845: Support GPU/GMU

2018-03-14 Thread Stephen Boyd
On Sun, Mar 11, 2018 at 10:52 PM, Viresh Kumar wrote: > On 09-03-18, 09:03, Jordan Crouse wrote: >> I don't think we are understanding each other. The GMU is a separate >> microcontroller. It is given a magic number (actually a combination of magic >> numbers) that it

Re: [PATCH v2 10/10] board: Add STM32F769 SoC, discovery board support

2018-03-14 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Signed-off-by: yannick fertre Can you add a commit message explaining why you add a specific defconfig for this board. FYI, previously, the same defconfig was used for all STM32F7 boards (ie

Re: [PATCH v3 10/10] board: Add STM32F769 SoC, discovery board support

2018-03-14 Thread Patrice CHOTARD
Hi Yannick You have forgotten the commit message Patrice On 03/13/2018 02:50 PM, yannick fertre wrote: > Signed-off-by: yannick fertre > --- > configs/stm32f769-disco_defconfig | 65 > +++ > 1 file changed, 65 insertions(+) >

[PATCH v3 0/3] drm: Add Thine THC63LVD1024 LVDS decoder bridge

2018-03-14 Thread Jacopo Mondi
Hello, opposed to v2, this version drops the "transparent LVDS decoder" and provides support for the Thine THC63LVD1024 chip only. I removed all references to "lvds-decoder" and made driver and bindings specific for the above mentioned chip. Andrzej: Bindings now describe 2 available inputs

Re: [PATCH v2 01/10] video: stm32: stm32_ltdc: add bridge to display controller

2018-03-14 Thread Patrice CHOTARD
Hi Yannick On 03/02/2018 04:44 PM, yannick fertre wrote: > Manage a bridge insert between the display controller & a panel. > > Signed-off-by: yannick fertre > --- > drivers/video/stm32/stm32_ltdc.c | 107 > ++- > 1 file changed, 71

Re: [Intel-gfx] [PATCH] [v2] drm/i915/pmu: avoid -Wmaybe-uninitialized warning

2018-03-14 Thread Tvrtko Ursulin
On 13/03/2018 20:10, Arnd Bergmann wrote: On Tue, Mar 13, 2018 at 6:46 PM, Tvrtko Ursulin wrote: On 13/03/2018 16:19, Arnd Bergmann wrote: The conditional spinlock confuses gcc into thinking the 'flags' value might contain uninitialized data:

Re: linux-next: merge conflict between drm-misc and sound trees

2018-03-14 Thread Takashi Iwai
On Wed, 14 Mar 2018 07:38:01 +0100, Lukas Wunner wrote: > > Dear Stephen, > > when rebuilding linux-next you're going to see a merge conflict in: > > sound/pci/hda/hda_intel.c > > betwen commit: > > 1ba8f9d30817 ("ALSA: hda: Add a power_save blacklist") > > from the sound tree and

Re: [PATCH v5 21/36] drm/bridge: analogix_dp: Fix timeout of video streamclk config

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang The STRM_VALID bit in register ANALOGIX_DP_SYS_CTL_3 may be unstable, so we may hit the error log "Timeout of video streamclk ok" since checked this unstable bit. In fact, we can go

Re: [PATCH v5 23/36] drm/bridge: analogix_dp: Move fast link training detect to set_bridge

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang It's too early to detect fast link training, if other step after it failed, we will set fast_link flag to 1, and retry set_bridge again. In this case we will power down and power up panel

Re: [PATCH v5 24/36] drm/bridge: analogix_dp: Reorder plat_data->power_off to happen sooner

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Douglas Anderson The current user of the analogix power_off is "analogix_dp-rockchip". That driver does this: - deactivate PSR - turn off a clock Both of these things (especially deactive PSR)

Re: [PATCH v5 25/36] drm/bridge: analogix_dp: Properly log AUX CH errors

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Douglas Anderson The code in analogix_dp_transfer() that was supposed to print out: AUX CH error happened Was actually dead code. That's because the previous check (whether the interrupt status

Re: [PATCH v5 26/36] drm/bridge: analogix_dp: Properly disable aux chan retries on rockchip

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Douglas Anderson The comments in analogix_dp_init_aux() claim that we're disabling aux channel retries, but then right below it for Rockchip it sets them to 3. If we actually need 3 retries for

linux-next: merge conflict between drm-misc and sound trees

2018-03-14 Thread Lukas Wunner
Dear Stephen, when rebuilding linux-next you're going to see a merge conflict in: sound/pci/hda/hda_intel.c betwen commit: 1ba8f9d30817 ("ALSA: hda: Add a power_save blacklist") from the sound tree and commit: 07f4f97d7b4b ("vga_switcheroo: Use device link for HDA controller") from

Re: [PATCH v5 22/36] drm/bridge: analogix_dp: Fix incorrect operations with register ANALOGIX_DP_FUNC_EN_1

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang Register ANALOGIX_DP_FUNC_EN_1(offset 0x18), Rockchip is different to Exynos: on Exynos edp phy, BIT 7 MASTER_VID_FUNC_EN_N BIT 6 reserved BIT 5

Re: [PATCH v5 20/36] drm/bridge: analogix_dp: Don't use ANALOGIX_DP_PLL_CTL to control pll

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang There is no register named ANALOGIX_DP_PLL_CTL in Rockchip edp phy reg list. We should use BIT_4 in ANALOGIX_DP_PD to control the pll power instead of ANALOGIX_DP_PLL_CTL. Reviewed-by:

Re: [PATCH v5 19/36] drm/rockchip: Restore psr->state when enable/disable psr failed

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang If we failed disable psr, it would hang the display until next psr cycle coming. So we should restore psr->state when it failed. For the bridge part, Reviewed-by: Archit Taneja

Re: [PATCH v5 18/36] drm/bridge: analogix_dp: Reset aux channel if an error occurred

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Lin Huang AUX errors are caused by many different reasons. We may not know what happened in aux channel on failure, so let's reset aux channel if some errors occurred. Cc: 征增 王

Re: [PATCH v5 17/36] drm/bridge: analogix_dp: Fix AUX_PD bit for Rockchip

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang There are some different bits between Rockchip and Exynos in register "AUX_PD". This patch fixes the incorrect operations about it. You mean the register

Re: [PATCH v5 16/36] drm/bridge: analogix_dp: Check dpcd write/read status

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Lin Huang We need to check the dpcd write/read return value to see whether the write/read was successful Reviewed-by: Archit Taneja Thanks, Archit Cc: Kristian H.

Re: [PATCH v5 15/36] drm/bridge: analogix_dp: Fix incorrect usage of enhanced mode

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang Enhanced mode is required by the eDP 1.2 specification, and not doing it early could result in a period of time where we have a link transmitting idle packets without it. Since there is no

Re: [PATCH v5 14/36] drm/bridge: analogix_dp: Extend hpd check time to 100ms

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Lin Huang There was a 1ms delay to detect the hpd signal, which is too short to detect a short pulse. This patch extends this delay to 100ms. Reviewed-by: Archit Taneja

Re: [PATCH v5 13/36] drm/bridge: analogix_dp: Ensure edp is disabled when shutting down the panel

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: Lin Huang When panel is shut down, we should make sure edp can be disabled to avoid undefined behavior. Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin

Re: [PATCH v5 12/36] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang Following the correct power up sequence: dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00 Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin

Re: [PATCH v5 11/36] drm/bridge: analogix_dp: Wait for HPD signal before configuring link

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang According to DP spec v1.3 chap 3.5.1.2 Link Training, Link Policy Maker must first detect that the HPD signal is asserted high by the Downstream Device before establishing a link with it.

Re: [PATCH v5 10/36] drm/bridge: analogix_dp: Retry bridge enable when it failed

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang When we enable bridge failed, we have to retry it, otherwise we would get the abnormal display. Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane

Re: [PATCH v2 0/7] Modernize vga_switcheroo by using device link for HDA

2018-03-14 Thread Lukas Wunner
On Sun, Mar 11, 2018 at 04:55:49PM +0100, Lukas Wunner wrote: > > On Sat, Mar 03, 2018 at 10:53:24AM +0100, Lukas Wunner wrote: > > > Modernize vga_switcheroo by using a device link to enforce a runtime PM > > > dependency from an HDA controller to the GPU it's integrated into, v2. > > > > > >

Re: [PATCH v5 09/36] drm/bridge: analogix_dp: Don't use fast link training when panel just powered up

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:53 AM, Enric Balletbo i Serra wrote: From: zain wang Panel would reset its setting when it powers down. It would forget the last succeeded link training setting. So we can't use the last successful link training setting to do fast link

Re: [PATCH v5 08/36] drm/bridge: analogix_dp: Check AUX_EN status when doing AUX transfer

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:52 AM, Enric Balletbo i Serra wrote: From: Lin Huang We should check AUX_EN bit to confirm the AUX CH operation is completed. Reviewed-by: Archit Taneja Thanks, Archit Cc: Stéphane Marchesin

Re: [PATCH v5 07/36] drm/bridge: analogix_dp: Move enable video into config_video()

2018-03-14 Thread Archit Taneja
On Saturday 10 March 2018 03:52 AM, Enric Balletbo i Serra wrote: From: Lin Huang We need to enable video before analogix_dp_is_video_stream_on(), so we can get the right video stream status. Cc: 征增 王 Cc: Stéphane Marchesin

<    1   2