[PATCH] drm/dp_mst: correct the shifting in DP_REMOTE_I2C_READ

2019-12-29 Thread Wayne Lin
[Why] According to DP spec, it should shift left 4 digits for NO_STOP_BIT in REMOTE_I2C_READ message. Not 5 digits. [How] Correct the shifting value of NO_STOP_BIT for DP_REMOTE_I2C_READ case in drm_dp_encode_sideband_req(). Signed-off-by: Wayne Lin --- drivers/gpu/drm/drm_dp_mst_topology.c |

Re: [RFC v2 1/1] drm/lima: Add optional devfreq support

2019-12-29 Thread Robin Murphy
On 2019-12-29 11:19 pm, Martin Blumenstingl wrote: Hi Robin, On Sun, Dec 29, 2019 at 11:58 PM Robin Murphy wrote: Hi Martin, On 2019-12-27 5:37 pm, Martin Blumenstingl wrote: Most platforms with a Mali-400 or Mali-450 GPU also have support for changing the GPU clock frequency. Add devfreq

Re: [RFC v2 1/1] drm/lima: Add optional devfreq support

2019-12-29 Thread Robin Murphy
Hi Martin, On 2019-12-27 5:37 pm, Martin Blumenstingl wrote: Most platforms with a Mali-400 or Mali-450 GPU also have support for changing the GPU clock frequency. Add devfreq support so the GPU clock rate is updated based on the actual GPU usage when the "operating-points-v2" property is

[PATCH 5.4 045/434] drm: mst: Fix query_payload ack reply struct

2019-12-29 Thread Greg Kroah-Hartman
From: Sean Paul [ Upstream commit 268de6530aa18fe5773062367fd119f0045f6e88 ] Spec says[1] Allocated_PBN is 16 bits [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98 Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)") Cc: Lyude Paul Cc: Todd Previte Cc: Dave

[PATCH 4.19 027/219] drm: mst: Fix query_payload ack reply struct

2019-12-29 Thread Greg Kroah-Hartman
From: Sean Paul [ Upstream commit 268de6530aa18fe5773062367fd119f0045f6e88 ] Spec says[1] Allocated_PBN is 16 bits [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98 Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)") Cc: Lyude Paul Cc: Todd Previte Cc: Dave

[PATCH 4.14 020/161] drm: mst: Fix query_payload ack reply struct

2019-12-29 Thread Greg Kroah-Hartman
From: Sean Paul [ Upstream commit 268de6530aa18fe5773062367fd119f0045f6e88 ] Spec says[1] Allocated_PBN is 16 bits [1]- DisplayPort 1.2 Spec, Section 2.11.9.8, Table 2-98 Fixes: ad7f8a1f9ced ("drm/helper: add Displayport multi-stream helper (v0.6)") Cc: Lyude Paul Cc: Todd Previte Cc: Dave

Re: Requesting commit access to libdrm

2019-12-29 Thread Eric Engestrom
On Monday, 2019-12-16 16:51:28 +, Souza, Jose wrote: > Hello > > I have being contributing to i915 for the past 2 years and part of my > work is update the PCI ids of Intel devices in libdrm. > Being able to push my reviewed patches would be really helpful, please > consider this request.

Re: [RFC 3/4] drm/sun4i: Reimplement plane z position setting logic

2019-12-29 Thread Jernej Škrabec
Dne nedelja, 29. december 2019 ob 13:08:19 CET je Roman Stratiienko napisal(a): > Hello Jernej, > > Thank you for review. > > On Sun, Dec 29, 2019 at 11:40 AM Jernej Škrabec wrote: > > Hi! > > > > Dne sobota, 28. december 2019 ob 21:28:17 CET je > > > > roman.stratiie...@globallogic.com

Re: [RFC 1/4] drm/sun4i: Wait for previous mixing process finish before committing next

2019-12-29 Thread Jernej Škrabec
Hi! Dne sobota, 28. december 2019 ob 21:28:15 CET je roman.stratiie...@globallogic.com napisal(a): > From: Roman Stratiienko > > Screen composition that requires dynamic layout modification, > especially scaling is corrupted when layout changes. > > For example if one of the layer scales

Re: [RFC 3/4] drm/sun4i: Reimplement plane z position setting logic

2019-12-29 Thread Roman Stratiienko
Hello Jernej, Thank you for review. On Sun, Dec 29, 2019 at 11:40 AM Jernej Škrabec wrote: > > Hi! > > Dne sobota, 28. december 2019 ob 21:28:17 CET je > roman.stratiie...@globallogic.com napisal(a): > > From: Roman Stratiienko > > > > To set blending channel order register software needs to

Re: [PATCH] arm: dts: sc7180: Add A618 gpu dt blob

2019-12-29 Thread Bjorn Andersson
On Tue 03 Dec 07:17 PST 2019, Sharat Masetty wrote: Please update subject to "arm64: dts: qcom: sc7180: Add A618 GPU nodes" > This patch adds the required dt nodes and properties > to enabled A618 GPU. > > Signed-off-by: Sharat Masetty > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 116 >

[PATCH] panel: simple: Add Ivo M133NWF4 R0

2019-12-29 Thread Bjorn Andersson
The InfoVision Optoelectronics M133NWF4 R0 panel is a 13.3" 1920x1080 eDP panel, add support for it in panel-simple. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/panel/panel-simple.c | 31 1 file changed, 31 insertions(+) diff --git

[PATCH] panel: simple: Add BOE NV133FHM-N61

2019-12-29 Thread Bjorn Andersson
The BOE NV133FHM-N61 panel is a 13.3" 1920x1080 eDP panel, add support for it in panel-simple. Signed-off-by: Bjorn Andersson --- drivers/gpu/drm/panel/panel-simple.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c

Re: [RFC 3/4] drm/sun4i: Reimplement plane z position setting logic

2019-12-29 Thread Jernej Škrabec
Dne nedelja, 29. december 2019 ob 14:13:06 CET je Roman Stratiienko napisal(a): > My proposal is to go with DRM_DEBUG_DRIVER for now. > In case stable branches would be interested in these fixes, it will be > easier to backport. Fair enough, but you need to add at least Fixes tag. Best regards,

[RFC 2/4] drm/sun4i: Use CRTC size instead of PRIMARY plane size as mixer frame.

2019-12-29 Thread roman . stratiienko
From: Roman Stratiienko According to DRM documentation the only difference between PRIMARY and OVERLAY plane is that each CRTC must have PRIMARY plane and OVERLAY are optional. Allow PRIMARY plane to have dimension different from full-screen. Signed-off-by: Roman Stratiienko ---

Re: [RFC 3/4] drm/sun4i: Reimplement plane z position setting logic

2019-12-29 Thread Jernej Škrabec
Dne nedelja, 29. december 2019 ob 13:47:38 CET je Roman Stratiienko napisal(a): > On Sun, Dec 29, 2019 at 2:18 PM Jernej Škrabec wrote: > > Dne nedelja, 29. december 2019 ob 13:08:19 CET je Roman Stratiienko > > > > napisal(a): > > > Hello Jernej, > > > > > > Thank you for review. > > > > >

Re: [RFC 3/4] drm/sun4i: Reimplement plane z position setting logic

2019-12-29 Thread Roman Stratiienko
My proposal is to go with DRM_DEBUG_DRIVER for now. In case stable branches would be interested in these fixes, it will be easier to backport. Also I am using v5.4 for testing since Google AOSP patches does not work correctly with mainline and missing for kernel-next. Maintaining 2 variants will

[RFC 4/4] drm/sun4i: Update mixer's internal registers after initialization

2019-12-29 Thread roman . stratiienko
From: Roman Stratiienko At system start blink of u-boot ghost framebuffer can be observed. Fix it. Signed-off-by: Roman Stratiienko --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c

Re: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

2019-12-29 Thread yukuai (C)
On 2019/12/29 4:45, Markus Elfring wrote: v3d_submit_cl_ioctl call kfree() with variable 'bin' twice. I would prefer a wording like “kfree() was called for the same variable twice within an if branch.”. Fix it by removing the latter one. I find the wording “Delete a duplicate function

[RFC 3/4] drm/sun4i: Reimplement plane z position setting logic

2019-12-29 Thread roman . stratiienko
From: Roman Stratiienko To set blending channel order register software needs to know state and position of each channel, which impossible at plane commit stage. Move this procedure to atomic_flush stage, where all necessary information is available. Signed-off-by: Roman Stratiienko ---

Re: [RFC 3/4] drm/sun4i: Reimplement plane z position setting logic

2019-12-29 Thread Jernej Škrabec
Hi! Dne sobota, 28. december 2019 ob 21:28:17 CET je roman.stratiie...@globallogic.com napisal(a): > From: Roman Stratiienko > > To set blending channel order register software needs to know state and > position of each channel, which impossible at plane commit stage. > > Move this procedure

[RFC 1/4] drm/sun4i: Wait for previous mixing process finish before committing next

2019-12-29 Thread roman . stratiienko
From: Roman Stratiienko Screen composition that requires dynamic layout modification, especially scaling is corrupted when layout changes. For example if one of the layer scales down, misaligned lines can be observed, and dynamic increasing of destination area makes mixer to hang and draw

Re: [RFC 2/4] drm/sun4i: Use CRTC size instead of PRIMARY plane size as mixer frame.

2019-12-29 Thread Jernej Škrabec
Hi! Dne sobota, 28. december 2019 ob 21:28:16 CET je roman.stratiie...@globallogic.com napisal(a): > From: Roman Stratiienko > > According to DRM documentation the only difference between PRIMARY > and OVERLAY plane is that each CRTC must have PRIMARY plane and > OVERLAY are optional. > >

Re: [RFC 3/4] drm/sun4i: Reimplement plane z position setting logic

2019-12-29 Thread Roman Stratiienko
On Sun, Dec 29, 2019 at 2:18 PM Jernej Škrabec wrote: > > Dne nedelja, 29. december 2019 ob 13:08:19 CET je Roman Stratiienko > napisal(a): > > Hello Jernej, > > > > Thank you for review. > > > > On Sun, Dec 29, 2019 at 11:40 AM Jernej Škrabec > wrote: > > > Hi! > > > > > > Dne sobota, 28.

Re: [RFC 4/4] drm/sun4i: Update mixer's internal registers after initialization

2019-12-29 Thread Jernej Škrabec
Hi! Dne sobota, 28. december 2019 ob 21:28:18 CET je roman.stratiie...@globallogic.com napisal(a): > From: Roman Stratiienko > > At system start blink of u-boot ghost framebuffer can be observed. > Fix it. Reviewed-by: Jernej Skrabec Please note that U-Boot to Linux handover may not be

Re: [PATCH] drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

2019-12-29 Thread Markus Elfring
> v3d_submit_cl_ioctl call kfree() with variable 'bin' twice. I would prefer a wording like “kfree() was called for the same variable twice within an if branch.”. > Fix it by removing the latter one. I find the wording “Delete a duplicate function call.” more appropriate. Please add the tag

Re: drm/v3d: remove duplicated kfree in v3d_submit_cl_ioctl

2019-12-29 Thread Markus Elfring
>> Please add the tag “Fixes” to your change description. > > I got the results from "git blame": > git blame -L 570,575 drivers/gpu/drm/v3d/v3d_gem.c … > 0d352a3a8a1f2 (Iago Toral Quiroga 2019-09-16 09:11:25 +0200 571)   >   kfree(bin); > a783a09ee76d6 (Eric Anholt    2019-04-16

Re: Why eglGetDisplay(EGL_DEFAULT_DISPLAY) returns EGL_NO_DISPLAY?

2019-12-29 Thread Pekka Paalanen
On Sat, 21 Dec 2019 02:05:59 +0900 TAEHO NAM wrote: > Hi, I'm new to dri-devel and sorry if this question doesn't fit here. > In my code, the case 1 of getting eglDisplay using EGL_DEFAULT_DISPLAY > failed, but, the case 2 succeeded. > > // Case 1 > egl_.display = eglGetDisplay