Re: Cleanup TTMs delayed delete handling

2020-02-11 Thread Pan, Xinhui
[AMD Official Use Only - Internal Distribution Only] For patch 1/2/3/5/6 Reviewed-by: xinhui pan From: Christian König Sent: Monday, February 10, 2020 11:09:01 PM To: Pan, Xinhui ; amd-...@lists.freedesktop.org ; dri-devel@lists.freedesktop.org Subject:

Re: [PATCH] fbdev: c2p: Use BUILD_BUG() instead of custom solution

2020-02-11 Thread Bartlomiej Zolnierkiewicz
On 2/11/20 9:49 AM, Geert Uytterhoeven wrote: > On Mon, Feb 10, 2020 at 12:16 PM Geert Uytterhoeven > wrote: >> On Sun, Jan 12, 2020 at 6:15 PM Geert Uytterhoeven >> wrote: >>> Replace the call to the custom non-existing function by a standard >>> BUILD_BUG() invocation. >>> >>> Suggested-by:

Re: [PATCH 3/4] drm/i915/display: Remove useless call intel_dp_mst_encoder_cleanup()

2020-02-11 Thread Lisovskiy, Stanislav
On Thu, 2020-01-16 at 17:58 -0800, José Roberto de Souza wrote: > This is a eDP function and it will always returns true for non-eDP > ports. > > Signed-off-by: José Roberto de Souza > --- > drivers/gpu/drm/i915/display/intel_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

[PATCH v3] drm/virtio: add drm_driver.release callback.

2020-02-11 Thread Gerd Hoffmann
Split virtio_gpu_deinit(), move the drm shutdown and release to virtio_gpu_release(). Drop vqs_ready variable, instead use drm_dev_{enter,exit,unplug} to avoid touching hardware after device removal. Tidy up here and there. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h

Re: [PATCH 2/3] ARM: dts: am437x-gp/epos-evm: drop unused panel timings

2020-02-11 Thread Tomi Valkeinen
On 13/01/2020 14:01, Tomi Valkeinen wrote: On 12/12/2019 22:35, Laurent Pinchart wrote: Hi Tomi, On Thu, Dec 12, 2019 at 11:37:51AM +0200, Tomi Valkeinen wrote: On 11/12/2019 18:53, Tony Lindgren wrote: * Laurent Pinchart [191202 13:05]: Hi Tomi, Thank you for the patch. On Thu, Nov 14,

[PATCH v3] drm/cirrus: add drm_driver.release callback.

2020-02-11 Thread Gerd Hoffmann
Move final cleanups from cirrus_pci_remove() to the new callback. Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). Use drm_dev_{enter,exit,unplug} to avoid touching hardware after device removal. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/cirrus/cirrus.c | 43

[PATCH v3] drm/bochs: add drm_driver.release callback.

2020-02-11 Thread Gerd Hoffmann
Call bochs_unload via drm_driver.release to make sure we release stuff when it is safe to do so. Use drm_dev_{enter,exit,unplug} to avoid touching hardware after device removal. Tidy up here and there. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 6 +++---

Re: [PATCH v2] drm/i915: Disable -Wtautological-constant-out-of-range-compare

2020-02-11 Thread Michel Dänzer
On 2020-02-11 7:13 a.m., Nathan Chancellor wrote: > A recent commit in clang added -Wtautological-compare to -Wall, which is > enabled for i915 so we see the following warning: > > ../drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1485:22: warning: > result of comparison of constant

Re: [PATCH] drm/tidss: dispc: Rewrite naive plane positioning code

2020-02-11 Thread Tomi Valkeinen
Hi Ville, On 10/02/2020 18:03, Ville Syrjälä wrote: The usual approach we follow in i915 for things that affect more than one plane is is to collect that state into the crtc state. That way we get to remember it for the planes that are not part of the current commit. And when we have state

Re: [PATCH] fbdev: c2p: Use BUILD_BUG() instead of custom solution

2020-02-11 Thread Geert Uytterhoeven
On Mon, Feb 10, 2020 at 12:16 PM Geert Uytterhoeven wrote: > On Sun, Jan 12, 2020 at 6:15 PM Geert Uytterhoeven > wrote: > > Replace the call to the custom non-existing function by a standard > > BUILD_BUG() invocation. > > > > Suggested-by: Masahiro Yamada > > Signed-off-by: Geert

Re: [Nouveau] [PATCH] drm/nouveau: Fix NULL ptr access in nv50_wndw_prepare_fb()

2020-02-11 Thread Daniel Vetter
On Tue, Feb 11, 2020 at 06:28:47AM +0100, Thomas Zimmermann wrote: > Hi > > I'm surprised that prepare_fb is called with fb == NULL. But, OK Yeah we don't filter that ... maybe an oversight? I'm not sure whether there's any driver that needs to do something special for when the plane is disabled

Re: [PATCH 0/2] Dual licence some files in GPL-2.0 and MIT

2020-02-11 Thread Daniel Vetter
On Mon, Feb 10, 2020 at 04:35:42PM +0100, Emmanuel Vadot wrote: > Hello all, > > We had a discussion a while back with Noralf where he said that he wouldn't > mind dual licence his work under GPL-2 and MIT. > Those files are a problem with BSDs as we cannot include them. > For drm_client.c the

Re: [PATCH v2] drm/virtio: add drm_driver.release callback.

2020-02-11 Thread Daniel Vetter
On Mon, Feb 10, 2020 at 11:08:19AM +0100, Gerd Hoffmann wrote: > Split virtio_gpu_deinit(), move the drm shutdown and release to > virtio_gpu_release(). Also free vbufs in case we can't queue them. > > Signed-off-by: Gerd Hoffmann > --- > drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + >

Re: [PATCH 4/4] drm/sun4i: dsi: Remove incorrect use of runtime PM

2020-02-11 Thread Maxime Ripard
Hi, On Tue, Feb 11, 2020 at 01:28:58AM -0600, Samuel Holland wrote: > The driver currently uses runtime PM to perform some of the module > initialization and cleanup. This has three problems: > > 1) There is no Kconfig dependency on CONFIG_PM, so if runtime PM is >disabled, the driver will

[PATCH 1/4] drm/sun4i: dsi: Remove unused drv from driver context

2020-02-11 Thread Samuel Holland
This member is never used, so remove it. Fixes: 133add5b5ad4 ("drm/sun4i: Add Allwinner A31 MIPI-DSI controller support") Signed-off-by: Samuel Holland --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 4 drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 1 - 2 files changed, 5 deletions(-) diff --git

[PATCH 2/4] drm/sun4i: dsi: Use NULL to signify "no panel"

2020-02-11 Thread Samuel Holland
The continued use of an ERR_PTR to signify "no panel" outside of sun6i_dsi_attach is confusing because it is a double negative. Because the connector always reports itself as connected, there is also the possibility of sending an ERR_PTR to drm_panel_get_modes(), which would crash. Solve both of

[PATCH 4/4] drm/sun4i: dsi: Remove incorrect use of runtime PM

2020-02-11 Thread Samuel Holland
The driver currently uses runtime PM to perform some of the module initialization and cleanup. This has three problems: 1) There is no Kconfig dependency on CONFIG_PM, so if runtime PM is disabled, the driver will not work at all, since the module will never be initialized. 2) The driver

[PATCH 3/4] drm/sun4i: dsi: Allow binding the host without a panel

2020-02-11 Thread Samuel Holland
Currently, the DSI host blocks binding the display pipeline until the panel is available. This unnecessarily prevents other display outpus from working, and adds logspam to dmesg when the panel driver is built as a module (the component master is unsuccessfully brought up several times during

Re: [PATCH v2] drm/cirrus: add drm_driver.release callback.

2020-02-11 Thread Daniel Vetter
On Mon, Feb 10, 2020 at 10:53:10AM +0100, Gerd Hoffmann wrote: > Move final cleanups from cirrus_pci_remove() to the new callback. > Add drm_atomic_helper_shutdown() call to cirrus_pci_remove(). > > Set pointers to NULL after iounmap() and check them before using > them to make sure we don't

Re: [RFC] drm: rework SET_MASTER and DROP_MASTER perm handling

2020-02-11 Thread Pekka Paalanen
On Mon, 10 Feb 2020 19:01:06 + Emil Velikov wrote: > Thanks for having a look Daniel. > > On Fri, 7 Feb 2020 at 13:29, Daniel Vetter wrote: > > > > On Wed, Feb 05, 2020 at 05:48:39PM +, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > This commit reworks the permission

<    1   2