Re: [PATCH v4 05/10] drm/ttm: Add vmap/vunmap to TTM and TTM GEM helpers

2020-10-19 Thread Christian König
Hi Thomas, [SNIP]   +int ttm_bo_vmap(struct ttm_buffer_object *bo, struct dma_buf_map *map) +{ +    struct ttm_resource *mem = >mem; +    int ret; + +    ret = ttm_mem_io_reserve(bo->bdev, mem); +    if (ret) +    return ret; + +    if (mem->bus.is_iomem) { +    void __iomem

Re: [PATCH v4 05/10] drm/ttm: Add vmap/vunmap to TTM and TTM GEM helpers

2020-10-19 Thread Thomas Zimmermann
Hi Christian On 15.10.20 16:08, Christian König wrote: > Am 15.10.20 um 14:38 schrieb Thomas Zimmermann: >> The new functions ttm_bo_{vmap,vunmap}() map and unmap a TTM BO in kernel >> address space. The mapping's address is returned as struct dma_buf_map. >> Each function is a simplified version

Re: [PATCH v4 0/4] drm: panel: add support for TDO tl070wsh30 panel

2020-10-19 Thread Neil Armstrong
On 17/10/2020 08:08, Sam Ravnborg wrote: > Hi Neil. > > On Tue, Sep 29, 2020 at 11:25:17AM +0200, Neil Armstrong wrote: >> Hi Sam, >> >> Is there anything more to change ? > Sorry for taking so long to get back to you on this. > > All patches looks good and are: > Reviewed-by: Sam Ravnborg > >

RE: [PATCH] drm/ast: Avoid to access BMC addressing when P2A is disabled

2020-10-19 Thread Kuo-Hsiang Chou
To Thomas, Thanks and got it. Regards, Kuo-Hsiang Chou -Original Message- From: Thomas Zimmermann [mailto:tzimmerm...@suse.de] Sent: Monday, October 19, 2020 3:42 PM To: Kuo-Hsiang Chou ; David Airlie Cc: Jenmin Yuan ; e...@suse.com; Arc Sung ; dri-devel ; Tommy Huang

Re: [PATCH v3 19/20] drm/tegra: Implement new UAPI

2020-10-19 Thread Mikko Perttunen
On 10/19/20 5:21 AM, Dmitry Osipenko wrote: 07.10.2020 20:12, Mikko Perttunen пишет: +int tegra_drm_ioctl_channel_map(struct drm_device *drm, void *data, + struct drm_file *file) +{ Hello, Mikko! Could you please tell what are the host1x clients that are going

Re: [PATCH] drm: document that user-space should avoid parsing EDIDs

2020-10-19 Thread Pekka Paalanen
On Fri, 16 Oct 2020 16:50:16 +0300 Ville Syrjälä wrote: > On Mon, Oct 12, 2020 at 10:11:01AM +0300, Pekka Paalanen wrote: > > On Fri, 9 Oct 2020 17:20:18 +0300 > > Ville Syrjälä wrote: > > > > > On Fri, Oct 09, 2020 at 04:56:51PM +0300, Pekka Paalanen wrote: > > > > On Fri, 9 Oct 2020

Re: [PATCH] drm/ast: Avoid to access BMC addressing when P2A is disabled

2020-10-19 Thread Thomas Zimmermann
Hi On 19.10.20 09:21, Kuo-Hsiang Chou wrote: To Sirs, Thanks for your answers about the patch and next upstream to kernel-5.9 must follow these rules. Thanks for wanting to contribute. This patch based on kernel-4.9.237 is required by our customers, because my customers said the native

[RFC] drm/hdcp: Max MST content streams

2020-10-19 Thread Anshuman Gupta
Let's define Maximum MST content streams up to four generically which can be supported by modern display controllers. Cc: Sean Paul Cc: Ramalingam C Signed-off-by: Anshuman Gupta --- include/drm/drm_hdcp.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: It appears drm-next TTM cleanup broke something . . .

2020-10-19 Thread Kevin Brace
Hi Dave, Yeah, with the workaround I mentioned in my previous e-mail, OpenChrome DRM does not crash for "ttm_tt_create" member being null. It is still not able to boot X Server due to some other TTM related memory allocation issue it is suffering from. I think making huge changes to TTM during

RE: [PATCH] drm/ast: Avoid to access BMC addressing when P2A is disabled

2020-10-19 Thread Kuo-Hsiang Chou
To Sirs, Thanks for your answers about the patch and next upstream to kernel-5.9 must follow these rules. This patch based on kernel-4.9.237 is required by our customers, because my customers said the native kernel of RHEL/CentOS 7.x is 3.10 and is required to update to 4.9. BTW, how to

Re: [PATCH] au1100fb: Remove NULL pointer check before clk_enable/disable

2020-10-19 Thread Thomas Zimmermann
Hi On 14.10.20 10:21, Xu Wang wrote: > Because clk_enable, clk_disable, clk_prepare, and clk_unprepare already > checked NULL clock parameter, so the additional checks are unnecessary, > just remove them. > > Signed-off-by: Xu Wang Sam convinced me to merge this patch as-is with out the

[PATCH 4/5] drm/ttm: add move old to system to drivers.

2020-10-19 Thread Dave Airlie
From: Dave Airlie Uninline ttm_bo_move_ttm. Eventually want to unhook the unbind out. Reviewed-by: Ben Skeggs Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 15 --- drivers/gpu/drm/nouveau/nouveau_bo.c | 11 +--

[PATCH 5/5] drm/ttm: drop ttm_bo_move_ttm wrapper

2020-10-19 Thread Dave Airlie
From: Dave Airlie The apis to move old/new are in place everywhere so this is no longer needed. --- drivers/gpu/drm/ttm/ttm_bo_util.c | 20 include/drm/ttm/ttm_bo_driver.h | 22 -- 2 files changed, 42 deletions(-) diff --git

[PATCH 1/5] drm/ttm: refactor out common code to setup a new tt backed resource

2020-10-19 Thread Dave Airlie
From: Dave Airlie This factors out the code to setup non-system tt. The same code was used twice in the move paths. Reviewed-by: Ben Skeggs Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo.c | 12 +++ drivers/gpu/drm/ttm/ttm_bo_util.c | 34

[PATCH 2/5] drm/ttm: split out the move to system from move ttm code

2020-10-19 Thread Dave Airlie
From: Dave Airlie Reviewed-by: Ben Skeggs Signed-off-by: Dave Airlie --- drivers/gpu/drm/ttm/ttm_bo_util.c | 38 --- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c index

[PATCH 3/5] drm/ttm: use new move interface for known system->ttm moves

2020-10-19 Thread Dave Airlie
From: Dave Airlie In all 3 drivers there is a case where the driver knows the bo is in SYSTEM so don't call the api that checks that. Reviewed-by: Ben Skeggs Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- drivers/gpu/drm/nouveau/nouveau_bo.c| 3 ++-

[PATCH 0/5] ttm get rid of ttm_bo_move_ttm

2020-10-19 Thread Dave Airlie
This function post removal of the caching stuff was doing 3 jobs, moving non system old ttm to system, moving from system to a new TT and assigning. Instead this series splits it into 3 and only calls the necessary combination from the drivers. This is just a cleaned up and rebased version of

Re: [PATCH] drm/ast: Avoid to access BMC addressing when P2A is disabled

2020-10-19 Thread Thomas Zimmermann
Hi On 16.10.20 23:01, David Airlie wrote: > On Fri, Oct 16, 2020 at 6:03 PM KuoHsiang Chou > wrote: >> >> The patch is upstreamed >> 1. For RHEL7.x, because its native kernel is suggested to update >>from 3.10 to 4.9 on 2 ODM's platform. >> 2. For AST2600. >> 3. For ASTDP. >> 4. v1.11 > >

<    1   2