linux-next: build warning after merge of the drm tree

2020-11-04 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/drm-kms:466: drivers/gpu/drm/drm_crtc.c:236: WARNING: Unexpected indentation. Documentation/gpu/drm-kms:466: drivers/gpu/drm/drm_crtc.c:237: WARNING: Block quote ends without a

Re: [PATCH] drm/virtio: use kvmalloc for large allocations

2020-11-04 Thread Gerd Hoffmann
Hi, > - *ents = kmalloc_array(*nents, sizeof(struct virtio_gpu_mem_entry), > - GFP_KERNEL); > + *ents = kvmalloc_array(*nents, > +sizeof(struct virtio_gpu_mem_entry), > +GFP_KERNEL); Shouldn't that be

linux-next: build warnings after merge of the drm tree

2020-11-04 Thread Stephen Rothwell
Hi all, After merging the drm tree, today's linux-next build (htmldocs) produced these warnings: include/linux/dma-buf-map.h:106: warning: Excess function parameter 'vaddr' description in 'DMA_BUF_MAP_INIT_VADDR' include/linux/dma-buf-map.h:106: warning: Function parameter or member 'vaddr_'

[radeon-alex:drm-next 655/663] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c:802:6: warning: no previous prototype for function 'kgd_gfx_v9_get_cu_occupancy'

2020-11-04 Thread kernel test robot
: x86_64-randconfig-a005-20201104 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 09ec07827b1128504457a93dee80b2ceee1af600) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin

[radeon-alex:amd-staging-drm-next 440/442] drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c:802:6: warning: no previous prototype for 'kgd_gfx_v9_get_cu_occupancy'

2020-11-04 Thread kernel test robot
config: x86_64-randconfig-a012-20201104 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): git remote add radeon-alex git://people.freedesktop.org/~agd5f/linux.git git fetch --no-tags radeon-alex amd-staging-drm-next git checkout

Re: [PATCH v7 36/47] memory: tegra20-emc: Add devfreq support

2020-11-04 Thread Chanwoo Choi
On 11/5/20 1:49 AM, Dmitry Osipenko wrote: > Add devfreq support to the Tegra20 EMC driver. Memory utilization > statistics will be periodically polled from the memory controller and > appropriate minimum clock rate will be selected by the devfreq governor. > > Signed-off-by: Dmitry Osipenko >

Re: [PATCH v7 47/47] PM / devfreq: tegra20: Deprecate in a favor of emc-stat based driver

2020-11-04 Thread Chanwoo Choi
Hi Dmitry, You need to update the MAINTAINERS file about tegra20-devfreq.c 11343 MEMORY FREQUENCY SCALING DRIVERS FOR NVIDIA TEGRA 11344 M: Dmitry Osipenko 11345 L: linux...@vger.kernel.org

Re: [PATCH v7 46/47] PM / devfreq: tegra30: Separate configurations per-SoC generation

2020-11-04 Thread Chanwoo Choi
Hi Dmitry, On 11/5/20 1:49 AM, Dmitry Osipenko wrote: > Previously we were using count-weight of the T124 for T30 in order to > get EMC clock rate that was reasonable for T30. In fact the count-weight > should be x2 times smaller on T30, but then devfreq was producing a bit > too low EMC clock

Re: [PATCH v7 45/47] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

2020-11-04 Thread Chanwoo Choi
Hi Dmitry, On 11/5/20 1:49 AM, Dmitry Osipenko wrote: > This patch moves ACTMON driver away from generating OPP table by itself, > transitioning it to use the table which comes from device-tree. This > change breaks compatibility with older device-trees in order to bring > support for the

Re: [PATCH v8 0/7] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-04 Thread Chanwoo Choi
Hi Sylwester, On 11/4/20 7:36 PM, Sylwester Nawrocki wrote: > This patchset adds interconnect API support for the Exynos SoC "samsung, > exynos-bus" compatible devices, which already have their corresponding > exynos-bus driver in the devfreq subsystem. Complementing the devfreq > driver with an

[PATCH v13 6/7] drm/kmb: Mipi DSI part of the display driver

2020-11-04 Thread Anitha Chrisanthus
Initializes Mipi DSI and sets up connects to ADV bridge v2: removed license text upclassed dev_private, removed HAVE_IRQ. (Sam) v3: Squashed all 59 commits to one v4: review changes from Sam Ravnborg renamed dev_p to kmb v5: corrected spellings v6: corrected checkpatch warnings v7:

[PATCH v13 4/7] drm/kmb: Keem Bay driver register definition

2020-11-04 Thread Anitha Chrisanthus
Register definitions for Keem Bay display driver v2: removed license text (Sam) v3: Squashed all 59 commits to one v4: review changes from Sam Ravnborg renamed dev_p to kmb v5: corrected spellings v6: corrected checkpatch warnings v7: removed redundant definitions v8: removed redundant

[PATCH v13 5/7] drm/kmb: Add support for KeemBay Display

2020-11-04 Thread Anitha Chrisanthus
This is a basic KMS atomic modesetting display driver for KeemBay family of SOCs. Driver has no 2D or 3D graphics. It calls into the ADV bridge driver at the connector level. Single CRTC with LCD controller->mipi DSI->ADV bridge Only 1080p resolution and single plane is supported at this time.

[PATCH v13 2/7] dt-bindings: display: Intel KeemBay MSSCAM

2020-11-04 Thread Anitha Chrisanthus
This patch add bindings for Intel KeemBay MSSCAM syscon v2: fixed compatible (Sam R.) Signed-off-by: Anitha Chrisanthus Cc: Sam Ravnborg Cc: Neil Armstrong Cc: Rob Herring --- .../bindings/display/intel,keembay-msscam.yaml | 43 ++ 1 file changed, 43 insertions(+)

[PATCH v13 7/7] drm/kmb: Build files for KeemBay Display driver

2020-11-04 Thread Anitha Chrisanthus
v2: Added Maintainer entry v3: Added one more Maintainer entry v3: drop videomode_helpers Cc: Sam Ravnborg Signed-off-by: Anitha Chrisanthus Reviewed-by: Sam Ravnborg --- MAINTAINERS | 7 +++ drivers/gpu/drm/Kconfig | 2 ++ drivers/gpu/drm/Makefile | 1 +

[PATCH v13 1/7] dt-bindings: display: Add support for Intel KeemBay Display

2020-11-04 Thread Anitha Chrisanthus
This patch adds bindings for Intel KeemBay Display v2: review changes from Rob Herring v3: review changes from Sam Ravnborg (removed mipi dsi entries, and encoder entry, connect port to dsi) MSSCAM is part of the display submodule and its used to reset LCD and MIPI DSI clocks, so its

[PATCH v13 3/7] dt-bindings: display: bridge: Intel KeemBay DSI

2020-11-04 Thread Anitha Chrisanthus
This patch adds bindings for Intel KeemBay MIPI DSI v2: corrected description for port Signed-off-by: Anitha Chrisanthus Reviewed-by: Sam Ravnborg Reviewed-by: Neil Armstrong Cc: Sam Ravnborg Cc: Thomas Zimmermann Cc: Daniel Vetter Cc: Rob Herring ---

[PATCH v13 0/7] Add support for KeemBay DRM drive

2020-11-04 Thread Anitha Chrisanthus
This is a new DRM driver for Intel's KeemBay SOC. The SoC couples an ARM Cortex A53 CPU with an Intel Movidius VPU. This driver is tested with the KMB EVM board which is the reference baord for Keem Bay SOC. The SOC's display pipeline is as follows +--++-+

linux-next: manual merge of the drm-msm tree with the drm tree

2020-11-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-msm tree got a conflict in: drivers/gpu/drm/msm/msm_drv.h between commit: 3c9edd9c85f5 ("drm/msm: Introduce GEM object funcs") from the drm tree and commit: 8f642378bfe5 ("drm/msm/gem: Move prototypes to msm_gem.h") from the drm-msm tree. I

linux-next: manual merge of the drm-msm tree with the drm tree

2020-11-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-msm tree got a conflict in: include/drm/drm_crtc.h between commit: 5c759eda9b04 ("drm: Introduce plane and CRTC scaling filter properties") from the drm tree and commit: cb21f3f882ad ("drm/msm/atomic: Drop per-CRTC locks in reverse order")

linux-next: manual merge of the drm-msm tree with the drm-misc tree

2020-11-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-msm tree got a conflict in: drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c between commit: 29b77ad7b9ca ("drm/atomic: Pass the full state to CRTC atomic_check") from the drm-misc tree and commit: 91693cbc13c2 ("drm/msm/dpu: Add newline to printks")

Re: linux-next: manual merge of the drm-misc tree with the amdgpu tree

2020-11-04 Thread Stephen Rothwell
Hi all, On Wed, 28 Oct 2020 12:06:31 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c > > between commit: > > ff72bc403170 ("drm/amdgpu: Add debugfs entry for printing VM info") > > from the

RE: [PATCH v7 4/5] RDMA/mlx5: Support dma-buf based userspace memory region

2020-11-04 Thread Xiong, Jianxin
> -Original Message- > From: Jason Gunthorpe > Sent: Wednesday, November 04, 2020 4:07 PM > To: Xiong, Jianxin > Cc: linux-r...@vger.kernel.org; dri-devel@lists.freedesktop.org; Doug Ledford > ; Leon Romanovsky > ; Sumit Semwal ; Christian Koenig > ; Vetter, Daniel > > Subject: Re:

Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

2020-11-04 Thread Chun-Kuang Hu
Hi, Enric: Enric Balletbo i Serra 於 2020年11月4日 週三 下午6:40寫道: > > Hi > > On 5/10/20 18:22, Enric Balletbo i Serra wrote: > > Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver") > > introduced the following build warning with W=1 > > > >

Re: [PATCH 1/4] dt-bindings: vendor-prefixes: Add abt vendor prefix

2020-11-04 Thread Rob Herring
On Sun, 01 Nov 2020 09:31:47 +, Paul Cercueil wrote: > Add prefix for ShenZhen Asia Better Technology Ltd. > > Signed-off-by: Paul Cercueil > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring

Re: [git pull] drm next pull for 5.10-rc1

2020-11-04 Thread Lyude Paul
ACK, I will send out a patch for this asap On Wed, 2020-11-04 at 01:20 +0300, Kirill A. Shutemov wrote: > On Thu, Oct 15, 2020 at 11:33:08AM +1000, Dave Airlie wrote: > >   drm/nouveau/kms: Search for encoders' connectors properly > > This commit (09838c4efe9a) broke boot for me. These two

[PATCH v7 5/5] dma-buf: Reject attach request from importers that use dma_virt_ops

2020-11-04 Thread Jianxin Xiong
dma_virt_ops is used by virtual devices that map pages / scatterlists to virtual addresses for CPU access instead of performing DMA. This is not the intended use of dma_buf_attach() and dma_buf_map_attachment(). CPU access of dma-buf should use dma_buf_vmap() and related functions. Signed-off-by:

[PATCH v7 4/5] RDMA/mlx5: Support dma-buf based userspace memory region

2020-11-04 Thread Jianxin Xiong
Implement the new driver method 'reg_user_mr_dmabuf'. Utilize the core functions to import dma-buf based memory region and update the mappings. Add code to handle dma-buf related page fault. Signed-off-by: Jianxin Xiong Reviewed-by: Sean Hefty Acked-by: Michael J. Ruhl Acked-by: Christian

[PATCH v7 2/5] RDMA/core: Add device method for registering dma-buf based memory region

2020-11-04 Thread Jianxin Xiong
Dma-buf based memory region requires one extra parameter and is processed quite differently. Adding a separate method allows clean separation from regular memory regions. Signed-off-by: Jianxin Xiong Reviewed-by: Sean Hefty Acked-by: Michael J. Ruhl Acked-by: Christian Koenig Acked-by: Daniel

[PATCH v7 3/5] RDMA/uverbs: Add uverbs command for dma-buf based MR registration

2020-11-04 Thread Jianxin Xiong
Implement a new uverbs ioctl method for memory registration with file descriptor as an extra parameter. Signed-off-by: Jianxin Xiong Reviewed-by: Sean Hefty Acked-by: Michael J. Ruhl Acked-by: Christian Koenig Acked-by: Daniel Vetter --- drivers/infiniband/core/uverbs_std_types_mr.c | 112

[PATCH v7 0/5] RDMA: Add dma-buf support

2020-11-04 Thread Jianxin Xiong
This is the seventh version of the patch set. Changelog: v7: * Rebase on top of latest mlx5 MR patch series * Slice dma-buf sg list at runtime instead of creating a new list * Preload the buffer page mapping when the MR is created * Move the 'dma_virt_ops' check into dma_buf_dynamic_attach() v6:

[PATCH v7 1/5] RDMA/umem: Support importing dma-buf as user memory region

2020-11-04 Thread Jianxin Xiong
Dma-buf is a standard cross-driver buffer sharing mechanism that can be used to support peer-to-peer access from RDMA devices. Device memory exported via dma-buf is associated with a file descriptor. This is passed to the user space as a property associated with the buffer allocation. When the

Re: [PATCH v2 1/3] dt-bindings: display: Add a property to deal with WiFi coexistence

2020-11-04 Thread Rob Herring
On Thu, 29 Oct 2020 14:40:16 +0100, Maxime Ripard wrote: > The RaspberryPi4 has both a WiFi chip and HDMI outputs capable of doing > 4k. Unfortunately, the 1440p resolution at 60Hz has a TMDS rate on the > HDMI cable right in the middle of the first Wifi channel. > > Add a property to our HDMI

Re: [PATCH v7 2/3] drm: Add support for the LogiCVC display controller

2020-11-04 Thread Sam Ravnborg
Hi Paul. A few comments in the following. I did not find time to read all of the driver. Sam On Mon, Nov 02, 2020 at 04:53:07PM +0100, Paul Kocialkowski wrote: > Introduces a driver for the LogiCVC display controller, a programmable > logic controller optimized for use in Xilinx

[pull] amdgpu, amdkfd drm-fixes-5.10

2020-11-04 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.10. The support for green sardine is not exactly a fix, but the changes are a minimal delta relative to renoir and should not affect any other asics. The following changes since commit 7babd126327b8b5a3904d2f8f01c95235801af2a: Merge tag

Re: [Freedreno] [PATCH v5 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-11-04 Thread Rob Clark
On Wed, Nov 4, 2020 at 12:03 PM Rob Herring wrote: > > On Fri, 30 Oct 2020 16:17:12 +0530, Akhil P Oommen wrote: > > Add cooling device support to gpu. A cooling device is bound to a > > thermal zone to allow thermal mitigation. > > > > Signed-off-by: Akhil P Oommen > > Reviewed-by: Matthias

Re: [PATCH v5 11/15] PCI: Obey iomem restrictions for procfs mmap

2020-11-04 Thread Dan Williams
On Wed, Nov 4, 2020 at 8:50 AM Bjorn Helgaas wrote: > > On Wed, Nov 04, 2020 at 09:44:04AM +0100, Daniel Vetter wrote: > > On Tue, Nov 3, 2020 at 11:09 PM Dan Williams > > wrote: > > > On Tue, Nov 3, 2020 at 1:28 PM Bjorn Helgaas wrote: > > > > On Fri, Oct 30, 2020 at 11:08:11AM +0100, Daniel

Re: [bugreport] [5.10-rc1] Oops: 0000 [#1] SMP NOPTI bug which always starts as page allocation failure

2020-11-04 Thread Alex Deucher
On Tue, Nov 3, 2020 at 4:05 PM Mikhail Gavrilov wrote: > > Hi folks. > I observed hard reproductible the set of bugs. > It always started as > 1) kworker/u64:2: page allocation failure: order:5, > mode:0x40dc0(GFP_KERNEL|__GFP_COMP|__GFP_ZERO), > nodemask=(null),cpuset=/,mems_allowed=0 >

Re: [PATCH v5 3/3] dt-bindings: drm/msm/gpu: Add cooling device support

2020-11-04 Thread Rob Herring
On Fri, 30 Oct 2020 16:17:12 +0530, Akhil P Oommen wrote: > Add cooling device support to gpu. A cooling device is bound to a > thermal zone to allow thermal mitigation. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Matthias Kaehlcke > --- >

Re: [PATCH] drm/amdkfd: replace idr_init() by idr_init_base()

2020-11-04 Thread Felix Kuehling
On 2020-11-04 10:13 a.m., Deepak R Varma wrote: idr_init() uses base 0 which is an invalid identifier. The new function idr_init_base allows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused. I disagree. We call idr_alloc with

[PATCH 30/36] tty: serial: serial-tegra: Provide some missing struct member descriptions

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/tty/serial/serial-tegra.c:94: warning: Function parameter or member 'fifo_mode_enable_status' not described in 'tegra_uart_chip_data' drivers/tty/serial/serial-tegra.c:94: warning: Function parameter or member 'uart_max_port' not

[PATCH 24/36] tty: serial: serial-tegra: Struct headers should start with 'struct '

2020-11-04 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/tty/serial/serial-tegra.c:85: warning: cannot understand function prototype: 'struct tegra_uart_chip_data ' Cc: Laxman Dewangan Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: Thierry Reding Cc: Jonathan Hunter Cc: Philipp Zabel Cc:

[PATCH 00/36] Rid W=1 issues from TTY

2020-11-04 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (36): tty: serdev: core: Remove unused variable 'dummy' tty: serdev: core: Provide missing description for 'owner' tty:

Re: [PATCH V2] drm/tegra: sor: Don't warn on probe deferral

2020-11-04 Thread Jon Hunter
On 04/11/2020 10:49, Dmitry Osipenko wrote: > 04.11.2020 12:23, Jon Hunter пишет: >> Deferred probe is an expected return value for tegra_output_probe(). >> Given that the driver deals with it properly, there's no need to output >> a warning that may potentially confuse users. >> >>

Re: [PATCH] dt-bindings: display: mcde: Convert to YAML schema

2020-11-04 Thread Rob Herring
On Wed, Nov 04, 2020 at 02:37:09PM +0100, Linus Walleij wrote: > This moves the MCDE bindings over to using the YAML schema > to describe the ST-Ericsson MCDE display controller, > making use of the generic DSI controller schema. > > We also add the "port" node, we will use this when adding > LCD

Re: [PATCH] dt-bindings: display: mcde: Convert to YAML schema

2020-11-04 Thread Rob Herring
On Wed, 04 Nov 2020 14:37:09 +0100, Linus Walleij wrote: > This moves the MCDE bindings over to using the YAML schema > to describe the ST-Ericsson MCDE display controller, > making use of the generic DSI controller schema. > > We also add the "port" node, we will use this when adding > LCD

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-11-04 Thread John Hubbard
On 11/4/20 10:17 AM, Jason Gunthorpe wrote: On Wed, Nov 04, 2020 at 04:41:19PM +, Christoph Hellwig wrote: On Wed, Nov 04, 2020 at 04:37:58PM +, Christoph Hellwig wrote: On Wed, Nov 04, 2020 at 05:26:58PM +0100, Daniel Vetter wrote: What we're discussing is whether gup_fast and

Re: [PATCH v7 1/3] dt-bindings: display: Document the Xylon LogiCVC display controller

2020-11-04 Thread Rob Herring
On Mon, 02 Nov 2020 16:53:06 +0100, Paul Kocialkowski wrote: > The Xylon LogiCVC is a display controller implemented as programmable > logic in Xilinx FPGAs. > > Signed-off-by: Paul Kocialkowski > Acked-by: Rob Herring > --- > .../display/xylon,logicvc-display.yaml| 313

Re: [PATCH 1/4] drm/radeon: stop using pages with drm_prime_sg_to_page_addr_arrays

2020-11-04 Thread Daniel Vetter
On Wed, Nov 04, 2020 at 02:00:21PM +0100, Christian König wrote: > This is deprecated. > > Signed-off-by: Christian König So I tried to prove to myself that ttm doesn't access ->pages for these cases, and kinda couldn't. We still seem to allocate the pages array and all that, and there's lots

Re: [Freedreno] [PATCH v2 3/4] drm/msm: register the base address with dpu_dbg module

2020-11-04 Thread Rob Clark
On Thu, Oct 29, 2020 at 6:01 PM Abhinav Kumar wrote: > > Register the base address of various dpu sub-modules with the > dpu_dbg module so that it can be dumped out during error scenarios. > > changes in v2: > - Fix an issue where the same dsi client was getting registered >multiple times to

Re: [PATCH v4] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-04 Thread Boris Brezillon
+amdgpu maintainers On Wed, 4 Nov 2020 18:07:29 +0100 Boris Brezillon wrote: > We've fixed many races in panfrost_job_timedout() but some remain. > Instead of trying to fix it again, let's simplify the logic and move > the reset bits to a separate work scheduled when one of the queue > reports

[PATCH v4] drm/panfrost: Move the GPU reset bits outside the timeout handler

2020-11-04 Thread Boris Brezillon
We've fixed many races in panfrost_job_timedout() but some remain. Instead of trying to fix it again, let's simplify the logic and move the reset bits to a separate work scheduled when one of the queue reports a timeout. v4: - Rework the logic to prevent a race between drm_sched_start() (reset

[PATCH v2] drm: document that blobs are ref'counted

2020-11-04 Thread Simon Ser
User-space doesn't need to keep track of blobs that might be in use by the kernel. User-space can just destroy blobs as soon as they don't need them anymore. Signed-off-by: Simon Ser Signed-off-by: Daniel Stone Reviewed-by: Jonas Ådahl Cc: Pekka Paalanen Cc: Daniel Vetter ---

Re: [PATCH] drm: document that blobs are ref'counted

2020-11-04 Thread Simon Ser
On Sunday, November 1, 2020 10:07 PM, Daniel Stone wrote: > > Daniel, does this patch look good to you? > > Unsure which Daniel you meant I was thinking of Daniel Vetter :P > but I would probably instead say: > 'Userspace can release blobs as soon as they do not need to refer to > them by

[PATCH] drm/ttm: don't set page->mapping

2020-11-04 Thread Daniel Vetter
Random observation while trying to review Christian's patch series to stop looking at struct page for dma-buf imports. This was originally added in commit 58aa6622d32af7d2c08d45085f44c54554a16ed7 Author: Thomas Hellstrom Date: Fri Jan 3 11:47:23 2014 +0100 drm/ttm: Correctly set page

Re: [PATCH v5 11/15] PCI: Obey iomem restrictions for procfs mmap

2020-11-04 Thread Bjorn Helgaas
On Wed, Nov 04, 2020 at 09:44:04AM +0100, Daniel Vetter wrote: > On Tue, Nov 3, 2020 at 11:09 PM Dan Williams wrote: > > On Tue, Nov 3, 2020 at 1:28 PM Bjorn Helgaas wrote: > > > On Fri, Oct 30, 2020 at 11:08:11AM +0100, Daniel Vetter wrote: > > > > There's three ways to access PCI BARs from

Re: [PATCH 4/4] drm/prime: document that use the page array is deprecated v3

2020-11-04 Thread Daniel Vetter
On Wed, Nov 04, 2020 at 02:00:24PM +0100, Christian König wrote: > We have reoccurring requests on this so better document that > this approach doesn't work and dma_buf_mmap() needs to be used instead. > > v2: split it into two functions > v3: rebased on latest changes > > Signed-off-by:

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-11-04 Thread Daniel Vetter
On Wed, Nov 4, 2020 at 5:21 PM Christoph Hellwig wrote: > > On Wed, Nov 04, 2020 at 04:54:19PM +0100, Daniel Vetter wrote: > > I don't really have a box here, but dma_mmap_attrs() and friends to > > mmap dma_alloc_coherent memory is set up as VM_IO | VM_PFNMAP (it's > > actually enforced since

Re: [PATCH 0/2] amdgpu's drm_driver becomes const

2020-11-04 Thread Luben Tuikov
On 2020-11-04 04:43, Daniel Vetter wrote: > On Tue, Nov 03, 2020 at 10:11:27PM -0500, Luben Tuikov wrote: >> Hi Daniel, >> >> These two patches follow up your latest >> DRM work to make definitions of struct drm_driver >> in DRM low-level drivers, constant, in amdgpu. >> >> This set doesn't

Re: [PATCH v5 05/15] mm/frame-vector: Use FOLL_LONGTERM

2020-11-04 Thread Daniel Vetter
On Wed, Nov 4, 2020 at 3:00 PM Jason Gunthorpe wrote: > > On Sun, Nov 01, 2020 at 11:50:39PM +0100, Daniel Vetter wrote: > > > It's not device drivers, but everyone else. At least my understanding > > is that VM_IO | VM_PFNMAP means "even if it happens to be backed by a > > struct page, do not

Re: [PATCH v3 3/3] backlight: pwm_bl: Fix interpolation

2020-11-04 Thread Lee Jones
On Wed, 21 Oct 2020, Alexandru Stan wrote: > The previous behavior was a little unexpected, its properties/problems: > 1. It was designed to generate strictly increasing values (no repeats) > 2. It had quantization errors when calculating step size. Resulting in > unexpected jumps near the end of

Re: [PATCH] drm/amdkfd: replace idr_init() by idr_init_base()

2020-11-04 Thread Christian König
Am 04.11.20 um 16:13 schrieb Deepak R Varma: idr_init() uses base 0 which is an invalid identifier. The new function idr_init_base allows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused. References: commit 6ce711f27500 ("idr:

Re: [PATCH] drm/amdgpu: replace idr_init() by idr_init_base()

2020-11-04 Thread Christian König
Am 04.11.20 um 16:16 schrieb Deepak R Varma: idr_init() uses base 0 which is an invalid identifier. The new function idr_init_base allows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused. References: commit 6ce711f27500 ("idr:

Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-04 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 02:22:37PM +0100, Sylwester Nawrocki wrote: > On 04.11.2020 13:37, Krzysztof Kozlowski wrote: > > On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote: > > >> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile > >> index

[PATCH] dt-bindings: display: mcde: Convert to YAML schema

2020-11-04 Thread Linus Walleij
This moves the MCDE bindings over to using the YAML schema to describe the ST-Ericsson MCDE display controller, making use of the generic DSI controller schema. We also add the "port" node, we will use this when adding LCD panels using the direct parallel interface DPI instead of DSI. Cc:

Re: [PATCH v8 3/7] MAINTAINERS: Add entry for Samsung interconnect drivers

2020-11-04 Thread Sylwester Nawrocki
On 04.11.2020 13:27, Krzysztof Kozlowski wrote: > On Wed, Nov 04, 2020 at 11:36:53AM +0100, Sylwester Nawrocki wrote: >> Add maintainers entry for the Samsung interconnect drivers, this currently >> includes Exynos SoC generic interconnect driver. >> >> Signed-off-by: Sylwester Nawrocki >> diff

Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-04 Thread Sylwester Nawrocki
On 04.11.2020 13:37, Krzysztof Kozlowski wrote: > On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote: >> diff --git a/drivers/interconnect/Makefile b/drivers/interconnect/Makefile >> index d203520..c2f9e9d 100644 >> --- a/drivers/interconnect/Makefile >> +++

Re: [PATCH] drm/amdgpu/virt: fix handling of the atomic flag

2020-11-04 Thread Alex Deucher
On Wed, Nov 4, 2020 at 4:39 AM Daniel Vetter wrote: > > On Tue, Nov 03, 2020 at 04:54:50PM -0500, Alex Deucher wrote: > > Use the per device drm driver feature flags rather than the > > global one. This way we can make the drm driver struct const. > > > > Signed-off-by: Alex Deucher > >

[PATCH 4/4] drm/prime: document that use the page array is deprecated v3

2020-11-04 Thread Christian König
We have reoccurring requests on this so better document that this approach doesn't work and dma_buf_mmap() needs to be used instead. v2: split it into two functions v3: rebased on latest changes Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 9 ++-

[PATCH 3/4] drm/nouveau: stop using pages with drm_prime_sg_to_page_addr_arrays

2020-11-04 Thread Christian König
This is deprecated, also drop the comment about faults. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_bo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index

[PATCH 1/4] drm/radeon: stop using pages with drm_prime_sg_to_page_addr_arrays

2020-11-04 Thread Christian König
This is deprecated. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_ttm.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 95038ac3382e..f41fcee35f70 100644 ---

[PATCH 2/4] drm/amdgpu: stop using pages with drm_prime_sg_to_page_addr_arrays

2020-11-04 Thread Christian König
This is deprecated. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index c01c060e4ac5..d6781b479839 100644 ---

Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-04 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 11:36:52AM +0100, Sylwester Nawrocki wrote: > This patch adds a generic interconnect driver for Exynos SoCs in order > to provide interconnect functionality for each "samsung,exynos-bus" > compatible device. > > The SoC topology is a graph (or more specifically, a tree)

Re: [PATCH v8 7/7] drm: exynos: mixer: Add interconnect support

2020-11-04 Thread Chanwoo Choi
Hi Sylwester, On Wed, Nov 4, 2020 at 7:37 PM Sylwester Nawrocki wrote: > > This patch adds interconnect support to exynos-mixer. The mixer works > the same as before when CONFIG_INTERCONNECT is 'n'. > > For proper operation of the video mixer block we need to ensure the > interconnect busses

Re: [PATCH v8 5/7] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes

2020-11-04 Thread Chanwoo Choi
Hi Sylwester, On Wed, Nov 4, 2020 at 7:37 PM Sylwester Nawrocki wrote: > > This patch adds the following properties for Exynos4412 interconnect > bus nodes: > - interconnects: to declare connections between nodes in order to >guarantee PM QoS requirements between nodes, > -

Re: [PATCH v8 3/7] MAINTAINERS: Add entry for Samsung interconnect drivers

2020-11-04 Thread Chanwoo Choi
Hi Sylwester, On Wed, Nov 4, 2020 at 7:37 PM Sylwester Nawrocki wrote: > > Add maintainers entry for the Samsung interconnect drivers, this currently > includes Exynos SoC generic interconnect driver. > > Signed-off-by: Sylwester Nawrocki > --- > Changes since v7: > - new patch. > --- >

Re: [PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-04 Thread Chanwoo Choi
Hi Sylwester, On Wed, Nov 4, 2020 at 7:37 PM Sylwester Nawrocki wrote: > > This patch adds a generic interconnect driver for Exynos SoCs in order > to provide interconnect functionality for each "samsung,exynos-bus" > compatible device. > > The SoC topology is a graph (or more specifically, a

Re: [PATCH v8 1/7] dt-bindings: devfreq: Add documentation for the interconnect properties

2020-11-04 Thread Chanwoo Choi
Hi Sylwester, On Wed, Nov 4, 2020 at 7:37 PM Sylwester Nawrocki wrote: > > Add documentation for new optional properties in the exynos bus nodes: > interconnects, #interconnect-cells, samsung,data-clock-ratio. > These properties allow to specify the SoC interconnect structure which > then allows

Re: [PATCH v8 3/7] MAINTAINERS: Add entry for Samsung interconnect drivers

2020-11-04 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 11:36:53AM +0100, Sylwester Nawrocki wrote: > Add maintainers entry for the Samsung interconnect drivers, this currently > includes Exynos SoC generic interconnect driver. > > Signed-off-by: Sylwester Nawrocki > --- > Changes since v7: > - new patch. > --- > MAINTAINERS

Re: [PATCH v8 1/7] dt-bindings: devfreq: Add documentation for the interconnect properties

2020-11-04 Thread Krzysztof Kozlowski
On Wed, Nov 04, 2020 at 11:36:51AM +0100, Sylwester Nawrocki wrote: > Add documentation for new optional properties in the exynos bus nodes: > interconnects, #interconnect-cells, samsung,data-clock-ratio. > These properties allow to specify the SoC interconnect structure which > then allows the

Re: [PATCH 0/4] soc: mediatek: Prepare MMSYS for DDP routing using tables

2020-11-04 Thread Enric Balletbo i Serra
Hi Matthias, On 6/10/20 21:33, Enric Balletbo i Serra wrote: > Dear all, > > The following series are intended to prepare the mtk-mmsys driver to > allow different DDP (Data Display Path) routing tables per SoC. Note > that the series has been tested only on MT8173 platform and could break > the

[PATCH] drm/i915/gvt: replace idr_init() by idr_init_base()

2020-11-04 Thread Deepak R Varma
idr_init() uses base 0 which is an invalid identifier. The new function idr_init_base allows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused. References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient")

Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

2020-11-04 Thread Enric Balletbo i Serra
Hi On 5/10/20 18:22, Enric Balletbo i Serra wrote: > Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver") > introduced the following build warning with W=1 > > drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable > 'mtk_dpi_encoder_funcs'

Re: [PATCH V2] drm/tegra: sor: Don't warn on probe deferral

2020-11-04 Thread Dmitry Osipenko
04.11.2020 12:23, Jon Hunter пишет: > Deferred probe is an expected return value for tegra_output_probe(). > Given that the driver deals with it properly, there's no need to output > a warning that may potentially confuse users. > > Signed-off-by: Jon Hunter > --- > > Changes since V1: > - This

[PATCH] drm/vgm: replace idr_init() by idr_init_base()

2020-11-04 Thread Deepak R Varma
idr_init() uses base 0 which is an invalid identifier. The new function idr_init_base allows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused. References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient")

Re: [PATCH] drm/panfrost: Replace devm_reset_control_array_get()

2020-11-04 Thread Steven Price
On 03/11/2020 01:48, Yejune Deng wrote: devm_reset_control_array_get_optional_exclusive() looks more readable Signed-off-by: Yejune Deng Reviewed-by: Steven Price Thanks, I'll push this to drm-misc-next. Steve --- drivers/gpu/drm/panfrost/panfrost_device.c | 2 +- 1 file changed, 1

Re: [PATCH] dt-bindings: display: panel-simple: Allow optional 'ports' property

2020-11-04 Thread Sam Ravnborg
Hi Liu Ying On Wed, Nov 04, 2020 at 04:03:37PM +0800, Liu Ying wrote: > Some simple panels have dual LVDS interfaces which receive even and odd > pixels respectively, like 'nlt,nl192108ac18-02d' and 'koe,tx26d202vm0bwa'. > So, let's allow optional 'ports' property so that pixel order can be got >

[PATCH v8 7/7] drm: exynos: mixer: Add interconnect support

2020-11-04 Thread Sylwester Nawrocki
This patch adds interconnect support to exynos-mixer. The mixer works the same as before when CONFIG_INTERCONNECT is 'n'. For proper operation of the video mixer block we need to ensure the interconnect busses like DMC or LEFTBUS provide enough bandwidth so as to avoid DMA buffer underruns in the

[PATCH v8 0/7] Exynos: Simple QoS for exynos-bus using interconnect

2020-11-04 Thread Sylwester Nawrocki
This patchset adds interconnect API support for the Exynos SoC "samsung, exynos-bus" compatible devices, which already have their corresponding exynos-bus driver in the devfreq subsystem. Complementing the devfreq driver with an interconnect functionality allows to ensure the QoS requirements of

[PATCH v8 4/7] PM / devfreq: exynos-bus: Add registration of interconnect child device

2020-11-04 Thread Sylwester Nawrocki
This patch adds registration of a child platform device for the exynos interconnect driver. It is assumed that the interconnect provider will only be needed when #interconnect-cells property is present in the bus DT node, hence the child device will be created only when such a property is present.

[PATCH v8 3/7] MAINTAINERS: Add entry for Samsung interconnect drivers

2020-11-04 Thread Sylwester Nawrocki
Add maintainers entry for the Samsung interconnect drivers, this currently includes Exynos SoC generic interconnect driver. Signed-off-by: Sylwester Nawrocki --- Changes since v7: - new patch. --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH v8 5/7] ARM: dts: exynos: Add interconnect properties to Exynos4412 bus nodes

2020-11-04 Thread Sylwester Nawrocki
This patch adds the following properties for Exynos4412 interconnect bus nodes: - interconnects: to declare connections between nodes in order to guarantee PM QoS requirements between nodes, - #interconnect-cells: required by the interconnect framework, - samsung,data-clk-ratio: which allows

[PATCH v8 1/7] dt-bindings: devfreq: Add documentation for the interconnect properties

2020-11-04 Thread Sylwester Nawrocki
Add documentation for new optional properties in the exynos bus nodes: interconnects, #interconnect-cells, samsung,data-clock-ratio. These properties allow to specify the SoC interconnect structure which then allows the interconnect consumer devices to request specific bandwidth requirements.

[PATCH v8 6/7] ARM: dts: exynos: Add interconnects to Exynos4412 mixer

2020-11-04 Thread Sylwester Nawrocki
From: Artur Świgoń This patch adds an 'interconnects' property to Exynos4412 DTS in order to declare the interconnect path used by the mixer. Please note that the 'interconnect-names' property is not needed when there is only one path in 'interconnects', in which case calling of_icc_get() with a

[PATCH v8 2/7] interconnect: Add generic interconnect driver for Exynos SoCs

2020-11-04 Thread Sylwester Nawrocki
This patch adds a generic interconnect driver for Exynos SoCs in order to provide interconnect functionality for each "samsung,exynos-bus" compatible device. The SoC topology is a graph (or more specifically, a tree) and its edges are described by specifying in the 'interconnects' property the

Re: use of dma_direct_set_offset in (allwinner) drivers

2020-11-04 Thread Robin Murphy
On 2020-11-04 08:14, Maxime Ripard wrote: Hi Christoph, On Tue, Nov 03, 2020 at 10:55:38AM +0100, Christoph Hellwig wrote: Linux 5.10-rc1 switched from having a single dma offset in struct device to a set of DMA ranges, and introduced a new helper to set them, dma_direct_set_offset. This in

[PATCH 2/6] drm: Compile out legacy chunks from struct drm_device

2020-11-04 Thread Daniel Vetter
This means some very few #ifdef in code, but it allows us to enlist the compiler to make sure this stuff isn't used anymore. More important, only legacy drivers change drm_device (for the legacy_dev_list shadow attach management), therefore this is prep to allow modern drivers to have a const

[PATCH 3/6] drm/amdgpu/virt: fix handling of the atomic flag

2020-11-04 Thread Daniel Vetter
From: Alex Deucher Use the per device drm driver feature flags rather than the global one. This way we can make the drm driver struct const. Signed-off-by: Alex Deucher Reviewed-by: Luben Tuikov Signed-off-by: Daniel Vetter --- drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 +++- 1 file

[PATCH 5/6] drm/: Constify struct drm_driver

2020-11-04 Thread Daniel Vetter
Only the following drivers aren't converted: - amdgpu, because of the driver_feature mangling due to virt support. Subsequent patch will address this. - nouveau, because DRIVER_ATOMIC uapi is still not the default on the platforms where it's supported (i.e. again driver_feature mangling) -

[PATCH 4/6] drm: Allow const struct drm_driver

2020-11-04 Thread Daniel Vetter
It's nice if a big function/ioctl table like this is const. Only downside here is that we need a few more #ifdef to paper over the differences when CONFIG_DRM_LEGACY is enabled. Maybe provides more motivation to sunset that horror show :-) v2: - Fix super important checkpatch warning (Sam) -

  1   2   >