Re: [PULL] fixes around VM_PFNMAP and follow_pfn for 5.12 merge window

2021-02-22 Thread Daniel Vetter
On Tue, Feb 23, 2021 at 2:42 AM Linus Torvalds wrote: > > On Mon, Feb 22, 2021 at 2:25 AM Daniel Vetter wrote: > > > > Cc all the mailing lists ... my usual script crashed and I had to > > hand-roll the email and screwed it up ofc :-/ > > Oh, and my reply thus also became just a reply to you

[PATCH] drm/amd/display: Remove unnecessary conversion to bool

2021-02-22 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8260:16-21: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1

RE: [PATCH 2/2] drm/dp_mst: Set CLEAR_PAYLOAD_ID_TABLE as broadcast

2021-02-22 Thread Lin, Wayne
[AMD Public Use] > -Original Message- > From: Ville Syrjälä > Sent: Tuesday, February 23, 2021 1:00 AM > To: Lin, Wayne > Cc: dri-devel@lists.freedesktop.org; Brol, Eryk ; Zhuo, > Qingqing ; > sta...@vger.kernel.org; Zuo, Jerry ; Kazlauskas, Nicholas > ; Dhinakaran > Pandiyan >

RE: [PATCH 1/2] drm/dp_mst: Revise broadcast msg lct & lcr

2021-02-22 Thread Lin, Wayne
[AMD Public Use] > -Original Message- > From: Ville Syrjälä > Sent: Tuesday, February 23, 2021 1:09 AM > To: Lin, Wayne > Cc: Brol, Eryk ; Zhuo, Qingqing ; > sta...@vger.kernel.org; Zuo, Jerry > ; dri-devel@lists.freedesktop.org; Kazlauskas, Nicholas > > Subject: Re: [PATCH 1/2]

[PATCH] drm/amdgpu: Remove unnecessary conversion to bool

2021-02-22 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:79:40-45: WARNING: conversion to bool not needed here. ./drivers/gpu/drm/amd/amdgpu/athub_v2_1.c:81:40-45: WARNING: conversion to bool not needed here. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong ---

Re: [PULL] fixes around VM_PFNMAP and follow_pfn for 5.12 merge window

2021-02-22 Thread Linus Torvalds
On Mon, Feb 22, 2021 at 2:25 AM Daniel Vetter wrote: > > Cc all the mailing lists ... my usual script crashed and I had to > hand-roll the email and screwed it up ofc :-/ Oh, and you also didn't get a pr-tracker-bot response for this for the same reason. Even your fixed email was ignored by the

Re: [PULL] topic/kcmp-kconfig

2021-02-22 Thread pr-tracker-bot
The pull request you sent on Mon, 22 Feb 2021 10:37:27 +0100: > git://anongit.freedesktop.org/drm/drm tags/topic/kcmp-kconfig-2021-02-22 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4b5f9254e4f4375ac845cb17f1732037dd8adeeb Thank you! -- Deet-doot-dot, I am a bot.

Re: [PULL] fixes around VM_PFNMAP and follow_pfn for 5.12 merge window

2021-02-22 Thread Linus Torvalds
On Mon, Feb 22, 2021 at 2:25 AM Daniel Vetter wrote: > > Cc all the mailing lists ... my usual script crashed and I had to > hand-roll the email and screwed it up ofc :-/ Oh, and my reply thus also became just a reply to you personally. So repeating it here, in case somebody has comments about

Re: [PATCHv1 5/6] dt-bindings: mtd: jedec,spi-nor: add sst25vf032b

2021-02-22 Thread Sebastian Reichel
Hi, On Mon, Feb 22, 2021 at 06:15:11PM -0600, Rob Herring wrote: > On Mon, Feb 22, 2021 at 11:13 AM Sebastian Reichel > wrote: > > > > The binding is already used by the driver. Update documentation > > accordingly. > > > > Signed-off-by: Sebastian Reichel > > --- > >

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Sebastian Reichel
Hi, On Mon, Feb 22, 2021 at 10:26:26PM +0100, Alexandre Belloni wrote: > On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote: > > On 22/02/2021 18:12:42+0100, Sebastian Reichel wrote: > > > Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The > > > modules SQW clock output defaults

Re: [PATCH RFC v1 5/6] xen-swiotlb: convert variables to arrays

2021-02-22 Thread Stefano Stabellini
On Fri, 19 Feb 2021, Konrad Rzeszutek Wilk wrote: > On Sun, Feb 07, 2021 at 04:56:01PM +0100, Christoph Hellwig wrote: > > On Thu, Feb 04, 2021 at 09:40:23AM +0100, Christoph Hellwig wrote: > > > So one thing that has been on my mind for a while: I'd really like > > > to kill the separate dma ops

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-22 Thread Bas Nieuwenhuizen
I think Alex moved to gitlab for his branches On Tue, Feb 23, 2021, 12:50 AM Simon Ser wrote: > On Tuesday, February 23rd, 2021 at 12:44 AM, Nathan Chancellor < > nat...@kernel.org> wrote: > > > On Mon, Feb 22, 2021 at 11:05:17PM +, Simon Ser wrote: > > > On Monday, February 22nd, 2021 at

Re: [PATCHv1 5/6] dt-bindings: mtd: jedec,spi-nor: add sst25vf032b

2021-02-22 Thread Rob Herring
On Mon, Feb 22, 2021 at 11:13 AM Sebastian Reichel wrote: > > The binding is already used by the driver. Update documentation > accordingly. > > Signed-off-by: Sebastian Reichel > --- > Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 1 + > 1 file changed, 1 insertion(+) This is now

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-22 Thread Nathan Chancellor
On Mon, Feb 22, 2021 at 11:50:06PM +, Simon Ser wrote: > On Tuesday, February 23rd, 2021 at 12:44 AM, Nathan Chancellor > wrote: > > > On Mon, Feb 22, 2021 at 11:05:17PM +, Simon Ser wrote: > > > On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder > > > wrote: > > > > > > > >>

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-22 Thread Simon Ser
On Tuesday, February 23rd, 2021 at 12:44 AM, Nathan Chancellor wrote: > On Mon, Feb 22, 2021 at 11:05:17PM +, Simon Ser wrote: > > On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder > > wrote: > > > > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: > > >

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-22 Thread Nathan Chancellor
On Mon, Feb 22, 2021 at 11:05:17PM +, Simon Ser wrote: > On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder > wrote: > > > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: > > >> warning: variable 'i' is uninitialized when used here > > >> [-Wuninitialized] >

Re: [PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-22 Thread Simon Ser
On Monday, February 22nd, 2021 at 8:25 PM, Souptick Joarder wrote: > >> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: > >> warning: variable 'i' is uninitialized when used here > >> [-Wuninitialized] >timing = >detailed_timings[i]; >

[PATCH] drm/amdgpu/display: initialize the variable 'i'

2021-02-22 Thread Souptick Joarder
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:9804:38: >> warning: variable 'i' is uninitialized when used here >> [-Wuninitialized] timing = >detailed_timings[i]; ^

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Alexandre Belloni
On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote: > On 22/02/2021 18:12:42+0100, Sebastian Reichel wrote: > > Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The > > modules SQW clock output defaults to 32768 Hz. This behaviour is > > used to provide the i.MX6 CKIL clock. Once the

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Alexandre Belloni
On 22/02/2021 18:12:42+0100, Sebastian Reichel wrote: > Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The > modules SQW clock output defaults to 32768 Hz. This behaviour is > used to provide the i.MX6 CKIL clock. Once the RTC driver is probed, > the clock is disabled and all i.MX6

[PATCH] drivers: gpu: drm: bridge: fix kconfig dependency on DRM_KMS_HELPER

2021-02-22 Thread Julian Braha
When DRM_TOSHIBA_TC358762 is enabled and DRM_KMS_HELPER is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for DRM_PANEL_BRIDGE Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && DRM_KMS_HELPER [=n] Selected by [y]: - DRM_TOSHIBA_TC358762 [=y] &&

Re: [PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-02-22 Thread Orson Zhai
On Mon, Feb 22, 2021 at 9:28 PM Kevin Tang wrote: > > Adds drm support for the Unisoc's display subsystem. > > This is drm kms driver, this driver provides support for the > application framework in Android, Yocto and more. > > Application framework can access Unisoc's display internel >

Re: [PATCH] drm/amdgpu/sdma5.2: Remove unnecessary conversion to bool

2021-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Feb 20, 2021 at 3:35 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1621:40-45: WARNING: conversion > to bool not needed here. > > ./drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c:1619:40-45: WARNING:

Re: [PATCH] drm/amd/display/dc/core/dc_link_ddc: Remove unnecessary conversion to bool

2021-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Sat, Feb 20, 2021 at 2:16 AM Jiapeng Chong wrote: > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c:544:34-39: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong

Re: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool

2021-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Feb 21, 2021 at 10:15 PM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Reviewed-by: Evan Quan > > -Original Message- > From: amd-gfx On Behalf Of Jiapeng > Chong > Sent: Saturday, February 20, 2021 10:55 AM > To:

Re: [PATCH] drm/amd/pm/swsmu: Avoid using structure_size uninitialized in smu_cmn_init_soft_gpu_metrics

2021-02-22 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Feb 18, 2021 at 6:12 PM Wang, Kevin(Yang) wrote: > > thanks, > > Reviewed-by: Kevin Wang > > Regards, > Kevin > > > 在 2021年2月19日,06:49,Nathan Chancellor 写道: > > > > Clang warns: > > > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu_cmn.c:764:2: warning: > >

2021 X.Org Board of Directors Elections Nomination period is NOW

2021-02-22 Thread Harry Wentland
We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2021 election are now open and will remain open until Sunday, the 7th of March. The Board consists of

Re: [PATCH] doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags from command line

2021-02-22 Thread Jonathan Corbet
Masahiro Yamada writes: > You should use KCFLAGS to pass additional compiler flags from the > command line. Using EXTRA_CFLAGS is wrong. > > EXTRA_CFLAGS is supposed to specify flags applied only to the current > Makefile (and now deprecated in favor of ccflags-y). > > It is still used in

Re: [git pull] drm for 5.12-rc1

2021-02-22 Thread Alex Deucher
On Sun, Feb 21, 2021 at 6:45 PM Nathan Chancellor wrote: > > On Sun, Feb 21, 2021 at 03:07:17PM -0800, Linus Torvalds wrote: > > On Thu, Feb 18, 2021 at 10:06 PM Dave Airlie wrote: > > > > > > Let me know if there are any issues, > > > > gcc was happy, and I obviously already pushed out my

[PATCH 2/2] drm/panel: Add inx Himax8279d MIPI-DSI LCD panel driver

2021-02-22 Thread Zhengqiao Xia
Add STARRY 2081101QFH032011-53G 10.1" WUXGA TFT LCD panel Signed-off-by: Zhengqiao Xia --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + .../gpu/drm/panel/panel-innolux-himax8279d.c | 520 ++ 3 files changed, 530

Re: [PATCH] drm/amdgpu: stream's id should reduced after stream destruct

2021-02-22 Thread Kazlauskas, Nicholas
On 2021-02-20 1:30 a.m., ZhiJie.Zhang wrote: Signed-off-by: ZhiJie.Zhang --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c index

Re: [PATCH] fbdev: atyfb: add stubs for aty_{ld,st}_lcd()

2021-02-22 Thread Ville Syrjälä
On Sun, Feb 21, 2021 at 07:28:53PM -0800, Randy Dunlap wrote: > Fix build errors when these functions are not defined. > > ../drivers/video/fbdev/aty/atyfb_base.c: In function 'aty_power_mgmt': > ../drivers/video/fbdev/aty/atyfb_base.c:2002:7: error: implicit declaration > of function

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-22 Thread khsieh
On 2021-02-22 08:55, Sean Paul wrote: On Mon, Feb 22, 2021 at 11:31 AM wrote: On 2021-02-19 14:46, Stephen Boyd wrote: > Quoting khs...@codeaurora.org (2021-02-19 08:39:38) >> On 2021-02-18 15:02, Stephen Boyd wrote: >> > Quoting Kuogee Hsieh (2021-02-18 12:55:04) >> >> Allow supported link

Re: [PATCH] drm/prime: Only call dma_map_sgtable() for devices with DMA support

2021-02-22 Thread Noralf Trønnes
Den 22.02.2021 08.54, skrev Thomas Zimmermann: > Hi > > Am 20.02.21 um 14:02 schrieb Noralf Trønnes: >> >> >> Den 19.02.2021 14.40, skrev Thomas Zimmermann: >>> Fixes a regression for udl and probably other USB-based drivers where >>> joining and mirroring displays fails. >>> >>> Joining

[PATCHv1 2/6] drm/imx: Add 8 pixel alignment fix

2021-02-22 Thread Sebastian Reichel
Some standard resolutions like 1366x768 do not work properly with i.MX6 SoCs, since the horizontal resolution needs to be aligned to 8 pixels (so 1360x768 or 1368x768 would work). This patch allocates framebuffers allocated to 8 pixels. The extra time required to send the extra pixels are removed

[PATCHv1 4/6] dt-bindings: arm: fsl: add GE B1x5pv2 boards

2021-02-22 Thread Sebastian Reichel
Document the compatible for GE B1x5pv2 boards. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/arm/fsl.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml

[PATCHv1 5/6] dt-bindings: mtd: jedec,spi-nor: add sst25vf032b

2021-02-22 Thread Sebastian Reichel
The binding is already used by the driver. Update documentation accordingly. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt

[PATCHv1 0/6] Support for GE B1x5v2

2021-02-22 Thread Sebastian Reichel
Hi, This series adds support for another General Electric patient monitor series (similar to existing Bx50v3), which is based on i.MX6DL using Congatec's QMX6 module. The module uses an I2C RTC to provide the i.MX6 32768 Hz clock, so it's important to keep it enabled. Not doing so results in

[PATCHv1 6/6] ARM: dts: imx6: Add GE B1x5v2

2021-02-22 Thread Sebastian Reichel
This adds device tree files for the General Electric Healthcare (GEHC) B1x5v2 series. All models make use of Congatec's QMX6 module, which is described in its own device tree include, so that it can also be used by other boards. Signed-off-by: Sebastian Reichel --- arch/arm/boot/dts/Makefile

[PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Sebastian Reichel
Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The modules SQW clock output defaults to 32768 Hz. This behaviour is used to provide the i.MX6 CKIL clock. Once the RTC driver is probed, the clock is disabled and all i.MX6 functionality depending on the 32 KHz clock has undefined

[PATCHv1 3/6] dt-bindings: vendor-prefixes: add congatec

2021-02-22 Thread Sebastian Reichel
Document binding for congatec. Signed-off-by: Sebastian Reichel --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index

Re: [PATCH 1/2] drm/dp_mst: Revise broadcast msg lct & lcr

2021-02-22 Thread Ville Syrjälä
On Mon, Feb 22, 2021 at 07:02:03PM +0200, Ville Syrjälä wrote: > On Mon, Feb 22, 2021 at 12:00:26PM +0800, Wayne Lin wrote: > > [Why & How] > > According to DP spec, broadcast message LCT equals to 1 and LCR equals > > to 6. Current implementation is incorrect. Fix it. > > > > Signed-off-by:

Re: [PATCH 1/2] drm/dp_mst: Revise broadcast msg lct & lcr

2021-02-22 Thread Ville Syrjälä
On Mon, Feb 22, 2021 at 12:00:26PM +0800, Wayne Lin wrote: > [Why & How] > According to DP spec, broadcast message LCT equals to 1 and LCR equals > to 6. Current implementation is incorrect. Fix it. > > Signed-off-by: Wayne Lin > Cc: sta...@vger.kernel.org > --- >

Re: [PATCH 2/2] drm/dp_mst: Set CLEAR_PAYLOAD_ID_TABLE as broadcast

2021-02-22 Thread Ville Syrjälä
On Mon, Feb 22, 2021 at 12:00:27PM +0800, Wayne Lin wrote: > [Why & How] > According to DP spec, CLEAR_PAYLOAD_ID_TABLE is a path broadcast request > message and current implementation is incorrect. Fix it. > > Signed-off-by: Wayne Lin > Cc: sta...@vger.kernel.org > --- >

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-22 Thread Sean Paul
On Mon, Feb 22, 2021 at 11:31 AM wrote: > > On 2021-02-19 14:46, Stephen Boyd wrote: > > Quoting khs...@codeaurora.org (2021-02-19 08:39:38) > >> On 2021-02-18 15:02, Stephen Boyd wrote: > >> > Quoting Kuogee Hsieh (2021-02-18 12:55:04) > >> >> Allow supported link rate to be limited to the value

Re: [PATCH 00/20] Manual replacement of all strlcpy in favor of strscpy

2021-02-22 Thread Shuah Khan
On 2/22/21 8:12 AM, Romain Perier wrote: strlcpy() copy a C-String into a sized buffer, the result is always a valid NULL-terminated that fits in the buffer, howerver it has severals issues. It reads the source buffer first, which is dangerous if it is non NULL-terminated or if the corresponding

Re: [RFC PATCH 3/3] drm/vkms: add overlay support

2021-02-22 Thread Daniel Vetter
On Sat, Feb 20, 2021 at 11:42:12AM -0300, Melissa Wen wrote: > Add support to overlay plane, in addition to primary and cursor > planes. In this approach, the plane composition still requires an > active primary plane and planes are composed associatively in the > order: (primary <- overlay) <-

Re: [RFC PATCH 1/3] drm/vkms: decouple cursor plane setup from crtc_init

2021-02-22 Thread Daniel Vetter
On Sat, Feb 20, 2021 at 11:38:50AM -0300, Melissa Wen wrote: > Initialize CRTC only with primary plane (without cursor) as a preparation > to init overlay plane before cursor plane and keep cursor on the top. > > Signed-off-by: Melissa Wen Why can't we first initialize all the planes (primary,

Re: [PATCH v2 0/3] drm/prime: Only call dma_map_sgtable() for devices with DMA support

2021-02-22 Thread Daniel Vetter
On Mon, Feb 22, 2021 at 05:25:46PM +0100, Thomas Zimmermann wrote: > Hi > > Am 22.02.21 um 17:10 schrieb Daniel Vetter: > > On Mon, Feb 22, 2021 at 2:24 PM Thomas Zimmermann > > wrote: > > > > > > Hi > > > > > > Am 22.02.21 um 14:09 schrieb Christian König: > > > > > > > > > > > > Am

Re: [PATCH v2 2/2] drm/msm/dp: add supported max link rate specified from dtsi

2021-02-22 Thread khsieh
On 2021-02-19 14:46, Stephen Boyd wrote: Quoting khs...@codeaurora.org (2021-02-19 08:39:38) On 2021-02-18 15:02, Stephen Boyd wrote: > Quoting Kuogee Hsieh (2021-02-18 12:55:04) >> Allow supported link rate to be limited to the value specified at >> dtsi. If it is not specified, then link rate

Re: [PATCH v2 1/3] drm: Support importing dmabufs into drivers without DMA

2021-02-22 Thread Daniel Vetter
On Mon, Feb 22, 2021 at 01:43:26PM +0100, Thomas Zimmermann wrote: > USB devices cannot perform DMA and hence have no dma_mask set in their > device structure. Importing dmabuf into a USB-based driver fails, which > break joining and mirroring of display in X11. A corresponding error > message is

Re: [PATCH v2 0/3] drm/prime: Only call dma_map_sgtable() for devices with DMA support

2021-02-22 Thread Thomas Zimmermann
Hi Am 22.02.21 um 17:10 schrieb Daniel Vetter: On Mon, Feb 22, 2021 at 2:24 PM Thomas Zimmermann wrote: Hi Am 22.02.21 um 14:09 schrieb Christian König: Am 22.02.21 um 13:43 schrieb Thomas Zimmermann: USB-based drivers cannot use DMA, so the importing of dma-buf attachments currently

Re: [PATCH] fbdev: atyfb: add stubs for aty_{ld,st}_lcd()

2021-02-22 Thread Daniel Vetter
On Sun, Feb 21, 2021 at 07:28:53PM -0800, Randy Dunlap wrote: > Fix build errors when these functions are not defined. > > ../drivers/video/fbdev/aty/atyfb_base.c: In function 'aty_power_mgmt': > ../drivers/video/fbdev/aty/atyfb_base.c:2002:7: error: implicit declaration > of function

Re: [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff

2021-02-22 Thread Daniel Vetter
On Mon, Feb 22, 2021 at 03:24:17PM +0100, Thomas Zimmermann wrote: > Hi > > Am 17.02.21 um 17:59 schrieb Neil Roberts: > > When mmapping the shmem, it would previously adjust the pgoff in the > > vm_area_struct to remove the fake offset that is added to be able to > > identify the buffer. This

Re: [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff

2021-02-22 Thread Daniel Vetter
On Mon, Feb 22, 2021 at 09:34:43AM +0100, Boris Brezillon wrote: > Hi Daniel, > > On Fri, 19 Feb 2021 18:45:00 +0100 > Daniel Vetter wrote: > > > On Fri, Feb 19, 2021 at 5:17 PM Steven Price wrote: > > > > > > On 19/02/2021 15:13, Daniel Vetter wrote: > > > > On Fri, Feb 19, 2021 at

[PATCH] drm: panel: simple: Set enable delay for BOE NV110WTM-N61

2021-02-22 Thread Douglas Anderson
Panel power sequence says timing T8 (time from link idle to turn on the backlight) should be at least 50 ms. This is what the .enable delay in simple-panel is for, so set it. NOTE: this overlaps with the 80 ms .prepare_to_enable delay on purpose. The data sheet says that at least 80 ms needs to

Re: [PATCH v2 0/3] drm/prime: Only call dma_map_sgtable() for devices with DMA support

2021-02-22 Thread Daniel Vetter
On Mon, Feb 22, 2021 at 2:24 PM Thomas Zimmermann wrote: > > Hi > > Am 22.02.21 um 14:09 schrieb Christian König: > > > > > > Am 22.02.21 um 13:43 schrieb Thomas Zimmermann: > >> USB-based drivers cannot use DMA, so the importing of dma-buf attachments > >> currently fails for udl and gm12u320.

Re: [v4] drm/msm/disp/dpu1: turn off vblank irqs aggressively in dpu driver

2021-02-22 Thread Rob Clark
On Thu, Feb 18, 2021 at 4:36 AM Kalyan Thota wrote: > > Set the flag vblank_disable_immediate = true to turn off vblank irqs > immediately as soon as drm_vblank_put is requested so that there are > no irqs triggered during idle state. This will reduce cpu wakeups > and help in power saving. > >

Re: [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-22 Thread Rob Clark
On Mon, Feb 22, 2021 at 7:45 AM Akhil P Oommen wrote: > > On 2/19/2021 9:30 PM, Rob Clark wrote: > > On Fri, Feb 19, 2021 at 2:44 AM Akhil P Oommen > > wrote: > >> > >> On 2/18/2021 9:41 PM, Rob Clark wrote: > >>> On Thu, Feb 18, 2021 at 4:28 AM Akhil P Oommen > >>> wrote: > > On

Re: [PATCH] drm/msm/a6xx: fix for kernels without CONFIG_NVMEM

2021-02-22 Thread Akhil P Oommen
On 2/19/2021 9:30 PM, Rob Clark wrote: On Fri, Feb 19, 2021 at 2:44 AM Akhil P Oommen wrote: On 2/18/2021 9:41 PM, Rob Clark wrote: On Thu, Feb 18, 2021 at 4:28 AM Akhil P Oommen wrote: On 2/18/2021 2:05 AM, Jonathan Marek wrote: On 2/17/21 3:18 PM, Rob Clark wrote: On Wed, Feb 17, 2021

[PATCH 04/20] dma-buf: Manual replacement of the deprecated strlcpy() with return values

2021-02-22 Thread Romain Perier
The strlcpy() reads the entire source buffer first, it is dangerous if the source buffer lenght is unbounded or possibility non NULL-terminated. It can lead to linear read overflows, crashes, etc... As recommended in the deprecated interfaces [1], it should be replaced by strscpy. This commit

[PATCH 00/20] Manual replacement of all strlcpy in favor of strscpy

2021-02-22 Thread Romain Perier
strlcpy() copy a C-String into a sized buffer, the result is always a valid NULL-terminated that fits in the buffer, howerver it has severals issues. It reads the source buffer first, which is dangerous if it is non NULL-terminated or if the corresponding buffer is unbounded. Its safe replacement

Re: [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff

2021-02-22 Thread Thomas Zimmermann
Hi Am 17.02.21 um 17:59 schrieb Neil Roberts: When mmapping the shmem, it would previously adjust the pgoff in the vm_area_struct to remove the fake offset that is added to be able to identify the buffer. This patch removes the adjustment and makes the fault handler use the vm_fault address to

Re: [PATCH] drivers: gnu: drm: i915: gvt: Fixed couple of spellings in the file gtt.c

2021-02-22 Thread Randy Dunlap
On 2/22/21 6:21 AM, Randy Dunlap wrote: > On 2/22/21 12:18 AM, Bhaskar Chowdhury wrote: >> >> s/negtive/negative/ >> s/possilbe/possible/ >> >> Signed-off-by: Bhaskar Chowdhury > > Acked-by: Randy Dunlap except the Subject has a typo in it. s/gnu/gpu/ >> --- >> drivers/gpu/drm/i915/gvt/gtt.c

Re: [PATCH] drivers: gnu: drm: i915: gvt: Fixed couple of spellings in the file gtt.c

2021-02-22 Thread Randy Dunlap
On 2/22/21 12:18 AM, Bhaskar Chowdhury wrote: > > s/negtive/negative/ > s/possilbe/possible/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/i915/gvt/gtt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[PATCH v3] drm/gem: Move drm_gem_fb_prepare_fb() to GEM atomic helpers

2021-02-22 Thread Thomas Zimmermann
The function drm_gem_fb_prepare_fb() is a helper for atomic modesetting, but currently located next to framebuffer helpers. Move it to GEM atomic helpers, rename it slightly and adopt the drivers. Same for the rsp simple-pipe helper. Compile-tested with x86-64, aarch64 and arm. The patch is

Re: [PATCH v2 1/3] drm: Support importing dmabufs into drivers without DMA

2021-02-22 Thread Ahmed S. Darwish
On Mon, Feb 22, 2021 at 01:43:26PM +0100, Thomas Zimmermann wrote: ... > > [ 60.050199] [ cut here ] > [ 60.055092] WARNING: CPU: 0 PID: 1403 at kernel/dma/mapping.c:190 > dma_map_sg_attrs+0x8f/0xc0 > [ 60.064331] Modules linked in: af_packet(E) rfkill(E)

Re: [PATCH v2] drm/scheduler: Fix hang when sched_entity released

2021-02-22 Thread Andrey Grodzovsky
Ping Andrey On 2021-02-20 7:12 a.m., Andrey Grodzovsky wrote: On 2/20/21 3:38 AM, Christian König wrote: Am 18.02.21 um 17:41 schrieb Andrey Grodzovsky: On 2/18/21 10:15 AM, Christian König wrote: Am 18.02.21 um 16:05 schrieb Andrey Grodzovsky: On 2/18/21 3:07 AM, Christian König

[PATCH v4 6/6] drm/sprd: add Unisoc's drm mipi dsi driver

2021-02-22 Thread Kevin Tang
Adds dsi host controller support for the Unisoc's display subsystem. Adds dsi phy support for the Unisoc's display subsystem. Only MIPI DSI Displays supported, DP/TV/HMDI will be support in the feature. v1: - Remove dphy and dsi graph binding, merge the dphy driver into the dsi. v2: - Use

[PATCH v4 4/6] drm/sprd: add Unisoc's drm display controller driver

2021-02-22 Thread Kevin Tang
Adds DPU(Display Processor Unit) support for the Unisoc's display subsystem. It's support multi planes, scaler, rotation, PQ(Picture Quality) and more. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang v2: - Use drm_xxx to replace all DRM_XXX. - Use kzalloc to replace

[PATCH v4 5/6] dt-bindings: display: add Unisoc's mipi dsi controller bindings

2021-02-22 Thread Kevin Tang
From: Kevin Tang Adds MIPI DSI Controller support for Unisoc's display subsystem. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring --- .../display/sprd/sprd,sharkl3-dsi-host.yaml | 102 ++ 1 file changed, 102 insertions(+) create mode

[PATCH v4 3/6] dt-bindings: display: add Unisoc's dpu bindings

2021-02-22 Thread Kevin Tang
From: Kevin Tang DPU (Display Processor Unit) is the Display Controller for the Unisoc SoCs which transfers the image data from a video memory buffer to an internal LCD interface. Cc: Orson Zhai Cc: Chunyan Zhang Signed-off-by: Kevin Tang Reviewed-by: Rob Herring ---

[PATCH v4 1/6] dt-bindings: display: add Unisoc's drm master bindings

2021-02-22 Thread Kevin Tang
From: Kevin Tang The Unisoc DRM master device is a virtual device needed to list all DPU devices or other display interface nodes that comprise the graphics subsystem Unisoc's display pipeline have several components as below description, multi display controllers and corresponding physical

[PATCH v4 2/6] drm/sprd: add Unisoc's drm kms master

2021-02-22 Thread Kevin Tang
Adds drm support for the Unisoc's display subsystem. This is drm kms driver, this driver provides support for the application framework in Android, Yocto and more. Application framework can access Unisoc's display internel peripherals through libdrm or libkms, it's test ok by modetest (DRM/KMS

[PATCH v4 0/6] Add Unisoc's drm kms module

2021-02-22 Thread Kevin Tang
ChangeList: RFC v1: 1. only upstream modeset and atomic at first commit. 2. remove some unused code; 3. use alpha and blend_mode properties; 3. add yaml support; 4. remove auto-adaptive panel driver; 5. bugfix RFC v2: 1. add sprd crtc and plane module for KMS, preparing for multi crtc 2. remove

Re: [PATCH v2 0/3] drm/prime: Only call dma_map_sgtable() for devices with DMA support

2021-02-22 Thread Thomas Zimmermann
Hi Am 22.02.21 um 14:09 schrieb Christian König: Am 22.02.21 um 13:43 schrieb Thomas Zimmermann: USB-based drivers cannot use DMA, so the importing of dma-buf attachments currently fails for udl and gm12u320. This breaks joining/mirroring of displays. The fix is now a little series. To

Re: [PATCH v2 0/3] drm/prime: Only call dma_map_sgtable() for devices with DMA support

2021-02-22 Thread Christian König
Am 22.02.21 um 13:43 schrieb Thomas Zimmermann: USB-based drivers cannot use DMA, so the importing of dma-buf attachments currently fails for udl and gm12u320. This breaks joining/mirroring of displays. The fix is now a little series. To solve the issue on the importer side (i.e., the

[PATCH v2 3/3] drm/cma-helper: Implement struct drm_driver.gem_prime_create_object

2021-02-22 Thread Thomas Zimmermann
Moves the scatter/gather-table setup from PRIME helpers into CMA helpers. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_cma_helper.c | 62 drivers/gpu/drm/pl111/pl111_drv.c| 8 ++-- include/drm/drm_gem_cma_helper.h | 12

[PATCH v2 2/3] drm/shmem-helper: Implement struct drm_driver.gem_prime_create_object

2021-02-22 Thread Thomas Zimmermann
Moves the scatter/gather-table setup from PRIME helpers into SHMEM helpers. USB-based drivers don't support DMA, so make the sg table optional. This cleans up rsp code in udl and gm12u320. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_shmem_helper.c | 38

[PATCH v2 1/3] drm: Support importing dmabufs into drivers without DMA

2021-02-22 Thread Thomas Zimmermann
USB devices cannot perform DMA and hence have no dma_mask set in their device structure. Importing dmabuf into a USB-based driver fails, which break joining and mirroring of display in X11. A corresponding error message is shown below. [ 60.050199] [ cut here ] [

[PATCH v2 0/3] drm/prime: Only call dma_map_sgtable() for devices with DMA support

2021-02-22 Thread Thomas Zimmermann
USB-based drivers cannot use DMA, so the importing of dma-buf attachments currently fails for udl and gm12u320. This breaks joining/mirroring of displays. The fix is now a little series. To solve the issue on the importer side (i.e., the affected USB-based driver), patch 1 introduces a new PRIME

KMSAN: kernel-infoleak in compat_drm_wait_vblank

2021-02-22 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:29ad81a1 arch/x86: add missing include to sparsemem.h git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=111e6312d0 kernel config:

Re: [PATCH] doc: use KCFLAGS instead of EXTRA_CFLAGS to pass flags from command line

2021-02-22 Thread Federico Vaga
On 2021-02-21 16:25, Masahiro Yamada wrote: You should use KCFLAGS to pass additional compiler flags from the command line. Using EXTRA_CFLAGS is wrong. EXTRA_CFLAGS is supposed to specify flags applied only to the current Makefile (and now deprecated in favor of ccflags-y). It is still used

Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features

2021-02-22 Thread Nicolas Boichat
On Mon, Feb 22, 2021 at 3:21 PM Andrzej Hajda wrote: > > Hi Nicolas, > > W dniu 22.02.2021 o 06:31, Nicolas Boichat pisze: > > On Mon, Feb 22, 2021 at 3:08 AM Laurent Pinchart > > wrote: > >> Hi Nicolas, > >> > >> Thank you for the patch. > >> > >> On Thu, Feb 11, 2021 at 11:33:55AM +0800,

Re: [PATCH v2 1/4] hmm: Device exclusive memory access

2021-02-22 Thread Alistair Popple
On Friday, 19 February 2021 8:47:41 PM AEDT Christoph Hellwig wrote: > > page = migration_entry_to_page(swpent); > > else if (is_device_private_entry(swpent)) > > page = device_private_entry_to_page(swpent); > > + else if

Re: [PULL] fixes around VM_PFNMAP and follow_pfn for 5.12 merge window

2021-02-22 Thread Daniel Vetter
Cc all the mailing lists ... my usual script crashed and I had to hand-roll the email and screwed it up ofc :-/ -Daniel On Mon, Feb 22, 2021 at 11:23 AM Daniel Vetter wrote: > > Hi Linus, > > Another small pull from you to ponder. > > This is the first part of a patch series I've been working on

[PATCH 2/2] drm/stm: dsi: Use dev_ based logging

2021-02-22 Thread Raphael GALLAIS-POU - foss
From: Yannick Fertre Standardize on the dev_ based logging. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 49 ++- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git

[PATCH] drm/compat: Clear bounce structures

2021-02-22 Thread Daniel Vetter
Some of them have gaps, or fields we don't clear. Native ioctl code does full copies plus zero-extends on size mismatch, so nothing can leak. But compat is more hand-rolled so need to be careful. None of these matter for performance, so just memset. Also I didn't fix up the CONFIG_DRM_LEGACY or

[PATCH] drm/compat: more dummy implementations

2021-02-22 Thread Daniel Vetter
drm_noop really doesnt do much, and who cares about the permission checks. So let's delete some code. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_ioc32.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_ioc32.c

Re: [PATCH] drm/ast: fix memory leak when unload the driver

2021-02-22 Thread Thomas Zimmermann
Am 22.02.21 um 03:33 schrieb Tong Zhang: a connector is leaked upon module unload, it seems that we should do similar to sample driver as suggested in drm_drv.c. Adding drm_atomic_helper_shutdown() in ast_pci_remove to prevent leaking. [ 153.822134] WARNING: CPU: 0 PID: 173 at

[PULL] topic/kcmp-kconfig

2021-02-22 Thread Daniel Vetter
Hi Linus, One patch pull request for you to ponder in the hopefully less stressful 2nd week of the merge window :-) It's also marked cc: stable so people can stop building kernels that don't work so well. topic/kcmp-kconfig-2021-02-22: kconfig for kcmp syscall drm userspaces uses this, systemd

[PATCH 1/2] drm/stm: dsi: Avoid printing errors for -EPROBE_DEFER

2021-02-22 Thread Raphael GALLAIS-POU - foss
From: Yannick Fertre Don't print error when probe deferred error is returned. Signed-off-by: Raphael Gallais-Pou Signed-off-by: Yannick Fertre --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git

[PATCH 0/2] Standardize DSI driver logging system

2021-02-22 Thread Raphael GALLAIS-POU - foss
The use of DRM logging macros was removed and dev_err_probe() replaces condition, showing errors but not EPROBE_DEFER. Yannick Fertre (2): drm/stm: dsi: Avoid printing errors for -EPROBE_DEFER drm/stm: dsi: Use dev_ based logging drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 58

Re: [PATCH v3 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-02-22 Thread Thomas Zimmermann
Am 19.02.21 um 13:00 schrieb Maxime Ripard: Many drivers reference the plane->state pointer in order to get the current plane state in their atomic_check hook, which would be the old plane state in the global atomic state since _swap_state hasn't happened when atomic_check is run. Use the

Re: [PATCH v3 05/11] drm: Use the state pointer directly in planes atomic_check

2021-02-22 Thread Thomas Zimmermann
Am 19.02.21 um 13:00 schrieb Maxime Ripard: Now that atomic_check takes the global atomic state as a parameter, we don't need to go through the pointer in the plane state. This was done using the following coccinelle script: @ plane_atomic_func @ identifier helpers; identifier func; @@

Re: [PATCH v3 02/11] drm: Rename plane atomic_check state names

2021-02-22 Thread Thomas Zimmermann
Am 19.02.21 um 16:12 schrieb Maxime Ripard: Hi Thomas, Thanks for your review! On Fri, Feb 19, 2021 at 03:49:22PM +0100, Thomas Zimmermann wrote: diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 075508051b5f..1873a155bb26 100644 ---

Re: [PATCH v3 04/11] drm/atomic: Pass the full state to planes atomic_check

2021-02-22 Thread Thomas Zimmermann
Am 19.02.21 um 13:00 schrieb Maxime Ripard: The current atomic helpers have either their object state being passed as an argument or the full atomic state. The former is the pattern that was done at first, before switching to the latter for new hooks or when it was needed. Let's convert all

RE: [RFC v3 2/3] virtio: Introduce Vdmabuf driver

2021-02-22 Thread Kasireddy, Vivek
Hi Gerd, > > On Fri, Feb 12, 2021 at 08:15:12AM +, Kasireddy, Vivek wrote: > > Hi Gerd, > > [Kasireddy, Vivek] Just to confirm my understanding of what you are > > suggesting, are you saying that we need to either have Weston allocate > > scanout buffers (GBM surface/BO) using virtio-gpu and

Re: [PATCH v4 24/80] drm/omap: dsi: move TE GPIO handling into core

2021-02-22 Thread Tomi Valkeinen
On 18/02/2021 07:57, Tony Lindgren wrote: > * Tomi Valkeinen [210217 07:42]: >> On 11/02/2021 19:35, Tony Lindgren wrote: >>> * Tomi Valkeinen [210211 07:35]: On 08/02/2021 19:55, Tony Lindgren wrote: > Hi, > > * Tomi Valkeinen [201124 12:47]: >> From: Sebastian Reichel

Re: [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff

2021-02-22 Thread Boris Brezillon
Hi Daniel, On Fri, 19 Feb 2021 18:45:00 +0100 Daniel Vetter wrote: > On Fri, Feb 19, 2021 at 5:17 PM Steven Price wrote: > > > > On 19/02/2021 15:13, Daniel Vetter wrote: > > > On Fri, Feb 19, 2021 at 01:36:06PM +, Steven Price wrote: > > >> On 18/02/2021 18:20, Daniel Vetter wrote:

  1   2   >