Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 12:27:19PM +0100, Daniel Vetter wrote: > On Wed, Jan 26, 2022 at 12:18 PM Helge Deller wrote: > > On 1/26/22 11:31, Daniel Vetter wrote: ... > > You are describing a transitioning over to DRM - which is Ok. > > But on that way there is no need to ignore, deny or even kill

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 12:31:40PM +0100, Thomas Zimmermann wrote: > Am 26.01.22 um 12:17 schrieb Helge Deller: ... > And none of those examples is out-ruled by DRM. In fact we do support > devices that fall in those categories. > > This is last week's discussion all over again. Fine, write a d

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 12:17:08PM +0100, Helge Deller wrote: > On 1/26/22 11:31, Daniel Vetter wrote: > > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > > wrote: ... > > On the other hand ... why does it have to be resurrecting fbdev? > > There's an entire community of people who really k

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 11:31:45AM +0100, Daniel Vetter wrote: > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > wrote: > > On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: ... > > I'm ok with the files moving if the dri developers agree with it. It's > > up to them, not me

Re: [PATCH v1 4/4] fbtft: Replace 'depends on FB_TFT' by 'if FB_TFT ... endif'

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 12:54:13AM -0800, Joe Perches wrote: > On Tue, 2022-01-25 at 22:21 +0200, Andy Shevchenko wrote: > > Replace 'depends on FB_TFT' by 'if FB_TFT ... endif' > > for the sake of deduplication. > [] > > diff --git a/drivers/video/fbtft/Kconfig b/drivers/video/fbtft/Kconfig > [] >

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Greg Kroah-Hartman
On Wed, Jan 26, 2022 at 01:37:00PM +0100, Javier Martinez Canillas wrote: > On 1/26/22 11:28, Dan Carpenter wrote: > > On Wed, Jan 26, 2022 at 12:04:26PM +0200, Andy Shevchenko wrote: > >> On Wed, Jan 26, 2022 at 12:02 PM Andy Shevchenko > >> wrote: > >>> On Wed, Jan 26, 2022 at 10:52 AM Thomas Zi

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level, v2.

2022-01-26 Thread Gwan-gyeong Mun
On 1/26/22 9:37 AM, Maarten Lankhorst wrote: set_cache_level may unbind the object, which will result in the below lockdep splat: <6> [184.578145] [IGT] kms_addfb_basic: starting subtest addfb25-framebuffer-vs-set-tiling <4> [184.578220] [ cut here ] <4> [184.578221] W

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Javier Martinez Canillas
On 1/26/22 11:28, Dan Carpenter wrote: > On Wed, Jan 26, 2022 at 12:04:26PM +0200, Andy Shevchenko wrote: >> On Wed, Jan 26, 2022 at 12:02 PM Andy Shevchenko >> wrote: >>> On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann >>> wrote: Am 25.01.22 um 21:21 schrieb Andy Shevchenko: >> >> ... >

Re: [Intel-gfx] [PATCH v2 09/11] drm: Convert open-coded yes/no strings to yesno()

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 02:43:45AM -0800, Lucas De Marchi wrote: > On Wed, Jan 26, 2022 at 12:12:50PM +0200, Andy Shevchenko wrote: > > On Wed, Jan 26, 2022 at 11:39 AM Lucas De Marchi > > wrote: ... > > > 411986 104906176 428652 68a6c drm.ko.old > > > 411986 104906176 428652

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Greg Kroah-Hartman
On Wed, Jan 26, 2022 at 12:51:46PM +0100, Helge Deller wrote: > On 1/26/22 12:38, Greg Kroah-Hartman wrote: > > On Wed, Jan 26, 2022 at 12:31:21PM +0100, Helge Deller wrote: > >> On 1/26/22 12:18, Javier Martinez Canillas wrote: > >>> On 1/26/22 11:59, Helge Deller wrote: > On 1/26/22 11:02, A

Re: [RFC v3 08/12] drm/amdgpu: Rework reset domain to be refcounted.

2022-01-26 Thread Christian König
Am 25.01.22 um 23:37 schrieb Andrey Grodzovsky: The reset domain contains register access semaphor now and so needs to be present as long as each device in a hive needs it and so it cannot be binded to XGMI hive life cycle. Adress this by making reset domain refcounted and pointed by each memb

Re: [RFC v3 01/12] drm/amdgpu: Introduce reset domain

2022-01-26 Thread Christian König
Am 25.01.22 um 23:37 schrieb Andrey Grodzovsky: Defined a reset_domain struct such that all the entities that go through reset together will be serialized one against another. Do it for both single device and XGMI hive cases. Signed-off-by: Andrey Grodzovsky Suggested-by: Daniel Vetter Suggest

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Helge Deller
On 1/26/22 12:38, Greg Kroah-Hartman wrote: > On Wed, Jan 26, 2022 at 12:31:21PM +0100, Helge Deller wrote: >> On 1/26/22 12:18, Javier Martinez Canillas wrote: >>> On 1/26/22 11:59, Helge Deller wrote: On 1/26/22 11:02, Andy Shevchenko wrote: >>> >>> [snip] >>> > P.S. For the record, I wi

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Thomas Zimmermann
Hi Am 26.01.22 um 12:31 schrieb Helge Deller: On 1/26/22 12:18, Javier Martinez Canillas wrote: On 1/26/22 11:59, Helge Deller wrote: On 1/26/22 11:02, Andy Shevchenko wrote: [snip] P.S. For the record, I will personally NAK any attempts to remove that driver from the kernel. And this is a

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Thomas Zimmermann
Hi Am 26.01.22 um 11:59 schrieb Helge Deller: On 1/26/22 11:02, Andy Shevchenko wrote: On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann wrote: Am 25.01.22 um 21:21 schrieb Andy Shevchenko: Since we got a maintainer for fbdev, I would like to unorphan fbtft (with the idea of sending PRs to

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Helge Deller
On 1/26/22 12:24, Daniel Vetter wrote: > On Wed, Jan 26, 2022 at 12:18 PM Javier Martinez Canillas > wrote: >> >> On 1/26/22 11:59, Helge Deller wrote: >>> On 1/26/22 11:02, Andy Shevchenko wrote: >> >> [snip] >> P.S. For the record, I will personally NAK any attempts to remove that driv

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Greg Kroah-Hartman
On Wed, Jan 26, 2022 at 12:31:21PM +0100, Helge Deller wrote: > On 1/26/22 12:18, Javier Martinez Canillas wrote: > > On 1/26/22 11:59, Helge Deller wrote: > >> On 1/26/22 11:02, Andy Shevchenko wrote: > > > > [snip] > > > >>> P.S. For the record, I will personally NAK any attempts to remove that >

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Helge Deller
On 1/26/22 12:18, Javier Martinez Canillas wrote: > On 1/26/22 11:59, Helge Deller wrote: >> On 1/26/22 11:02, Andy Shevchenko wrote: > > [snip] > >>> P.S. For the record, I will personally NAK any attempts to remove that >>> driver from the kernel. And this is another point why it's better not >>>

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Thomas Zimmermann
Hi Am 26.01.22 um 12:17 schrieb Helge Deller: On 1/26/22 11:31, Daniel Vetter wrote: On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman wrote: On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: Let's maintain occasional fixes to the fbtft driver. Signed-off-by: Andy Shevchenk

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Daniel Vetter
On Wed, Jan 26, 2022 at 12:18 PM Helge Deller wrote: > > On 1/26/22 11:31, Daniel Vetter wrote: > > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > > wrote: > >> > >> On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: > >>> Let's maintain occasional fixes to the fbtft driver. >

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Greg Kroah-Hartman
On Wed, Jan 26, 2022 at 12:17:08PM +0100, Helge Deller wrote: > On 1/26/22 11:31, Daniel Vetter wrote: > > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > > wrote: > >> > >> On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: > >>> Let's maintain occasional fixes to the fbtft dri

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Daniel Vetter
On Wed, Jan 26, 2022 at 12:18 PM Javier Martinez Canillas wrote: > > On 1/26/22 11:59, Helge Deller wrote: > > On 1/26/22 11:02, Andy Shevchenko wrote: > > [snip] > > >> P.S. For the record, I will personally NAK any attempts to remove that > >> driver from the kernel. And this is another point wh

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Helge Deller
On 1/26/22 11:31, Daniel Vetter wrote: > On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman > wrote: >> >> On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: >>> Let's maintain occasional fixes to the fbtft driver. >>> >>> Signed-off-by: Andy Shevchenko >>> --- >>> MAINTAINERS | 4

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Javier Martinez Canillas
On 1/26/22 11:59, Helge Deller wrote: > On 1/26/22 11:02, Andy Shevchenko wrote: [snip] >> P.S. For the record, I will personally NAK any attempts to remove that >> driver from the kernel. And this is another point why it's better not >> to be under the staging. > > I agree. Same as for me to NA

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Greg Kroah-Hartman
On Wed, Jan 26, 2022 at 11:52:16AM +0100, Daniel Vetter wrote: > On Wed, Jan 26, 2022 at 11:47 AM Greg Kroah-Hartman > wrote: > > > > On Wed, Jan 26, 2022 at 12:02:36PM +0200, Andy Shevchenko wrote: > > > On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann > > > wrote: > > > > > > > > Hi > > > >

Re: [PATCH] [RFC] fbcon: Add option to enable legacy hardware acceleration

2022-01-26 Thread Daniel Vetter
On Tue, Jan 25, 2022 at 8:44 PM Helge Deller wrote: > > On 1/25/22 20:17, Helge Deller wrote: > > On 1/25/22 20:12, Helge Deller wrote: > >> Add a config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION to > >> enable bitblt and fillrect hardware acceleration in the framebuffer > >> console.

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Helge Deller
On 1/26/22 11:02, Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann > wrote: >> Am 25.01.22 um 21:21 schrieb Andy Shevchenko: >>> Since we got a maintainer for fbdev, I would like to >>> unorphan fbtft (with the idea of sending PRs to Helge) >>> and move it out of stagin

Re: [PATCH] drm/msm/dp: add connector type to enhance debug messages

2022-01-26 Thread Dmitry Baryshkov
On Tue, 25 Jan 2022 at 21:26, Kuogee Hsieh wrote: > > > On 1/24/2022 5:50 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-24 14:44:52) > >> DP driver is a generic driver which supports both eDP and DP. > >> For debugging purpose it is required to have capabilities to > >> differentiate m

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Daniel Vetter
On Wed, Jan 26, 2022 at 11:47 AM Greg Kroah-Hartman wrote: > > On Wed, Jan 26, 2022 at 12:02:36PM +0200, Andy Shevchenko wrote: > > On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann > > wrote: > > > > > > Hi > > > > > > Am 25.01.22 um 21:21 schrieb Andy Shevchenko: > > > > Since we got a mainta

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Greg Kroah-Hartman
On Wed, Jan 26, 2022 at 12:02:36PM +0200, Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann > wrote: > > > > Hi > > > > Am 25.01.22 um 21:21 schrieb Andy Shevchenko: > > > Since we got a maintainer for fbdev, I would like to > > > unorphan fbtft (with the idea of sending

[PATCH v5 00/10] Add GuC Error Capture Support

2022-01-26 Thread Alan Previn
This series: 1. Enables support of GuC to execute error- state-capture based on a list of MMIO registers the driver registers and GuC will dump and report back right before a GuC triggered engine-reset event. 2. Updates the ADS blob creation to register lists of global

Re: [Intel-gfx] [PATCH v2 09/11] drm: Convert open-coded yes/no strings to yesno()

2022-01-26 Thread Lucas De Marchi
On Wed, Jan 26, 2022 at 12:12:50PM +0200, Andy Shevchenko wrote: On Wed, Jan 26, 2022 at 11:39 AM Lucas De Marchi wrote: linux/string_helpers.h provides a helper to return "yes"/"no" strings. Replace the open coded versions with str_yes_no(). The places were oops, I replaced yesno() here but

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Daniel Vetter
On Wed, Jan 26, 2022 at 11:03 AM Andy Shevchenko wrote: > > On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann > wrote: > > > > Hi > > > > Am 25.01.22 um 21:21 schrieb Andy Shevchenko: > > > Since we got a maintainer for fbdev, I would like to > > > unorphan fbtft (with the idea of sending PRs t

Re: [Intel-gfx] [PATCH 3/4] drm/i915/execlists: Fix execlists request cancellation corner case

2022-01-26 Thread Tvrtko Ursulin
On 25/01/2022 16:32, Matthew Brost wrote: On Tue, Jan 25, 2022 at 03:27:31PM +, Tvrtko Ursulin wrote: On 24/01/2022 15:01, Matthew Brost wrote: More than 1 request can be submitted to a single ELSP at a time if multiple requests are ready run to on the same context. When a request is can

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Daniel Vetter
On Wed, Jan 26, 2022 at 9:31 AM Greg Kroah-Hartman wrote: > > On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: > > Let's maintain occasional fixes to the fbtft driver. > > > > Signed-off-by: Andy Shevchenko > > --- > > MAINTAINERS | 4 +++- > > 1 file changed, 3 insertions(+), 1

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Dan Carpenter
On Wed, Jan 26, 2022 at 12:04:26PM +0200, Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 12:02 PM Andy Shevchenko > wrote: > > On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann > > wrote: > > > Am 25.01.22 um 21:21 schrieb Andy Shevchenko: > > ... > > > > But why? We already have DRM driver

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add request cancel low level trace point

2022-01-26 Thread Tvrtko Ursulin
On 25/01/2022 16:39, Matthew Brost wrote: On Tue, Jan 25, 2022 at 12:27:43PM +, Tvrtko Ursulin wrote: On 24/01/2022 15:01, Matthew Brost wrote: Add request cancel trace point guarded by CONFIG_DRM_I915_LOW_LEVEL_TRACEPOINT. Okay-ish I guess (There is pr_notice with the only real caller

Re: [PATCH v2 00/11] lib/string_helpers: Add a few string helpers

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 11:39 AM Lucas De Marchi wrote: > > Add some helpers under lib/string_helpers.h so they can be used > throughout the kernel. When I started doing this there were 2 other > previous attempts I know of, not counting the iterations each of them > had: > > 1) https://lore.kerne

Re: [PATCH v2 09/11] drm: Convert open-coded yes/no strings to yesno()

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 11:39 AM Lucas De Marchi wrote: > > linux/string_helpers.h provides a helper to return "yes"/"no" strings. > Replace the open coded versions with str_yes_no(). The places were > identified with the following semantic patch: > > @@ > expression b; > @

Re: [PATCH][next] drm/i915/guc: Use struct_size() helper in kmalloc()

2022-01-26 Thread Tvrtko Ursulin
On 25/01/2022 18:07, Gustavo A. R. Silva wrote: Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows. Also, address the following sparse warnings: driv

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 12:02 PM Andy Shevchenko wrote: > On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann > wrote: > > Am 25.01.22 um 21:21 schrieb Andy Shevchenko: ... > > But why? We already have DRM drivers for some of these devices. > > No, we do not (only a few are available). Sorry,

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Andy Shevchenko
On Wed, Jan 26, 2022 at 10:52 AM Thomas Zimmermann wrote: > > Hi > > Am 25.01.22 um 21:21 schrieb Andy Shevchenko: > > Since we got a maintainer for fbdev, I would like to > > unorphan fbtft (with the idea of sending PRs to Helge) > > and move it out of staging since there is no more clean > > up

[PATCH] drm/amdgpu: Wrong order for config and counter_id parameters

2022-01-26 Thread jinsdb
From: huangqu Wrong order for config and counter_id parameters was passed, when calling df_v3_6_pmc_set_deferred and df_v3_6_pmc_is_deferred functions. Signed-off-by: huangqu --- drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dri

Re: [PATCH 17/54] gpu: drm: replace cpumask_weight with cpumask_empty where appropriate

2022-01-26 Thread Tvrtko Ursulin
On 25/01/2022 18:16, Yury Norov wrote: On Tue, Jan 25, 2022 at 1:28 AM Tvrtko Ursulin wrote: On 23/01/2022 18:38, Yury Norov wrote: i915_pmu_cpu_online() calls cpumask_weight() to check if any bit of a given cpumask is set. We can do it more efficiently with cpumask_empty() because cpumask

[PATCH v2 10/11] tomoyo: Use str_yes_no()

2022-01-26 Thread Lucas De Marchi
Remove the local yesno() implementation and adopt the str_yes_no() from linux/string_helpers.h. Signed-off-by: Lucas De Marchi Reviewed-by: Sakari Ailus --- security/tomoyo/audit.c | 2 +- security/tomoyo/common.c | 19 +-- security/tomoyo/common.h | 1 - 3 files changed, 6 i

[PATCH v2 11/11] cxgb4: Use str_yes_no()

2022-01-26 Thread Lucas De Marchi
Remove the local yesno() implementation and adopt the str_yes_no() from linux/string_helpers.h. Signed-off-by: Lucas De Marchi --- .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c| 249 ++ 1 file changed, 137 insertions(+), 112 deletions(-) diff --git a/drivers/net/ethernet/chelsi

[PATCH v2 03/11] drm/i915: Use str_yes_no()

2022-01-26 Thread Lucas De Marchi
Remove the local yesno() implementation and adopt the str_yes_no() from linux/string_helpers.h. Signed-off-by: Lucas De Marchi Acked-by: Daniel Vetter Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_display.c | 23 +++ .../drm/i915/display/intel_display_debugfs.c | 66 ++

[PATCH v2 05/11] drm/i915: Use str_enabled_disabled()

2022-01-26 Thread Lucas De Marchi
Remove the local enableddisabled() implementation and adopt the str_enabled_disabled() from linux/string_helpers.h. Signed-off-by: Lucas De Marchi Acked-by: Daniel Vetter Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_backlight.c | 3 ++- drivers/gpu/drm/i915/display/intel_dis

[PATCH v2 07/11] drm/amd/display: Use str_yes_no()

2022-01-26 Thread Lucas De Marchi
Remove the local yesno() implementation and adopt the str_yes_no() from linux/string_helpers.h. Signed-off-by: Lucas De Marchi --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amd

[PATCH v2 06/11] drm/i915: Use str_on_off()

2022-01-26 Thread Lucas De Marchi
Remove the local onoff() implementation and adopt the str_on_off() from linux/string_helpers.h. Signed-off-by: Lucas De Marchi Acked-by: Daniel Vetter Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/g4x_dp.c | 6 -- drivers/gpu/drm/i915/display/intel_display.c | 7

[PATCH v2 08/11] drm/gem: Sort includes alphabetically

2022-01-26 Thread Lucas De Marchi
Sort includes alphabetically so it's easier to add/remove includes and know when that is needed. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/drm_gem.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm

[PATCH v2 09/11] drm: Convert open-coded yes/no strings to yesno()

2022-01-26 Thread Lucas De Marchi
linux/string_helpers.h provides a helper to return "yes"/"no" strings. Replace the open coded versions with str_yes_no(). The places were identified with the following semantic patch: @@ expression b; @@ - b ? "yes" : "no" + str_yes_no(b) Then the includes

[PATCH v2 04/11] drm/i915: Use str_enable_disable()

2022-01-26 Thread Lucas De Marchi
Remove the local enabledisable() implementation and adopt the str_enable_disable() from linux/string_helpers.h. Signed-off-by: Lucas De Marchi Acked-by: Daniel Vetter Acked-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_ddi.c | 4 +++- drivers/gpu/drm/i915/display/intel_displ

[PATCH v2 00/11] lib/string_helpers: Add a few string helpers

2022-01-26 Thread Lucas De Marchi
Add some helpers under lib/string_helpers.h so they can be used throughout the kernel. When I started doing this there were 2 other previous attempts I know of, not counting the iterations each of them had: 1) https://lore.kernel.org/all/20191023131308.9420-1-jani.nik...@intel.com/ 2) https://lor

[PATCH v2 02/11] drm/i915: Fix trailing semicolon

2022-01-26 Thread Lucas De Marchi
Remove the trailing semicolon, as correctly warned by checkpatch: -:1189: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #1189: FILE: drivers/gpu/drm/i915/intel_device_info.c:119: +#define PRINT_FLAG(name) drm_printf(p, "%s: %s\n", #name, yesno(inf

[PATCH v2 01/11] lib/string_helpers: Consolidate string helpers implementation

2022-01-26 Thread Lucas De Marchi
There are a few implementations of string helpers in the tree like yesno() that just returns "yes" or "no" depending on a boolean argument. Those are helpful to output strings to the user or log. In order to consolidate them, prefix all of them str_ prefix to make it clear what they are about and

Re: [PATCH] Revert "drm/ast: Support 1600x900 with 108MHz PCLK"

2022-01-26 Thread Thomas Zimmermann
Hi Am 20.01.22 um 05:05 schrieb Dave Airlie: From: Dave Airlie This reverts commit 9bb7b689274b67ecb3641e399e76f84adc627df1. This caused a regression reported to Red Hat. Fixes: 9bb7b689274b ("drm/ast: Support 1600x900 with 108MHz PCLK") Signed-off-by: Dave Airlie Thanks a lot. Merged int

Re: [PATCH] [RFC] fbcon: Add option to enable legacy hardware acceleration

2022-01-26 Thread Geert Uytterhoeven
Hi Helge, Thanks for your patch! On Wed, Jan 26, 2022 at 8:20 AM Helge Deller wrote: > Add a config option CONFIG_FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION to > enable bitblt and fillrect hardware acceleration in the framebuffer > console. If disabled, such acceleration will not be used, even if i

Re: [PATCH 3/3] drm: Convert open yes/no strings to yesno()

2022-01-26 Thread Lucas De Marchi
On Wed, Jan 19, 2022 at 09:30:47PM +0200, Andy Shevchenko wrote: On Tue, Jan 18, 2022 at 11:24:50PM -0800, Lucas De Marchi wrote: linux/string_helpers.h provides a helper to return "yes"/"no" strings. Replace the open coded versions with yesno(). The places were identified with the following sem

Re: [PATCH v1 4/4] fbtft: Replace 'depends on FB_TFT' by 'if FB_TFT ... endif'

2022-01-26 Thread Joe Perches
On Tue, 2022-01-25 at 22:21 +0200, Andy Shevchenko wrote: > Replace 'depends on FB_TFT' by 'if FB_TFT ... endif' > for the sake of deduplication. [] > diff --git a/drivers/video/fbtft/Kconfig b/drivers/video/fbtft/Kconfig [] > @@ -10,87 +10,75 @@ menuconfig FB_TFT > select FB_DEFERRED_IO >

Re: [PATCH v1 0/4] fbtft: Unorphan the driver for maintenance

2022-01-26 Thread Thomas Zimmermann
Hi Am 25.01.22 um 21:21 schrieb Andy Shevchenko: Since we got a maintainer for fbdev, I would like to unorphan fbtft (with the idea of sending PRs to Helge) and move it out of staging since there is no more clean up work expected and no more drivers either. Thoughts? But why? We already have

[PATCH][next] drm/i915/guc: fix spelling mistake "notificaion" -> "notification"

2022-01-26 Thread Colin Ian King
There is a spelling mistake in a drm_err error message. Fix it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/

Re: [PATCH 5/5] spi: make remove callback a void function

2022-01-26 Thread Miquel Raynal
Hi Uwe, u.kleine-koe...@pengutronix.de wrote on Sun, 23 Jan 2022 18:52:01 +0100: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove functio

Re: [PATCH 5/5] spi: make remove callback a void function

2022-01-26 Thread Uwe Kleine-König
[Dropped a few people from Cc that are not reachable (Harry Morris, Charles-Antoine Couret, Marco Felsch)] On Tue, Jan 25, 2022 at 09:47:59AM +, Jonathan Cameron wrote: > On Sun, 23 Jan 2022 18:52:01 +0100 > Uwe Kleine-König wrote: > > > The value returned by an spi driver's remove function

Re: [PATCH 5/5] spi: make remove callback a void function

2022-01-26 Thread Stefan Schmidt
Hello. On 23.01.22 18:52, Uwe Kleine-König wrote: The value returned by an spi driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver

Re: [PATCH 5/5] spi: make remove callback a void function

2022-01-26 Thread Alexandre Belloni
On 23/01/2022 18:52:01+0100, Uwe Kleine-König wrote: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This > w

Re: [PATCH 5/5] spi: make remove callback a void function

2022-01-26 Thread Geert Uytterhoeven
On Sun, Jan 23, 2022 at 6:54 PM Uwe Kleine-König wrote: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no value. This

Re: [PATCH 0/5] spi: make remove callback a void function

2022-01-26 Thread Lee Jones
My usual mailer won't let me reply to this many people, so I'm using Gmail. No idea what chaos this will cause, but here goes ... > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >

Re: [PATCH 5/5] spi: make remove callback a void function

2022-01-26 Thread Jérôme Pouiller
On Sunday 23 January 2022 18:52:01 CET Uwe Kleine-König wrote: > > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) > > So change the prototype of the remove function to return no va

Re: [PATCH v1 1/4] fbtft: Unorphan the driver

2022-01-26 Thread Greg Kroah-Hartman
On Tue, Jan 25, 2022 at 10:21:14PM +0200, Andy Shevchenko wrote: > Let's maintain occasional fixes to the fbtft driver. > > Signed-off-by: Andy Shevchenko > --- > MAINTAINERS | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ea3e6c9143

Re: [PATCH] drm/panel-edp: Allow querying the detected panel via sysfs

2022-01-26 Thread Javier Martinez Canillas
On 1/26/22 00:25, Doug Anderson wrote: > On Tue, Jan 25, 2022 at 2:55 PM Javier Martinez Canillas > wrote: [snip] >> Should this new sysfs entry be documented in Documentation/ABI/ ? > > I'm not sure what the policy is here. I actually don't know that I'm > too worried about this being an ABI.

<    1   2   3