Re: [Intel-gfx] [PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-07 Thread Ville Syrjälä
On Tue, Feb 08, 2022 at 03:37:12PM +0800, Hsin-Yi Wang wrote: > +int drm_connector_init_panel_orientation_property( > + struct drm_connector *connector) > +{ > + struct drm_device *dev = connector->dev; > + struct drm_property *prop; > + > + prop = drm_property_create_enum(dev,

Re: [PATCH 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-02-07 Thread Greg Kroah-Hartman
On Mon, Feb 07, 2022 at 08:43:28PM -0800, Bjorn Andersson wrote: > The Qualcomm DisplayPort driver contains traces of the necessary > plumbing to hook up USB HPD, in the form of the dp_hpd module and the > dp_usbpd_cb struct. Use this as basis for implementing the > oob_hotplug_event() callback,

[PATCH v7 3/3] arm64: dts: mt8183: Add panel rotation

2022-02-07 Thread Hsin-Yi Wang
krane, kakadu, and kodama boards have a default panel rotation. Signed-off-by: Hsin-Yi Wang Reviewed-by: Enric Balletbo i Serra Tested-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v7 2/3] drm/mediatek: init panel orientation property

2022-02-07 Thread Hsin-Yi Wang
Init panel orientation property after connector is initialized. Let the panel driver decides the orientation value later. Signed-off-by: Hsin-Yi Wang Acked-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_dsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[PATCH v7 1/3] gpu: drm: separate panel orientation property creating and value setting

2022-02-07 Thread Hsin-Yi Wang
drm_dev_register() sets connector->registration_state to DRM_CONNECTOR_REGISTERED and dev->registered to true. If drm_connector_set_panel_orientation() is first called after drm_dev_register(), it will fail several checks and results in following warning. Add a function to create panel

Re: [PATCH v2 2/2] drm/radeon/uvd: Fix forgotten unmap buffer objects

2022-02-07 Thread Christian König
Am 08.02.22 um 04:14 schrieb zhanglianjie: after the buffer object is successfully mapped, call radeon_bo_kunmap before the function returns. Signed-off-by: zhanglianjie Reviewed-by: Christian König diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c

Re: [RFC PATCH 1/3] drm: Extract amdgpu_sa.c as a generic suballocation helper

2022-02-07 Thread Christian König
Am 07.02.22 um 12:18 schrieb Maarten Lankhorst: Op 04-02-2022 om 19:29 schreef Christian König: [SNIP] I think we should put that into a separate module like we now do with other helpers as well. Can easily be done, it will likely be a very small helper. The code itself is just under a

Re: [RFC v3 06/12] drm/amdgpu: Drop hive->in_reset

2022-02-07 Thread Lazar, Lijo
On 1/26/2022 4:07 AM, Andrey Grodzovsky wrote: Since we serialize all resets no need to protect from concurrent resets. Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 19 +--

[PATCH 2/2] drm/msm/dp: Implement oob_hotplug_event()

2022-02-07 Thread Bjorn Andersson
The Qualcomm DisplayPort driver contains traces of the necessary plumbing to hook up USB HPD, in the form of the dp_hpd module and the dp_usbpd_cb struct. Use this as basis for implementing the oob_hotplug_event() callback, by amending the dp_hpd module with the missing logic. Overall the

[PATCH 1/2] drm: Add HPD state to drm_connector_oob_hotplug_event()

2022-02-07 Thread Bjorn Andersson
In some implementations, such as the Qualcomm platforms, the display driver has no way to query the current HPD state and as such it's impossible to distinguish between disconnect and attention events. Add a parameter to drm_connector_oob_hotplug_event() to pass the HPD state. Also push the test

Re: [Intel-gfx] [PATCH v6 6/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-07 Thread kernel test robot
Hi Michael, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm/drm-next v5.17-rc3 next-20220207] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [Intel-gfx] [PATCH v6 6/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-07 Thread kernel test robot
Hi Michael, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm/drm-next v5.17-rc3 next-20220207] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-02-07 Thread Laurent Pinchart
Hello Liu Ying, On Tue, Feb 08, 2022 at 10:41:59AM +0800, Liu Ying wrote: > On Mon, 2022-02-07 at 11:43 +0100, Marek Vasut wrote: > > On 2/7/22 10:18, Liu Ying wrote: > > > > > On Sun, 2022-02-06 at 19:56 +0100, Marek Vasut wrote: > > > > > > The LCDIF controller as present in i.MX6SX/i.MX8M

Re: [PATCH] [RFC] drm: mxsfb: Implement LCDIF scanout CRC32 support

2022-02-07 Thread Liu Ying
On Mon, 2022-02-07 at 11:43 +0100, Marek Vasut wrote: > On 2/7/22 10:18, Liu Ying wrote: > > Hi, > > > > > On Sun, 2022-02-06 at 19:56 +0100, Marek Vasut wrote: > > > > > The LCDIF controller as present in i.MX6SX/i.MX8M Mini/Nano > > > > > has a > > > > > CRC_STAT > > > > > register, which

Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount

2022-02-07 Thread Ralph Campbell
On 2/6/22 22:32, Christoph Hellwig wrote: ZONE_DEVICE struct pages have an extra reference count that complicates the code for put_page() and several places in the kernel that need to check the reference count to see that a page is not being used (gup, compaction, migration, etc.). Clean up the

[PATCH 7/8] drm/i915/guc: Drop obsolete H2G definitions

2022-02-07 Thread John . C . Harrison
From: John Harrison The CTB registration process changed significantly a while back using a single KLV based H2G. So drop the original and now obsolete H2G definitions. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 2 -- 1 file changed, 2 deletions(-)

[PATCH 8/8] drm/i915/guc: Fix potential invalid pointer dereferences when decoding G2Hs

2022-02-07 Thread John . C . Harrison
From: John Harrison Some G2H handlers were reading the context id field from the payload before checking the payload met the minimum length required. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH 2/8] drm/i915/guc: Add an explicit 'submission_initialized' flag

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for whether submission has been initialised or not. Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/uc/intel_guc.h| 2 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c | 8 +---

[PATCH 3/8] drm/i915/guc: Better name for context id limit

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as the limit for how many context ids are available. While at it, also update a kzalloc(sizeof()*count) to be a kcalloc(count,size). Signed-off-by: John Harrison --- drivers/gpu/drm/i915/gt/intel_context.c

[PATCH 5/8] drm/i915/guc: Move lrc desc setup to where it is needed

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor was being initialised early on in the context registration sequence. It could then be determined that the actual registration needs to be delayed and the descriptor would be wiped out. This is inefficient, so move the setup to later in the process after the

[PATCH 6/8] drm/i915/guc: Rename desc_idx to ctx_id

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop naming context ids as descriptor pool indecies. While at it, add a bunch of missing line feeds to some error messages. Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 56 +--

[PATCH 4/8] drm/i915/guc: Split guc_lrc_desc_pin apart

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. Further, the function that was populating it was also doing a bunch of logic about the context registration sequence. So, split that code apart into separate state setup and try to register functions. Note that some of those 'try to

[PATCH 1/8] drm/i915/guc: Do not conflate lrc_desc with GuC id for registration

2022-02-07 Thread John . C . Harrison
From: John Harrison The LRC descriptor pool is going away. So, stop using it as a check for context registration, use the GuC id instead (being the thing that actually gets registered with the GuC). Signed-off-by: John Harrison --- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 69

[PATCH 0/8] Prep work for next GuC release

2022-02-07 Thread John . C . Harrison
From: John Harrison The next GuC firmware release includes some significant backwards breaking API changes. One such is that there is no longer an LRC descriptor pool. A bunch of prep work for that change can be done in advance - the descriptor pool was being used for things it shouldn't really

Re: [PATCH v8 00/10] vgaarb: Rework default VGA device selection

2022-02-07 Thread Huacai Chen
Hi, Bjorn, On Tue, Feb 8, 2022 at 1:59 AM Bjorn Helgaas wrote: > > On Tue, Feb 01, 2022 at 04:46:33PM +0100, Maarten Lankhorst wrote: > > Op 31-01-2022 om 23:23 schreef Bjorn Helgaas: > > > [+to Maarten, Maxime, Thomas; beginning of thread: > > >

[PATCH] drm/i915/guc: Fix flag query to not modify state

2022-02-07 Thread John . C . Harrison
From: John Harrison A flag query helper was actually writing to the flags word rather than just reading. Fix that. Also update the function's comment as it was out of date. Fixes: 0f7976506de61 ("drm/i915/guc: Rework and simplify locking") Signed-off-by: John Harrison ---

Re: [PATCH v2 2/3] drm: Plumb debugfs_init through to panels

2022-02-07 Thread Laurent Pinchart
Hi Douglas, Thank you for the patch. On Fri, Feb 04, 2022 at 04:13:41PM -0800, Douglas Anderson wrote: > We'd like panels to be able to add things to debugfs underneath the > connector's directory. Let's plumb it through. A panel will be able to > put things in a "panel" directory under the

Re: [PATCH -next] drm/msm/dpu: clean up some inconsistent indenting

2022-02-07 Thread Abhinav Kumar
On 2/7/2022 5:23 PM, Yang Li wrote: Eliminate the follow smatch warning: drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:411 _dpu_crtc_blend_setup_mixer() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Abhinav Kumar ---

Re: [PATCH v2 1/3] drm/bridge: ti-sn65dsi86: Use drm_bridge_connector

2022-02-07 Thread Laurent Pinchart
Hi Doug, Thank you for the patch. On Fri, Feb 04, 2022 at 04:13:40PM -0800, Douglas Anderson wrote: > The ti-sn65dsi86 driver shouldn't hand-roll its own bridge > connector. It should use the normal drm_bridge_connector. Let's switch > to do that, removing all of the custom code. > > NOTE: this

[PATCH -next] drm/msm/dpu: clean up some inconsistent indenting

2022-02-07 Thread Yang Li
Eliminate the follow smatch warning: drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:411 _dpu_crtc_blend_setup_mixer() warn: inconsistent indenting Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v1 6/9] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2022-02-07 Thread Laurent Pinchart
Hello, On Mon, Feb 07, 2022 at 02:34:34PM -0800, Doug Anderson wrote: > On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote: > > > > From: Rob Clark > > > > Slightly awkward to fish out the display_info when we aren't creating > > own connector. But I don't see an obvious better way. > > > > v3:

Re: [PATCH v1 9/9] drm/bridge: Drop unused drm_bridge_chain functions

2022-02-07 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Feb 06, 2022 at 04:44:05PM +0100, Sam Ravnborg wrote: > The drm_bridge_chain_{pre_enable,enable,disable,post_disable} has no > users left and we have atomic variants that should be used. > Drop them so they do not gain new users. > > Adjust a few

Re: [PATCH v1 4/9] drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs

2022-02-07 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Feb 06, 2022 at 04:44:00PM +0100, Sam Ravnborg wrote: > Move away from the deprecated enable/diable operations in s/diable/disable/ > drm_bridge_funcs and enable atomic use. > > Signed-off-by: Sam Ravnborg > Cc: Douglas Anderson > Cc: Andrzej Hajda

Re: [PATCH v1 3/9] drm: add drm_atomic_helper_bridge_dsi_input_bus_fmt

2022-02-07 Thread Laurent Pinchart
Hello, On Mon, Feb 07, 2022 at 02:32:45PM -0800, Doug Anderson wrote: > On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote: > > > > There is a number of bridge drivers that supports a single media bus > > format for DSI. Add a helper to avoid duplicating the code. > > > > Signed-off-by: Sam

Re: [PATCH v1 2/9] drm: add drm specific media-bus-format header file

2022-02-07 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Feb 06, 2022 at 04:43:58PM +0100, Sam Ravnborg wrote: > For now the header file includes a single method to retreive the bpc s/retreive/retrieve/ > from the bus format. > The supported MEDIA_BUS_* codes are the ones used for the current panels > in DRM.

Re: [PATCH v1 1/9] drm/bridge: add DRM_BRIDGE_STATE_OPS macro

2022-02-07 Thread Laurent Pinchart
Hi Sam, Thank you for the patch. On Sun, Feb 06, 2022 at 04:43:57PM +0100, Sam Ravnborg wrote: > The DRM_BRIDGE_STATE_OPS can be used as shortcut for bridge drivers that > do not subclass drm_bridge_state to assign the default operations for > reset, duplicate and destroy of the state. > >

Re: [PATCH v1 0/3] Add support for eDP PHY on SC7280 platform

2022-02-07 Thread Doug Anderson
Hi, On Wed, Feb 2, 2022 at 1:54 PM Stephen Boyd wrote: > > Quoting Sankeerth Billakanti (2021-11-15 23:07:35) > > This series adds support for the eDP PHY on Qualcomm SC7280 platform. > > The changes are dependent on v4 of the new eDP PHY driver introduced by > > Bjorn: > >

Re: [Intel-gfx] [PATCH 3/4] drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item

2022-02-07 Thread kernel test robot
Hi Jordan, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next v5.17-rc3 next-20220207] [cannot apply to airlied/drm-next] [If your

Re: [PATCH 6/8] mm: don't include in

2022-02-07 Thread Dan Williams
On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > Move the check for the actual pgmap types that need the free at refcount > one behavior into the out of line helper, and thus avoid the need to > pull memremap.h into mm.h. Looks good to me assuming the compile bots agree.

Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages

2022-02-07 Thread Dan Williams
On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. Looks good to me: Reviewed-by: Dan Williams

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Verify hwconfig blob matches supported format

2022-02-07 Thread kernel test robot
Hi Jordan, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm-tip/drm-tip drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next v5.17-rc3 next-20220207] [cannot apply to airlied/drm-next] [If your

[PATCH][next] nouveau/svm: Use struct_size() helper in nouveau_pfns_map()

2022-02-07 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worse scenario, could lead to heap overflows. Link: https://github.com/KSPP/linux/issues/160 Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-02-07 Thread Rob Herring
On Thu, Jan 27, 2022 at 10:37:22AM +0100, Maxime Ripard wrote: > Hi, > > On Tue, Jan 25, 2022 at 06:56:58PM +0100, Noralf Trønnes wrote: > > Add binding for MIPI DBI compatible SPI panels. > > > > v2: > > - Fix path for panel-common.yaml > > - Use unevaluatedProperties > > - Drop properties

Re: [PATCH 4/6 v2] dt-bindings: display: simple: add Geekworm MZP280 Panel

2022-02-07 Thread Rob Herring
On Mon, 24 Jan 2022 10:55:24 -0600, Chris Morgan wrote: > From: Chris Morgan > > The Geekworm MZP280 panel is a 480x640 (portrait) panel with a > capacitive touch interface and a 40 pin header meant to interface > directly with the Raspberry Pi. The screen is 2.8 inches diagonally, > and there

Re: [PATCH 1/6 v2] dt-bindings: vendor-prefixes: Add Geekworm

2022-02-07 Thread Rob Herring
On Mon, 24 Jan 2022 10:55:21 -0600, Chris Morgan wrote: > From: Chris Morgan > > Add vendor prefix for Geekworm (https://geekworm.com). > > Signed-off-by: Chris Morgan > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Verify hwconfig blob matches supported format

2022-02-07 Thread kernel test robot
Hi Jordan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next v5.17-rc3 next-20220207] [cannot apply to airlied/drm-next

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Verify hwconfig blob matches supported format

2022-02-07 Thread kernel test robot
Hi Jordan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next drm/drm-next tegra-drm/drm/tegra/for-next v5.17-rc3 next-20220207] [If your patch is applied

Re: [PATCH v1 4/9] drm/bridge: ti-sn65dsi86: Use atomic variants of drm_bridge_funcs

2022-02-07 Thread Doug Anderson
Hi, On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote: > > Move away from the deprecated enable/diable operations in > drm_bridge_funcs and enable atomic use. > > Signed-off-by: Sam Ravnborg > Cc: Douglas Anderson > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: Laurent

[PATCH v2] dt-bindings: display: bridge: document Toshiba TC358768 cells and panel node

2022-02-07 Thread David Heidelberg
Inherit valid properties from the dsi-controller. Reviewed-by: Dmitry Osipenko Signed-off-by: David Heidelberg --- v2: - added $ref ../dsi-controller.yaml# instead copying properties (Dmitry) - additionalProperties -> unevaluatedProperties (Dmitry) - example dsi-bridge@ -> dsi@ (Dmitry)

Re: [PATCH v1 6/9] drm/bridge: ti-sn65dsi86: Add NO_CONNECTOR support

2022-02-07 Thread Doug Anderson
Hi, On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote: > > From: Rob Clark > > Slightly awkward to fish out the display_info when we aren't creating > own connector. But I don't see an obvious better way. > > v3: > - Rebased and dropped the ti_sn_bridge_get_bpp() patch >as this was solved

Re: [PATCH v1 5/9] drm/bridge: ti-sn65dsi86: Fetch bpc via drm_bridge_state

2022-02-07 Thread Doug Anderson
Hi, On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote: > > To prepare for DRM_BRIDGE_ATTACH_NO_CONNECTOR support, > fix so the bpc is found using the output format. > > This avoids the use of the connector stored in the private data. > > Signed-off-by: Sam Ravnborg > Cc: Douglas Anderson > Cc:

Re: [PATCH v1 3/9] drm: add drm_atomic_helper_bridge_dsi_input_bus_fmt

2022-02-07 Thread Doug Anderson
Hi, On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote: > > There is a number of bridge drivers that supports a single media bus > format for DSI. Add a helper to avoid duplicating the code. > > Signed-off-by: Sam Ravnborg > --- > drivers/gpu/drm/drm_atomic_helper.c | 41

Re: [PATCH v1 2/9] drm: add drm specific media-bus-format header file

2022-02-07 Thread Doug Anderson
Hi, On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote: > > For now the header file includes a single method to retreive the bpc > from the bus format. > The supported MEDIA_BUS_* codes are the ones used for the current panels > in DRM. The list can be extended as there are a need for more

Re: [PATCH v4 0/3] Support Sharp LQ101R1SX03 and HannStar HSD101PWW2 panels

2022-02-07 Thread Dmitry Osipenko
31.01.2022 21:12, Dmitry Osipenko пишет: > This series adds support for Sharp LQ101R1SX03 and HannStar HSD101PWW2 > display panels that are used by Asus Transformer tablets, which we're > planning to support since 5.17 kernel. > > Changelog: > > v4: - Added r-b from Rob Herring that he gave to

Re: [PATCH v1 1/9] drm/bridge: add DRM_BRIDGE_STATE_OPS macro

2022-02-07 Thread Doug Anderson
Hi, On Sun, Feb 6, 2022 at 7:44 AM Sam Ravnborg wrote: > > The DRM_BRIDGE_STATE_OPS can be used as shortcut for bridge drivers that > do not subclass drm_bridge_state to assign the default operations for > reset, duplicate and destroy of the state. > > Signed-off-by: Sam Ravnborg > Cc: Douglas

Re: [PATCH 16/23] drm/rcar: plane: Remove redundant zpos initialisation

2022-02-07 Thread Laurent Pinchart
Hello Maxime, Thank you for the patch. On Mon, Feb 07, 2022 at 05:35:08PM +0100, Maxime Ripard wrote: > The rcar-du KMS driver will call drm_plane_create_zpos_property() with an > init value depending on the plane type. > > Since the initial value wasn't carried over in the state, the driver

Re: [PATCH 07/23] drm/object: Add default zpos value at reset

2022-02-07 Thread Laurent Pinchart
Hi Maxime and Dave, Thank you for the patch. On Mon, Feb 07, 2022 at 05:34:59PM +0100, Maxime Ripard wrote: > From: Dave Stevenson > > The drm_plane_create_zpos_property() function asks for an initial value, > and will set the associated plane state variable with that value if a > state is

Re: [PATCH 06/23] drm/object: Add drm_object_property_get_default_value() function

2022-02-07 Thread Laurent Pinchart
Hi Maxime and Dave, Thank you for the patch. On Mon, Feb 07, 2022 at 05:34:58PM +0100, Maxime Ripard wrote: > From: Dave Stevenson > > Some functions to create properties (drm_plane_create_zpos_property or > drm_plane_create_color_properties for example) will ask for a range of > acceptable

[PATCH] drm/i915/psr: Disable PSR2 selective fetch for all TGL steps

2022-02-07 Thread Lyude Paul
As we've unfortunately started to come to expect from PSR on Intel platforms, PSR2 selective fetch is not at all ready to be enabled on Tigerlake as it results in severe flickering issues - at least on this ThinkPad X1 Carbon 9th generation. The easiest way I've found of reproducing these issues

[PATCH v1] drm/tegra: Use dev_err_probe()

2022-02-07 Thread Dmitry Osipenko
Replace dev_printk() with a generic dev_err_probe() helper which silences noisy error messages about deferred probe and makes easy to debug failing deferred probe by printing notification about the failure to KMSG in the end of kernel booting process and by adding failing device and the reason of

Re: [PATCH v3] drm/i915/dg2: Define GuC firmware version for DG2

2022-02-07 Thread John Harrison
Hmm, this is actually v1 not v3! Had something stale when posting. John. On 2/7/2022 12:36, john.c.harri...@intel.com wrote: From: John Harrison First release of GuC for DG2. Signed-off-by: John Harrison CC: Tomasz Mistat CC: Ramalingam C CC: Daniele Ceraolo Spurio ---

Re: [PATCH 6/8] mm: don't include in

2022-02-07 Thread Felix Kuehling
Am 2022-02-07 um 01:32 schrieb Christoph Hellwig: Move the check for the actual pgmap types that need the free at refcount one behavior into the out of line helper, and thus avoid the need to pull memremap.h into mm.h. Signed-off-by: Christoph Hellwig The amdkfd part looks good to me. It

Re: [PATCH] drm/amd/pm: add missing prototypes to amdgpu_dpm_internal

2022-02-07 Thread Alex Deucher
Applied. Thanks! On Sun, Feb 6, 2022 at 10:30 PM Quan, Evan wrote: > > [AMD Official Use Only] > > Thanks for the fix! > Reviewed-by: Evan Quan > > > -Original Message- > > From: Maíra Canal > > Sent: Thursday, February 3, 2022 8:40 AM > > To: Quan, Evan ; Deucher, Alexander > > ;

Re: [PATCH] drm/amd/pm: fix error handling

2022-02-07 Thread Alex Deucher
Applied. Thanks! Alex On Sun, Feb 6, 2022 at 10:04 PM Quan, Evan wrote: > > [AMD Official Use Only] > > Reviewed-by: Evan Quan > > > -Original Message- > > From: t...@redhat.com > > Sent: Saturday, February 5, 2022 11:00 PM > > To: Quan, Evan ; Deucher, Alexander > > ; Koenig,

[PATCH v3] drm/i915/dg2: Define GuC firmware version for DG2

2022-02-07 Thread John . C . Harrison
From: John Harrison First release of GuC for DG2. Signed-off-by: John Harrison CC: Tomasz Mistat CC: Ramalingam C CC: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c

Re: [PATCH 04/19] drm/i915/gt: Add helper for shmem copy to iosys_map

2022-02-07 Thread Lucas De Marchi
On Fri, Feb 04, 2022 at 08:15:12PM +0100, Thomas Zimmermann wrote: Hi Am 04.02.22 um 18:44 schrieb Lucas De Marchi: Add a variant of shmem_read() that takes a iosys_map pointer rather than a plain pointer as argument. It's mostly a copy __shmem_rw() but adapting the api and removing the write

[PATCH v6 3/6] drm/i915/gt: Re-work reset_csb

2022-02-07 Thread Michael Cheng
Use drm_clflush_virt_range instead of directly invoking clflush. This will prevent compiler errors when building for non-x86 architectures. v2(Michael Cheng): Remove extra clflush v3(Michael Cheng): Remove memory barrier since drm_clflush_virt_range takes care of it.

[PATCH v6 4/6] drm/i915/: Re-work clflush_write32

2022-02-07 Thread Michael Cheng
Use drm_clflush_virt_range instead of clflushopt and remove the memory barrier, since drm_clflush_virt_range takes care of that. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v6 5/6] drm/i915/gt: replace cache_clflush_range

2022-02-07 Thread Michael Cheng
Replace all occurance of cache_clflush_range with drm_clflush_virt_range. This will prevent compile errors on non-x86 platforms. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 12 ++-- drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +-

[PATCH v6 6/6] drm: Add arch arm64 for drm_clflush_virt_range

2022-02-07 Thread Michael Cheng
Use flush_tlb_kernel_range when invoking drm_clflush_virt_range on arm64 platforms. Using flush_tlb_kernel_range will: 1. Make sure prior page-table updates have been completed 2. Invalidate the TLB 3. Check if the TLB invalidation has been completed Signed-off-by: Michael Cheng ---

[PATCH v6 2/6] drm/i915/gt: Drop invalidate_csb_entries

2022-02-07 Thread Michael Cheng
Drop invalidate_csb_entries and directly call drm_clflush_virt_range. This allows for one less function call, and prevent complier errors when building for non-x86 architectures. v2(Michael Cheng): Drop invalidate_csb_entries function and directly invoke drm_clflush_virt_range.

[PATCH v6 0/6] Use drm_clflush* instead of clflush

2022-02-07 Thread Michael Cheng
This patch series re-work a few i915 functions to use drm_clflush_virt_range instead of calling clflush or clflushopt directly. This will prevent errors when building for non-x86 architectures.

[PATCH v6 1/6] drm/i915/gt: Re-work intel_write_status_page

2022-02-07 Thread Michael Cheng
Re-work intel_write_status_page to use drm_clflush_virt_range. This will prevent compiler errors when building for non-x86 architectures. Signed-off-by: Michael Cheng --- drivers/gpu/drm/i915/gt/intel_engine.h | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git

Re: [PATCH 8/8] fsdax: depend on ZONE_DEVICE || FS_DAX_LIMITED

2022-02-07 Thread Jason Gunthorpe
On Mon, Feb 07, 2022 at 07:32:49AM +0100, Christoph Hellwig wrote: > Add a depends on ZONE_DEVICE support or the s390-specific limited DAX > support, as one of the two is required at runtime for fsdax code to > actually work. > > Signed-off-by: Christoph Hellwig > --- > fs/Kconfig | 1 + > 1

Re: [PATCH 6/8] mm: don't include in

2022-02-07 Thread Jason Gunthorpe
On Mon, Feb 07, 2022 at 07:32:47AM +0100, Christoph Hellwig wrote: > Move the check for the actual pgmap types that need the free at refcount > one behavior into the out of line helper, and thus avoid the need to > pull memremap.h into mm.h. > > Signed-off-by: Christoph Hellwig > --- >

Re: [PATCH 5/8] mm: simplify freeing of devmap managed pages

2022-02-07 Thread Jason Gunthorpe
On Mon, Feb 07, 2022 at 07:32:46AM +0100, Christoph Hellwig wrote: > Make put_devmap_managed_page return if it took charge of the page > or not and remove the separate page_is_devmap_managed helper. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 34

[PATCH 4/4] drm/i915/guc: Verify hwconfig blob matches supported format

2022-02-07 Thread Jordan Justen
Signed-off-by: Jordan Justen --- .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c | 26 +++ 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c index ce6088f112d4..695ef7a8f519 100644 ---

[PATCH 3/4] drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item

2022-02-07 Thread Jordan Justen
Also, document DRM_I915_QUERY_HWCONFIG_BLOB with this struct. Cc: Daniel Vetter Signed-off-by: Jordan Justen --- include/uapi/drm/i915_drm.h | 24 1 file changed, 24 insertions(+) diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index

[PATCH 1/4] drm/i915/guc: Add fetch of hwconfig table

2022-02-07 Thread Jordan Justen
From: John Harrison Implement support for fetching the hardware description table from the GuC. The call is made twice - once without a destination buffer to query the size and then a second time to fill in the buffer. Note that the table is only available on ADL-P and later platforms. Cc:

[PATCH 2/4] drm/i915/uapi: Add query for hwconfig blob

2022-02-07 Thread Jordan Justen
From: Rodrigo Vivi The DRM_I915_QUERY_HWCONFIG_BLOB query item returns a blob of data which it receives from the GuC software. This blob provides some useful data about the hardware for drivers. Although the blob is not fully documented at this time, the basic format is an array of u32 values.

[PATCH 0/4] GuC HWCONFIG with documentation

2022-02-07 Thread Jordan Justen
This is John/Rodrigo's 2 patches with some minor changes, and I added 2 patches. "drm/i915/uapi: Add query for hwconfig blob" was changed: * Rename DRM_I915_QUERY_HWCONFIG_TABLE to DRM_I915_QUERY_HWCONFIG_BLOB as requested by Joonas. * Reword commit message * I added Acked-by to this

Re: [PATCH 04/23] drm/msm/mdp5: Fix zpos initial value mismatch

2022-02-07 Thread Dmitry Baryshkov
On Mon, 7 Feb 2022 at 19:56, Maxime Ripard wrote: > > While the mdp5_plane_install_properties() function calls > drm_plane_create_zpos_property() with an initial value of 1, > mdp5_plane_reset() will force it to another value depending on the plane > type. > > Fix the discrepancy by setting the

Re: [PATCH 4/8] mm: move free_devmap_managed_page to memremap.c

2022-02-07 Thread Jason Gunthorpe
On Mon, Feb 07, 2022 at 07:32:45AM +0100, Christoph Hellwig wrote: > free_devmap_managed_page has nothing to do with the code in swap.c, > move it to live with the rest of the code for devmap handling. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 1 - > mm/memremap.c

Re: [PATCH 2/8] mm: remove the __KERNEL__ guard from

2022-02-07 Thread Jason Gunthorpe
On Mon, Feb 07, 2022 at 07:32:43AM +0100, Christoph Hellwig wrote: > __KERNEL__ ifdefs don't make sense outside of include/uapi/. > > Signed-off-by: Christoph Hellwig > --- > include/linux/mm.h | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Jason Gunthorpe Jason

Re: [PATCH 19/23] drm/object: Add default color encoding and range value at reset

2022-02-07 Thread Harry Wentland
On 2022-02-07 11:35, Maxime Ripard wrote: > From: Dave Stevenson > > The drm_plane_create_color_properties() function asks for an initial > value for the color encoding and range, and will set the associated > plane state variable with that value if a state is present. > > However, that

Re: [PATCH 07/23] drm/object: Add default zpos value at reset

2022-02-07 Thread Harry Wentland
On 2022-02-07 11:34, Maxime Ripard wrote: > From: Dave Stevenson > > The drm_plane_create_zpos_property() function asks for an initial value, > and will set the associated plane state variable with that value if a > state is present. > > However, that function is usually called at a time

Re: [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages

2022-02-07 Thread Jason Gunthorpe
On Mon, Feb 07, 2022 at 07:32:42AM +0100, Christoph Hellwig wrote: > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. > > Signed-off-by: Christoph Hellwig > --- > mm/memremap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH 7/8] mm: remove the extra ZONE_DEVICE struct page refcount

2022-02-07 Thread Jason Gunthorpe
On Mon, Feb 07, 2022 at 07:32:48AM +0100, Christoph Hellwig wrote: > ZONE_DEVICE struct pages have an extra reference count that complicates > the code for put_page() and several places in the kernel that need to > check the reference count to see that a page is not being used (gup, > compaction,

Re: [PATCH 4/8] mm: move free_devmap_managed_page to memremap.c

2022-02-07 Thread Dan Williams
On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > free_devmap_managed_page has nothing to do with the code in swap.c, > move it to live with the rest of the code for devmap handling. > Looks good. Reviewed-by: Dan Williams

Re: [PATCH 05/23] drm/amd/display: Fix color encoding mismatch

2022-02-07 Thread Harry Wentland
On 2022-02-07 13:57, Harry Wentland wrote: > On 2022-02-07 11:34, Maxime Ripard wrote: >> The amdgpu KMS driver calls drm_plane_create_color_properties() with a >> default encoding set to BT709. >> >> However, the core will ignore it and the driver doesn't force it in its >> plane state reset

Re: [PATCH 05/23] drm/amd/display: Fix color encoding mismatch

2022-02-07 Thread Harry Wentland
On 2022-02-07 11:34, Maxime Ripard wrote: > The amdgpu KMS driver calls drm_plane_create_color_properties() with a > default encoding set to BT709. > > However, the core will ignore it and the driver doesn't force it in its > plane state reset hook, so the initial value will be 0, which

Re: [PATCH v5 2/5] drm/i915/gt: Drop invalidate_csb_entries

2022-02-07 Thread Michael Cheng
Ah, sorry thanks for pointing that out. We did discuss previously. I will go ahead and change it. On 2022-02-07 3:57 a.m., Tvrtko Ursulin wrote: On 04/02/2022 16:37, Michael Cheng wrote: Drop invalidate_csb_entries and directly call drm_clflush_virt_range. This allows for one less function

Re: [PATCH 2/8] mm: remove the __KERNEL__ guard from

2022-02-07 Thread Dan Williams
On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > __KERNEL__ ifdefs don't make sense outside of include/uapi/. Yes. Reviewed-by: Dan Williams

Re: [PATCH 1/8] mm: remove a pointless CONFIG_ZONE_DEVICE check in memremap_pages

2022-02-07 Thread Dan Williams
On Sun, Feb 6, 2022 at 10:33 PM Christoph Hellwig wrote: > > memremap.c is only built when CONFIG_ZONE_DEVICE is set, so remove > the superflous extra check. Looks good to me. Reviewed-by: Dan Williams

Re: [PATCH v8 00/10] vgaarb: Rework default VGA device selection

2022-02-07 Thread Bjorn Helgaas
On Tue, Feb 01, 2022 at 04:46:33PM +0100, Maarten Lankhorst wrote: > Op 31-01-2022 om 23:23 schreef Bjorn Helgaas: > > [+to Maarten, Maxime, Thomas; beginning of thread: > > https://lore.kernel.org/r/20220106000658.243509-1-helg...@kernel.org] > > > > On Wed, Jan 05, 2022 at 06:06:48PM -0600,

Re: [Intel-gfx] [PATCH 5/5] drm/i915/guc: Allow user to override driver load failure without GuC

2022-02-07 Thread Daniele Ceraolo Spurio
On 1/28/2022 10:52 AM, Ramalingam C wrote: From: Stuart Summers The driver is set currently to fail modprobe when GuC is disabled (enable_guc=0) after GuC has been loaded on a previous modprobe. For GuC deprivilege, the BIOS is setting the locked bit, so the driver always considers the GuC

Re: [PATCH 5/5] drm/stm: ltdc: add support of ycbcr pixel formats

2022-02-07 Thread Nathan Chancellor
On Mon, Feb 07, 2022 at 11:00:34AM +0100, yannick Fertre wrote: > Hi Nathan, > > On 2/2/22 17:54, Nathan Chancellor wrote: > > Hi Yannick, > > > > On Wed, Dec 15, 2021 at 10:48:43PM +0100, Yannick Fertre wrote: > > > This patch adds the following YCbCr input pixel formats on the latest > > >

[PATCH] drm/stm: Avoid using val uninitialized in ltdc_set_ycbcr_config()

2022-02-07 Thread Nathan Chancellor
Clang warns: drivers/gpu/drm/stm/ltdc.c:625:2: warning: variable 'val' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized] default: ^~~ drivers/gpu/drm/stm/ltdc.c:635:2: note: uninitialized use occurs here val |= LxPCR_YCEN;

[PATCH 23/23] drm/omap: plane: Remove redundant color encoding and range initialisation

2022-02-07 Thread Maxime Ripard
The omap KMS driver will call drm_plane_create_color_properties() with a default encoding and range values of BT601 and Full Range, respectively. Since the initial value wasn't carried over in the state, the driver had to set it again in omap_plane_reset(). However, the helpers have been adjusted

[PATCH 22/23] drm/imx: ipuv3-plane: Remove redundant color encoding and range initialisation

2022-02-07 Thread Maxime Ripard
The imx KMS driver will call drm_plane_create_color_properties() with a default encoding and range values of BT601 and Limited Range, respectively. Since the initial value wasn't carried over in the state, the driver had to set it again in ipu_plane_state_reset(). However, the helpers have been

  1   2   3   >