Re: [PATCH v12 1/5] drm: improve drm_buddy_alloc function

2022-02-15 Thread Arunpravin
On 14/02/22 2:42 pm, Christian König wrote: > > > Am 14.02.22 um 09:36 schrieb Matthew Auld: >> On Mon, 14 Feb 2022 at 06:32, Christian König >> wrote: >>> Am 13.02.22 um 09:52 schrieb Arunpravin: - Make drm_buddy_alloc a single function to handle range allocation and non-range

Re: [PATCH] drm: fb-helper: Avoid nesting spinlock_t into raw_spinlock_t

2022-02-15 Thread Sebastian Siewior
On 2022-02-15 20:59:24 [+0100], Jiri Kosina wrote: > Thanks for confirmation, seems like this problem is indeed cured by your > series. Oki. > I still believe though that we shouldn't let 5.17 released with this > warning being emitted into dmesg, so I'd suggest going with my patch for >

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Abhinav Kumar
On 2/15/2022 9:14 PM, Bjorn Andersson wrote: On Tue 15 Feb 20:38 CST 2022, Abhinav Kumar wrote: On 2/15/2022 6:14 PM, Bjorn Andersson wrote: On Tue 15 Feb 11:42 CST 2022, Abhinav Kumar wrote: On 2/15/2022 9:28 AM, Bjorn Andersson wrote: On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 20:38 CST 2022, Abhinav Kumar wrote: > > > On 2/15/2022 6:14 PM, Bjorn Andersson wrote: > > On Tue 15 Feb 11:42 CST 2022, Abhinav Kumar wrote: > > > > > > > > > > > On 2/15/2022 9:28 AM, Bjorn Andersson wrote: > > > > On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: > > > >

Re: Report in unix_stream_read_generic()

2022-02-15 Thread Matthew Wilcox
On Wed, Feb 16, 2022 at 01:17:03PM +0900, Byungchul Park wrote: > [7.013330] === > [7.013331] DEPT: Circular dependency has been detected. > [7.013332] 5.17.0-rc1-00014-gcf3441bb2012 #2 Tainted: GW > [7.01]

[PATCH] drm/i915/guc/slpc: Use wrapper for reading RP_STATE_CAP

2022-02-15 Thread Vinay Belgaumkar
This will ensure correct values for Gen12+ platforms. Cc: Matt Roper Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c

Re: [PATCH] drm/msm/dpu: drop unused access macros

2022-02-15 Thread Abhinav Kumar
On 2/15/2022 6:53 AM, Dmitry Baryshkov wrote: The access macros BLK_foo are not used by the code, drop them. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 16 1 file changed, 16 deletions(-) diff --git

Re: [PATCH v2 1/2] drm/msm/dpu: Add INTF_5 interrupts

2022-02-15 Thread Abhinav Kumar
On 2/14/2022 8:33 PM, Bjorn Andersson wrote: SC8180x has the eDP controller wired up to INTF_5, so add the interrupt register block for this interface to the list. Signed-off-by: Bjorn Andersson Reviewed-by: Abhinav Kumar --- Changes since v1: - None

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Abhinav Kumar
On 2/15/2022 6:14 PM, Bjorn Andersson wrote: On Tue 15 Feb 11:42 CST 2022, Abhinav Kumar wrote: On 2/15/2022 9:28 AM, Bjorn Andersson wrote: On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: On 2/14/2022 8:33 PM, Bjorn Andersson wrote: From: Rob Clark Add SC8180x to the hardware

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-15 Thread Alistair Popple
On Wednesday, 16 February 2022 1:03:57 PM AEDT Jason Gunthorpe wrote: > On Wed, Feb 16, 2022 at 12:23:44PM +1100, Alistair Popple wrote: > > > Device private and device coherent pages are not marked with pte_devmap and > > they > > are backed by a struct page. The only way of inserting them is

Re: [PATCH v4 2/2] drm/msm/dp: rewrite dss_module_power to use bulk clock functions

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-31 13:05:13) > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.h > b/drivers/gpu/drm/msm/dp/dp_parser.h > index 094b39bfed8c..f16072f33cdb 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.h > +++ b/drivers/gpu/drm/msm/dp/dp_parser.h > @@ -10,7 +10,6 @@ > #include

Re: [PATCH 6/6] drm/msm/dpu: pass irq to dpu_encoder_helper_wait_for_irq()

2022-02-15 Thread Abhinav Kumar
On 2/1/2022 7:10 AM, Dmitry Baryshkov wrote: Pass IRQ number directly rather than passing an index in the dpu_encoder's irq table. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 29 +--

Re: [PATCH v4 1/2] drm/msm/dpu: simplify clocks handling

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-01-31 13:05:12) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > index 60fe06018581..4d184122d63e 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c > +++

Re: [PATCH] drm/msm: populate intf_audio_select() base on hardware capability

2022-02-15 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-02-11 15:23:42) > intf_audio_select() callback function use to configure > HDMI_DP_CORE_SELECT to decide audio output routes to HDMI or DP > interface. HDMI is obsoleted at newer chipset. To keep supporting > legacy hdmi application, intf_audio_select call back function

Re: [PATCH v3] drm/msm/dpu: Only create debugfs for PRIMARY minor

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-11 16:38:11) > From: Bjorn Andersson > > dpu_kms_debugfs_init() is invoked for each minor being registered. Most > of the files created are unrelated to the minor, so there's no reason to > present them per minor. > The exception to this is the DisplayPort code,

Re: [PATCH 6/6] drm/msm/dpu: pass irq to dpu_encoder_helper_wait_for_irq()

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:56) > Pass IRQ number directly rather than passing an index in the dpu_encoder's > irq table. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:55) > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > index ff2218155b44..803fd6f25da1 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h > +++

Re: [PATCH 4/6] drm/msm/dpu: get rid of dpu_encoder_helper_(un)register_irq

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:54) > Get rid of dpu_encoder_helper_register_irq/unregister_irq helpers, call > dpu_core_register/unregister_callback directly, without surrounding them > with helpers. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar > --- Reviewed-by:

Re: [PATCH 2/6] drm/msm/dpu: remove always-true argument of dpu_core_irq_read()

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:52) > The argument clear of the function dpu_core_irq_read() is always true. > Remove it. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH 1/6] drm/msm/dpu: remove extra wrappers around dpu_core_irq

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-01 07:10:51) > Remove extra dpu_irq_* wrappers from dpu_kms.c, merge them directly into > dpu_core_irq_* functions. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by: Abhinav Kumar > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 7/8] drm/msm/dpu: pull connector from dpu_encoder_phys to dpu_encoder_virt

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 18:13:09) > On Wed, 16 Feb 2022 at 05:00, Stephen Boyd wrote: > > > > Quoting Dmitry Baryshkov (2022-02-15 06:16:42) > > > All physical encoders used by virtual encoder share the same connector, > > > so pull the connector field from dpu_encoder_phys into

Re: [Freedreno] [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Abhinav Kumar
On 2/15/2022 6:03 PM, Bjorn Andersson wrote: On Tue 15 Feb 19:34 CST 2022, Abhinav Kumar wrote: On 2/15/2022 4:20 PM, Dmitry Baryshkov wrote: On Tue, 15 Feb 2022 at 23:21, Abhinav Kumar wrote: On 2/15/2022 10:42 AM, Dmitry Baryshkov wrote: On Tue, 15 Feb 2022 at 20:42, Abhinav Kumar

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 11:42 CST 2022, Abhinav Kumar wrote: > > > On 2/15/2022 9:28 AM, Bjorn Andersson wrote: > > On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: > > > > > > > > > > > On 2/14/2022 8:33 PM, Bjorn Andersson wrote: > > > > From: Rob Clark > > > > > > > > Add SC8180x to the

Re: [PATCH v2 7/8] drm/msm/dpu: pull connector from dpu_encoder_phys to dpu_encoder_virt

2022-02-15 Thread Dmitry Baryshkov
On Wed, 16 Feb 2022 at 05:00, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-02-15 06:16:42) > > All physical encoders used by virtual encoder share the same connector, > > so pull the connector field from dpu_encoder_phys into dpu_encoder_virt > > structure. > > What is the benefit? Less

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-15 Thread Jason Gunthorpe
On Wed, Feb 16, 2022 at 12:23:44PM +1100, Alistair Popple wrote: > Device private and device coherent pages are not marked with pte_devmap and > they > are backed by a struct page. The only way of inserting them is via > migrate_vma. > The refcount is decremented in zap_pte_range() on munmap()

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 19:34 CST 2022, Abhinav Kumar wrote: > > > On 2/15/2022 4:20 PM, Dmitry Baryshkov wrote: > > On Tue, 15 Feb 2022 at 23:21, Abhinav Kumar > > wrote: > > > On 2/15/2022 10:42 AM, Dmitry Baryshkov wrote: > > > > On Tue, 15 Feb 2022 at 20:42, Abhinav Kumar > > > > wrote: > > > > >

Re: [PATCH] drm/msm/dpu: drop unused access macros

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:53:06) > The access macros BLK_foo are not used by the code, drop them. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-15 Thread Jason Gunthorpe
On Tue, Feb 15, 2022 at 05:49:07PM -0500, Felix Kuehling wrote: > > Userspace does > > 1) mmap(MAP_PRIVATE) to allocate anon memory > > 2) something to trigger migration to install a ZONE_DEVICE page > > 3) munmap() > > > > Who decrements the refcout on the munmap? > > > > When a

Re: [PATCH v2 7/8] drm/msm/dpu: pull connector from dpu_encoder_phys to dpu_encoder_virt

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:42) > All physical encoders used by virtual encoder share the same connector, > so pull the connector field from dpu_encoder_phys into dpu_encoder_virt > structure. What is the benefit? Less code? Clearer association?

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-15 Thread Alistair Popple
Jason Gunthorpe writes: > On Tue, Feb 15, 2022 at 04:35:56PM -0500, Felix Kuehling wrote: >> >> On 2022-02-15 14:41, Jason Gunthorpe wrote: >> > On Tue, Feb 15, 2022 at 07:32:09PM +0100, Christoph Hellwig wrote: >> > > On Tue, Feb 15, 2022 at 10:45:24AM -0400, Jason Gunthorpe wrote: >> > > > >

Re: [PATCH v2 6/8] drm/msm/dpu: switch dpu_encoder to use atomic_mode_set

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:41) > Make dpu_encoder use atomic_mode_set to receive connector and CRTC > states as arguments rather than finding connector and CRTC by manually > looping through the respective lists. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov >

Re: [PATCH v2 5/8] drm/msm/dpu: encoder: drop unused mode_fixup callback

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:40) > Both cmd and vid backends provide useless mode_fixup() callback. Drop > it. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 4/8] drm/msm/dpu: drop bus_scaling_client field

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:39) > We do not use MSM bus client, so drop bus_scaling_client field from > dpu_encoder_virt. > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 3/8] drm/msm/dpu: remove msm_dp cached in dpu_encoder_virt

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:38) > Stop caching msm_dp instance in dpu_encoder_virt since it's not used > now. > > Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable > and disable") > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > ---

Re: [PATCH 5/6] drm/msm/dpu: remove struct dpu_encoder_irq

2022-02-15 Thread Abhinav Kumar
On 2/1/2022 7:10 AM, Dmitry Baryshkov wrote: Remove additional indirection: specify IRQ callbacks and IRQ indices directly rather than through the pointer in the irq structure. For each IRQ we have a constant IRQ callback. This change simplifies code review as the reader no longer needs to

Re: [PATCH v2 2/8] drm/msm: move struct msm_display_info to dpu driver

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:37) > The msm_display_info structure is not used by the rest of msm driver, so > move it into the dpu1 (dpu_encoder.h to be precise). > > Reviewed-by: Abhinav Kumar > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Stephen Boyd

Re: [PATCH v2 1/8] drm/msm/dpu: fix dp audio condition

2022-02-15 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2022-02-15 06:16:36) > DP audio enablement code which is comparing intf_type, > DRM_MODE_ENCODER_TMDS (= 2) with DRM_MODE_CONNECTOR_DisplayPort (= 10). > Which would never succeed. Fix it to check for DRM_MODE_ENCODER_TMDS. > > Fixes: d13e36d7d222 ("drm/msm/dp: add audio

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Abhinav Kumar
On 2/15/2022 4:20 PM, Dmitry Baryshkov wrote: On Tue, 15 Feb 2022 at 23:21, Abhinav Kumar wrote: On 2/15/2022 10:42 AM, Dmitry Baryshkov wrote: On Tue, 15 Feb 2022 at 20:42, Abhinav Kumar wrote: On 2/15/2022 9:28 AM, Bjorn Andersson wrote: On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar

Re: [PATCH] drm/virtio: Fix capset-id query size

2022-02-15 Thread Gurchetan Singh
On Tue, Feb 15, 2022 at 5:15 PM Rob Clark wrote: > From: Rob Clark > > The UABI was already defined for pointer to 64b value, and all the > userspace users of this ioctl that I could find are already using a > uint64_t (but zeroing it out to work around kernel only copying 32b). > Unfortunately

Re: [PATCH 1/1] drm/amdkfd: Replace zero-length array with flexible-array member

2022-02-15 Thread philip yang
On 2022-02-15 7:38 p.m., Felix Kuehling wrote: Reference: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays CC: Changcheng Deng Signed-off-by: Felix Kuehling Reviewed-by: Philip Yang

[PATCH] drm/virtio: Fix capset-id query size

2022-02-15 Thread Rob Clark
From: Rob Clark The UABI was already defined for pointer to 64b value, and all the userspace users of this ioctl that I could find are already using a uint64_t (but zeroing it out to work around kernel only copying 32b). Unfortunately this ioctl doesn't have a length field, so out of paranoia I

Re: [PATCH v2] drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX

2022-02-15 Thread Brian Norris
On Tue, Feb 15, 2022 at 3:46 PM Doug Anderson wrote: > On Tue, Feb 15, 2022 at 2:52 PM Brian Norris wrote: > > It still makes me wonder what the point > > of the /dev/drm_dp_aux interface is though, because it seems like > > you're pretty much destined to not have reliable operation through > >

[PATCH 1/1] drm/amdkfd: Replace zero-length array with flexible-array member

2022-02-15 Thread Felix Kuehling
Reference: https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays CC: Changcheng Deng Signed-off-by: Felix Kuehling --- include/uapi/linux/kfd_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/kfd_ioctl.h

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Dmitry Baryshkov
On Tue, 15 Feb 2022 at 23:21, Abhinav Kumar wrote: > On 2/15/2022 10:42 AM, Dmitry Baryshkov wrote: > > On Tue, 15 Feb 2022 at 20:42, Abhinav Kumar > > wrote: > >> On 2/15/2022 9:28 AM, Bjorn Andersson wrote: > >>> On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: > >>> > > > On

Re: [PATCH] drm/amdkfd: Replace zero-length array with flexible-array member

2022-02-15 Thread Felix Kuehling
On 2022-02-15 04:11, cgel@gmail.com wrote: From: Changcheng Deng There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use "flexible array members" for these cases. The older style

Re: [PATCH 3/6] drm/msm/dpu: allow just single IRQ callback

2022-02-15 Thread Abhinav Kumar
On 2/1/2022 7:10 AM, Dmitry Baryshkov wrote: DPU interrupts code allows multiple callbacks per interrut. In reality none of the interrupts is shared between blocks (and will probably never be). Drop support for registering multiple callbacks per interrupt to simplify interrupt handling code.

[PATCH 1/2] drm/bridge: analogix_dp: Support PSR-exit to disable transition

2022-02-15 Thread Brian Norris
Most eDP panel functions only work correctly when the panel is not in self-refresh. In particular, analogix_dp_bridge_disable() tends to hit AUX channel errors if the panel is in self-refresh. Given the above, it appears that so far, this driver assumes that we are never in self-refresh when it

[PATCH 2/2] drm/atomic: Force bridge self-refresh-exit on CRTC switch

2022-02-15 Thread Brian Norris
It's possible to change which CRTC is in use for a given connector/encoder/bridge while we're in self-refresh without fully disabling the connector/encoder/bridge along the way. This can confuse the bridge encoder/bridge, because (a) it needs to track the SR state (trying to perform "active"

[PATCH 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes

2022-02-15 Thread Brian Norris
Hi, I've been investigating several eDP issues on a Rockchip RK3399 system and have two proposed bugfixes. RK3399 has two CRTCs, either of which can be used for eDP output. For both fixes, we have bugs due to the relationship between the generalized "self refresh helpers" and the analogix-dp

Re: [PATCH v2] drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX

2022-02-15 Thread Doug Anderson
Hi, On Tue, Feb 15, 2022 at 2:52 PM Brian Norris wrote: > > On Tue, Feb 15, 2022 at 1:31 PM Doug Anderson wrote: > > > > Hi, > > Hi! > > > On Fri, Oct 1, 2021 at 2:50 PM Brian Norris > > wrote: > > > > > > If the display is not enable()d, then we aren't holding a runtime PM > > > reference

Re: [PATCH v2 0/3] drm/panel-edp: Debugfs for panel-edp

2022-02-15 Thread Doug Anderson
Hi, On Fri, Feb 4, 2022 at 4:14 PM Douglas Anderson wrote: > > The main goal of this series is the final patch in the series: to > allow test code to reliably find out if we ended up hitting the > "fallback" case of the generic edp-panel driver where we don't > recognize a panel and choose to

Re: [Intel-gfx] [PATCH v2 08/18] drm/i915/guc: Convert engine record to iosys_map

2022-02-15 Thread Matt Atwood
On Tue, Feb 08, 2022 at 02:45:14AM -0800, Lucas De Marchi wrote: > Use iosys_map to read fields from the dma_blob so access to IO and > system memory is abstracted away. > > Cc: Matt Roper > Cc: Thomas Hellström > Cc: Daniel Vetter > Cc: John Harrison > Cc: Matthew Brost > Cc: Daniele

Re: [PATCH 2/6] drm/msm/dpu: remove always-true argument of dpu_core_irq_read()

2022-02-15 Thread Abhinav Kumar
On 2/1/2022 7:10 AM, Dmitry Baryshkov wrote: The argument clear of the function dpu_core_irq_read() is always true. Remove it. Signed-off-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.h | 4 +---

Re: [PATCH v2 2/3] drm: Plumb debugfs_init through to panels

2022-02-15 Thread Doug Anderson
Hi, On Tue, Feb 15, 2022 at 2:20 PM Andrzej Hajda wrote: > > On 15.02.2022 23:09, Javier Martinez Canillas wrote: > > Hello Doug, > > > > On 2/5/22 01:13, Douglas Anderson wrote: > > > > [snip] > > > >> +static void panel_bridge_debugfs_init(struct drm_bridge *bridge, > >> +

Re: [PATCH v2] drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX

2022-02-15 Thread Brian Norris
On Tue, Feb 15, 2022 at 1:31 PM Doug Anderson wrote: > > Hi, Hi! > On Fri, Oct 1, 2021 at 2:50 PM Brian Norris wrote: > > > > If the display is not enable()d, then we aren't holding a runtime PM > > reference here. Thus, it's easy to accidentally cause a hang, if user > > space is poking

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-15 Thread Felix Kuehling
On 2022-02-15 16:47, Jason Gunthorpe wrote: On Tue, Feb 15, 2022 at 04:35:56PM -0500, Felix Kuehling wrote: On 2022-02-15 14:41, Jason Gunthorpe wrote: On Tue, Feb 15, 2022 at 07:32:09PM +0100, Christoph Hellwig wrote: On Tue, Feb 15, 2022 at 10:45:24AM -0400, Jason Gunthorpe wrote: Do you

[PATCH 1/2] drm/mm: Add an iterator to optimally walk over holes for an allocation (v3)

2022-02-15 Thread Vivek Kasireddy
This iterator relies on drm_mm_first_hole() and drm_mm_next_hole() functions to identify suitable holes for an allocation of a given size by efficiently traversing the rbtree associated with the given allocator. It replaces the for loop in drm_mm_insert_node_in_range() and can also be used by drm

Re: [PATCH] drm/panfrost: Dynamically allocate pm_domains

2022-02-15 Thread Alyssa Rosenzweig
> I'd do the oneliner changing it to 5 and be done with it. That being > said, we have plenty of examples of doing this both ways, so whatever > makes people happy. Excellent, that's the patch I wrote originally :-) Dropping this patch, unless Angelo (or someone else) strongly objects.

Re: [PATCH v2 2/3] drm: Plumb debugfs_init through to panels

2022-02-15 Thread Andrzej Hajda
On 15.02.2022 23:09, Javier Martinez Canillas wrote: Hello Doug, On 2/5/22 01:13, Douglas Anderson wrote: [snip] +static void panel_bridge_debugfs_init(struct drm_bridge *bridge, + struct dentry *root) +{ + struct panel_bridge *panel_bridge =

Re: [PATCH v2 3/3] drm/panel-edp: Allow querying the detected panel via debugfs

2022-02-15 Thread Javier Martinez Canillas
On 2/5/22 01:13, Douglas Anderson wrote: > Recently we added generic "edp-panel"s probed by EDID. To support > panels in this way we look at the panel ID in the EDID and look up the > panel in a table that has power sequence timings. If we find a panel > that's not in the table we will still

Re: [PATCH v2 2/3] drm: Plumb debugfs_init through to panels

2022-02-15 Thread Javier Martinez Canillas
Hello Doug, On 2/5/22 01:13, Douglas Anderson wrote: [snip] > +static void panel_bridge_debugfs_init(struct drm_bridge *bridge, > + struct dentry *root) > +{ > + struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge); > + struct

Re: [PATCH] drm/panfrost: Dynamically allocate pm_domains

2022-02-15 Thread Rob Herring
On Mon, Feb 14, 2022 at 2:31 PM Alyssa Rosenzweig wrote: > > MT8192 requires 5 power domains. Rather than bump MAX_PM_DOMAINS and > waste memory on every supported Panfrost chip, instead dynamically > allocate pm_domain_devs and pm_domain_links. This adds some flexibility; > it seems inevitable a

Re: [PATCH v2 1/3] migrate.c: Remove vma check in migrate_vma_setup()

2022-02-15 Thread John Hubbard
On 2/6/22 20:26, Alistair Popple wrote: migrate_vma_setup() checks that a valid vma is passed so that the page tables can be walked to find the pfns associated with a given address range. However in some cases the pfns are already known, such as when migrating device coherent pages during

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-15 Thread Jason Gunthorpe
On Tue, Feb 15, 2022 at 04:35:56PM -0500, Felix Kuehling wrote: > > On 2022-02-15 14:41, Jason Gunthorpe wrote: > > On Tue, Feb 15, 2022 at 07:32:09PM +0100, Christoph Hellwig wrote: > > > On Tue, Feb 15, 2022 at 10:45:24AM -0400, Jason Gunthorpe wrote: > > > > > Do you know if DEVICE_GENERIC

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-15 Thread Felix Kuehling
On 2022-02-15 14:41, Jason Gunthorpe wrote: On Tue, Feb 15, 2022 at 07:32:09PM +0100, Christoph Hellwig wrote: On Tue, Feb 15, 2022 at 10:45:24AM -0400, Jason Gunthorpe wrote: Do you know if DEVICE_GENERIC pages would end up as PageAnon()? My assumption was that they would be part of a

Re: [PATCH v2] drm/bridge: analogix_dp: Grab runtime PM reference for DP-AUX

2022-02-15 Thread Doug Anderson
Hi, On Fri, Oct 1, 2021 at 2:50 PM Brian Norris wrote: > > If the display is not enable()d, then we aren't holding a runtime PM > reference here. Thus, it's easy to accidentally cause a hang, if user > space is poking around at /dev/drm_dp_aux0 at the "wrong" time. > > Let's get the panel and PM

[PATCH v5 2/2] drm/msm/dp: enable widebus feature for display port

2022-02-15 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. This feature now is required to be enabled to easy migrant to higher resolution applications in future. However since some legacy chipsets does not support this feature, this feature is enabled base on chip's hardware

[PATCH v5 1/2] drm/msm/dpu: revise timing engine programming to support widebus feature

2022-02-15 Thread Kuogee Hsieh
Widebus feature will transmit two pixel data per pixel clock to interface. Timing engine provides driving force for this purpose. This patch base on HPG (Hardware Programming Guide) to revise timing engine register setting to accommodate both widebus and non widebus application. Also horizontal

[PATCH v5 0/2] drm/msm/dp: enable widebus feature base on chip hardware revision

2022-02-15 Thread Kuogee Hsieh
revise widebus timing engine programming and enable widebus feature base on chip hardware revision Kuogee Hsieh (2): drm/msm/dpu: revise timing engine programming to support widebus feature drm/msm/dp: enable widebus feature for display port drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

Re: [PATCH 22/23] video: omapfb: dss: Make use of the helper component_compare_dev

2022-02-15 Thread Helge Deller
On 2/14/22 07:08, Yong Wu wrote: > Use the common compare helper from component. > > Cc: Helge Deller > Cc: linux-o...@vger.kernel.org > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Yong Wu Applied to the fbdev for-next branch. Thanks! Helge > drivers/video/fbdev/omap2/omapfb/dss/dss.c |

Re: [PATCH 0/3] video: fbdev: atari: Miscellaneous fixes

2022-02-15 Thread Helge Deller
Hi Geert, On 2/15/22 12:21, Geert Uytterhoeven wrote: > This is a small series of miscellaneous fixes for the Atari frame buffer > device driver. > > The first patch has been sent before, and is untested, as I have no > access to the hardware. > The other patches have been tested on ARAnyM. > >

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Abhinav Kumar
On 2/15/2022 10:42 AM, Dmitry Baryshkov wrote: On Tue, 15 Feb 2022 at 20:42, Abhinav Kumar wrote: On 2/15/2022 9:28 AM, Bjorn Andersson wrote: On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: On 2/14/2022 8:33 PM, Bjorn Andersson wrote: From: Rob Clark Add SC8180x to the hardware

Re: [PATCH] drm: fb-helper: Avoid nesting spinlock_t into raw_spinlock_t

2022-02-15 Thread Jiri Kosina
On Tue, 15 Feb 2022, John Ogness wrote: > >> drm_fb_helper_damage() is acquiring spinlock_t (helper->damage_lock), > >> while it can be called from contexts where raw_spinlock_t is held (e.g. > >> console_owner lock obtained on vprintk_emit() codepath). > >> > >> As the critical sections

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-15 Thread Jason Gunthorpe
On Tue, Feb 15, 2022 at 07:32:09PM +0100, Christoph Hellwig wrote: > On Tue, Feb 15, 2022 at 10:45:24AM -0400, Jason Gunthorpe wrote: > > > Do you know if DEVICE_GENERIC pages would end up as PageAnon()? My > > > assumption was that they would be part of a special mapping. > > > > We need to stop

Re: [Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2: Introduce format modifier for DG2 clear color

2022-02-15 Thread Juha-Pekka Heikkila
On 15.2.2022 20.24, Chery, Nanley G wrote: -Original Message- From: Juha-Pekka Heikkila Sent: Tuesday, February 15, 2022 9:32 AM To: Chery, Nanley G ; Nanley Chery ; C, Ramalingam Cc: intel-gfx ; Auld, Matthew ; dri-devel Subject: Re: [Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2:

Re: [PATCH][next] treewide: Replace zero-length arrays with flexible-array members

2022-02-15 Thread Gustavo A. R. Silva
On Tue, Feb 15, 2022 at 09:19:29PM +0200, Leon Romanovsky wrote: > On Tue, Feb 15, 2022 at 01:21:10PM -0600, Gustavo A. R. Silva wrote: > > On Tue, Feb 15, 2022 at 10:17:40AM -0800, Kees Cook wrote: > > > On Tue, Feb 15, 2022 at 11:47:43AM -0600, Gustavo A. R. Silva wrote: > > > > > > These all

Re: [PATCH][next] treewide: Replace zero-length arrays with flexible-array members

2022-02-15 Thread Leon Romanovsky
On Tue, Feb 15, 2022 at 01:21:10PM -0600, Gustavo A. R. Silva wrote: > On Tue, Feb 15, 2022 at 10:17:40AM -0800, Kees Cook wrote: > > On Tue, Feb 15, 2022 at 11:47:43AM -0600, Gustavo A. R. Silva wrote: > > > There is a regular need in the kernel to provide a way to declare > > > having a

Re: [PATCH][next] treewide: Replace zero-length arrays with flexible-array members

2022-02-15 Thread Gustavo A. R. Silva
On Tue, Feb 15, 2022 at 10:17:40AM -0800, Kees Cook wrote: > On Tue, Feb 15, 2022 at 11:47:43AM -0600, Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare > > having a dynamically sized set of trailing elements in a structure. > > Kernel code should

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-15 Thread Limonciello, Mario
On 2/15/2022 01:29, Lukas Wunner wrote: On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +- drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +-

Re: [PATCH 2/6] drm/ttm: add resource iterator v3

2022-02-15 Thread Felix Kuehling
On 2022-02-15 12:22, Christian König wrote: Instead of duplicating that at different places add an iterator over all the resources in a resource manager. v2: add lockdep annotation and kerneldoc v3: fix various bugs pointed out by Felix Signed-off-by: Christian König Tested-by: Bas

Re: [PATCH v1 1/1] drm/i915/selftests: Replace too verbose for-loop with simpler while

2022-02-15 Thread Andy Shevchenko
On Tue, Feb 15, 2022 at 07:14:49PM +0200, Jani Nikula wrote: > On Tue, 15 Feb 2022, Andy Shevchenko > wrote: > > It's hard to parse for-loop which has some magic calculations inside. > > Much cleaner to use while-loop directly. > > I assume you're trying to prove a point following our recent >

Re: [PATCH v2] drm/i915: fix build issue when using clang

2022-02-15 Thread Nathan Chancellor
On Mon, Feb 14, 2022 at 11:58:20AM -0800, Tong Zhang wrote: > drm/i915 adds some extra cflags, namely -Wall, which causes > instances of -Wformat-security to appear when building with clang, even > though this warning is turned off kernel-wide in the main Makefile: > > >

Re: [PATCH v6 01/10] mm: add zone device coherent type memory support

2022-02-15 Thread Felix Kuehling
On 2022-02-15 07:15, David Hildenbrand wrote: On 11.02.22 17:56, Jason Gunthorpe wrote: On Fri, Feb 11, 2022 at 05:49:08PM +0100, David Hildenbrand wrote: On 11.02.22 17:45, Jason Gunthorpe wrote: On Fri, Feb 11, 2022 at 05:15:25PM +0100, David Hildenbrand wrote: ... I'm pretty sure we

Re: [PATCH v4 2/2] drm/msm/dp: enable widebus feature for display port

2022-02-15 Thread Dmitry Baryshkov
On 15/02/2022 21:39, Kuogee Hsieh wrote: On 2/15/2022 10:30 AM, Dmitry Baryshkov wrote: On Tue, 15 Feb 2022 at 20:49, Kuogee Hsieh wrote: On 2/15/2022 5:34 AM, Dmitry Baryshkov wrote: On 15/02/2022 01:39, Kuogee Hsieh wrote: Widebus feature will transmit two pixel data per pixel clock to

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Dmitry Baryshkov
On Tue, 15 Feb 2022 at 20:42, Abhinav Kumar wrote: > On 2/15/2022 9:28 AM, Bjorn Andersson wrote: > > On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: > > > >> > >> > >> On 2/14/2022 8:33 PM, Bjorn Andersson wrote: > >>> From: Rob Clark > >>> > >>> Add SC8180x to the hardware catalog, for

Re: [PATCH v4 2/2] drm/msm/dp: enable widebus feature for display port

2022-02-15 Thread Kuogee Hsieh
On 2/15/2022 10:30 AM, Dmitry Baryshkov wrote: On Tue, 15 Feb 2022 at 20:49, Kuogee Hsieh wrote: On 2/15/2022 5:34 AM, Dmitry Baryshkov wrote: On 15/02/2022 01:39, Kuogee Hsieh wrote: Widebus feature will transmit two pixel data per pixel clock to interface. This feature now is required

Re: [PATCH v4 2/2] drm/msm/dp: enable widebus feature for display port

2022-02-15 Thread Dmitry Baryshkov
On Tue, 15 Feb 2022 at 20:49, Kuogee Hsieh wrote: > > > On 2/15/2022 5:34 AM, Dmitry Baryshkov wrote: > > On 15/02/2022 01:39, Kuogee Hsieh wrote: > >> Widebus feature will transmit two pixel data per pixel clock to > >> interface. > >> This feature now is required to be enabled to easy migrant

RE: [Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2: Introduce format modifier for DG2 clear color

2022-02-15 Thread Chery, Nanley G
> -Original Message- > From: Juha-Pekka Heikkila > Sent: Tuesday, February 15, 2022 9:32 AM > To: Chery, Nanley G ; Nanley Chery > ; C, Ramalingam > Cc: intel-gfx ; Auld, Matthew > ; dri-devel > Subject: Re: [Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2: Introduce format > modifier for

Re: [PATCH][next] treewide: Replace zero-length arrays with flexible-array members

2022-02-15 Thread Kees Cook
On Tue, Feb 15, 2022 at 11:47:43AM -0600, Gustavo A. R. Silva wrote: > There is a regular need in the kernel to provide a way to declare > having a dynamically sized set of trailing elements in a structure. > Kernel code should always use “flexible array members”[1] for these > cases. The older

Re: [PATCH v2 1/8] drm/msm/dpu: fix dp audio condition

2022-02-15 Thread Abhinav Kumar
On 2/15/2022 6:16 AM, Dmitry Baryshkov wrote: DP audio enablement code which is comparing intf_type, DRM_MODE_ENCODER_TMDS (= 2) with DRM_MODE_CONNECTOR_DisplayPort (= 10). Which would never succeed. Fix it to check for DRM_MODE_ENCODER_TMDS. Fixes: d13e36d7d222 ("drm/msm/dp: add audio

Re: [PATCH v2 8/8] drm/msm/dpu: simplify intf allocation code

2022-02-15 Thread Abhinav Kumar
On 2/15/2022 6:16 AM, Dmitry Baryshkov wrote: Rather than passing DRM_MODE_ENCODER_* and letting dpu_encoder to guess, which intf type we mean, pass INTF_DSI/INTF_DP directly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 26 +++--

Re: [PATCH v4 2/2] drm/msm/dp: enable widebus feature for display port

2022-02-15 Thread Kuogee Hsieh
On 2/15/2022 5:34 AM, Dmitry Baryshkov wrote: On 15/02/2022 01:39, Kuogee Hsieh wrote: Widebus feature will transmit two pixel data per pixel clock to interface. This feature now is required to be enabled to easy migrant to higher resolution applications in future. However since some legacy

Re: [PATCH v2 00/12] iio: buffer-dma: write() and new DMABUF based API

2022-02-15 Thread Paul Cercueil
Hi Jonathan, Le dim., févr. 13 2022 at 18:46:16 +, Jonathan Cameron a écrit : On Mon, 7 Feb 2022 12:59:21 + Paul Cercueil wrote: Hi Jonathan, This is the V2 of my patchset that introduces a new userspace interface based on DMABUF objects to complement the fileio API, and adds

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Abhinav Kumar
On 2/15/2022 9:28 AM, Bjorn Andersson wrote: On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: On 2/14/2022 8:33 PM, Bjorn Andersson wrote: From: Rob Clark Add SC8180x to the hardware catalog, for initial support for the platform. Due to limitations in the DP driver only one of the

Re: [PATCH v4 2/2] drm/msm/dp: enable widebus feature for display port

2022-02-15 Thread Kuogee Hsieh
On 2/14/2022 8:22 PM, Bjorn Andersson wrote: On Mon 14 Feb 16:39 CST 2022, Kuogee Hsieh wrote: Widebus feature will transmit two pixel data per pixel clock to interface. This feature now is required to be enabled to easy migrant to higher resolution applications in future. However since some

[PATCH][next] treewide: Replace zero-length arrays with flexible-array members

2022-02-15 Thread Gustavo A. R. Silva
There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should no longer be used[2]. This

Re: [PATCH v6 25/35] iommu/mediatek: Migrate to aggregate driver

2022-02-15 Thread Krzysztof Kozlowski
On 10/02/2022 12:03, Yong Wu wrote: > On Thu, 2022-01-27 at 12:01 -0800, Stephen Boyd wrote: >> Use an aggregate driver instead of component ops so that we can get >> proper driver probe ordering of the aggregate device with respect to >> all >> the component devices that make up the aggregate

Re: [Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2: Introduce format modifier for DG2 clear color

2022-02-15 Thread Juha-Pekka Heikkila
On 15.2.2022 18.44, Chery, Nanley G wrote: -Original Message- From: Juha-Pekka Heikkila Sent: Tuesday, February 15, 2022 8:15 AM To: Chery, Nanley G ; Nanley Chery ; C, Ramalingam Cc: intel-gfx ; Auld, Matthew ; dri-devel Subject: Re: [Intel-gfx] [PATCH v5 16/19] uapi/drm/dg2:

Re: [PATCH v2 2/2] drm/msm/dpu: Add SC8180x to hw catalog

2022-02-15 Thread Bjorn Andersson
On Tue 15 Feb 11:14 CST 2022, Abhinav Kumar wrote: > > > On 2/14/2022 8:33 PM, Bjorn Andersson wrote: > > From: Rob Clark > > > > Add SC8180x to the hardware catalog, for initial support for the > > platform. Due to limitations in the DP driver only one of the four DP > > interfaces is left

[PATCH 2/6] drm/ttm: add resource iterator v3

2022-02-15 Thread Christian König
Instead of duplicating that at different places add an iterator over all the resources in a resource manager. v2: add lockdep annotation and kerneldoc v3: fix various bugs pointed out by Felix Signed-off-by: Christian König Tested-by: Bas Nieuwenhuizen Reviewed-by: Daniel Vetter (v3) ---

  1   2   >