[PATCH] drm/scheduler: quieten kernel-doc warnings

2022-04-03 Thread Randy Dunlap
Fix kernel-doc warnings in gpu_scheduler.h and sched_main.c. Quashes these warnings: include/drm/gpu_scheduler.h:316: warning: Function parameter or member 'work' not described in 'drm_sched_job' include/drm/gpu_scheduler.h:332: warning: missing initial short description on line: * struct

Re: [PATCH 16/23] dma-buf: add enum dma_resv_usage v3

2022-04-03 Thread Bas Nieuwenhuizen
On Mon, Mar 21, 2022 at 2:59 PM Christian König wrote: > > This change adds the dma_resv_usage enum and allows us to specify why a > dma_resv object is queried for its containing fences. > > Additional to that a dma_resv_usage_rw() helper function is added to aid > retrieving the fences for a

[PATCH] drm/format_helper: fix a kernel-doc typo

2022-04-03 Thread Randy Dunlap
It looks like the incorrect name of a function parameter was used in the kernel-doc notation, so just change it to the function's parameter name to quell the kernel-doc warning. drivers/gpu/drm/drm_format_helper.c:640: warning: Function parameter or member 'vaddr' not described in

[PATCH v2] drm: drm/drm_file.h: fix a kernel-doc typo

2022-04-03 Thread Randy Dunlap
Fix a build warning from 'make htmldocs' by correcting the lock name in the kernel-doc comment. include/drm/drm_file.h:369: warning: Function parameter or member 'master_lookup_lock' not described in 'drm_file' Signed-off-by: Randy Dunlap Cc: David Airlie Cc: Daniel Vetter Cc:

[PATCH] gpu: host1x: fix a kernel-doc warning

2022-04-03 Thread Randy Dunlap
Add @cache description to eliminate a kernel-doc warning. include/linux/host1x.h:104: warning: Function parameter or member 'cache' not described in 'host1x_client' Fixes: 1f39b1dfa53c ("drm/tegra: Implement buffer object cache") Signed-off-by: Randy Dunlap Cc: Thierry Reding Cc:

RE: [WARNING] [AMDGPU] Linux 5.16.18 warning about ttm_bo_release with R7 360

2022-04-03 Thread Chris Rankin
Ah yes, here it is: https://lore.kernel.org/lkml/CAK2bqVJo8TZUwu4-5VcY0MEezM7gJJq77prMpCB=fda24fe...@mail.gmail.com/ It looks like this warning started with the 5.14.x kernels. Cheers, Chris

[WARNING] [AMDGPU] Linux 5.16.18 warning about ttm_bo_release with R7 360

2022-04-03 Thread Chris Rankin
Hi, I have resurrected my old AMD R7 360 card (Bonnaire?) for a machine that needed an upgrade, and now notice this warning in the dmesg log, soon after logging into X. (In fact, this warning looks rather familiar. I suspect I was already reporting it up until I removed this R7 360 from my own

Re: [PATCH 17/23] dma-buf: specify usage while adding fences to dma_resv obj v5

2022-04-03 Thread Christian König
Am 03.04.22 um 00:16 schrieb Bas Nieuwenhuizen: On Mon, Mar 21, 2022 at 2:59 PM Christian König wrote: [SNIP] @@ -519,17 +513,17 @@ EXPORT_SYMBOL_GPL(dma_resv_iter_first); */ struct dma_fence *dma_resv_iter_next(struct dma_resv_iter *cursor) { - unsigned int idx; + struct

[PATCH] drm: bridge: icn6211: Convert to regmap

2022-04-03 Thread Marek Vasut
To make debugging easier, convert driver to regmap. Implement read and write regmap tables for known registers, keep all known register readable and mark those which are obviously read-only as not writeable. Use common I2C regmap for the I2C configuration, implement custom regmap bus for DSI

Re: [PATCH 06/23] drm/nouveau: stop using dma_resv_excl_fence

2022-04-03 Thread Christian König
Just a gentle ping to the nouveau guys. Any more comments on this? Otherwise I'm pushing that with Daniels rb. Thanks, Christian. Am 21.03.22 um 14:58 schrieb Christian König: Instead use the new dma_resv_get_singleton function. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Cc:

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-03 Thread Zheyu Ma
On Sun, Apr 3, 2022, 23:02 Helge Deller wrote: > On 4/3/22 13:26, Zheyu Ma wrote: > > Hi, > > > > I found a bug in the function i740fb_set_par(). > > Nice catch! > > > When the user calls the ioctl system call without setting the value to > > 'var->pixclock', the driver will throw a divide

Re: [PATCH] drm/radeon: change si_default_state table from global to static

2022-04-03 Thread Christian König
Am 02.04.22 um 18:27 schrieb Tom Rix: Smatch reports these issues si_blit_shaders.c:31:11: warning: symbol 'si_default_state' was not declared. Should it be static? si_blit_shaders.c:253:11: warning: symbol 'si_default_size' was not declared. Should it be static? Both symbols are only

[PATCH] drm/bridge: fix it6505 Kconfig terms

2022-04-03 Thread Randy Dunlap
Fix around 50 undefined references when DRM_ITE_IT6505=y while DRM_DP_AUX_BUS=m and DRM_DP_HELPER=m. Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver") Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: Allen Chen Cc: Robert Foss Cc: Hermes Wu Cc: AngeloGioacchino Del Regno

Re: [PATCH] drivers/dma-buf: dma-buf.c: fix a typo

2022-04-03 Thread Christian König
Am 02.04.22 um 15:44 schrieb Sui Jingfeng: Signed-off-by: Sui Jingfeng <15330273...@189.cn> Reviewed-by: Christian König and pushed to drm-misc-next. Thanks, Christian. --- drivers/dma-buf/dma-buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH next v2] dma-buf/sync-file: do not allow zero size allocation

2022-04-03 Thread Christian König
Am 01.04.22 um 23:31 schrieb Pavel Skripkin: num_fences is user-controlled value and it can be equal to 0. Code should not pass 0 to kcalloc(), since it will cause kcalloc() to return ZERO_PTR. ZERO_PTR will pass `!fences` check and kernel will panic because of dereferencing ZERO_PTR in

Re: [BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-03 Thread Helge Deller
On 4/3/22 13:26, Zheyu Ma wrote: > Hi, > > I found a bug in the function i740fb_set_par(). Nice catch! > When the user calls the ioctl system call without setting the value to > 'var->pixclock', the driver will throw a divide error. > > This bug occurs because the driver uses the value of

[PATCH] drm/amd/display: cleanup extern usage in function definition

2022-04-03 Thread Tom Rix
Smatch reports this issue hdcp1_execution.c:500:29: warning: function 'mod_hdcp_hdcp1_dp_execution' with external linkage has definition The storage-class-specifier extern is not needed in a definition, so remove it. Signed-off-by: Tom Rix ---

AMDGPU: regression on 5.17.1

2022-04-03 Thread Michele Ballabio
Hi, I've hit a regression on 5.17.1 (haven't tested 5.17.0, but 5.16-stable didn't have this problem). The machine is a Ryzen 5 1600 with AMD graphics (RX 560). The regression I hit seems to trigger when the machine is left idle at boot (I don't boot straight to X, I boot to a tty, login

Re: [PATCH] drm/bridge: Fix error handling in analogix_dp_probe

2022-04-03 Thread kernel test robot
' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Miaoqian-Lin/drm-bridge-Fix-error-handling-in-analogix_dp_probe/20220403-131916 base: git://anongit.freedesktop.org/drm/drm drm-next config: x86_64-randconfig-m001 (https://download.01.org

[BUG] fbdev: i740fb: Divide error when ‘var->pixclock’ is zero

2022-04-03 Thread Zheyu Ma
Hi, I found a bug in the function i740fb_set_par(). When the user calls the ioctl system call without setting the value to 'var->pixclock', the driver will throw a divide error. This bug occurs because the driver uses the value of 'var->pixclock' without checking it, as the following code