Re: [PATCH v1 08/12] drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup

2022-09-17 Thread Chun-Kuang Hu
Hi, Sam: Sam Ravnborg 於 2022年7月18日 週一 凌晨1:58寫道: > > The implementation of drm_bridge_funcs.mode_fixup is optional > so there is no need to provide an empty implementation. > Drop mtk_hdmi_bridge_mode_fixup() so the driver no longer uses the > deprecated drm_bridge_funcs.mode_fixup() operation.

Re: [PATCH v1 03/12] drm/mediatek: Drop chain_mode_fixup call in mode_valid()

2022-09-17 Thread Chun-Kuang Hu
Hi, Sam: Sam Ravnborg 於 2022年7月18日 週一 凌晨1:45寫道: > > The mode_valid implementation had a call to > drm_bridge_chain_mode_fixup() which would be wrong as the mode_valid is > not allowed to change anything - only to validate the mode. > > As the next bridge is often/always a connector the call had

Re: [PATCH v2] drm: mediatek: Fix display vblank timeout when disable dsi

2022-09-17 Thread Chun-Kuang Hu
Hi, Allen: Allen-KH Cheng 於 2022年9月14日 週三 晚上10:00寫道: > > From: Xinlei Lee > > Dsi is turned off at bridge.disable, causing crtc to wait for vblank > timeout. It is necessary to add count protection to turn off dsi and > turn off at post_disable. If turn off dsi in post_disable(), you should

Re: [PATCH -next] drm/mediatek: dp: change mtk_dp_driver to static

2022-09-17 Thread Chun-Kuang Hu
Hi, Dmity: My tree has no mtk dp driver yet. Would you like to pick this patch? Acked-by: Chun-Kuang Hu Dmitry Osipenko 於 2022年9月15日 週四 下午5:04寫道: > > On 9/13/22 16:49, Yang Yingliang wrote: > > mtk_dp_driver is only used in mtk_dp.c now, change it > > to static. > > > > Fixes: f70ac097a2cf

[PATCH v3 4/4] drm/panel: clockworkpi-cwd686: Implement .get_orientation callback

2022-09-17 Thread Max Fierke
Returns the panel's configured orientation Signed-off-by: Max Fierke --- Changes in v3: - no changes Changes in v2: - this was added as .get_orientation is now available in drm-misc-next since v1 drivers/gpu/drm/panel/panel-clockworkpi-cwd686.c | 13 - 1 file changed, 12

[PATCH v3 3/4] drm: panel: Add driver for ClockworkPi cwd686 panel

2022-09-17 Thread Max Fierke
The ClockworkPi DevTerm (all models) uses a 6.86" IPS display of unknown provenance, which uses the Chipone ICNL9707 IC driver. The display panel I have has two model numbers: TXW686001 and WTL068601G, but cannot find any manufacturer associated with either, so opting for the ClockworkPi model

[PATCH v3 2/4] dt-bindings: display: Add ClockworkPi CWD686 panel

2022-09-17 Thread Max Fierke
The CWD686 is a 6.86" IPS LCD panel used as the primary display in the ClockworkPi DevTerm portable (all cores) Signed-off-by: Max Fierke Reviewed-by: Krzysztof Kozlowski --- Changes in v3 (Krzysztof Kozlowski's Suggestions) - add missing lines for spacing Changes in v2 (Krzysztof Kozlowski

[PATCH v3 0/4] Introduce ClockworkPi CWD686 DRM panel driver

2022-09-17 Thread Max Fierke
The ClockworkPi DevTerm (all models) uses a 6.86" IPS display of unknown provenance, which uses the Chipone ICNL9707 IC driver[1]. The display panel I have has two model numbers: TXW686001 and WTL068601G, but cannot find any manufacturer associated with either, so opting for the ClockworkPi model

[PATCH v3 1/4] dt-bindings: vendor-prefixes: Add prefix for ClockworkPi

2022-09-17 Thread Max Fierke
Add a prefix for Clockwork Tech LLC, known as ClockworkPi. They produce a number of hobbyist devices, including the ClockworkPi DevTerm and GameShell. Signed-off-by: Max Fierke Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2

Re: [PATCH v2 0/3] Refactor MediaTek DP drivers

2022-09-17 Thread Chun-Kuang Hu
Hi, Dmitry: My tree has no mtk-dp driver yet. Would you like to pick this series? Regards, Chun-Kuang. Bo-Chen Chen 於 2022年9月16日 週五 晚上9:38寫道: > > For this series, we do some clean-up and fix a build warning. > This series is based on linux-next-20220915. > > Changes for v2: > 1. Update commit

Re: [PATCH v2 2/3] drm/mediatek: dp: Remove unused register definitions

2022-09-17 Thread Chun-Kuang Hu
Hi, Bo-Chen: Bo-Chen Chen 於 2022年9月16日 週五 晚上9:38寫道: > > Some definitions in mtk_dp_reg.h are not used, so remove these > redundant codes. Acked-by: Chun-Kuang Hu > > Signed-off-by: Bo-Chen Chen > Reviewed-by: AngeloGioacchino Del Regno > > Reviewed-by: Matthias Brugger > --- >

Re: [PATCH v2 3/3] drm/mediatek: dp: Fix warning in mtk_dp_video_mute()

2022-09-17 Thread Chun-Kuang Hu
Hi, Bo-Chen: Bo-Chen Chen 於 2022年9月16日 週五 晚上9:38寫道: > > Warning: > ../drivers/gpu/drm/mediatek/mtk_dp.c: In function ‘mtk_dp_video_mute’: > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:23: warning: format ‘%x’ > expects argument of type ‘unsigned int’, but argument 4 has type ‘long > unsigned int’

Re: [PATCH v2 1/3] drm/mediatek: dp: Reduce indentation in mtk_dp_bdg_detect()

2022-09-17 Thread Chun-Kuang Hu
Bo-Chen Chen 於 2022年9月16日 週五 晚上9:38寫道: > > In order to improve human readability, reduce the indentation by > returning early if the dp/edp cable is not plugged in. Acked-by: Chun-Kuang Hu > > Signed-off-by: Bo-Chen Chen > --- > drivers/gpu/drm/mediatek/mtk_dp.c | 66

Re: [PATCH v10 2/9] overflow: Move and add few utility macros into overflow

2022-09-17 Thread kernel test robot
Hi Gwan-gyeong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v6.0-rc5] [cannot apply to drm-intel/for-linux-next kees/for-next/hardening next-20220916] [If your patch is applied to the wrong git tree,

Re: [PATCH v2 3/5] drm/gma500: Use backlight_get_brightness() to get the brightness

2022-09-17 Thread Sam Ravnborg
Hi Hans, On Sat, Sep 17, 2022 at 11:00:55PM +0200, Hans de Goede wrote: > Hi, > > On 9/17/22 22:46, Sam Ravnborg wrote: > > On Sat, Sep 17, 2022 at 04:03:50PM +0200, Hans de Goede wrote: > >> Use backlight_get_brightness() instead of directly referencing > >> bd->props.brightness. This will take

Re: [PATCH v2 3/5] drm/gma500: Use backlight_get_brightness() to get the brightness

2022-09-17 Thread Hans de Goede
Hi, On 9/17/22 22:46, Sam Ravnborg wrote: > On Sat, Sep 17, 2022 at 04:03:50PM +0200, Hans de Goede wrote: >> Use backlight_get_brightness() instead of directly referencing >> bd->props.brightness. This will take backlight_is_blank() into account, >> properly setting brightness to 0 when

[PATCH v3 3/5] drm/gma500: Use backlight_get_brightness() to get the brightness

2022-09-17 Thread Hans de Goede
Use backlight_get_brightness() instead of directly referencing bd->props.brightness. This will take backlight_is_blank() into account, properly setting brightness to 0 when screen-blanking has been requested through the backlight sysfs interface. Suggested-by: Sam Ravnborg Acked-by: Sam Ravnborg

[PATCH v3 4/5] drm/gma500: Don't register backlight when another backlight should be used

2022-09-17 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

[PATCH v3 5/5] drm/gma500: Call acpi_video_register_backlight()

2022-09-17 Thread Hans de Goede
On machines without an Intel video opregion the acpi_video driver immediately probes the ACPI video bus and used to also immediately register acpi_video# backlight devices when supported. Once the drm/kms driver then loaded later and possibly registered a native backlight device then the

[PATCH v3 2/5] drm/gma500: Change registered backlight device type to raw/native

2022-09-17 Thread Hans de Goede
Change the type for the registered backlight class device from platform to raw/native. The poulsbo/cedarview/oaktrail backlight support is using native GPU backlight control and as such the type should be raw (aka native) as is done by all the other native GPU backlight driver code. Note this

[PATCH v3 1/5] drm/gma500: Refactor backlight support (v2)

2022-09-17 Thread Hans de Goede
Refactor backlight support so that the gma_backlight_enable() / gma_backlight_disable() / gma_backlight_set() functions used by the Opregion handle will also work if no backlight_device gets registered. This is a preparation patch for not registering the gma500's own backlight device when

[PATCH v3 0/5] drm/gma500: Backlight handling changes

2022-09-17 Thread Hans de Goede
Hi All, Here is a patch-series changing gma500's backlight handling to match the changes done to the other major x86 GPU drivers in the just landed backlight detection refactor patch series: https://lore.kernel.org/dri-devel/261afe3d-7790-e945-adf6-a2c96c9b1...@redhat.com/ The main goal is here

Re: [PATCH v2 1/5] drm/gma500: Refactor backlight support

2022-09-17 Thread Hans de Goede
kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: > https://github.com/intel-lab-lkp/linux/commits/Hans-de-Goede/drm-gma500-Backlight-handling-c

Re: [PATCH v2 3/5] drm/gma500: Use backlight_get_brightness() to get the brightness

2022-09-17 Thread Sam Ravnborg
On Sat, Sep 17, 2022 at 04:03:50PM +0200, Hans de Goede wrote: > Use backlight_get_brightness() instead of directly referencing > bd->props.brightness. This will take backlight_is_blank() into account, > properly setting brightness to 0 when screen-blanking has been requested > through the

Re: drm: panel-orientation-quirks: Add quirk for Aya Neo Air

2022-09-17 Thread Maya Matuszczyk
Hey, sob., 17 wrz 2022 o 20:00 Hans de Goede napisał(a): > > Hi, > > On 8/25/22 21:19, Maccraft123 wrote: > > From: Maya Matuszczyk > > > > Yet another x86 gaming handheld. > > > > This one has many SKUs with quite a few of DMI strings, > > so let's just use a catchall, just as with Aya Neo

[PATCH] drm/amd/display: refactor CalculateWriteBackDelay to use vba_vars_st ptr

2022-09-17 Thread Tom Rix
Mimimize the function signature by passing a pointer and an index instead of passing several elements of the pointer. The dml2x,dml3x families uses the same algorithm. Remove the duplicates. Use dml20_ and dml30_ prefix to distinguish the two variants. Signed-off-by: Tom Rix ---

Re: drm: panel-orientation-quirks: Add quirk for Aya Neo Air

2022-09-17 Thread Hans de Goede
Hi, On 8/25/22 21:19, Maccraft123 wrote: > From: Maya Matuszczyk > > Yet another x86 gaming handheld. > > This one has many SKUs with quite a few of DMI strings, > so let's just use a catchall, just as with Aya Neo Next. > > Signed-off-by: Maya Matuszczyk Thanks, I have pushed this out to

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600

2022-09-17 Thread Maya Matuszczyk
Hello, sob., 17 wrz 2022 o 15:04 Hans de Goede napisał(a): > > Hi, > > On 8/3/22 20:24, Maccraft123 wrote: > > From: Maya Matuszczyk > > > > This device is another x86 gaming handheld, and as (hopefully) there is > > only one set of DMI IDs it's using DMI_EXACT_MATCH > > > > Signed-off-by: Maya

[drm-tip:drm-tip 3/6] drivers/gpu/drm/i915/i915_gem.c:886:1: error: conflicting types for 'i915_gem_object_ggtt_pin_ww'; have 'struct i915_vma *(struct drm_i915_gem_object *, struct i915_gem_ww_ctx *,

2022-09-17 Thread kernel test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: 989401d639a84cb706eafc23c37e030014bcf253 commit: 86ac35ffd55d4c2b8308276ab521b2b0afb486c0 [3/6] Merge remote-tracking branch 'drm-intel/drm-intel-next' into drm-tip config: x86_64-defconfig

Re: [PATCH v2 1/7] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-09-17 Thread Krzysztof Kozlowski
On 16/09/2022 21:00, Bjorn Andersson wrote: > From: Bjorn Andersson > > Add compatibles for the DisplayPort and Embedded DisplayPort blocks in > Qualcomm SDM845 and SC8280XP platforms. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson No need for quicinc SoB (unless you

Re: [Linaro-mm-sig] Re: [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on debug

2022-09-17 Thread Christian König
Am 17.09.22 um 08:17 schrieb Ville Syrjälä: On Thu, Sep 15, 2022 at 06:05:30PM +0200, Christian König wrote: Am 15.09.22 um 15:02 schrieb Yadav, Arvind: On 9/15/2022 5:37 PM, Christian König wrote: Is that sufficient to allow running a desktop on amdgpu with the extra check enabled? If yes

[PATCH v2 2/5] drm/gma500: Change registered backlight device type to raw/native

2022-09-17 Thread Hans de Goede
Change the type for the registered backlight class device from platform to raw/native. The poulsbo/cedarview/oaktrail backlight support is using native GPU backlight control and as such the type should be raw (aka native) as is done by all the other native GPU backlight driver code. Note this

[PATCH v2 3/5] drm/gma500: Use backlight_get_brightness() to get the brightness

2022-09-17 Thread Hans de Goede
Use backlight_get_brightness() instead of directly referencing bd->props.brightness. This will take backlight_is_blank() into account, properly setting brightness to 0 when screen-blanking has been requested through the backlight sysfs interface. Suggested-by: Sam Ravnborg Signed-off-by: Hans de

[PATCH v2 5/5] drm/gma500: Call acpi_video_register_backlight()

2022-09-17 Thread Hans de Goede
On machines without an Intel video opregion the acpi_video driver immediately probes the ACPI video bus and used to also immediately register acpi_video# backlight devices when supported. Once the drm/kms driver then loaded later and possibly registered a native backlight device then the

[PATCH v2 0/5] drm/gma500: Backlight handling changes

2022-09-17 Thread Hans de Goede
Hi All, Here is a patch-series changing gma500's backlight handling to match the changes done to the other major x86 GPU drivers in the just landed backlight detection refactor patch series: https://lore.kernel.org/dri-devel/261afe3d-7790-e945-adf6-a2c96c9b1...@redhat.com/ The main goal is here

[PATCH v2 4/5] drm/gma500: Don't register backlight when another backlight should be used

2022-09-17 Thread Hans de Goede
Before this commit when we want userspace to use the acpi_video backlight device we register both the GPU's native backlight device and acpi_video's firmware acpi_video# backlight device. This relies on userspace preferring firmware type backlight devices over native ones. Registering 2 backlight

[PATCH v2 1/5] drm/gma500: Refactor backlight support

2022-09-17 Thread Hans de Goede
Refactor backlight support so that the gma_backlight_enable() / gma_backlight_disable() / gma_backlight_set() functions used by the Opregion handle will also work if no backlight_device gets registered. This is a preparation patch for not registering the gma500's own backlight device when

Re: mainline build failure (new) for x86_64 allmodconfig with clang

2022-09-17 Thread Sudip Mukherjee
Hi Nathan, On Sat, Sep 17, 2022 at 2:25 PM Nathan Chancellor wrote: > > Hi Sudip, > > On Sat, Sep 17, 2022 at 11:55:05AM +0100, Sudip Mukherjee (Codethink) wrote: > > Hi All, > > > > The latest mainline kernel branch fails to build for x86_64 allmodconfig > > with clang. The errors are: > > > >

Re: mainline build failure (new) for x86_64 allmodconfig with clang

2022-09-17 Thread Nathan Chancellor
Hi Sudip, On Sat, Sep 17, 2022 at 11:55:05AM +0100, Sudip Mukherjee (Codethink) wrote: > Hi All, > > The latest mainline kernel branch fails to build for x86_64 allmodconfig > with clang. The errors are: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.c:4020:6: >

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600

2022-09-17 Thread Hans de Goede
Hi, On 8/3/22 20:24, Maccraft123 wrote: > From: Maya Matuszczyk > > This device is another x86 gaming handheld, and as (hopefully) there is > only one set of DMI IDs it's using DMI_EXACT_MATCH > > Signed-off-by: Maya Matuszczyk Thanks I have added this patch to my local drm-misc-next branch.

Re: drm/vboxvideo: fix repeated words in comments

2022-09-17 Thread Hans de Goede
Hi, On 8/24/22 15:02, Jilin Yuan wrote: > Delete the redundant word 'the'. > > Signed-off-by: Jilin Yuan Thanks I have added this patch to my local drm-misc-next branch. I will push this out to the official drm-misc-next branch after running some local tests. Regards, Hans > --- >

Re: [PATCH 1/2] drm/amd/display: Reduce number of arguments of dml314's CalculateWatermarksAndDRAMSpeedChangeSupport()

2022-09-17 Thread Maíra Canal
Hi Nathan, On 9/16/22 18:06, Nathan Chancellor wrote: > Most of the arguments are identical between the two call sites and they > can be accessed through the 'struct vba_vars_st' pointer. This reduces > the total amount of stack space that > dml314_ModeSupportAndSystemConfigurationFull() uses by

Re: [PATCH 0/6] drm/gma500: 1 fix + further cleanups

2022-09-17 Thread Hans de Goede
Hi Patrik, On 9/14/22 09:50, Patrik Jakobsson wrote: > On Fri, Sep 9, 2022 at 1:56 PM Hans de Goede wrote: >> >> Hi Patrik, >> >> Here is another gma500 patch-series with one more bugfix and a bunch >> of other cleanups of stuff which I noticed while doing the previous >> set of bugfixes. >> >

mainline build failure (new) for x86_64 allmodconfig with clang

2022-09-17 Thread Sudip Mukherjee (Codethink)
Hi All, The latest mainline kernel branch fails to build for x86_64 allmodconfig with clang. The errors are: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/display_mode_vba_314.c:4020:6: error: stack frame size (2184) exceeds limit (2048) in 'dml314_ModeSupportAndSystemConfigurationFull'

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-17 Thread Zheng Hacker
Hi Greg, Sorry for that. I’ll write another one. Regards, Zheng Wang 在 2022年9月17日星期六,Greg KH 写道: > On Fri, Sep 16, 2022 at 11:54:42PM +0800, Zheng Hacker wrote: > > >From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 > > From: xmzyshypnc <1002992...@qq.com> > > Date: Fri,

Re: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry.

2022-09-17 Thread Greg KH
On Fri, Sep 16, 2022 at 11:54:42PM +0800, Zheng Hacker wrote: > >From afe79848cb74cc8e45ab426d13fa2394c87e0422 Mon Sep 17 00:00:00 2001 > From: xmzyshypnc <1002992...@qq.com> > Date: Fri, 16 Sep 2022 23:48:23 +0800 > Subject: [PATCH] drm/i915/gvt: fix double-free bug in split_2MB_gtt_entry > >

Re: [PATCH] drm/vmwgfx: Fix memory leak in vmw_mksstat_add_ioctl()

2022-09-17 Thread Martin Krastev (VMware)
Thank you for the catch! Reviewed-by: Martin Krastev Regards, Martin On 16.09.22 г. 23:47 ч., Rafael Mendonca wrote: If the copy of the description string from userspace fails, then the page for the instance descriptor doesn't get freed before returning -EFAULT, which leads to a memleak.

Re: [PATCH v4 0/6] dma-buf: Check status of enable-signaling bit on debug

2022-09-17 Thread Ville Syrjälä
On Thu, Sep 15, 2022 at 06:05:30PM +0200, Christian König wrote: > Am 15.09.22 um 15:02 schrieb Yadav, Arvind: > > > > On 9/15/2022 5:37 PM, Christian König wrote: > >> Is that sufficient to allow running a desktop on amdgpu with the > >> extra check enabled? If yes that would be quite a