Re: [PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Hector Martin
On 27/10/2022 19.13, Hector Martin wrote: > Until now, simpledrm unconditionally advertised all formats that can be > supported natively as conversions. However, we don't actually have a > full conversion matrix of helpers. Although the list is arguably > provided to userspace in precedence order,

[PATCH] docs/sphinx: More depth in the rtd sidebar toc

2022-10-27 Thread Daniel Vetter
We love to nest our documenation for good structure, but that means the table of contents needs to keep up or you can't navigate them. Realized this trying to find the drm property documentation, which with some shuffling around disappeared. Why I didn't realize we can do this earlier, no idea.

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-27 Thread Hans de Goede
Hi, On 10/27/22 11:52, Matthew Garrett wrote: > On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede wrote: > >> The *only* behavior which actually is new in 6.1 is the native GPU >> drivers now doing the equivalent of: >> >> if (acpi_video_get_backlight_type() != acpi_backlight_native)

Re: [PATCH v1 1/2] dma-buf: Make locking consistent in dma_buf_detach()

2022-10-27 Thread Dmitry Osipenko
On 10/27/22 09:13, Christian König wrote: > Am 27.10.22 um 00:46 schrieb Dmitry Osipenko: >> The dma_buf_detach() locks attach->dmabuf->resv and then unlocks >> dmabuf->resv, which could be a two different locks from a static >> code checker perspective. In particular this triggers Smatch to >>

[PATCH] drm/simpledrm: Only advertise formats that are supported

2022-10-27 Thread Hector Martin
Until now, simpledrm unconditionally advertised all formats that can be supported natively as conversions. However, we don't actually have a full conversion matrix of helpers. Although the list is arguably provided to userspace in precedence order, userspace can pick something out-of-order (and

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marek Vasut
On 10/27/22 07:45, Liu Ying wrote: Hi, [...] diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index a5302006c02cd..aee7babb5fa5c 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -341,6 +341,18 @@ static void

[PULL] drm-misc-fixes

2022-10-27 Thread Maarten Lankhorst
drm-misc-fixes-2022-10-27: drm-misc-fixes for v6.1-rc3: - Fix HPD on bridge/ps8640. - Stop leaking fences when killing a sched entity. - Avoid uninitialized read in aperture_remove_conflicting_pci_device() The following changes since commit 247f34f7b80357943234f93f247a1ae6b6c3a740: Linux

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-27 Thread Matthew Garrett
On Thu, Oct 27, 2022 at 11:39:38AM +0200, Hans de Goede wrote: > The *only* behavior which actually is new in 6.1 is the native GPU > drivers now doing the equivalent of: > > if (acpi_video_get_backlight_type() != acpi_backlight_native) > return; > > In their backlight

Re: [PATCH v3] drm/ttm: rework on ttm_resource to use size_t type

2022-10-27 Thread Christian König
Am 27.10.22 um 11:12 schrieb Somalapuram Amaranath: Change ttm_resource structure from num_pages to size_t size in bytes. v1 -> v2: change PFN_UP(dst_mem->size) to ttm->num_pages v1 -> v2: change bo->resource->size to bo->base.size at some places v1 -> v2: remove the local variable v1 -> v2:

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-27 Thread Hans de Goede
Hi Matthew, On 10/27/22 11:11, Matthew Garrett wrote: > On Thu, Oct 27, 2022 at 10:51:45AM +0200, Hans de Goede wrote: > >> In their backlight register paths and this has been present since >> circa 2015. >> >> So both before and after my 6.1 refactor vendor is only preferred >> on devices which

Re: [PATCH v6 16/23] drm/probe-helper: Provide a TV get_modes helper

2022-10-27 Thread Maxime Ripard
Hi Mateusz, On Thu, Oct 27, 2022 at 12:02:24AM +0200, Mateusz Kwiatkowski wrote: > First of all, nice idea with the helper function that can be reused by > different drivers. This is neat! Yeah, it looked to me that given how complex it is, we don't want to duplicate it in each and every driver.

Re: [PATCH v3 2/7] drm/ivpu: Add Intel VPU MMU support

2022-10-27 Thread Jacek Lawrynowicz
Hi, Thanks for an in-depth review. My responses are inline. On 10/26/2022 2:12 AM, Jeffrey Hugo wrote: > On 9/24/2022 9:11 AM, Jacek Lawrynowicz wrote: >> VPU Memory Management Unit is based on ARM MMU-600. >> It allows to create multiple virtual address spaces for the device and > > "It allows

[PATCH v3] drm/ttm: rework on ttm_resource to use size_t type

2022-10-27 Thread Somalapuram Amaranath
Change ttm_resource structure from num_pages to size_t size in bytes. v1 -> v2: change PFN_UP(dst_mem->size) to ttm->num_pages v1 -> v2: change bo->resource->size to bo->base.size at some places v1 -> v2: remove the local variable v1 -> v2: cleanup cmp_size_smaller_first() v2 -> v3: adding missing

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-27 Thread Matthew Garrett
On Thu, Oct 27, 2022 at 10:51:45AM +0200, Hans de Goede wrote: > In their backlight register paths and this has been present since > circa 2015. > > So both before and after my 6.1 refactor vendor is only preferred > on devices which don't implement the ACPI video bus control method. Sorry,

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marek Vasut
On 10/27/22 10:32, Marco Felsch wrote: Hi, diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index a5302006c02cd..aee7babb5fa5c 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -341,6 +341,18 @@ static void

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread Christian König
Am 27.10.22 um 11:00 schrieb broler Liew: It's very nice of you-all to finger it out that it may crash when it is the last entity in the list.   Absolutely I made a mistake about that. But I still cannot understand why we need to restart the selection from the list head when the current entity

Re: [PATCH] drm/i915: stop abusing swiotlb_max_segment

2022-10-27 Thread Tvrtko Ursulin
On 20/10/2022 12:03, Christoph Hellwig wrote: From: Robert Beckett swiotlb_max_segment used to return either the maximum size that swiotlb could bounce, or for Xen PV PAGE_SIZE even if swiotlb could bounce buffer larger mappings. This made i915 on Xen PV work as it bypasses the coherency

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread broler Liew
It's very nice of you-all to finger it out that it may crash when it is the last entity in the list. Absolutely I made a mistake about that. But I still cannot understand why we need to restart the selection from the list head when the current entity is removed from rq. In

Re: [PATCH] dma-buf: cma_heap: Fix typo in comment

2022-10-27 Thread AngeloGioacchino Del Regno
Il 27/10/22 09:26, Mark-PK Tsai ha scritto: Fix typo in comment. Signed-off-by: Mark-PK Tsai Reviewed-by: AngeloGioacchino Del Regno

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-27 Thread Hans de Goede
Hi, On 10/26/22 22:49, Matthew Garrett wrote: > On Wed, Oct 26, 2022 at 11:59:28AM +0200, Hans de Goede wrote: > >> Ok, so this is a local customization to what is already a custom BIOS >> for a custom motherboard. There is a lot of custom in that sentence and >> TBH at some point things might

[PATCH] drm: Include missing header

2022-10-27 Thread Bo Liu
The file drm_nomodeset.c missed the header drm_drv.h, which resulted on the following warning: drivers/gpu/drm/drm_nomodeset.c:8:6: warning: no previous prototype for 'drm_firmware_drivers_only' [-Wmissing-prototypes] Signed-off-by: Bo Liu --- drivers/gpu/drm/drm_nomodeset.c | 1 + 1 file

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marco Felsch
On 22-10-27, Marek Vasut wrote: > On 10/27/22 10:13, Marco Felsch wrote: > > Hi, > > [...] > > > > diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > b/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > index a5302006c02cd..aee7babb5fa5c 100644 > > > --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c > > > +++

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread Luben Tuikov
On 2022-10-27 04:19, Christian König wrote: > Am 27.10.22 um 10:07 schrieb Luben Tuikov: >> On 2022-10-27 03:01, Luben Tuikov wrote: >>> On 2022-10-25 13:50, Luben Tuikov wrote: Looking... Regards, Luben On 2022-10-25 09:35, Alex Deucher wrote: > + Luben >

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marek Vasut
On 10/27/22 10:13, Marco Felsch wrote: Hi, [...] diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c index a5302006c02cd..aee7babb5fa5c 100644 --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c @@ -341,6 +341,18 @@ static void

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread Christian König
Am 27.10.22 um 10:07 schrieb Luben Tuikov: On 2022-10-27 03:01, Luben Tuikov wrote: On 2022-10-25 13:50, Luben Tuikov wrote: Looking... Regards, Luben On 2022-10-25 09:35, Alex Deucher wrote: + Luben On Tue, Oct 25, 2022 at 2:55 AM brolerliew wrote: When entity move from one rq to

[PULL] drm-intel-fixes

2022-10-27 Thread Tvrtko Ursulin
Hi Dave, Daniel, Three fixes for the next release candidate: one display training fix, one new workaround and disabling of autosuspend for DG2 until things can get properly fixed. Regards, Tvrtko drm-intel-fixes-2022-10-27-1: - Extend Wa_1607297627 to Alderlake-P (José Roberto de Souza) - Keep

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-10-27 Thread Marco Felsch
On 22-10-27, Marek Vasut wrote: > On 10/27/22 10:04, Marco Felsch wrote: > > Hi Marek, > > Hi, > > > On 22-10-26, Marek Vasut wrote: > > > On 7/26/22 11:43, Marco Felsch wrote: > > > > FIFO underruns are seen if a AXI bus master with a higher priority do a > > > > lot of memory access. Increase

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-10-27 Thread Marek Vasut
On 10/27/22 10:04, Marco Felsch wrote: Hi Marek, Hi, On 22-10-26, Marek Vasut wrote: On 7/26/22 11:43, Marco Felsch wrote: FIFO underruns are seen if a AXI bus master with a higher priority do a lot of memory access. Increase the burst size to 256B to avoid such underruns and to improve

Re: [PATCH] drm: lcdif: Set and enable FIFO Panic threshold

2022-10-27 Thread Marco Felsch
Hi Marek, On 22-10-26, Marek Vasut wrote: > In case the LCDIFv3 is used to drive a 4k panel via i.MX8MP HDMI bridge, > the LCDIFv3 becomes susceptible to FIFO underflows, which lead to nasty > flicker of the image on the panel, or image being shifted by half frame > horizontally every second

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread Luben Tuikov
On 2022-10-27 03:01, Luben Tuikov wrote: > On 2022-10-25 13:50, Luben Tuikov wrote: >> Looking... >> >> Regards, >> Luben >> >> On 2022-10-25 09:35, Alex Deucher wrote: >>> + Luben >>> >>> On Tue, Oct 25, 2022 at 2:55 AM brolerliew wrote: When entity move from one rq to another,

Re: [PATCH v2] drm/lima: Fix opp clkname setting in case of missing regulator

2022-10-27 Thread Viresh Kumar
On 27-10-22, 09:32, Erico Nunes wrote: > Commit d8c32d3971e4 ("drm/lima: Migrate to dev_pm_opp_set_config()") > introduced a regression as it may undo the clk_names setting in case > the optional regulator is missing. This resulted in test and performance > regressions with lima. > > Restore the

Re: [PATCH] drm: lcdif: change burst size to 256B

2022-10-27 Thread Marco Felsch
Hi Marek, On 22-10-26, Marek Vasut wrote: > On 7/26/22 11:43, Marco Felsch wrote: > > FIFO underruns are seen if a AXI bus master with a higher priority do a > > lot of memory access. Increase the burst size to 256B to avoid such > > underruns and to improve the memory access efficiency. > > > >

Re: [PATCH] fbdev/core: Avoid uninitialized read in aperture_remove_conflicting_pci_device()

2022-10-27 Thread Thomas Zimmermann
Hi thanks for the patch. Added to drm-misc-fixes. Best regards Thomas Am 27.10.22 um 02:06 schrieb Michał Mirosław: Return on error directly from the BAR-iterating loop instead of break+return. This is actually a cosmetic fix, since it would be highly unusual to have this called for a PCI

Re: [PATCH] drm/bridge: it6505: Fix return value check for pm_runtime_get_sync

2022-10-27 Thread AngeloGioacchino Del Regno
Il 27/10/22 05:21, Pin-yen Lin ha scritto: `pm_runtime_get_sync` may return 1 on success. Fix the `if` statement here to make the code less confusing, even though additional calls to `it6505_poweron` doesn't break anything when it's already powered. This was reported by Dan Carpenter in

Re: [PATCH v1 2/2] drm/gem: Check whether object is NULL in drm_gem_vunmap()

2022-10-27 Thread Christian König
Am 27.10.22 um 09:28 schrieb Dan Carpenter: On Thu, Oct 27, 2022 at 08:17:31AM +0200, Christian König wrote: Am 27.10.22 um 00:46 schrieb Dmitry Osipenko: The drm_gem_vunmap() will crash with a NULL dereference if the passed object pointer is NULL. It wasn't a problem before we added the

[PULL] drm-misc-next

2022-10-27 Thread Maxime Ripard
Hi, Here's this week drm-misc-next PR Maxime drm-misc-next-2022-10-27: drm-misc-next for 6.2: UAPI Changes: Cross-subsystem Changes: Core Changes: - connector: Send hotplug event on cleanup - edid: logging/debug improvements - plane_helper: Improve tests Driver Changes: - bridge: -

[PATCH v2] drm/lima: Fix opp clkname setting in case of missing regulator

2022-10-27 Thread Erico Nunes
Commit d8c32d3971e4 ("drm/lima: Migrate to dev_pm_opp_set_config()") introduced a regression as it may undo the clk_names setting in case the optional regulator is missing. This resulted in test and performance regressions with lima. Restore the old behavior where clk_names is set separately so

Re: [PATCH v1 2/2] drm/gem: Check whether object is NULL in drm_gem_vunmap()

2022-10-27 Thread Dan Carpenter
On Thu, Oct 27, 2022 at 08:17:31AM +0200, Christian König wrote: > > > Am 27.10.22 um 00:46 schrieb Dmitry Osipenko: > > The drm_gem_vunmap() will crash with a NULL dereference if the passed > > object pointer is NULL. It wasn't a problem before we added the locking > > support to drm_gem_vunmap

Re: [PATCH] drm/arc: disambiguate Synopsys ARC in Kconfig labels

2022-10-27 Thread Alexey Brodkin
Hi Adam, > There's Intel Arc now which is what most folks will be looking for. > > Signed-off-by: Adam Borowski > --- > drivers/gpu/drm/tiny/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig > index

[PATCH] drm/tests: Add back seed value information

2022-10-27 Thread Arthur Grillo
As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they being refactored into kunit. This patch adds back this important information to assure reproducibility converting them to use the kunit api. Signed-off-by: Arthur Grillo Reported-by: Michał

Re: [PATCH] drm/scheduler: set current_entity to next when remove from rq

2022-10-27 Thread Luben Tuikov
On 2022-10-25 13:50, Luben Tuikov wrote: > Looking... > > Regards, > Luben > > On 2022-10-25 09:35, Alex Deucher wrote: >> + Luben >> >> On Tue, Oct 25, 2022 at 2:55 AM brolerliew wrote: >>> >>> When entity move from one rq to another, current_entity will be set to NULL >>> if it is the moving

[PATCH] MAINTAINERS: Update GPU Scheduler email

2022-10-27 Thread Luben Tuikov
Update GPU Scheduler maintainer email. Cc: Alex Deucher Cc: Christian König Cc: Daniel Vetter Cc: Dave Airlie Cc: AMD Graphics Cc: Direct Rendering Infrastructure - Development Signed-off-by: Luben Tuikov Acked-by: Christian König --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v1 2/2] drm/gem: Check whether object is NULL in drm_gem_vunmap()

2022-10-27 Thread Christian König
Am 27.10.22 um 00:46 schrieb Dmitry Osipenko: The drm_gem_vunmap() will crash with a NULL dereference if the passed object pointer is NULL. It wasn't a problem before we added the locking support to drm_gem_vunmap function because the mapping argument was always NULL together with the object.

Re: [PATCH v1 1/2] dma-buf: Make locking consistent in dma_buf_detach()

2022-10-27 Thread Christian König
Am 27.10.22 um 00:46 schrieb Dmitry Osipenko: The dma_buf_detach() locks attach->dmabuf->resv and then unlocks dmabuf->resv, which could be a two different locks from a static code checker perspective. In particular this triggers Smatch to report the "double unlock" error. Make the locking

Re: [PATCH 2/5] drm/amdgpu: stop resubmitting jobs for bare metal reset

2022-10-27 Thread Christian König
Hi Shaoyun, yes, absolutely. If you say that this is ok then I'm fine with that as well. Thanks, Christian. Am 26.10.22 um 20:13 schrieb Liu, Shaoyun: [AMD Official Use Only - General] The SRIOV already has its own reset routine amdgpu_device_reset_sriov, we try to put the sriov specific

<    1   2