[PATCH 1/1] drm: bridge: ldb: Warn if LDB clock does not match requested link frequency

2022-12-07 Thread Alexander Stein
The LDB clock needs to be exactly 7-times the pixel clock used by the display. Signed-off-by: Alexander Stein --- i.MX8MP has a dedicated LDB clock which defines the actual LVDS link frequency. This has to be (exactly) the 7-time of the pixel clock. Although the clock min/max range is available,

Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp

2022-12-07 Thread Alexander Stein
Hello Marek, Am Mittwoch, 7. Dezember 2022, 16:59:50 CET schrieb Marek Vasut: > On 12/7/22 16:13, Alexander Stein wrote: > > i.MX8MP uses 3 clocks, so soften the restrictions for clocks & > > clock-names. > > > > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") > >

Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain

2022-12-07 Thread Alexander Stein
Am Mittwoch, 7. Dezember 2022, 17:00:22 CET schrieb Marek Vasut: > On 12/7/22 16:14, Alexander Stein wrote: > > i.MX8MP requires a power-domain for this peripheral to use. Add it as > > an optional property. > > > > Signed-off-by: Alexander Stein > > --- > > > >

Re: [PATCH v2 2/6] drm/i915/gsc: Skip the version check when fetching the GSC FW

2022-12-07 Thread Teres Alexis, Alan Previn
On Mon, 2022-12-05 at 17:19 -0800, Ceraolo Spurio, Daniele wrote: > The current exectation from the FW side is that the driver will query > the GSC FW version after the FW is loaded, similarly to what the mei > driver does on DG2. However, we're discussing with the FW team if there > is a way to

[PATCH v11 1/1] drm/i915/pxp: Promote pxp subsystem to top-level of i915

2022-12-07 Thread Alan Previn
Starting with MTL, there will be two GT-tiles, a render and media tile. PXP as a service for supporting workloads with protected contexts and protected buffers can be subscribed by process workloads on any tile. However, depending on the platform, only one of the tiles is used for control events

Re: [PATCH v3 0/2] drm: Add GPU reset sysfs

2022-12-07 Thread Alex Deucher
On Wed, Nov 30, 2022 at 6:11 AM Daniel Vetter wrote: > > On Fri, Nov 25, 2022 at 02:52:01PM -0300, André Almeida wrote: > > This patchset adds a udev event for DRM device's resets. > > > > Userspace apps can trigger GPU resets by misuse of graphical APIs or driver > > bugs. Either way, the GPU

Re: [PATCH v2 1/6] drm/i915/uc: Introduce GSC FW

2022-12-07 Thread Teres Alexis, Alan Previn
On Mon, 2022-12-05 at 17:19 -0800, Ceraolo Spurio, Daniele wrote: > On MTL the GSC FW needs to be loaded on the media GT by the graphics > driver. We're going to treat it like a new uc_fw, so add the initial > defs and init/fini functions for it. > > Similarly to the other FWs, the GSC FW path

[PATCH] drm: mali-dp: Add check for kzalloc

2022-12-07 Thread Jiasheng Jiang
As kzalloc may fail and return NULL pointer, the "mw_state" can be NULL. If the layout of struct malidp_mw_connector_state ever changes, it will cause NULL poineter derefernce of "_state->base". Therefore, the "mw_state" should be checked whether it is NULL in order to improve the robust. Fixes:

[PATCH] drm: mali-dp: Add check for kzalloc

2022-12-07 Thread Jiasheng Jiang
As kzalloc may fail and return NULL pointer, the "mw_state" can be NULL. If the layout of struct malidp_mw_connector_state ever changes, it will cause NULL poineter derefernce of "_state->base". Therefore, the "mw_state" should be check whether it is NULL in order to improve the robust. Fixes:

Re: [PATCH] drm: mali-dp: Add check for kzalloc

2022-12-07 Thread Jiasheng Jiang
On Wed, Dec 07, 2022 at 09:59:04PM +0800, Robin Murphy wrote: >> As kzalloc may fail and return NULL pointer, it should be better to check >> the return value in order to avoid the NULL pointer dereference in >> __drm_atomic_helper_connector_reset. > > This commit message is nonsense; if >

[PATCH] drm: mali-dp: Add check for kzalloc

2022-12-07 Thread Jiasheng Jiang
As kzalloc may fail and return NULL pointer, the "mw_state" can be NULL. If the the layout of struct malidp_mw_connector_state ever changes, it will cause NULL poineter derefernce of "_state->base". Therefore, the "mw_state" should be check whether it is NULL in order to improve the robust.

[PATCH v2 4/4] arm64: dts: qcom: add SoC specific compat strings to mdp5 nodes

2022-12-07 Thread Dmitry Baryshkov
Add SoC-specific compat string to the MDP5 device nodes to ease distinguishing between various platforms. Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- arch/arm64/boot/dts/qcom/sdm630.dtsi | 2 +-

[PATCH v2 2/4] dt-bindings: display/msm: add SoC-specific compats to qcom, mdp5.yaml

2022-12-07 Thread Dmitry Baryshkov
Add platform-specific compatible entries to the qcom,mdp5.yaml to allow distinguishing between various platforms. Signed-off-by: Dmitry Baryshkov --- .../bindings/display/msm/qcom,mdp5.yaml | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git

[PATCH v2 3/4] ARM: dts: qcom-msm8974: add SoC specific compat string to mdp5 node

2022-12-07 Thread Dmitry Baryshkov
Add SoC-specific compat string to the MDP5 device node to ease distinguishing between various platforms. Signed-off-by: Dmitry Baryshkov --- arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi

[PATCH v2 1/4] dt-bindings: display/msm: convert MDP5 schema to YAML format

2022-12-07 Thread Dmitry Baryshkov
Convert the mdp5.txt into the yaml format. Changes to the existing (txt) schema: - MSM8996 has additional "iommu" clock, define it separately - Add new properties used on some of platforms: - interconnects, interconnect-names - iommus - power-domains - operating-points-v2, opp-table

[PATCH v2 0/4] dt-bindings: display/msm: convert MDP5 schema to YAML format

2022-12-07 Thread Dmitry Baryshkov
This patch concludes the conversion of display/msm schema from txt files to YAML format. The per-SoC compat (new addition) is required to ease migrating platform support between mdp5 and dpu drivers. Changes since v1: - Renamed mdp@ to display-controller@ in the example (Krzysztof) - Extended

[RFC PATCH 3/4] drm/msm/mdss: add data for sc8180xp

2022-12-07 Thread Dmitry Baryshkov
Add platform data for sc8180xp based on sdmshrike-sde.dtsi. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index

[RFC PATCH 2/4] drm/msm/mdss: correct the ubwc version for sm6115 platform

2022-12-07 Thread Dmitry Baryshkov
According to the vendor DT, sm6115 has UBWC 1.0, not 2.0. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 2219c1bd59a9..4401f945b966

[RFC PATCH 1/4] drm/msm/mdss: convert UBWC setup to use match data

2022-12-07 Thread Dmitry Baryshkov
To simplify adding new platforms and to make settings more obvious, rewrite the UBWC setup to use the data structure to pass platform config rather than just calling the functions direcly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 158 -

[RFC PATCH 4/4] drm/msm/mdss: add the sdm845 data for completeness

2022-12-07 Thread Dmitry Baryshkov
Add the platform data for sdm845 platform. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/msm_mdss.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c index 5e19ec897670..b2c6e8b12469 100644 ---

[RFC PATCH 0/4] drm/msm/mdss: rework UBWC setup

2022-12-07 Thread Dmitry Baryshkov
The commit 92bab9142456 ("drm/msm: less magic numbers in msm_mdss_enable") reworked the static UBWC setup to replace magic numbers with calulating written values from the SoC/device parameters. This simplified adding new platforms. However I did not estimate that the values would still be cryptic

Re: [PATCH v3 05/11] drm/msm: Add support for SM8350

2022-12-07 Thread Dmitry Baryshkov
On 05/12/2022 18:37, Robert Foss wrote: Add compatibles string, "qcom,sm8350-mdss", for the multimedia display subsystem unit used on Qualcomm SM8350 platform. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/msm_mdss.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH v3 04/11] drm/msm/dpu: Add support for SM8350

2022-12-07 Thread Abhinav Kumar
On 12/5/2022 8:37 AM, Robert Foss wrote: Add compatibles string, "qcom,sm8350-dpu", for the display processing unit used on Qualcomm SM8350 platform. Signed-off-by: Robert Foss Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + 1 file changed, 1

Re: [PATCH v3 03/11] drm/msm/dpu: Add SM8350 to hw catalog

2022-12-07 Thread Abhinav Kumar
On 12/5/2022 8:37 AM, Robert Foss wrote: Add compatibility for SM8350 display subsystem, including required entries in DPU hw catalog. Signed-off-by: Robert Foss --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 196 ++ .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h|

Re: [PATCH v3 04/11] drm/msm/dpu: Add support for SM8350

2022-12-07 Thread Dmitry Baryshkov
On 05/12/2022 18:37, Robert Foss wrote: Add compatibles string, "qcom,sm8350-dpu", for the display processing unit used on Qualcomm SM8350 platform. Signed-off-by: Robert Foss --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Dmitry Baryshkov

Re: [PATCH v3 03/11] drm/msm/dpu: Add SM8350 to hw catalog

2022-12-07 Thread Dmitry Baryshkov
On 05/12/2022 18:37, Robert Foss wrote: Add compatibility for SM8350 display subsystem, including required entries in DPU hw catalog. Signed-off-by: Robert Foss Reviewed-by: Dmitry Baryshkov Minor nit below. --- .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c| 196 ++

Re: [PATCH v5 02/12] drm/msm/dpu: Introduce SC8280XP

2022-12-07 Thread Dmitry Baryshkov
On 08/12/2022 00:00, Bjorn Andersson wrote: From: Bjorn Andersson The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9 interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the necessary definitions and describe the DPU in the SC8280XP. Signed-off-by: Bjorn Andersson

[pull] amdgpu drm-next-6.2

2022-12-07 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.2. The following changes since commit 4670ac706ff9b3d0adb766ef9e93cc36d9dda474: drm/amdgpu: expand on GPUVM documentation (2022-12-02 10:06:00 -0500) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH v10 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-07 Thread Rob Herring
On Wed, 07 Dec 2022 08:57:55 -0800, Kuogee Hsieh wrote: > Add both data-lanes and link-frequencies property into endpoint > > Changes in v7: > -- split yaml out of dtsi patch > -- link-frequencies from link rate to symbol rate > -- deprecation of old data-lanes property > > Changes in v8: > --

[pull] amdgpu drm-fixes-6.1

2022-12-07 Thread Alex Deucher
Hi Dave, Daniel, A couple of small fixes for 6.1. The following changes since commit 76dcd734eca23168cb008912c0f69ff408905235: Linux 6.1-rc8 (2022-12-04 14:48:12 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

[PATCH v5 08/12] drm/msm/dp: Rely on hpd_enable/disable callbacks

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson The DisplayPort controller's internal HPD interrupt handling is used for cases where the HPD signal is connected to a GPIO which is pinmuxed into the DisplayPort controller. In other configurations the HPD notification might be delivered by the DRM framework from an

[PATCH v5 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson The SA8295P ADP has, among other interfaces, six MiniDP connectors which are connected to MDSS0 DP2 and DP3, and MDSS1 DP0 through DP3. Enable Display Clock controllers, MDSS instanced, MDPs, DP controllers, DP PHYs and link them all together. Signed-off-by: Bjorn

[PATCH v5 09/12] drm/msm/dp: Implement hpd_notify()

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson The DisplayPort controller's hot-plug mechanism is based on pinmuxing a physical signal on a GPIO pin into the controller. This is not always possible, either because there aren't dedicated GPIOs available or because the hot-plug signal is a virtual notification, in cases

[PATCH v5 07/12] drm/msm/dp: Add SDM845 DisplayPort instance

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson The Qualcomm SDM845 platform has a single DisplayPort controller, with the same design as SC7180, so add support for this by reusing the SC7180 definition. Signed-off-by: Bjorn Andersson Reviewed-by: Dmitry Baryshkov Signed-off-by: Bjorn Andersson --- Changes since v4:

[PATCH v5 04/12] dt-bindings: msm/dp: Add SDM845 and SC8280XP compatibles

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson Add compatibles for the DisplayPort and Embedded DisplayPort blocks in Qualcomm SDM845 and SC8280XP platforms. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson Acked-by: Krzysztof Kozlowski --- Changes since v4: - None

[PATCH v5 05/12] drm/msm/dp: Stop using DP id as index in desc

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson In the SC8280XP platform there are two identical MDSS instances, each with the same set of DisplayPort instances, at different addresses. By not relying on the index to define the instance id it's possible to describe them both in the same table and hence have a single

[PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson The SC8280XP CRD has a EDP display on MDSS0 DP3, enable relevant nodes and link it together with the backlight control. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes since v4: - None arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 72

[PATCH v5 06/12] drm/msm/dp: Add DP and EDP compatibles for SC8280XP

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson The SC8280XP platform has four DisplayPort controllers, per MDSS instance, all with widebus support. The first two are defined to be DisplayPort only, while the latter pair (of each instance) can be either DisplayPort or Embedded DisplayPort. The two sets are tied to the

[PATCH v5 02/12] drm/msm/dpu: Introduce SC8280XP

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9 interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the necessary definitions and describe the DPU in the SC8280XP. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes

[PATCH v5 03/12] drm/msm: Introduce SC8280XP MDSS

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson Add compatible for the SC8280XP Mobile Display Subsystem and initialization for version 8.0.0. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson Reviewed-by: Dmitry Baryshkov --- Changes since v4: - None drivers/gpu/drm/msm/msm_mdss.c | 4 1 file

[PATCH v5 01/12] dt-bindings: display/msm: Add binding for SC8280XP MDSS

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson Add binding for the display subsystem and display processing unit in the Qualcomm SC8280XP platform. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson Reviewed-by: Rob Herring --- Changes since v4: - None .../display/msm/qcom,sc8280xp-dpu.yaml|

[PATCH v5 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks

2022-12-07 Thread Bjorn Andersson
From: Bjorn Andersson Define the display clock controllers, the MDSS instances, the DP phys and connect these together. Signed-off-by: Bjorn Andersson Signed-off-by: Bjorn Andersson --- Changes since v4: - None arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 838 + 1 file

[PATCH v5 00/12] drm/msm: Add SC8280XP support

2022-12-07 Thread Bjorn Andersson
This introduces support for the SC8280XP platform in the MDSS, DPU and DP driver. It reworks the HDP handling in the DP driver to support external HPD sources - such as the dp-connector, or USB Type-C altmode. It then introduces the display clock controllers, mdss, dpu and displayport controllers

Re: [PATCH] drm/vmwgfx: Remove rcu locks from user resources

2022-12-07 Thread "Maaz Mombasawala (VMware)
LGTM. Reviewed-by: Maaz Mombasawala On 12/7/22 09:29, Zack Rusin wrote: > From: Zack Rusin > > User resource lookups used rcu to avoid two extra atomics. Unfortunately > the rcu paths were buggy and it was easy to make the driver crash by > submitting command buffers from two different

Re: [PATCH v10 4/5] drm/msm/dp: parser link-frequencies as property of dp_out endpoint

2022-12-07 Thread Dmitry Baryshkov
On 07/12/2022 18:57, Kuogee Hsieh wrote: Add capability to parser and retrieve max DP link supported rate from link-frequencies property of dp_out endpoint. Changes in v6: -- second patch after split parser patch into two patches Changes in v7: -- without checking cnt against

Re: [PATCH v10 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-07 Thread Dmitry Baryshkov
On 07/12/2022 18:57, Kuogee Hsieh wrote: Add both data-lanes and link-frequencies property into endpoint Changes in v7: -- split yaml out of dtsi patch -- link-frequencies from link rate to symbol rate -- deprecation of old data-lanes property Changes in v8: -- correct Bjorn mail address to

Re: [PATCH v4 02/13] drm/msm/dpu: Introduce SC8280XP

2022-12-07 Thread Dmitry Baryshkov
On 07/12/2022 18:28, Bjorn Andersson wrote: On Wed, Dec 07, 2022 at 04:49:07PM +0200, Dmitry Baryshkov wrote: On 05/12/2022 19:44, Bjorn Andersson wrote: diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c [..] +static const struct

[PATCH] drm/gud: Fix missing include

2022-12-07 Thread Noralf Trønnes via B4 Submission Endpoint
gud_pipe.c b/drivers/gpu/drm/gud/gud_pipe.c index 62c43d3632d4..dc16a92625d4 100644 --- a/drivers/gpu/drm/gud/gud_pipe.c +++ b/drivers/gpu/drm/gud/gud_pipe.c @@ -5,6 +5,7 @@ #include #include +#include #include #include --- base-commit: 5ad8e63ebba3d5a0730b43180b200e41eeb9409c change-id

Re: [PATCH] drm: mali-dp: Add check for kzalloc

2022-12-07 Thread Robin Murphy
On 2022-12-07 15:29, Liviu Dudau wrote: On Wed, Dec 07, 2022 at 01:59:04PM +, Robin Murphy wrote: On 2022-12-07 09:21, Jiasheng Jiang wrote: As kzalloc may fail and return NULL pointer, it should be better to check the return value in order to avoid the NULL pointer dereference in

Re: [PATCH] drm/vmwgfx: Remove rcu locks from user resources

2022-12-07 Thread Martin Krastev (VMware)
From: Martin Krastev Looks good! Reviewed-by: Martin Krastev Regards, Martin On 7.12.22 г. 19:29 ч., Zack Rusin wrote: From: Zack Rusin User resource lookups used rcu to avoid two extra atomics. Unfortunately the rcu paths were buggy and it was easy to make the driver crash by

Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain

2022-12-07 Thread Rob Herring
On Wed, 07 Dec 2022 16:14:00 +0100, Alexander Stein wrote: > i.MX8MP requires a power-domain for this peripheral to use. Add it as > an optional property. > > Signed-off-by: Alexander Stein > --- > Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++ > 1 file changed, 3

Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp

2022-12-07 Thread Rob Herring
On Wed, 07 Dec 2022 16:13:59 +0100, Alexander Stein wrote: > i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. > > Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") > Signed-off-by: Alexander Stein > --- >

[PATCH] drm/vmwgfx: Remove rcu locks from user resources

2022-12-07 Thread Zack Rusin
From: Zack Rusin User resource lookups used rcu to avoid two extra atomics. Unfortunately the rcu paths were buggy and it was easy to make the driver crash by submitting command buffers from two different threads. Because the lookups never show up in performance profiles replace them with a

Re: [PATCH] drm: Add orientation quirk for DynaBook K50

2022-12-07 Thread Hans de Goede
Hi, On 11/30/22 18:08, Allen Ballway wrote: > Like the ASUS T100HAN for which there is already a quirk, > the DynaBook K50 has a 800x1280 portrait screen mounted > in the tablet part of a landscape oriented 2-in-1. > Update the quirk to be more generic and apply to this device. > >

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Tab 3 X90F

2022-12-07 Thread Hans de Goede
Hi, On 11/30/22 08:43, Javier Martinez Canillas wrote: > Hello Hans, > > On 11/27/22 19:15, Hans de Goede wrote: >> The Lenovo Yoga Tab 3 X90F has a portrait 1600x2560 LCD used in >> landscape mode, add a quirk for this. >> >> Signed-off-by: Hans de Goede >> --- > > Looks good to me. > >

[PATCH v10 3/5] drm/msm/dp: parser data-lanes as property of dp_out endpoint

2022-12-07 Thread Kuogee Hsieh
Add capability to parser data-lanes as property of dp_out endpoint. Also retain the original capability to parser data-lanes as property of mdss_dp node to handle legacy case. Changes in v6: -- first patch after split parser patch into two Changes in v7: -- check "data-lanes" from endpoint first

[PATCH v10 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

2022-12-07 Thread Kuogee Hsieh
Add both data-lanes and link-frequencies property into endpoint Changes in v7: -- split yaml out of dtsi patch -- link-frequencies from link rate to symbol rate -- deprecation of old data-lanes property Changes in v8: -- correct Bjorn mail address to kernel.org Changes in v10: -- add menu item

[PATCH v10 5/5] drm/msm/dp: add support of max dp link rate

2022-12-07 Thread Kuogee Hsieh
By default, HBR2 (5.4G) is the max link link be supported. This patch uses the actual limit specified by DT and removes the artificial limitation to 5.4 Gbps. Supporting HBR3 is a consequence of that. Changes in v2: -- add max link rate from dtsi Changes in v3: -- parser max_data_lanes and

[PATCH v10 4/5] drm/msm/dp: parser link-frequencies as property of dp_out endpoint

2022-12-07 Thread Kuogee Hsieh
Add capability to parser and retrieve max DP link supported rate from link-frequencies property of dp_out endpoint. Changes in v6: -- second patch after split parser patch into two patches Changes in v7: -- without checking cnt against DP_MAX_NUM_DP_LANES to retrieve link rate Changes in v9: --

[PATCH v10 1/5] arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint

2022-12-07 Thread Kuogee Hsieh
Move data-lanes property from mdss_dp node to dp_out endpoint. Also add link-frequencies property into dp_out endpoint as well. The last frequency specified at link-frequencies will be the max link rate supported by DP. Changes in v5: -- revert changes at sc7180.dtsi and sc7280.dtsi -- add _out

[PATCH v10 0/5] Add data-lanes and link-frequencies to dp_out endpoint

2022-12-07 Thread Kuogee Hsieh
Add DP both data-lanes and link-frequencies property to dp_out endpoint and support functions to DP driver. Kuogee Hsieh (5): arm64: dts: qcom: add data-lanes and link-freuencies into dp_out endpoint dt-bindings: msm/dp: add data-lanes and link-frequencies property drm/msm/dp: parser

Re: [PATCH v7 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

2022-12-07 Thread Bjorn Andersson
On Wed, Dec 07, 2022 at 05:00:51PM +0100, Ulf Hansson wrote: > On Thu, 1 Dec 2022 at 23:57, Bjorn Andersson wrote: > > > > On Wed, Oct 05, 2022 at 02:36:58PM +0530, Akhil P Oommen wrote: > > > > > > > @Ulf, Akhil has a power-domain for a piece of hardware which may be > > voted active by multiple

Re: [PATCH] drm/i915/gsc: GSC firmware loading

2022-12-07 Thread Ceraolo Spurio, Daniele
On 12/7/2022 2:16 AM, Teres Alexis, Alan Previn wrote: Diffed the patches and reviewed the changes -- i.e. the use of the worker for the gsc fw loading cmd submission. All looks good - just a few nits below. Reviewed-by: Alan Previn On Mon, 2022-12-05 at 21:15 -0800, Ceraolo Spurio,

[linux-next:master] BUILD REGRESSION 591cd61541b9b95401e17dca24be486e32104cb8

2022-12-07 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 591cd61541b9b95401e17dca24be486e32104cb8 Add linux-next specific files for 20221207 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211090634.ryfkk0ws-...@intel.com https

Re: [PATCH v4 02/13] drm/msm/dpu: Introduce SC8280XP

2022-12-07 Thread Bjorn Andersson
On Wed, Dec 07, 2022 at 04:49:07PM +0200, Dmitry Baryshkov wrote: > On 05/12/2022 19:44, Bjorn Andersson wrote: > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c > > b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c [..] > > +static const struct dpu_mdp_cfg sc8280xp_mdp[] = { > > +

Re: [PATCH v3 18/20] drm/vc4: tests: Fail the current test if we access a register

2022-12-07 Thread Maxime Ripard
Hi Maíra, Thanks for your review! On Wed, Dec 07, 2022 at 11:26:13AM -0300, Maíra Canal wrote: > On 12/1/22 12:11, Maxime Ripard wrote: > > Accessing a register when running under kunit is a bad idea since our > > device is completely mocked. > > > > Fail the current test if we ever access any

[PATCH 8/9] drm/vc4: hdmi: Add BT.601 Support

2022-12-07 Thread Maxime Ripard
From: Dave Stevenson Even though we report that we support the BT601 Colorspace, we were always using the BT.709 conversion matrices. Let's add the BT601 ones. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 38

[PATCH 9/9] drm/vc4: hdmi: Add BT.2020 Support

2022-12-07 Thread Maxime Ripard
From: Dave Stevenson Even though we report that we support the BT.2020 Colorspace, we were always using the BT.709 conversion matrices. Let's add the BT.2020 ones. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 38

[PATCH 7/9] drm/vc4: hdmi: Add a function to retrieve the CSC matrix

2022-12-07 Thread Maxime Ripard
From: Dave Stevenson The CSC matrix to use depends on the output format, its range and the colorspace. Since we're going to add more colorspaces, let's move the CSC matrix retrieval to a function. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c

[PATCH 4/9] drm/vc4: hdmi: Rename full range helper

2022-12-07 Thread Maxime Ripard
From: Dave Stevenson The VC4 HDMI driver has a helper function to figure out whether full range or limited range RGB is being used called vc4_hdmi_is_full_range_rgb(). We'll need it to support other colorspaces, so let's rename it to vc4_hdmi_is_full_range(). Signed-off-by: Dave Stevenson

[PATCH 3/9] drm/vc4: hdmi: Add Broadcast RGB property to allow override of RGB range

2022-12-07 Thread Maxime Ripard
From: Dave Stevenson Copy Intel's "Broadcast RGB" property semantics to add manual override of the HDMI pixel range for monitors that don't abide by the content of the AVI Infoframe. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 87

[PATCH 5/9] drm/vc4: hdmi: Rework the CSC matrices organization

2022-12-07 Thread Maxime Ripard
From: Dave Stevenson The CSC matrices were stored as separate matrix for each colorspace, and if we wanted a limited or full RGB output. This created some gaps in our support and we would not always pick the relevant matrix. Let's rework our data structure to store one per colorspace, and then

[PATCH 6/9] drm/vc4: hdmi: Swap CSC matrix channels for YUV444

2022-12-07 Thread Maxime Ripard
From: Dave Stevenson YUV444 requires the matrix coefficients to be programmed in a different way than the other formats. Let's add a function to program it properly. Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 17 - 1 file

[PATCH 2/9] drm/vc4: hdmi: Constify container_of wrappers

2022-12-07 Thread Maxime Ripard
None of our wrappers around container_of to access our objects from the DRM object pointer actually modify the latter. Let's make them const. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 0/9] drm/vc4: hdmi: Broadcast RGB, BT601, BT2020

2022-12-07 Thread Maxime Ripard
: Constify container_of wrappers drivers/gpu/drm/vc4/vc4_hdmi.c | 326 ++--- drivers/gpu/drm/vc4/vc4_hdmi.h | 21 ++- 2 files changed, 289 insertions(+), 58 deletions(-) --- base-commit: 99e2d98adc738597abcc5d38b03d0e9858db5c00 change-id: 20221207-rpi-hdmi

[PATCH 1/9] drm/vc4: hdmi: Update all the planes if the TV margins are changed

2022-12-07 Thread Maxime Ripard
On VC4, the TV margins on the HDMI connector are implemented by scaling the planes. However, if only the TV margins or the connector are changed by a new state, the planes ending up on that connector won't be. Thus, they won't be updated properly and we'll effectively ignore that change until the

Re: [PATCH v7 0/6] clk/qcom: Support gdsc collapse polling using 'reset' interface

2022-12-07 Thread Ulf Hansson
On Thu, 1 Dec 2022 at 23:57, Bjorn Andersson wrote: > > On Wed, Oct 05, 2022 at 02:36:58PM +0530, Akhil P Oommen wrote: > > > > @Ulf, Akhil has a power-domain for a piece of hardware which may be > voted active by multiple different subsystems (co-processors/execution > contexts) in the system. >

Re: [PATCH] drm/i915: Fix documentation for intel_uncore_forcewake_put__locked

2022-12-07 Thread Rodrigo Vivi
On Wed, Dec 07, 2022 at 03:29:09PM +0400, Miaoqian Lin wrote: > intel_uncore_forcewake_put__locked() is used to release a reference. > > Fixes: a6111f7b6604 ("drm/i915: Reduce locking in execlist command > submission") > Signed-off-by: Miaoqian Lin Reviewed-by: Rodrigo Vivi and will push

Re: [PATCH 2/2] dt-bindings: lcdif: Add optional power-domain

2022-12-07 Thread Marek Vasut
On 12/7/22 16:14, Alexander Stein wrote: i.MX8MP requires a power-domain for this peripheral to use. Add it as an optional property. Signed-off-by: Alexander Stein --- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp

2022-12-07 Thread Marek Vasut
On 12/7/22 16:13, Alexander Stein wrote: i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") Signed-off-by: Alexander Stein --- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- 1

Re: [Intel-gfx] [PATCH v2 26/26] drm/i915/gt: Remove #ifdef guards for PM related functions

2022-12-07 Thread Rodrigo Vivi
On Tue, Nov 29, 2022 at 07:19:42PM +, Paul Cercueil wrote: > Instead of defining two versions of intel_sysfs_rc6_init(), one for each > value of CONFIG_PM, add a check on !IS_ENABLED(CONFIG_PM) early in the > function. This will allow the compiler to automatically drop the dead > code when

Re: [PATCH v7 4/6] clk: qcom: gpucc-sc7280: Add cx collapse reset support

2022-12-07 Thread Ulf Hansson
On Wed, 5 Oct 2022 at 11:08, Akhil P Oommen wrote: > > Allow a consumer driver to poll for cx gdsc collapse through Reset > framework. Would you mind extending this commit message, to allow us to better understand what part is really the consumer part. I was expecting the consumer part to be

Re: [PATCH v7 3/6] clk: qcom: gdsc: Add a reset op to poll gdsc collapse

2022-12-07 Thread Ulf Hansson
On Wed, 5 Oct 2022 at 11:08, Akhil P Oommen wrote: > > Add a reset op compatible function to poll for gdsc collapse. This is > required because: > 1. We don't wait for it to turn OFF at hardware for VOTABLE GDSCs. > 2. There is no way for client drivers (eg. gpu driver) to do >

Re: [PATCH] drm/amdgpu: Retry DDC probing on DVI on failure if we got an HPD interrupt

2022-12-07 Thread kernel test robot
Hi xurui, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master v6.1-rc8 next-20221207] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH] drm: mali-dp: Add check for kzalloc

2022-12-07 Thread Liviu Dudau
On Wed, Dec 07, 2022 at 01:59:04PM +, Robin Murphy wrote: > On 2022-12-07 09:21, Jiasheng Jiang wrote: > > As kzalloc may fail and return NULL pointer, it should be better to check > > the return value in order to avoid the NULL pointer dereference in > > __drm_atomic_helper_connector_reset. >

[PATCH 2/2] dt-bindings: lcdif: Add optional power-domain

2022-12-07 Thread Alexander Stein
i.MX8MP requires a power-domain for this peripheral to use. Add it as an optional property. Signed-off-by: Alexander Stein --- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml

[PATCH 1/2] dt-bindings: lcdif: Fix clock constraints for imx8mp

2022-12-07 Thread Alexander Stein
i.MX8MP uses 3 clocks, so soften the restrictions for clocks & clock-names. Fixes: f5419cb0743f ("dt-bindings: lcdif: Add compatible for i.MX8MP") Signed-off-by: Alexander Stein --- Documentation/devicetree/bindings/display/fsl,lcdif.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH v4 2/3] drm/msm/disp/dpu1: add helper to know if display is builtin

2022-12-07 Thread Dmitry Baryshkov
On 21/11/2022 11:08, Kalyan Thota wrote: Since DRM encoder type for few encoders can be similar (like eDP and DP), get the connector type for a given encoder to differentiate between builtin and pluggable displays. Changes in v1: - add connector type in the disp_info (Dmitry) - add helper

Re: [PATCH v2] drm/msm/dpu: Fix memory leak in msm_mdss_parse_data_bus_icc_path

2022-12-07 Thread Doug Anderson
Hi, On Tue, Dec 6, 2022 at 10:59 PM Miaoqian Lin wrote: > > of_icc_get() alloc resources for path1, we should release it when not > need anymore. Early return when IS_ERR_OR_NULL(path0) may leak path1. > Defer getting path1 to fix this. > > Fixes: b9364eed9232 ("drm/msm/dpu: Move min BW request

Re: [PATCH v4 02/13] drm/msm/dpu: Introduce SC8280XP

2022-12-07 Thread Dmitry Baryshkov
On 05/12/2022 19:44, Bjorn Andersson wrote: From: Bjorn Andersson The Qualcomm SC8280XP platform contains DPU version 8.0.0, has 9 interfaces, 2 DSI controllers and 4 DisplayPort controllers. Extend the necessary definitions and describe the DPU in the SC8280XP. Signed-off-by: Bjorn Andersson

Re: [PATCH] drm/msm: Add MSM_SUBMIT_BO_NO_IMPLICIT

2022-12-07 Thread Rob Clark
On Wed, Dec 7, 2022 at 2:15 AM Lucas Stach wrote: > > Hi Rob, > > Am Dienstag, dem 06.12.2022 um 11:21 -0800 schrieb Rob Clark: > > From: Rob Clark > > > > In cases where implicit sync is used, it is still useful (for things > > like sub-allocation, etc) to allow userspace to opt-out of implicit

[PATCH 3/3] drm/msm/dpu: add missing ubwc_swizzle setting to catalog

2022-12-07 Thread Dmitry Baryshkov
Use the values from the vendor DTs to set ubwc_swizzle in the catalog. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c

[PATCH 2/3] drm/msm/dpu: correct the UBWC version on sm6115

2022-12-07 Thread Dmitry Baryshkov
According to downstream (bengal-sde.dtsi), the sm6115 uses UBWC 1.0. Change the catalog entry accordingly. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/3] drm/msm/dpu: handle UBWC 1.0 in dpu_hw_sspp_setup_format

2022-12-07 Thread Dmitry Baryshkov
Extend dpu_hw_sspp_setup_format() to also handle the UBWC 1.0 case. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c

[PATCH 0/3] drm/msm/dpu: several fixes for UBWC setup

2022-12-07 Thread Dmitry Baryshkov
Several small corrections for the UBWC setup and related data. Dmitry Baryshkov (3): drm/msm/dpu: handle UBWC 1.0 in dpu_hw_sspp_setup_format drm/msm/dpu: correct the UBWC version on sm6115 drm/msm/dpu: add missing ubwc_swizzle setting to catalog

Re: [PATCH v3 18/20] drm/vc4: tests: Fail the current test if we access a register

2022-12-07 Thread Maíra Canal
On 12/1/22 12:11, Maxime Ripard wrote: Accessing a register when running under kunit is a bad idea since our device is completely mocked. Fail the current test if we ever access any of our hardware registers. Reviewed-by: Javier Martinez Canillas Signed-off-by: Maxime Ripard Reviewed-by:

Re: [PATCH v3 19/20] drm/vc4: tests: Add unit test suite for the PV muxing

2022-12-07 Thread Maíra Canal
On 12/1/22 12:11, Maxime Ripard wrote: The HVS to PixelValve muxing code is fairly error prone and has a bunch of arbitrary constraints due to the hardware setup. Let's create a test suite that makes sure that the possible combinations work and the invalid ones don't. Reviewed-by: Javier

Re: [PATCH 019/606] drm/bridge: chrontel-ch7033: Convert to i2c's .probe_new()

2022-12-07 Thread Uwe Kleine-König
Hello dear drm/bridge maintainers, On Fri, Nov 18, 2022 at 11:35:53PM +0100, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König Do you plan to pick

Re: [PATCH v3 17/20] drm/vc4: tests: Introduce a mocking infrastructure

2022-12-07 Thread Maíra Canal
On 12/1/22 12:11, Maxime Ripard wrote: In order to test the current atomic_check hooks we need to have a DRM device that has roughly the same capabilities and layout that the actual hardware. We'll also need a bunch of functions to create arbitrary atomic states. Let's create some helpers to

Re: [v10] drm/msm/disp/dpu1: add support for dspp sub block flush in sc7280

2022-12-07 Thread Marijn Suijten
On 2022-12-07 04:59:23, Kalyan Thota wrote: > Flush mechanism for DSPP blocks has changed in sc7280 family, it > allows individual sub blocks to be flushed in coordination with > master flush control. > > Representation: master_flush && (PCC_flush | IGC_flush .. etc ) > > This change adds

  1   2   >