Re: [PATCH v3 2/4] mei: gsc_proxy: add gsc proxy driver

2023-05-03 Thread Teres Alexis, Alan Previn
We only had nits before and all sorted now, so.. Reviewed-by: Alan Previn On Tue, 2023-05-02 at 09:38 -0700, Ceraolo Spurio, Daniele wrote: > From: Alexander Usyskin > > Add GSC proxy driver. It to allows messaging between GSC component > on Intel graphics card and CSE device. > > Cc: Alan

Re: [RFC PATCH 04/10] drm/sched: Add generic scheduler message interface

2023-05-03 Thread Luben Tuikov
On 2023-04-03 20:22, Matthew Brost wrote: > Add generic schedule message interface which sends messages to backend > from the drm_gpu_scheduler main submission thread. The idea is some of > these messages modify some state in drm_sched_entity which is also > modified during submission. By

Re: [RFC PATCH 07/10] drm/sched: Add helper to set TDR timeout

2023-05-03 Thread Luben Tuikov
On 2023-04-03 20:22, Matthew Brost wrote: > Add helper to set TDR timeout and restart the TDR with new timeout > value. This will be used in XE, new Intel GPU driver, to trigger the TDR > to cleanup drm_sched_entity that encounter errors. > > Signed-off-by: Matthew Brost > --- >

Re: [PATCH v3 1/4] drm/i915/mtl: Define GSC Proxy component interface

2023-05-03 Thread Teres Alexis, Alan Previn
LGTM Reviewed-by: Alan Previn On Tue, 2023-05-02 at 09:38 -0700, Ceraolo Spurio, Daniele wrote: > From: Alexander Usyskin > > GSC Proxy component is used for communication between the > Intel graphics driver and MEI driver. > > Cc: Alan Previn > Signed-off-by: Alexander Usyskin >

Re: [RFC PATCH 06/10] drm/sched: Submit job before starting TDR

2023-05-03 Thread Luben Tuikov
On 2023-04-03 20:22, Matthew Brost wrote: > If the TDR is set to a value, it can fire before a job is submitted in > drm_sched_main. The job should be always be submitted before the TDR > fires, fix this ordering. > > Signed-off-by: Matthew Brost > --- > drivers/gpu/drm/scheduler/sched_main.c |

Re: drm/sched: Replacement for drm_sched_resubmit_jobs() is deprecated

2023-05-03 Thread Matthew Brost
On Wed, May 03, 2023 at 10:47:43AM +0200, Christian König wrote: > Adding Luben as well. > > Am 03.05.23 um 10:16 schrieb Boris Brezillon: > > [SNIP] > > > To sum-up, we shouldn't call drm_sched_{start,stop,resubmit_jobs}(). > > After the discussion I had with Matthew yesterday on IRC, I > >

Re: [PATCH v1] drm/mipi-dsi: Set the fwnode for mipi_dsi_device

2023-05-03 Thread Saravana Kannan
On Fri, Mar 17, 2023 at 3:36 PM Saravana Kannan wrote: > > On Sun, Mar 12, 2023 at 7:45 AM Martin Kepplinger > wrote: > > > > Am Donnerstag, dem 09.03.2023 um 22:39 -0800 schrieb Saravana Kannan: > > > After commit 3fb16866b51d ("driver core: fw_devlink: Make cycle > > > detection more robust"),

[pull] amdgpu drm-fixes-6.4

2023-05-03 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.4. The following changes since commit d893f39320e1248d1c97fde0d6e51e5ea008a76b: drm/amd/display: Lowering min Z8 residency time (2023-04-26 22:53:58 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git

Re: [PATCH v2] accel/habanalabs: Make use of rhashtable

2023-05-03 Thread Cai Huoqing
On 30 4月 23 09:36:29, Oded Gabbay wrote: > On Fri, Apr 28, 2023 at 5:49 PM Cai Huoqing wrote: > > > > Using rhashtable to accelerate the search for userptr by address, > > instead of using a list. > > > > Preferably, the lookup complexity of a hash table is O(1). > > > > This patch will speedup

Re: [PATCH v2 1/8] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2023-05-03 Thread Zack Rusin
On Wed, 2023-05-03 at 09:48 +0200, Javier Martinez Canillas wrote: > Zack Rusin writes: > > > On Tue, 2023-05-02 at 11:32 +0200, Javier Martinez Canillas wrote: > > > !! External Email > > > > > > Daniel Vetter writes: > > > > > > > On Mon, Jul 11, 2022 at 11:32:39PM -0400, Zack Rusin wrote:

Re: [PATCH v2 1/8] drm: Disable the cursor plane on atomic contexts with virtualized drivers

2023-05-03 Thread Zack Rusin
On Wed, 2023-05-03 at 10:54 +0300, Pekka Paalanen wrote: > On Wed, 3 May 2023 03:35:29 + > Zack Rusin wrote: > > > On Tue, 2023-05-02 at 11:32 +0200, Javier Martinez Canillas wrote: > > > !! External Email > > > > > > Daniel Vetter writes: > > >   > > > > On Mon, Jul 11, 2022 at

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-03 Thread Marek Olšák
On Wed, May 3, 2023, 14:53 André Almeida wrote: > Em 03/05/2023 14:08, Marek Olšák escreveu: > > GPU hangs are pretty common post-bringup. They are not common per user, > > but if we gather all hangs from all users, we can have lots and lots of > > them. > > > > GPU hangs are indeed not very

Re: [PATCH 4/4] drm/msm/dpu: Enable compression for command mode

2023-05-03 Thread Jessica Zhang
On 5/3/2023 4:00 PM, Marijn Suijten wrote: Hi Jessica, On 2023-05-03 12:04:59, Jessica Zhang wrote: On 5/3/2023 12:28 AM, Marijn Suijten wrote: On 2023-05-02 18:19:15, Jessica Zhang wrote: Add a dpu_hw_intf op to enable data compression. Signed-off-by: Jessica Zhang ---

Re: [PATCH v4 4/7] drm/msm/dpu: add PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-03 Thread Marijn Suijten
On 2023-05-03 13:10:36, Kuogee Hsieh wrote: > During DSC setup, the crossbar mux need to be programmed to engage > DSC to specified PINGPONG. Hence during tear down, the crossbar mux > need to be reset to disengage DSC from PINGPONG. 0X0F is written to > reset crossbar mux. It is not relevant to

Re: [PATCH 3/4] drm/msm/dpu: Add has_data_compress to dpu_caps

2023-05-03 Thread Jessica Zhang
On 5/3/2023 4:03 PM, Marijn Suijten wrote: Hi Jessica, On 2023-05-03 12:03:40, Jessica Zhang wrote: On 5/3/2023 12:07 AM, Marijn Suijten wrote: On 2023-05-02 18:19:14, Jessica Zhang wrote: Add data_compress feature to DPU HW catalog. In DPU 7.x and later, there is a DATA_COMPRESS

Re: [PATCH v4 2/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit

2023-05-03 Thread Marijn Suijten
Hi Kuogee, On 2023-05-03 13:10:34, Kuogee Hsieh wrote: > Legacy DPU (DPU < 7.0.0) requires PP block to be involved during Nit: I wouldn't call it "legacy" (that's not really relevant here), just DPU < 7.0.0 requires the PINGPONG block ... > DSC setting up. Since then, enable and start the

Re: [PATCH 4/4] drm/msm/dpu: Enable compression for command mode

2023-05-03 Thread Jessica Zhang
On 5/3/2023 12:51 PM, Dmitry Baryshkov wrote: On 03/05/2023 22:04, Jessica Zhang wrote: On 5/3/2023 12:28 AM, Marijn Suijten wrote: On 2023-05-02 18:19:15, Jessica Zhang wrote: Add a dpu_hw_intf op to enable data compression. Signed-off-by: Jessica Zhang ---  

[PATCH v11 1/2] MAINTAINERS: add maintainers for DRM LOONGSON driver

2023-05-03 Thread Sui Jingfeng
This patch add myself as maintainer to drm loongson driver Signed-off-by: Sui Jingfeng --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e9a3bf32fe28..4aa2e587f061 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6920,6 +6920,13 @@ T:

Re: [PATCH v4 0/7] add DSC 1.2 dpu supports

2023-05-03 Thread Marijn Suijten
On 2023-05-03 13:10:32, Kuogee Hsieh wrote: > This series adds the DPU side changes to support DSC 1.2 encoder. This > was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. > The DSI and DP parts will be pushed later on top of this change. > This seriel is rebase on [1], [2] and

Re: [PATCH 3/4] drm/msm/dpu: Add has_data_compress to dpu_caps

2023-05-03 Thread Marijn Suijten
Hi Jessica, On 2023-05-03 12:03:40, Jessica Zhang wrote: > > > On 5/3/2023 12:07 AM, Marijn Suijten wrote: > > On 2023-05-02 18:19:14, Jessica Zhang wrote: > >> Add data_compress feature to DPU HW catalog. > >> > >> In DPU 7.x and later, there is a DATA_COMPRESS register that must be set > >>

[PATCH v5 2/5] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread fei . yang
From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent,

[PATCH v5 3/5] drm/i915: make sure correct pte encode is used

2023-05-03 Thread fei . yang
From: Fei Yang PTE encode is platform dependent. After replacing cache_level with pat_index, the newly introduced mtl_pte_encode is actually generic for all gen12 platforms, thus rename it to gen12_pte_encode and apply it to all gen12 platforms. Cc: Chris Wilson Cc: Matt Roper Signed-off-by:

[PATCH v5 5/5] drm/i915: Allow user to set cache at BO creation

2023-05-03 Thread fei . yang
From: Fei Yang To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a

[PATCH v5 4/5] drm/i915/mtl: end support for set caching ioctl

2023-05-03 Thread fei . yang
From: Fei Yang The design is to keep Buffer Object's caching policy immutable through out its life cycle. This patch ends the support for set caching ioctl from MTL onward. While doing that we also set BO's to be 1-way coherent at creation time because GPU is no longer automatically snooping CPU

[PATCH v5 0/5] drm/i915: Allow user to set cache at BO creation

2023-05-03 Thread fei . yang
From: Fei Yang The first three patches in this series are taken from https://patchwork.freedesktop.org/series/116868/ These patches are included here because the last patch has dependency on the pat_index refactor. This series is focusing on uAPI changes, 1. end support for set caching ioctl

[PATCH v5 1/5] drm/i915: preparation for using PAT index

2023-05-03 Thread fei . yang
From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. Preparing the transition by

Re: [PATCH 4/4] drm/msm/dpu: Enable compression for command mode

2023-05-03 Thread Marijn Suijten
Hi Jessica, On 2023-05-03 12:04:59, Jessica Zhang wrote: > > > On 5/3/2023 12:28 AM, Marijn Suijten wrote: > > On 2023-05-02 18:19:15, Jessica Zhang wrote: > >> Add a dpu_hw_intf op to enable data compression. > >> > >> Signed-off-by: Jessica Zhang > >> --- > >>

[PATCH v5 2/3] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread fei . yang
From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum. In addition, the PAT index is platform dependent,

[PATCH v5 0/3] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread fei . yang
From: Fei Yang This patch set was posted at https://patchwork.freedesktop.org/series/116868/ Change title since the PTE patch was merged separately. These patches are extracted from series https://patchwork.freedesktop.org/series/115980/ This series refactor the cache policy programming so

[PATCH v5 1/3] drm/i915: preparation for using PAT index

2023-05-03 Thread fei . yang
From: Fei Yang This patch is a preparation for replacing enum i915_cache_level with PAT index. Caching policy for buffer objects is set through the PAT index in PTE, the old i915_cache_level is not sufficient to represent all caching modes supported by the hardware. Preparing the transition by

[PATCH v5 3/3] drm/i915: make sure correct pte encode is used

2023-05-03 Thread fei . yang
From: Fei Yang PTE encode is platform dependent. After replacing cache_level with pat_index, the newly introduced mtl_pte_encode is actually generic for all gen12 platforms, thus rename it to gen12_pte_encode and apply it to all gen12 platforms. Cc: Chris Wilson Cc: Matt Roper Signed-off-by:

Re: [PATCH 0/7] drm/msm/dpu: simplify DPU encoder init

2023-05-03 Thread Abhinav Kumar
On 4/30/2023 4:57 PM, Dmitry Baryshkov wrote: Rework dpu_encoder initialization code, simplifying calling sequences and separating common init parts. Please mention that your series was made on top of https://patchwork.freedesktop.org/series/116530/. Figured it out when I tried to apply

[PATCH] drm/msm/dpu: add writeback support for sc7280

2023-05-03 Thread Abhinav Kumar
Add writeback support for sc7280. This was validated with kms_writeback test case in IGT. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h

RE: [Intel-gfx] [PATCH v4 2/3] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread Yang, Fei
[...] >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c >> b/drivers/gpu/drm/i915/gem/i915_gem_object.c >> index 8c70a0ec7d2f..27c948350b5b 100644 >> --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c >> @@ -54,6 +54,25 @@ unsigned int

Re: [PATCH 01/11] drm/dp_mst: Fix fractional DSC bpp handling

2023-05-03 Thread Lyude Paul
Reviewed-by: Lyude Paul Thanks! On Tue, 2023-05-02 at 17:38 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The current code does '(bpp << 4) / 16' in the MST PBN > calculation, but that is just the same as 'bpp' so the > DSC codepath achieves absolutely nothing. Fix it up so that > the

Re: [PATCH v6 06/15] drm/msm/a6xx: Introduce GMU wrapper support

2023-05-03 Thread Akhil P Oommen
On Tue, May 02, 2023 at 11:40:26AM +0200, Konrad Dybcio wrote: > > > On 2.05.2023 09:49, Akhil P Oommen wrote: > > On Sat, Apr 01, 2023 at 01:54:43PM +0200, Konrad Dybcio wrote: > >> Some (particularly SMD_RPM, a.k.a non-RPMh) SoCs implement A6XX GPUs > >> but don't implement the associated

[PATCH v4 5/7] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-03 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_config_1_2() -- unrolling thresh loops Changes in v4: -- delete DPU_DSC_HW_REV_1_1 -- delete

[PATCH v4 7/7] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-03 Thread Kuogee Hsieh
From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so both share same base address but with its own different sub block address. changes in v4: --

[PATCH v4 4/7] drm/msm/dpu: add PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-03 Thread Kuogee Hsieh
During DSC setup, the crossbar mux need to be programmed to engage DSC to specified PINGPONG. Hence during tear down, the crossbar mux need to be reset to disengage DSC from PINGPONG. 0X0F is written to reset crossbar mux. It is not relevant to hw_pp->idx. This patch add PINGPONG_NONE to serve as

[PATCH v4 6/7] drm/msm/dpu: separate DSC flush update out of interface

2023-05-03 Thread Kuogee Hsieh
Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to make it consistent with the location of flush

[PATCH v4 3/7] drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos

2023-05-03 Thread Kuogee Hsieh
At legacy chipsets, it required DPU_PINGPONG_DSC bit be set to indicate pingpong ops functions are required to complete DSC data path setup if this chipset has DSC hardware block presented. This patch add DPU_PINGPONG_DSC bit to both PP_BLK and PP_BLK_TE marcos if it has DSC hardware block

[PATCH v4 2/7] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit

2023-05-03 Thread Kuogee Hsieh
Legacy DPU (DPU < 7.0.0) requires PP block to be involved during DSC setting up. Since then, enable and start the DSC encoder engine had moved to INTF with helps of flush mechanism. This patch adds DPU_PINGPONG_DSC feature bit to indicate that both dpu_hw_pp_setup_dsc() and dpu_hw_pp_dsc_enable()

[PATCH v4 1/7] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-03 Thread Kuogee Hsieh
From: Abhinav Kumar There are some platforms has DSC blocks but it is not declared at catalog. For completeness, this patch adds DSC blocks for platforms which missed them. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_0_msm8998.h

[PATCH v4 0/7] add DSC 1.2 dpu supports

2023-05-03 Thread Kuogee Hsieh
This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. The DSI and DP parts will be pushed later on top of this change. This seriel is rebase on [1], [2] and catalog fixes from [3]. Abhinav Kumar (2): drm/msm/dpu:

Re: [PATCH v3 3/7] drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos

2023-05-03 Thread Kuogee Hsieh
On 5/3/2023 11:55 AM, Dmitry Baryshkov wrote: On 03/05/2023 20:45, Kuogee Hsieh wrote: On 5/2/2023 3:42 PM, Dmitry Baryshkov wrote: On 03/05/2023 00:02, Kuogee Hsieh wrote: At legacy chipsets, it required DPU_PINGPONG_DSC bit be set to indicate pingpong ops functions are required to

Re: [PATCH 4/4] drm/msm/dpu: Enable compression for command mode

2023-05-03 Thread Dmitry Baryshkov
On 03/05/2023 22:04, Jessica Zhang wrote: On 5/3/2023 12:28 AM, Marijn Suijten wrote: On 2023-05-02 18:19:15, Jessica Zhang wrote: Add a dpu_hw_intf op to enable data compression. Signed-off-by: Jessica Zhang ---   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4  

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-03 Thread André Almeida
Em 03/05/2023 14:43, Timur Kristóf escreveu: Hi Felix, On Wed, 2023-05-03 at 11:08 -0400, Felix Kuehling wrote: That's the worst-case scenario where you're debugging HW or FW issues. Those should be pretty rare post-bringup. But are there hangs caused by user mode driver or application bugs

Re: [PATCH v3 6/6] fbdev: Rename fb_mem*() helpers

2023-05-03 Thread Sam Ravnborg
Hi Thomas, On Wed, May 03, 2023 at 10:15:46AM +0200, Thomas Zimmermann wrote: > Hi > > Am 02.05.23 um 22:08 schrieb Sam Ravnborg: > > Hi Thomas. > > > > On Tue, May 02, 2023 at 03:02:23PM +0200, Thomas Zimmermann wrote: > > > Update the names of the fb_mem*() helpers to be consistent with their

Re: [PATCH 4/4] drm/msm/dpu: Enable compression for command mode

2023-05-03 Thread Jessica Zhang
On 5/3/2023 12:28 AM, Marijn Suijten wrote: On 2023-05-02 18:19:15, Jessica Zhang wrote: Add a dpu_hw_intf op to enable data compression. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 4 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c

Re: [PATCH 3/4] drm/msm/dpu: Add has_data_compress to dpu_caps

2023-05-03 Thread Jessica Zhang
On 5/3/2023 12:07 AM, Marijn Suijten wrote: On 2023-05-02 18:19:14, Jessica Zhang wrote: Add data_compress feature to DPU HW catalog. In DPU 7.x and later, there is a DATA_COMPRESS register that must be set within the DPU INTF block for DSC to work. As core_rev (and related macros) was

Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-03 Thread Sam Ravnborg
Hi Thomas, > > But I am missing something somewhere as I cannot see how this builds. > > asm-generic now provide the fb_read/fb_write helpers. > > But for example sparc has an architecture specifc fb.h so it will not > > use the asm-generic variant. So I wonder how sparc get hold of the > >

Re: [PATCH v3 3/7] drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos

2023-05-03 Thread Dmitry Baryshkov
On 03/05/2023 20:45, Kuogee Hsieh wrote: On 5/2/2023 3:42 PM, Dmitry Baryshkov wrote: On 03/05/2023 00:02, Kuogee Hsieh wrote: At legacy chipsets, it required DPU_PINGPONG_DSC bit be set to indicate pingpong ops functions are required to complete DSC data path setup if this chipset has DSC

Re: [PATCH v3 7/7] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-03 Thread Abhinav Kumar
On 5/2/2023 2:42 PM, Dmitry Baryshkov wrote: On 03/05/2023 00:03, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information.  Each display compression engine (DCE) contains dual hard slice DSC encoders so both

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-03 Thread André Almeida
Em 03/05/2023 14:08, Marek Olšák escreveu: GPU hangs are pretty common post-bringup. They are not common per user, but if we gather all hangs from all users, we can have lots and lots of them. GPU hangs are indeed not very debuggable. There are however some things we can do: - Identify the

Re: [PATCH 1/4] Input/ARM: ads7846: Get pendown IRQ from descriptors

2023-05-03 Thread Dmitry Torokhov
On Sun, Apr 30, 2023 at 11:22:16AM +0200, Linus Walleij wrote: > The ADS7846 has some limited support for using GPIO descriptors, > let's convert it over completely and fix all users to provide > GPIOs in descriptor tables. > > The Nokia 770 now has dynamic allocation of IRQ numbers, so this >

Re: drm/amdgpu: fix an amdgpu_irq_put() issue in gmc_v9_0_hw_fini()

2023-05-03 Thread Limonciello, Mario
On 5/2/2023 11:51 AM, Hamza Mahfooz wrote: As made mention of, in commit 9128e6babf10 ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v10_0_hw_fini") and commit c094b8923bdd ("drm/amdgpu: fix amdgpu_irq_put call trace in gmc_v11_0_hw_fini"). It is meaningless to call amdgpu_irq_put() for

Re: [PATCH v2 17/19] fbdev: Validate info->screen_{base,buffer} in fb_ops implementations

2023-05-03 Thread Thomas Zimmermann
Hi Am 03.05.23 um 17:02 schrieb Geert Uytterhoeven: Hi Thomas, On Wed, May 3, 2023 at 4:30 PM Thomas Zimmermann wrote: Am 03.05.23 um 11:51 schrieb Geert Uytterhoeven: On Fri, Apr 28, 2023 at 2:26 PM Thomas Zimmermann wrote: Push the test for info->screen_base from fb_read() and

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/guc: Capture list naming clean up

2023-05-03 Thread Teres Alexis, Alan Previn
LGTM: Reviewed-by: Alan Previn On Fri, 2023-04-28 at 11:56 -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > Don't use 'xe_lp*' prefixes for register lists that are common with > Gen8. > > Don't add Xe only GSC registers to pre-Xe devices that don't > even have a GSC engine. >

Re: [PATCH v3 4/7] drm/msm/dpu: add PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-03 Thread Kuogee Hsieh
On 5/3/2023 1:03 AM, Marijn Suijten wrote: On 2023-05-02 14:02:59, Kuogee Hsieh wrote: During DSC setup, the crossbar mux need to be programmed to engage DSC to specified PINGPONG. Hence during tear down, the crossbar mux need to be reset to disengage DSC from PINGPONG. This patch add

Re: [PATCH v3 3/7] drm/msm/dpu: add DPU_PINGPONG_DSC bits into PP_BLK and PP_BLK_TE marcos

2023-05-03 Thread Kuogee Hsieh
On 5/2/2023 3:42 PM, Dmitry Baryshkov wrote: On 03/05/2023 00:02, Kuogee Hsieh wrote: At legacy chipsets, it required DPU_PINGPONG_DSC bit be set to indicate pingpong ops functions are required to complete DSC data path setup if this chipset has DSC hardware block presented. This patch add

Re: [PATCH 2/4] drm/msm/dsi: Fix compressed word count calculation

2023-05-03 Thread Jessica Zhang
On 5/3/2023 1:26 AM, Dmitry Baryshkov wrote: On 03/05/2023 04:19, Jessica Zhang wrote: Currently, word count is calculated using slice_count. This is incorrect as downstream uses slice per packet, which is different from slice_count. Slice count represents the number of soft slices per

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-03 Thread Marek Olšák
WRITE_DATA with ENGINE=PFP will execute the packet on the frontend engine, while ENGINE=ME will execute the packet on the backend engine. Marek On Wed, May 3, 2023 at 1:08 PM Marek Olšák wrote: > GPU hangs are pretty common post-bringup. They are not common per user, > but if we gather all

Re: [PATCH 1/4] drm/msm/dsi: Adjust pclk rate for compression

2023-05-03 Thread Jessica Zhang
On 5/3/2023 1:33 AM, Dmitry Baryshkov wrote: On 03/05/2023 04:19, Jessica Zhang wrote: Divide the pclk rate by the compression ratio when DSC is enabled Signed-off-by: Jessica Zhang ---   drivers/gpu/drm/msm/dsi/dsi_host.c | 14 ++   1 file changed, 10 insertions(+), 4

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-03 Thread Marek Olšák
GPU hangs are pretty common post-bringup. They are not common per user, but if we gather all hangs from all users, we can have lots and lots of them. GPU hangs are indeed not very debuggable. There are however some things we can do: - Identify the hanging IB by its VA (the kernel should know it)

Re: [PATCH v6 0/3] Add sync object UAPI support to VirtIO-GPU driver

2023-05-03 Thread Gurchetan Singh
On Mon, May 1, 2023 at 8:38 AM Dmitry Osipenko < dmitry.osipe...@collabora.com> wrote: > On 4/16/23 14:52, Dmitry Osipenko wrote: > > We have multiple Vulkan context types that are awaiting for the addition > > of the sync object DRM UAPI support to the VirtIO-GPU kernel driver: > > > > 1. Venus

Re: [PATCH V2 1/6] drm: bridge: samsung-dsim: fix blanking packet size calculation

2023-05-03 Thread Jagan Teki
On Mon, Apr 24, 2023 at 3:17 PM Adam Ford wrote: > > On Mon, Apr 24, 2023 at 4:03 AM Jagan Teki wrote: > > > > On Sun, Apr 23, 2023 at 5:42 PM Adam Ford wrote: > > > > > > From: Lucas Stach > > > > > > Scale the blanking packet sizes to match the ratio between HS clock > > > and DPI interface

[PATCH v2 2/2] drm/bridge: ti-sn65dsi83: Fix enable/disable flow to meet spec

2023-05-03 Thread Frieder Schrempf
From: Frieder Schrempf The datasheet describes the following initialization flow including minimum delay times between each step: 1. DSI data lanes need to be in LP-11 and the clock lane in HS mode 2. toggle EN signal 3. initialize registers 4. enable PLL 5. soft reset 6. enable DSI stream 7.

[PATCH v2 1/2] drm: bridge: samsung-dsim: Fix i.MX8M enable flow to meet spec

2023-05-03 Thread Frieder Schrempf
From: Frieder Schrempf According to the documentation [1] the proper enable flow is: 1. Enable DSI link and keep data lanes in LP-11 (stop state) 2. Disable stop state to bring data lanes into HS mode Currently we do this all at once within enable(), which doesn't allow to meet the

[PATCH v2 0/2] Init flow fixes for Samsung DSIM and TI SN65DSI84

2023-05-03 Thread Frieder Schrempf
From: Frieder Schrempf This patchset contains a proposal to fix the initialization flow for the display pipeline used on our i.MX8MM Kontron boards: i.MX8MM LCDIF -> i.MX8MM DSIM -> TI SN65DSI84 -> 7" LVDS Panel Without these changes the display works most of the time, but fails to come up

Re: [PATCH V3 7/7] drm: bridge: samsung-dsim: Let blanking calcuation work in non-burst mode

2023-05-03 Thread Adam Ford
On Wed, May 3, 2023 at 10:52 AM Frieder Schrempf wrote: > > On 02.05.23 03:07, Adam Ford wrote: > > The blanking calculation currently uses burst_clk_rate for calculating > > the settings. Since it's possible to use this in non-burst mode, it's > > possible that where won't be burst_clk_rate.

Re: [PATCH V3 7/7] drm: bridge: samsung-dsim: Let blanking calcuation work in non-burst mode

2023-05-03 Thread Frieder Schrempf
On 02.05.23 03:07, Adam Ford wrote: > The blanking calculation currently uses burst_clk_rate for calculating > the settings. Since it's possible to use this in non-burst mode, it's > possible that where won't be burst_clk_rate. Instead, cache the "possible that burst_clk_rate is 0" > clock rate

Re: [PATCH V3 6/7] drm: bridge: samsung-dsim: Support non-burst mode

2023-05-03 Thread Frieder Schrempf
On 02.05.23 03:07, Adam Ford wrote: > The high-speed clock is hard-coded to the burst-clock > frequency specified in the device tree. However, when > using devices like certain bridge chips without burst mode > and varying resolutions and refresh rates, it may be > necessary to set the high-speed

Re: [PATCH V3 5/7] drm: bridge: samsung-dsim: Dynamically configure DPHY timing

2023-05-03 Thread Frieder Schrempf
On 02.05.23 03:07, Adam Ford wrote: > The DPHY timings are currently hard coded. Since the input > clock can be variable, the phy timings need to be variable > too. Add an additional variable to the driver data to enable > this feature to prevent breaking boards that don't support it. > > The

Re: [Intel-gfx] [RFC PATCH 2/4] drm/cgroup: Add memory accounting to DRM cgroup

2023-05-03 Thread Maarten Lankhorst
On 2023-05-03 17:31, Tvrtko Ursulin wrote: On 03/05/2023 09:34, Maarten Lankhorst wrote: Based roughly on the rdma and misc cgroup controllers, with a lot of the accounting code borrowed from rdma. The interface is simple: - populate drmcgroup_device->regions[..] name and size for each

Re: [Intel-gfx] [RFC PATCH 2/4] drm/cgroup: Add memory accounting to DRM cgroup

2023-05-03 Thread Tvrtko Ursulin
On 03/05/2023 09:34, Maarten Lankhorst wrote: Based roughly on the rdma and misc cgroup controllers, with a lot of the accounting code borrowed from rdma. The interface is simple: - populate drmcgroup_device->regions[..] name and size for each active region. - Call

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-03 Thread Christian König
Am 03.05.23 um 17:08 schrieb Felix Kuehling: Am 2023-05-03 um 03:59 schrieb Christian König: Am 02.05.23 um 20:41 schrieb Alex Deucher: On Tue, May 2, 2023 at 11:22 AM Timur Kristóf wrote: [SNIP] In my opinion, the correct solution to those problems would be if the kernel could give

Re: [PATCH V3 4/7] drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY

2023-05-03 Thread Frieder Schrempf
On 02.05.23 03:07, Adam Ford wrote: > In order to support variable DPHY timings, it's necessary > to enable GENERIC_PHY_MIPI_DPHY so phy_mipi_dphy_get_default_config > can be used to determine the nominal values for a given resolution > and refresh rate. > > Signed-off-by: Adam Ford This fixes

Re: [PATCH V3 3/7] drm: bridge: samsung-dsim: Fetch pll-clock-frequency automatically

2023-05-03 Thread Frieder Schrempf
On 02.05.23 03:07, Adam Ford wrote: > Make the pll-clock-frequency optional. If it's present, use it > to maintain backwards compatibility with existing hardware. If it > is absent, read clock rate of "sclk_mipi" to determine the rate. > > Signed-off-by: Adam Ford > Tested-by: Chen-Yu Tsai

Re: [PATCH V3 2/7] drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp]

2023-05-03 Thread Frieder Schrempf
On 02.05.23 03:07, Adam Ford wrote: > According to Table 13-45 of the i.MX8M Mini Reference Manual, the min > and max values for M and the frequency range for the VCO_out > calculator were incorrect. This information was contradicted in other > parts of the mini, nano and plus manuals. After

Re: [PATCH V3 1/7] drm: bridge: samsung-dsim: fix blanking packet size calculation

2023-05-03 Thread Frieder Schrempf
On 02.05.23 03:07, Adam Ford wrote: > From: Lucas Stach > > Scale the blanking packet sizes to match the ratio between HS clock > and DPI interface clock. The controller seems to do internal scaling > to the number of active lanes, so we don't take those into account. > > Signed-off-by: Lucas

Re: [RFC PATCH 0/1] Add AMDGPU_INFO_GUILTY_APP ioctl

2023-05-03 Thread Felix Kuehling
Am 2023-05-03 um 03:59 schrieb Christian König: Am 02.05.23 um 20:41 schrieb Alex Deucher: On Tue, May 2, 2023 at 11:22 AM Timur Kristóf wrote: [SNIP] In my opinion, the correct solution to those problems would be if the kernel could give userspace the necessary information about a GPU hang

Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-03 Thread Arnd Bergmann
On Wed, May 3, 2023, at 16:55, Thomas Zimmermann wrote: > Am 02.05.23 um 22:06 schrieb Arnd Bergmann: >> It's probably safe to deal with all the above by either adding >> architecture specific overrides to the current version, or >> by doing the semantic changes before the move to asm/fb.h, but

Re: [PATCH v2 17/19] fbdev: Validate info->screen_{base,buffer} in fb_ops implementations

2023-05-03 Thread Geert Uytterhoeven
Hi Thomas, On Wed, May 3, 2023 at 4:30 PM Thomas Zimmermann wrote: > Am 03.05.23 um 11:51 schrieb Geert Uytterhoeven: > > On Fri, Apr 28, 2023 at 2:26 PM Thomas Zimmermann > > wrote: > >> Push the test for info->screen_base from fb_read() and fb_write() into > >> the implementations of struct

Re: drm/sched: Replacement for drm_sched_resubmit_jobs() is deprecated

2023-05-03 Thread Christian König
Am 03.05.23 um 15:10 schrieb Lucas Stach: Am Mittwoch, dem 03.05.2023 um 13:40 +0200 schrieb Christian König: Hi Lucas, Am 03.05.23 um 12:28 schrieb Lucas Stach: Hi Christian, Am Mittwoch, dem 03.05.2023 um 10:47 +0200 schrieb Christian König: Adding Luben as well. Am 03.05.23 um 10:16

Re: [PATCH v3 5/6] fbdev: Move framebuffer I/O helpers into

2023-05-03 Thread Thomas Zimmermann
Hi Am 02.05.23 um 22:06 schrieb Arnd Bergmann: On Tue, May 2, 2023, at 15:02, Thomas Zimmermann wrote: Implement framebuffer I/O helpers, such as fb_read*() and fb_write*(), in the architecture's header file or the generic one. The common case has been the use of regular I/O functions, such

Re: [PATCH] drm/udl: delete dead code

2023-05-03 Thread Thomas Zimmermann
Merged, thanks! Am 02.05.23 um 14:59 schrieb Dan Carpenter: The "unode" pointer cannot be NULL here and checking for it causes Smatch warnings: drivers/gpu/drm/udl/udl_main.c:259 udl_get_urb_locked() warn: can 'unode' even be NULL? Fortunately, it's just harmless dead code which can

Re: [PATCH v2 17/19] fbdev: Validate info->screen_{base,buffer} in fb_ops implementations

2023-05-03 Thread Thomas Zimmermann
Hi Am 03.05.23 um 11:51 schrieb Geert Uytterhoeven: On Fri, Apr 28, 2023 at 2:26 PM Thomas Zimmermann wrote: Push the test for info->screen_base from fb_read() and fb_write() into the implementations of struct fb_ops.{fb_read,fb_write}. In cases where the driver operates on

[PATCH v3] drm/i915: avoid flush_scheduled_work() usage

2023-05-03 Thread Tetsuo Handa
Like commit c4f135d643823a86 ("workqueue: Wrap flush_workqueue() using a macro") says, flush_scheduled_work() is dangerous and will be forbidden. i915 became the last flush_scheduled_work() user, but developers cannot find time for auditing which work items does this flush_scheduled_work() need

Re: [Intel-gfx] [PATCH v4 2/3] drm/i915: use pat_index instead of cache_level

2023-05-03 Thread Tvrtko Ursulin
On 02/05/2023 05:11, fei.y...@intel.com wrote: From: Fei Yang Currently the KMD is using enum i915_cache_level to set caching policy for buffer objects. This is flaky because the PAT index which really controls the caching behavior in PTE has far more levels than what's defined in the enum.

Re: drm/sched: Replacement for drm_sched_resubmit_jobs() is deprecated

2023-05-03 Thread Lucas Stach
Am Mittwoch, dem 03.05.2023 um 13:40 +0200 schrieb Christian König: > Hi Lucas, > > Am 03.05.23 um 12:28 schrieb Lucas Stach: > > Hi Christian, > > > > Am Mittwoch, dem 03.05.2023 um 10:47 +0200 schrieb Christian König: > > > Adding Luben as well. > > > > > > Am 03.05.23 um 10:16 schrieb Boris

Re: [PATCH 3/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

2023-05-03 Thread Linus Walleij
On Tue, May 2, 2023 at 4:26 PM Ulf Hansson wrote: > On Sun, 30 Apr 2023 at 11:22, Linus Walleij wrote: > > Fixes: 92bf78b33b0b ("gpio: omap: use dynamic allocation of base") > > Signed-off-by: Linus Walleij > > This looks like it's best funneled through the soc maintainer's tree(s), > right?

Re: [PATCH 02/11] drm/i915/mst: Remove broken MST DSC support

2023-05-03 Thread Lisovskiy, Stanislav
On Wed, May 03, 2023 at 02:07:04PM +0300, Ville Syrjälä wrote: > On Wed, May 03, 2023 at 10:36:42AM +0300, Lisovskiy, Stanislav wrote: > > On Tue, May 02, 2023 at 05:38:57PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > The MST DSC code has a myriad of issues: > > > -

[PATCH v2 09/11] drm/mediatek: gamma: Add support for 12-bit LUT and MT8195

2023-05-03 Thread AngeloGioacchino Del Regno
Add support for 12-bit gamma lookup tables and introduce the first user for it: MT8195. While at it, also reorder the variables in mtk_gamma_set_common() and rename `lut_base` to `lut0_base` to improve readability. Signed-off-by: AngeloGioacchino Del Regno ---

[PATCH v2 11/11] drm/mediatek: gamma: Program gamma LUT type for descending or rising

2023-05-03 Thread AngeloGioacchino Del Regno
All of the SoCs that don't have dithering control in the gamma IP have got a GAMMA_LUT_TYPE bit that tells to the IP if the LUT is "descending" (bit set) or "rising" (bit cleared): make sure to set it correctly after programming the LUT. Signed-off-by: AngeloGioacchino Del Regno ---

[PATCH v2 08/11] drm/mediatek: gamma: Support multi-bank gamma LUT

2023-05-03 Thread AngeloGioacchino Del Regno
Newer Gamma IP have got multiple LUT banks: support specifying the size of the LUT banks and handle bank-switching before programming the LUT in mtk_gamma_set_common() in preparation for adding support for MT8195 and newer SoCs. Suggested-by: Jason-JH.Lin [Angelo: Refactored original commit]

[PATCH v2 10/11] drm/mediatek: gamma: Make sure relay mode is disabled

2023-05-03 Thread AngeloGioacchino Del Regno
Disable relay mode at the end of LUT programming to make sure that the processed image goes through. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c

[PATCH v2 07/11] drm/mediatek: gamma: Support specifying number of bits per LUT component

2023-05-03 Thread AngeloGioacchino Del Regno
New SoCs, like MT8195, not only may support bigger lookup tables, but have got a different register layout to support bigger precision: support specifying the number of `lut_bits` for each SoC and use it in mtk_gamma_set_common() to perform the right calculation. Signed-off-by: AngeloGioacchino

[PATCH v2 06/11] drm/mediatek: gamma: Use bitfield macros

2023-05-03 Thread AngeloGioacchino Del Regno
Make the code more robust and improve readability by using bitfield macros instead of open coding bit operations. While at it, also add a definition for LUT_BITS_DEFAULT. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 41 ++- 1

[PATCH v2 04/11] drm/mediatek: gamma: Improve and simplify HW LUT calculation

2023-05-03 Thread AngeloGioacchino Del Regno
Use drm_color_lut_extract() to avoid open-coding the bits reduction calculations for each color channel and use a struct drm_color_lut to temporarily store the information instead of an array of u32. Also, slightly improve the precision of the HW LUT calculation in the LUT DIFF case by performing

[PATCH v2 05/11] drm/mediatek: gamma: Enable the Gamma LUT table only after programming

2023-05-03 Thread AngeloGioacchino Del Regno
Move the write to DISP_GAMMA_CFG to enable the Gamma LUT to after programming the actual table to avoid potential visual glitches during table modification. Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 13 - 1 file changed, 8

  1   2   >