[PATCH 6/7] drm/amd/display: Implement the retrieval of secure display CRC data

2023-05-15 Thread Alan Liu
Retrieve secure display's CRC data from the DC hardware in vline0 irq handler, and store the values in secure display contexts. Signed-off-by: Alan Liu --- .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 50 --- 1 file changed, 42 insertions(+), 8 deletions(-) diff --git

[PATCH 5/7] drm/amd/display: Processing secure display new ROI update in atomic commit

2023-05-15 Thread Alan Liu
Check if there is a new ROI update during the atomic commit and process it. A new function amdgpu_dm_crtc_set_secure_display_crc_source() is implemented to control the state of CRC engine in hardware. Signed-off-by: Alan Liu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 38 +

[PATCH 7/7] drm/amd/display: Block the requests for secure display ROI/CRC until data ready

2023-05-15 Thread Alan Liu
When the user requests for secure display ROI or CRC data, the request will be blocked until the CRC result of current frame is calculated and updated to secure display ctx in vline0 irq handler. Signed-off-by: Alan Liu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 +++-

[PATCH 4/7] drm/amd/display: Implement set/get functions for secure display CRC properties

2023-05-15 Thread Alan Liu
Implement set/get functions as the callback for userspace to get the CRC result values of the corresponding ROI configuration of secure display. Signed-off-by: Alan Liu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 1 + .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c| 38

[PATCH 3/7] drm/amd/display: Add new blob properties for secure display CRC

2023-05-15 Thread Alan Liu
Add a new blob properties and implement the property creation and attachment functions for the CRC result values of secure display. Signed-off-by: Alan Liu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 3 +++ .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 1 +

[PATCH 2/7] drm/amd/display: Implement set/get functions for secure display ROI properties

2023-05-15 Thread Alan Liu
Implement set/get functions as the callback for userspace to update or get the secure display ROI configuration. Signed-off-by: Alan Liu --- .../amd/display/amdgpu_dm/amdgpu_dm_crtc.c| 51 +++ 1 file changed, 51 insertions(+) diff --git

[PATCH 1/7] drm/amd/display: Add new blob properties for secure display ROI

2023-05-15 Thread Alan Liu
Add a new blob properties as well as the create and attach functions for configuring region of interested (ROI) of secure display. Signed-off-by: Alan Liu --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 10 ++ .../drm/amd/display/amdgpu_dm/amdgpu_dm_crc.c | 4 +++

[PATCH 0/7] Secure display with new CRTC properties

2023-05-15 Thread Alan Liu
Dear DRM development community, We'd like to introduce the implementation of the new crtc properties. First of all, please let me introduce the problem we try to address. With the popularity of electric vehicles, the car vendors have increasing requirement for ensuring the integrity of the

Re: [PATCH V6 6/6] drm: bridge: samsung-dsim: Support non-burst mode

2023-05-15 Thread Chen-Yu Tsai
On Tue, May 16, 2023 at 7:57 AM Adam Ford wrote: > > The high-speed clock is hard-coded to the burst-clock > frequency specified in the device tree. However, when > using devices like certain bridge chips without burst mode > and varying resolutions and refresh rates, it may be > necessary to

Re: [PATCH] drm/msm/a6xx: don't set IO_PGTABLE_QUIRK_ARM_OUTER_WBWA with coherent SMMU

2023-05-15 Thread Konrad Dybcio
On 10.04.2023 20:52, Dmitry Baryshkov wrote: > If the Adreno SMMU is dma-coherent, allocation will fail unless we > disable IO_PGTABLE_QUIRK_ARM_OUTER_WBWA. Skip setting this quirk for the > coherent SMMUs (like we have on sm8350 platform). > > Fixes: 54af0ceb7595 ("arm64: dts: qcom: sm8350:

Re: [PATCH v3 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-05-15 Thread Konrad Dybcio
On 7.05.2023 10:20, Krzysztof Kozlowski wrote: > On 05/05/2023 23:40, Konrad Dybcio wrote: >> Document the SM6375 MDSS. >> >> Signed-off-by: Konrad Dybcio >> --- >> .../bindings/display/msm/qcom,sm6375-mdss.yaml | 216 >> + >> 1 file changed, 216 insertions(+) >> > >

Re: [PATCH v3 1/2] iommu/arm-smmu-qcom: Fix missing adreno_smmu's

2023-05-15 Thread Konrad Dybcio
On 11.05.2023 16:59, Rob Clark wrote: > From: Rob Clark > > When the special handling of qcom,adreno-smmu was moved into > qcom_smmu_create(), it was overlooked that we didn't have all the > required entries in qcom_smmu_impl_of_match. So we stopped getting > adreno_smmu_priv on sc7180,

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Jessica Zhang
On 5/15/2023 3:07 PM, Dmitry Baryshkov wrote: On 16/05/2023 01:01, Marijn Suijten wrote: On 2023-05-15 13:29:21, Jessica Zhang wrote: Const, as requested elsewhere.  But this function is not used anywhere in any of the series (because we replaced the usages with more sensible member

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Jessica Zhang
On 5/15/2023 3:01 PM, Marijn Suijten wrote: On 2023-05-15 13:29:21, Jessica Zhang wrote: Const, as requested elsewhere. But this function is not used anywhere in any of the series (because we replaced the usages with more sensible member accesses like slice_chunk_size). Acked. I would

Re: [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

2023-05-15 Thread Dixit, Ashutosh
On Mon, 15 May 2023 15:58:26 -0700, Dixit, Ashutosh wrote: > > On Mon, 15 May 2023 15:23:58 -0700, Belgaumkar, Vinay wrote: > > > > > > On 5/12/2023 5:39 PM, Dixit, Ashutosh wrote: > > > On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote: > > > Hi Vinay, > > > > > >> rps_boost debugfs

Re: [PATCH v8 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-15 Thread Abhinav Kumar
On 5/15/2023 3:23 PM, Marijn Suijten wrote: On 2023-05-15 15:03:46, Abhinav Kumar wrote: On 5/15/2023 2:21 PM, Marijn Suijten wrote: On 2023-05-12 11:00:22, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag

[PATCH V6 5/6] drm: bridge: samsung-dsim: Dynamically configure DPHY timing

2023-05-15 Thread Adam Ford
The DPHY timings are currently hard coded. Since the input clock can be variable, the phy timings need to be variable too. To facilitate this, we need to cache the hs_clock based on what is generated from the PLL. The phy_mipi_dphy_get_default_config_for_hsclk function configures the DPHY

[PATCH V6 6/6] drm: bridge: samsung-dsim: Support non-burst mode

2023-05-15 Thread Adam Ford
The high-speed clock is hard-coded to the burst-clock frequency specified in the device tree. However, when using devices like certain bridge chips without burst mode and varying resolutions and refresh rates, it may be necessary to set the high-speed clock dynamically based on the desired pixel

[PATCH V6 4/6] drm: bridge: samsung-dsim: Select GENERIC_PHY_MIPI_DPHY

2023-05-15 Thread Adam Ford
In order to support variable DPHY timings, it's necessary to enable GENERIC_PHY_MIPI_DPHY so phy_mipi_dphy_get_default_config can be used to determine the nominal values for a given resolution and refresh rate. Signed-off-by: Adam Ford Tested-by: Frieder Schrempf Reviewed-by: Frieder Schrempf

[PATCH V6 3/6] drm: bridge: samsung-dsim: Fetch pll-clock-frequency automatically

2023-05-15 Thread Adam Ford
Make the pll-clock-frequency optional. If it's present, use it to maintain backwards compatibility with existing hardware. If it is absent, read clock rate of "sclk_mipi" to determine the rate. Since it can be optional, change the message from an error to dev_info. Signed-off-by: Adam Ford

[PATCH V6 2/6] drm: bridge: samsung-dsim: Fix PMS Calculator on imx8m[mnp]

2023-05-15 Thread Adam Ford
According to Table 13-45 of the i.MX8M Mini Reference Manual, the min and max values for M and the frequency range for the VCO_out calculator were incorrect. This information was contradicted in other parts of the mini, nano and plus manuals. After reaching out to my NXP Rep, when confronting

[PATCH V6 1/6] drm: bridge: samsung-dsim: fix blanking packet size calculation

2023-05-15 Thread Adam Ford
From: Lucas Stach Scale the blanking packet sizes to match the ratio between HS clock and DPI interface clock. The controller seems to do internal scaling to the number of active lanes, so we don't take those into account. Signed-off-by: Lucas Stach Signed-off-by: Adam Ford Tested-by: Chen-Yu

[PATCH V6 0/6] drm: bridge: samsung-dsim: Support variable clocking

2023-05-15 Thread Adam Ford
This series fixes the blanking pack size and the PMS calculation. It then adds support to allows the DSIM to dynamically DPHY clocks, and support non-burst mode while allowing the removal of the hard-coded clock values for the PLL for imx8m mini/nano/plus, and it allows the removal of the

Re: [PATCH v9 8/8] drm/msm/dpu: tear down DSC data path when DSC disabled

2023-05-15 Thread Marijn Suijten
Tear down DSC datapath* on encoder cleanup* On 2023-05-15 14:25:28, Kuogee Hsieh wrote: > > Unset DSC_ACTIVE bit at dpu_hw_ctl_reset_intf_cfg_v1(), > dpu_encoder_unprep_dsc() and dpu_encoder_dsc_pipe_clr() functions > to tear down DSC data path if DSC data path was setup previous. > >

Re: [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

2023-05-15 Thread Dixit, Ashutosh
On Mon, 15 May 2023 15:23:58 -0700, Belgaumkar, Vinay wrote: > > > On 5/12/2023 5:39 PM, Dixit, Ashutosh wrote: > > On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote: > > Hi Vinay, > > > >> rps_boost debugfs shows host turbo related info. This is not valid > >> when SLPC is enabled. > > A

Re: [PATCH v9 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-15 Thread Marijn Suijten
On 2023-05-15 14:25:26, Kuogee Hsieh wrote: > > Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). > This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by > adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per > DSC engine and DSC flush bits at

Re: [PATCH v9 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-15 Thread Marijn Suijten
On 2023-05-15 14:25:27, Kuogee Hsieh wrote: > > From: Abhinav Kumar > > Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and > feature flag information. Each display compression engine (DCE) contains > dual hard slice DSC encoders so both share same base address but with >

Re: [PATCH v9 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Marijn Suijten
On 2023-05-15 14:25:25, Kuogee Hsieh wrote: > > Add support for DSC 1.2 by providing the necessary hooks to program > the DPU DSC 1.2 encoder. > > Changes in v3: > -- fixed kernel test rebot report that "__iomem *off" is declared but not >used at dpu_hw_dsc_config_1_2() > -- unrolling thresh

Re: [PATCH v9 3/8] drm/msm/dpu: test DPU_PINGPONG_DSC bit before assign DSC ops to PINGPONG

2023-05-15 Thread Marijn Suijten
You forgot to address the title suggestion "before assign" isn't proper English. Copying from v8 review: "Guard PINGPONG DSC ops behind DPU_PINGPONG_DSC bit" On 2023-05-15 14:25:23, Kuogee Hsieh wrote: > > DPU < 7.0.0 has DPU_PINGPONG_DSC feature bit set to indicate it requires > both

Re: [PATCH] drm:amd:amdgpu: Fix missing buffer object unlock in failure path

2023-05-15 Thread Sukrut Bellary
On 5/3/23 16:15, Sukrut Bellary wrote: > smatch warning - > 1) drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c:3615 gfx_v9_0_kiq_resume() > warn: inconsistent returns 'ring->mqd_obj->tbo.base.resv'. > > 2) drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c:6901 gfx_v10_0_kiq_resume() > warn: inconsistent returns

Re: [PATCH] drm/i915/guc/slpc: Disable rps_boost debugfs

2023-05-15 Thread Belgaumkar, Vinay
On 5/12/2023 5:39 PM, Dixit, Ashutosh wrote: On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote: Hi Vinay, rps_boost debugfs shows host turbo related info. This is not valid when SLPC is enabled. A couple of thoughts about this. It appears people are know only about rps_boost_info

Re: [PATCH v8 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-15 Thread Marijn Suijten
On 2023-05-15 15:03:46, Abhinav Kumar wrote: > On 5/15/2023 2:21 PM, Marijn Suijten wrote: > > On 2023-05-12 11:00:22, Kuogee Hsieh wrote: > >> > >> From: Abhinav Kumar > >> > >> Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and > >> feature flag information. Each display

Re: [PATCH v9 2/8] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit for DPU < 7.0.0

2023-05-15 Thread Marijn Suijten
On 2023-05-15 14:25:22, Kuogee Hsieh wrote: > > DPU < 7.0.0 requires the PINGPONG block to be involved during > DSC setting up. Since DPU >= 7.0.0, enabling and starting the DSC > encoder engine was moved to INTF with the help of the flush mechanism. > Add a DPU_PINGPONG_DSC feature bit to

Re: [PATCH v9 1/8] drm/msm/dpu: add dsc blocks to the catalog of MSM8998 and SC8180X

2023-05-15 Thread Marijn Suijten
Once again, capitalize DSC in the title. On 2023-05-15 14:25:21, Kuogee Hsieh wrote: > > From: Abhinav Kumar > > There are some platforms has DSC blocks which have not been declared in There are some platforms has? How about (as suggested in earlier review): Some platforms have... > the

Re: [Freedreno] [PATCH v8 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-15 Thread Abhinav Kumar
On 5/15/2023 3:03 PM, Abhinav Kumar wrote: On 5/15/2023 2:21 PM, Marijn Suijten wrote: On 2023-05-12 11:00:22, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information.  Each display compression engine

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Dmitry Baryshkov
On 16/05/2023 01:01, Marijn Suijten wrote: On 2023-05-15 13:29:21, Jessica Zhang wrote: Const, as requested elsewhere. But this function is not used anywhere in any of the series (because we replaced the usages with more sensible member accesses like slice_chunk_size). Acked. I would

Re: [PATCH v8 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-15 Thread Abhinav Kumar
On 5/15/2023 2:21 PM, Marijn Suijten wrote: On 2023-05-12 11:00:22, Kuogee Hsieh wrote: From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Marijn Suijten
On 2023-05-15 13:29:21, Jessica Zhang wrote: > > Const, as requested elsewhere. But this function is not used anywhere > > in any of the series (because we replaced the usages with more sensible > > member accesses like slice_chunk_size). > > Acked. > > I would prefer to keep this helper so

Re: [PATCH v9 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-15 Thread Dmitry Baryshkov
On Tue, 16 May 2023 at 00:26, Kuogee Hsieh wrote: > > From: Abhinav Kumar > > Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and > feature flag information. Each display compression engine (DCE) contains > dual hard slice DSC encoders so both share same base address but

Re: [PATCH v9 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Dmitry Baryshkov
On Tue, 16 May 2023 at 00:26, Kuogee Hsieh wrote: > > Add support for DSC 1.2 by providing the necessary hooks to program > the DPU DSC 1.2 encoder. > > Changes in v3: > -- fixed kernel test rebot report that "__iomem *off" is declared but not >used at dpu_hw_dsc_config_1_2() > -- unrolling

Re: [PATCH v9 3/8] drm/msm/dpu: test DPU_PINGPONG_DSC bit before assign DSC ops to PINGPONG

2023-05-15 Thread Dmitry Baryshkov
On Tue, 16 May 2023 at 00:25, Kuogee Hsieh wrote: > > DPU < 7.0.0 has DPU_PINGPONG_DSC feature bit set to indicate it requires > both dpu_hw_pp_setup_dsc() and dpu_hw_pp_dsc_{enable,disable}() to be > executed to complete DSC configuration if DSC hardware block is present. > Hence test

Re: [PATCH v9 2/8] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit for DPU < 7.0.0

2023-05-15 Thread Dmitry Baryshkov
On Tue, 16 May 2023 at 00:25, Kuogee Hsieh wrote: > > DPU < 7.0.0 requires the PINGPONG block to be involved during > DSC setting up. Since DPU >= 7.0.0, enabling and starting the DSC > encoder engine was moved to INTF with the help of the flush mechanism. > Add a DPU_PINGPONG_DSC feature bit to

Re: [PATCH v8 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-15 Thread Marijn Suijten
On 2023-05-12 11:00:21, Kuogee Hsieh wrote: > > Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). Can you rewrite "is piggyback"? Something like "Currently DSC flushing happens during interface configuration". And it's intf configuration **on the CTL**, which makes this

Re: [PATCH] drm/amdgpu: remove unnecessary (void*) conversions

2023-05-15 Thread Alex Deucher
Applied. Thanks! Alex On Mon, May 15, 2023 at 3:18 AM Su Hui wrote: > > No need cast (void*) to (struct amdgpu_device *). > > Signed-off-by: Su Hui > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 2 +- >

Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-15 Thread Abhinav Kumar
On 5/15/2023 2:23 PM, Marijn Suijten wrote: On 2023-05-15 13:58:35, Abhinav Kumar wrote: On 5/15/2023 1:07 PM, Marijn Suijten wrote: On 2023-05-15 11:20:02, Abhinav Kumar wrote: On 5/14/2023 2:39 PM, Marijn Suijten wrote: DSC*, and mention 1.1 explicitly (since this skips the 1.2

[PATCH v9 8/8] drm/msm/dpu: tear down DSC data path when DSC disabled

2023-05-15 Thread Kuogee Hsieh
Unset DSC_ACTIVE bit at dpu_hw_ctl_reset_intf_cfg_v1(), dpu_encoder_unprep_dsc() and dpu_encoder_dsc_pipe_clr() functions to tear down DSC data path if DSC data path was setup previous. Signed-off-by: Kuogee Hsieh Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c |

[PATCH v9 4/8] drm/msm/dpu: Introduce PINGPONG_NONE to disconnect DSC from PINGPONG

2023-05-15 Thread Kuogee Hsieh
Disabling the crossbar mux between DSC and PINGPONG currently requires a bogus enum dpu_pingpong value to be passed when calling dsc_bind_pingpong_blk() with enable=false, even though the register value written is independent of the current PINGPONG block. Replace that `bool enable` parameter

[PATCH v9 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Kuogee Hsieh
Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at dpu_hw_dsc_config_1_2() -- unrolling thresh loops Changes in v4: -- delete DPU_DSC_HW_REV_1_1 -- delete

[PATCH v9 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-15 Thread Kuogee Hsieh
From: Abhinav Kumar Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and feature flag information. Each display compression engine (DCE) contains dual hard slice DSC encoders so both share same base address but with its own different sub block address. changes in v4: --

[PATCH v9 3/8] drm/msm/dpu: test DPU_PINGPONG_DSC bit before assign DSC ops to PINGPONG

2023-05-15 Thread Kuogee Hsieh
DPU < 7.0.0 has DPU_PINGPONG_DSC feature bit set to indicate it requires both dpu_hw_pp_setup_dsc() and dpu_hw_pp_dsc_{enable,disable}() to be executed to complete DSC configuration if DSC hardware block is present. Hence test DPU_PINGPONG_DSC feature bit and assign DSC related functions to the

[PATCH v9 6/8] drm/msm/dpu: separate DSC flush update out of interface

2023-05-15 Thread Kuogee Hsieh
Current DSC flush update is piggyback inside dpu_hw_ctl_intf_cfg_v1(). This patch separates DSC flush away from dpu_hw_ctl_intf_cfg_v1() by adding dpu_hw_ctl_update_pending_flush_dsc_v1() to handle both per DSC engine and DSC flush bits at same time to make it consistent with the location of flush

[PATCH v9 2/8] drm/msm/dpu: add DPU_PINGPONG_DSC feature bit for DPU < 7.0.0

2023-05-15 Thread Kuogee Hsieh
DPU < 7.0.0 requires the PINGPONG block to be involved during DSC setting up. Since DPU >= 7.0.0, enabling and starting the DSC encoder engine was moved to INTF with the help of the flush mechanism. Add a DPU_PINGPONG_DSC feature bit to restrict the availability of dpu_hw_pp_setup_dsc() and

[PATCH v9 1/8] drm/msm/dpu: add dsc blocks to the catalog of MSM8998 and SC8180X

2023-05-15 Thread Kuogee Hsieh
From: Abhinav Kumar There are some platforms has DSC blocks which have not been declared in the catalog. Complete DSC 1.1 support for all platforms by adding the missing blocks to MSM8998 and SC8180X. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov ---

[PATCH v9 0/8] add DSC 1.2 dpu supports

2023-05-15 Thread Kuogee Hsieh
This series adds the DPU side changes to support DSC 1.2 encoder. This was validated with both DSI DSC 1.2 panel and DP DSC 1.2 monitor. The DSI and DP parts will be pushed later on top of this change. This seriel is rebase on [1], [2] and catalog fixes from rev-4 of [3]. [1]:

Re: [PATCH v8 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-15 Thread Marijn Suijten
By the way, can we replace "relevant chipsets" in the title with "DPU >= 7.0" like the other titles? - Marijn On 2023-05-12 11:00:22, Kuogee Hsieh wrote:

Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-15 Thread Marijn Suijten
On 2023-05-15 13:58:35, Abhinav Kumar wrote: > > > > On 5/15/2023 1:07 PM, Marijn Suijten wrote: > > On 2023-05-15 11:20:02, Abhinav Kumar wrote: > >> > >> > >> > >> On 5/14/2023 2:39 PM, Marijn Suijten wrote: > >>> DSC*, and mention 1.1 explicitly (since this skips the 1.2 blocks, while > >>>

Re: [PATCH v8 7/8] drm/msm/dpu: add DSC 1.2 hw blocks for relevant chipsets

2023-05-15 Thread Marijn Suijten
On 2023-05-12 11:00:22, Kuogee Hsieh wrote: > > From: Abhinav Kumar > > Add DSC 1.2 hardware blocks to the catalog with necessary sub-block and > feature flag information. Each display compression engine (DCE) contains > dual hard slice DSC encoders so both share same base address but with >

Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-15 Thread Abhinav Kumar
On 5/15/2023 1:07 PM, Marijn Suijten wrote: On 2023-05-15 11:20:02, Abhinav Kumar wrote: On 5/14/2023 2:39 PM, Marijn Suijten wrote: DSC*, and mention 1.1 explicitly (since this skips the 1.2 blocks, while the series is clearly aimed at 1.1...). This was done for the DSC 1.2 HW block

Re: [PATCH v10 4/8] drm/msm: Add MSM-specific DSC helper methods

2023-05-15 Thread Jessica Zhang
On 5/14/2023 2:25 PM, Marijn Suijten wrote: On 2023-05-12 14:32:14, Jessica Zhang wrote: Introduce MSM-specific DSC helper methods, as some calculations are common between DP and DSC. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/msm_dsc_helper.h | 65

Re: [PATCH v8 2/2] drm/i915: Allow user to set cache at BO creation

2023-05-15 Thread Yang, Fei
> Hi Fei, > > On Fri, May 12, 2023 at 04:28:25PM -0700, fei.y...@intel.com wrote: >> From: Fei Yang >> >> To comply with the design that buffer objects shall have immutable >> cache setting through out their life cycle, {set, get}_caching ioctl's >> are no longer supported from MTL onward. With

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Marijn Suijten
On 2023-05-15 10:06:33, Kuogee Hsieh wrote: > >> +static inline int _dsc_calc_ob_max_addr(struct dpu_hw_dsc *hw_dsc, int > >> num_ss) > > Can you write out "ob" fully? > > > > These don't need to be marked "inline", same below. Please add newlines around your reply, like I did here, to make it

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Marijn Suijten
On 2023-05-15 10:46:48, Kuogee Hsieh wrote: > > Friendly request to strip/snip unneeded context (as done in this reply) > > to make it easier to spot the conversation, and replies to it. > > > > - Marijn > > Thanks for suggestion. > > How can I do that? > > just manually delete unneeded

Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-15 Thread Marijn Suijten
On 2023-05-15 11:20:02, Abhinav Kumar wrote: > > > > On 5/14/2023 2:39 PM, Marijn Suijten wrote: > > DSC*, and mention 1.1 explicitly (since this skips the 1.2 blocks, while > > the series is clearly aimed at 1.1...). This was done for the DSC 1.2 > > HW block patch after all. > > > > in

RE: [PATCH v2 RESEND 4/7] swiotlb: Dynamically allocated bounce buffers

2023-05-15 Thread Michael Kelley (LINUX)
From: Petr Tesarik Sent: Tuesday, May 9, 2023 2:18 AM > > The software IO TLB was designed with the assumption that it is not > used much, especially on 64-bit systems, so a small fixed memory > area (currently 64 MiB) is sufficient to handle the few cases which > still require a bounce buffer.

Re: [RFC PATCH v2 02/13] drm/msm/dpu: take plane rotation into account for wide planes

2023-05-15 Thread Abhinav Kumar
On 5/15/2023 12:12 PM, Dmitry Baryshkov wrote: On Mon, 15 May 2023 at 21:45, Abhinav Kumar wrote: On 5/14/2023 10:01 AM, Dmitry Baryshkov wrote: On Sat, 13 May 2023 at 01:12, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Take into account the plane rotation

Re: [RFC PATCH v2 02/13] drm/msm/dpu: take plane rotation into account for wide planes

2023-05-15 Thread Dmitry Baryshkov
On Mon, 15 May 2023 at 21:45, Abhinav Kumar wrote: > > > > On 5/14/2023 10:01 AM, Dmitry Baryshkov wrote: > > On Sat, 13 May 2023 at 01:12, Abhinav Kumar > > wrote: > >> > >> > >> > >> On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: > >>> Take into account the plane rotation and flipping when

Re: [PATCH v5 1/6] mm/gup: remove unused vmas parameter from get_user_pages()

2023-05-15 Thread Sean Christopherson
On Sun, May 14, 2023, Lorenzo Stoakes wrote: > No invocation of get_user_pages() use the vmas parameter, so remove it. > > The GUP API is confusing and caveated. Recent changes have done much to > improve that, however there is more we can do. Exporting vmas is a prime > target as the caller has

[PATCH] drm: panel-orientation-quirks: Change Air's quirk to support Air Plus

2023-05-15 Thread Maya Matuszczyk
It turned out that Aya Neo Air Plus had a different board name than expected. This patch changes Aya Neo Air's quirk to account for that, as both devices share "Air" in DMI product name. Tested on Air claiming to be an Air Pro, and on Air Plus. Signed-off-by: Maya Matuszczyk ---

Re: [RFC PATCH v2 02/13] drm/msm/dpu: take plane rotation into account for wide planes

2023-05-15 Thread Abhinav Kumar
On 5/14/2023 10:01 AM, Dmitry Baryshkov wrote: On Sat, 13 May 2023 at 01:12, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Take into account the plane rotation and flipping when calculating src positions for the wide plane parts. Signed-off-by: Dmitry Baryshkov

[PATCH v1] drm/bridge: tc358768: remove unneeded semicolon

2023-05-15 Thread Francesco Dolcini
From: Francesco Dolcini Remove unneeded stray semicolon. Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202305152341.oisjrpv6-...@intel.com/ Signed-off-by: Francesco Dolcini --- drivers/gpu/drm/bridge/tc358768.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v8 1/8] drm/msm/dpu: add dsc blocks for remaining chipsets in catalog

2023-05-15 Thread Abhinav Kumar
On 5/14/2023 2:39 PM, Marijn Suijten wrote: DSC*, and mention 1.1 explicitly (since this skips the 1.2 blocks, while the series is clearly aimed at 1.1...). This was done for the DSC 1.2 HW block patch after all. in catalog -> to catalog But it's just two platforms, you can fit MSM8998 and

Re: [PATCH v2 02/12] drm/armada: Use regular fbdev I/O helpers

2023-05-15 Thread Russell King (Oracle)
On Mon, May 15, 2023 at 07:55:44PM +0200, Sam Ravnborg wrote: > Hi Thomas, > > On Mon, May 15, 2023 at 11:40:23AM +0200, Thomas Zimmermann wrote: > > Use the regular fbdev helpers for framebuffer I/O instead of DRM's > > helpers. Armada does not use damage handling, so DRM's fbdev helpers > > are

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Dmitry Baryshkov
On Mon, 15 May 2023 at 20:47, Kuogee Hsieh wrote: > > > On 5/14/2023 2:46 PM, Marijn Suijten wrote: > > On 2023-05-12 21:19:19, Dmitry Baryshkov wrote: > > >>> +static inline void dpu_hw_dsc_bind_pingpong_blk_1_2(struct dpu_hw_dsc > >>> *hw_dsc, > >>> +

[PATCH 5.4 130/282] linux/vt_buffer.h: allow either builtin or modular for macros

2023-05-15 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 2b76ffe81e32afd6d318dc4547e2ba8c46207b77 ] Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m. This allows the ARCH macros to be the only ones defined. In file included from ../drivers/video/console/mdacon.c:37: ../arch/alpha/include/asm/vga.h:17:40:

Re: [PATCH v2 02/12] drm/armada: Use regular fbdev I/O helpers

2023-05-15 Thread Sam Ravnborg
Hi Thomas, On Mon, May 15, 2023 at 11:40:23AM +0200, Thomas Zimmermann wrote: > Use the regular fbdev helpers for framebuffer I/O instead of DRM's > helpers. Armada does not use damage handling, so DRM's fbdev helpers > are mere wrappers around the fbdev code. > > By using fbdev helpers directly

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Kuogee Hsieh
On 5/14/2023 2:46 PM, Marijn Suijten wrote: On 2023-05-12 21:19:19, Dmitry Baryshkov wrote: +static inline void dpu_hw_dsc_bind_pingpong_blk_1_2(struct dpu_hw_dsc *hw_dsc, + const enum dpu_pingpong pp) +{ + struct dpu_hw_blk_reg_map *hw;

Re: [PATCH v2 03/12] drm/exynos: Use regular fbdev I/O helpers

2023-05-15 Thread Sam Ravnborg
Hi Thomas, On Mon, May 15, 2023 at 11:40:24AM +0200, Thomas Zimmermann wrote: > Use the regular fbdev helpers for framebuffer I/O instead of DRM's > helpers. Exynos does not use damage handling, so DRM's fbdev helpers > are mere wrappers around the fbdev code. > > By using fbdev helpers directly

[PATCH 5.10 204/381] linux/vt_buffer.h: allow either builtin or modular for macros

2023-05-15 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 2b76ffe81e32afd6d318dc4547e2ba8c46207b77 ] Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m. This allows the ARCH macros to be the only ones defined. In file included from ../drivers/video/console/mdacon.c:37: ../arch/alpha/include/asm/vga.h:17:40:

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Kuogee Hsieh
On 5/14/2023 3:18 PM, Marijn Suijten wrote: On 2023-05-12 11:00:20, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at

Re: [PATCH v8 5/8] drm/msm/dpu: add support for DSC encoder v1.2 engine

2023-05-15 Thread Kuogee Hsieh
On 5/14/2023 3:18 PM, Marijn Suijten wrote: On 2023-05-12 11:00:20, Kuogee Hsieh wrote: Add support for DSC 1.2 by providing the necessary hooks to program the DPU DSC 1.2 encoder. Changes in v3: -- fixed kernel test rebot report that "__iomem *off" is declared but not used at

Re: [PATCH v10 1/8] drm/display/dsc: Add flatness and initial scale value calculations

2023-05-15 Thread Jessica Zhang
On 5/13/2023 1:28 PM, Marijn Suijten wrote: On 2023-05-12 14:32:11, Jessica Zhang wrote: Add helpers to calculate det_thresh_flatness and initial_scale_value as these calculations are defined within the DSC spec. Reviewed-by: Marijn Suijten Signed-off-by: Jessica Zhang ---

[PATCH 4.19 085/191] linux/vt_buffer.h: allow either builtin or modular for macros

2023-05-15 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 2b76ffe81e32afd6d318dc4547e2ba8c46207b77 ] Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m. This allows the ARCH macros to be the only ones defined. In file included from ../drivers/video/console/mdacon.c:37: ../arch/alpha/include/asm/vga.h:17:40:

Re: [PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-15 Thread Krzysztof Kozlowski
On 15/05/2023 18:28, neil.armstr...@linaro.org wrote: >> It's just a link stored in automated responses, what's here childish? >> It's still valid in current cycle! Look: >> >> https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 >> >> What's the

[PATCH 4.14 046/116] linux/vt_buffer.h: allow either builtin or modular for macros

2023-05-15 Thread Greg Kroah-Hartman
From: Randy Dunlap [ Upstream commit 2b76ffe81e32afd6d318dc4547e2ba8c46207b77 ] Fix build errors on ARCH=alpha when CONFIG_MDA_CONSOLE=m. This allows the ARCH macros to be the only ones defined. In file included from ../drivers/video/console/mdacon.c:37: ../arch/alpha/include/asm/vga.h:17:40:

Re: [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-15 Thread Krzysztof Kozlowski
On 15/05/2023 18:22, neil.armstr...@linaro.org wrote: >>> Meson is the only or almost the only platform making such changes. I >>> don't get why, because the conflict could be easily avoided with using >>> different names for defines in bindings and local clock. Approach of >>> having bindings

Re: [PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-15 Thread neil . armstrong
On 15/05/2023 18:22, Krzysztof Kozlowski wrote: On 15/05/2023 18:15, Neil Armstrong wrote: On 13/05/2023 20:32, Krzysztof Kozlowski wrote: On 12/05/2023 15:11, Neil Armstrong wrote: The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue

Re: [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-15 Thread neil . armstrong
On 15/05/2023 18:15, Krzysztof Kozlowski wrote: On 15/05/2023 18:13, Krzysztof Kozlowski wrote: On 15/05/2023 18:06, Neil Armstrong wrote: On 13/05/2023 20:28, Krzysztof Kozlowski wrote: On 12/05/2023 15:11, Neil Armstrong wrote: Expose VCLK2_SEL clock id and add new ids for the CTS_ENCL and

Re: [PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-15 Thread Krzysztof Kozlowski
On 15/05/2023 18:15, Neil Armstrong wrote: > On 13/05/2023 20:32, Krzysztof Kozlowski wrote: >> On 12/05/2023 15:11, Neil Armstrong wrote: >>> The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver >>> (ver 1.21a), >>> with a custom glue managing the IP resets, clock and data

[PATCH] dt-bindings: display: bridge: tc358867: Document TC358867/TC9595 compatible

2023-05-15 Thread Marek Vasut
The TC358867/TC9595 devices are compatible with the predecessor TC358767. Document compatible strings for the new devices, so they can be discerned in board DTs. Update the title to match description in the process. Signed-off-by: Marek Vasut --- Cc: Andrey Gusakov Cc: Andrzej Hajda Cc: Conor

Re: [PATCH v4 04/13] dt-bindings: display: add Amlogic MIPI DSI Host Controller bindings

2023-05-15 Thread Neil Armstrong
On 13/05/2023 20:32, Krzysztof Kozlowski wrote: On 12/05/2023 15:11, Neil Armstrong wrote: The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a), with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue on the same Amlogic

Re: [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-15 Thread Krzysztof Kozlowski
On 15/05/2023 18:13, Krzysztof Kozlowski wrote: > On 15/05/2023 18:06, Neil Armstrong wrote: >> On 13/05/2023 20:28, Krzysztof Kozlowski wrote: >>> On 12/05/2023 15:11, Neil Armstrong wrote: Expose VCLK2_SEL clock id and add new ids for the CTS_ENCL and CTS_ENCL_SEL clocks on G12A

Re: [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-15 Thread Krzysztof Kozlowski
On 15/05/2023 18:06, Neil Armstrong wrote: > On 13/05/2023 20:28, Krzysztof Kozlowski wrote: >> On 12/05/2023 15:11, Neil Armstrong wrote: >>> Expose VCLK2_SEL clock id and add new ids for the CTS_ENCL and CTS_ENCL_SEL >>> clocks on G12A compatible SoCs. >>> >>> Signed-off-by: Neil Armstrong >>>

Re: [PATCH v4 01/13] dt-bindings: clk: g12a-clkc: export VCLK2_SEL and add CTS_ENCL clock ids

2023-05-15 Thread Neil Armstrong
On 13/05/2023 20:28, Krzysztof Kozlowski wrote: On 12/05/2023 15:11, Neil Armstrong wrote: Expose VCLK2_SEL clock id and add new ids for the CTS_ENCL and CTS_ENCL_SEL clocks on G12A compatible SoCs. Signed-off-by: Neil Armstrong --- drivers/clk/meson/g12a.h | 1 -

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

2023-05-15 Thread Aradhya Bhatia
Hi Tomi, On 12-May-23 14:45, Tomi Valkeinen wrote: > On 09/05/2023 12:30, Aradhya Bhatia wrote: >> From: Nikhil Devshatwar >> >> With new connector model, mhdp bridge will not create the connector and >> SoC driver will rely on format negotiation to setup the encoder format. >> >> Support

[PATCH v13 2/2] MAINTAINERS: add maintainers for DRM LOONGSON driver

2023-05-15 Thread Sui Jingfeng
This patch add Li Yi and Sui Jingfeng as maintainer to drm/loongson driver Signed-off-by: Sui Jingfeng --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 402e26d0cdbc..8cdb75f653bc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6945,6

[PATCH v13 0/2] drm: add kms driver for loongson display controller

2023-05-15 Thread Sui Jingfeng
Loongson display controller IP has been integrated in both Loongson north bridge chipset(ls7a1000/ls7a2000) and Loongson SoCs(ls2k1000/ls2k2000), it has been even included in Loongson self-made BMC products. This display controller is a PCI device. It has two display pipes and each display pipe

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-15 Thread Julien Stephan
On Mon, May 15, 2023 at 04:22:38PM +0200, AngeloGioacchino Del Regno wrote: > Il 15/05/23 15:36, Julien Stephan ha scritto: > > On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: > > > Il 15/05/23 11:05, Julien Stephan ha scritto: > > ..snip.. > > > > +

Re: [PATCH 05/13] drm/i915/intel_cdclk: Add vdsc with bigjoiner constraints on min_cdlck

2023-05-15 Thread Ville Syrjälä
On Fri, May 12, 2023 at 11:54:09AM +0530, Ankit Nautiyal wrote: > As per Bsepc:49259, Bigjoiner BW check puts restriction on the > compressed bpp for a given CDCLK, pixelclock in cases where > Bigjoiner + DSC are used. > > Currently compressed bpp is computed first, and it is ensured that > the

Re: [PATCH] drm/amdgpu: remove unnecessary (void*) conversions

2023-05-15 Thread Dan Carpenter
On Mon, May 15, 2023 at 10:11:39AM -0400, Alex Deucher wrote: > On Mon, May 15, 2023 at 3:17 AM Dan Carpenter > wrote: > > > > On Mon, May 15, 2023 at 09:34:28AM +0800, Su Hui wrote: > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c > > >

Re: [PATCH v2 2/2] phy: mtk-mipi-csi: add driver for CSI phy

2023-05-15 Thread AngeloGioacchino Del Regno
Il 15/05/23 16:07, Julien Stephan ha scritto: On Mon, May 15, 2023 at 02:22:52PM +0200, AngeloGioacchino Del Regno wrote: +#define CSIxB_OFFSET 0x1000 What if we grab two (or three?) iospaces from devicetree? - base (global) - csi_a - csi_b That would make it possible to maybe

  1   2   >