Re: [PATCH 5/5] accel/ivpu: Mark 64 kB contiguous areas as contiguous in PTEs

2023-06-07 Thread Stanislaw Gruszka
On Thu, May 18, 2023 at 08:17:02AM -0600, Jeffrey Hugo wrote: > On 5/18/2023 7:16 AM, Stanislaw Gruszka wrote: > > From: Karol Wachowski > > > > Whenever KMD maps region larger than 64kB that is both aligned and > > contiguous, set contiguous bit (52) in MMU PTE descriptor for each page > > in

Re: [PATCH] accel/ivpu: Use struct_size()

2023-06-07 Thread Stanislaw Gruszka
On Thu, Jun 01, 2023 at 05:58:48PM +0200, Marco Pagani wrote: > > On 2023-05-29 15:28, Christophe JAILLET wrote: > > Use struct_size() instead of hand-writing it. It is less verbose, more > > robust and more informative. > > > > Signed-off-by: Christophe JAILLET > > Reviewed-by: Marco Pagani

Re: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

2023-06-07 Thread kernel test robot
/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20230607144931.v2.8.Ib1a98309c455cd7e26b931c69993d4fba33bbe15%40changeid patch subject: [PATCH v2 08/10] HID: i2c-hid: Support being a panel follower config: arc-randconfig-r021-20230607 (https://download.01.org/0day

Re: [PATCH] drm: gem: add an option for supporting the dma-coherent hardware.

2023-06-07 Thread Sui Jingfeng
Hi, On 2023/6/7 20:19, Maxime Ripard wrote: On Wed, Jun 07, 2023 at 06:30:01PM +0800, Sui Jingfeng wrote: On 2023/6/7 17:36, Paul Cercueil wrote: Hi Sui, Le mercredi 07 juin 2023 à 13:30 +0800, Sui Jingfeng a écrit : The single map_noncoherent member of struct drm_gem_dma_object may not

[PATCH v2] drm/logicvc: Kconfig: select REGMAP and REGMAP_MMIO

2023-06-07 Thread Sui Jingfeng
drm/logicvc driver is depend on REGMAP and REGMAP_MMIO, should select this two kconfig option, otherwise the driver failed to compile on platform without REGMAP_MMIO selected: ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/logicvc/logicvc-drm.ko] undefined! make[1]: ***

[PATCH v3] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-07 Thread Su Hui
Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") Signed-off-by: Su Hui --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-07 Thread Su Hui
On 2023/6/7 22:03, Doug Anderson wrote: Hi, On Tue, Jun 6, 2023 at 6:25 PM Su Hui wrote: Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") Signed-off-by: Su Hui --- drivers/gpu/drm/bridge/ti-sn65dsi86.c

Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-07 Thread Andi Shyti
Hi Dong, On Wed, Jun 07, 2023 at 12:03:50PM -0700, Zhanjun Dong wrote: > This attempts to avoid circular locking dependency between flush delayed work > and intel_gt_reset. > Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync > version for reset path, it is safe as the

Re: [v1] drm/xe/guc: Fix h2g_write usage of GUC_CTB_MSG_MAX_LEN

2023-06-07 Thread Teres Alexis, Alan Previn
On Fri, 2023-06-02 at 11:52 -0700, Alan Previn wrote: > In the ABI header, GUC_CTB_MSG_MIN_LEN is '1' because > GUC_CTB_HDR_LEN is 1. This aligns with H2G/G2H CTB specification > where all command formats are defined in units of dwords so that '1' > is a dword. Accordingly, GUC_CTB_MSG_MAX_LEN is

Re: [PATCH v6 00/12] SM63(50|75) DPU support

2023-06-07 Thread Dmitry Baryshkov
On 06/06/2023 15:43, Konrad Dybcio wrote: [skipped the changelog] --- Konrad Dybcio (12): dt-bindings: display/msm: dsi-controller-main: Add SM6350 dt-bindings: display/msm: dsi-controller-main: Add SM6375 dt-bindings: display/msm: sc7180-dpu: Describe SM6350 and SM6375

Re: [PATCH v17] drm/msm/dpu: add DSC blocks to the catalog of MSM8998

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 13:11:12 -0700, Kuogee Hsieh wrote: > Some platforms have DSC blocks which have not been declared in the catalog. > Complete DSC 1.1 support for all platforms by adding the missing blocks to > MSM8998. > > Changes in v9: > -- add MSM8998 and SC8180x to commit title > >

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 11:33:03 +0300, Dan Carpenter wrote: > The "vsync_hz" variable is unsigned int so it can't be less > than zero. The dpu_kms_get_clk_rate() function used to return a u64 > but I previously changed it to return an unsigned long and zero on > error so it matches clk_get_rate().

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dmitry Baryshkov
On 07/06/2023 17:42, Dan Carpenter wrote: On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( * frequency divided by the no. of rows (lines) in the LCDpanel. */ vsync_hz =

Re: [PATCH v17] drm/msm/dpu: add DSC blocks to the catalog of MSM8998

2023-06-07 Thread Dmitry Baryshkov
On 06/06/2023 23:11, Kuogee Hsieh wrote: From: Abhinav Kumar Some platforms have DSC blocks which have not been declared in the catalog. Complete DSC 1.1 support for all platforms by adding the missing blocks to MSM8998. Changes in v9: -- add MSM8998 and SC8180x to commit title Changes in

Re: [PATCH v6 00/12] SM63(50|75) DPU support

2023-06-07 Thread Dmitry Baryshkov
On Tue, 06 Jun 2023 14:43:51 +0200, Konrad Dybcio wrote: > v5 -> v6: > - Drop unnecessary items: level in bindings > - Use INTF_SC7180_MASK for 6375 to avoid enabling DPU_INTF_DATA_COMPRESS on > DPU6 > - Pick up tags > > v5: >

Re: [PATCH v2 1/2] drm/msm/dpu: use PINGPONG_NONE to unbind INTF from PP

2023-06-07 Thread Dmitry Baryshkov
On Sun, 04 Jun 2023 06:13:07 +0300, Dmitry Baryshkov wrote: > Currently the driver passes the PINGPONG index to > dpu_hw_intf_ops::bind_pingpong_blk() callback and uses separate boolean > flag to tell whether INTF should be bound or unbound. Simplify this by > passing PINGPONG_NONE in case of

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-07 Thread Javier Martinez Canillas
Geert Uytterhoeven writes: Hello Geert and Thomas, > Hi Thomas, > > On Wed, Jun 7, 2023 at 5:15 PM Thomas Zimmermann wrote: >> Am 07.06.23 um 10:48 schrieb Geert Uytterhoeven: >> > On Mon, Jun 5, 2023 at 4:48 PM Thomas Zimmermann >> > wrote: >> >> --- a/drivers/video/fbdev/Kconfig >> >> +++

Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property

2023-06-07 Thread Rob Herring
On Wed, 07 Jun 2023 13:55:01 +0200, Leonard Göhrs wrote: > Some MIPI DBI panels support a three wire mode (clock, chip select, > bidirectional data) that can be used to ask the panel if it is already set > up by e.g. the bootloader and can thus skip the initialization. > This enables a

Re: [PATCH v1 1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible

2023-06-07 Thread Rob Herring
On Wed, 07 Jun 2023 13:55:00 +0200, Leonard Göhrs wrote: > The Shineworld LH133K is a 1.3" 240x240px RGB LCD with a MIPI DBI > compatible SPI interface. > The initialization procedure is quite basic with the exception of > requiring inverted colors. > A basic mipi-dbi-cmd[1] script to get the

Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property

2023-06-07 Thread Rob Herring
On Wed, Jun 07, 2023 at 09:59:47PM +0200, Noralf Trønnes wrote: > > > On 6/7/23 13:55, Leonard Göhrs wrote: > > Some MIPI DBI panels support a three wire mode (clock, chip select, > > bidirectional data) that can be used to ask the panel if it is already set > > up by e.g. the bootloader and can

Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Move fbdev's file-I/O code into a separate file and contain it in > init and cleanup helpers. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- [...] > + > +#include #include here, the robot complained about:

Re: [PATCH net-next v6 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

2023-06-07 Thread Rob Herring
On Thu, Jun 01, 2023 at 03:12:27PM -0700, Justin Chen wrote: > From: Florian Fainelli > > Add a binding document for the Broadcom ASP 2.0 Ethernet > controller. > > Reviewed-by: Conor Dooley > Signed-off-by: Florian Fainelli > Signed-off-by: Justin Chen > --- > v6 > - Moved compatible

Re: [PATCH 23/30] fbdev/tdfxfb: Set i2c adapter parent to hardware device

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Use the 3dfx hardware device from the Linux device hierarchy as > parent device of the i2c adapter. Aligns the driver with the rest > of the codebase and prepares fbdev for making struct fb_info.dev > optional. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by:

Re: [PATCH 22/30] fbdev/smscufx: Detect registered fb_info from refcount

2023-06-07 Thread Javier Martinez Canillas
Thomas Zimmermann writes: > Detect registered instances of fb_info by reading the reference > counter from struct fb_info.read. Avoids looking at the dev field > and prepares fbdev for making struct fb_info.dev optional. > > Signed-off-by: Thomas Zimmermann > Cc: Steve Glendinning > --- >

Re: [RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes

2023-06-07 Thread Dmitry Baryshkov
On 08/06/2023 00:05, Abhinav Kumar wrote: On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features.  Properly utilizing all planes requires the attention of the compositor, who

[PATCH v2 10/10] arm64: dts: qcom: sc7180: Link trogdor touchscreens to the panels

2023-06-07 Thread Douglas Anderson
Let's provide the proper link from the touchscreen to the panel on trogdor devices where the touchscreen support it. This allows the OS to power sequence the touchscreen more properly. For the most part, this is just expected to marginally improve power consumption while the screen is off.

[PATCH v2 08/10] HID: i2c-hid: Support being a panel follower

2023-06-07 Thread Douglas Anderson
As talked about in the patch ("drm/panel: Add a way for other devices to follow panel state"), we really want to keep the power states of a touchscreen and the panel it's attached to in sync with each other. In that spirit, add support to i2c-hid to be a panel follower. This will let the i2c-hid

[PATCH v2 09/10] HID: i2c-hid: Do panel follower work on the system_wq

2023-06-07 Thread Douglas Anderson
Turning on an i2c-hid device can be a slow process. This is why i2c-hid devices use PROBE_PREFER_ASYNCHRONOUS. Unfortunately, when we're a panel follower the i2c-hid power up sequence now blocks the power on of the panel. Let's fix that by scheduling the work on the system_wq. Signed-off-by:

[PATCH v2 06/10] HID: i2c-hid: Rearrange probe() to power things up later

2023-06-07 Thread Douglas Anderson
In a future patch, we want to change i2c-hid not to necessarily power up the touchscreen during probe. In preparation for that, rearrange the probe function so that we put as much stuff _before_ powering up the device as possible. This change is expected to have no functional effect.

[PATCH v2 07/10] HID: i2c-hid: Make suspend and resume into helper functions

2023-06-07 Thread Douglas Anderson
In a future patch we'd like to be able to call the current i2c-hid suspend and resume functions from times other than system suspend. Move the functions higher up in the file and have them take a "struct i2c_hid" to make this simpler. We'll then add tiny wrappers of the functions for use with

[PATCH v2 05/10] HID: i2c-hid: Switch to SYSTEM_SLEEP_PM_OPS()

2023-06-07 Thread Douglas Anderson
The SYSTEM_SLEEP_PM_OPS() allows us to get rid of '#ifdef CONFIG_PM_SLEEP', as talked about in commit 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones"). This change is expected to have no functional effect. Signed-off-by: Douglas Anderson --- (no changes since v1)

[PATCH v2 04/10] of: property: fw_devlink: Add a devlink for panel followers

2023-06-07 Thread Douglas Anderson
Inform fw_devlink of the fact that a panel follower (like a touchscreen) is effectively a consumer of the panel from the purposes of fw_devlink. NOTE: this patch isn't required for correctness but instead optimizes probe order / helps avoid deferrals. Signed-off-by: Douglas Anderson --- Since

[PATCH v2 03/10] drm/panel: Add a way for other devices to follow panel state

2023-06-07 Thread Douglas Anderson
These days, it's fairly common to see panels that have touchscreens attached to them. The panel and the touchscreen can somewhat be thought of as totally separate devices and, historically, this is how Linux has treated them. However, treating them as separate isn't necessarily the best way to

[PATCH v2 02/10] drm/panel: Check for already prepared/enabled in drm_panel

2023-06-07 Thread Douglas Anderson
In a whole pile of panel drivers, we have code to make the prepare/unprepare/enable/disable callbacks behave as no-ops if they've already been called. It's silly to have this code duplicated everywhere. Add it to the core instead so that we can eventually delete it from all the drivers. Note: to

[PATCH v2 01/10] dt-bindings: HID: i2c-hid: Add "panel" property to i2c-hid backed touchscreens

2023-06-07 Thread Douglas Anderson
As talked about in the patch ("drm/panel: Add a way for other devices to follow panel state"), touchscreens that are connected to panels are generally expected to be power sequenced together with the panel they're attached to. Today, nothing provides information allowing you to find out that a

[PATCH v2 00/10] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together

2023-06-07 Thread Douglas Anderson
The big motivation for this patch series is mostly described in the patch ("drm/panel: Add a way for other devices to follow panel state"), but to quickly summarize here: for touchscreens that are connected to a panel we need the ability to power sequence the two device together. This is not a

[pull] amdgpu, radeon drm-fixes-6.4

2023-06-07 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 6.4. The following changes since commit 9561de3a55bed6bdd44a12820ba81ec416e705a7: Linux 6.4-rc5 (2023-06-04 14:04:27 -0400) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-6.4-2023-06-07 for you to

Re: [PATCH v3] drm/i915/mtl/gsc: Add a gsc_info debugfs

2023-06-07 Thread Teres Alexis, Alan Previn
On Mon, 2023-06-05 at 21:32 -0700, Ceraolo Spurio, Daniele wrote: > Add a new debugfs to dump information about the GSC. This includes: > > - the FW path and SW tracking status; > - the release, security and compatibility versions; > - the HECI1 status registers. > > Note that those are the same

RE: [PATCH v3] drm/i915: Fix a VMA UAF for multi-gt platform

2023-06-07 Thread Venkatesh Reddy, Sushma
Thank you, Nirmoy. We have verified it on Chrome. Tested-by: Sushma Venkatesh Reddy -Original Message- From: Das, Nirmoy Sent: Wednesday, June 7, 2023 1:11 AM To: intel-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org; Das, Nirmoy ; Joonas Lahtinen ; Vivi, Rodrigo ;

Re: [RFC PATCH v2 12/13] drm/msm/dpu: add support for virtual planes

2023-06-07 Thread Abhinav Kumar
On 3/20/2023 6:18 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features. Properly utilizing all planes requires the attention of the compositor, who should prefer simpler planes to YUV-supporting

Re: [Freedreno] [PATCH v3 6/7] drm/msm/dsi: Add phy configuration for MSM8226

2023-06-07 Thread Luca Weiss
On Mittwoch, 7. Juni 2023 21:46:31 CEST Jeykumar Sankaran wrote: > On 6/1/2023 10:00 AM, Luca Weiss wrote: > > MSM8226 uses a modified PLL lock sequence compared to MSM8974, which is > > based on the function dsi_pll_enable_seq_m in the msm-3.10 kernel. > > > > Worth noting that the msm-3.10

Re: [PATCH] mm: fix hugetlb page unmap count balance issue

2023-06-07 Thread Andrew Morton
On Wed, 7 Jun 2023 13:53:10 -0700 Mike Kravetz wrote: > > > > BUGs aren't good. Can we please find a way to push this along? > > > > Have we heard anything from any udmabuf people? > > > > I have not heard anything. When this issue popped up, it took me by surprise. > > udmabuf maintainer

Re: [PATCH 29/30] fbdev/core: Rework fb init code

2023-06-07 Thread Sam Ravnborg
Hi Thomas. On Mon, Jun 05, 2023 at 04:48:11PM +0200, Thomas Zimmermann wrote: > Init the class "graphics" before the rest of fbdev. Later steps, such > as the sysfs code, depend on the class. Also arrange the module's exit > code in reverse order. > > Unexport the global variable fb_class, which

Re: [PATCH 28/30] fbdev/core: Move file-I/O code into separate file

2023-06-07 Thread Sam Ravnborg
Hi Thomas. On Mon, Jun 05, 2023 at 04:48:10PM +0200, Thomas Zimmermann wrote: > Move fbdev's file-I/O code into a separate file and contain it in > init and cleanup helpers. No functional changes. > > Signed-off-by: Thomas Zimmermann Consider moving the two helps as noted below. With or without

Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property

2023-06-07 Thread Noralf Trønnes
On 6/7/23 13:55, Leonard Göhrs wrote: > Some MIPI DBI panels support a three wire mode (clock, chip select, > bidirectional data) that can be used to ask the panel if it is already set > up by e.g. the bootloader and can thus skip the initialization. > This enables a flicker-free boot. > >

Re: [PATCH 27/30] fbdev/core: Move procfs code to separate file

2023-06-07 Thread Sam Ravnborg
Hi Thomas, On Mon, Jun 05, 2023 at 04:48:09PM +0200, Thomas Zimmermann wrote: > Move fbdev's procfs code into a separate file and contain it in > init and cleanup helpers. No functional changes. Maybe add: Delete the unused for_each_registered_fb while touching the code. The change to use

Re: [PATCH drm-next v4 04/14] drm: debugfs: provide infrastructure to dump a DRM GPU VA space

2023-06-07 Thread kernel test robot
Hi Danilo, kernel test robot noticed the following build warnings: [auto build test WARNING on 33a86170888b7e4aa0cea94ebb9c67180139cea9] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-execution-context-for-GEM-buffers-v4/20230607-063442 base

Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-07 Thread John Harrison
On 6/7/2023 12:03, Zhanjun Dong wrote: This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset. Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle

Re: [Freedreno] [PATCH v3 6/7] drm/msm/dsi: Add phy configuration for MSM8226

2023-06-07 Thread Jeykumar Sankaran
On 6/1/2023 10:00 AM, Luca Weiss wrote: MSM8226 uses a modified PLL lock sequence compared to MSM8974, which is based on the function dsi_pll_enable_seq_m in the msm-3.10 kernel. Worth noting that the msm-3.10 downstream kernel also will try other sequences in case this one doesn't work, but

Re: [PATCH 26/30] fbdev/core: Add fb_device_{create,destroy}()

2023-06-07 Thread Sam Ravnborg
Hi Thomas, On Mon, Jun 05, 2023 at 04:48:08PM +0200, Thomas Zimmermann wrote: > Move the logic to create and destroy fbdev devices into the new > helpers fb_device_create() and fb_device_destroy(). > > There was a call to fb_cleanup_device() in do_unregister_framebuffer() > that was too late.

Re: [PATCH 25/30] fbdev/core: Move framebuffer and backlight helpers into separate files

2023-06-07 Thread Sam Ravnborg
Hi Thomas, On Mon, Jun 05, 2023 at 04:48:07PM +0200, Thomas Zimmermann wrote: > Move framebuffer and backlight helpers into separate files. Leave > fbsysfs.c to sysfs-related code. No functional changes. > > The framebuffer helpers are not in fbmem.c because they are under > GPL-2.0-or-later

Re: [PATCH] mm: fix hugetlb page unmap count balance issue

2023-06-07 Thread David Hildenbrand
On 17.05.23 00:34, Mike Kravetz wrote: On 05/15/23 10:04, Mike Kravetz wrote: On 05/12/23 16:29, Mike Kravetz wrote: On 05/12/23 14:26, James Houghton wrote: On Fri, May 12, 2023 at 12:20 AM Junxiao Chang wrote: This alone doesn't fix mapcounting for PTE-mapped HugeTLB pages. You need

Re: [PATCH 24/30] fbdev/core: Pass Linux device to pm_vt_switch_*() functions

2023-06-07 Thread Sam Ravnborg
On Mon, Jun 05, 2023 at 04:48:06PM +0200, Thomas Zimmermann wrote: > Pass the Linux device to pm_vt_switch_*() instead of the virtual > fbdev device. Prepares fbdev for making struct fb_info.dev optional. > > The type of device that is passed to the PM functions does not matter > much. It is only

Re: [PATCH v2 1/5] drm/i915/gsc: fixes and updates for GSC memory allocation

2023-06-07 Thread Teres Alexis, Alan Previn
On Mon, 2023-06-05 at 19:23 -0700, Ceraolo Spurio, Daniele wrote: > A few fixes/updates are required around the GSC memory allocation and it > is easier to do them all at the same time. The changes are as follows: > > 1 - Switch the memory allocation to stolen memory. We need to avoid > accesses

Re: [PATCH] drm: rcar-du: Replace DRM_INFO() with drm_info()

2023-06-07 Thread Kieran Bingham
Quoting Laurent Pinchart (2023-05-30 10:26:39) > drm_info() adds proper context to the kernel log message, as it receives > the drm_device pointer. It is thus preferred over DRM_INFO(). Replace > the latter with the former. > > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham >

[PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-07 Thread Zhanjun Dong
This attempts to avoid circular locking dependency between flush delayed work and intel_gt_reset. Switched from cancel_delayed_work_sync to cancel_delayed_work, the non-sync version for reset path, it is safe as the worker has the trylock code to handle the lock; Meanwhile keep the sync version

Re: [PATCH] mm: fix hugetlb page unmap count balance issue

2023-06-07 Thread Andrew Morton
On Tue, 16 May 2023 15:34:40 -0700 Mike Kravetz wrote: > On 05/15/23 10:04, Mike Kravetz wrote: > > On 05/12/23 16:29, Mike Kravetz wrote: > > > On 05/12/23 14:26, James Houghton wrote: > > > > On Fri, May 12, 2023 at 12:20 AM Junxiao Chang > > > > wrote: > > > > > > > > This alone doesn't

Re: [PATCH 1/1] drm/bridge: Silence error messages upon probe deferral

2023-06-07 Thread Laurent Pinchart
Hi Alexander, On Wed, Jun 07, 2023 at 01:26:03PM +0200, Alexander Stein wrote: > Am Dienstag, 6. Juni 2023, 17:12:29 CEST schrieb Laurent Pinchart: > > On Tue, Jun 06, 2023 at 04:48:33PM +0200, Alexander Stein wrote: > > > When -EPROBE_DEFER is returned do not raise an error, but silently return

Re: [PATCH v6 05/12] dt-bindings: display/msm: Add SM6375 MDSS

2023-06-07 Thread Krzysztof Kozlowski
On 06/06/2023 14:43, Konrad Dybcio wrote: > Document the SM6375 MDSS. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm6375-mdss.yaml | 215 > + > 1 file changed, 215 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v6 04/12] dt-bindings: display/msm: Add SM6350 MDSS

2023-06-07 Thread Krzysztof Kozlowski
On 06/06/2023 14:43, Konrad Dybcio wrote: > Document the SM6350 MDSS. > > Signed-off-by: Konrad Dybcio > --- > .../bindings/display/msm/qcom,sm6350-mdss.yaml | 213 > + > 1 file changed, 213 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: PROBLEM: AMD Ryzen 9 7950X iGPU - Blinking Issue

2023-06-07 Thread Alex Deucher
On Wed, Jun 7, 2023 at 4:42 AM Felix Richter wrote: > > Hi Guys, > > so I checked, the kernel I am running has this commit > (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > /commit/?id=08da182175db4c7f80850354849d95f2670e8cd9) applied already! > >

Re: [PATCH v1 1/8] dt-bindings: display: panel: mipi-dbi-spi: add shineworld lh133k compatible

2023-06-07 Thread Conor Dooley
On Wed, Jun 07, 2023 at 01:55:00PM +0200, Leonard Göhrs wrote: > The Shineworld LH133K is a 1.3" 240x240px RGB LCD with a MIPI DBI > compatible SPI interface. > The initialization procedure is quite basic with the exception of > requiring inverted colors. > A basic mipi-dbi-cmd[1] script to get

Re: [PATCH v1 2/8] dt-bindings: display: panel: mipi-dbi-spi: add spi-3wire property

2023-06-07 Thread Conor Dooley
On Wed, Jun 07, 2023 at 01:55:01PM +0200, Leonard Göhrs wrote: > Some MIPI DBI panels support a three wire mode (clock, chip select, > bidirectional data) that can be used to ask the panel if it is already set > up by e.g. the bootloader and can thus skip the initialization. > This enables a

Re: [Intel-gfx] [PATCH] drm/i915: Avoid circular locking dependency when flush delayed work on gt reset

2023-06-07 Thread John Harrison
On 6/6/2023 10:53, John Harrison wrote: On 6/5/2023 20:00, Zhanjun Dong wrote: This attemps to avoid circular locing dependency between flush delayed work and intel_gt_reset. locing -> locking WARNING: possible circular locking dependency detected 6.4.0-rc1-drmtip_1340-g31e3463b0edb+ #1

Re: [PATCH] drm: gem: add an option for supporting the dma-coherent hardware.

2023-06-07 Thread Sui Jingfeng
Hi, On 2023/6/8 00:12, Paul Cercueil wrote: Hi Sui, Le mercredi 07 juin 2023 à 22:38 +0800, Sui Jingfeng a écrit : Hi,  welcome to discussion. I have limited skills in manipulating English. It may not express what I'm really means in the short time. Part of word in the sentence may not as

[linux-next:master] BUILD REGRESSION abbd8bb42915d9ed06df11b430bf4ecb3d8ac5ad

2023-06-07 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: abbd8bb42915d9ed06df11b430bf4ecb3d8ac5ad Add linux-next specific files for 20230607 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202305132244.dwzbucud-...@intel.com https

Re: [PATCH] drm: gem: add an option for supporting the dma-coherent hardware.

2023-06-07 Thread Paul Cercueil
Hi Sui, Le mercredi 07 juin 2023 à 22:38 +0800, Sui Jingfeng a écrit : > Hi,  welcome to discussion. > > > I have limited skills in manipulating English. > > It may not express what I'm really means in the short time. > > Part of word in the sentence may not as accurate as your. > > Well,

Re: [PATCH v6 00/13] Enable Colorspace connector property in amdgpu

2023-06-07 Thread Simon Ser
Thanks! All of the core DRM patches (1-6) are Reviewed-by: Simon Ser

Re: [PATCH drm-next v4 12/14] drm/nouveau: nvkm/vmm: implement raw ops to manage uvmm

2023-06-07 Thread kernel test robot
Hi Danilo, kernel test robot noticed the following build warnings: [auto build test WARNING on 33a86170888b7e4aa0cea94ebb9c67180139cea9] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-execution-context-for-GEM-buffers-v4/20230607-063442 base

Re: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-07 Thread Andi Shyti
Hi Fei, On Tue, Jun 06, 2023 at 12:00:42PM +0200, Andi Shyti wrote: > From: Fei Yang > > To comply with the design that buffer objects shall have immutable > cache setting through out their life cycle, {set, get}_caching ioctl's > are no longer supported from MTL onward. With that change

Re: [PATCH drm-next v4 09/14] drm/nouveau: fence: separate fence alloc and emit

2023-06-07 Thread kernel test robot
Hi Danilo, kernel test robot noticed the following build errors: [auto build test ERROR on 33a86170888b7e4aa0cea94ebb9c67180139cea9] url: https://github.com/intel-lab-lkp/linux/commits/Danilo-Krummrich/drm-execution-context-for-GEM-buffers-v4/20230607-063442 base

Re: [PATCH v2] drm/panel-edp: Add AUO B116XAB01.4 edp panel entry

2023-06-07 Thread Doug Anderson
Hi, On Wed, Jun 7, 2023 at 8:06 AM Laura Nao wrote: > > Add a panel entry for the AUO B116XAB01.4 edp panel, found in the Acer > Chromebook Spin 311 (CP311-3H) laptop. > > Signed-off-by: Laura Nao > --- > > Changes in v2: > - Sorted by product ID > > drivers/gpu/drm/panel/panel-edp.c | 1 + >

[PATCH v6 10/13] drm/amd/display: Send correct DP colorspace infopacket

2023-06-07 Thread Harry Wentland
Look at connector->colorimetry to determine output colorspace. We don't want to impact current SDR behavior, so DRM_MODE_COLORIMETRY_DEFAULT preserves current behavior. Also add support to explicitly set BT601 and BT709. v4: - Roll support for BT709 and BT601 into this patch - Add default case

[PATCH v6 12/13] drm/amd/display: Add debugfs for testing output colorspace

2023-06-07 Thread Harry Wentland
In order to IGT test colorspace we'll want to print the currently enabled colorspace on a stream. We add a new debugfs to do so, using the same scheme as current bpc reporting. This might also come in handy when debugging display issues. v4: - Fix function doc comment - Fix sRGB debug print

[PATCH v6 13/13] drm/amd/display: Refactor avi_info_frame colorimetry determination

2023-06-07 Thread Harry Wentland
From: Joshua Ashton Replace the messy two if-else chains here that were on the same value with a switch on the enum. Signed-off-by: Joshua Ashton Signed-off-by: Harry Wentland Reviewed-by: Harry Wentland Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton

[PATCH v6 04/13] drm/connector: Use common colorspace_names array

2023-06-07 Thread Harry Wentland
We an use bitfields to track the support ones for HDMI and DP. This allows us to print colorspaces in a consistent manner without needing to know whether we're dealing with DP or HDMI. v4: - Rename _MAX to _COUNT and leave comment to indicate it's not a valid value - Fix misplaced function doc

[PATCH v6 03/13] drm/connector: Pull out common create_colorspace_property code

2023-06-07 Thread Harry Wentland
Signed-off-by: Harry Wentland Reviewed-by: Sebastian Wick Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua Ashton Cc: Jani Nikula Cc: Simon Ser Cc: Ville Syrjälä Cc: Melissa Wen Cc:

[PATCH v6 11/13] drm/amd/display: Always set crtcinfo from create_stream_for_sink

2023-06-07 Thread Harry Wentland
From: Joshua Ashton Given that we always pass dm_state into here now, this won't ever trigger anymore. This is needed for we will always fail mode validation with invalid clocks or link bandwidth errors. Signed-off-by: Joshua Ashton Signed-off-by: Harry Wentland Reviewed-by: Harry Wentland

[PATCH v6 09/13] drm/amd/display: Signal mode_changed if colorspace changed

2023-06-07 Thread Harry Wentland
We need to signal mode_changed to make sure we update the output colorspace. v2: No need to call drm_hdmi_avi_infoframe_colorimetry as DC does its own infoframe packing. Signed-off-by: Harry Wentland Reviewed-by: Leo Li Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick

[PATCH v6 08/13] drm/amd/display: Register Colorspace property for DP and HDMI

2023-06-07 Thread Harry Wentland
We want compositors to be able to set the output colorspace on DP and HDMI outputs, based on the caps reported from the receiver via EDID. Signed-off-by: Harry Wentland Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc: Simon

[PATCH v6 06/13] drm/connector: Allow drivers to pass list of supported colorspaces

2023-06-07 Thread Harry Wentland
Drivers might not support all colorspaces defined in dp_colorspaces and hdmi_colorspaces. This results in undefined behavior when userspace is setting an unsupported colorspace. Allow drivers to pass the list of supported colorspaces when creating the colorspace property. v2: - Use 0 to

[PATCH v6 07/13] drm/amd/display: Always pass connector_state to stream validation

2023-06-07 Thread Harry Wentland
We need the connector_state for colorspace and scaling information and can get it from connector->state. Signed-off-by: Harry Wentland Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Joshua Ashton Cc: Simon Ser Cc: Melissa Wen Cc:

[PATCH v6 05/13] drm/connector: Print connector colorspace in state debugfs

2023-06-07 Thread Harry Wentland
v3: Fix kerneldocs (kernel test robot) v4: Avoid returning NULL from drm_get_colorspace_name Signed-off-by: Harry Wentland Reviewed-by: Sebastian Wick Reviewed-by: Joshua Ashton Cc: Pekka Paalanen Cc: Sebastian Wick Cc: vitaly.pros...@amd.com Cc: Uma Shankar Cc: Ville Syrjälä Cc: Joshua

[PATCH v6 02/13] drm/connector: Add enum documentation to drm_colorspace

2023-06-07 Thread Harry Wentland
From: Joshua Ashton To match the other enums, and add more information about these values. v2: - Specify where an enum entry comes from - Clarify DEFAULT and NO_DATA behavior - BT.2020 CYCC is "constant luminance" - correct type for BT.601 v4: - drop DP/HDMI clarifications that might

[PATCH v6 01/13] drm/connector: Convert DRM_MODE_COLORIMETRY to enum

2023-06-07 Thread Harry Wentland
This allows us to use strongly typed arguments. v2: - Bring NO_DATA back - Provide explicit enum values v3: - Drop unnecessary '&' from kerneldoc (emersion) v4: - Fix Normal Colorimetry comment Signed-off-by: Harry Wentland Reviewed-by: Simon Ser Reviewed-by: Sebastian Wick Reviewed-by:

[PATCH v6 00/13] Enable Colorspace connector property in amdgpu

2023-06-07 Thread Harry Wentland
This patchset is based on Joshua's previous patchset [1], as well as my previous patchset [2]. It is - enabling support for the colorspace property in amdgpu, as well as - allowing drivers to specify the supported set of colorspaces, and Colorspace, Infoframes, and YCbCr matrix

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-07 Thread Geert Uytterhoeven
Hi Thomas, On Wed, Jun 7, 2023 at 5:15 PM Thomas Zimmermann wrote: > Am 07.06.23 um 10:48 schrieb Geert Uytterhoeven: > > On Mon, Jun 5, 2023 at 4:48 PM Thomas Zimmermann > > wrote: > >> --- a/drivers/video/fbdev/Kconfig > >> +++ b/drivers/video/fbdev/Kconfig > >> @@ -57,6 +57,15 @@ config

Re: [PATCH 30/30] fbdev: Make support for userspace interfaces configurable

2023-06-07 Thread Thomas Zimmermann
Hi Am 07.06.23 um 10:48 schrieb Geert Uytterhoeven: Hi Thomas, Thanks for your patch! On Mon, Jun 5, 2023 at 4:48 PM Thomas Zimmermann wrote: Add Kconfig option CONFIG_FB_DEVICE and make the virtual fbdev device optional. If the new option has not been selected, fbdev does not create a

[PATCH v4 1/3] dt-bindings: add fannal vendor prefix

2023-06-07 Thread Paulo Pavacic
Fannal is a one-stop-solution provider for touch displays in industrial application, committed to delivering a variety of professional high-quality products and technical services globally. Website: www.fannal.com Signed-off-by: Paulo Pavacic Acked-by: Krzysztof Kozlowski ---

[PATCH v4 3/3] drm/panel-fannal-c3004: Add fannal c3004 DSI panel

2023-06-07 Thread Paulo Pavacic
Fannal C3004 is a 480x800 display made by fannal that requires DCS initialization sequences. Signed-off-by: Paulo Pavacic --- v4 changelog: - removal of blank lines, code wrapping changes - reset pin initialization handling changes v3 changelog: - formatting and style changes - remove

[PATCH v4 2/3] dt-bindings: display: panel: add fannal,c3004

2023-06-07 Thread Paulo Pavacic
Added fannal to vendor-prefixes and dt bindings for Fannal C3004. Fannal C3004 is a 480x800 MIPI DSI Panel which requires DCS initialization sequences with certain delays between certain commands. Signed-off-by: Paulo Pavacic Reviewed-by: Krzysztof Kozlowski --- v4 changelog: - removed

[PATCH v4 0/3] drm/panel: add fannal c3004 panel

2023-06-07 Thread Paulo Pavacic
Fannal C3004 is a 2 lane MIPI DSI 480x800 panel which requires initialization with DSI DCS commands. After few initialization commands delay is required. Paulo Pavacic (3): dt-bindings: add fannal vendor prefix dt-bindings: display: panel: add fannal,c3004 drm/panel-fannal-c3004: Add

Re: [PATCH 2/2] drm: bridge: tc358767: give VSDELAY some positive value

2023-06-07 Thread Marek Vasut
On 6/7/23 14:53, Lucas Stach wrote: Am Freitag, dem 02.06.2023 um 23:34 +0200 schrieb Marek Vasut: On 6/2/23 21:15, Lucas Stach wrote: From: David Jander The documentation is not clear about how this delay works. Empirical tests have shown that with a VSDELAY of 0, the first scanline is not

[PATCH v2] drm/panel-edp: Add AUO B116XAB01.4 edp panel entry

2023-06-07 Thread Laura Nao
Add a panel entry for the AUO B116XAB01.4 edp panel, found in the Acer Chromebook Spin 311 (CP311-3H) laptop. Signed-off-by: Laura Nao --- Changes in v2: - Sorted by product ID drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v17 1/1] drm/i915: Allow user to set cache at BO creation

2023-06-07 Thread Andi Shyti
On Tue, Jun 06, 2023 at 12:00:42PM +0200, Andi Shyti wrote: > From: Fei Yang > > To comply with the design that buffer objects shall have immutable > cache setting through out their life cycle, {set, get}_caching ioctl's > are no longer supported from MTL onward. With that change caching >

Re: [PATCH] drm/msm/dpu: tidy up some error checking

2023-06-07 Thread Dan Carpenter
On Tue, Jun 06, 2023 at 10:23:46PM +0200, Marijn Suijten wrote: > > @@ -359,8 +359,8 @@ static void dpu_encoder_phys_cmd_tearcheck_config( > > * frequency divided by the no. of rows (lines) in the LCDpanel. > > */ > > vsync_hz = dpu_kms_get_clk_rate(dpu_kms, "vsync"); > > - if

Re: [PATCH] drm: gem: add an option for supporting the dma-coherent hardware.

2023-06-07 Thread Sui Jingfeng
Hi,  welcome to discussion. I have limited skills in manipulating English. It may not express what I'm really means in the short time. Part of word in the sentence may not as accurate as your. Well, please don't misunderstand, I'm not doing the rude to you. I will explain it with more

Re: [PATCH V8 0/7] drm: bridge: samsung-dsim: Support variable clocking

2023-06-07 Thread Adam Ford
On Wed, Jun 7, 2023 at 8:27 AM Adam Ford wrote: > > On Wed, Jun 7, 2023 at 8:15 AM Rasmus Villemoes > wrote: > > > > On 26/05/2023 05.05, Adam Ford wrote: > > > This series fixes the blanking pack size and the PMS calculation. It then > > > adds support to allows the DSIM to dynamically DPHY

Re: [PATCH 00/30] fbdev: Make userspace interfaces optional

2023-06-07 Thread Markus Elfring
> Ha! It says 'distrobutions'. Do you tend to prefer any distributions? Regards, Markus

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: Avoid possible buffer overflow

2023-06-07 Thread Doug Anderson
Hi, On Tue, Jun 6, 2023 at 6:25 PM Su Hui wrote: > > Smatch error:buffer overflow 'ti_sn_bridge_refclk_lut' 5 <= 5. > > Fixes: cea86c5bb442 ("drm/bridge: ti-sn65dsi86: Implement the pwm_chip") > Signed-off-by: Su Hui > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +- > 1 file changed, 1

  1   2   3   >