Re: [PATCH v2] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Pekka Paalanen
On Fri, 25 Aug 2023 10:55:35 +0200 Jocelyn Falempe wrote: > After discussions on IRC, the consensus is that the DRM drivers should > avoid software color conversion, and only advertise the formats supported > by hardware. > Update the doc accordingly so that the rule and exceptions are clear for

Re: [PATCH v7 09/11] drm/mediatek: dp: Add support for embedded DisplayPort aux-bus

2023-08-25 Thread Michael Walle
Hi AngeloGioacchino, > For the eDP case we can support using aux-bus on MediaTek DP: this > gives us the possibility to declare our panel as generic "panel-edp" > which will automatically configure the timings and available modes > via the EDID that we read from it. > > To do this, move the panel

[RFC v2 5/5] drm/xe/RAS: send multicast event on occurrence of an error

2023-08-25 Thread Aravind Iddamsetty
Whenever a correctable or an uncorrectable error happens an event is sent to the corresponding listeners of these groups. Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/xe_irq.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_

[RFC v2 4/5] drm/netlink: Define multicast groups

2023-08-25 Thread Aravind Iddamsetty
Netlink subsystem supports event notifications to userspace. we define two multicast groups for correctable and uncorrectable errors to which userspace can subscribe and be notified when any of those errors happen. The group names are local to the driver's genl netlink family. Signed-off-by: Aravi

[RFC v2 1/5] drm/netlink: Add netlink infrastructure

2023-08-25 Thread Aravind Iddamsetty
Define the netlink registration interface and commands, attributes that can be commonly used across by drm drivers. This patch intends to use the generic netlink family to expose various stats of device. At present it defines some commands that shall be used to expose RAS error counters. v2: defin

[RFC v2 2/5] drm/xe/RAS: Register netlink capability

2023-08-25 Thread Aravind Iddamsetty
Register netlink capability with the DRM and register the driver callbacks to DRM RAS netlink commands. v2: Move the netlink registration parts to DRM susbsytem (Tomer Tayar) Cc: Tomer Tayar Signed-off-by: Aravind Iddamsetty --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/x

[RFC v2 3/5] drm/xe/RAS: Expose the error counters

2023-08-25 Thread Aravind Iddamsetty
We expose the various error counters supported on a hardware via genl subsytem through the registered commands to userspace. The DRM_RAS_CMD_QUERY lists the error names with config id, DRM_RAD_CMD_READ_ONE returns the counter value for the requested config id and the DRM_RAS_CMD_READ_ALL lists the

[RFC v2 0/5] Proposal to use netlink for RAS and Telemetry across drm subsystem

2023-08-25 Thread Aravind Iddamsetty
Respin on old xe base, would like to get agreement on the design first. Our hardware supports RAS(Reliability, Availability, Serviceability) by reporting the errors to the host, which the KMD processes and exposes a set of error counters which can be used by observability tools to take correctiv

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-25 Thread Pekka Paalanen
On Fri, 25 Aug 2023 15:56:18 +0800 Hsia-Jun Li wrote: > On 8/25/23 15:40, Pekka Paalanen wrote: > > Subject: > > Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers > > From: > > Pekka Paalanen > > Date: > > 8/25/23, 15:40 > > > > To: > > Hsia-Jun Li > > CC: > > Tomasz Figa , linux...

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-25 Thread Lazar, Lijo
On 8/25/2023 4:48 PM, Yadav, Arvind wrote: On 8/22/2023 6:16 PM, Lazar, Lijo wrote: On 8/22/2023 5:41 PM, Yadav, Arvind wrote: Hi Lijo, The *_set function will set the GPU power profile and the *_put function will  schedule the smu_delayed_work task after 100ms delay. This smu_delayed_w

Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-25 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm/drm-next next-20230825] [cannot apply to drm-intel/for-linux-next-fixes drm-misc/drm-misc-next linus/master v6.5-rc7] [If your patch is applied to the

Re: [Intel-gfx] [PATCH 4/6] drm/cec: add drm_dp_cec_attach() as the non-edid version of set edid

2023-08-25 Thread kernel test robot
Hi Jani, kernel test robot noticed the following build errors: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on drm/drm-next next-20230825] [cannot apply to drm-intel/for-linux-next-fixes drm-misc/drm-misc-next linus/master v6.5-rc7] [If your patch is applied to the

Re: [PATCH] drm/repaper: fix -Wvoid-pointer-to-enum-cast warning

2023-08-25 Thread Noralf Trønnes
On 8/16/23 21:55, Justin Stitt wrote: > When building with clang 18 I see the following warning: > | drivers/gpu/drm/tiny/repaper.c:952:11: warning: cast to smaller > integer > | type 'enum repaper_model' from 'const void *' > [-Wvoid-pointer-to-enum-cast] > | 952 |

Re: [PATCH v2 3/7] drm/amdgpu: Add new function to put GPU power profile

2023-08-25 Thread Yadav, Arvind
On 8/22/2023 6:16 PM, Lazar, Lijo wrote: On 8/22/2023 5:41 PM, Yadav, Arvind wrote: Hi Lijo, The *_set function will set the GPU power profile and the *_put function will  schedule the smu_delayed_work task after 100ms delay. This smu_delayed_work task will clear a GPU power profile if an

Re: [QUESTION] drm/crtc: precondition for drm_crtc_init_with_planes()

2023-08-25 Thread Maxime Ripard
On Fri, Aug 25, 2023 at 01:18:46PM +0300, e.orl...@ispras.ru wrote: > Documentation for drm_crtc_init_with_planes() in > drivers/gpu/drm/drm_crtc.c states: «The crtc structure should not be > allocated with devm_kzalloc()». > > However, in drivers/gpu/drm/stm/ltdc.c > the 2nd argument of the funct

Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-25 Thread Laurent Pinchart
On Fri, Aug 25, 2023 at 06:48:45AM +0300, Andy Shevchenko wrote: > On Thu, Aug 24, 2023 at 9:26 PM Laurent Pinchart wrote: > > On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote: > > ... > > > I wonder, as the device can only be instantiated from OF, should we add > > > > depends on

[QUESTION] drm/crtc: precondition for drm_crtc_init_with_planes()

2023-08-25 Thread e . orlova
Documentation for drm_crtc_init_with_planes() in drivers/gpu/drm/drm_crtc.c states: «The crtc structure should not be allocated with devm_kzalloc()». However, in drivers/gpu/drm/stm/ltdc.c the 2nd argument of the function drm_crtc_init_with_planes() is a structure allocated with devm_kzalloc() A

Re: [PATCH v2] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Simon Ser
It would be nicer to have the linked email as proper docs, but that sounds like a bunch more work. In any case: Acked-by: Simon Ser

Re: [PATCH] habanalabs/goya: refactor deprecated strncpy

2023-08-25 Thread Stanislaw Gruszka
On Thu, Aug 24, 2023 at 08:49:11PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `strscpy` [2] due to the fact that it > guarantees NUL-termination on its destination buffer argument which is > _not_ the case f

Re: [PATCH] habanalabs/gaudi2: refactor deprecated strncpy

2023-08-25 Thread Stanislaw Gruszka
On Thu, Aug 24, 2023 at 08:45:08PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `strscpy` [2] due to the fact that it > guarantees NUL-termination on its destination buffer argument which is > _not_ the case f

Re: [PATCH] habanalabs/gaudi: refactor deprecated strncpy

2023-08-25 Thread Stanislaw Gruszka
On Thu, Aug 24, 2023 at 08:41:26PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `strscpy` [2] due to the fact that it > guarantees NUL-termination on its destination buffer argument which is > _not_ the case f

Re: [PATCH] accel/habanalabs: refactor deprecated strncpy

2023-08-25 Thread Stanislaw Gruszka
On Wed, Aug 23, 2023 at 12:23:08AM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `strscpy` [2] due to the fact that it > guarantees NUL-termination on its destination buffer argument which is > _not_ the case f

Re: [PATCH] accel/ivpu: refactor deprecated strncpy

2023-08-25 Thread Stanislaw Gruszka
On Thu, Aug 24, 2023 at 09:20:25PM +, Justin Stitt wrote: > `strncpy` is deprecated for use on NUL-terminated destination strings [1]. > > A suitable replacement is `strscpy` [2] due to the fact that it > guarantees NUL-termination on its destination buffer argument which is > _not_ the case f

[PATCH v2] drm/plane: Add documentation about software color conversion.

2023-08-25 Thread Jocelyn Falempe
After discussions on IRC, the consensus is that the DRM drivers should avoid software color conversion, and only advertise the formats supported by hardware. Update the doc accordingly so that the rule and exceptions are clear for everyone. Signed-off-by: Jocelyn Falempe --- drivers/gpu/drm/drm_

[V10 8/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.7

2023-08-25 Thread Evan Quan
Fulfill the SMU13.0.7 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c | 59 +++ 1 file changed, 59 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_7_ppt.c

[V10 6/8] drm/amd/pm: add flood detection for wbrf events

2023-08-25 Thread Evan Quan
To protect PMFW from being overloaded. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 31 +++ drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 7 + 2 files changed, 32 insertions(+), 6 deletions(-) diff --git a/dr

[V10 7/8] drm/amd/pm: enable Wifi RFI mitigation feature support for SMU13.0.0

2023-08-25 Thread Evan Quan
Fulfill the SMU13.0.0 support for Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h | 3 + drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h | 3 +- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 3 + .../gpu/d

[V10 5/8] drm/amd/pm: setup the framework to support Wifi RFI mitigation feature

2023-08-25 Thread Evan Quan
With WBRF feature supported, as a driver responding to the frequencies, amdgpu driver is able to do shadow pstate switching to mitigate possible interference(between its (G-)DDR memory clocks and local radio module frequency bands used by Wifi 6/6e/7). Signed-off-by: Evan Quan Reviewed-by: Mario

[V10 4/8] drm/amd/pm: update driver_if and ppsmc headers for coming wbrf feature

2023-08-25 Thread Evan Quan
Add those data structures to support Wifi RFI mitigation feature. Signed-off-by: Evan Quan Reviewed-by: Mario Limonciello --- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_0.h | 14 +- .../pm/swsmu/inc/pmfw_if/smu13_driver_if_v13_0_7.h | 14 +- .../amd/pm/swsmu/inc/pmfw

[V10 1/8] ACPI: Add support for AMD ACPI based Wifi band RFI mitigation feature

2023-08-25 Thread Evan Quan
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate this, AMD has introduced a mechanism that devices can

[V10 3/8] wifi: mac80211: Add support for WBRF features

2023-08-25 Thread Evan Quan
To support the WBRF mechanism, Wifi adapters utilized in the system must register the frequencies in use(or unregister those frequencies no longer used) via the dedicated calls. So that, other drivers responding to the frequencies can take proper actions to mitigate possible interference. Co-devel

[V10 2/8] cfg80211: expose nl80211_chan_width_to_mhz for wide sharing

2023-08-25 Thread Evan Quan
The newly added WBRF feature needs this interface for channel width calculation. Signed-off-by: Evan Quan -- v8->v9: - correct typo(Mhz -> MHz) (Johnson) --- include/net/cfg80211.h | 8 net/wireless/chan.c| 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/incl

[V10 0/8] Enable Wifi RFI interference mitigation feature support

2023-08-25 Thread Evan Quan
Due to electrical and mechanical constraints in certain platform designs there may be likely interference of relatively high-powered harmonics of the (G-)DDR memory clocks with local radio module frequency bands used by Wifi 6/6e/7. To mitigate possible RFI interference producers can advertise the

Re: [PATCH] drm/gma500: Fix call trace when psb_gem_mm_init() fails

2023-08-25 Thread suijingfeng
Hi, On 2023/8/25 14:54, Patrik Jakobsson wrote: On Fri, Jul 28, 2023 at 02:58:55AM +0800, Sui Jingfeng wrote: Because the gma_irq_install() is call after psb_gem_mm_init() function, when psb_gem_mm_init() fails, the interrupt line haven't been allocated. Yet the gma_irq_uninstall() is called i

Re: [PATCH 0/3] Make Allwinner A64's pll-mipi keep its rate when parent rate changes

2023-08-25 Thread Maxime Ripard
Hi, On Fri, Aug 25, 2023 at 07:36:36AM +0200, Frank Oltmanns wrote: > I would like to make the Allwinner A64's pll-mipi to keep its rate when > its parent's (pll-video0) rate changes. Keeping pll-mipi's rate is > required, to let the A64 drive both an LCD and HDMI display at the same > time, becau

Re: [PATCH v2 4/9] drm/sched: Split free_job into own work item

2023-08-25 Thread Christian König
Am 25.08.23 um 04:58 schrieb Matthew Brost: On Fri, Aug 25, 2023 at 01:04:10AM +0200, Danilo Krummrich wrote: On Thu, Aug 10, 2023 at 07:31:32PM -0700, Matthew Brost wrote: Rather than call free_job and run_job in same work item have a dedicated work item for each. This aligns with the design a

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-25 Thread Hsia-Jun Li
On 8/25/23 15:40, Pekka Paalanen wrote: Subject: Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers From: Pekka Paalanen Date: 8/25/23, 15:40 To: Hsia-Jun Li CC: Tomasz Figa , linux...@kvack.org, dri-devel@lists.freedesktop.org, Linux Media Mailing List , hu...@google.com, a...

Re: [PATCH 2/5] ALSA: hda/intel: Use pci_get_base_class() to reduce duplicated code

2023-08-25 Thread Takashi Iwai
On Fri, 25 Aug 2023 08:27:11 +0200, Sui Jingfeng wrote: > > From: Sui Jingfeng > > Should be no functional change > > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Fred Oh > Cc: Pierre-Louis Bossart > Cc: Kai Vehmanen > Cc: Bjorn Helgaas > Signed-off-by: Sui Jingfeng > --- > sound/pci/hd

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-25 Thread Pekka Paalanen
On Wed, 23 Aug 2023 15:11:23 +0800 Hsia-Jun Li wrote: > On 8/23/23 12:46, Tomasz Figa wrote: > > CAUTION: Email originated externally, do not click links or open > > attachments unless you recognize the sender and know the content is safe. > > > > > > Hi Hsia-Jun, > > > > On Tue, Aug 22, 2023

Re: [RFC]: shmem fd for non-DMA buffer sharing cross drivers

2023-08-25 Thread Hsia-Jun Li
On 8/23/23 21:15, Tomasz Figa wrote: CAUTION: Email originated externally, do not click links or open attachments unless you recognize the sender and know the content is safe. On Wed, Aug 23, 2023 at 4:11 PM Hsia-Jun Li wrote: On 8/23/23 12:46, Tomasz Figa wrote: CAUTION: Email origin

[PATCH -next] drm: xlnx: zynqmp_dpsub: Use devm_clk_get_enabled() helper function

2023-08-25 Thread Jinjie Ruan
The devm_clk_get_enabled() helper: - calls devm_clk_get() - calls clk_prepare_enable() and registers what is needed in order to call clk_disable_unprepare() when needed, as a managed resource. This simplifies the code. Signed-off-by: Jinjie Ruan --- drivers/gpu/drm/xlnx/zynqmp_dps

Re: [BUG] KCSAN: data-race in drm_sched_entity_is_ready [gpu_sched] / drm_sched_entity_push_job [gpu_sched]

2023-08-25 Thread Christian König
Hi Mirsad, the name SPSC stands for SingleProducerSingleConsumer, so yes even by the name of the component we make it clear that this can only be used by one producer and one consumer thread at the same time. Here disabling preemption is just done so that the consumer thread doesn't busy loo

<    1   2