[PATCH v2 06/10] drm/ast: Enable MMIO without ast device instance

We'll have to enable the MMIO access for detecting the ast device type. Make this work without an instance of the ast device. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_main.c | 16 +--- drivers/gpu/drm/ast/ast_reg.h | 2 ++ 2 files c

[PATCH v2 05/10] drm/ast: Enable VGA without ast device instance

We'll have to enable the VGA functionality for detecting the ast device type. Make this work without an instance of the ast device. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_main.c | 29 - drivers/gpu/drm/ast/ast_reg.h

[PATCH v2 10/10] drm/ast: Move detection code into PCI probe helper

Detect device type and config mode in the PCI probe helper, but leave DRM device initialization where it is. Structures the driver probe and setup code into a detection and an initialization phase. A later patch can add branching to the device-initialization code. Each chip type can have it own in

[PATCH v2 07/10] drm/ast: Partially implement POST without ast device instance

We'll have to do some of the GPU POSTing for detecting the ast device type. Make this work without an instance of the ast device. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.h | 2 +- drivers/gpu/drm/ast/ast_main.c | 2 +- drivers/gpu/drm/ast

[PATCH v2 08/10] drm/ast: Add enum ast_config_mode

The config mode used to be a field in struct ast_device. Turn it into a named type. We'll need this for device detection. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_drv.h | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --g

[PATCH v2 09/10] drm/ast: Detect ast device type and config mode without ast device

Return the ast chip and config in the detection function's parameters instead of storing them directly in the ast device instance. v2: * add break statements to switch default branches (Jocelyn) Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_m

[PATCH v2 03/10] drm/ast: Retrieve I/O-memory ranges without ast device

Read the I/O-memory ranges into local variables before setting them in the ast device instanace. We'll later need this to split detecting the device type from the creation of the ast device instance. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/ast/ast_main.

[PATCH v2 01/10] drm/ast: Turn ioregs_lock to modeset_lock

The lock for the I/O registers is only relevant during mode-setting operations. It protects the registers from concurrent access from reading EDID information. Reduce lock coverage to mode setting, rename the lock and move it entirely into the mode-setting code. No functional changes, as the I/O l

[PATCH v2 00/10] drm/ast: Detect device type before init

Detecting the ast device's chipset type and configuration mode involves several registers, DT properties and possibly POSTing parts of the chip. It is preferable to do this before initializing the DRM driver, so that that each chip type can have an individual setup code. The patchset addresses the

[PATCH v2 04/10] drm/ast: Add I/O helpers without ast device

Implement I/O access in helpers that do now use an ast device instance, but the raw pointer to the I/O memory. We'll later need these helpers to detect the device type before allocating the ast device instance. Signed-off-by: Thomas Zimmermann Reviewed-by: Jocelyn Falempe --- drivers/gpu/drm/as

[PATCH v2 02/10] drm/ast: Rework I/O register setup

There are three different ways of retrieving the I/O-memory ranges for AST devices: either from PCI BAR 1, from PCI BAR 2 or from PCI BAR 1 by 'guessing'. Make the respective code more readable by making each case self- contained. Also add error checking against the length of the PCI BARs. v2:

Re: [PATCH 03/32] fbdev/vfb: Set FBINFO_VIRTFB flag

Thomas Zimmermann writes: > The vfb driver operates on system memory. Mark the framebuffer > accordingly. Helpers operating on the framebuffer memory will test > for the presence of this flag. > > Signed-off-by: Thomas Zimmermann > --- Reviewed-by: Javier Martinez Canillas -- Best regards,

Re: [PATCH v4] Documentation/gpu: VM_BIND locking document

Hi Thomas, On Wed, 15 Nov 2023 13:49:37 +0100 Thomas Hellström wrote: > Add the first version of the VM_BIND locking document which is > intended to be part of the xe driver upstreaming agreement. > > The document describes and discuss the locking used during exec- > functions, evicton and for

Re: [PATCH 02/32] fbdev/sm712fb: Use correct initializer macros for struct fb_ops

Thomas Zimmermann writes: > Only initialize mmap and draw helpers with macros; leave read/write > callbacks to driver implementations. Fixes the following warnings: > > CC [M] drivers/video/fbdev/sm712fb.o > sm712fb.c:1355:25: warning: initialized field overwritten [-Woverride-init] > 1355

Re: [PATCH 01/32] fbdev/acornfb: Fix name of fb_ops initializer macro

Thomas Zimmermann writes: > Fix build by using the correct name for the initializer macro > for struct fb_ops. > > Signed-off-by: Thomas Zimmermann > Fixes: 9037afde8b9d ("fbdev/acornfb: Use fbdev I/O helpers") > Cc: Thomas Zimmermann > Cc: Sam Ravnborg > Cc: Helge Deller > Cc: Javier Martine

Re: [RFC PATCH] of/platform: Disable sysfb if a simple-framebuffer node is found

Rob Herring writes: Hello Rob, > On Mon, Nov 13, 2023 at 2:53 AM Javier Martinez Canillas > wrote: >> >> Some DT platforms use EFI to boot and in this case the EFI Boot Services >> may register a EFI_GRAPHICS_OUTPUT_PROTOCOL handle, that will later be >> queried by the Linux EFI stub to fill th

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

On Thu, 16 Nov 2023 at 11:14, Sui Jingfeng wrote: > > Hi, > > Thanks a lot for reviewing! > > > On 2023/11/15 00:30, Dmitry Baryshkov wrote: > > On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: > >> From: Sui Jingfeng > >> > >> The it66121_create_bridge() and it66121_destroy_bridge() are added

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

Hi, On Mon, Nov 13, 2023 at 09:56:32PM -0500, Luben Tuikov wrote: > On 2023-11-13 21:45, Stephen Rothwell wrote: > > Hi Luben, > > > > On Mon, 13 Nov 2023 20:32:40 -0500 Luben Tuikov wrote: > >> > >> On 2023-11-13 20:08, Luben Tuikov wrote: > >>> On 2023-11-13 15:55, Stephen Rothwell wrote: >

Re: [PATCH 2/6] drm: Add drm_atomic_helper_buffer_damage_{iter_init, merged}() helpers

On Tue, 14 Nov 2023 17:05:12 +0100 Javier Martinez Canillas wrote: > Thomas Zimmermann writes: > > > Hi > > > > Am 09.11.23 um 18:24 schrieb Javier Martinez Canillas: > > [...] > > >>struct drm_rect src; > >>memset(iter, 0, sizeof(*iter)); > >> @@ -223,7 +224,8 @@ __drm_atomic_helpe

Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib

Hi, Thanks a lot for reviewing! On 2023/11/15 00:30, Dmitry Baryshkov wrote: On Tue, 14 Nov 2023 at 17:09, Sui Jingfeng wrote: From: Sui Jingfeng The it66121_create_bridge() and it66121_destroy_bridge() are added to export the core functionalities. Create a connector manually by using brid

Use after free with GEM shadow-buffered planes

[Originally reported at https://gitlab.freedesktop.org/drm/misc/-/issues/33] The following happens in a cycle: • An atomic state is allocated • A plane state is allocated (drm_gem_duplicate_shadow_plane_state()) • Commit (drm_atomic_helper_commit(), possibly nonblocking / asynchronously) • Th

Re: [PATCH v3 5/7] PCI: ACPI: Detect PCIe root ports that are used for tunneling

Hi Mario, On Wed, Nov 15, 2023 at 11:08:43AM -0600, Mario Limonciello wrote: > On 11/15/2023 04:40, Mika Westerberg wrote: > > Hi Mario, > > > > On Tue, Nov 14, 2023 at 02:07:53PM -0600, Mario Limonciello wrote: > > > USB4 routers support a feature called "PCIe tunneling". This > > > allows PCIe

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

Hi, On 11/3/23 21:18, Andy Shevchenko wrote: > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct > talking to GPIO IP behind the actual driver's back. A second attempt > to fix that is here. > > If I understood correctly, my approach should work in the similar way as > the cur

[PATCH v2] drm/i915/gsc: Mark internal GSC engine with reserved uabi class

From: Tvrtko Ursulin The GSC CS is not exposed to the user, so we skipped assigning a uabi class number for it. However, the trace logs use the uabi class and instance to identify the engine, so leaving uabi class unset makes the GSC CS show up as the RCS in those logs. Given that the engine is

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

On Thu, Nov 16, 2023 at 09:11:43AM +0100, Maxime Ripard wrote: > On Tue, Nov 14, 2023 at 06:46:21PM -0500, Luben Tuikov wrote: > > On 2023-11-13 22:08, Stephen Rothwell wrote: > > > BTW, cherry picking commits does not avoid conflicts - in fact it can > > > cause conflicts if there are further chan

Re: [PATCH 1/1] backlight: pwm_bl: Use dev_err_probe

Hello, On Thu, Nov 16, 2023 at 08:50:17AM +0100, Alexander Stein wrote: > Let dev_err_probe handle the -EPROBE_DEFER case and also add an entry to > /sys/kernel/debug/devices_deferred when deferred. > > Signed-off-by: Alexander Stein > --- > drivers/video/backlight/pwm_bl.c | 3 +-- > 1 file ch

Re: linux-next: Signed-off-by missing for commit in the drm-misc tree

On Tue, Nov 14, 2023 at 06:46:21PM -0500, Luben Tuikov wrote: > On 2023-11-13 22:08, Stephen Rothwell wrote: > > BTW, cherry picking commits does not avoid conflicts - in fact it can > > cause conflicts if there are further changes to the files affected by > > the cherry picked commit in either the

Re: [PATCH 09/11] drm/rockchip: vop2: Add support for rk3588

Hi Sascha: On 11/16/23 15:50, Sascha Hauer wrote: On Thu, Nov 16, 2023 at 03:24:54PM +0800, Andy Yan wrote: case ROCKCHIP_VOP2_EP_HDMI0: case ROCKCHIP_VOP2_EP_HDMI1: ... } would look a bit better overall. + /* +* K = 2: dclk_core

<    1   2   3