Re: [PATCH v1 2/3] drm/panel: st7701: Add support for SPI for configuration

2024-06-20 Thread Dan Carpenter
Hi Hironori, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Hironori-KIKUCHI/dt-bindings-display-st7701-Add-Anbernic-RG28XX-panel/20240618-161849 base: https://git

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-20 Thread Bjorn Andersson
On Wed, Jun 12, 2024 at 09:28:39PM GMT, Dmitry Baryshkov wrote: > On Wed, Jun 12, 2024 at 12:17:28PM +0530, Ekansh Gupta wrote: > > Move fastrpc.c from misc/ to misc/fastrpc/. New C files are planned > > to be added for PD notifications and other missing features. Adding > > and maintaining new fil

Re: [PATCH v14 00/12] Improve test coverage of TTM

2024-06-20 Thread Somalapuram, Amaranath
Hi Arun, I still don't have commit permission. Can you please help to push this patches. Regards, S.Amarnath On 6/20/2024 2:38 PM, Karolina Stolarek wrote: Hi Christian and Amaranath, On 12.06.2024 14:02, Karolina Stolarek wrote: Introduce tests for ttm_bo_validate()/ttm_bo_init_validate()

[PATCH] drm/buddy: Add start address support to trim function

2024-06-20 Thread Arunpravin Paneer Selvam
- Add a new start parameter in trim function to specify exact address from where to start the trimming. This would help us in situations like if drivers would like to do address alignment for specific requirements. - Add a new flag DRM_BUDDY_TRIM_DISABLE. Drivers can use this flag to disab

Re: (subset) [PATCH v2 0/7] Add SMEM-based speedbin matching

2024-06-20 Thread Bjorn Andersson
On Wed, 05 Jun 2024 22:10:13 +0200, Konrad Dybcio wrote: > Newer (SM8550+) SoCs don't seem to have a nice speedbin fuse anymore, > but instead rely on a set of combinations of "feature code" (FC) and > "product code" (PC) identifiers to match the bins. This series adds > support for that. > > I

Re: [PATCH v3 09/11] tracing: Replace strncpy() with __get_task_comm()

2024-06-20 Thread Google
On Fri, 21 Jun 2024 10:29:57 +0800 Yafang Shao wrote: > Using __get_task_comm() to read the task comm ensures that the name is > always NUL-terminated, regardless of the source string. This approach also > facilitates future extensions to the task comm. Good catch! Looks good to me. Acked-by: M

Re: [PATCH 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-20 Thread Marek Vasut
On 6/11/24 6:45 PM, Marek Vasut wrote: On 6/6/24 12:10 PM, Alexander Stein wrote: Hi Marek, Hello Alexander, sorry for the delay. At least for 148.5MHz (1080p) apparently it is not possible to that exact clock anyway. Right, which sucks, but the TC9595 datasheet explicitly states that th

[PATCH v3 11/11] drm: Replace strcpy() with __get_task_comm()

2024-06-20 Thread Yafang Shao
To prevent erros from occurring when the src string is longer than the dst string in strcpy(), we should use __get_task_comm() instead. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc

[PATCH v3 10/11] net: Replace strcpy() with __get_task_comm()

2024-06-20 Thread Yafang Shao
To prevent errors from occurring when the src string is longer than the dst string in strcpy(), we should use __get_task_comm() instead. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Cc: "David S. Miller" Cc: David Ahern Cc: Eric Dumazet Cc: Jaku

[PATCH v3 09/11] tracing: Replace strncpy() with __get_task_comm()

2024-06-20 Thread Yafang Shao
Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Mathieu Desnoyers --- kernel

[PATCH v3 08/11] tsacct: Replace strncpy() with __get_task_comm()

2024-06-20 Thread Yafang Shao
Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao --- kernel/tsacct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 07/11] mm/kmemleak: Replace strncpy() with __get_task_comm()

2024-06-20 Thread Yafang Shao
Since task lock was dropped from __get_task_comm(), it's safe to call it from kmemleak. Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by:

[PATCH v3 06/11] mm/util: Deduplicate code in {kstrdup, kstrndup, kmemdup_nul}

2024-06-20 Thread Yafang Shao
These three functions follow the same pattern. To deduplicate the code, let's introduce a common help __kstrndup(). Suggested-by: Andrew Morton Signed-off-by: Yafang Shao --- mm/internal.h | 24 mm/util.c | 27 --- 2 files changed, 28 inserti

[PATCH v3 05/11] mm/util: Fix possible race condition in kstrdup()

2024-06-20 Thread Yafang Shao
In kstrdup(), it is critical to ensure that the dest string is always NUL-terminated. However, potential race condidtion can occur between a writer and a reader. Consider the following scenario involving task->comm: readerwriter len = strlen(s) + 1;

[PATCH v3 04/11] bpftool: Ensure task comm is always NUL-terminated

2024-06-20 Thread Yafang Shao
Let's explicitly ensure the destination string is NUL-terminated. This way, it won't be affected by changes to the source string. Signed-off-by: Yafang Shao Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/pids.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/bpf/bpftool/pids.c b/

[PATCH v3 03/11] security: Replace memcpy() with __get_task_comm()

2024-06-20 Thread Yafang Shao
Quoted from Linus [0]: selinux never wanted a lock, and never wanted any kind of *consistent* result, it just wanted a *stable* result. Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates

[PATCH v3 02/11] auditsc: Replace memcpy() with __get_task_comm()

2024-06-20 Thread Yafang Shao
Using __get_task_comm() to read the task comm ensures that the name is always NUL-terminated, regardless of the source string. This approach also facilitates future extensions to the task comm. Signed-off-by: Yafang Shao Acked-by: Paul Moore Cc: Eric Paris --- kernel/auditsc.c | 6 +++--- 1 fi

[PATCH v3 01/11] fs/exec: Drop task_lock() inside __get_task_comm()

2024-06-20 Thread Yafang Shao
Quoted from Linus [0]: Since user space can randomly change their names anyway, using locking was always wrong for readers (for writers it probably does make sense to have some lock - although practically speaking nobody cares there either, but at least for a writer some kind of race could

[PATCH v3 00/11] Improve the copy of task comm

2024-06-20 Thread Yafang Shao
Using {memcpy,strncpy,strcpy,kstrdup} to copy the task comm relies on the length of task comm. Changes in the task comm could result in a destination string that is overflow. Therefore, we should explicitly ensure the destination string is always NUL-terminated, regardless of the task comm. This ap

Re: [PATCH v3 00/14] This series fixes the errors of MediaTek display driver found by IGT.

2024-06-20 Thread 宋孝謙

Re: [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver

2024-06-20 Thread zhaoxiong lv
On Fri, Jun 21, 2024 at 3:56 AM Dmitry Baryshkov wrote: > > On Thu, Jun 20, 2024 at 07:52:45PM GMT, Zhaoxiong Lv wrote: > > The bias IC of this starry-er88577 panel is placed > > on the panel side, so when the panel is powered on, > > there is no need to control AVDD and AVEE in the driver, > > on

Re: [Patch V3] i2c: imx-lpi2c: add eDMA mode support for LPI2C

2024-06-20 Thread kernel test robot
Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on andi-shyti/i2c/i2c-host] [also build test WARNING on linus/master v6.10-rc4 next-20240620] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] drm/ssd130x: Add drm_panic support

2024-06-20 Thread Javier Martinez Canillas
Add support for the drm_panic infrastructure, which allows to display a user friendly message on the screen when a Linux kernel panic occurs. The display controller doesn't scanout the framebuffer, but instead the pixels are sent to the device using a transport bus. For this reason, a .panic_flush

Re: [PATCH v5 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-06-20 Thread Dmitry Baryshkov
On Thu, Jun 20, 2024 at 03:05:16PM GMT, Abhinav Kumar wrote: > > > On 6/20/2024 2:24 PM, Dmitry Baryshkov wrote: > > On Thu, Jun 20, 2024 at 01:49:33PM GMT, Abhinav Kumar wrote: > > > > > > > > > On 6/20/2024 1:32 PM, Dmitry Baryshkov wrote: > > > > On Thu, Jun 20, 2024 at 01:27:15PM GMT, Abhin

Re: [PATCH v5 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-06-20 Thread Abhinav Kumar
On 6/20/2024 2:24 PM, Dmitry Baryshkov wrote: On Thu, Jun 20, 2024 at 01:49:33PM GMT, Abhinav Kumar wrote: On 6/20/2024 1:32 PM, Dmitry Baryshkov wrote: On Thu, Jun 20, 2024 at 01:27:15PM GMT, Abhinav Kumar wrote: On 6/7/2024 6:23 AM, Dmitry Baryshkov wrote: The mode_set callback is de

[PATCH v2] drm/msm/adreno: Add A306A support

2024-06-20 Thread Barnabás Czémán
From: Otto Pflüger Add support for Adreno 306A GPU what is found in MSM8917 SoC. This GPU marketing name is Adreno 308. Signed-off-by: Otto Pflüger [use internal name of the GPU, reword the commit message] Signed-off-by: Barnabás Czémán --- Changes in v2: - Rebase on https://patchwork.freedesk

Re: [PATCH] dma-buf/sw_sync: Add a reference when adding fence to timeline list

2024-06-20 Thread Thadeu Lima de Souza Cascardo
On Thu, Jun 20, 2024 at 03:50:58PM -0300, Thadeu Lima de Souza Cascardo wrote: > On Wed, Jun 19, 2024 at 01:14:38PM +0100, Tvrtko Ursulin wrote: > > > > On 14/06/2024 19:00, Thadeu Lima de Souza Cascardo wrote: > > > On Fri, Jun 14, 2024 at 11:52:03AM +0100, Tvrtko Ursulin wrote: > > > > > > > >

Re: [PATCH] drm/mediatek: select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION=y

2024-06-20 Thread Paolo Bonzini
On Thu, Jun 20, 2024 at 11:21 PM Paolo Bonzini wrote: > Queued, thanks. Oops, a script started sending "queued" messages for everything that had "y" in the subject. Sorry about that. Paolo

Re: [PATCH v5 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-06-20 Thread Dmitry Baryshkov
On Thu, Jun 20, 2024 at 01:49:33PM GMT, Abhinav Kumar wrote: > > > On 6/20/2024 1:32 PM, Dmitry Baryshkov wrote: > > On Thu, Jun 20, 2024 at 01:27:15PM GMT, Abhinav Kumar wrote: > > > > > > > > > On 6/7/2024 6:23 AM, Dmitry Baryshkov wrote: > > > > The mode_set callback is deprecated, it doesn'

Re: [PATCH] drm/mediatek: select DRM_GEM_DMA_HELPER if DRM_FBDEV_EMULATION=y

2024-06-20 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH v5 8/9] drm/msm/hdmi: update HDMI_GEN_PKT_CTRL_GENERIC0_UPDATE definition

2024-06-20 Thread Abhinav Kumar
On 6/7/2024 6:23 AM, Dmitry Baryshkov wrote: The GENERIC0_UPDATE field is a single bit. Redefine it as boolean to simplify its usage in the driver. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/registers/display/hdmi.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v5 7/9] drm/msm/hdmi: get rid of hdmi_mode

2024-06-20 Thread Abhinav Kumar
On 6/7/2024 6:23 AM, Dmitry Baryshkov wrote: Use connector->display_info.is_hdmi instead of manually using drm_detect_hdmi_monitor(). Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi.c| 2 +- drivers/gpu/drm/msm/hdmi/hdmi.h| 2 --

Re: [PATCH v5 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-06-20 Thread Abhinav Kumar
On 6/20/2024 1:32 PM, Dmitry Baryshkov wrote: On Thu, Jun 20, 2024 at 01:27:15PM GMT, Abhinav Kumar wrote: On 6/7/2024 6:23 AM, Dmitry Baryshkov wrote: The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Turn it into the atomic_enable call

Re: [PATCH v5 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-06-20 Thread Dmitry Baryshkov
On Thu, Jun 20, 2024 at 01:27:15PM GMT, Abhinav Kumar wrote: > > > On 6/7/2024 6:23 AM, Dmitry Baryshkov wrote: > > The mode_set callback is deprecated, it doesn't get the > > drm_bridge_state, just mode-related argumetns. Turn it into the > > atomic_enable callback as suggested by the documentat

Re: [PATCH v3] drm/msm/dpu: drop validity checks for clear_pending_flush() ctl op

2024-06-20 Thread Dmitry Baryshkov
On Thu, Jun 20, 2024 at 01:17:30PM GMT, Abhinav Kumar wrote: > clear_pending_flush() ctl op is always assigned irrespective of the DPU > hardware revision. Hence there is no needed to check whether the op has > been assigned before calling it. > > Drop the checks across the driver for clear_pendin

Re: [PATCH v5 5/9] drm/msm/hdmi: turn mode_set into atomic_enable

2024-06-20 Thread Abhinav Kumar
On 6/7/2024 6:23 AM, Dmitry Baryshkov wrote: The mode_set callback is deprecated, it doesn't get the drm_bridge_state, just mode-related argumetns. Turn it into the atomic_enable callback as suggested by the documentation. mode_set is deprecated but atomic_mode_set is not. I would rather u

Re: [PATCH v3 2/2] drm/amd: Add power_saving_policy drm property to eDP connectors

2024-06-20 Thread Xaver Hugl
Am Mi., 19. Juni 2024 um 06:08 Uhr schrieb Mario Limonciello > Thanks! I don't have permissions, so can you (or someone else) please > apply to drm-misc-next for me? > > After it's merged I'll rebase and work on the feedback for the new IGT > tests. Merging can only happen once a real world user

Re: [PATCH V2] drm/bridge: adv7511: Fix Intermittent EDID failures

2024-06-20 Thread Dmitry Baryshkov
On Sat, Jun 01, 2024 at 08:24:59AM GMT, Adam Ford wrote: > In the process of adding support for shared IRQ pins, a scenario > was accidentally created where adv7511_irq_process returned > prematurely causing the EDID to fail randomly. > > Since the interrupt handler is broken up into two main help

Re: [PATCH v5 4/9] drm/msm/hdmi: switch to atomic bridge callbacks

2024-06-20 Thread Abhinav Kumar
On 6/7/2024 6:23 AM, Dmitry Baryshkov wrote: Change MSM HDMI bridge to use atomic_* callbacks in preparation to enablign the HDMI connector support. Acked-by: Maxime Ripard Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 13 + 1 file changed, 9 in

[PATCH v3] drm/msm/dpu: drop validity checks for clear_pending_flush() ctl op

2024-06-20 Thread Abhinav Kumar
clear_pending_flush() ctl op is always assigned irrespective of the DPU hardware revision. Hence there is no needed to check whether the op has been assigned before calling it. Drop the checks across the driver for clear_pending_flush() and also update its documentation that it is always expected

Re: [PATCH v3 16/23] leds: max77705: Add LEDs support

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > This adds basic support for LEDs for the max77705 PMIC. > > Signed-off-by: Dzmitry Sankouski > --- > MAINTAINERS | 1 + > drivers/leds/Kconfig | 6 ++ > drivers/leds/Makefile| 1 + > drivers/leds/leds-max77705

Re: [PATCH v3 11/23] drm/panel: Add support for S6E3HA8 panel driver

2024-06-20 Thread Dmitry Baryshkov
On Wed, Jun 19, 2024 at 04:27:40PM GMT, Dzmitry Sankouski wrote: > вт, 18 июн. 2024 г. в 21:39, Dmitry Baryshkov : > > > > > + ret = mipi_dsi_compression_mode(dsi, true); > > > + if (ret < 0) { > > > + dev_err(dev, "Failed to set compression mode: %d\n", ret); > > > +

Re: [PATCH v2] drm/msm/dpu: drop validity checks for clear_pending_flush() ctl op

2024-06-20 Thread Dmitry Baryshkov
On Thu, Jun 20, 2024 at 12:12:27PM GMT, Abhinav Kumar wrote: > clear_pending_flush() ctl op is always assigned irrespective of the DPU > hardware revision. Hence there is no needed to check whether the op has > been assigned before calling it. > > Drop the checks across the driver for clear_pendin

Re: [PATCH v4 2/2] drm/panel: starry-er88577: add new panel driver

2024-06-20 Thread Dmitry Baryshkov
On Thu, Jun 20, 2024 at 07:52:45PM GMT, Zhaoxiong Lv wrote: > The bias IC of this starry-er88577 panel is placed > on the panel side, so when the panel is powered on, > there is no need to control AVDD and AVEE in the driver, > only 3.3v and reset are needed. > > Signed-off-by: Zhaoxiong Lv > ---

Re: [PATCH v3] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions

2024-06-20 Thread Doug Anderson
Hi, On Thu, Jun 20, 2024 at 11:12 AM Tejas Vipin wrote: > > Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: > Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe > ("drm/mipi-dsi: wrap more functions for streamline handling") for the > raydium-rm692e5 panel. > > Addit

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-20 Thread Andrew Lunn
On Thu, Jun 20, 2024 at 06:51:35AM -0700, Jakub Kicinski wrote: > On Thu, 20 Jun 2024 08:43:34 + Omer Shpigelman wrote: > > > You support 400G, you really need to give the user the ability > > > to access higher pages. > > > > Actually the 200G and 400G modes in the ethtool code should be re

Re: [PATCH v12 0/7] iio: new DMABUF based API v12

2024-06-20 Thread Jonathan Cameron
On Thu, 20 Jun 2024 20:11:50 +0100 Jonathan Cameron wrote: > On Thu, 20 Jun 2024 21:50:41 +0530 > Vinod Koul wrote: > > > On 20-06-24, 14:27, Paul Cercueil wrote: > > > Hi Jonathan, > > > > Hey Jonathan, > > > > Assuming we are fine with this series, how would you like to proceed. > > W

[PATCH v2] drm/msm/dpu: drop validity checks for clear_pending_flush() ctl op

2024-06-20 Thread Abhinav Kumar
clear_pending_flush() ctl op is always assigned irrespective of the DPU hardware revision. Hence there is no needed to check whether the op has been assigned before calling it. Drop the checks across the driver for clear_pending_flush() and also update its documentation that it is always expected

Re: [PATCH v12 0/7] iio: new DMABUF based API v12

2024-06-20 Thread Jonathan Cameron
On Thu, 20 Jun 2024 21:50:41 +0530 Vinod Koul wrote: > On 20-06-24, 14:27, Paul Cercueil wrote: > > Hi Jonathan, > > Hey Jonathan, > > Assuming we are fine with this series, how would you like to proceed. > Would you be fine with me picking the dmaengine bits and providing a > signed tag for

Re: [PATCH] dma-buf/sw_sync: Add a reference when adding fence to timeline list

2024-06-20 Thread Thadeu Lima de Souza Cascardo
On Wed, Jun 19, 2024 at 01:14:38PM +0100, Tvrtko Ursulin wrote: > > On 14/06/2024 19:00, Thadeu Lima de Souza Cascardo wrote: > > On Fri, Jun 14, 2024 at 11:52:03AM +0100, Tvrtko Ursulin wrote: > > > > > > On 24/03/2024 10:15, Thadeu Lima de Souza Cascardo wrote: > > > > commit e531fdb5cd5e ("dma

[PATCH v3] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions

2024-06-20 Thread Tejas Vipin
Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe ("drm/mipi-dsi: wrap more functions for streamline handling") for the raydium-rm692e5 panel. Additionally, the error handling in rm692e5_prepare() is changed to properly

Re: (subset) [PATCH] backlight: Drop explicit initialization of struct i2c_device_id::driver_data to 0

2024-06-20 Thread Lee Jones
On Wed, 19 Jun 2024 21:35:57 +0200, Uwe Kleine-König wrote: > These drivers don't use the driver_data member of struct i2c_device_id, > so don't explicitly initialize this member. > > This prepares putting driver_data in an anonymous union which requires > either no initialization or named designa

Re: [PATCH] drm/msm/adreno: Add A306A support

2024-06-20 Thread Rob Clark
On Wed, May 29, 2024 at 3:41 AM Konrad Dybcio wrote: > > On 28.05.2024 9:43 PM, Barnabás Czémán wrote: > > From: Otto Pflüger > > > > Add support for Adreno 306A GPU what is found in MSM8917 SoC. > > This GPU marketing name is Adreno 308. > > > > Signed-off-by: Otto Pflüger > > [use internal nam

Re: [PATCH 2/2] drm/panel-xinpeng-xpp055c272: add check for mipi_dsi_dcs_enter_sleep_mode

2024-06-20 Thread Christophe JAILLET
Le 20/06/2024 à 09:48, Chen Ni a écrit : Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and return the error if it fails in order to catch the error. Signed-off-by: Chen Ni --- drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH 1/2] drm/panel: ltk050h3146w: add check for mipi_dsi_dcs_enter_sleep_mode

2024-06-20 Thread Christophe JAILLET
Le 20/06/2024 à 09:47, Chen Ni a écrit : Add check for the return value of mipi_dsi_dcs_enter_sleep_mode() and return the error if it fails in order to catch the error. Signed-off-by: Chen Ni --- drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-20 Thread Lee Jones
On Thu, 20 Jun 2024, Vinod Koul wrote: > On 20-06-24, 12:45, Markus Elfring wrote: > > … > > > All errors (new ones prefixed by >>): > > > > > >>> drivers/iio/industrialio-buffer.c:1715:3: error: cannot jump from this > > >>> goto statement to its label > > > 1715 | goto err_d

Re: [PATCH] MAINTAINERS: update Microchip's Atmel-HLCDC driver maintainers

2024-06-20 Thread Sam Ravnborg
Hi Manikandan and Dharma. On Thu, Jun 20, 2024 at 03:28:56PM +0530, Manikandan Muralidharan wrote: > Drop Sam Ravnborg and Boris Brezillon as they are no longer interested in > maintaining the drivers. Add myself and Dharma Balasubiramani as the > Maintainer and co-maintainer for Microchip's Atmel

Re: [PATCH 4/4] drm: rcar-du: Add support for R8A779H0

2024-06-20 Thread Geert Uytterhoeven
Hi Jacopo, On Thu, Jun 20, 2024 at 6:48 PM Jacopo Mondi wrote: > On Thu, Jun 20, 2024 at 02:48:49PM GMT, Geert Uytterhoeven wrote: > > On Wed, Jun 19, 2024 at 9:46 PM Laurent Pinchart > > wrote: > > > On Wed, Jun 19, 2024 at 12:22:18PM +0200, Jacopo Mondi wrote: > > > > Add support for R-Car R8A

Re: [PATCH v12 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-20 Thread Lee Jones
On Thu, 20 Jun 2024, Markus Elfring wrote: > … > > v11: > … > > - Use guard(mutex) > > > > v12: > > - Revert to mutex_lock/mutex_unlock in iio_buffer_attach_dmabuf(), > > as it uses cleanup GOTOs > … > > I would find it nice if better design options could gain acceptance. > Will the

Re: [PATCH] drm/msm/dpu: protect ctl ops calls with validity checks

2024-06-20 Thread Abhinav Kumar
On 6/20/2024 9:41 AM, Rob Clark wrote: On Thu, Jun 20, 2024 at 6:08 AM Dmitry Baryshkov wrote: On Thu, 20 Jun 2024 at 00:27, Abhinav Kumar wrote: dpu_encoder_helper_phys_cleanup() calls the ctl ops without checking if the ops are assigned causing discrepancy between its callers where the

Re: [PATCH 4/4] drm: rcar-du: Add support for R8A779H0

2024-06-20 Thread Jacopo Mondi
Hi Geert On Thu, Jun 20, 2024 at 02:48:49PM GMT, Geert Uytterhoeven wrote: > Hi Laurent, Jacopo, > > On Wed, Jun 19, 2024 at 9:46 PM Laurent Pinchart > wrote: > > On Wed, Jun 19, 2024 at 12:22:18PM +0200, Jacopo Mondi wrote: > > > Add support for R-Car R8A779H0 V4M which has similar characteristi

Re: [PATCH] drm/msm/dpu: protect ctl ops calls with validity checks

2024-06-20 Thread Rob Clark
On Thu, Jun 20, 2024 at 6:08 AM Dmitry Baryshkov wrote: > > On Thu, 20 Jun 2024 at 00:27, Abhinav Kumar wrote: > > > > dpu_encoder_helper_phys_cleanup() calls the ctl ops without checking if > > the ops are assigned causing discrepancy between its callers where the > > checks are performed and th

Re: [PATCH v4 5/5] drm/msm/adreno: Move CP_PROTECT settings to hw catalog

2024-06-20 Thread Rob Clark
On Tue, Jun 18, 2024 at 12:02 PM Konrad Dybcio wrote: > > > > On 6/18/24 18:42, Rob Clark wrote: > > From: Rob Clark > > > > Move the CP_PROTECT settings into the hw catalog. > > > > Signed-off-by: Rob Clark > > Reviewed-by: Dmitry Baryshkov > > --- > > [...] > > > +static inline void __build_a

Re: [PATCH v12 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-20 Thread Markus Elfring
… > v11: … > - Use guard(mutex) > > v12: > - Revert to mutex_lock/mutex_unlock in iio_buffer_attach_dmabuf(), > as it uses cleanup GOTOs … I would find it nice if better design options could gain acceptance. Will the chances grow to adjust scopes another bit for involved variables in

Re: [PATCH v12 0/7] iio: new DMABUF based API v12

2024-06-20 Thread Vinod Koul
On 20-06-24, 14:27, Paul Cercueil wrote: > Hi Jonathan, Hey Jonathan, Assuming we are fine with this series, how would you like to proceed. Would you be fine with me picking the dmaengine bits and providing a signed tag for you to pull? -- ~Vinod

[PATCH] drm/ttm/pool: Revert to clear-on-alloc to honor TTM_TT_FLAG_ZERO_ALLOC

2024-06-20 Thread Nirmoy Das
Currently ttm pool is not honoring TTM_TT_FLAG_ZERO_ALLOC flag and clearing pages on free. It does help with allocation latency but clearing happens even if drm driver doesn't passes the flag. If clear on free is needed then a new flag can be added for that purpose. Cc: Christian Koenig Cc: "Thom

Re: [PATCH v3 07/23] dt-bindings: power: supply: add maxim,max77705

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > add maxim,max77705 fuel gauge binding part > > Signed-off-by: Dzmitry Sankouski > --- > .../bindings/power/supply/maxim,max77705-fg.yaml | 35 > ++ > 1 file changed, 35 insertions(+) > > diff --git > a/Documentation/devicet

Re: [PATCH v4 2/4] dt-bindings: display: panel: Add compatible for kingdisplay-kd101ne3

2024-06-20 Thread Conor Dooley
On Thu, Jun 20, 2024 at 04:05:07PM +0800, Zhaoxiong Lv wrote: > The kingdisplay-kd101ne3 is a 10.1" WXGA TFT-LCD panel with > jadard-jd9365da controller. Hence, we add a new compatible > with panel specific config. > > Signed-off-by: Zhaoxiong Lv Acked-by: Conor Dooley signature.asc Descripti

Re: [PATCH v3 19/23] power: supply: s2dos05: Add fuel gauge driver for s2dos05

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add fuel gauge driver for s2dos05 PMIC. It uses adc to measure power > on each power output s2dos05 provides, including regulator outputs > and AVDD, ELVSS, ELVDD lines. Driver registers power supply for each > corresponding power line. > > Adc can b

Re: [v11 3/7] iio: core: Add new DMABUF interface infrastructure

2024-06-20 Thread Vinod Koul
On 20-06-24, 12:45, Markus Elfring wrote: > … > > All errors (new ones prefixed by >>): > > > >>> drivers/iio/industrialio-buffer.c:1715:3: error: cannot jump from this > >>> goto statement to its label > > 1715 | goto err_dmabuf_unmap_attachment; > … > > Which software design

Re: [PATCH v3 18/23] regulator: add s2dos05 regulator support

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > S2dos05 has 1 buck and 4 LDO regulators, used for powering > panel/touchscreen. > > Signed-off-by: Dzmitry Sankouski > diff --git a/drivers/regulator/s2dos05-regulator.c > b/drivers/regulator/s2dos05-regulator.c > new file mode 100644 > index 000

Re: [PATCH v3 17/23] mfd: add s2dos series core driver

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > S2DOS05 is a panel/touchscreen PMIC, often found in > Samsung phones. We define 2 sub-devices for which drivers will > be added in subsequent patches. > > Signed-off-by: Dzmitry Sankouski > --- > MAINTAINERS| 1 + > dr

Re: [PATCH v3 14/23] power: supply: max77705: Add charger driver for Maxim 77705

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add driver for Maxim 77705 switch-mode charger (part of max77705 > MFD driver) providing power supply class information to userspace. > > The driver is configured through DTS (battery and system related > settings). Also, POWER_SUPPLY_PROP_CONSTANT_C

Re: [PATCH v3 13/23] input: add max77705 haptic driver

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add support for haptic controller on MAX77705 Multifunction > device. > > This driver supports external pwm and LRA (Linear Resonant Actuator) motor. > User can control the haptic device via force feedback framework. > > Signed-off-by: Dzmitry Sanko

Re: [PATCH v4 1/2] dt-bindings: display: panel-simple-dsi: add Starry-er88577 DSI panel bindings

2024-06-20 Thread Conor Dooley
On Thu, Jun 20, 2024 at 07:52:44PM +0800, Zhaoxiong Lv wrote: > This add the bindings for the 1280x800 TFT LCD Starry-er88577 DSI panel > to panel-simple-dsi. > > Signed-off-by: Zhaoxiong Lv Acked-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH v3 12/23] mfd: Add new driver for MAX77705 PMIC

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > Add the core MFD driver for max77705 PMIC. We define five sub-devices > for which the drivers will be added in subsequent patches. > > Signed-off-by: Dzmitry Sankouski > Co-authored-by: Rose Hudson > --- > MAINTAINERS |

Re: [PATCH v3 10/23] dt-bindings: regulator: add samsung,s2dos05

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > add samsung,s2dos05 regulator binding part Make it a proper sentence. > > Signed-off-by: Dzmitry Sankouski > --- > .../bindings/regulator/samsung,s2dos05.yaml| 36 > ++ > MAINTAINERS

Re: [PATCH 1/2] drm/amdgpu: Unmap BO memory before calling amdgpu_bo_unref()

2024-06-20 Thread Christian König
Am 20.06.24 um 16:44 schrieb Thomas Zimmermann: Prepares for using ttm_bo_vmap() and ttm_bo_vunmap() in amdgpu. Both require the caller to hold the GEM reservation lock, which is not the case while releasing a buffer object. Hence, push a possible call to unmap out from the buffer-object release

Re: [PATCH v3 09/23] dt-bindings: mfd: add samsung,s2dos05

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > add samsung,s2dos05 core MFD module binding > > Signed-off-by: Dzmitry Sankouski > --- > .../devicetree/bindings/mfd/samsung,s2dos05.yaml | 89 > ++ > MAINTAINERS| 1 + > 2 files chang

[PATCH] drm/omap: Restrict compile testing to PAGE_SIZE less than 64KB

2024-06-20 Thread Nathan Chancellor
P tristate "OMAP DRM" depends on DRM && OF - depends on ARCH_OMAP2PLUS || COMPILE_TEST + depends on ARCH_OMAP2PLUS || (COMPILE_TEST && PAGE_SIZE_LESS_THAN_64KB) select DRM_KMS_HELPER select FB_DMAMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION

[PATCH 31/31] drm/vc4: Enable SCALER_CONTROL early in HVS init

2024-06-20 Thread Dave Stevenson
From: Tim Gover Always enable SCALER_CONTROL before attempting other HVS operations. It's safe to write to some parts of the HVS but in general it's dangerous to do this because it can cause bus lockups. Signed-off-by: Tim Gover Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_hvs.c

[PATCH 20/31] drm/vc4: hvs: Remove ABORT_ON_EMPTY flag

2024-06-20 Thread Dave Stevenson
From: Dom Cobley ABORT_ON_EMPTY chooses whether the HVS abandons the current frame when it experiences an underflow, or attempts to continue. In theory the frame should be black from the point of underflow, compared to a shift of sebsequent pixels to the left. Unfortunately it seems to put the

[PATCH 28/31] drm/vc4: hvs: Rework LBM alignment

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard With the introduction of the support for BCM2712, the check of whether we're running on vc5 or not to compute the LBM alignment requirement doesn't work anymore. Moreover, the LBM size will need to be computed in words for the BCM2712, while we've had sizes in bytes so far.

[PATCH 24/31] drm/vc4: hvs: Create hw_init function

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard Since the BCM2712 will feature a significantly different HVS, let's move the hardware initialisation part of our bind function into a separate function. That way, it will be easier to extend in the future. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- dri

Re: [PATCH v3 06/23] dt-bindings: power: supply: add maxim,max77705 charger

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > add maxim,max77705 charger binding part Make it a proper sentence. > > Signed-off-by: Dzmitry Sankouski > --- > .../power/supply/maxim,max77705-charger.yaml | 30 > ++ > 1 file changed, 30 insertions(+) > > diff --git

[PATCH 21/31] drm/vc4: Introduce generation number enum

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard With the introduction of the BCM2712 support, we will get yet another generation of display engine to support. The binary check of whether it's VC5 or not thus doesn't work anymore, especially since some parts of the driver will have changed with BCM2711, and some others with

[PATCH 16/31] drm/vc4: UV planes vertical scaling must always be enabled

2024-06-20 Thread Dave Stevenson
It has been observed that a YUV422 unity scaled plane isn't displayed. Enabling vertical scaling on the UV planes solves this. There is already a similar clause to always enable horizontal scaling on the UV planes. Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_plane.c | 6 ++ 1 f

[PATCH 22/31] drm/vc4: Make v3d paths unavailable on any generation newer than vc4

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard The V3D IP has been separate since BCM2711, so let's make sure we issue a WARN if we're running not only on BCM2711, but also anything newer. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_bo.c | 28 +++-

[PATCH 29/31] drm/vc4: hvs: Change prototype of __vc4_hvs_alloc to pass registers

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard The BCM2712 HVS has registers to report the size of the various SRAM the driver uses, and their size actually differ depending on the stepping. The initialisation of the memory pools happen in the __vc4_hvs_alloc() function that also allocates the main HVS structure, that wil

[PATCH 25/31] drm/vc4: hvs: Create cob_init function

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard Just like the HVS itself, the COB parameters will be fairly different in the BCM2712. Let's move the COB parameters computation and its initialisation to a separate function that will be easier to extend in the future. Signed-off-by: Maxime Ripard Signed-off-by: Dave Steven

[PATCH 26/31] drm/vc4: hvs: Rename hvs_regs list

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard The HVS register set has been heavily modified in the BCM2712, and we'll thus need a separate debugfs_reg32 array for it. The name hvs_regs is thus a bit too generic, so let's rename it to something more specific. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson

[PATCH 27/31] drm/vc4: plane: Change ptr0_offset to an array

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard The BCM2712 will have a fairly different dlist, that will feature one Pointer 0 word for each plane. Let's prepare by changing the ptr0_offset variable that holds the offset in a dlist of the pointer 0 word to an array. Signed-off-by: Maxime Ripard Signed-off-by: Dave Steve

[PATCH 23/31] drm/vc4: hvs: Use switch statement to simplify vc4_hvs_get_fifo_from_output

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard Since we'll support BCM2712 soon, let's move the logic behind vc4_hvs_get_fifo_from_output() to a switch to extend it more easily. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_hvs.c | 77 +++ 1 file

[PATCH 30/31] drm/vc4: Move the buffer offset out of the vc4_plane_state

2024-06-20 Thread Dave Stevenson
The offset fields in vc4_plane_state are described as being the offset for each buffer in the bo, however it is used to store the complete DMA address that is then written into the register. The DMA address including the fb ofset can be retrieved using drm_fb_dma_get_gem_addr, and the offset adju

Re: [PATCH v3 05/23] dt-bindings: input: add maxim,max77705-haptic

2024-06-20 Thread Krzysztof Kozlowski
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > maxim,max77705-haptic is MAX77705 pmic binding part > > + > +maintainers: > + - Dzmitry Sankouski > + > +description: | > + This is a part of device tree bindings for Maxim MAX77705 multi functional > device. Wrap according to Linux coding sty

[PATCH 17/31] drm/vc4: hdmi: Avoid hang with debug registers when suspended

2024-06-20 Thread Dave Stevenson
From: Dom Cobley Trying to read /sys/kernel/debug/dri/1/hdmi1_regs when the hdmi is disconnected results in a fatal system hang. This is due to the pm suspend code disabling the dvp clock. That is just a gate of the 108MHz clock in DVP_HT_RPI_MISC_CONFIG, which results in accesses hanging AXI bu

[PATCH 03/31] drm/vc4: Force trigger of dlist update on margins change

2024-06-20 Thread Dave Stevenson
When the margins are changed, the dlist needs to be regenerated with the changed updated dest regions for each of the planes. Setting the zpos_changed flag is sufficient to trigger that without doing a full modeset, therefore set it should the margins be changed. Signed-off-by: Dave Stevenson --

[PATCH 04/31] drm/vc4: hdmi: Avoid log spam for audio start failure

2024-06-20 Thread Dave Stevenson
From: Dom Cobley We regularly get dmesg error reports of: [ 18.184066] hdmi-audio-codec hdmi-audio-codec.3.auto: ASoC: error at snd_soc_dai_startup on i2s-hifi: -19 [ 18.184098] MAI: soc_pcm_open() failed (-19) These are generated for any disconnected hdmi interface when pulseaudio attempt

[PATCH 14/31] drm/vc4: crtc: Move assigned_channel to a variable

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard We access multiple times the vc4_crtc_state->assigned_channel variable in the vc4_crtc_get_scanout_position() function, so let's store it in a local variable. Signed-off-by: Maxime Ripard Signed-off-by: Dave Stevenson --- drivers/gpu/drm/vc4/vc4_crtc.c | 7 --- 1 file

[PATCH 13/31] drm/vc4: plane: Use return variable in atomic_check

2024-06-20 Thread Dave Stevenson
From: Maxime Ripard The vc4_plane_atomic_check() directly returns the result of the final function it calls. Using the already defined ret variable to check its content on error, and a separate return 0 on success, makes it easier to extend. Signed-off-by: Maxime Ripard Signed-off-by: Dave Ste

  1   2   3   >