[PATCH v2] drm/vc4: Fix atomicity violation in vc4_crtc_send_vblank()

2024-10-29 Thread Qiu-ji Chen
An atomicity violation occurs when the vc4_crtc_send_vblank function executes simultaneously with modifications to crtc->state->event. Consider a scenario where crtc->state->event is non-null, allowing it to pass the validity check. However, at the same time, crtc->state->event might be set to

[linux-next:fs-next] [fs] 0eccf222d7: Oops:general_protection_fault, probably_for_non-canonical_address#:#[##]PREEMPT_SMP_KASAN_PTI

2024-10-29 Thread kernel test robot
Hello, for this commit but in linux-next/fs-next branch, we notice crash issue in vm/booting tests kernel test robot noticed "Oops:general_protection_fault,probably_for_non-canonical_address#:#[##]PREEMPT_SMP_KASAN_PTI" on: commit: 0eccf222d798166ce42a4ed0da91a0cb14945c7a ("fs: port files t

RE: [EXT] Re: [PATCH v16 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ

2024-10-29 Thread Sandor Yu
> > Am Dienstag, dem 02.07.2024 um 20:22 +0800 schrieb Sandor Yu: > > This patchset sits on top > > Dmitry's 'make use of the HDMI connector infrastructure' patchset > > ([2]). > > > > The patch set initial support Cadence MHDP8501(HDMI/DP) DRM bridge > > driver and Cadence HDP-TX PHY(HDMI/DP) dri

Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-10-29 Thread 胡俊光

Re: [PATCH v2] driver core: fw_devlink: Stop trying to optimize cycle detection logic

2024-10-29 Thread Saravana Kannan
On Tue, Oct 29, 2024 at 4:21 AM Tomi Valkeinen wrote: > > Hi, > > On 28/10/2024 22:39, Saravana Kannan wrote: > > On Mon, Oct 28, 2024 at 1:06 AM Tomi Valkeinen > > wrote: > >> > >> Hi, > >> > >> On 26/10/2024 07:52, Saravana Kannan wrote: > >>> In attempting to optimize fw_devlink runtime, I int

[PATCH v2] drm/msm/dpu: cast crtc_clk calculation to u64 in _dpu_core_perf_calc_clk()

2024-10-29 Thread Gax-c
From: Zichen Xie There may be a potential integer overflow issue in _dpu_core_perf_calc_clk(). crtc_clk is defined as u64, while mode->vtotal, mode->hdisplay, and drm_mode_vrefresh(mode) are defined as a smaller data type. The result of the calculation will be limited to "int" in this case withou

linux-next: duplicate patch in the iommu tree

2024-10-29 Thread Stephen Rothwell
Hi all, The following commits are also in other trees as a different commits (but the same patches): 0c069019f33d ("media: nvidia: tegra: Use iommu_paging_domain_alloc()") ba1057ab5d01 ("drm/nouveau/tegra: Use iommu_paging_domain_alloc()") These are commits bf7835facc09 ("drm/nouveau/tegr

Re: [PATCH] drm/mediatek: Drop dependency on ARM

2024-10-29 Thread 胡俊光

Re: [PATCH v1 05/10] media: platform: mediatek: add isp_7x camsys unit

2024-10-29 Thread 胡俊光

Re: [PATCH V2 drm-dp 2/4] drm/hisilicon/hibmc: add dp link moduel in hibmc

2024-10-29 Thread Dmitry Baryshkov
On Tue, 29 Oct 2024 at 16:15, Yongbang Shi wrote: > > > On Tue, Oct 22, 2024 at 08:41:46PM +0800, Yongbang Shi wrote: > >> From: baihan li > >> > >> Add link training process functions in this moduel. > > We should probably have a bounty for a developer who finally writes a > > generic DP link tr

Re: [PATCH v4 00/13] Add ITE IT6263 LVDS to HDMI converter support

2024-10-29 Thread Dmitry Baryshkov
On Tue, 29 Oct 2024 at 04:41, Liu Ying wrote: > > On 10/28/2024, Dmitry Baryshkov wrote: > > On Mon, Oct 28, 2024 at 11:12:00AM +, Biju Das wrote: > >> Hi Dmitry, Liu, > >> > >>> -Original Message- > >>> From: Dmitry Baryshkov > >>> Sent: 28 October 2024 10:20 > >>> Subject: Re: [PATC

[PATCH v4 3/3] drm/tests: hdmi: Fix memory leaks in drm_display_mode_from_cea_vic()

2024-10-29 Thread Jinjie Ruan
modprobe drm_hdmi_state_helper_test and then rmmod it, the following memory leak occurs. The `mode` allocated in drm_mode_duplicate() called by drm_display_mode_from_cea_vic() is not freed, which cause the memory leak: unreferenced object 0xff80ccd18100 (size 128): comm "kun

[PATCH v4 1/3] drm/tests: helpers: Add helper for drm_display_mode_from_cea_vic()

2024-10-29 Thread Jinjie Ruan
As Maxime suggested, add a new helper drm_kunit_display_mode_from_cea_vic(), it can replace the direct call of drm_display_mode_from_cea_vic(), and it will help solving the `mode` memory leaks. Acked-by: Maxime Ripard Suggested-by: Maxime Ripard Signed-off-by: Jinjie Ruan --- v4: - Return NULL

[PATCH v4 2/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()

2024-10-29 Thread Jinjie Ruan
modprobe drm_connector_test and then rmmod drm_connector_test, the following memory leak occurs. The `mode` allocated in drm_mode_duplicate() called by drm_display_mode_from_cea_vic() is not freed, which cause the memory leak: unreferenced object 0xff80cb0ee400 (size 128): c

[PATCH v4 0/3] drm/tests: Fix some memory leaks

2024-10-29 Thread Jinjie Ruan
Fix some memory leaks in drm tests. Changes in v4: - Return NULL early if drm_display_mode_from_cea_vic() return NULL for drm_kunit_display_mode_from_cea_vic() helper as Maxime suggested. - Split out the separate ttm test patch. Changes in v3: - Adjust drm/drm_edid.h header to drm_kunit_helpers

Re: [PATCH v4 15/18] dt-bindings: usb: Add ports to google,cros-ec-typec for DP altmode

2024-10-29 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2024-10-25 03:49:36) > On Tue, Oct 22, 2024 at 06:15:47PM -0700, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2024-09-20 02:38:53) > > > On Sat, Aug 31, 2024 at 09:06:53PM GMT, Stephen Boyd wrote: > > > > > Either way the problem seems to be that I need to associate o

Re: [PATCH v4] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create()

2024-10-29 Thread Jinjie Ruan
Gentle ping. On 2024/10/26 10:07, Jinjie Ruan wrote: > modprobe ttm_device_test and then rmmod ttm_device_test, the following > memory leaks occurs: > > The ttm->pages allocated in ttm_tt_init() is not freed after calling > ttm_tt_simple_create(), which cause the memory leak: > > unreferen

Re: [PATCH V2 drm-dp 1/4] drm/hisilicon/hibmc: add dp aux in hibmc

2024-10-29 Thread Dmitry Baryshkov
On Tue, 29 Oct 2024 at 16:15, Yongbang Shi wrote: > > > On Tue, Oct 22, 2024 at 08:41:45PM +0800, Yongbang Shi wrote: > >> From: baihan li > >> +} > >> + > >> +enum dpcd_revision { > >> +DPCD_REVISION_10 = 0x10, > >> +DPCD_REVISION_11, > >> +DPCD_REVISION_12, > >> +DPCD_REVISION_

Re: [PATCH v3 1/4] drm/tests: helpers: Add helper for drm_display_mode_from_cea_vic()

2024-10-29 Thread Jinjie Ruan
On 2024/10/29 16:16, Maxime Ripard wrote: > On Thu, Oct 17, 2024 at 02:31:22PM +0800, Jinjie Ruan wrote: >> As Maxime suggested, add a new helper >> drm_kunit_display_mode_from_cea_vic(), it can replace the direct call >> of drm_display_mode_from_cea_vic(), and it will help solving >> the `mode`

Re: [PATCH] amdgpu: prevent NULL pointer dereference if ATIF is not supported

2024-10-29 Thread Mario Limonciello
On 10/29/2024 18:32, Antonio Quartulli wrote: acpi_evaluate_object() may return AE_NOT_FOUND (failure), which would result in dereferencing buffer.pointer (obj) while being NULL. Bail out also when status is AE_NOT_FOUND with a proper error message. This fixes 1 FORWARD_NULL issue reported by C

[RFC PATCH] i2c: skip of_i2c_register_device() for invalid child nodes

2024-10-29 Thread Abhinav Kumar
of_i2c_register_devices() adds all child nodes of a given i2c bus however in certain device trees of_alias_from_compatible() and of_property_read_u32() can fail as the child nodes of the device might not be valid i2c client devices. One such example is the i2c aux device for the DRM MST toplogy man

[PATCH v2 0/3] DRM deadcode

2024-10-29 Thread linux
From: "Dr. David Alan Gilbert" This is a bunch of deadcode removals; the first two are strictly whole function removals; the last as a revert also undoes an extra parameter that was added. It was a clean revert. v2 Drop Remove unused drm_client_framebuffer_flush Jocelyn & Thomas have plan

Re: [PATCH 5/5] drm/client: Remove unused drm_client_modeset_check

2024-10-29 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (li...@treblig.org) wrote: > * Dmitry Baryshkov (dmitry.barysh...@linaro.org) wrote: > > On Wed, Oct 23, 2024 at 12:29:34AM +0100, li...@treblig.org wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > drm_client_modeset_check() was explicitly added in 2020 by > > > co

[PATCH v2 2/3] drm/sysfs: Remove unused drm_class_device_(un)register

2024-10-29 Thread linux
From: "Dr. David Alan Gilbert" drm_class_device_register() and drm_class_device_unregister() have been unused since commit ed89fff97382 ("drm/ttm: drop sysfs directory") Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_sysfs.c | 32

[PATCH v2 3/3] Revert "drm/client: Add drm_client_modeset_check()"

2024-10-29 Thread linux
From: "Dr. David Alan Gilbert" drm_client_modeset_check() was explicitly added in 2020 by commit 64593f2a6fc9 ("drm/client: Add drm_client_modeset_check()") but has never been used. This reverts commit 64593f2a6fc933bb9a410bc3f8c261f3e57a9601. Signed-off-by: Dr. David Alan Gilbert --- drivers

[PATCH v2 1/3] drm: Remove unused drm_atomic_helper_commit_planes_on_crtc

2024-10-29 Thread linux
From: "Dr. David Alan Gilbert" The last use of drm_atomic_helper_commit_planes_on_crtc() was removed in 2018 by commit 6c246b81f938 ("drm/i915: Replace call to commit_planes_on_crtc with internal update, v2.") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Dmitry Baryshkov ---

[PATCH v2 3/3] drm/msm/dp: tidy up platform data names

2024-10-29 Thread Dmitry Baryshkov
Follow the established symbol name pattern and rename platform data structures. Reviewed-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/

Re: [PATCH] accel/ivpu: Fix NOC firewall interrupt handling

2024-10-29 Thread Jeffrey Hugo
On 10/17/2024 8:49 AM, Jacek Lawrynowicz wrote: From: Andrzej Kacprowski The NOC firewall interrupt means that the HW prevented unauthorized access to a protected resource, so there is no need to trigger device reset in such case. To facilitate security testing add firewall_irq_counter debugfs

Re: [PATCH v6 8/9] drm/msm/dpu: allow using two SSPP blocks for a single plane

2024-10-29 Thread Abhinav Kumar
On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote: Virtual wide planes give high amount of flexibility, but it is not always enough: In parallel multirect case only the half of the usual width is supported for tiled formats. Thus the whole width of two tiled multirect rectangles can not be greate

Re: [PATCH v6 7/9] drm/msm/dpu: add support for virtual planes

2024-10-29 Thread Abhinav Kumar
On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote: Only several SSPP blocks support such features as YUV output or scaling, thus different DRM planes have different features. Properly utilizing all planes requires the attention of the compositor, who should prefer simpler planes to YUV-supporting

Re: [PATCH v3 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-10-29 Thread Fabio Estevam
Hi Marek, On Tue, Oct 29, 2024 at 5:16 PM Marek Vasut wrote: > So you wouldn't have to write three compatible strings for the 6sl/sll , > but only two ? I.e. this: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; > compatible = "fsl,imx6sll-lcdif", "fsl,imx28-lcdif"; i.MX6SL and i.MX6SLL

Re: [PATCH 0/7] kernel/cgroups: Add "dev" memory accounting cgroup.

2024-10-29 Thread Johannes Weiner
On Mon, Oct 28, 2024 at 11:05:48AM +0100, Maxime Ripard wrote: > On Thu, Oct 24, 2024 at 07:06:36AM -1000, Tejun Heo wrote: > > Hello, > > > > On Thu, Oct 24, 2024 at 09:20:43AM +0200, Maxime Ripard wrote: > > ... > > > > Yeah, let's not use "dev" name for this. As Waiman pointed out, it > > > >

Re: [PATCH v6 6/9] drm/msm/dpu: move rot90 checking to dpu_plane_atomic_check_sspp()

2024-10-29 Thread Abhinav Kumar
On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote: Move a call to dpu_plane_check_inline_rotation() to the dpu_plane_atomic_check_sspp() function, so that the rot90 constraints are checked for both SSPP blocks. Also move rotation field from struct dpu_plane_state to struct dpu_sw_pipe_cfg. Signed

Re: [PATCH] fbdev: udl: Make CONFIG_FB_DEVICE optional

2024-10-29 Thread Helge Deller
Hi Thomas, On 10/28/24 09:41, Thomas Zimmermann wrote: Am 25.10.24 um 17:37 schrieb Helge Deller: On 10/25/24 11:25, Gonzalo Silvalde Blanco wrote: The fb_udl driver currently depends on CONFIG_FB_DEVICE to create sysfs entries and access framebuffer device information. This patch wraps the re

Re: [PATCH v6 2/9] drm/msm/dpu: move pstate->pipe initialization to dpu_plane_atomic_check

2024-10-29 Thread Abhinav Kumar
On 10/28/2024 3:46 AM, Dmitry Baryshkov wrote: On Fri, Oct 25, 2024 at 12:00:20PM -0700, Abhinav Kumar wrote: On 10/24/2024 5:20 PM, Dmitry Baryshkov wrote: In preparation for virtualized planes support, move pstate->pipe initialization from dpu_plane_reset() to dpu_plane_atomic_check(). I

Re: [PATCH v2 2/3] drm/msm/dp: rename edp_ bridge functions and struct

2024-10-29 Thread Abhinav Kumar
On 10/29/2024 1:28 PM, Dmitry Baryshkov wrote: Follow the estalished prefix and rename eDP bridge symbols to use msm_edp_ prefix, moving the edp to the end of the symbol name. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c | 36 ++-- 1

Re: [PATCH v2 2/3] accel/ivpu: remove DRIVER_DATE conditional drm_driver init

2024-10-29 Thread Jacek Lawrynowicz
Reviewed-by: Jacek Lawrynowicz On 10/28/2024 7:51 PM, Jani Nikula wrote: > The ivpu struct drm_driver has conditional initialization based on #ifdef > DRIVER_DATE, which is never defined anywhere. Neither are the macros > referenced within the block: DRIVER_DATE, DRIVER_MAJOR, DRIVER_MINOR, > and

[PATCH v2 0/3] drm/msm/dp: mass-rename symbols

2024-10-29 Thread Dmitry Baryshkov
The LKP reported [1] a symbol clash between the drm/msm/dp and the HIMBC driver being sumbitted, because both of them use a generic dp_ prefix for a lot of symbols. It's a hight time we made msm/dp driver use something less generic, like msm_dp. [1] https://lore.kernel.org/oe-kbuild-all/2024102503

[PATCH v2 2/3] drm/msm/dp: rename edp_ bridge functions and struct

2024-10-29 Thread Dmitry Baryshkov
Follow the estalished prefix and rename eDP bridge symbols to use msm_edp_ prefix, moving the edp to the end of the symbol name. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff

Re: [PATCH v3 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback

2024-10-29 Thread Rob Herring (Arm)
On Tue, 29 Oct 2024 16:16:38 -0300, Fabio Estevam wrote: > From: Fabio Estevam > > imx6sx.dtsi has the following lcdif entries: > > compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; > > This causes the following dt-schema warning: > > ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long >

Re: [PATCH v3 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-10-29 Thread Marek Vasut
On 10/29/24 8:16 PM, Fabio Estevam wrote: From: Fabio Estevam mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; This causes dt-schema warnings as the current binding only allow 'fsl,imx6sx-lcdif' as fallback. ['fsl,imx6sl-lcdif'

Re: [PATCH 2/3] drm/msm/dp: rename edp_ bridge functions and struct

2024-10-29 Thread Dmitry Baryshkov
On Tue, 29 Oct 2024 at 20:08, Abhinav Kumar wrote: > > > > On 10/28/2024 4:49 AM, Dmitry Baryshkov wrote: > > Follow the estalished prefix and rename eDP bridge symbols to use > > msm_dp_ prefix, moving the edp to the end of the symbol name. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > d

Re: [PATCH v3 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-10-29 Thread Ahmad Fatoum
On 29.10.24 21:16, Marek Vasut wrote: > On 10/29/24 8:16 PM, Fabio Estevam wrote: >> From: Fabio Estevam >> >> mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: >> >> compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; >> >> This causes dt-schema warnings as the current binding only >>

Re: [PATCH v3] drm/amdgpu: Fix the memory allocation issue in amdgpu_discovery_get_nps_info()

2024-10-29 Thread Markus Elfring
… > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c > @@ -1757,11 +1757,13 @@ int amdgpu_discovery_get_nps_info(struct > amdgpu_device *adev, > > switch (le16_to_cpu(nps_info->v1.header.version_major)) { > case 1: > + mem_ranges = kvcalloc(nps_info->v1.count, > +

[PATCH v3 1/3] dt-bindings: lcdif: Document a imx6sx-lcdif fallback

2024-10-29 Thread Fabio Estevam
From: Fabio Estevam imx6sx.dtsi has the following lcdif entries: compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif"; This causes the following dt-schema warning: ['fsl,imx6sx-lcdif', 'fsl,imx28-lcdif'] is too long To keep DT compatibility, document 'fsl,imx28-lcdif' as a possible 'fsl,imx6sx-

[PATCH v3 3/3] ARM: dts: imx6sl: Provide a more specific lcdif compatible

2024-10-29 Thread Fabio Estevam
From: Fabio Estevam The LCDIF IP on i.MX6SL and i.MX6SLL is compatible with i.MX6SX. Provide a more specific "fsl,imx6sx-lcdif" compatible and still keep "fsl,imx28-lcdif" for DT compatibility. Signed-off-by: Fabio Estevam --- Changes since v2: - None. arch/arm/boot/dts/nxp/imx/imx6sl.dtsi

[PATCH v3 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-10-29 Thread Fabio Estevam
From: Fabio Estevam mx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; This causes dt-schema warnings as the current binding only allow 'fsl,imx6sx-lcdif' as fallback. ['fsl,imx6sl-lcdif', 'fsl,imx28-lcdif'] is too long ['fsl,imx6s

Re: [PATCH] drm/msm/dpu: Cast an operand to u64 to prevent potential overflow in _dpu_core_perf_calc_clk()

2024-10-29 Thread Abhinav Kumar
On 10/29/2024 9:26 AM, Gax-c wrote: From: Zichen Xie There may be a potential integer overflow issue in _dpu_core_perf_calc_clk(). crtc_clk is defined as u64, while mode->vtotal, mode->hdisplay, and drm_mode_vrefresh(mode) are defined as a smaller data type. The result of the calculation wil

lockdep and ww mutex debug interactions in hdmi tests

2024-10-29 Thread Dave Airlie
Hi, I mentioned this internally, but wanted to get it on the list, I ran the hdmi kunit tests with LOCKDEP and WW_MUTEX_SLOWPATH enabled and hit some issues. With the slowpath we get the occasional EDEADLK to test the paths are doing things right, I think you should handle EDEADLK in the tests w

Re: [PATCH v2 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

2024-10-29 Thread Andreas Kemnade
Am Tue, 29 Oct 2024 09:02:35 -0300 schrieb Fabio Estevam : > From: Fabio Estevam > > imx6sl.dtsi and imx6sll.dtsi have the following lcdif entries: > > compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; > > This causes dt-schema warnings as the current binding only > allow 'fsl,imx6sx-lcdif'

Re: [PATCH] drm/nouveau/gr/gf100: Fix missing unlock in gf100_gr_chan_new()

2024-10-29 Thread Lyude Paul
Reviewed-by: Lyude Paul Will push upstream in a moment On Sun, 2024-10-27 at 01:38 +0800, Li Huafei wrote: > When the call to gf100_grctx_generate() fails, unlock gr->fecs.mutex > before returning the error. > > Fixes smatch warning: > > drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:480 gf100

[PATCH] MAINTAINERS: add Raphael Gallais-Pou to DRM/STi maintainers

2024-10-29 Thread Raphael Gallais-Pou
Add myself as a maintainer for STi driver changes. Signed-off-by: Raphael Gallais-Pou --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 71b739b40921..0e583aae590a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7477,6 +7477,7 @@ F:drivers/

Re: [PATCH 2/3] drm/msm/dp: rename edp_ bridge functions and struct

2024-10-29 Thread Abhinav Kumar
On 10/28/2024 4:49 AM, Dmitry Baryshkov wrote: Follow the estalished prefix and rename eDP bridge symbols to use msm_dp_ prefix, moving the edp to the end of the symbol name. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_drm.c | 36 ++-- 1 f

Re: [PATCH 3/3] drm/msm/dp: tidy up platform data names

2024-10-29 Thread Abhinav Kumar
On 10/28/2024 4:49 AM, Dmitry Baryshkov wrote: Follow the established symbol name pattern and rename platform data structures. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_display.c | 38 ++--- 1 file changed, 19 insertions(+), 19 deletions

Re: [PATCH 1/3] drm/msm/dp: prefix all symbols with msm_dp_

2024-10-29 Thread Abhinav Kumar
On 10/28/2024 4:49 AM, Dmitry Baryshkov wrote: For historical reasons a lot of symbols in the MSM DisplayPort driver used the generic dp_ prefix. Perform a mass-rename of those symbols to use msm_dp prefix. Basically this is a result of the following script: sed drivers/gpu/drm/msm/dp/* -i -

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 1:05 PM R Sundar wrote: > > On 29/10/24 19:11, Alex Deucher wrote: > > On Sun, Oct 27, 2024 at 10:18 AM R Sundar wrote: > >> > >> Use string choice helpers for better readability. > > > > I personally find this less readable, but if this is the preferred > > method going f

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2024-10-29 Thread R Sundar
On 29/10/24 19:11, Alex Deucher wrote: On Sun, Oct 27, 2024 at 10:18 AM R Sundar wrote: Use string choice helpers for better readability. I personally find this less readable, but if this is the preferred method going forward, I'm fine to take the patch. Alex Hi, Thanks for the comments

[PATCH] drm/vmwgfx: avoid null_ptr_deref in vmw_framebuffer_surface_create_handle

2024-10-29 Thread Chen Ridong
From: Chen Ridong The 'vmw_user_object_buffer' function may return NULL with incorrect inputs. To avoid possible null pointer dereference, add a check whether the 'bo' is NULL in the vmw_framebuffer_surface_create_handle. Fixes: d6667f0ddf46 ("drm/vmwgfx: Fix handling of dumb buffers") Signed-of

Re: [PATCH] fbdev: Constify struct sbus_mmap_map

2024-10-29 Thread Enrico Weigelt, metux IT consult
On 13.10.24 13:48, Christophe JAILLET wrote: 'struct sbus_mmap_map' are not modified in these drivers. Constifying this structure moves some data to a read-only section, so increases overall security. Update sbusfb_mmap_helper() accordingly. On a x86_64, with allmodconfig, as an example: Bef

Re: [PATCH] drm/v3d: Drop allocation of object without mountpoint

2024-10-29 Thread Matthias Brugger
Hi Maria, On 29/10/2024 01:41, Maíra Canal wrote: Hi Matthias, Thanks for your patch! On 28/10/24 11:27, matthias@kernel.org wrote: From: Matthias Brugger Function drm_gem_shmem_create_with_mnt() creates an object without using the mountpoint if gemfs is NULL. Drop the else branch call

Re: [PATCH v6 02/15] net: generalise net_iov chunk owners

2024-10-29 Thread Pavel Begunkov
On 10/28/24 12:11, Christoph Hellwig wrote: On Thu, Oct 24, 2024 at 05:40:02PM +0100, Pavel Begunkov wrote: On 10/24/24 17:06, Christoph Hellwig wrote: On Thu, Oct 24, 2024 at 03:23:06PM +0100, Pavel Begunkov wrote: That's not what this series does. It adds the new memory_provider_ops set of

[PATCH] drm/msm/dpu: Cast an operand to u64 to prevent potential overflow in _dpu_core_perf_calc_clk()

2024-10-29 Thread Gax-c
From: Zichen Xie There may be a potential integer overflow issue in _dpu_core_perf_calc_clk(). crtc_clk is defined as u64, while mode->vtotal, mode->hdisplay, and drm_mode_vrefresh(mode) are defined as a smaller data type. The result of the calculation will be limited to "int" in this case withou

Re: [PATCH v3 3/3] drm/panthor: Report innocent group kill

2024-10-29 Thread Boris Brezillon
On Tue, 29 Oct 2024 16:29:12 +0100 Boris Brezillon wrote: > Groups can be killed during a reset even though they did nothing wrong. > That usually happens when the FW is put in a bad state by other groups, > resulting in group suspension failures when the reset happens. > > If we end up in that

[PATCH 6.1 1/1] Revert "drm/amd/display: Skip Recompute DSC Params if no Stream on Link"

2024-10-29 Thread Fedor Pchelkin
This reverts commit 7c887efda1201110211fed8921a92a713e0b6bcd. It is a duplicate of the change made in 6.1.105 by commit 282f0a482ee6 ("drm/amd/display: Skip Recompute DSC Params if no Stream on Link"). This is a consequence of two "similar" upstream commits existence, one of which has been cherry

Re: [PATCH drm-next] drm/xe/xe2: Remove duplicate XE2LPM_* register definitions

2024-10-29 Thread Lucas De Marchi
On Tue, Oct 29, 2024 at 10:30:33AM +0100, Geert Uytterhoeven wrote: Merging commits e1f813947ccf2326 ("drm/xe/xe2: Extend performance tuning to media GT") and 876253165f3eaaac ("drm/xe/xe2: Add performance tuning for L3 cache flushing") with their upstream counterparts 6ef5a04221aaeb85 and 3bf909

Re: [PATCH] drm/fourcc: add AMD_FMT_MOD_TILE_GFX9_4K_D_X

2024-10-29 Thread Alex Deucher
On Fri, Oct 25, 2024 at 2:03 AM Qiang Yu wrote: > > From: Qiang Yu > > This is used when radeonsi export small texture's modifier > to user with eglExportDMABUFImageQueryMESA(). > > mesa changes is available here: > https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31658 > > Signed-off-by

Re: [PATCH V5 07/10] accel/amdxdna: Add command execution

2024-10-29 Thread Lizhi Hou
On 10/25/24 10:55, Jeffrey Hugo wrote: On 10/21/2024 10:19 AM, Lizhi Hou wrote: diff --git a/include/uapi/drm/amdxdna_accel.h b/include/uapi/drm/amdxdna_accel.h index 3792750834b2..08f3ec7146ab 100644 --- a/include/uapi/drm/amdxdna_accel.h +++ b/include/uapi/drm/amdxdna_accel.h @@ -13,6 +13,7

[PATCH v3 2/3] drm/panthor: Report group as timedout when we fail to properly suspend

2024-10-29 Thread Boris Brezillon
If we don't do that, the group is considered usable by userspace, but all further GROUP_SUBMIT will fail with -EINVAL. Changes in v3: - Add R-bs Changes in v2: - New patch Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") Signed-off-by: Boris Brezillon Reviewed-by: Steven Pri

[PATCH v3 3/3] drm/panthor: Report innocent group kill

2024-10-29 Thread Boris Brezillon
Groups can be killed during a reset even though they did nothing wrong. That usually happens when the FW is put in a bad state by other groups, resulting in group suspension failures when the reset happens. If we end up in that situation, flag the group innocent and report innocence through a new

[PATCH v3 1/3] drm/panthor: Fail job creation when the group is dead

2024-10-29 Thread Boris Brezillon
Userspace can use GROUP_SUBMIT errors as a trigger to check the group state and recreate the group if it became unusable. Make sure we report an error when the group became unusable. Changes in v3: - None Changes in v2: - Add R-bs Fixes: de8548813824 ("drm/panthor: Add the scheduler logical bloc

[PATCH v3 0/3] drm/panthor: Fix group state reporting

2024-10-29 Thread Boris Brezillon
Hello, What initially started as a simple fix to avoid queueing jobs to a group that can't be scheduled has turned into a series of three patches improving the group state reporting. Two of them are actual fixes, the last one is an improvement to properly report innocence/guiltiness of a group whe

Re: [PATCH V5 00/10] AMD XDNA driver

2024-10-29 Thread Lizhi Hou
On 10/25/24 15:02, Jeffrey Hugo wrote: On 10/25/2024 3:28 PM, Lizhi Hou wrote: On 10/25/24 10:55, Jeffrey Hugo wrote: On 10/21/2024 10:19 AM, Lizhi Hou wrote: This patchset introduces a new Linux Kernel Driver, amdxdna for AMD NPUs. The driver is based on Linux accel subsystem. NPU (Neura

Re: [PATCH 0/1] On DRM -> stable process

2024-10-29 Thread Fedor Pchelkin
On Tue, 29. Oct 10:20, Sasha Levin wrote: > On Tue, Oct 29, 2024 at 04:31:40PM +0300, Fedor Pchelkin wrote: > > BTW, a question to the stable-team: what Git magic (3-way-merge?) let the > > duplicate patch be applied successfully? The patch context in stable trees > > was different to that moment s

Re: [RFC PATCH] drm/bridge: panel: Use devm_drm_bridge_add()

2024-10-29 Thread Fei Shao
On Thu, Oct 24, 2024 at 8:36 PM Maxime Ripard wrote: > > On Wed, Oct 09, 2024 at 01:23:31PM +0800, Fei Shao wrote: > > In the mtk_dsi driver, its DSI host attach callback calls > > devm_drm_of_get_bridge() to get the next bridge. If that next bridge is > > a panel bridge, a panel_bridge object is

Re: [PATCH v2 3/3] drm: remove driver date from struct drm_driver and all drivers

2024-10-29 Thread Jeffrey Hugo
On 10/28/2024 12:51 PM, Jani Nikula wrote: We stopped using the driver initialized date in commit 7fb8af6798e8 ("drm: deprecate driver date") and (eventually) started returning "0" for drm_version ioctl instead. Finish the job, and remove the unused date member from struct drm_driver, its initia

[PATCH libdrm] modetest: Make modetest availble to vendor on Android

2024-10-29 Thread Rob Barnes
Make modetest available to vendors on Android. libdrm_util and libdrm_test_headers is also made available to vendors since these are depenencies of modetest. This results in the module target modetest.vendor being availble to vendor modules. Signed-off-by: Rob Barnes --- tests/Android.bp

Re: [PATCH V2 drm-dp 1/4] drm/hisilicon/hibmc: add dp aux in hibmc

2024-10-29 Thread Yongbang Shi
On Tue, Oct 22, 2024 at 08:41:45PM +0800, Yongbang Shi wrote: From: baihan li Add dp aux read/write functions. They are basic functions and will be used later. Signed-off-by: baihan li --- ChangeLog: v1 -> v2: - using drm_dp_aux frame implement dp aux read and write functions, suggested b

[PATCH 1/2] drm/cirrus: Use virtual encoder and connector types

2024-10-29 Thread Thomas Zimmermann
The cirrus driver only works on emulated Cirrus hardware. Use the correct types for encoder and connector. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/tiny/cirrus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tiny/cirrus.c b/drivers/gpu/drm/ti

[PATCH 2/2] drm/cirrus: Rename to cirrus-qemu

2024-10-29 Thread Thomas Zimmermann
This driver is only for Qemu's emulated Cirrus hardware. Name it accordingly. Signed-off-by: Thomas Zimmermann --- MAINTAINERS | 2 +- drivers/gpu/drm/tiny/Makefile| 2 +- drivers/gpu/drm/tiny/{cirrus.c => cirrus-qemu.c} | 2 +- 3 files ch

[PATCH 0/2] drm/cirrus: Don't pretend to operate hardware

2024-10-29 Thread Thomas Zimmermann
The cirrus driver is only for qemu's emulation of that hardware. The two patches in this series update cirrus to reflect this. (The driver is still obsolete. Use something else if possible.) Thomas Zimmermann (2): drm/cirrus: Use virtual encoder and connector types drm/cirrus: Rename to cirru

Re: [PATCH v2] drm/amdgpu: add dce6 drm_panic support

2024-10-29 Thread Alex Deucher
Applied. Thanks. Alex On Mon, Aug 12, 2024 at 2:10 AM Lu Yao wrote: > > Add support for the drm_panic module, which displays a pretty user > friendly message on the screen when a Linux kernel panic occurs. > > Signed-off-by: Lu Yao > --- > Changes in v2: > 1. Drop include "drm_internal.h" > 2.

Re: [PATCH 0/1] On DRM -> stable process

2024-10-29 Thread Sasha Levin
On Tue, Oct 29, 2024 at 04:31:40PM +0300, Fedor Pchelkin wrote: BTW, a question to the stable-team: what Git magic (3-way-merge?) let the duplicate patch be applied successfully? The patch context in stable trees was different to that moment so should the duplicate have been expected to fail to b

Re: [PATCH V2 drm-dp 1/4] drm/hisilicon/hibmc: add dp aux in hibmc

2024-10-29 Thread Yongbang Shi
On Tue, Oct 22, 2024 at 08:41:45PM +0800, Yongbang Shi wrote: From: baihan li Add dp aux read/write functions. They are basic functions and will be used later. Signed-off-by: baihan li --- ChangeLog: v1 -> v2: - using drm_dp_aux frame implement dp aux read and write functions, suggested b

Re: [PATCH V2 drm-dp 2/4] drm/hisilicon/hibmc: add dp link moduel in hibmc

2024-10-29 Thread Yongbang Shi
On Tue, Oct 22, 2024 at 08:41:46PM +0800, Yongbang Shi wrote: From: baihan li Add link training process functions in this moduel. We should probably have a bounty for a developer who finally writes a generic DP link training helpers. Signed-off-by: baihan li Missing SoB --- ChangeLog: v1

Re: [PATCH v2 2/3] drm/panthor: Report group as timedout when we fail to properly suspend

2024-10-29 Thread Liviu Dudau
On Mon, Oct 28, 2024 at 12:48:14PM +0100, Boris Brezillon wrote: > If we don't do that, the group is considered usable by userspace, but > all further GROUP_SUBMIT will fail with -EINVAL. > > Changes in v2: > - New patch > > Fixes: de8548813824 ("drm/panthor: Add the scheduler logical block") > S

Re: [PATCH v3] drm/amdgpu: Fix the memory allocation issue in amdgpu_discovery_get_nps_info()

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 8:53 AM Li Huafei wrote: > > Fix two issues with memory allocation in amdgpu_discovery_get_nps_info() > for mem_ranges: > > - Add a check for allocation failure to avoid dereferencing a null >pointer. > > - As suggested by Christophe, use kvcalloc() for memory allocat

Re: [PATCH] drm/amd/display: Remove last parts of timing_trace

2024-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Oct 10, 2024 at 4:52 PM wrote: > > From: "Dr. David Alan Gilbert" > > Commit c2c2ce1e9623 ("drm/amd/display: Optimize passive update planes.") > removed the last caller of context_timing_trace. > Remove it. > > With that gone, no one is now looking at the 'timing_

Re: [PATCH] drm/amd/display: Remove unused cm3_helper_translate_curve_to_degamma_hw_format

2024-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Tue, Oct 8, 2024 at 8:43 PM wrote: > > From: "Dr. David Alan Gilbert" > > cm3_helper_translate_curve_to_degamma_hw_format() since it was added in > 2020's commit > 03f54d7d3448 ("drm/amd/display: Add DCN3 DPP") > > Remove it. > > Signed-off-by: Dr. David Alan Gilbert

Re: [PATCH linux-next] drm/amdgpu: use string choice helpers

2024-10-29 Thread Alex Deucher
On Sun, Oct 27, 2024 at 10:18 AM R Sundar wrote: > > Use string choice helpers for better readability. I personally find this less readable, but if this is the preferred method going forward, I'm fine to take the patch. Alex > > Reported-by: kernel test robot > Reported-by: Julia Lawall > Clo

Re: [PATCH] drm/sched: Document purpose of drm_sched_{start,stop}

2024-10-29 Thread Alex Deucher
On Tue, Oct 29, 2024 at 9:39 AM Philipp Stanner wrote: > > drm_sched_start()'s and drm_sched_stop()'s names suggest that those > functions might be intended for actively starting and stopping the > scheduler on initialization and teardown. > > They are, however, only used on timeout handling (rese

[PATCH] drm/sched: Document purpose of drm_sched_{start,stop}

2024-10-29 Thread Philipp Stanner
drm_sched_start()'s and drm_sched_stop()'s names suggest that those functions might be intended for actively starting and stopping the scheduler on initialization and teardown. They are, however, only used on timeout handling (reset recovery). The docstrings should reflect that to prevent confusio

[PATCH 0/1] On DRM -> stable process

2024-10-29 Thread Fedor Pchelkin
Hi all, I'm writing as a bystander working with 6.1.y stable branch and possibly lacking some context with the established DRM -> stable patch flow, Cc'ing a large number of people. The commit being reverted from 6.1.y is the one that duplicates the changes already backported to that branch with

Re: [PATCH v4 3/7] PCI: Add a helper to convert between standard and IOV resources

2024-10-29 Thread Christian König
Am 25.10.24 um 23:50 schrieb Michał Winiarski: There are multiple places where conversions between IOV resources and standard resources are done. Extract the logic to pci_resource_to_iov() and pci_resource_from_iov() helpers. Suggested-by: Ilpo Järvinen Signed-off-by: Michał Winiarski I don

Re: [PATCH v4 2/7] PCI: Add a helper to identify IOV resources

2024-10-29 Thread Christian König
Am 25.10.24 um 23:50 schrieb Michał Winiarski: There are multiple places where special handling is required for IOV resources. Extract it to pci_resource_is_iov() helper and drop a few ifdefs. Signed-off-by: Michał Winiarski Reviewed-by: Ilpo Järvinen Reviewed-by: Christian König --- d

Re: [PATCH v4 1/7] PCI/IOV: Restore VF resizable BAR state after reset

2024-10-29 Thread Christian König
Am 25.10.24 um 23:50 schrieb Michał Winiarski: Similar to regular resizable BAR, VF BAR can also be resized, e.g. by the system firmware or the PCI subsystem itself. Add the capability ID and restore it as a part of IOV state. See PCIe r4.0, sec 9.3.7.4. Signed-off-by: Michał Winiarski Review

Re: [PATCH] drm/panthor: use defines for sync flags

2024-10-29 Thread Boris Brezillon
On Tue, 29 Oct 2024 10:46:29 +0100 Erik Faye-Lund wrote: > Enums are always signed, and assigning 1u << 31 to it invokes > implementation defined behavior. It's not a great idea to depend on this > in the UAPI, and it turns out no other UAPI does either. > > So let's do what other UAPI does, and

Re: [PATCH] drm/panthor: use defines for sync flags

2024-10-29 Thread Mihail Atanassov
Hi Erik, On 29/10/2024 09:46, Erik Faye-Lund wrote: Enums are always signed, and assigning 1u << 31 to it invokes implementation defined behavior. It's not a great idea to depend on this in the UAPI, and it turns out no other UAPI does either. So let's do what other UAPI does, and use defines i

[PATCH] drm/panel: novatek-nt35950: fix return value check in nt35950_probe()

2024-10-29 Thread Yang Yingliang
From: Yang Yingliang mipi_dsi_device_register_full() never returns NULL pointer, it will return ERR_PTR() when it fails, so replace the check with IS_ERR(). Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") Signed-off-by: Yang Yingliang --- drivers/gpu/drm/

Re: [PATCH v2] drm/amdgpu: Fix possible NULL pointer dereference

2024-10-29 Thread Li Huafei
On 2024/10/29 16:18, Christophe JAILLET wrote: > Le 29/10/2024 à 11:18, Li Huafei a écrit : >> Fix the potential NULL pointer dereference on mem_ranges in >> amdgpu_discovery_get_nps_info(). Additionally, assign the output >> parameters nps_type and range_cnt after the kvzalloc() call to prevent

[PATCH v3] drm/amdgpu: Fix the memory allocation issue in amdgpu_discovery_get_nps_info()

2024-10-29 Thread Li Huafei
Fix two issues with memory allocation in amdgpu_discovery_get_nps_info() for mem_ranges: - Add a check for allocation failure to avoid dereferencing a null pointer. - As suggested by Christophe, use kvcalloc() for memory allocation, which checks for multiplication overflow. Additionally,

  1   2   >