Re: [PATCH v6 07/10] tee: add tee_shm_alloc_cma_phys_mem()

2025-03-24 Thread Sumit Garg
Hi Jens, On Wed, Mar 05, 2025 at 02:04:13PM +0100, Jens Wiklander wrote: > Add tee_shm_alloc_cma_phys_mem() to allocate a physical memory using > from the default CMA pool. The memory is represented by a tee_shm object > using the new flag TEE_SHM_CMA_BUF to identify it as physical memory > from C

Re: [PATCH v6 06/10] tee: new ioctl to a register tee_shm from a dmabuf file descriptor

2025-03-24 Thread Sumit Garg
Hi Jens, On Wed, Mar 05, 2025 at 02:04:12PM +0100, Jens Wiklander wrote: > From: Etienne Carriere > > Enable userspace to create a tee_shm object that refers to a dmabuf > reference. > > Userspace registers the dmabuf file descriptor as in a tee_shm object. > The registration is completed with

[PATCH v2 35/59] drm: use correct ccflags-y spelling

2025-03-24 Thread Jim Cromie
Incorrectly spelled CFLAGS- failed to add -DDYNAMIC_DEBUG_MODULE, which disabled dynamic-debug in modules built with: CONFIG_DYNAMIC_DEBUG=n # 1 CONFIG_DYNAMIC_DEBUG_CORE=y # 2 CONFIG_DRM_USE_DYNAMIC_DEBUG=y # 3 NB: this adds the flag (when 3) more often than strictly needed; module

[PATCH v2 03/15] dt-bindings: display: mediatek: add EXDMA yaml for MT8196

2025-03-24 Thread paul-pl . chen
From: Paul-pl Chen Add mediatek,exdma.yaml to support EXDMA for MT8196. The MediaTek display overlap extended DMA engine, namely OVL_EXDMA or EXDMA, primarily functions as a DMA engine for reading data from DRAM with various DRAM footprints and data formats. Signed-off-by: Paul-pl Chen --- ...

[PATCH] drm/ttm: reserve the move fence space first

2025-03-24 Thread Prike Liang
Reserve the move fence space before adding the fence to reserve objection. Signed-off-by: Prike Liang --- drivers/gpu/drm/ttm/ttm_bo.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index f9a84d07dcbc..d5eab0

Re: [PATCH 28/63] dyndbg-API: promote DYNDBG_CLASSMAP_PARAM to API

2025-03-24 Thread jim . cromie
On Sun, Mar 16, 2025 at 3:14 PM wrote: > > On Tue, Feb 25, 2025 at 7:29 AM Louis Chauvet > wrote: > > > > > > > > Le 25/01/2025 à 07:45, Jim Cromie a écrit : > > > move the DYNDBG_CLASSMAP_PARAM macro from test-dynamic-debug.c into > > > the header, and refine it, by distinguishing the 2 use cas

Re: [PATCH v6 05/10] tee: implement restricted DMA-heap

2025-03-24 Thread Sumit Garg
Hi Jens, On Wed, Mar 05, 2025 at 02:04:11PM +0100, Jens Wiklander wrote: > Implement DMA heap for restricted DMA-buf allocation in the TEE > subsystem. > > Restricted memory refers to memory buffers behind a hardware enforced > firewall. It is not accessible to the kernel during normal circumstan

RE: [PATCH] udmabuf: fix a buf size overflow issue during udmabuf creation

2025-03-24 Thread Kasireddy, Vivek
Hi Christian, > Am 21.03.25 um 17:41 schrieb Xiaogang.Chen: > > From: Xiaogang Chen > > > > by casting size_limit_mb to u64 when calculate pglimit. > > > > Signed-off-by: Xiaogang Chen > > Reviewed-by: Christian König > > If nobody objects I'm going to push that to drm-misc-fixes. No objectio

Re: [PATCH v6 04/10] optee: sync secure world ABI headers

2025-03-24 Thread Sumit Garg
Hi Jens, It has taken a bit of time for me to review this patch-set as I am settling in my new role. On Wed, Mar 05, 2025 at 02:04:10PM +0100, Jens Wiklander wrote: > Update the header files describing the secure world ABI, both with and > without FF-A. The ABI is extended to deal with restricted

[PATCH 0/7] Replace xe_hmm with gpusvm

2025-03-24 Thread Matthew Auld
As a first step to moving userptr handling over to drm, replace the hmm usage in xe over to gpusvm, which already offers similar functionality. As some prep steps we also align on some of the missing pieces that were already handled in xe_hmm. -- 2.48.1

[PATCH 01/10] drm/panic: add missing space

2025-03-24 Thread Miguel Ojeda
Add missing space in sentence. This was found using the Clippy `doc_markdown` lint, which we may want to enable. Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen") Signed-off-by: Miguel Ojeda --- drivers/gpu/drm/drm_panic_qr.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH v2 14/15] drm/mediatek: Add support for multiple mmsys in the one mediatek-drm driver

2025-03-24 Thread 胡俊光

Re: [PATCH v7 drm-dp 5/9] drm/hisilicon/hibmc: Getting connector info and EDID by using AUX channel

2025-03-24 Thread Yongbang Shi
On Mon, 24 Mar 2025, Yongbang Shi wrote: On Wed, 19 Mar 2025, Yongbang Shi wrote: From: Baihan Li Add registering drm_aux and use it to get connector edid with drm functions. Add ddc channel in connector initialization to put drm_aux in drm_connector. Signed-off-by: Baihan Li Signed-off

Re: [PATCH v2 09/15] drm/mediatek: Refine OVL format convert API and export to public

2025-03-24 Thread 胡俊光

Re: [PATCH v2 06/15] soc: mediatek: add mmsys support for MT8196

2025-03-24 Thread AngeloGioacchino Del Regno
Il 21/03/25 10:33, paul-pl.chen ha scritto: From: Nancy Lin 1. Defining driver data and adding compatible string for different subsystems (DISPSYS0, DISPSYS1, OVLSYS0, OVLSYS1, VDISP_AO) 2. Adding functions to control top clocks and ddp clocks. 3. Updating the probe function to initialize clock

[PATCH] drm/amdgpu: Replace deprecated function strcpy() with strscpy()

2025-03-24 Thread Andres Urian Florez
Instead of using the strcpy() deprecated function to populate the fw_name, use the strscpy() function Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy Signed-off-by: Andres Urian Florez --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 68 - 1 file

Re: [PATCH v4 01/18] dt-bindings: gpu: img: Future-proofing enhancements

2025-03-24 Thread Rob Herring (Arm)
On Thu, 20 Mar 2025 11:32:11 +, Matt Coster wrote: > The first compatible strings added for the AXE-1-16M are not sufficient to > accurately describe all the IMG Rogue GPUs. The current "img,img-axe" > string refers to the entire family of Series AXE GPUs, but this is > primarily a marketing

Re: [PATCH v2 9/9] arm64: dts: imx95: Describe Mali G310 GPU

2025-03-24 Thread Marek Vasut
On 3/24/25 8:02 AM, Alexander Stein wrote: Hi, @@ -1890,6 +1919,35 @@ netc_emdio: mdio@0,0 { }; }; + gpu_blk_ctrl: reset-controller@4d81 { + compatible = "nxp,imx95-gpu-blk-ctrl"; + reg = <0x0 0x4d81000

Re: [PATCH 0/7] A few drm_syncobj optimisations

2025-03-24 Thread Maíra Canal
Hi Tvrtko, Thanks for this patchset! I applied this patchset to the RPi downstream kernel 6.13.7 [1] and saw an FPS improvement of approximately 5.85% with "vkgears -present-mailbox" on the RPi 5. I did five 100 seconds runs on each kernel and here are my results: ### 6.13.7 | Run| Min

[PATCH v12 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-24 Thread Jonathan Cavitt
Add support for userspace to request a list of observed faults from a specified VM. v2: - Only allow querying of failed pagefaults (Matt Brost) v3: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jcavitt) - Remove unnecessary copy_from_user (Jain

[PATCH v12 2/5] drm/xe/xe_gt_pagefault: Move pagefault struct to header

2025-03-24 Thread Jonathan Cavitt
Move the pagefault struct from xe_gt_pagefault.c to the xe_gt_pagefault_types.h header file, and move the associated enum values into the regs folder under xe_pagefault_desc.h Since xe_pagefault_desc.h is being initialized here, also move the xe_guc_pagefault_desc hardware formats to the new file.

[PATCH v12 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-24 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_property ioctl. v2: - Expand kernel docs for drm_xe_vm_get_property (Jianxun) v3: - Remove address type external definitions (Jianxun) - Add fault type to xe_drm_fault struct (Jianxun) Signed-off-by: Jonathan Cavitt Cc: Zhang Jianxun --- include/

Re: [PATCH 7/7] drm/syncobj: Add a fast path to drm_syncobj_array_find

2025-03-24 Thread Maíra Canal
Hi Tvrtko, Some nits inline, mostly personal comments. In any case, Reviewed-by: Maíra Canal On 18/03/25 12:54, Tvrtko Ursulin wrote: Running the Cyberpunk 2077 benchmark we can observe that the lookup helper is relatively hot, but the 97% of the calls are for a single object. (~3% for two p

Re: [PATCH 6/7] drm/syncobj: Add a fast path to drm_syncobj_array_wait_timeout

2025-03-24 Thread Maíra Canal
Hi Tvrtko, On 18/03/25 12:54, Tvrtko Ursulin wrote: Running the Cyberpunk 2077 benchmark we can observe that waiting on DRM sycobjs is relatively hot, but the 96% of the calls are for a single object. (~4% for two points, and never more than three points. While a more trivial workload like vkmar

Re: linux-next: Tree for Mar 24 (drm/xe/xe_migrate)

2025-03-24 Thread Randy Dunlap
On 3/24/25 5:01 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20250321: > on i386: linux-next-20250324/X32/drivers/gpu/drm/xe/xe_migrate.c:1561:(.text+0x3074): undefined reference to `__udivdi3' -- ~Randy

[PATCH v6 3/6] rust: enable `clippy::ptr_cast_constness` lint

2025-03-24 Thread Tamir Duberstein
In Rust 1.72.0, Clippy introduced the `ptr_cast_constness` lint [1]: > Though `as` casts between raw pointers are not terrible, > `pointer::cast_mut` and `pointer::cast_const` are safer because they > cannot accidentally cast the pointer to another type. There are only 2 affected sites: - `*mut T

[RFC PATCH 0/5] drm/sched: Fix memory leaks in drm_sched_fini()

2025-03-24 Thread Philipp Stanner
Howdy, as many of you know, we have potential memory leaks in drm_sched_fini() which have been tried to be solved by various parties with various methods in the past. In our past discussions, we came to the conclusion, that the simplest solution, blocking in drm_sched_fini(), is not possible beca

Re: [PATCH 3/7] drm/syncobj: Avoid one temporary allocation in drm_syncobj_array_find

2025-03-24 Thread Maíra Canal
Hi Tvrtko, On 18/03/25 12:54, Tvrtko Ursulin wrote: Drm_syncobj_array_find() helper is used from many userspace ioctl entry points with the task of looking up userspace handles to internal objects. We can easily avoid one temporary allocation by making it read the handles as it is looking them

Re: [PATCH v2 10/59] dyndbg: replace classmap list with a vector

2025-03-24 Thread jim . cromie
On Mon, Mar 24, 2025 at 9:08 AM Louis Chauvet wrote: > > > > Le 20/03/2025 à 19:51, Jim Cromie a écrit : > Thanks for your explanation of __outvar! It makes sense. I never seen > this pattern anywhere in the kernel, maybe a simple doc comment is > enough to carry the information: Im gonna pull

Re: [PATCH 4/7] drm/syncobj: Use put_user in drm_syncobj_query_ioctl

2025-03-24 Thread Maíra Canal
Hi Tvrtko, On 18/03/25 12:54, Tvrtko Ursulin wrote: Since the query loop is using copy_to_user() to write out a single u64 at a time it feels more natural (and is a tiny bit more compact) to replace it with put_user(). Access_ok() check is added to the input checking for an early bailout in cas

[PATCH v6 5/6] rust: enable `clippy::as_underscore` lint

2025-03-24 Thread Tamir Duberstein
In Rust 1.63.0, Clippy introduced the `as_underscore` lint [1]: > The conversion might include lossy conversion or a dangerous cast that > might go undetected due to the type being inferred. > > The lint is allowed by default as using `_` is less wordy than always > specifying the type. Always sp

Re: [PATCH 2/7] drm/syncobj: Do not allocate an array to store zeros when waiting

2025-03-24 Thread Maíra Canal
Hi Tvrtko, On 18/03/25 12:54, Tvrtko Ursulin wrote: When waiting on syncobjs the current code allocates a temporary array only to fill it up with all zeros. We can avoid that by relying on the allocated entry array already being zero allocated. For the timeline mode we can fetch the timeline p

[PATCH v6 4/6] rust: enable `clippy::as_ptr_cast_mut` lint

2025-03-24 Thread Tamir Duberstein
In Rust 1.66.0, Clippy introduced the `as_ptr_cast_mut` lint [1]: > Since `as_ptr` takes a `&self`, the pointer won’t have write > permissions unless interior mutability is used, making it unlikely > that having it as a mutable pointer is correct. There is only one affected callsite, and the chan

[PATCH v6 1/6] rust: retain pointer mut-ness in `container_of!`

2025-03-24 Thread Tamir Duberstein
Avoid casting the input pointer to `*const _`, allowing the output pointer to be `*mut` if the input is `*mut`. This allows a number of `*const` to `*mut` conversions to be removed at the cost of slightly worse ergonomics when the macro is used with a reference rather than a pointer; the only examp

[PATCH v6 6/6] rust: enable `clippy::cast_lossless` lint

2025-03-24 Thread Tamir Duberstein
Before Rust 1.29.0, Clippy introduced the `cast_lossless` lint [1]: > Rust’s `as` keyword will perform many kinds of conversions, including > silently lossy conversions. Conversion functions such as `i32::from` > will only perform lossless conversions. Using the conversion functions > prevents con

[PATCH v6 0/6] rust: reduce `as` casts, enable related lints

2025-03-24 Thread Tamir Duberstein
This started with a patch that enabled `clippy::ptr_as_ptr`. Benno Lossin suggested I also look into `clippy::ptr_cast_constness` and I discovered `clippy::as_ptr_cast_mut`. This series now enables all 3 lints. It also enables `clippy::as_underscore` which ensures other pointer casts weren't missed

[PATCH v6 2/6] rust: enable `clippy::ptr_as_ptr` lint

2025-03-24 Thread Tamir Duberstein
In Rust 1.51.0, Clippy introduced the `ptr_as_ptr` lint [1]: > Though `as` casts between raw pointers are not terrible, > `pointer::cast` is safer because it cannot accidentally change the > pointer's mutability, nor cast the pointer to other types like `usize`. There are a few classes of changes

[PATCH v11 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-24 Thread Jonathan Cavitt
Add support for userspace to request a list of observed faults from a specified VM. v2: - Only allow querying of failed pagefaults (Matt Brost) v3: - Remove unnecessary size parameter from helper function, as it is a property of the arguments. (jcavitt) - Remove unnecessary copy_from_user (Jain

[PATCH v11 4/5] drm/xe/xe_vm: Add per VM fault info

2025-03-24 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the first 50 seen faults. Only pagefaults are saved this way currently, though in the future, all faults should be tracked by the VM for future reporting. Additionally, of the pagefaults reported, only failed pagefaults are saved this

[PATCH v11 0/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-24 Thread Jonathan Cavitt
Add additional information to each VM so they can report up to the first 50 seen faults. Only pagefaults are saved this way currently, though in the future, all faults should be tracked by the VM for future reporting. Additionally, of the pagefaults reported, only failed pagefaults are saved this

[PATCH v11 3/5] drm/xe/uapi: Define drm_xe_vm_get_property

2025-03-24 Thread Jonathan Cavitt
Add initial declarations for the drm_xe_vm_get_property ioctl. v2: - Expand kernel docs for drm_xe_vm_get_property (Jianxun) v3: - Remove address type external definitions (Jianxun) - Add fault type to xe_drm_fault struct (Jianxun) Signed-off-by: Jonathan Cavitt Cc: Zhang Jianxun --- include/

[PATCH v11 2/5] drm/xe/xe_gt_pagefault: Move pagefault struct to header

2025-03-24 Thread Jonathan Cavitt
Move the pagefault struct from xe_gt_pagefault.c to the xe_gt_pagefault_types.h header file, and move the associated enum values into the regs folder under xe_pagefault_desc.h Since xe_pagefault_desc.h is being initialized here, also move the xe_guc_pagefault_desc hardware formats to the new file.

Re: [PATCH 1/7] drm/syncobj: Remove unhelpful helper

2025-03-24 Thread Maíra Canal
Hi Tvrtko, Some nits inline, but feel free to ignore them if you don't think they are reasonable. Apart from that, Reviewed-by: Maíra Canal On 18/03/25 12:54, Tvrtko Ursulin wrote: Helper which fails to consolidate the code and instead just forks into two copies of the code based on a boolean

RE: [PATCH v10 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-24 Thread Cavitt, Jonathan
-Original Message- From: Jadav, Raag Sent: Monday, March 24, 2025 2:26 PM To: Cavitt, Jonathan Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Zhang, Jianxun ; Lin, Shuicheng ; dri-devel@lists.freedesktop.org; Wajdec

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Doug Anderson
Hi, On Mon, Mar 24, 2025 at 10:31 AM Laurent Pinchart wrote: > > On Mon, Mar 24, 2025 at 10:17:05AM -0700, Doug Anderson wrote: > > On Mon, Mar 24, 2025 at 9:40 AM Laurent Pinchart wrote: > > > On Tue, Mar 18, 2025 at 10:00:31PM +0100, Wolfram Sang wrote: > > > > Hi Laurent, > > > > > > > > > > R

Re: [PATCH] drm/i915/gvt: Add __nonstring annotations for unterminated strings

2025-03-24 Thread Nicolas Chauvet
Le lun. 24 mars 2025 à 13:54, Jani Nikula a écrit : > > On Sun, 23 Mar 2025, Damian Tometzki wrote: > > On Mon, 10. Mar 15:23, Kees Cook wrote: > >> When a character array without a terminating NUL character has a static > >> initializer, GCC 15's -Wunterminated-string-initialization will only >

[PATCH] drm/xe: avoid plain 64-bit division

2025-03-24 Thread Arnd Bergmann
From: Arnd Bergmann Building the xe driver for i386 results in a link time warning: x86_64-linux-ld: drivers/gpu/drm/xe/xe_migrate.o: in function `xe_migrate_vram': xe_migrate.c:(.text+0x1e15): undefined reference to `__udivdi3' Avoid this by using DIV_U64_ROUND_UP() instead of DIV_ROUND_UP().

[PATCH] drm/i2c: tda998x: select CONFIG_DRM_KMS_HELPER

2025-03-24 Thread Arnd Bergmann
From: Arnd Bergmann This fails to build without the KMS helper functions: x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x_drv.o: in function `tda998x_detect_work': tda998x_drv.c:(.text+0x4e6): undefined reference to `drm_kms_helper_hotplug_event' x86_64-linux-ld: drivers/gpu/drm/bridge/tda998x

Re: [PATCH 2/2] rust: drm: Add GPUVM abstraction

2025-03-24 Thread Miguel Ojeda
On Mon, Mar 24, 2025 at 8:38 PM Miguel Ojeda wrote: > > Yeah, I asked upstream if we could have something that at least > detects what could have been intra-doc links, because that should not > have too many false positives since it is a subset: > > https://github.com/rust-lang/rust/issues/131

[PATCH 02/10] drm/panic: add missing Markdown code span

2025-03-24 Thread Miguel Ojeda
Add missing Markdown code span. This was found using the Clippy `doc_markdown` lint, which we may want to enable. Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen") Signed-off-by: Miguel Ojeda --- drivers/gpu/drm/drm_panic_qr.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 2/2] rust: drm: Add GPUVM abstraction

2025-03-24 Thread Miguel Ojeda
On Mon, Mar 24, 2025 at 8:25 PM Daniel Almeida wrote: > > By the way, maybe we should have a lint for CamelCase in docs? I tried my > best to > cover all of these, but some slip through :/ > > i.e.: if you write something in CamelCase somewhere in the docs, there's a > high > chance that you sho

[PATCH v2] drm/panel/sharp-ls043t1le01: Use _multi variants

2025-03-24 Thread Anusha Srivatsa
Move away from using deprecated API and use _multi variants if available. Use mipi_dsi_msleep() and mipi_dsi_usleep_range() instead of msleep() and usleep_range() respectively. Used Coccinelle to find the _multi variant APIs, replacing mpi_dsi_msleep() where necessary and for returning dsi_ctx.acc

Re: [PATCH 2/2] rust: drm: Add GPUVM abstraction

2025-03-24 Thread Benno Lossin
On Mon Mar 24, 2025 at 8:25 PM CET, Daniel Almeida wrote: >> On 24 Mar 2025, at 14:36, Miguel Ojeda >> wrote: >> >> Hi Daniel, >> >> A few quick notes for future versions on style/docs to try to keep >> things consistent upstream -- not an actual review. >> >> On Mon, Mar 24, 2025 at 4:14 PM D

Re: [RFC PATCH RESEND v4 0/6] drm/display: dp: add new DPCD access functions

2025-03-24 Thread Lyude Paul
This looks all good to me, do you need someone to push this to drm-misc? On Mon, 2025-03-24 at 13:51 +0200, Dmitry Baryshkov wrote: > Existing DPCD access functions return an error code or the number of > bytes being read / write in case of partial access. However a lot of > drivers either (incorr

Re: [PATCH 2/2] rust: drm: Add GPUVM abstraction

2025-03-24 Thread Daniel Almeida
Hi Miguel, thanks for having a look at this: > On 24 Mar 2025, at 14:36, Miguel Ojeda > wrote: > > Hi Daniel, > > A few quick notes for future versions on style/docs to try to keep > things consistent upstream -- not an actual review. > > On Mon, Mar 24, 2025 at 4:14 PM Daniel Almeida > wrot

Re: [PATCH v2 4/9] drm/panthor: Implement optional reset

2025-03-24 Thread Marek Vasut
On 3/24/25 9:43 AM, Boris Brezillon wrote: [...] @@ -563,6 +585,7 @@ int panthor_device_suspend(struct device *dev) panthor_devfreq_suspend(ptdev); + reset_control_assert(ptdev->resets); Hm, that might be the cause of the fast reset issue (which is a fast resume more than a fast rese

[PATCH RESEND RFC v4 4/6] drm/display: dp-cec: use new DCPD access helpers

2025-03-24 Thread Dmitry Baryshkov
From: Dmitry Baryshkov Switch drm_dp_cec.c to use new set of DPCD read / write helpers. Reviewed-by: Lyude Paul Acked-by: Jani Nikula Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_dp_cec.c | 37 ++-- 1 file changed, 18 insertions(+), 19 delet

[PATCH v5 3/6] drm/panfrost: Set HW_FEATURE_AARCH64_MMU feature flag on Bifrost models

2025-03-24 Thread Ariel D'Alessandro
Set this feature flag on all Mali Bifrost platforms as the MMU supports AARCH64 4K page table format. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/pan

[RFC PATCH 4/5] drm/nouveau: Add new callback for scheduler teardown

2025-03-24 Thread Philipp Stanner
There is a new callback for always tearing the scheduler down in a leak-free, deadlock-free manner. Port Nouveau as its first user by providing the scheduler with a callback that ensures the fence context gets killed in drm_sched_fini(). Signed-off-by: Philipp Stanner --- drivers/gpu/drm/nouvea

[PATCH v5 1/6] drm/panfrost: Set IOMMU_CACHE flag

2025-03-24 Thread Ariel D'Alessandro
Panfrost does not support uncached mappings, so flag them properly. Also flag the pages that are mapped as response to a page fault as cached. Signed-off-by: Boris Brezillon Signed-off-by: Ariel D'Alessandro Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Steven Price Reviewed-by: Adrián

[PATCH v5 5/6] drm/panfrost: Force AARCH64_4K page table format on MediaTek MT8188

2025-03-24 Thread Ariel D'Alessandro
MediaTek MT8188 SoC has an ARM Mali-G57 MC3 GPU (Valhall-JM), which constantly faults with the current panfrost support. For instance, running `glmark2-es2-drm` benchmark test: ``` [ 79.617461] panfrost 1300.gpu: js fault, js=1, status=JOB_BUS_FAULT, head=0xaadc380, tail=0xaadc380 [ 80.11

[PATCH v5 2/6] drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

2025-03-24 Thread Ariel D'Alessandro
As done in panthor, define and use these GPU_MMU_FEATURES_* macros, which makes code easier to read and reuse. Signed-off-by: Ariel D'Alessandro Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Adrián Larumbe --- drivers/gpu/drm/pan

[RFC PATCH 5/5] drm/nouveau: Remove waitque for sched teardown

2025-03-24 Thread Philipp Stanner
struct nouveau_sched contains a waitque needed to prevent drm_sched_fini() from being called while there are still jobs pending. Doing so so far would have caused memory leaks. With the new memleak-free mode of operation switched on in drm_sched_fini() by providing the callback nouveau_sched_fence

[RFC PATCH 3/5] drm/sched: Warn if pending list is not empty

2025-03-24 Thread Philipp Stanner
drm_sched_fini() can leak jobs under certain circumstances. Warn if that happens. Signed-off-by: Philipp Stanner --- drivers/gpu/drm/scheduler/sched_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c in

[RFC PATCH 2/5] drm/sched: Prevent teardown waitque from blocking too long

2025-03-24 Thread Philipp Stanner
The waitqueue that ensures that drm_sched_fini() blocks until the pending_list has become empty could theoretically cause that function to block for a very long time. That, ultimately, could block userspace procesess and prevent them from being killable through SIGKILL. When a driver calls drm_sch

[PATCH v5 0/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-24 Thread Ariel D'Alessandro
Hi all, This is a new iteration on Panfrost support for AARCH64_4K page table format. The main reason behind this patchset is that MediaTek MT8188 SoC (ARM Mali-G57 MC3 GPU) constantly faults due to the actual Panfrost cache configuration. Currently, Panfrost only supports MMU configuration in "L

[RFC PATCH 1/5] drm/sched: Fix teardown leaks with waitqueue

2025-03-24 Thread Philipp Stanner
From: Philipp Stanner The GPU scheduler currently does not ensure that its pending_list is empty before performing various other teardown tasks in drm_sched_fini(). If there are still jobs in the pending_list, this is problematic because after scheduler teardown, no one will call backend_ops.fre

Re: [PATCH 1/2] rust: helpers: Add bindings/wrappers for dma_resv

2025-03-24 Thread Miguel Ojeda
On Mon, Mar 24, 2025 at 4:14 PM Daniel Almeida wrote: > > -const blk_features_t RUST_CONST_HELPER_BLK_FEAT_ROTATIONAL = > BLK_FEAT_ROTATIONAL; > +const blk_features_t RUST_CONST_HELPER_BLK_FEAT_ROTATIONAL = > + BLK_FEAT_ROTATIONAL; Spurious change? Ah, this is probably the result of apply

Re: [PATCH v4 4/6] drm/panfrost: Add support for AARCH64_4K page table format

2025-03-24 Thread Ariel D'Alessandro
Adrian, On 3/22/25 3:48 PM, Adrian Larumbe wrote: On 17.03.2025 11:52, Ariel D'Alessandro wrote: Currently, Panfrost only supports MMU configuration in "LEGACY" (as Bifrost calls it) mode, a (modified) version of LPAE "Large Physical Address Extension", which in Linux we've called "mali_lpae".

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Doug Anderson
Hi, On Mon, Mar 24, 2025 at 9:40 AM Laurent Pinchart wrote: > > On Tue, Mar 18, 2025 at 10:00:31PM +0100, Wolfram Sang wrote: > > Hi Laurent, > > > > > > Read out and check the ID registers, so we can bail out if I2C > > > > communication does not work or if the device is unknown. > > > > > > Wha

Re: [PATCH v2 2/3] misc: fastrpc: add support for gpdsp remoteproc

2025-03-24 Thread Dmitry Baryshkov
On Mon, Mar 24, 2025 at 01:29:30PM +, Srinivas Kandagatla wrote: > > > On 21/03/2025 14:07, Dmitry Baryshkov wrote: > > On Thu, Mar 20, 2025 at 05:11:20PM +, Srinivas Kandagatla wrote: > > > > > > > > > On 20/03/2025 09:14, Ling Xu wrote: > > > > The fastrpc driver has support for 5 typ

Re: [PATCH v2 07/15] soc: mediatek: mutex: refactor SOF settings for output components

2025-03-24 Thread AngeloGioacchino Del Regno
Il 21/03/25 10:33, paul-pl.chen ha scritto: From: Nancy Lin Refactor SOF settings by adding mtk_mutex_get_output_comp_sof() and extracting SOF logic from mtk_mutex_add_comp() and mtk_mutex_remove_comp(). - Added mtk_mutex_add_comp_sof() and mtk_mutex_remove_comp_sof() for SOF settings. - Re

Re: [PATCH] drm/xe/svm: fix dereferencing error pointer in drm_gpusvm_range_alloc()

2025-03-24 Thread Matthew Brost
On Sun, Mar 23, 2025 at 05:49:06AM -0700, Harshit Mogalapalli wrote: > xe_svm_range_alloc() returns ERR_PTR(-ENOMEM) on failure and there is a > dereference of "range" after that: > > --> range->gpusvm = gpusvm; > > In xe_svm_range_alloc(), when memory allocation fails return NULL > ins

Re: [PATCH] drm/panel: himax-hx8394: transition to mipi_dsi wrapped functions

2025-03-24 Thread Doug Anderson
Hi, On Sat, Mar 22, 2025 at 10:30 PM Tejas Vipin wrote: > > @@ -493,35 +481,28 @@ static int hx8394_enable(struct drm_panel *panel) > { > struct hx8394 *ctx = panel_to_hx8394(panel); > struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev); > - int ret; > - > - re

RE: [PATCH v10 5/5] drm/xe/xe_vm: Implement xe_vm_get_property_ioctl

2025-03-24 Thread Cavitt, Jonathan
-Original Message- From: Jadav, Raag Sent: Friday, March 21, 2025 4:37 PM To: Cavitt, Jonathan Cc: intel...@lists.freedesktop.org; Gupta, saurabhg ; Zuo, Alex ; joonas.lahti...@linux.intel.com; Brost, Matthew ; Zhang, Jianxun ; Lin, Shuicheng ; dri-devel@lists.freedesktop.org; Wajdec

Re: [PATCH v2] drm/panel: samsung-s6d7aa0: transition to mipi_dsi wrapped functions

2025-03-24 Thread Doug Anderson
Hi, On Wed, Mar 19, 2025 at 1:05 PM Doug Anderson wrote: > > Hi, > > On Wed, Mar 19, 2025 at 11:31 AM Tejas Vipin wrote: > > > > Changes the samsung-s6d7aa0 panel to use multi style functions for > > improved error handling. > > > > Signed-off-by: Tejas Vipin > > --- > > Changes in v2: > >

Re: [PATCH v2 39/59] drm-dyndbg: DRM_CLASSMAP_USE in amdgpu driver

2025-03-24 Thread Louis Chauvet
Le 20/03/2025 à 19:52, Jim Cromie a écrit : Following the dyndbg-api-fix, replace DECLARE_DYNDBG_CLASSMAP with DRM_CLASSMAP_USE. This refs the defined & exported classmap, rather than re-declaring it redundantly, and error-prone-ly. This resolves the appearance of "class:_UNKNOWN_" in the co

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Laurent Pinchart
On Tue, Mar 18, 2025 at 10:00:31PM +0100, Wolfram Sang wrote: > Hi Laurent, > > > > Read out and check the ID registers, so we can bail out if I2C > > > communication does not work or if the device is unknown. > > > > What's the advantage of that, what are you trying to guard against ? > > That

Re: [PATCH v7 0/5] bits: Fixed-type GENMASK_U*() and BIT_U*()

2025-03-24 Thread Vincent Mailhol
On 24/03/2025 at 23:28, Yury Norov wrote: > On Sat, Mar 22, 2025 at 06:23:11PM +0900, Vincent Mailhol via B4 Relay wrote: >> Introduce some fixed width variant of the GENMASK() and the BIT() >> macros in bits.h. Note that the main goal is not to get the correct >> type, but rather to enforce more c

Re: [PATCH 0/3] bits: Split asm and non-asm GENMASK*() and unify definitions

2025-03-24 Thread Vincent Mailhol
On 25/03/2025 at 01:11, Yury Norov wrote: > + Anshuman Khandual, Catalin Marinas, linux-arm-ker...@lists.infradead.org > > This series moves GENMASK_U128 out of uapi. ARM is the only proposed > user. Add ARM people for visibility. Actually, not yet. Here, I am decoupling GENMASK_U128() from __GEN

Re: [PATCH v2] drm/bridge: ti-sn65dsi86: make use of debugfs_init callback

2025-03-24 Thread Doug Anderson
Hi, On Mon, Mar 17, 2025 at 7:33 AM Doug Anderson wrote: > > Hi, > > On Sat, Mar 15, 2025 at 1:17 PM Wolfram Sang > wrote: > > > > Do not create a custom directory in debugfs-root, but use the > > debugfs_init callback to create a custom directory at the given place > > for the bridge. The new d

Re: [PATCH v3] drm/bridge: ti-sn65dsi86: Check bridge connection failure

2025-03-24 Thread Doug Anderson
Hi, On Tue, Mar 18, 2025 at 10:56 AM Doug Anderson wrote: > > Hi, > > On Tue, Mar 18, 2025 at 8:56 AM Wolfram Sang > wrote: > > > > Read out and check the ID registers, so we can bail out if I2C > > communication does not work or if the device is unknown. Tested on a > > Renesas GrayHawk board (

Re: [PATCH v4] drm/panel: novatek-nt36523: transition to mipi_dsi wrapped functions

2025-03-24 Thread Doug Anderson
Hi, On Sat, Mar 15, 2025 at 11:25 AM Tejas Vipin wrote: > > Changes the novatek-nt36523 panel to use multi style functions for > improved error handling. > > Reviewed-by: Douglas Anderson > Signed-off-by: Tejas Vipin > --- > Changes in v4: > - Cleanup nt36523_prepare > > Link to v3: > http

Re: [PATCH v4] drm/panel/synaptics-r63353: Use _multi variants

2025-03-24 Thread Doug Anderson
Hi, On Tue, Mar 18, 2025 at 7:37 AM Anusha Srivatsa wrote: > > Move away from using deprecated API and use _multi > variants if available. Use mipi_dsi_msleep() > and mipi_dsi_usleep_range() instead of msleep() > and usleep_range() respectively. > > Used Coccinelle to find the _multi variant APIs

Re: [PATCH v2 7/9] dt-bindings: gpu: mali-valhall-csf: Document i.MX95 support

2025-03-24 Thread Rob Herring (Arm)
On Fri, 21 Mar 2025 21:05:57 +0100, Marek Vasut wrote: > The instance of the GPU populated in Freescale i.MX95 is the > Mali G310, document support for this variant. > > Reviewed-by: Alexander Stein > Reviewed-by: Frank Li > Signed-off-by: Marek Vasut > --- > Cc: Boris Brezillon > Cc: Conor

[PATCH 2/2] rust: drm: Add GPUVM abstraction

2025-03-24 Thread Daniel Almeida
From: Asahi Lina Add a GPUVM abstraction to be used by Rust GPU drivers. GPUVM keeps track of a GPU's virtual address (VA) space and manages the corresponding virtual mappings represented by "GPU VA" objects. It also keeps track of the mapping's backing GEM buffers. This initial version only su

Re: [PATCH v2 05/15] dt-bindings: display: mediatek: add OUTPROC yaml for MT8196

2025-03-24 Thread Rob Herring
On Fri, Mar 21, 2025 at 05:33:34PM +0800, paul-pl.chen wrote: > From: Paul-pl Chen > > Add mediate,outproc.yaml to support OUTPROC for MT8196. > MediaTek display overlap output processor, namely OVL_OUTPROC > or OUTPROC,handles the post-stage of pixel processing in the > overlapping procedure. >

Re: [PATCH v2 20/59] dyndbg: check DYNDBG_CLASSMAP_DEFINE args at compile-time

2025-03-24 Thread Louis Chauvet
Le 20/03/2025 à 19:51, Jim Cromie a écrit : Add __DYNDBG_CLASSMAP_CHECK to implement these arg-checks at compile: 0 <= _base < 63 class_names is not empty class_names[0] is a string (class_names.length + _base) < 63 These compile-time checks will prevent severa

Re: [PATCH v2 22/59] dyndbg-API: promote DYNAMIC_DEBUG_CLASSMAP_PARAM to API

2025-03-24 Thread Louis Chauvet
Le 20/03/2025 à 19:52, Jim Cromie a écrit : move the DYNAMIC_DEBUG_CLASSMAP_PARAM macro from test-dynamic-debug.c into the header, and refine it, by distinguishing the 2 use cases: 1.DYNAMIC_DEBUG_CLASSMAP_PARAM_REF for DRM, to pass in extern __drm_debug by name. dyndbg keeps bits i

Re: [PATCH v3 00/16] Introduce and use generic parity16/32/64 helper

2025-03-24 Thread Yury Norov
On Sun, Mar 23, 2025 at 03:40:20PM -0700, H. Peter Anvin wrote: > On March 23, 2025 8:16:24 AM PDT, Kuan-Wei Chiu wrote: > >On Thu, Mar 13, 2025 at 03:41:49PM +0800, Kuan-Wei Chiu wrote: > >> On Thu, Mar 13, 2025 at 12:29:13AM +0800, Kuan-Wei Chiu wrote: > >> > On Wed, Mar 12, 2025 at 11:51:12AM -

[PATCH 1/2] rust: helpers: Add bindings/wrappers for dma_resv

2025-03-24 Thread Daniel Almeida
From: Asahi Lina This is just for basic usage in the DRM shmem abstractions for implied locking, not intended as a full DMA Reservation abstraction yet. Signed-off-by: Asahi Lina --- rust/bindings/bindings_helper.h | 4 +++- rust/helpers/dma-resv.c | 13 + rust/helpers/hel

Re: [PATCH v2 15/59] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module

2025-03-24 Thread Louis Chauvet
Le 20/03/2025 à 19:51, Jim Cromie a écrit : The body of ddebug_attach_module_classes() is dominated by a code-block that finds the contiguous subrange of classmaps matching on modname, and saves it into the ddebug_table's info record. Implement this block in a macro to accommodate different c

Re: [PATCH v2 5/7] accel/rocket: Add IOCTL for BO creation

2025-03-24 Thread Jeffrey Hugo
On 2/25/2025 12:55 AM, Tomeu Vizoso wrote: +/** + * rocket_gem_create_object - Implementation of driver->gem_create_object. + * @dev: DRM device + * @size: Size in bytes of the memory the object will reference + * + * This lets the GEM helpers allocate object structs for us, and keep + * our BO s

Re: [PATCH 16/63] dyndbg-API: replace DECLARE_DYNDBG_CLASSMAP

2025-03-24 Thread Louis Chauvet
Le 16/03/2025 à 20:46, jim.cro...@gmail.com a écrit : hi Louis, On Tue, Feb 25, 2025 at 7:16 AM Louis Chauvet wrote: Le 25/01/2025 à 07:45, Jim Cromie a écrit : DECLARE_DYNDBG_CLASSMAP() has a design error; its usage fails a basic K&R rule: "define once, refer many times". It is used a

Re: [PATCH v2 40/59] drm-dyndbg: DRM_CLASSMAP_USE in i915 driver

2025-03-24 Thread Louis Chauvet
Le 20/03/2025 à 19:52, Jim Cromie a écrit : Following the dyndbg-api-fix, replace DECLARE_DYNDBG_CLASSMAP with DRM_CLASSMAP_USE. This refs the defined & exported classmap, rather than re-declaring it redundantly, and error-prone-ly. This resolves the appearance of "class:_UNKNOWN_" in the co

Re: [PATCH v2 08/10] drm/bridge: anx7625: enable HPD interrupts

2025-03-24 Thread Ayushi Makhija
On 3/11/2025 9:09 PM, Dmitry Baryshkov wrote: > On Tue, Mar 11, 2025 at 05:54:43PM +0530, Ayushi Makhija wrote: >> When device enters the suspend state, it prevents >> HPD interrupts from occurring. To address this, >> add an additional PM runtime vote in hpd_enable(). >> This vote is removed in hp

Re: [PATCH v2 14/59] dyndbg: split _emit_lookup() out of dynamic_emit_prefix()

2025-03-24 Thread Louis Chauvet
Le 20/03/2025 à 19:51, Jim Cromie a écrit : Split dynamic_emit_prefix() to separate out _INCL_LOOKUPs: 1. keep dynamic_emit_prefix() static inline check _INCL_ANY flags before calling 2 2. __dynamic_emit_prefix() prints [TID] or and trailing space if +t flag check _INCL_LOOKUP f

Re: [PATCH v2 33/59] docs/dyndbg: add classmap info to howto (TBD)

2025-03-24 Thread Louis Chauvet
Le 20/03/2025 à 19:52, Jim Cromie a écrit : Describe the 3 API macros providing dynamic_debug's classmaps DYNDBG_CLASSMAP_DEFINE - create & export a classmap DYNDBG_CLASSMAP_USE- refer to exported map DYNDBG_CLASSMAP_PARAM - bind control param to the classmap DYNDBG_CLASSMAP_PARAM_REF +

Re: [PATCH v2 44/59] drm-dyndbg: add DRM_CLASSMAP_USE to Xe driver

2025-03-24 Thread Louis Chauvet
Le 20/03/2025 à 19:52, Jim Cromie a écrit : Invoke DRM_CLASSMAP_USE from xe_drm_client.c. When built with CONFIG_DRM_USE_DYNAMIC_DEBUG=y, this tells dydnbg that Xe uses has drm.debug calls. Signed-off-by: Jim Cromie --- drivers/gpu/drm/xe/xe_drm_client.c | 2 ++ 1 file changed, 2 inserti

Re: [PATCH v2 42/59] drm-dyndbg: DRM_CLASSMAP_USE in drm_dp_helper

2025-03-24 Thread Louis Chauvet
Le 20/03/2025 à 19:52, Jim Cromie a écrit : Following the dyndbg-api-fix, replace DECLARE_DYNDBG_CLASSMAP with DRM_CLASSMAP_USE. This refs the defined & exported classmap, rather than re-declaring it redundantly, and error-prone-ly. This resolves the appearance of "class:_UNKNOWN_" in the co

  1   2   >