[RFC PATCH] drm/etnaviv: set the 32-bit coherent DMA mask later

2025-07-18 Thread Icenowy Zheng
The etnaviv driver wants to use 40-bit DMA mask and 32-bit coherent allocation mask, to be able to access memory up to 40-bit, but still limit page tables to lower 32-bit. However, the call to of_dma_configure() next to setting the masks ruined everything -- of_dma_configure will use the coherent

Re: [PATCH v6 1/1] drm/amd: Re-introduce property to control adaptive backlight modulation

2025-07-18 Thread Xaver Hugl
Looks like a reasonable approach to me. Thanks for following up on it! I'll look into a KWin implementation soon. - Xaver

Re: [PATCH v3 1/5] dt-bindings: Fixup x1e80100 to add DP MST support

2025-07-18 Thread Jessica Zhang
On 7/18/2025 2:13 AM, Dmitry Baryshkov wrote: On Thu, Jul 17, 2025 at 04:28:43PM -0700, Jessica Zhang wrote: From: Abhinav Kumar Please fix the patch subject. Hi Dmitry, Ack. Add x1e80100 to the dp-controller bindings, fix the displayport-controller reg bindings, and drop assigned-

Re: [PATCH] drm/i915/display: Allow async flips on planes with no framebuffer changes

2025-07-18 Thread Xaver Hugl
Am Do., 10. Juli 2025 um 22:21 Uhr schrieb Ville Syrjälä : > > On Mon, Jul 07, 2025 at 03:41:20PM +, Naveen Kumar wrote: > > Allow asynchronous page flips on planes that either lack a framebuffer or > > retain the same framebuffer, as long as no plane properties are modified. > > > > This avoid

[GIT PULL] Nova changes for v6.17

2025-07-18 Thread Danilo Krummrich
Hi Dave and Sima, Please pull the following nova changes and other dependencies. There's a minor conflict with the rust-timekeeping tree [1] with a resolution in [2]. [1] https://lore.kernel.org/all/20250624195142.1050e...@canb.auug.org.au/ [2] https://lore.kernel.org/all/20250626170538.67e26...

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-18 Thread Alex Deucher
On Fri, Jul 18, 2025 at 6:01 PM Leo Li wrote: > > > > On 2025-07-18 17:33, Alex Deucher wrote: > > On Fri, Jul 18, 2025 at 5:02 PM Leo Li wrote: > >> > >> > >> > >> On 2025-07-18 16:07, Alex Deucher wrote: > >>> On Fri, Jul 18, 2025 at 1:57 PM Brian Geffon wrote: > > On Thu, Jul 17, 20

Re: [PATCH] drm/msm/dp: Propagate core clock enable error in runtime resume

2025-07-18 Thread Dmitry Baryshkov
On Fri, Jul 18, 2025 at 03:15:51PM -0700, Jessica Zhang wrote: > Currently, runtime resume will always return success even if the core > clock enable fails. > > Propagate any core clock enable errors during the resume to avoid any > crashes later. > > Signed-off-by: Jessica Zhang > --- > driver

[PATCH] drm/msm/dp: Propagate core clock enable error in runtime resume

2025-07-18 Thread Jessica Zhang
Currently, runtime resume will always return success even if the core clock enable fails. Propagate any core clock enable errors during the resume to avoid any crashes later. Signed-off-by: Jessica Zhang --- drivers/gpu/drm/msm/dp/dp_display.c | 16 1 file changed, 12 insertion

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-18 Thread Leo Li
On 2025-07-18 17:33, Alex Deucher wrote: > On Fri, Jul 18, 2025 at 5:02 PM Leo Li wrote: >> >> >> >> On 2025-07-18 16:07, Alex Deucher wrote: >>> On Fri, Jul 18, 2025 at 1:57 PM Brian Geffon wrote: On Thu, Jul 17, 2025 at 10:59 AM Alex Deucher wrote: > > On Wed, Jul 16

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-18 Thread Alex Deucher
On Fri, Jul 18, 2025 at 5:02 PM Leo Li wrote: > > > > On 2025-07-18 16:07, Alex Deucher wrote: > > On Fri, Jul 18, 2025 at 1:57 PM Brian Geffon wrote: > >> > >> On Thu, Jul 17, 2025 at 10:59 AM Alex Deucher > >> wrote: > >>> > >>> On Wed, Jul 16, 2025 at 8:13 PM Brian Geffon wrote: > > >>

Re: [PATCH v5 14/14] drm/amd/display: move dc_sink from dc_edid to drm_edid

2025-07-18 Thread Alex Hung
Melisa, The following NULL pointer error was reported from promotion test with this patch: [ 31.525028] amdgpu :c4:00.0: [drm] *ERROR* No EDID read. [ 31.525596] amdgpu :c4:00.0: [drm:drm_dp_dpcd_read [drm_display_helper]] AMDGPU DM aux hw bus 2: 0x6921d AUX -> (ret= 3) 00 00 0

[PATCH next] drm/xe: Fix an IS_ERR() vs NULL bug in xe_tile_alloc_vram()

2025-07-18 Thread Dan Carpenter
The xe_vram_region_alloc() function returns NULL on error. It never returns error pointers. Update the error checking to match. Fixes: 4b0a5f5ce784 ("drm/xe: Unify the initialization of VRAM regions") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/xe/xe_tile.c | 4 ++-- 1 file changed, 2 ins

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-18 Thread Leo Li
On 2025-07-18 16:07, Alex Deucher wrote: > On Fri, Jul 18, 2025 at 1:57 PM Brian Geffon wrote: >> >> On Thu, Jul 17, 2025 at 10:59 AM Alex Deucher wrote: >>> >>> On Wed, Jul 16, 2025 at 8:13 PM Brian Geffon wrote: On Wed, Jul 16, 2025 at 5:03 PM Alex Deucher wrote: > > On W

Re: [PATCH 3/3] drm/amdgpu: update mmhub 4.1.0 client id mappings

2025-07-18 Thread Wu, David
thanks! Tested-by: David (Ming Qiang) Wu Reviewed-by: David (Ming Qiang) Wu On 7/18/2025 3:57 PM, Alex Deucher wrote: Update the client id mapping so the correct clients get printed when there is a mmhub page fault. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c

Re: [PATCH v4 1/4] drm: Create mipi_dsi_dual macro

2025-07-18 Thread Doug Anderson
Hi, On Fri, Jul 18, 2025 at 10:17 AM Brigham Campbell wrote: > > On Fri Jul 18, 2025 at 10:10 AM MDT, Doug Anderson wrote: > >> +#define mipi_dsi_dual(_func, _dsi1, _dsi2, _ctx, ...) \ > >> + _mipi_dsi_dual(_func, _dsi1, _dsi2, _ctx, ##__VA_ARGS__) > >> + > >> +#define _mipi_dsi_d

Re: [PATCH v2 16/19] gpu: nova-core: falcon: add distinct base address for PFALCON2

2025-07-18 Thread John Hubbard
On 7/18/25 12:26 AM, Alexandre Courbot wrote: ... diff --git a/drivers/gpu/nova-core/falcon/gsp.rs b/drivers/gpu/nova-core/falcon/gsp.rs index 0db9f94036a6a7ced5a461aec2cff2ce246a5e0e..f17599cb49fa1e5077a554dc14b3715aa62a4ebd 100644 --- a/drivers/gpu/nova-core/falcon/gsp.rs +++ b/drivers/gpu/n

Re: [PATCH] [PATCH v2] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Rodrigo Vivi
On Fri, Jul 18, 2025 at 01:34:13PM -0300, Luiz Otavio Mello wrote: Oi Luiz! :) First of all thank you so much for the patch. A few comments below: > Includes the missing file drm_device.h, which was unintentionally > omitted in v1. This version comment should be below, not in the beginning of t

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-18 Thread Alex Deucher
On Fri, Jul 18, 2025 at 1:57 PM Brian Geffon wrote: > > On Thu, Jul 17, 2025 at 10:59 AM Alex Deucher wrote: > > > > On Wed, Jul 16, 2025 at 8:13 PM Brian Geffon wrote: > > > > > > On Wed, Jul 16, 2025 at 5:03 PM Alex Deucher > > > wrote: > > > > > > > > On Wed, Jul 16, 2025 at 12:40 PM Brian

[PATCH 1/3] drm/amdgpu: update mmhub 3.0.1 client id mappings

2025-07-18 Thread Alex Deucher
Update the client id mapping so the correct clients get printed when there is a mmhub page fault. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v3_0_1.c | 57 +-- 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmh

[PATCH 3/3] drm/amdgpu: update mmhub 4.1.0 client id mappings

2025-07-18 Thread Alex Deucher
Update the client id mapping so the correct clients get printed when there is a mmhub page fault. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v4_1_0.c | 34 +-- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmh

[PATCH 2/3] drm/amdgpu: update mmhub 3.3 client id mappings

2025-07-18 Thread Alex Deucher
Update the client id mapping so the correct clients get printed when there is a mmhub page fault. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v3_3.c | 104 +++- 1 file changed, 103 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhu

[PATCH] [PATCH v3] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Luiz Otavio Mello
Includes the missing file drm_device.h, which was unintentionally omitted in v1. i915 is the only remaining user of struct_mutex lock. Move it from drm_device to drm_i915_private so it is only used within the i915 driver. Also update intel_guc_log.c to use the new location of struct_mutex. Sign

[PATCH v6 1/1] drm/amd: Re-introduce property to control adaptive backlight modulation

2025-07-18 Thread Mario Limonciello
From: Mario Limonciello commit 0887054d14ae2 ("drm/amd: Drop abm_level property") dropped the abm level property in favor of sysfs control. Since then there have been discussions that compositors showed an interest in modifying a vendor specific property instead. So re-introduce the abm level pr

[PATCH v6 0/1] Panel power savings revisit

2025-07-18 Thread Mario Limonciello
From: Mario Limonciello During the 2025 Display Next Hackfest the topic from the 2024 display next hackfest about what to do with adaptive backlight modulation was revisited. The general consensus was that the 2024 proposed solution [1] although functional was not desirable because it was a bina

Re: [PATCH v2 02/19] gpu: nova-core: register: fix typo

2025-07-18 Thread Boqun Feng
On Fri, Jul 18, 2025 at 04:26:07PM +0900, Alexandre Courbot wrote: > A space was missing between arguments in this invocation. > It's obvious up to driver and Nova folks, but I feel this commit better folded into another patch or we make the title a bit more clear, say: gpu: nova-core: register:

Re: [git pull] drm fixes for 6.16-rc7

2025-07-18 Thread pr-tracker-bot
The pull request you sent on Fri, 18 Jul 2025 20:33:49 +1000: > https://gitlab.freedesktop.org/drm/kernel.git tags/drm-fixes-2025-07-18-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/c460535a6d6182dcb00773132a8c384c1f9b5408 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH 6/9] drm/msm/dp: Work around bogus maximum link rate

2025-07-18 Thread Dmitry Baryshkov
On 18/07/2025 21:26, Jérôme de Bretagne wrote: On Friday, Jul 18, 2025, Dmitry Baryshkov wrote: On Thu, Jul 17, 2025 at 11:36:38PM +0200, Jérôme de Bretagne wrote: Le jeu. 17 juil. 2025 à 23:10, Konrad Dybcio a écrit : On 7/17/25 10:27 PM, Jérôme de Bretagne wrote: On 2025/7/17 04:21, Xil

Re: [PATCH 6/9] drm/msm/dp: Work around bogus maximum link rate

2025-07-18 Thread Jérôme de Bretagne
On Friday, Jul 18, 2025, Dmitry Baryshkov wrote: > > On Thu, Jul 17, 2025 at 11:36:38PM +0200, Jérôme de Bretagne wrote: > > Le jeu. 17 juil. 2025 à 23:10, Konrad Dybcio > > a écrit : > > > > > > On 7/17/25 10:27 PM, Jérôme de Bretagne wrote: > > > > On 2025/7/17 04:21, Xilin Wu wrote : > > > >>

Re: [PATCH 6/9] drm/msm/dp: Work around bogus maximum link rate

2025-07-18 Thread Jérôme de Bretagne
On Friday, Jul 18, 2025, Dmitry Baryshkov wrote: > On Thu, Jul 17, 2025 at 11:36:38PM +0200, Jérôme de Bretagne wrote: >> Le jeu. 17 juil. 2025 à 23:10, Konrad Dybcio >> a écrit : >> > >> > On 7/17/25 10:27 PM, Jérôme de Bretagne wrote: >> > > On 2025/7/17 04:21, Xilin Wu wrote : >> > >> >> > >>

Re: Regression: DDC I2C Display Freezing for internal displays

2025-07-18 Thread Mario Limonciello
On 7/17/2025 2:42 PM, Felix Richter wrote: Hi, just tested that this Bug still exists in kernel version 6.16-rc6. The example trigger from my previous mail still works triggering screen freezing shortly after invocation. I also learned that setting kernel param `amdgpu.dcdebugmask=0x10` work

Re: [PATCH] drm/amdgpu: Raven: don't allow mixing GTT and VRAM

2025-07-18 Thread Brian Geffon
On Thu, Jul 17, 2025 at 10:59 AM Alex Deucher wrote: > > On Wed, Jul 16, 2025 at 8:13 PM Brian Geffon wrote: > > > > On Wed, Jul 16, 2025 at 5:03 PM Alex Deucher wrote: > > > > > > On Wed, Jul 16, 2025 at 12:40 PM Brian Geffon wrote: > > > > > > > > On Wed, Jul 16, 2025 at 12:33 PM Alex Deucher

Re: [PATCH v9 9/9] PCI: Add a new 'boot_display' attribute

2025-07-18 Thread Mario Limonciello
On 7/18/2025 12:36 PM, Bjorn Helgaas wrote: On Fri, Jul 18, 2025 at 12:29:05PM -0500, Mario Limonciello wrote: On 7/18/2025 12:25 PM, Bjorn Helgaas wrote: On Thu, Jul 17, 2025 at 12:38:12PM -0500, Mario Limonciello wrote: From: Mario Limonciello On systems with multiple GPUs there can be unc

Re: [PATCH v9 9/9] PCI: Add a new 'boot_display' attribute

2025-07-18 Thread Bjorn Helgaas
On Fri, Jul 18, 2025 at 12:29:05PM -0500, Mario Limonciello wrote: > On 7/18/2025 12:25 PM, Bjorn Helgaas wrote: > > On Thu, Jul 17, 2025 at 12:38:12PM -0500, Mario Limonciello wrote: > > > From: Mario Limonciello > > > > > > On systems with multiple GPUs there can be uncertainty which GPU is the

Re: [PATCH v9 9/9] PCI: Add a new 'boot_display' attribute

2025-07-18 Thread Mario Limonciello
On 7/18/2025 12:25 PM, Bjorn Helgaas wrote: On Thu, Jul 17, 2025 at 12:38:12PM -0500, Mario Limonciello wrote: From: Mario Limonciello On systems with multiple GPUs there can be uncertainty which GPU is the primary one used to drive the display at bootup. In some desktop environments this can

Re: [PATCH][next] drm/msm: remove extraneous semicolon after a statement

2025-07-18 Thread Dmitry Baryshkov
On Fri, Jul 18, 2025 at 02:34:04PM +0100, Colin Ian King wrote: > There is a statement that has an extraneous semicolon; remove it. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/msm/msm_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov

Re: [PATCH v2] drm/msm: Don't use %pK through printk

2025-07-18 Thread Dmitry Baryshkov
On Fri, Jul 18, 2025 at 03:27:37PM +0200, Thomas Weißschuh wrote: > In the past %pK was preferable to %p as it would not leak raw pointer > values into the kernel log. > Since commit ad67b74d2469 ("printk: hash addresses printed with %p") > the regular %p has been improved to avoid this issue. > Fu

Re: [PATCH v8 04/10] accel/rocket: Add job submission IOCTL

2025-07-18 Thread Jeff Hugo
On 7/13/2025 2:38 AM, Tomeu Vizoso wrote: Using the DRM GPU scheduler infrastructure, with a scheduler for each core. Userspace can decide for a series of tasks to be executed sequentially in the same core, so SRAM locality can be taken advantage of. The job submission code was initially based

Re: [PATCH v9 9/9] PCI: Add a new 'boot_display' attribute

2025-07-18 Thread Bjorn Helgaas
On Thu, Jul 17, 2025 at 12:38:12PM -0500, Mario Limonciello wrote: > From: Mario Limonciello > > On systems with multiple GPUs there can be uncertainty which GPU is the > primary one used to drive the display at bootup. In some desktop > environments this can lead to increased power consumption b

Re: [PATCH v4 1/4] drm: Create mipi_dsi_dual macro

2025-07-18 Thread Brigham Campbell
On Fri Jul 18, 2025 at 10:10 AM MDT, Doug Anderson wrote: >> +#define mipi_dsi_dual(_func, _dsi1, _dsi2, _ctx, ...) \ >> + _mipi_dsi_dual(_func, _dsi1, _dsi2, _ctx, ##__VA_ARGS__) >> + >> +#define _mipi_dsi_dual(_func, _dsi1, _dsi2, _ctx, ...) \ >> + do {

Re: [PATCH v8 02/10] accel/rocket: Add a new driver for Rockchip's NPU

2025-07-18 Thread Jeff Hugo
On 7/13/2025 2:38 AM, Tomeu Vizoso wrote: This initial version supports the NPU as shipped in the RK3588 SoC and described in the first part of its TRM, in Chapter 36. This NPU contains 3 independent cores that the driver can submit jobs to. This commit adds just hardware initialization and pow

Re: [PATCH v8 01/10] accel/rocket: Add registers header

2025-07-18 Thread Jeff Hugo
On 7/13/2025 2:38 AM, Tomeu Vizoso wrote: A XML file was generated with the data from the TRM, and then this header was generated from it. The canonical location for the XML file is the Mesa3D repository. v3: - Make use of GPL-2.0-only for the copyright notice (Jeff Hugo) v8: - Remove full MIT

Re: [PATCH] [PATCH v2] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Sam Ravnborg
On Fri, Jul 18, 2025 at 01:34:13PM -0300, Luiz Otavio Mello wrote: > Includes the missing file drm_device.h, which was unintentionally > omitted in v1. > > i915 is the only remaining user of struct_mutex lock. > > Move it from drm_device to drm_i915_private so it is only used within > the i915 dr

Re: [PATCH v10 2/4] drm: add debugfs support on per client-id basis

2025-07-18 Thread Jeff Hugo
On 7/4/2025 1:55 AM, Sunil Khatri wrote: add support to add a directory for each client-id Nitpick. This is the start of a sentence, and therefore proper grammar would have the first letter capitalized. So, "add support" should be "Add support". -Jeff

Re: [PATCH v10 1/4] drm: move drm based debugfs funcs to drm_debugfs.c

2025-07-18 Thread Jeff Hugo
On 7/4/2025 1:55 AM, Sunil Khatri wrote: Requirement is to create per client-id based directories to hold key debugging information and for that access to root debugfs dentry is need which is not in one place and that information cannot be stored in drm_device. Move the debugfs functionality fro

Re: [PATCH] drm/amdgpu: check if hubbub is NULL in debugfs/amdgpu_dm_capabilities

2025-07-18 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Jul 17, 2025 at 4:58 PM Peter Shkenev wrote: > > HUBBUB structure is not initialized on DCE hardware, so check if it is NULL > to avoid null dereference while accessing amdgpu_dm_capabilities file in > debugfs. > > Signed-off-by: Peter Shkenev > --- > drivers/gpu

Re: [PATCH v6 08/10] drm/display: bridge-connector: hook in CEC notifier support

2025-07-18 Thread Dmitry Baryshkov
On Fri, Jul 18, 2025 at 04:41:56PM +0200, Luca Ceresoli wrote: > Hi Dmitry, > > On Sat, 17 May 2025 04:59:44 +0300 > Dmitry Baryshkov wrote: > > > Allow HDMI DRM bridges to create CEC notifier. Physical address is > > handled automatically by drm_atomic_helper_connector_hdmi_hotplug() > > being

Re: [PATCH v3 0/5] dt-bindings: msm/dp: Add support for 4 pixel streams

2025-07-18 Thread Jessica Zhang
On 7/18/2025 2:22 AM, Dmitry Baryshkov wrote: On Thu, Jul 17, 2025 at 04:28:42PM -0700, Jessica Zhang wrote: On some MSM chipsets, the display port controller is capable of supporting up to 4 streams. To drive these additional streams, the pixel clocks for the corresponding stream needs to b

Re: [PATCH v3 1/5] dt-bindings: Fixup x1e80100 to add DP MST support

2025-07-18 Thread Jessica Zhang
On 7/17/2025 11:16 PM, Krzysztof Kozlowski wrote: On 18/07/2025 01:28, Jessica Zhang wrote: From: Abhinav Kumar Add x1e80100 to the dp-controller bindings, fix the displayport-controller reg bindings, and drop assigned-clock-parents/assigned-clocks Signed-off-by: Abhinav Kumar Reviewed-by

Re: [PATCH v3 5/5] arm64: dts: qcom: Add MST pixel streams for displayport

2025-07-18 Thread Jessica Zhang
On 7/18/2025 2:23 AM, Konrad Dybcio wrote: On 7/18/25 1:28 AM, Jessica Zhang wrote: The following chipsets support 2 total pixel streams: - sa8775p (on mdss_dp1) - sc8180x - sc8280xp (mdss_dp0-2 only) - sm8150 - sm8350 I think 8250 can do 2 streams too, no? Hi Konrad, Yes,

Re: [PATCH v3 5/5] arm64: dts: qcom: Add MST pixel streams for displayport

2025-07-18 Thread Jessica Zhang
On 7/18/2025 2:20 AM, Dmitry Baryshkov wrote: On Thu, Jul 17, 2025 at 04:28:47PM -0700, Jessica Zhang wrote: The following chipsets support 2 total pixel streams: - sa8775p (on mdss_dp1) Uppercase chipset names. Hi Dmitry, Ack. - sc8180x - sc8280xp (mdss_dp0-2 only) - sm8

[PATCH] [PATCH v2] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Luiz Otavio Mello
Includes the missing file drm_device.h, which was unintentionally omitted in v1. i915 is the only remaining user of struct_mutex lock. Move it from drm_device to drm_i915_private so it is only used within the i915 driver. Also update intel_guc_log.c to use the new location of struct_mutex. Sign

Re: [PATCH 4/4] arm64: dts: imx8mp: Add hdmi parallel audio interface node

2025-07-18 Thread Frank Li
On Fri, Jul 18, 2025 at 06:11:50PM +0800, Shengjiu Wang wrote: > The HDMI TX Parallel Audio Interface (HTX_PAI) is a digital module that > acts as the bridge between the Audio Subsystem to the HDMI TX Controller. Remove " a digital module that acts as the" is more straightforward. > > Correct the

Re: [PATCH 3/4] dt-bindings: display: imx: add binding for i.MX8MP HDMI PAI

2025-07-18 Thread Frank Li
On Fri, Jul 18, 2025 at 06:11:49PM +0800, Shengjiu Wang wrote: Subject needn't said binding again. dt-bindings: display: imx: add HDMI PAI for i.MX8MP > Add binding for the i.MX8MP HDMI parallel Audio interface block. Need empty line between two paragraph > As this port is linked to imx8mp-hdm

Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST

2025-07-18 Thread Rodrigo Vivi
On Fri, Jul 18, 2025 at 02:59:10PM +0100, Ruben Wauters wrote: > On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote: > > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: > > convert drm_mm selftest to KUnit) and all functions under it were > > converted to KUnit, under the

Re: [PATCH v4 1/4] drm: Create mipi_dsi_dual macro

2025-07-18 Thread Doug Anderson
Hi, On Thu, Jul 17, 2025 at 9:41 AM Brigham Campbell wrote: > > Create mipi_dsi_dual macro for panels which are driven by two parallel > serial interfaces. This allows for the reduction of code duplication in > drivers for these panels. > > Signed-off-by: Brigham Campbell > --- > include/drm/d

[PATCH] drm/i915: move struct_mutex from drm_device to drm_i915_private

2025-07-18 Thread Luiz Otavio Mello
i915 is the only remaining user of struct_mutex lock. Move it from drm_device to drm_i915_private so it is only used within the i915 driver. Signed-off-by: Luiz Otavio Mello --- drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h| 8 2 files

Re: [PATCH 1/4] drm/bridge: dw-hdmi: Add function to get plat_data

2025-07-18 Thread Frank Li
On Fri, Jul 18, 2025 at 06:11:47PM +0800, Shengjiu Wang wrote: > The enable_audio() and disable_audio() callback pointers are in > plat_data structure, and the audio device driver needs to get plat_data > for assign these pointers. So add a function to export plat_data > structure. drm/bridge: dw-

Re: [PATCH v4 2/4] drm/panel: jdi-lpm102a188a: Fix bug and clean up driver

2025-07-18 Thread Doug Anderson
Hi, On Thu, Jul 17, 2025 at 9:41 AM Brigham Campbell wrote: > > static int jdi_panel_prepare(struct drm_panel *panel) > { > struct jdi_panel *jdi = to_panel_jdi(panel); > + struct mipi_dsi_multi_context dsi_ctx = { .accum_err = 0 }; nit: can just be this: struct mipi_dsi_multi_

Re: [PATCH] drm/panthor: Fix memory leak in panthor_ioctl_group_create()

2025-07-18 Thread Steven Price
On 13/11/2024 21:03, Jann Horn wrote: > When bailing out due to group_priority_permit() failure, the queue_args > need to be freed. Fix it by rearranging the function to use the > goto-on-error pattern, such that the success case flows straight without > indentation while error cases jump forward t

Re: [PATCH v5 00/16] drm/vkms: Add configfs support

2025-07-18 Thread Louis Chauvet
Le 18/07/2025 à 15:03, Marius Vlad a écrit : Hi, FWIW, we (Weston) also use vkms in CI and we have in plan to make use of these changes to exercise some internal code paths and enhance our tests. Look forward to getting these into the tree and have it a in release. We tend to follow with a br

Re: [PATCH] iosys-map: Fix undefined behavior in iosys_map_clear()

2025-07-18 Thread Thomas Zimmermann
Hi Am 18.07.25 um 16:47 schrieb Andi Shyti: Hi Nitin, On Fri, Jul 18, 2025 at 04:20:51PM +0530, Nitin Gote wrote: The current iosys_map_clear() implementation reads the potentially uninitialized 'is_iomem' boolean field to decide which union member to clear. This causes undefined behavior when

[PATCH v2] drm/sitronix/st7571-i2c: Make st7571_panel_data variables static const

2025-07-18 Thread Javier Martinez Canillas
The kernel test robot reported that sparse gives the following warnings: make C=2 M=drivers/gpu/drm/sitronix/ CC [M] st7571-i2c.o CHECK st7571-i2c.c st7571-i2c.c:1027:26: warning: symbol 'st7567_config' was not declared. Should it be static? st7571-i2c.c:1039:26: warning: symbol 'st7571_co

[PATCH 1/2] drm/bridge: add connector argument to .hpd_notify callback

2025-07-18 Thread Dmitry Baryshkov
Drivers might need to update DRM connector in the drm_bridge_funcs.hpd_notify callback (e.g. it might be necessary to update EDID before setting ELD). Add corresponding argument to the callback. Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/display/drm_bridge_connector.c | 2 +- drivers/gp

[PATCH 2/2] drm/bridge: lontium-lt9611uxc: switch to HDMI audio helpers

2025-07-18 Thread Dmitry Baryshkov
While LT9611UXC is a DSI-to-HDMI bridge, it implements all HDMI-related functions internally, in the firmware, thus it doesn't make sense to implement DRM_BRIDGE_OP_HDMI. However it is possible to implement DRM_BRIDGE_OP_HDMI_AUDIO, streamlining HDMI audio plumbing (which includes plugged notificat

[PATCH 0/2] drm/bridge: lontium-lt9611uxc: switch to DRM_BRIDGE_OP_HDMI_AUDIO

2025-07-18 Thread Dmitry Baryshkov
+- drivers/gpu/drm/omapdrm/dss/hdmi4.c| 1 + include/drm/drm_bridge.h | 1 + 7 files changed, 57 insertions(+), 79 deletions(-) --- base-commit: 024e09e444bd2b06aee9d1f3fe7b313c7a2df1bb change-id: 20250718-lt9611uxc-hdmi-3dd96306cdff Best regards, -- With best

Re: [PATCH v4 7/7] drm/panthor: Expose the panthor perf ioctls

2025-07-18 Thread Adrián Larumbe
Hi Lucas, another missing remark from the original review, On 16.05.2025 16:49, Lukas Zapolskas wrote: > This patch implements the PANTHOR_PERF_CONTROL ioctl series, and > a PANTHOR_GET_UOBJ wrapper to deal with the backwards and forwards > compatibility of the uAPI. > > The minor version is bumpe

Re: [PATCH v4 2/7] drm/panthor: Add DEV_QUERY.PERF_INFO handling for Gx10

2025-07-18 Thread Adrián Larumbe
Hi Lucas, forgot to add one comment in the previous patch review, On 16.05.2025 16:49, Lukas Zapolskas wrote: > This change adds the IOCTL to query data about the performance counter > setup. Some of this data was available via previous DEV_QUERY calls, > for instance for GPU info, but exposing it

Re: [PATCH v4 7/7] drm/panthor: Expose the panthor perf ioctls

2025-07-18 Thread Adrián Larumbe
Hi Lucas, this whole patch is alright, but don't forget to bump the driver minor revision up, because 1.5 has alrady been assigned: 1.5 - adds DRM_PANTHOR_SET_USER_MMIO_OFFSET ioctl On 16.05.2025 16:49, Lukas Zapolskas wrote: > This patch implements the PANTHOR_PERF_CONTROL ioctl series, and > a

Re: [PATCH v4 6/7] drm/panthor: Add suspend, resume and reset handling

2025-07-18 Thread Adrián Larumbe
On 16.05.2025 16:49, Lukas Zapolskas wrote: > The sampler must disable and re-enable counter sampling around suspends, > and must re-program the FW interface after a reset to avoid losing > data. > > Signed-off-by: Lukas Zapolskas > --- > drivers/gpu/drm/panthor/panthor_device.c | 7 +- > drive

Re: [PATCH v4 5/7] drm/panthor: Implement the counter sampler and sample handling

2025-07-18 Thread Adrián Larumbe
On 16.05.2025 16:49, Lukas Zapolskas wrote: > From: Adrián Larumbe > > The sampler aggregates counter and set requests coming from userspace > and mediates interactions with the FW interface, to ensure that user > sessions cannot override the global configuration. > > From the top-level interface,

[PATCH v8] Add CRIU support for amdgpu dmabuf

2025-07-18 Thread David Francis
This patch series adds support for CRIU checkpointing of processes that share memory with the amdgpu dmabuf interface. This v8 incorporates the vm mapping rework, which it depends on. (https://lore.kernel.org/amd-gfx/880855c5-dede-4497-8ca1-916bd0dbd...@amd.com/T/#u) Accompanying CRIU changes: ht

[PATCH v8 3/3] drm/amdgpu: Allow kfd CRIU with no buffer objects

2025-07-18 Thread David Francis
The kfd CRIU checkpoint ioctl would return an error if trying to checkpoint a process with no kfd buffer objects. This is a normal case and should not be an error. Signed-off-by: David Francis --- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v8 2/3] drm/amdgpu: Add CRIU mapping info ioctl

2025-07-18 Thread David Francis
Add new ioctl DRM_IOCTL_AMDGPU_CRIU_MAPPING_INFO, which returns a list of mappings associated with a given bo, along with their positions and offsets. Signed-off-by: David Francis --- drivers/gpu/drm/amd/amdgpu/amdgpu_criu.c | 97 drivers/gpu/drm/amd/amdgpu/amdgpu_criu.h

[PATCH v8 1/3] drm/amdgpu: Add CRIU ioctl to get bo info

2025-07-18 Thread David Francis
Add new ioctl DRM_IOCTL_AMDGPU_CRIU_BO_INFO. This ioctl returns a list of bos with their handles, sizes, and flags and domains. This ioctl is meant to be used during CRIU checkpoint and provide information needed to reconstruct the bos in CRIU restore. Signed-off-by: David Francis --- drivers/

Re: [PATCH] iosys-map: Fix undefined behavior in iosys_map_clear()

2025-07-18 Thread Andi Shyti
Hi Nitin, On Fri, Jul 18, 2025 at 04:20:51PM +0530, Nitin Gote wrote: > The current iosys_map_clear() implementation reads the potentially > uninitialized 'is_iomem' boolean field to decide which union member > to clear. This causes undefined behavior when called on uninitialized > structures, as

Re: [PATCH v2 1/5] mm/hmm: HMM API to enable P2P DMA for device private pages

2025-07-18 Thread Jason Gunthorpe
On Fri, Jul 18, 2025 at 03:17:00PM +0100, Matthew Wilcox wrote: > On Fri, Jul 18, 2025 at 02:51:08PM +0300, Yonatan Maman wrote: > > +++ b/include/linux/memremap.h > > @@ -89,6 +89,14 @@ struct dev_pagemap_ops { > > */ > > vm_fault_t (*migrate_to_ram)(struct vm_fault *vmf); > > > > + /

Re: [PATCH] drm/tidss: encoder: convert to devm_drm_bridge_alloc()

2025-07-18 Thread Luca Ceresoli
Hello Tomi, On Fri, 18 Jul 2025 14:13:03 +0300 Tomi Valkeinen wrote: > Hi, > > On 17/07/2025 16:56, Luca Ceresoli wrote: > > Hello Jyri, Tomi, Michael, > > > > On Thu, 17 Jul 2025 09:49:44 +0200 > > "Michael Walle" wrote: > > > >> Hi, > >> > >> thanks for taking a look! > >> > >>> Howeve

Re: [PATCH v6 08/10] drm/display: bridge-connector: hook in CEC notifier support

2025-07-18 Thread Luca Ceresoli
Hi Dmitry, On Sat, 17 May 2025 04:59:44 +0300 Dmitry Baryshkov wrote: > Allow HDMI DRM bridges to create CEC notifier. Physical address is > handled automatically by drm_atomic_helper_connector_hdmi_hotplug() > being called from .detect() path. > > Signed-off-by: Dmitry Baryshkov > Reviewed-by

Re: [PATCH v2 1/5] mm/hmm: HMM API to enable P2P DMA for device private pages

2025-07-18 Thread Matthew Wilcox
On Fri, Jul 18, 2025 at 02:51:08PM +0300, Yonatan Maman wrote: > +++ b/include/linux/memremap.h > @@ -89,6 +89,14 @@ struct dev_pagemap_ops { >*/ > vm_fault_t (*migrate_to_ram)(struct vm_fault *vmf); > > + /* > + * Used for private (un-addressable) device memory only. Retur

Re: [PATCH v2] drm/i915: replace DRM_DEBUG_SELFTEST with DRM_KUNIT_TEST

2025-07-18 Thread Ruben Wauters
On Tue, 2025-07-01 at 12:54 +0100, Ruben Wauters wrote: > DRM_DEBUG_SELFTEST was removed in commit fc8d29e298cf (drm: selftest: > convert drm_mm selftest to KUnit) and all functions under it were > converted to KUnit, under the DRM_KUNIT_TEST option > > This conversion however did not occur in the

RE: [PATCH] drm/amdgpu: Initialize data to NULL in imu_v12_0_program_rlc_ram()

2025-07-18 Thread Deucher, Alexander
[Public] > -Original Message- > From: Nathan Chancellor > Sent: Tuesday, July 15, 2025 7:50 PM > To: Deucher, Alexander ; Koenig, Christian > > Cc: Gao, Likun ; Zhang, Hawking > ; amd-...@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; l...@lists.linux.dev; patc...@lists.linux

Re: [PATCH v2 7/8] xen/xenbus: Fix typo "notifer"

2025-07-18 Thread Jürgen Groß
On 15.07.25 15:44, WangYuli wrote: There is a spelling mistake of 'notifer' in the comment which should be 'notifier'. Link: https://lore.kernel.org/all/b3c019b63c93846f+20250715071245.398846-1-wangy...@uniontech.com/ Signed-off-by: WangYuli Reviewed-by: Juergen Gross Juergen OpenPGP_0x

[PATCH][next] drm/msm: remove extraneous semicolon after a statement

2025-07-18 Thread Colin Ian King
There is a statement that has an extraneous semicolon; remove it. Signed-off-by: Colin Ian King --- drivers/gpu/drm/msm/msm_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c index c317b25a8162..33caefd0f877 100

[PATCH v2] drm/msm: Don't use %pK through printk

2025-07-18 Thread Thomas Weißschuh
In the past %pK was preferable to %p as it would not leak raw pointer values into the kernel log. Since commit ad67b74d2469 ("printk: hash addresses printed with %p") the regular %p has been improved to avoid this issue. Furthermore, restricted pointers ("%pK") were never meant to be used through p

Re: [PATCH] Revert "drm/amd/display: limit clear_update_flags to dcn32 and above"

2025-07-18 Thread Melissa Wen
On 18-07-2025 00:51, Matthew Schwartz wrote: [...] > > Sure, going to use my Legion Go S w/ Z2 Go for this (DCN 3.1.2). All > of these are from amd-staging-drm-next with AMD_PRIVATE_COLOR=y. > > DTN log from Hades II with MangoHud enabled: > https://gist.github.com/matte-schwartz/0c290ffe99bdb4f0

Re: [PATCH v5 00/16] drm/vkms: Add configfs support

2025-07-18 Thread Marius Vlad
Hi, FWIW, we (Weston) also use vkms in CI and we have in plan to make use of these changes to exercise some internal code paths and enhance our tests. Look forward to getting these into the tree and have it a in release. We tend to follow with a branch/stable release so I suppose that's going be

Re: [PATCH v1 5/7] drm/ci: uprev IGT

2025-07-18 Thread Dmitry Baryshkov
On Fri, Jul 18, 2025 at 04:23:57PM +0530, Vignesh Raman wrote: > Uprev IGT to the latest version and update expectation files. > > Signed-off-by: Vignesh Raman > --- > drivers/gpu/drm/ci/gitlab-ci.yml | 2 +- > .../gpu/drm/ci/xfails/amdgpu-stoney-fails.txt | 2 + > .../drm/ci/xf

Re: [PATCH v1] drm/vkms: Add writeback encoders as possible clones

2025-07-18 Thread Robert Mader
On 18.07.25 12:23, Louis Chauvet wrote: Le 03/07/2025 à 11:03, Robert Mader a écrit : Since commit 41b4b11da0215 ("drm: Add valid clones check") setting the `possible_clones` values is a hard requirement for cloning. `vkms` supports cloning for writeback connectors in order to capture CRTC con

[PATCH v2] drm/vkms: Add writeback encoders as possible clones

2025-07-18 Thread Robert Mader
Since commit 41b4b11da0215 ("drm: Add valid clones check") setting the `possible_clones` values is a hard requirement for cloning. `vkms` supports cloning for writeback connectors in order to capture CRTC content, however that broke with said commit. Writeback connectors are created on a per-CRTC

[PATCH 4/4] arm64: dts: imx8mp: Add hdmi parallel audio interface node

2025-07-18 Thread Shengjiu Wang
The HDMI TX Parallel Audio Interface (HTX_PAI) is a digital module that acts as the bridge between the Audio Subsystem to the HDMI TX Controller. Correct the register map of hdmi_pvi, which is overlapped with the hdmi_pai device. Signed-off-by: Shengjiu Wang --- arch/arm64/boot/dts/freescale/im

[PATCH 2/4] drm/bridge: imx: add driver for HDMI TX Parallel Audio Interface

2025-07-18 Thread Shengjiu Wang
The HDMI TX Parallel Audio Interface (HTX_PAI) is a digital module that acts as the bridge between the Audio Subsystem to the HDMI TX Controller. This IP block is found in the HDMI subsystem of the i.MX8MP SoC. Data received from the audio subsystem can have an arbitrary component ordering. The HT

[PATCH 3/4] dt-bindings: display: imx: add binding for i.MX8MP HDMI PAI

2025-07-18 Thread Shengjiu Wang
Add binding for the i.MX8MP HDMI parallel Audio interface block. As this port is linked to imx8mp-hdmi-tx, add port@2 in fsl,imx8mp-hdmi-tx.yaml document. Signed-off-by: Shengjiu Wang --- .../display/bridge/fsl,imx8mp-hdmi-tx.yaml| 13 .../display/imx/fsl,imx8mp-hdmi-pai.yaml | 61

[PATCH v2] gpu: nova-core: vbios: use size_of instead of magic number

2025-07-18 Thread Rhys Lloyd
12 is identical to the value of `size_of::()`, so use the latter instead. Signed-off-by: Rhys Lloyd --- Changes in v2: - Added `#[repr(C)]` to `BitHeader` --- drivers/gpu/nova-core/vbios.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/vbios.rs b/dr

[PATCH v3] gpu: nova-core: vbios: change PmuLookupTableEntry to use size_of

2025-07-18 Thread Rhys Lloyd
Annotate the PmuLookupTableEntry with an `#[repr(C, packed)]` attribute. Removes another magic number by making the struct the same size as the data it needs to read, allowing the use of `size_of::()` Signed-off-by: Rhys Lloyd --- Changes in v2: - get_data helper function renamed to data Changes

[PATCH 1/4] drm/bridge: dw-hdmi: Add function to get plat_data

2025-07-18 Thread Shengjiu Wang
The enable_audio() and disable_audio() callback pointers are in plat_data structure, and the audio device driver needs to get plat_data for assign these pointers. So add a function to export plat_data structure. Signed-off-by: Shengjiu Wang --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 +

[PATCH] gpu: nova-core: vbios: use offset_of in PmuLookupTableHeader::new

2025-07-18 Thread Rhys Lloyd
Use the offset_of macro for each struct field, annotate the `PmuLookupTableHeader` struct with `#[repr(C)]` attribute, and add a TODO message to use FromBytes when available. Signed-off-by: Rhys Lloyd --- drivers/gpu/nova-core/vbios.rs | 10 ++ 1 file changed, 6 insertions(+), 4 deletion

[PATCH 0/4] drm/bridge: imx: Add HDMI PAI driver on i.MX8MP

2025-07-18 Thread Shengjiu Wang
The HDMI TX Parallel Audio Interface (HTX_PAI) is a digital module that acts as the bridge between the Audio Subsystem to the HDMI TX Controller. Add HDMI PAI driver on i.MX8MP to make HDMI audio function fully work. Shengjiu Wang (4): drm/bridge: dw-hdmi: Add function to get plat_data drm/br

[PATCH v2 4/4] hax: drm/i915: Disable TPS4 support to force POST_LT_ADJ_REQ usage

2025-07-18 Thread Ville Syrjala
From: Ville Syrjälä Disable TPS4 in favor of POST_LT_ADJ_REQ for testing purposes. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp_link_training.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/

[PATCH v2 3/4] drm/i915/dp: Implement the POST_LT_ADJ_REQ sequence

2025-07-18 Thread Ville Syrjala
From: Ville Syrjälä Implement the POST_LT_ADJ_REQ sequence, which should be used to further fine tune the link if TPS4 is not supported. The POST_LT_ADJ_REQ sequence will be performed after the normal link training has succeeded. Only the final hop between the last LTTPR and DPRX will perform th

[PATCH v2 2/4] drm/dp: Add POST_LT_ADJ_REQ helpers

2025-07-18 Thread Ville Syrjala
From: Ville Syrjälä Add small helpers (drm_dp_post_lt_adj_req_supported() and drm_dp_post_lt_adj_req_in_progress()) to help with implementing the POST_LT_ADJ_REQ sequence. Tested-by: Imre Deak Reviewed-by: Imre Deak Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/display/drm_dp_helper.c | 8

  1   2   >