[PATCH v16 5/9] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap

2024-06-24 Thread Vivek Kasireddy
Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel

[PATCH v16 9/9] selftests/udmabuf: Add tests to verify data after page migration

2024-06-24 Thread Vivek Kasireddy
Since the memfd pages associated with a udmabuf may be migrated as part of udmabuf create, we need to verify the data coherency after successful migration. The new tests added in this patch try to do just that using 4k sized pages and also 2 MB sized huge pages for the memfd. Successful

[PATCH v16 3/9] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios

2024-06-24 Thread Vivek Kasireddy
For drivers that would like to longterm-pin the folios associated with a memfd, the memfd_pin_folios() API provides an option to not only pin the folios via FOLL_PIN but also to check and migrate them if they reside in movable zone or CMA block. This API currently works with memfds but it should

[PATCH v16 8/9] udmabuf: Pin the pages using memfd_pin_folios() API

2024-06-24 Thread Vivek Kasireddy
Using memfd_pin_folios() will ensure that the pages are pinned correctly using FOLL_PIN. And, this also ensures that we don't accidentally break features such as memory hotunplug as it would not allow pinning pages in the movable zone. Using this new API also simplifies the code as we no longer

[PATCH v16 7/9] udmabuf: Convert udmabuf driver to use folios

2024-06-24 Thread Vivek Kasireddy
This is mainly a preparatory patch to use memfd_pin_folios() API for pinning folios. Using folios instead of pages makes sense as the udmabuf driver needs to handle both shmem and hugetlb cases. And, using the memfd_pin_folios() API makes this easier as we no longer need to separately handle shmem

[PATCH v16 6/9] udmabuf: Add back support for mapping hugetlb pages

2024-06-24 Thread Vivek Kasireddy
A user or admin can configure a VMM (Qemu) Guest's memory to be backed by hugetlb pages for various reasons. However, a Guest OS would still allocate (and pin) buffers that are backed by regular 4k sized pages. In order to map these buffers and create dma-bufs for them on the Host, we first need

[PATCH v16 0/9] mm/gup: Introduce memfd_pin_folios() for pinning memfd folios

2024-06-24 Thread Vivek Kasireddy
Currently, some drivers (e.g, Udmabuf) that want to longterm-pin the pages/folios associated with a memfd, do so by simply taking a reference on them. This is not desirable because the pages/folios may reside in Movable zone or CMA block. Therefore, having drivers use memfd_pin_folios() API

[PATCH v16 2/9] mm/gup: Introduce check_and_migrate_movable_folios()

2024-06-24 Thread Vivek Kasireddy
This helper is the folio equivalent of check_and_migrate_movable_pages(). Therefore, all the rules that apply to check_and_migrate_movable_pages() also apply to this one as well. Currently, this helper is only used by memfd_pin_folios(). This patch also includes changes to rename and convert the

[PATCH v16 4/9] udmabuf: add CONFIG_MMU dependency

2024-06-24 Thread Vivek Kasireddy
From: Arnd Bergmann There is no !CONFIG_MMU version of vmf_insert_pfn(): arm-linux-gnueabi-ld: drivers/dma-buf/udmabuf.o: in function `udmabuf_vm_fault': udmabuf.c:(.text+0xaa): undefined reference to `vmf_insert_pfn' Fixes: d1d00dd1fd2f ("udmabuf: use vmf_insert_pfn and VM_PFNMAP for handling

[PATCH v16 1/9] mm/gup: Introduce unpin_folio/unpin_folios helpers

2024-06-24 Thread Vivek Kasireddy
These helpers are the folio versions of unpin_user_page/unpin_user_pages. They are currently only useful for unpinning folios pinned by memfd_pin_folios() or other associated routines. However, they could find new uses in the future, when more and more folio-only helpers are added to GUP. We

Re: [PATCH] agp: add missing MODULE_DESCRIPTION() macros

2024-06-24 Thread Dave Airlie
> > Following up to see if anything else is needed from me. > Hoping to see this in linux-next :) I just pushed this into drm-next. Thanks, Dave.

Re: [PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-24 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 01:11:48PM +0200, Krzysztof Kozlowski wrote: > On 23/06/2024 13:06, Akhil P Oommen wrote: > > This series adds support for the Adreno X1-85 GPU found in Qualcomm's > > compute series chipset, Snapdragon X1 Elite (x1e80100). In this new > > naming scheme for Adreno GPU, 'X'

Re: Time for drm-ci-next?

2024-06-23 Thread Vignesh Raman
Hi, On 15/03/24 22:50, Rob Clark wrote: On Fri, Mar 15, 2024 at 2:28 AM Jani Nikula wrote: On Thu, 14 Mar 2024, Rob Clark wrote: When we first merged drm/ci I was unsure if it would need it's own -next branch. But after using it for a couple releases, a few times I've found myself wanting

Re: [PATCH 5/7] drm/panel: add driver for samsung amb655x

2024-06-23 Thread Dmitry Baryshkov
On Mon, Jun 24, 2024 at 03:30:29AM GMT, Caleb Connolly wrote: > This is a 1080x2400 120hz panel used on the OnePlus 8T. It uses DSC but > uses non-standard DCS commands. Please add a note regarding the panel using long packets for all the commands. Also the cover letter had a mention of the

Re: [PATCH 4/7] drm: mipi: add mipi_dsi_generic_write_multi_type()

2024-06-23 Thread Dmitry Baryshkov
On Mon, Jun 24, 2024 at 03:30:28AM GMT, Caleb Connolly wrote: > Some panels like the Samsung AMB655X use long write commands for all > non-standard messages and do not work when trying to use the appropriate > command type. > > Support these panels by introducing a new helper to send commands of

Re: [PATCH 0/7] qcom: initial support for the OnePlus 8T

2024-06-23 Thread Dmitry Baryshkov
On Mon, Jun 24, 2024 at 03:30:24AM GMT, Caleb Connolly wrote: > Add bindings for the SM8250 OnePlus devices, a common devicetree, > touchscreen and display drivers, and a dts for the OnePlus 8T (kebab). > > The OnePlus 8 series is made up of 3 flagship smartphones from 2019, > featuring the

Re: [PATCH 3/7] dt-bindings: arm: qcom: add OnePlus 8 series

2024-06-23 Thread Krzysztof Kozlowski
On 24/06/2024 03:30, Caleb Connolly wrote: > Add bindings for the OnePlus 8, 8 Pro, and 8T devices. > > Signed-off-by: Caleb Connolly Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH] drm/amd/display: Use ARRAY_SIZE for array length

2024-06-23 Thread Jiapeng Chong
Use of macro ARRAY_SIZE to calculate array size minimizes the redundant code and improves code reusability. ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:164:45-46: WARNING: Use ARRAY_SIZE. ./drivers/gpu/drm/amd/display/modules/hdcp/hdcp_ddc.c:183:47-48: WARNING: Use ARRAY_SIZE.

Re: [PATCH 2/7] dt-bindings: input: touchscreen: document synaptics TCM oncell

2024-06-23 Thread Rob Herring (Arm)
On Mon, 24 Jun 2024 03:30:26 +0200, Caleb Connolly wrote: > Document the Synaptics TCM oncell series of touchscreens, starting with > the s3908. > > Signed-off-by: Caleb Connolly > --- > .../input/touchscreen/syna,tcm-oncell.yaml | 66 > ++ > 1 file changed, 66

[PATCH] drm/stm: ltdc: Remove unused function plane_to_ltdc

2024-06-23 Thread Jiapeng Chong
The function are defined in the ltdc.c file, but not called anywhere, so delete the unused function. drivers/gpu/drm/stm/ltdc.c:494:35: warning: unused function 'encoder_to_ltdc'. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9403 Signed-off-by: Jiapeng Chong

[PATCH] drm/amd/display: Remove unused function reverse_planes_order

2024-06-23 Thread Jiapeng Chong
The function are defined in the amdgpu_dm.c file, but not called anywhere, so delete the unused function. drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:371:20: warning: unused function 'reverse_planes_order'. Reported-by: Abaci Robot Closes:

[PATCH] drm/amd/display: use swap() in is_config_schedulable()

2024-06-23 Thread Jiapeng Chong
Use existing swap() function rather than duplicating its implementation. ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c:1171:103-104: WARNING opportunity for swap(). ./drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_pmo/dml2_pmo_dcn4_fams2.c:1231:99-100:

[PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA

2024-06-23 Thread Liu Ying
KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags. This aligns display_timing with panel_desc. Fixes: 8a07052440c2 ("drm/panel: simple: Add support for KOE TX26D202VM0BWA panel") Signed-off-by: Liu Ying

Re: [PATCH v2 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-06-23 Thread Marek Vasut
On 6/23/24 7:20 PM, Conor Dooley wrote: On Sun, Jun 23, 2024 at 04:48:47PM +0200, Marek Vasut wrote: On 6/22/24 1:56 PM, Conor Dooley wrote: On Fri, Jun 21, 2024 at 05:53:53PM +0200, Marek Vasut wrote: Document default DP port preemphasis configurable via new DT property

Re: [PATCH net-next v12 10/13] tcp: RX path for devmem TCP

2024-06-23 Thread Pavel Begunkov
On 6/21/24 21:31, Mina Almasry wrote: On Mon, Jun 17, 2024 at 9:36 AM Pavel Begunkov wrote: On 6/13/24 02:35, Mina Almasry wrote: The pages awaiting freeing are stored in the newly added sk->sk_user_frags, and each page passed to userspace is get_page()'d. This reference is dropped once the

Re: [PATCH net-next v12 06/13] page_pool: devmem support

2024-06-23 Thread Pavel Begunkov
On 6/21/24 19:48, Mina Almasry wrote: On Mon, Jun 17, 2024 at 7:17 AM Pavel Begunkov wrote: ... static inline unsigned long netmem_to_pfn(netmem_ref netmem) { + if (netmem_is_net_iov(netmem)) + return 0; IIRC 0 is a valid pfn. Not much of a concern since it's used only

[PATCH] drm/msm/mdp5: Remove MDP_CAP_SRC_SPLIT from msm8x53_config

2024-06-23 Thread Barnabás Czémán
Remove MDP_CAP_SRC_SPLIT from msm8x53_config because it is not referenced in downstream. Fixes: fb25d4474fa0 ("drm/msm/mdp5: Add configuration for MDP v1.16") Signed-off-by: Barnabás Czémán --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

Re: [PATCH v2 2/4] drm/msm/mdp5: Add MDP5 configuration for MSM8937

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 10:30:37PM GMT, Barnabás Czémán wrote: > From: Daniil Titov > > Add the mdp5_cfg_hw entry for MDP5 version v1.14 found on msm8937. > > Signed-off-by: Daniil Titov > Signed-off-by: Barnabás Czémán > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 88 >

Re: [PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 01:11:48PM GMT, Krzysztof Kozlowski wrote: > On 23/06/2024 13:06, Akhil P Oommen wrote: > > This series adds support for the Adreno X1-85 GPU found in Qualcomm's > > compute series chipset, Snapdragon X1 Elite (x1e80100). In this new > > naming scheme for Adreno GPU, 'X'

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 04:36:30PM GMT, Akhil P Oommen wrote: > Add the necessary dt nodes for gpu support in X1E80100. > > Signed-off-by: Akhil P Oommen > --- > > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 195 + > 1 file changed, 195 insertions(+) > > diff --git

Re: [PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 04:36:29PM GMT, Akhil P Oommen wrote: > Add support in drm/msm driver for the Adreno X185 gpu found in > Snapdragon X1 Elite chipset. > > Signed-off-by: Akhil P Oommen > --- > > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 19 +++ >

Re: [PATCH 2/4] drm/msm/mdp5: Add MDP5 configuration for MSM8937

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 12:48:53PM GMT, Barnabás Czémán wrote: > On Sun, Jun 23, 2024 at 7:59 AM Dmitry Baryshkov > wrote: > > > > On Sun, Jun 23, 2024 at 01:25:52AM GMT, Barnabás Czémán wrote: > > > From: Daniil Titov > > > > > > Add the mdp5_cfg_hw entry for MDP5 version v1.14 found on

Re: [PATCH v4 10/10] drm/vs: add simple dsi encoder

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 07:17:09AM GMT, Keith Zhao wrote: > Hi Dmitry: > > > On Tue, May 21, 2024 at 06:58:17PM +0800, keith wrote: > > > + > > > "starfive,syscon", > > > + 2,

Re: [PATCH v4 08/10] drm/vs: add vs drm master driver

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 07:16:57AM GMT, Keith Zhao wrote: > > On Tue, May 21, 2024 at 06:58:15PM +0800, keith wrote: > > > Add vs DRM master driver for JH7110 SoC ADD DMA GEM driver > > > > > > Signed-off-by: keith > > > --- > > > drivers/gpu/drm/verisilicon/Makefile | 3 +- > > >

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 03:40:06PM -0500, Bjorn Andersson wrote: > On Sun, Jun 23, 2024 at 08:46:30PM GMT, Akhil P Oommen wrote: > > On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: > > > On 23/06/2024 14:28, Akhil P Oommen wrote: > > > > On Sun, Jun 23, 2024 at 01:17:16PM

Re: [PATCH v4 07/10] drm/vs: add ctrc fun

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 07:17:04AM GMT, Keith Zhao wrote: > > On Tue, May 21, 2024 at 06:58:14PM +0800, keith wrote: > > > add crtc funs and helper funs > > > > > > Signed-off-by: keith > > > --- > > > drivers/gpu/drm/verisilicon/Makefile | 3 +- > > > drivers/gpu/drm/verisilicon/vs_crtc.c |

Re: [PATCH v2 1/3] drm: Add panel backlight quirks

2024-06-23 Thread Hans de Goede
Hi, On 6/23/24 10:20 PM, Mario Limonciello wrote: > On 6/23/2024 03:51, Thomas Weißschuh wrote: >> Panels using a PWM-controlled backlight source without an do not have a >> standard way to communicate their valid PWM ranges. >> On x86 the ranges are read from ACPI through driver-specific tables.

Re: [PATCH v4 06/10] drm/vs: add vs plane api

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 07:17:07AM GMT, Keith Zhao wrote: > > > > On Tue, May 21, 2024 at 06:58:13PM +0800, keith wrote: > > > add plane funs and helper funs > > > add vs drm common struct and funs > > > > > > Signed-off-by: keith > > > --- > > > drivers/gpu/drm/verisilicon/Makefile | 3 +-

Re: [PATCH v4 05/10] drm/vs: add vs mode config init

2024-06-23 Thread Dmitry Baryshkov
On Sun, Jun 23, 2024 at 07:17:01AM GMT, Keith Zhao wrote: > Hi Dmitry: > > > -Original Message- > > From: Dmitry Baryshkov Please drop such headers from your replies. A simple "On 1st of January John Doe wrote" is more than enough. -- With best wishes Dmitry

Re: [PATCH v4 04/10] drm/vs: Add hardware funcs for vs.

2024-06-23 Thread Dmitry Baryshkov
Hi Keith, On Sun, Jun 23, 2024 at 07:16:47AM GMT, Keith Zhao wrote: > > On Tue, May 21, 2024 at 06:58:11PM +0800, keith wrote: > > > +} > > > + > > > +static inline void dc_set_clear(struct dc_hw *hw, u32 reg, u32 set, u32 > > > clear) > > > +{ > > > + u32 value = dc_read(hw, reg); > > > + > > >

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Bjorn Andersson
On Sun, Jun 23, 2024 at 08:46:30PM GMT, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: > > On 23/06/2024 14:28, Akhil P Oommen wrote: > > > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: > > >> On 23/06/2024 13:06, Akhil P Oommen

[PATCH v2 4/4] drm/msm/dsi: Add phy configuration for MSM8937

2024-06-23 Thread Barnabás Czémán
From: Daniil Titov Add phy configuration for 28nm dsi phy found on MSM8937 SoC. Only difference from existing msm8916 configuration is number of phy and io_start addresses. Signed-off-by: Daniil Titov Reviewed-by: Dmitry Baryshkov Signed-off-by: Barnabás Czémán ---

[PATCH v2 3/4] dt-bindings: msm: dsi-phy-28nm: Document msm8937 compatible

2024-06-23 Thread Barnabás Czémán
The MSM8937 SoC uses a slightly different 28nm dsi phy. Add a new compatible for it. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Barnabás Czémán --- Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml | 1 + Documentation/devicetree/bindings/display/msm/qcom,mdss.yaml| 1 +

[PATCH v2 2/4] drm/msm/mdp5: Add MDP5 configuration for MSM8937

2024-06-23 Thread Barnabás Czémán
From: Daniil Titov Add the mdp5_cfg_hw entry for MDP5 version v1.14 found on msm8937. Signed-off-by: Daniil Titov Signed-off-by: Barnabás Czémán --- drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 88 1 file changed, 88 insertions(+) diff --git

[PATCH v2 1/4] dt-bindings: display/msm: qcom, mdp5: Add msm8937 compatible

2024-06-23 Thread Barnabás Czémán
Add the compatible for the MDP5 found on MSM8937. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Barnabás Czémán --- Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/display/msm/qcom,mdp5.yaml

[PATCH v2 0/4] MSM8937 MDP/DSI PHY enablement

2024-06-23 Thread Barnabás Czémán
This patch series adds support for the MDP and DSI PHY as found on the MSM8937 platform. Signed-off-by: Barnabás Czémán --- Changes in v2: - Remove MDP_CAP_SRC_SPLIT from mdp5_cfg - Link to v1: https://lore.kernel.org/r/20240623-dsi-v1-0-4ab560eb5...@gmail.com --- Barnabás Czémán (2):

Re: [PATCH v2 1/3] drm: Add panel backlight quirks

2024-06-23 Thread Mario Limonciello
On 6/23/2024 03:51, Thomas Weißschuh wrote: Panels using a PWM-controlled backlight source without an do not have a standard way to communicate their valid PWM ranges. On x86 the ranges are read from ACPI through driver-specific tables. The built-in ranges are not necessarily correct, or may

Re: [PATCH v1] misc: fastrpc: Move fastrpc driver to misc/fastrpc/

2024-06-23 Thread Bjorn Andersson
On Fri, Jun 21, 2024 at 05:52:32PM GMT, Daniel Vetter wrote: > On Fri, Jun 21, 2024 at 09:40:09AM -0600, Jeffrey Hugo wrote: > > On 6/21/2024 5:19 AM, Dmitry Baryshkov wrote: > > > On Fri, 21 Jun 2024 at 09:19, Bjorn Andersson > > > wrote: > > > > > > > > On Wed, Jun 12, 2024 at 09:28:39PM GMT,

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 17:16, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 14:28, Akhil P Oommen wrote: >>> On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: On 23/06/2024 13:06, Akhil P Oommen wrote: > Add the

[PATCH v2 1/4] dt-bindings: display/msm/gpu: constrain clocks in top-level

2024-06-23 Thread Krzysztof Kozlowski
We expect each schema with variable number of clocks, to have the widest constrains in top-level "properties:". This is more readable and also makes binding stricter, if there is no "if:then:" block for given variant. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski ---

[PATCH v2 4/4] dt-bindings: display/msm/gpu: fix the schema being not applied

2024-06-23 Thread Krzysztof Kozlowski
dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for given binding validation if the schema contains compatible list with pattern and a const fallback. This leads to binding being a no-op - not being applied at all. Issue should be fixed in the dtschema but for now add a

[PATCH v2 3/4] dt-bindings: display/msm/gpu: simplify compatible regex

2024-06-23 Thread Krzysztof Kozlowski
Regex for newer Adreno compatibles can be simpler. Suggested-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/msm/gpu.yaml

[PATCH v2 2/4] dt-bindings: display/msm/gpu: define reg-names in top-level

2024-06-23 Thread Krzysztof Kozlowski
All devices should (and actually do) have same order of entries, if possible. That's the case for reg/reg-names, so define the reg-names in top-level to enforce that. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 5 -

[PATCH v2 0/4] dt-bindings: display/msm/gpu: few cleanups

2024-06-23 Thread Krzysztof Kozlowski
Changes since v1: 1. Add tags 2. New patches #3 and #4 3. Drop previous patch "dt-bindings: display/msm/gpu: constrain reg/reg-names per variant", because I need to investigate more. v1: dt-bindings: display/msm/gpu: constrain reg/reg-names per variant Best regards, Krzysztof --- Krzysztof

[PATCH 2/2] arm64: dts: qcom: sm8150-mtp: drop incorrect amd,imageon

2024-06-23 Thread Krzysztof Kozlowski
The SM8150 MTP board does not have magically different GPU than the SM8150, so it cannot use amd,imageon compatible, also pointed by dtbs_check: sm8150-mtp.dtb: gpu@2c0: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,adreno-640.1', 'qcom,adreno', 'amd,imageon'] is

[PATCH 1/2] drm/msm/adreno: allow headless setup on SM8150 MTP

2024-06-23 Thread Krzysztof Kozlowski
Commit f30ac26def18 ("arm64: dts: qcom: add sm8150 GPU nodes") re-used amd,imageon compatible for the SM8150 just to enable headless mode due to missing display controller nodes. This work-around was later narrowed to the SM8150 MTP board in commit 1642ab96efa4 ("arm64: dts: qcom: sm8150: Don't

Re: [PATCH v4 02/10] drm/bridge: add common api for inno hdmi

2024-06-23 Thread Markus Elfring
… > Signed-off-by: keith Should the personal name be more unique (according to the Developer's Certificate of Origin)? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc4#n438 … > +++

Re: [PATCH] agp: add missing MODULE_DESCRIPTION() macros

2024-06-23 Thread Jeff Johnson
On 6/3/2024 9:55 AM, Jeff Johnson wrote: > make allmodconfig && make W=1 C=1 reports: > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/amd64-agp.o > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/char/agp/intel-agp.o > WARNING: modpost: missing MODULE_DESCRIPTION()

Re: [PATCH v2 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-06-23 Thread Conor Dooley
On Sun, Jun 23, 2024 at 04:48:47PM +0200, Marek Vasut wrote: > On 6/22/24 1:56 PM, Conor Dooley wrote: > > On Fri, Jun 21, 2024 at 05:53:53PM +0200, Marek Vasut wrote: > > > Document default DP port preemphasis configurable via new DT property > > > "toshiba,pre-emphasis". This is useful in case

Re: [PATCH v2 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis

2024-06-23 Thread Marek Vasut
On 6/22/24 1:56 PM, Conor Dooley wrote: On Fri, Jun 21, 2024 at 05:53:53PM +0200, Marek Vasut wrote: Document default DP port preemphasis configurable via new DT property "toshiba,pre-emphasis". This is useful in case the DP link properties are known and starting link training from preemphasis

Re: [PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 16:13, Conor Dooley wrote: > On Sun, Jun 23, 2024 at 02:00:26PM +0200, Krzysztof Kozlowski wrote: >> MMIO address space is known per each variant of Adreno GPU, so we can >> constrain the reg/reg-names entries for each variant. There is no DTS >> for A619, so that part is not

Re: [PATCH v3] drm/panel: raydium-rm692e5: transition to mipi_dsi wrapped functions

2024-06-23 Thread neil . armstrong
On 20/06/2024 21:18, Doug Anderson wrote: Hi, On Thu, Jun 20, 2024 at 11:12 AM Tejas Vipin wrote: Use functions introduced in commit 966e397e4f60 ("drm/mipi-dsi: Introduce mipi_dsi_*_write_seq_multi()") and commit f79d6d28d8fe ("drm/mipi-dsi: wrap more functions for streamline handling") for

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 02:53:17PM +0200, Krzysztof Kozlowski wrote: > On 23/06/2024 14:28, Akhil P Oommen wrote: > > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: > >> On 23/06/2024 13:06, Akhil P Oommen wrote: > >>> Add the necessary dt nodes for gpu support in X1E80100. >

Re: [PATCH 06/15] net: hbl_cn: debugfs support

2024-06-23 Thread Andrew Lunn
> > If there is no netdev, what is the point of putting it into loopback? > > How do you send packets which are to be looped back? How do you > > receive them to see if they were actually looped back? > > > > Andrew > > To run RDMA test in loopback. What is special about your RDMA? Why do

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-23 Thread Omer Shpigelman
On 6/20/24 22:14, Andrew Lunn wrote: > On Thu, Jun 20, 2024 at 06:51:35AM -0700, Jakub Kicinski wrote: >> On Thu, 20 Jun 2024 08:43:34 + Omer Shpigelman wrote: You support 400G, you really need to give the user the ability to access higher pages. >>> >>> Actually the 200G and 400G

Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

2024-06-23 Thread Andrew Lunn
> > But what about when the system is under memory pressure? You say it > > allocates memory. What happens if those allocations fail. Does > > changing the MTU take me from a working system to a dead system? It is > > good practice to not kill a working system under situations like > > memory

[PATCH v3 2/6] drm/bridge: tc358767: Use tc_pxl_pll_calc() to correct adjusted_mode clock

2024-06-23 Thread Marek Vasut
Use tc_pxl_pll_calc() to find out the exact clock frequency generated by the Pixel PLL. Use the Pixel PLL frequency as adjusted_mode clock frequency and pass it down the display pipeline to obtain exactly this frequency on input into this bridge. The precise input frequency that matches the Pixel

[PATCH v3 6/6] Revert "drm/bridge: tc358767: Set default CLRSIPO count"

2024-06-23 Thread Marek Vasut
This reverts commit 01338bb82fed40a6a234c2b36a92367c8671adf0. With clock improvements in place, this seems to be no longer necessary. Set the CLRSIPO to default setting recommended by manufacturer. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc: Daniel Vetter Cc: David Airlie Cc: Jernej

[PATCH v3 4/6] drm/bridge: tc358767: Disable MIPI_DSI_CLOCK_NON_CONTINUOUS

2024-06-23 Thread Marek Vasut
The MIPI_DSI_CLOCK_NON_CONTINUOUS causes visible artifacts in high resolution modes, disable it. Namely, in DSI->DP mode 1920x1200 24 bpp 59.95 Hz, with DSI bus at maximum 1 Gbps per lane setting, the image contains jittering empty lines. Signed-off-by: Marek Vasut --- Cc: Andrzej Hajda Cc:

[PATCH v3 3/6] drm/bridge: tc358767: Drop line_pixel_subtract

2024-06-23 Thread Marek Vasut
This line_pixel_subtract is no longer needed now that the bridge can request and obtain specific pixel clock on input to the bridge, with clock frequency that matches the Pixel PLL frequency. The line_pixel_subtract is now always 0, so drop it entirely. The line_pixel_subtract was not reliable

[PATCH v3 5/6] drm/bridge: tc358767: Set LSCLK divider for SYSCLK to 1

2024-06-23 Thread Marek Vasut
The only information in the datasheet regarding this divider is a note in SYS_PLLPARAM register documentation which states that when LSCLK is 270 MHz, LSCLK_DIV should be 1. What should LSCLK_DIV be set to when LSCLK is 162 MHz (for DP 1.62G mode) is unclear, but empirical test confirms using

[PATCH v3 1/6] drm/bridge: tc358767: Split tc_pxl_pll_en() into parameter calculation and enablement

2024-06-23 Thread Marek Vasut
Split tc_pxl_pll_en() into tc_pxl_pll_calc() which does only Pixel PLL parameter calculation and tc_pxl_pll_en() which calls tc_pxl_pll_calc() and then configures the Pixel PLL register. This is a preparatory patch for further rework, where tc_pxl_pll_calc() will also be used to find out the

Re: [PATCH 1/3] dt-bindings: display/msm/gpu: constrain clocks in top-level

2024-06-23 Thread Conor Dooley
On Sun, Jun 23, 2024 at 02:00:24PM +0200, Krzysztof Kozlowski wrote: > We expect each schema with variable number of clocks, to have the widest > constrains in top-level "properties:". This is more readable and also > makes binding stricter, if there is no "if:then:" block for given > variant. >

Re: [PATCH 2/3] dt-bindings: display/msm/gpu: define reg-names in top-level

2024-06-23 Thread Conor Dooley
On Sun, Jun 23, 2024 at 02:00:25PM +0200, Krzysztof Kozlowski wrote: > All devices should (and actually do) have same order of entries, if > possible. That's the case for reg/reg-names, so define the reg-names in > top-level to enforce that. > > Signed-off-by: Krzysztof Kozlowski Acked-by:

Re: [PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Conor Dooley
On Sun, Jun 23, 2024 at 02:00:26PM +0200, Krzysztof Kozlowski wrote: > MMIO address space is known per each variant of Adreno GPU, so we can > constrain the reg/reg-names entries for each variant. There is no DTS > for A619, so that part is not accurate but could be corrected later. > >

[PATCH AUTOSEL 6.1 10/12] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-06-23 Thread Sasha Levin
From: Tobias Jakobi [ Upstream commit f74fb5df429ebc6a614dc5aa9e44d7194d402e5a ] Similar to the other Aya Neo devices this one features again a portrait screen, here with a native resolution of 1600x2560. Signed-off-by: Tobias Jakobi Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

[PATCH AUTOSEL 6.6 14/16] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-23 Thread Sasha Levin
From: Douglas Anderson [ Upstream commit c38896ca6318c2df20bbe6c8e3f633e071fda910 ] Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't

[PATCH AUTOSEL 6.6 13/16] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-06-23 Thread Sasha Levin
From: Tobias Jakobi [ Upstream commit f74fb5df429ebc6a614dc5aa9e44d7194d402e5a ] Similar to the other Aya Neo devices this one features again a portrait screen, here with a native resolution of 1600x2560. Signed-off-by: Tobias Jakobi Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

[PATCH AUTOSEL 6.6 12/16] drm/exynos: dp: drop driver owner initialization

2024-06-23 Thread Sasha Levin
From: Krzysztof Kozlowski [ Upstream commit 1f3512cdf8299f9edaea9046d53ea324a7730bab ] Core in platform_driver_register() already sets the .owner, so driver does not need to. Whatever is set here will be anyway overwritten by main driver calling platform_driver_register(). Signed-off-by:

[PATCH AUTOSEL 6.9 16/21] drm: renesas: shmobile: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-23 Thread Sasha Levin
From: Douglas Anderson [ Upstream commit 0320ca14c6fb68ad19aa72e55a1a21c061b2946b ] Based on grepping through the source code, this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. This is important because drm_atomic_helper_shutdown() will cause

[PATCH AUTOSEL 6.9 17/21] drm/mediatek: Call drm_atomic_helper_shutdown() at shutdown time

2024-06-23 Thread Sasha Levin
From: Douglas Anderson [ Upstream commit c38896ca6318c2df20bbe6c8e3f633e071fda910 ] Based on grepping through the source code this driver appears to be missing a call to drm_atomic_helper_shutdown() at system shutdown time. Among other things, this means that if a panel is in use that it won't

[PATCH AUTOSEL 6.9 15/21] drm: panel-orientation-quirks: Add quirk for Aya Neo KUN

2024-06-23 Thread Sasha Levin
From: Tobias Jakobi [ Upstream commit f74fb5df429ebc6a614dc5aa9e44d7194d402e5a ] Similar to the other Aya Neo devices this one features again a portrait screen, here with a native resolution of 1600x2560. Signed-off-by: Tobias Jakobi Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede

[PATCH AUTOSEL 6.9 14/21] drm/exynos: dp: drop driver owner initialization

2024-06-23 Thread Sasha Levin
From: Krzysztof Kozlowski [ Upstream commit 1f3512cdf8299f9edaea9046d53ea324a7730bab ] Core in platform_driver_register() already sets the .owner, so driver does not need to. Whatever is set here will be anyway overwritten by main driver calling platform_driver_register(). Signed-off-by:

[PATCH] dt-bindings: display/msm/gmu: fix the schema being not applied

2024-06-23 Thread Krzysztof Kozlowski
dtschema v2024.4, v2024.5 and maybe earlier do not select device nodes for given binding validation if the schema contains compatible list with pattern and a const fallback. This leads to binding being a no-op - not being applied at all. Issue should be fixed in the dtschema but for now add a

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 14:28, Akhil P Oommen wrote: > On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: >> On 23/06/2024 13:06, Akhil P Oommen wrote: >>> Add the necessary dt nodes for gpu support in X1E80100. >>> >>> Signed-off-by: Akhil P Oommen >>> --- >>> + gmu:

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Akhil P Oommen
On Sun, Jun 23, 2024 at 01:17:16PM +0200, Krzysztof Kozlowski wrote: > On 23/06/2024 13:06, Akhil P Oommen wrote: > > Add the necessary dt nodes for gpu support in X1E80100. > > > > Signed-off-by: Akhil P Oommen > > --- > > + gmu: gmu@3d6a000 { > > + compatible =

[PATCH 3/3] dt-bindings: display/msm/gpu: constrain reg/reg-names per variant

2024-06-23 Thread Krzysztof Kozlowski
MMIO address space is known per each variant of Adreno GPU, so we can constrain the reg/reg-names entries for each variant. There is no DTS for A619, so that part is not accurate but could be corrected later. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/gpu.yaml

[PATCH 2/3] dt-bindings: display/msm/gpu: define reg-names in top-level

2024-06-23 Thread Krzysztof Kozlowski
All devices should (and actually do) have same order of entries, if possible. That's the case for reg/reg-names, so define the reg-names in top-level to enforce that. Signed-off-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/display/msm/gpu.yaml | 5 - 1 file changed, 4

[PATCH 1/3] dt-bindings: display/msm/gpu: constrain clocks in top-level

2024-06-23 Thread Krzysztof Kozlowski
We expect each schema with variable number of clocks, to have the widest constrains in top-level "properties:". This is more readable and also makes binding stricter, if there is no "if:then:" block for given variant. Signed-off-by: Krzysztof Kozlowski ---

Re: [PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Add the necessary dt nodes for gpu support in X1E80100. > > Signed-off-by: Akhil P Oommen > --- > + gmu: gmu@3d6a000 { > + compatible = "qcom,adreno-gmu-x185.1", > "qcom,adreno-gmu"; > + reg = <0x0

Re: [PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > Document Adreno X185 GMU in the dt-binding specification. > > Signed-off-by: Akhil P Oommen > --- > > Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-23 Thread Krzysztof Kozlowski
On 23/06/2024 13:06, Akhil P Oommen wrote: > This series adds support for the Adreno X1-85 GPU found in Qualcomm's > compute series chipset, Snapdragon X1 Elite (x1e80100). In this new > naming scheme for Adreno GPU, 'X' stands for compute series, '1' denotes > 1st generation and '8' & '5' denotes

[PATCH v1 3/3] arm64: dts: qcom: x1e80100: Add gpu support

2024-06-23 Thread Akhil P Oommen
Add the necessary dt nodes for gpu support in X1E80100. Signed-off-by: Akhil P Oommen --- arch/arm64/boot/dts/qcom/x1e80100.dtsi | 195 + 1 file changed, 195 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi

[PATCH v1 1/3] dt-bindings: display/msm/gmu: Add Adreno X185 GMU

2024-06-23 Thread Akhil P Oommen
Document Adreno X185 GMU in the dt-binding specification. Signed-off-by: Akhil P Oommen --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml

[PATCH v1 2/3] drm/msm/adreno: Add support for X185 GPU

2024-06-23 Thread Akhil P Oommen
Add support in drm/msm driver for the Adreno X185 gpu found in Snapdragon X1 Elite chipset. Signed-off-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 19 +++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 ++ drivers/gpu/drm/msm/adreno/adreno_device.c

[PATCH v1 0/3] Support for Adreno X1-85 GPU

2024-06-23 Thread Akhil P Oommen
This series adds support for the Adreno X1-85 GPU found in Qualcomm's compute series chipset, Snapdragon X1 Elite (x1e80100). In this new naming scheme for Adreno GPU, 'X' stands for compute series, '1' denotes 1st generation and '8' & '5' denotes the tier and the SKU which it belongs. X1-85 has

Re: [PATCH 2/4] drm/msm/mdp5: Add MDP5 configuration for MSM8937

2024-06-23 Thread Barnabás Czémán
On Sun, Jun 23, 2024 at 7:59 AM Dmitry Baryshkov wrote: > > On Sun, Jun 23, 2024 at 01:25:52AM GMT, Barnabás Czémán wrote: > > From: Daniil Titov > > > > Add the mdp5_cfg_hw entry for MDP5 version v1.14 found on msm8937. > > > > Signed-off-by: Daniil Titov > > Signed-off-by: Barnabás Czémán >

Re: [PATCH] drm/amdgpu: fix a possible null pointer dereference

2024-06-23 Thread Joshua Ashton
Are you planning on submitting a bogus CVE for this patch too? - Joshie ✨ On June 22, 2024 9:22:19 AM GMT+01:00, Ma Ke wrote: >In amdgpu_connector_add_common_modes(), the return value of drm_cvt_mode() >is assigned to mode, which will lead to a NULL pointer dereference on >failure of

[PATCH v2 2/3] drm: panel-backlight-quirks: Add Framework 13 matte panel

2024-06-23 Thread Thomas Weißschuh
The value of "min_input_signal" returned from ATIF on a Framework AMD 13 is "12". This leads to a fairly bright minimum display backlight. Add a quirk to override that the minimum backlight PWM to "0" which leads to a much lower minimum brightness, which is still visible. Tested on a Framework

  1   2   3   4   5   6   7   8   9   10   >