Re: [PATCH drm/hisilicon v2 1/4] drm/hisilicon: Assgin local variable to drm_device

在 2020/12/1 20:36, Thomas Zimmermann 写道: Hi Am 01.12.20 um 13:26 schrieb tiantao (H): 在 2020/12/1 20:17, Thomas Zimmermann 写道: Hi Am 01.12.20 um 12:55 schrieb Tian Tao: Assign local variable to struct drm_device *dev because they are used multiple times within a function. Signed-off

Re: [PATCH drm/hisilicon v2 1/4] drm/hisilicon: Assgin local variable to drm_device

在 2020/12/1 20:17, Thomas Zimmermann 写道: Hi Am 01.12.20 um 12:55 schrieb Tian Tao: Assign local variable to struct drm_device *dev because they are used multiple times within a function. Signed-off-by: Tian Tao ---   drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c   |  2 +-  

Re: [REGRESSION] omapdrm/N900 display broken

Hi Ivaylo, > Am 27.11.2020 um 19:44 schrieb Ivaylo Dimitrov : > > Hi, > > On 27.11.20 г. 19:30 ч., Tomi Valkeinen wrote: >> On 27/11/2020 17:37, Ivaylo Dimitrov wrote: >>> With 5.9.11 and the patch on top, n900 boots fine, albeit display remains >>> blank, could be related to >>> brightness,

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

Hi Tomi, I hope you had a good weekend. And I have added back the CC: list because I think we have progress after our internal discussion and only one issue remaining. > Am 13.11.2020 um 15:49 schrieb Tomi Valkeinen : > > On 13/11/2020 16:41, H. Nikolaus Schaller wrote: >> Hi T

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

> Am 11.11.2020 um 11:11 schrieb Tomi Valkeinen : > > On 11/11/2020 09:48, H. Nikolaus Schaller wrote: >> >>> Am 11.11.2020 um 07:40 schrieb Tomi Valkeinen : >>> >>> On 10/11/2020 23:04, H. Nikolaus Schaller wrote: >>>> >>>>&g

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

> Am 10.11.2020 um 14:49 schrieb H. Nikolaus Schaller : > > Hi Tomi, > >> Am 09.11.2020 um 12:33 schrieb Tomi Valkeinen : >> >> On 09/11/2020 13:09, H. Nikolaus Schaller wrote: >> >>>>> I see. >>>>> Anyways there is missing so

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

Hi Tomi, > Am 09.11.2020 um 12:33 schrieb Tomi Valkeinen : > > On 09/11/2020 13:09, H. Nikolaus Schaller wrote: > >>>> I see. >>>> Anyways there is missing some simple thing which makes the driver not >>>> prepared/enabled. >>>&g

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

> Am 11.11.2020 um 07:40 schrieb Tomi Valkeinen : > > On 10/11/2020 23:04, H. Nikolaus Schaller wrote: >> >>> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen : >>> >>> On 10/11/2020 18:49, H. Nikolaus Schaller wrote: >>> >>> I gue

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

> Am 10.11.2020 um 17:52 schrieb Tomi Valkeinen : > > On 10/11/2020 18:49, H. Nikolaus Schaller wrote: > > I guess you have the same issue. It goes to dsi_bridge_mode_valid, then > __dsi_calc_config, and stays > there finding good clocks. Yes, I could trace it down to ex

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

> Am 09.11.2020 um 09:04 schrieb Tomi Valkeinen : > > On 07/11/2020 14:19, H. Nikolaus Schaller wrote: > >> I have set up based on our complete letux-5.10-rc2 tree and maybe using our >> private config makes >> the difference. Anyways, the driver is now

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

> Am 09.11.2020 um 11:34 schrieb Tomi Valkeinen : > > On 09/11/2020 12:31, H. Nikolaus Schaller wrote: >> >>> Am 09.11.2020 um 11:22 schrieb Tomi Valkeinen : >>> >>> On 09/11/2020 11:30, H. Nikolaus Schaller wrote: >>>> >>>>&g

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

> Am 09.11.2020 um 11:22 schrieb Tomi Valkeinen : > > On 09/11/2020 11:30, H. Nikolaus Schaller wrote: >> >>> Am 09.11.2020 um 09:04 schrieb Tomi Valkeinen : >>> >>> On 07/11/2020 14:19, H. Nikolaus Schaller wrote: >>> >>>> I

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

d no calls to prepare/unprepare etc. but now I can start to debug on omap5. And hopefully we are close to push the panel driver for review. And in a second step some device tree for the Pyra. The new tree is here: https://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/work-pyra-panel BR and thanks, Nikolaus ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

> Am 05.11.2020 um 19:28 schrieb Tomi Valkeinen : > > On 05/11/2020 20:14, H. Nikolaus Schaller wrote: >> >>> Am 05.11.2020 um 18:36 schrieb Tomi Valkeinen : >>> >>> Hi, >>> >>> On 05/11/2020 19:15, H. Nikolaus Schaller wrote: &

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

> Am 05.11.2020 um 18:36 schrieb Tomi Valkeinen : > > Hi, > > On 05/11/2020 19:15, H. Nikolaus Schaller wrote: > >> Next, I migrated my long waiting mipi_dsi/drm_panel driver conversion for >> the panel of the Pyra handheld (omap 5 based) to compile on 5.10-rc2

Re: [PATCH v3 00/56] Convert DSI code to use drm_mipi_dsi and drm_panel

Hi Tomi, > Am 05.11.2020 um 13:02 schrieb Tomi Valkeinen : > > Hi, > > This is third version of the series sent by Sebastian in February: > > https://www.spinics.net/lists/linux-omap/msg153465.html > > I took the patches from his git tree, and rebased on 5.10-rc2. There > were some conflicts

Re: [PATCH v2] drm: Add the new api to install irq

在 2020/11/3 15:56, Thomas Zimmermann 写道: Hi Thanks, the code looks good already. There just are a few nits below. Thanks for the help with the review code. Add the new api devm_drm_irq_install and himbc use the new interface as one patch or two? Am 03.11.20 um 03:10 schrieb Tian Tao:

Re: [PATCH] drm/irq: Add irq as false detection

在 2020/11/2 20:09, Thomas Zimmermann 写道: Hi Am 02.11.20 um 12:19 schrieb Tian Tao: Add the detection of false for irq, so that the EINVAL is not returned when dev->irq_enabled is false. Signed-off-by: Tian Tao --- drivers/gpu/drm/drm_irq.c | 3 +++ 1 file changed, 3 insertions(+) diff

Re: [PATCH] drm/hisilicon: Remove redundant null check

在 2020/11/2 17:03, Thomas Zimmermann 写道: Hi Am 02.11.20 um 09:46 schrieb tiantao (H): 在 2020/11/2 16:32, Thomas Zimmermann 写道: Hi Am 30.10.20 um 10:27 schrieb Tian Tao: drm_irq_uninstall can handle the case where dev->irq_enable is false, so Remove redundant null check. Signed-

Re: [PATCH] drm/hisilicon: Remove redundant null check

在 2020/11/2 16:32, Thomas Zimmermann 写道: Hi Am 30.10.20 um 10:27 schrieb Tian Tao: drm_irq_uninstall can handle the case where dev->irq_enable is false, so Remove redundant null check. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 +++--- 1 file

Re: [PATCH] drm/hisilicon: Delete the unused macro

在 2020/9/29 15:24, Thomas Zimmermann 写道: Am 29.09.20 um 02:45 schrieb Tian Tao: The macro PADDING is no longer used. Delete it. Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann Thanks a lot for the timely help with the review code! ---

Re: [PATCH] drm/hisilicon: Deleted the drm_device declaration

在 2020/9/25 15:26, Thomas Zimmermann 写道: Hi Am 25.09.20 um 09:02 schrieb Thomas Zimmermann: Hi, just a few nits. Am 25.09.20 um 08:49 schrieb Tian Tao: drm_framebuffer.h contains drm/drm_device.h and struct drm_device is contains -> includes already declared in this file, so there is

Re: [PATCH] drm/vc4: Deleted the drm_device declaration

Hi : I alwaygs used scripts/get_maintainers.pl to get the recipient list.I don't know why miss maintainers for a given piece of code. tiantao@ubuntu:~$ git send-email -to e...@anholt.net -to airl...@linux.ie -to dan...@ffwll.ch -to sumit.sem...@linaro.org -to christian.koe...@amd.com -to

Re: [PATCH] drm/vc4: Remove unused variables

Hi Thomas: 在 2020/9/11 15:47, Thomas Zimmermann 写道: Hi Am 09.09.20 um 09:33 schrieb Tian Tao: Fixes the following W=1 kernel build warning(s): vc4_plane.c: In function ‘vc4_plane_init’: vc4_plane.c:1340:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Signed-off-by:

Re: drm/bridge: Synopsys DW-HDMI bridge driver for the Ingenic JZ4780 (was Re: Specialising the Synopsys DW-HDMI bridge driver for the Ingenic JZ4780)

Hi Ezequiel, > Am 27.08.2020 um 09:21 schrieb H. Nikolaus Schaller : > > Hi Ezequiel, > >> Am 24.08.2020 um 19:38 schrieb Ezequiel Garcia >> : >> >> On Mon, 24 Aug 2020 at 13:05, H. Nikolaus Schaller >> wrote: >>> >>> Hi Ezequie

Re: drm/bridge: Synopsys DW-HDMI bridge driver for the Ingenic JZ4780 (was Re: Specialising the Synopsys DW-HDMI bridge driver for the Ingenic JZ4780)

included only for making my Ethernet interface work for testing): >>> >>> https://git.goldelico.com/?p=letux-kernel.git;a=shortlog;h=refs/heads/letux/jz4780-hdmi-v5 >>> >>> Please take it, do the required squashes and rebasing and post them for >>> d

[PATCH] udmabuf: Add missing compact_ioctl

From: "Kristian H. Kristensen" Make sure we can use this on mixed systems. Signed-off-by: Kristian H. Kristensen --- drivers/dma-buf/udmabuf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index 9635897458a0..6f4ff6ede

Re: drm/bridge: Synopsys DW-HDMI bridge driver for the Ingenic JZ4780 (was Re: Specialising the Synopsys DW-HDMI bridge driver for the Ingenic JZ4780)

Hi Ezequiel, > Am 24.08.2020 um 19:38 schrieb Ezequiel Garcia > : > > On Mon, 24 Aug 2020 at 13:05, H. Nikolaus Schaller wrote: >> >> Hi Ezequiel, > > The fix is just re-organizing the code a bit. Just pushed a possible > fix for that (following the IPU han

Re: drm/bridge: Synopsys DW-HDMI bridge driver for the Ingenic JZ4780 (was Re: Specialising the Synopsys DW-HDMI bridge driver for the Ingenic JZ4780)

Hi Ezequiel, > Am 24.08.2020 um 15:46 schrieb Ezequiel Garcia > : > > On Fri, 21 Aug 2020 at 19:24, Paul Cercueil wrote: >> >> >> >> Le sam. 22 août 2020 à 0:11, Paul Boddie a >> écrit : >> >> If you send clean patches, there's no reason for me not to merge them. >> > > I'd really like

Re: drm/bridge: Synopsys DW-HDMI bridge driver for the Ingenic JZ4780 (was Re: Specialising the Synopsys DW-HDMI bridge driver for the Ingenic JZ4780)

Hi Ezequiel, > Am 20.08.2020 um 00:26 schrieb Ezequiel Garcia > : > > On Wed, 19 Aug 2020 at 15:50, H. Nikolaus Schaller wrote: >> >> Maybe, can you share your rebased tree to clearly identify the >> subtle differences? Maybe I have broken something by the reba

Re: drm/bridge: Synopsys DW-HDMI bridge driver for the Ingenic JZ4780 (was Re: Specialising the Synopsys DW-HDMI bridge driver for the Ingenic JZ4780)

Hi Ezequiel, > Am 19.08.2020 um 12:21 schrieb Ezequiel Garcia > : > > Hello, > > First of all, I'd like to thank everyone for the great work > on ingenic-drm. The driver is in very good shape > and a pleasure to work with. > > Yesterday, I checked out branch "paulb-jz4780-ci20-hdmi-5.8-rc5",

Re: [PATCH drm/hisilicon v2 0/3] hibmc clean up and code refactoring

在 2020/8/12 15:04, Thomas Zimmermann 写道: Hi Am 03.08.20 um 02:38 schrieb Tian Tao: patch #1 and #3 is clean up, patch #2 is for code refactoring Sorry for all my reviews taking so long. Please merge patch #3 into patch #2 and then the series is thanks,I will send v3 to fix this.

答复: [PATCH v3] drm/hisilicon: Fixed the warning: Assignment of 0/1 to bool variable

Hi Thomas: Thank you very much . Best -邮件原件- 发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de] 发送时间: 2020年7月29日 16:35 收件人: tiantao (H) ; airl...@linux.ie; dan...@ffwll.ch; kra...@redhat.com; alexander.deuc...@amd.com; t...@linutronix.de; dri-devel@lists.freedesktop.org

答复: [PATCH v2] drm/hisilicon: Use drmm_kzalloc() instead of devm_kzalloc()

Hi: I am sorry for misunderstood you suggests. I will send v3 to fixed this. Best -邮件原件- 发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de] 发送时间: 2020年7月2日 15:20 收件人: tiantao (H) ; Chenfeng (puck) ; airl...@linux.ie; dan...@ffwll.ch; kra...@redhat.com; alexander.deuc...@amd.com; t

答复: [PATCH] drm/hisilicon: Use drmm_kzalloc() instead of devm_kzalloc()

Hi： Thanks for the help with the review code. I will send v2 to fixed this. Best -邮件原件- 发件人: Thomas Zimmermann [mailto:tzimmerm...@suse.de] 发送时间: 2020年7月2日 14:43 收件人: tiantao (H) ; Chenfeng (puck) ; airl...@linux.ie; dan...@ffwll.ch; kra...@redhat.com; alexander.deuc

Re: [PATCHv2 00/56] drm/omap: Convert DSI code to use drm_mipi_dsi and drm_panel

Hi Sebastian, > Am 25.02.2020 um 00:20 schrieb Sebastian Reichel > : > > This updates the existing omapdrm DSI code, so that it uses > common drm_mipi_dsi API and drm_panel. > > The patchset has been tested with Droid 4 using Linux console, X.org and > Weston. The patchset is based on Laurent

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

> -Original Message- > From: Ashwin H > Sent: Thursday, May 28, 2020 1:01 PM > To: Greg KH > Cc: x...@kernel.org; dri-devel@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; linux-ker...@vger.kernel.org; sta...@kernel.org; > Srivatsa Bhat ; sriva...@

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

> -Original Message- > From: Greg KH > Sent: Wednesday, May 27, 2020 9:02 PM > To: Ashwin H > Cc: x...@kernel.org; dri-devel@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; linux-ker...@vger.kernel.org; sta...@kernel.org; > Srivatsa Bhat ; sriva...@

Re: [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Tony, > Am 03.05.2020 um 17:01 schrieb Tony Lindgren : > > * Paul Cercueil [200503 14:19]: >> You have a new SoC with a SGX, and you only need to enable one clock to get >> it to work. So you create a devicetree node which receives only one clock. >> >> Turns out, that the bootloader was

Re: [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

> Am 05.05.2020 um 17:53 schrieb Rob Herring : > > On Fri, Apr 24, 2020 at 10:34:04PM +0200, H. Nikolaus Schaller wrote: >> The Imagination PVR/SGX GPU is part of several SoC from >> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo, >&g

Re: [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Paul & Paul, > Am 03.05.2020 um 18:41 schrieb H. Nikolaus Schaller : > > Hi Paul and Paul, > >> Am 03.05.2020 um 16:18 schrieb Paul Cercueil : >> >> >> >> Le dim. 3 mai 2020 à 15:31, H. Nikolaus Schaller a >> écrit : >>&g

RE: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

> Ok, but what does that mean for us? > > You need to say why you are sending a patch, otherwise we will guess wrong. In drivers/gpu/drm/i915/i915_gem_execbuffer.c, ioctl functions does user_access_begin() without doing access_ok(Checks if a user space pointer is valid) first. A local

Re: [PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

This patch fixes CVE-2018-20669 in 4.19 tree. On 13/05/20, 11:36 AM, "Greg KH" wrote: On Wed, May 13, 2020 at 07:19:21AM +0530, ashwin-h wrote: > From: Linus Torvalds > > commit 594cc251fdd0d231d342d88b2fdff4bc42fb0690 upstream. > >

[PATCH v4.19.x] make 'user_access_begin()' do 'access_ok()'

. We have way too long a history of people trying to avoid them. Signed-off-by: Linus Torvalds Signed-off-by: Ashwin H --- arch/x86/include/asm/uaccess.h | 11 ++- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 15 +-- include/linux/uaccess.h

[PATCH] drm: ingenic-drm: add MODULE_DEVICE_TABLE

so that the driver can load by matching the device tree if compiled as module. Cc: sta...@vger.kernel.org # v5.3+ Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the Ingenic JZ47xx SoCs") Signed-off-by: H. Nikolaus Schaller --- drivers/gpu/drm/ingenic/ingenic-drm.c | 1 + 1 file

Re: [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Paul, > Am 03.05.2020 um 14:52 schrieb Paul Cercueil : > >>> It's possible to forbid the presence of the 'clocks' property on some >>> implementations, and require it on others. >> To be precise we have to specify the exact number of clocks (between 0 and >> 4) for every architecture. >>

Re: [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Paul and Paul, > Am 03.05.2020 um 16:18 schrieb Paul Cercueil : > > > > Le dim. 3 mai 2020 à 15:31, H. Nikolaus Schaller a écrit > : >> Hi Paul, >>> Am 03.05.2020 um 14:52 schrieb Paul Cercueil : >>>>> It's possible to forb

Re: [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Paul, > Am 26.04.2020 um 15:11 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le ven. 24 avril 2020 à 22:34, H. Nikolaus Schaller a > écrit : >> The Imagination PVR/SGX GPU is part of several SoC from >> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, I

Re: [PATCH v7 06/12] ARM: DTS: omap4: add sgx gpu child node

Hi Paul, > Am 26.04.2020 um 14:50 schrieb Paul Cercueil : > > Hi Nikolaus, > > Le ven. 24 avril 2020 à 22:34, H. Nikolaus Schaller a > écrit : >> Add SGX GPU node with interrupt. Tested on PandaBoard ES. >> Since omap4420/30/60 and omap4470 come with dif

Re: [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Philipp, > Am 26.04.2020 um 21:36 schrieb Philipp Rossak : > > Hi Nikolaus, > > On 24.04.20 22:34, H. Nikolaus Schaller wrote: >> The Imagination PVR/SGX GPU is part of several SoC from >> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo,

[PATCH v7 03/12] ARM: DTS: am3517: add sgx gpu child node

Add SGX GPU node with interrupt. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/am3517.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi index e0b5a00e2078..3fce56a646d1 100644 --- a/arch

[PATCH v7 07/12] ARM: DTS: omap5: add sgx gpu child node

Add SGX GPU node with interrupt. Tested on Pyra-Handheld. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap5.dtsi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index 2ac7f021c284

[PATCH v7 12/12] MIPS: DTS: jz4780: add sgx gpu node

and add interrupt and clocks. Tested to build for CI20 board and load a driver. Setup can not yet be fully tested since there is no working HDMI driver for jz4780. Suggested-by: Paul Boddie Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 11 +++ 1 file

[PATCH v7 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

e kernel driver or the (non-free) user-space libraries and binaries. The driver works on jz4780 but user-space could not yet be tested. [1]: https://github.com/openpvrsgx-devgroup H. Nikolaus Schaller (8): dt-bindings: add img,pvrsgx.yaml for Imagination GPUs ARM: DTS: am33xx: add sgx gpu child nod

[PATCH v7 05/12] ARM: DTS: omap36xx: add sgx gpu child node

Add SGX GPU node with interrupt. Tested on GTA04, BeagleBoard XM. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap36xx.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi index

[PATCH v7 09/12] ARM: dts: sun6i: a31: add sgx gpu child node

available. The currently used binding that is used during development is more complete and was already verifyed by loading the kernelmodule successful. Signed-off-by: Philipp Rossak Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/sun6i-a31.dtsi | 11 +++ 1 file changed, 11 insertions

[PATCH v7 10/12] ARM: dts: sun6i: a31s: add sgx gpu child node

available. The currently used binding that is used during development is more complete and was already verifyed by loading the kernelmodule successful. Signed-off-by: Philipp Rossak Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/sun6i-a31s.dtsi | 10 ++ 1 file changed, 10 insertions

Re: [PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

> Am 24.04.2020 um 22:34 schrieb H. Nikolaus Schaller : > > The Imagination PVR/SGX GPU is part of several SoC from > multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo, > Allwinner A83 and others. > > With this binding, we describe how the SGX processor is &g

[PATCH v7 11/12] ARM: dts: sun8i: a83t: add sgx gpu child node

available. The currently used binding that is used during development is more complete and was already verifyed by loading the kernelmodule successful. Signed-off-by: Philipp Rossak Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +++ 1 file changed, 11 insertions

[PATCH v7 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Signed-off-by: H. Nikolaus Schaller --- .../devicetree/bindings/gpu/img,pvrsgx.yaml | 150 ++ 1 file changed, 150 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpu/img,pvrsgx.yaml diff --git a/Documentation/devicetree/bindings/gpu/img,pvrsgx.yaml b

[PATCH v7 08/12] arm: dts: s5pv210: Add node for SGX 540

From: Jonathan Bakker All s5pv210 devices have a PowerVR SGX 540 (revision 120) attached. There is no external regulator for it so it can be enabled by default. Signed-off-by: Jonathan Bakker Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/s5pv210.dtsi | 13 + 1 file

[PATCH v7 06/12] ARM: DTS: omap4: add sgx gpu child node

Add SGX GPU node with interrupt. Tested on PandaBoard ES. Since omap4420/30/60 and omap4470 come with different SGX variants we need to introduce a new omap4470.dtsi. If an omap4470 board does not want to use SGX it is no problem to still include omap4460.dtsi. Signed-off-by: H. Nikolaus

[PATCH v7 02/12] ARM: DTS: am33xx: add sgx gpu child node

Add SGX GPU node with interrupt. Tested on BeagleBone Black. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/am33xx.dtsi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index a35f5052d76f

[PATCH v7 04/12] ARM: DTS: omap34xx: add sgx gpu child node

Add SGX GPU node with interrupt. Tested on OpenPandora 600 MHz. According to omap3530 TRM the SGX register block is 64kB. See: 13.4 SGX Register Mapping, Table 13-2 Reported-by: Andrew F. Davis # register size Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap34xx.dtsi | 11

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

Hi, > Am 23.04.2020 um 22:36 schrieb Maxime Ripard : >> My goal is to keep the bindings as minimalistic as possible. And reset >> lines and power domains are (at least for those we have in the works) >> not needed to make working systems. >> >> Therefore, for clocks I also would start with a

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

Hi Neil, > Am 23.04.2020 um 17:00 schrieb Neil Armstrong : >> One thing we can learn is that "core" seems to be a de facto standard >> for the core clock-name. An alternative "gpu" is used by nvidia,gk20a.txt. > > Usually IPs needs a few clocks: > - pclk or apb or reg: the clock clocking the

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

Hi Maxime, > Am 22.04.2020 um 17:13 schrieb Maxime Ripard : > > On Wed, Apr 22, 2020 at 09:10:57AM +0200, H. Nikolaus Schaller wrote: >>> Am 22.04.2020 um 08:58 schrieb Maxime Ripard : >>>> >>>> It also allows to handle different number of cloc

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

Hi Maxime, > Am 22.04.2020 um 08:58 schrieb Maxime Ripard : > > On Tue, Apr 21, 2020 at 07:29:32PM +0200, H. Nikolaus Schaller wrote: >> >>> Am 21.04.2020 um 16:15 schrieb Tony Lindgren : >>> >>> * Maxime Ripard [200421 11:22]: >>>> On

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

> Am 21.04.2020 um 16:15 schrieb Tony Lindgren : > > * Maxime Ripard [200421 11:22]: >> On Tue, Apr 21, 2020 at 11:57:33AM +0200, Philipp Rossak wrote: >>> I had a look on genpd and I'm not really sure if that fits. >>> >>> It is basically some bit that verify that the clocks should be

Re: [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!

Hi Laurent, > Am 17.04.2020 um 14:58 schrieb Laurent Pinchart > : > > Hello, > > On Fri, Apr 17, 2020 at 02:44:22PM +0200, Maxime Ripard wrote: >> On Fri, Apr 17, 2020 at 02:18:11PM +0200, H. Nikolaus Schaller wrote: >>> Hi Maxime, >>> I have sta

[drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional!

Hi Maxime, I have started to test v5.7-rc1 and can't fully boot the GTA04 device any more. What I see in the log is: [ 28.567840] [drm:simple_bridge_attach [simple_bridge]] *ERROR* Fix bridge driver to make connector optional! [ 28.567871] omapdrm omapdrm.0: unable to attach bridge

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Maxime, > Am 17.04.2020 um 12:25 schrieb Maxime Ripard : > > Hi, > > On Wed, Apr 15, 2020 at 06:42:18PM +0200, H. Nikolaus Schaller wrote: >>> Am 15.04.2020 um 18:21 schrieb Maxime Ripard : >>> >>> On Wed, Apr 15, 2020 at 05:09:45PM +0200,

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Rob, > Am 16.04.2020 um 22:41 schrieb Rob Herring : > > On Wed, 15 Apr 2020 10:35:08 +0200, "H. Nikolaus Schaller" wrote: >> The Imagination PVR/SGX GPU is part of several SoC from >> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Pouls

Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

Hi Jonathan, > Am 15.04.2020 um 20:17 schrieb Jonathan Bakker : > > Hi Nikolaus, > > On 2020-04-15 5:50 a.m., H. Nikolaus Schaller wrote: >> >>> Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : >>> >>> On Wed, 15 Apr 2020 at 10:36, H

Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

> Am 15.04.2020 um 13:49 schrieb Krzysztof Kozlowski : > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: >> >> From: Jonathan Bakker >> >> to add support for SGX540 GPU. > > Do not continue the subject in commit msg like it is one sente

[PATCH v6 06/12] ARM: DTS: omap4: add sgx gpu child node

and add interrupt. Since omap4420/30/60 and omap4470 come with different SGX variants we need to introduce a new omap4470.dtsi. If an omap4470 board does not want to use SGX it is no problem to still include omap4460.dtsi. Tested-by: H. Nikolaus Schaller # PandaBoard ES Signed-off-by: H

[PATCH v6 10/12] ARM: dts: sun6i: a31s: add sgx gpu child node

available. The currently used binding that is used during development is more complete and was already verifyed by loading the kernelmodule successful. Signed-off-by: Philipp Rossak Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/sun6i-a31s.dtsi | 10 ++ 1 file changed, 10 insertions

[PATCH v6 02/12] ARM: DTS: am33xx: add sgx gpu child node

and add interrupt. Tested-by: H. Nikolaus Schaller # BeagleBone Black Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/am33xx.dtsi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index

[PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

tially work on OMAP3530 and PandaBoard ES but that is likely a problem in the kernel driver or the (non-free) user-space libraries and binaries. Wotk for JZ4780 (CI20 board) is in progress and there is potential to extend this work to e.g. BananaPi-M3 (A83) and some Intel Poulsbo and CedarView devices.

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

> Am 15.04.2020 um 15:02 schrieb Maxime Ripard : > > On Wed, Apr 15, 2020 at 02:41:52PM +0200, H. Nikolaus Schaller wrote: >>>> The kernel modules built from this project have successfully >>>> demonstrated to work with the DTS definitions from this patch se

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Maxime, > Am 15.04.2020 um 16:21 schrieb Maxime Ripard : > >> >> Well we could add clocks and resets as optional but that would >> allow to wrongly define omap. >> >> Or delegate them to a parent "simple-pm-bus" node. >> >> I have to study that material more to understand what you seem >>

[PATCH v6 12/12] MIPS: DTS: jz4780: add sgx gpu node

and add interrupt and clocks. Tested to build for CI20 board and load a driver. Setup can not yet be fully tested since there is no working HDMI driver for jz4780. Suggested-by: Paul Boddie Tested-by: H. Nikolaus Schaller # CI20. Signed-off-by: H. Nikolaus Schaller --- arch/mips/boot/dts

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

Hi Maxime, > Am 15.04.2020 um 12:10 schrieb Maxime Ripard : > > Hi, > > On Wed, Apr 15, 2020 at 10:35:07AM +0200, H. Nikolaus Schaller wrote: >> * rebased to v5.7-rc1 >> * added DTS for for a31, a31s, a83t - by Philipp Rossak >> * added DTS for "samsung,s5

Re: [PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node

> Am 15.04.2020 um 15:47 schrieb Krzysztof Kozlowski : > > On Wed, Apr 15, 2020 at 01:46:06PM +0200, H. Nikolaus Schaller wrote: >> Hi Krzysztof, >> >>> Am 15.04.2020 um 13:38 schrieb Krzysztof Kozlowski : >>> >>> On Wed, 15 Apr

[PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

From: Jonathan Bakker to add support for SGX540 GPU. Signed-off-by: Jonathan Bakker Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/s5pv210.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/s5pv210.dtsi b/arch/arm/boot/dts/s5pv210.dtsi

Re: [PATCH v6 08/12] arm: dts: s5pv210: Add G3D node

Hi Sergei and Jonathan, > Am 15.04.2020 um 11:15 schrieb Sergei Shtylyov > : > > Hello! > > On 15.04.2020 11:35, H. Nikolaus Schaller wrote: > >> From: Jonathan Bakker >> to add support for SGX540 GPU. >> Signed-off-by: Jonathan Bakker >> Signed-

Re: [PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node

Hi Krzysztof, > Am 15.04.2020 um 13:38 schrieb Krzysztof Kozlowski : > > On Wed, 15 Apr 2020 at 10:36, H. Nikolaus Schaller wrote: >> >> and add interrupt. >> >> Tested-by: H. Nikolaus Schaller # Pyra-Handheld. > > Don't add your own Tested-b

[PATCH v6 05/12] ARM: DTS: omap36xx: add sgx gpu child node

and add interrupt. Tested-by: H. Nikolaus Schaller # GTA04, BeagleBoard XM Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap36xx.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi

[PATCH v6 09/12] ARM: dts: sun6i: a31: add sgx gpu child node

available. The currently used binding that is used during development is more complete and was already verifyed by loading the kernelmodule successful. Signed-off-by: Philipp Rossak Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/sun6i-a31.dtsi | 11 +++ 1 file changed, 11 insertions

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

> Am 15.04.2020 um 12:12 schrieb Maxime Ripard : > > Hi, > > On Wed, Apr 15, 2020 at 10:35:08AM +0200, H. Nikolaus Schaller wrote: >> The Imagination PVR/SGX GPU is part of several SoC from >> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo,

[PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

management is handled by a parent node or elsewhere (e.g. code in the driver). Tested by make dt_binding_check dtbs_check Signed-off-by: H. Nikolaus Schaller --- .../devicetree/bindings/gpu/img,pvrsgx.yaml | 122 ++ 1 file changed, 122 insertions(+) create mode 100644 Documentation

[PATCH v6 11/12] ARM: dts: sun8i: a83t: add sgx gpu child node

available. The currently used binding that is used during development is more complete and was already verifyed by loading the kernelmodule successful. Signed-off-by: Philipp Rossak Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/sun8i-a83t.dtsi | 11 +++ 1 file changed, 11 insertions

[PATCH v6 07/12] ARM: DTS: omap5: add sgx gpu child node

and add interrupt. Tested-by: H. Nikolaus Schaller # Pyra-Handheld. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/omap5.dtsi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi index

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Neil, > Am 15.04.2020 um 14:54 schrieb Neil Armstrong : > > Hi, > > On 15/04/2020 14:43, H. Nikolaus Schaller wrote: >> >>> Am 15.04.2020 um 12:12 schrieb Maxime Ripard : >>> >>> Hi, >>> >>> On Wed, Apr 15, 2020 at 10:35:08

[PATCH v6 03/12] ARM: DTS: am3517: add sgx gpu child node

and add interrupt. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts/am3517.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/am3517.dtsi b/arch/arm/boot/dts/am3517.dtsi index e0b5a00e2078..3fce56a646d1 100644 --- a/arch/arm/boot/dts

[PATCH v6 04/12] ARM: DTS: omap34xx: add sgx gpu child node

and add interrupt. According to omap3530 TRM the SGX register block is 64kB. See: 13.4 SGX Register Mapping, Table 13-2 Reported-by: Andrew F. Davis # register size Tested-by: H. Nikolaus Schaller # OpenPandora 600 MHz. Signed-off-by: H. Nikolaus Schaller --- arch/arm/boot/dts

Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

Hi Maxime, > Am 15.04.2020 um 18:21 schrieb Maxime Ripard : > > On Wed, Apr 15, 2020 at 05:09:45PM +0200, H. Nikolaus Schaller wrote: >> Hi Maxime, >> >> Hm. Yes. We know that there likely are clocks and maybe reset >> but for some SoC this seems to be u

Re: DRM interaction problems on Ingenic CI20 / jz4780 with dw-hdmi and ingenic-drm

> Am 13.04.2020 um 13:25 schrieb Paul Cercueil : > > Hi Nikolaus, > > > Le sam. 11 avril 2020 à 16:14, H. Nikolaus Schaller a > écrit : >> Hi, >> we (Paul Boddie and me) are working to get HDMI functional on the >> Ingenic CI20 board with jz4780 SoC w

Re: [PATCH] drm/hisilicon: Code refactoring for hibmc_drv_vdac

Thank you, your suggestion is accepted and I will issue v2 在 2020/4/11 11:43, Joe Perches 写道: On Sat, 2020-04-11 at 10:49 +0800, Tian Tao wrote: code refactoring for hibmc_drv_vdac.c, no actual function changes. Seems sensible. diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c

Re: [PATCH v5 1/8] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs

> Am 29.03.2020 um 19:38 schrieb H. Nikolaus Schaller : > > The Imagination PVR/SGX GPU is part of several SoC from > multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo, > Allwinner A83 and others. > > With this binding, we describe how the SGX processor is &g

<    1   2   3   4   5   6   7   8   >