Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

Hi, On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote: > The CBUS also has the ADS7846 touchscreen attached. Not sure what this comment means. CBUS is for Retu/Tahvo, and touchscreen is SPI. When tested w/gpio-descriptors-omap branch, the touchscreen probe fails: [2.378540] SPI

Re: [PATCH v4 2/4] ARM/mmc: Convert old mmci-omap to GPIO descriptors

Hi, This one has some issue as mmci-omap is unable to find the GPIOs on 770. On Mon, May 08, 2023 at 11:20:07PM +0200, Linus Walleij wrote: > +static struct gpiod_lookup_table nokia770_mmc_gpio_table = { > + .dev_id = "mmci-omap", Changing this to "mmci-omap.1" helped, not sure if that is a

Re: [PATCH v4 1/4] Input: ads7846 - Convert to use software nodes

Hi, This does not compile as nokia770_ads7846_props is declared twice, and nokia770_cbus_props and nokia770_mpuio_gpiochip_swnode are missing. On Mon, May 08, 2023 at 11:20:06PM +0200, Linus Walleij wrote: > +static const struct software_node_ref_args nokia770_cbus_gpio_refs[] = { > +

Re: [PATCH 14/17] ARM: omap1: remove dead code

Hi, On Wed, Oct 19, 2022 at 05:03:36PM +0200, Arnd Bergmann wrote: > drivers/usb/phy/phy-isp1301-omap.c | 91 +- This driver and config option ISP1301_OMAP can be deleted altogether as there are no users after H2/H3 boards are gone. A.

Re: [PATCH 00/41] OMAP1 full multiplatform conversion

Hi, On Wed, Apr 20, 2022 at 10:00:13PM +0200, Arnd Bergmann wrote: > On Wed, Apr 20, 2022 at 7:08 PM Aaro Koskinen wrote: > > On Tue, Apr 19, 2022 at 03:36:42PM +0200, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > This is the full series f

Re: [PATCH 26/41] ARM: omap1: relocate static I/O mapping

Hi, On Tue, Apr 19, 2022 at 03:37:08PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The address range 0xfee0-0xfeff is used for PCI and > PCMCIA I/O port mappings, but OMAP1 has its static mappings > there as well. > > Move the OMAP1 addresses a little higher to avoid crashing

Re: [PATCH 00/41] OMAP1 full multiplatform conversion

Hi, On Tue, Apr 19, 2022 at 03:36:42PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > This is the full series for converting OMAP1 to multiplatform, rebased > from my 2019 attempt to do the same thing. The soc tree contains simpler > patches to do the same for iop32x, ixp4xx, ep93xx and

Re: [PATCH] OMAP: DSS2: OMAPFB: fix potential GPF

Hi, On Sat, Jun 26, 2021 at 01:33:23AM +0300, Pavel Skripkin wrote: > In case of allocation failures, all code paths was jumping > to this code: > > err: > kfree(fbi); > kfree(var); > kfree(fbops); > > return r; > > Since all 3 pointers placed on stack and don't

Re: [PATCH] drm/omap: sdi: fix bridge enable/disable

t; WARNING: CPU: 0 PID: 18 at drivers/gpu/drm/drm_bridge.c:708 > drm_atomic_helper_commit_modeset_enables+0x134/0x268 > > and display not working. > > Fix this by using the legacy enable/disable funcs. > > Signed-off-by: Tomi Valkeinen &

Re: [PATCH] drm/panel: sony-acx565akm: Fix race condition in probe

driver. Last > but not least the omapdrm specific driver has been removed in > 45f16c82db7e ("drm/omap: displays: Remove unused panel drivers"). > > Reported-by: Jarkko Nikula > Reported-by: Peter Ujfalusi > Reported-by: Tony Lindgren > Reported-by: Aaro Koskine

Re: [PATCH] drm/omap: Fix port lookup for SDI output

nup code for > output devices") > Signed-off-by: Laurent Pinchart Tested-by: Aaro Koskinen Thanks, this fixes the display issue on N900. A. > --- > drivers/gpu/drm/omapdrm/dss/output.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers

Re: [PATCH] video: fbdev: omap2: remove rfbi

Hi, On Mon, Apr 30, 2018 at 10:06:11AM +0300, Tomi Valkeinen wrote: > On 27/04/18 21:12, Aaro Koskinen wrote: > >> You should be targeting omapdrm driver instead, fbdev subsystem is closed > >> for the new hardware support. > > > > AFAIK, based on N950 display su

Re: [PATCH] video: fbdev: omap2: remove rfbi

Hi, On Mon, Apr 30, 2018 at 05:34:59PM +0200, Bartlomiej Zolnierkiewicz wrote: > BROKEN is not an user selectable config option so without modifying > drivers/video/fbdev/omap2/omapfb/dss/Kconfig the RFBI driver is not > even included in the kernel build.. Yes, I know. It's still incorrect to

Re: [PATCH] video: fbdev: omap2: remove rfbi

Hi, On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > The RFBI driver has not worked nor compiled for many years. There are > very few boards out there that use RFBI, and no one has stepped

Re: [PATCH] video: fbdev: omap2: remove rfbi

Hi, On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > omapfb equivalent of drm's commit aa61321d4c08 ("drm/omap: remove rfbi"): > > The RFBI driver has not worked nor compiled for many years. There are What is the build failure you are seeing? When removing the

Re: [PATCH] video: fbdev: omap2: remove rfbi

Hi, On Fri, Apr 27, 2018 at 07:58:28PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Friday, April 27, 2018 08:47:14 PM Aaro Koskinen wrote: > > On Fri, Apr 27, 2018 at 05:09:14PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > omapfb equivalent of drm's commit aa61321d4c08 (&quo

Re: [PATCH 1/3] drm/omap: work-around for omap3 display enable

Hi, On Wed, Aug 23, 2017 at 12:33:08PM +0300, Tomi Valkeinen wrote: > On 13/06/17 12:02, Tomi Valkeinen wrote: > > Seems that on omap3 enabling a crtc without any planes causes a sync > > lost flood. This only happens on the first enable, and after that it > > works. This looks like an HW issue.

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

Hi, On Fri, Jun 30, 2017 at 11:47:55AM +0300, Tomi Valkeinen wrote: > > So, I don't know... I guess I need to try to invent some horrible hacks > > around the driver to somehow manage the omap3 problems. Perhaps > > disabling/enabling the outputs when sync lost happens... > > Well, I tried that

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

Hi, On Fri, Jun 30, 2017 at 09:41:35AM +0300, Tomi Valkeinen wrote: > On 29/06/17 21:50, Aaro Koskinen wrote: > > On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: > >> On 15/06/17 01:11, Aaro Koskinen wrote: > >>> When booting v4.12-rc5 on Noki

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

Hi, On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: > On 15/06/17 01:11, Aaro Koskinen wrote: > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > is no display. > > Are you sure it doesn't probe? It fails the omapdss_sta

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

Hi, On Thu, Jun 29, 2017 at 09:50:13PM +0300, Aaro Koskinen wrote: > On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: > > On 15/06/17 01:11, Aaro Koskinen wrote: > > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > > is no dis

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

Hi, On Thu, Jun 15, 2017 at 10:28:31AM +0300, Peter Ujfalusi wrote: > On 2017-06-15 01:11, Aaro Koskinen wrote: > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > is no display. > > > > Bisected to: > > > > a09d2bc1503508c17e

Re: [BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

Hi, On Thu, Jun 15, 2017 at 09:51:06AM +0300, Tomi Valkeinen wrote: > On 15/06/17 01:11, Aaro Koskinen wrote: > > When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there > > is no display. > > Are you sure it doesn't probe? It fails the omapdss_stack_is_ready

[BISECTED, REGRESSION] v4.12-rc: omapdrm fails to probe on Nokia N900

Hi, When booting v4.12-rc5 on Nokia N900, omapdrm fails to probe and there is no display. Bisected to: a09d2bc1503508c17ef3a71c6b1905e3660f3029 is the first bad commit commit a09d2bc1503508c17ef3a71c6b1905e3660f3029 Author: Peter Ujfalusi Date: Tue May 3 22:08:01 2016

Re: [PATCH 1/3] drm/omap: work-around for omap3 display enable

clear if omap2 has the same issue, but it > probably has and the WA should have no side effects so it should be safe > to enable on omap2 too. > > Signed-off-by: Tomi Valkeinen <tomi.valkei...@ti.com> Tested-by: Aaro Koskinen <aaro.koski...@iki.fi> This fixes the LCD errors

[PATCH 00/23] Nokia N950 display support

Hi, On Tue, Mar 08, 2016 at 09:45:11PM +0100, Sebastian Reichel wrote: > On Tue, Mar 08, 2016 at 08:39:08PM +0200, Aaro Koskinen wrote: > > On Tue, Mar 08, 2016 at 05:39:32PM +0100, Sebastian Reichel wrote: > > > This series adds support for the Nokia N950 display. > > &g

[PATCH 00/23] Nokia N950 display support

Hi, On Tue, Mar 08, 2016 at 05:39:32PM +0100, Sebastian Reichel wrote: > This series adds support for the Nokia N950 display. > Since the panel is using DSI command mode, it involves > adding support for manually updated displays to > omapdrm. Works OK, but the picture seems to be upside down?

No more new fbdev drivers, please

Hi, On Thu, Sep 24, 2015 at 03:27:01PM +0300, Tomi Valkeinen wrote: > fbdev is (more or less) maintained, but it's a deprecated framework. All > new Linux display drivers should be done on DRM. > > So let's not add any more new fbdev drivers. > > I will continue to maintain the current fbdev

Build regressions/improvements in v4.1-rc1

Hi, On Mon, Apr 27, 2015 at 12:03:32PM +0200, Geert Uytterhoeven wrote: > > *** ERRORS *** > > > > 34 regressions: > > The quiet days are over... > > > + /home/kisskb/slave/src/arch/mips/cavium-octeon/smp.c: error: passing > > argument 2 of 'cpumask_clear_cpu' discards 'volatile' qualifier

Re: [PATCH 03/15] drm/nouveau: use mdelay instead of large udelay constants

Hi, On Sat, Jun 01, 2013 at 12:22:40AM +0200, Arnd Bergmann wrote: ARM cannot handle udelay for more than 2 miliseconds, so we There's l missing here. should use mdelay instead for those. Could this be handled

[PATCH 03/15] drm/nouveau: use mdelay instead of large udelay constants

Hi, On Sat, Jun 01, 2013 at 12:22:40AM +0200, Arnd Bergmann wrote: > ARM cannot handle udelay for more than 2 miliseconds, so we There's l missing here. > should use mdelay instead for those. Could this be handled

Re: [PATCH] drm/nouveau: fix NULL ptr dereference from nv50_disp_intr()

This fixes regression caused by 1d7c71a3e2f7 (drm/nouveau/disp: port vblank handling to event interface), This patch fixes the boot crashes also on my G5 iMac (http://marc.info/?l=linux-kernelm=136285469916031w=2). Tested-by: Aaro Koskinen aaro.koski...@iki.fi

[PATCH] drm/nouveau: fix NULL ptr dereference from nv50_disp_intr()

n my system too, so it was easy to fix. > > I didn't even need gdm to trigger it! > > >8 > This fixes regression caused by 1d7c71a3e2f7 (drm/nouveau/disp: port vblank > handling to event interface), This patch fixes the boot crashes also on my G5 iMac (http://marc.info/?l=linux-kernel=136285469916031=2). Tested-by: Aaro Koskinen A.

Re: linux 3.9-rc1: nouveau crash on PPC

Hi, On Sat, Mar 09, 2013 at 08:44:31PM +0200, Aaro Koskinen wrote: There's nouveau crash during boot with 3.9-rc1 on iMac G5 (nVidia GeForce FX 5200 Ultra). This happens also with current mainline kernel HEAD (0aefda3e8188ad71168bd32152d41b3d72f04087). git bisect tells the first bad commit

linux 3.9-rc1: nouveau crash on PPC

Hi, On Sat, Mar 09, 2013 at 08:44:31PM +0200, Aaro Koskinen wrote: > There's nouveau crash during boot with 3.9-rc1 on iMac G5 (nVidia GeForce > FX 5200 Ultra). This happens also with current mainline kernel HEAD > (0aefda3e8188ad71168bd32152d41b3d72f04087). > > git bisect tell

linux 3.9-rc1: nouveau crash on PPC

Hi, There's nouveau crash during boot with 3.9-rc1 on iMac G5 (nVidia GeForce FX 5200 Ultra). This happens also with current mainline kernel HEAD (0aefda3e8188ad71168bd32152d41b3d72f04087). git bisect tells the first bad commit is 1d7c71a3e2f77336df536855b0efd2dc5bdeb41b (drm/nouveau/disp: port

linux 3.9-rc1: nouveau crash on PPC

Hi, There's nouveau crash during boot with 3.9-rc1 on iMac G5 (nVidia GeForce FX 5200 Ultra). This happens also with current mainline kernel HEAD (0aefda3e8188ad71168bd32152d41b3d72f04087). git bisect tells the first bad commit is 1d7c71a3e2f77336df536855b0efd2dc5bdeb41b (drm/nouveau/disp: port

[RESEND PATCH] drm/nouveau: fix init with agpgart-uninorth

channel, -12 Reviewed-by: Michel D?nzer Signed-off-by: Aaro Koskinen --- drivers/gpu/drm/nouveau/nouveau_bo.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 5614c89..69d7b1d 100644 --- a/drivers

[PATCH] drm/nouveau: fix init with agpgart-uninorth

channel, -12 Signed-off-by: Aaro Koskinen --- drivers/gpu/drm/nouveau/nouveau_bo.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 35ac57f..5f0e7ef 100644 --- a/drivers/gpu/drm/nouveau

[PATCH] drm/nouveau: fix init with agpgart-uninorth

channel, -12 Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/gpu/drm/nouveau/nouveau_bo.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index 35ac57f..5f0e7ef 100644 --- a/drivers/gpu/drm