[PATCH 07/32] acpi-video-detect: Rewrite backlight interface selection logic

On 06/11/2015 05:19 PM, Hans de Goede wrote: > Hi, > > On 11-06-15 11:00, Aaron Lu wrote: >> On Wed, Jun 10, 2015 at 03:01:07PM +0200, Hans de Goede wrote: >>> Currently we have 2 kernel commandline options + dmi-quirks in 3 places all >>> interacting (in intere

[PATCH 07/32] acpi-video-detect: Rewrite backlight interface selection logic

On Wed, Jun 10, 2015 at 03:01:07PM +0200, Hans de Goede wrote: > Currently we have 2 kernel commandline options + dmi-quirks in 3 places all > interacting (in interesting ways) to select which which backlight interface > to use. On the commandline we've acpi_backlight=[video|vendor] and >

[PATCH v2] acpi-video: Add a parameter to not register the backlight sysfs interface

On Tue, Jun 09, 2015 at 11:54:45PM +0200, Hans de Goede wrote: > Hi, > > On 06/09/2015 11:10 AM, Aaron Lu wrote: > >On Tue, Jun 09, 2015 at 10:32:25AM +0200, Hans de Goede wrote: > >>On some systems acpi-video backlight is broken in the sense that it cannot &g

[PATCH v2] acpi-video: Add a parameter to not register the backlight sysfs interface

On Tue, Jun 09, 2015 at 10:32:25AM +0200, Hans de Goede wrote: > On some systems acpi-video backlight is broken in the sense that it cannot > control the brightness of the backlight, but it must still be called on > resume to power-up the backlight after resume. All the video module does on

[PATCH 0/3] Use acpi_video_unregister_backlight instead of acpi_video_unregister in platfrom backlight drivers

On Tue, Jun 02, 2015 at 10:33:50PM +0800, Aaron Lu wrote: > On Tue, Jun 02, 2015 at 12:14:28PM +0200, Hans de Goede wrote: > > > > If this makes sense (*) then the cooling device stuff should maybe moved > > from the acpi/video.c code to the backlight core code. > >

[PATCH 0/3] Use acpi_video_unregister_backlight instead of acpi_video_unregister in platfrom backlight drivers

On Tue, Jun 02, 2015 at 12:14:28PM +0200, Hans de Goede wrote: > Hi, > > On 02-06-15 11:59, Jani Nikula wrote: > >On Mon, 01 Jun 2015, Hans de Goede wrote: > >>Hi All, > >> > >>I'm working on cleaning up the currently somewhat convoluted logic to > >>select which backlight interfaces to register

[PATCH 0/3] Use acpi_video_unregister_backlight instead of acpi_video_unregister in platfrom backlight drivers

On Tue, Jun 02, 2015 at 12:59:10PM +0300, Jani Nikula wrote: > On Mon, 01 Jun 2015, Hans de Goede wrote: > > Hi All, > > > > I'm working on cleaning up the currently somewhat convoluted logic to > > select which backlight interfaces to register on x86 systems, see: > >

[PATCH] ACPI / i915: Update the condition to ignore firmware backlight change request

interface is not in use and the ACPI backlight interface is broken, we ignore the requests; oterwise, we keep processing them. Reference: https://lkml.org/lkml/2014/9/23/854 Reported-and-tested-by: Pali Roh?r Cc: # v3.16 and later Signed-off-by: Aaron Lu --- drivers/gpu/drm/i915/intel_opregion.c

ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

On 09/26/2014 03:58 AM, Rafael J. Wysocki wrote: > On Thursday, September 25, 2014 11:15:35 AM Aaron Lu wrote: >> Hi Hans, >> >> Thanks for following up and explaining the situation to Pali. >> >> On 09/25/2014 02:21 AM, Pali Roh?r wrote: >>> On Wednesda

ACPI/i915: Cannot configure display brightness on Dell Latitude E6440

Hi Hans, Thanks for following up and explaining the situation to Pali. On 09/25/2014 02:21 AM, Pali Roh?r wrote: > On Wednesday 24 September 2014 16:34:21 Hans de Goede wrote: >> Ok, so the dell-laptop interface is just an obsolete wrapper >> around the i915 opregion code, which shows that the

[PATCH v3] drm/i915: restore backlight precision when converting from opregion

On 05/04/2014 03:22 PM, Chris Wilson wrote: > 32b * 32b = 32b > > n = (u64)level * freq; to avoid overflow as you claim. Updated patch to fix this problem is here, thanks! >From a0f41a92d949c814c203672ff7efe219a90ca6df Mon Sep 17 00:00:00 2001 From: Aaron Lu <aaron...@intel.com

[Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

On 05/04/2014 06:41 PM, Chris Wilson wrote: > On Sun, May 04, 2014 at 03:31:01PM +0800, Aaron Lu wrote: >> On 05/04/2014 03:22 PM, Chris Wilson wrote: >>> Also this still has the same rounding error as before. >> >> I didn't get this, care to explain? > >

[Intel-gfx] [PATCH v2] drm/i915: restore backlight precision when converting from opregion

On 05/04/2014 03:22 PM, Chris Wilson wrote: > On Sun, May 04, 2014 at 03:16:05PM +0800, Aaron Lu wrote: >> On 04/28/2014 09:41 PM, Daniel Vetter wrote: >>> 64bit divisions won't compile on 32bit. You need one of the DO_DIV macros, >>> or whatever they're c

[PATCH v2] drm/i915: restore backlight precision when converting from opregion

On 04/28/2014 09:41 PM, Daniel Vetter wrote: > 64bit divisions won't compile on 32bit. You need one of the DO_DIV macros, > or whatever they're called again. I pain, I know ;-) Thanks for the correction, here is an updated patch :-) From: Aaron Lu <aaron...@intel.com> Date: Mon, 28

[PATCH] drm/i915: restore backlight precision when converting from opregion

=72491 Reported-and-tested-by: Nico Schottelius Signed-off-by: Aaron Lu --- drivers/gpu/drm/i915/intel_panel.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index a953b081ee38..bdd2f24b7a6b 100644

[PATCH] [ACPI] Default to using the native backlight control on Windows 8 systems

On 04/11/2014 06:58 PM, Jani Nikula wrote: > On Fri, 11 Apr 2014, Aaron Lu wrote: >> On 04/11/2014 04:13 AM, Matthew Garrett wrote: >>> The list of machines in the "Use native backlight" table is getting longer >>> and longer, which is a solid indica

[PATCH] [ACPI] Default to using the native backlight control on Windows 8 systems

On 04/11/2014 04:13 AM, Matthew Garrett wrote: > The list of machines in the "Use native backlight" table is getting longer > and longer, which is a solid indication that we're doing something wrong. > Disable the ACPI backlight interface if the system claims to be Windows 8 > or later. And has a

[PATCH v3] ACPI / video: Add systems that should favor native backlight interface

On 01/21/2014 08:11 PM, Matthew Garrett wrote: > On Tue, 2014-01-21 at 13:32 +0800, Aaron Lu wrote: >> On 01/21/2014 11:17 AM, Matthew Garrett wrote: >>> We know that Windows 8 graphics drivers don't use the ACPI interface, >>> and that systems change their behaviour

[PATCH v3] ACPI / video: Add systems that should favor native backlight interface

On 01/21/2014 11:17 AM, Matthew Garrett wrote: > On Tue, 2014-01-21 at 10:24 +0800, Aaron Lu wrote: >> On 01/20/2014 09:34 PM, Matthew Garrett wrote: >>> On Mon, 2014-01-20 at 16:12 +0800, Aaron Lu wrote: >>> >>>> 1 remove the win8 OSI check, I've seen win7

[PATCH v3] ACPI / video: Add systems that should favor native backlight interface

On 01/20/2014 09:34 PM, Matthew Garrett wrote: > On Mon, 2014-01-20 at 16:12 +0800, Aaron Lu wrote: > >> 1 remove the win8 OSI check, I've seen win7 laptops that also needs to >> have only the GPU interface left and checking win8 doesn't make much >> sense now; >

[PATCH v3] ACPI / video: Add systems that should favor native backlight interface

Hi Igor, On 01/18/2014 09:54 PM, Igor Gnatenko wrote: > From: Aaron Lu > > Some system's ACPI video backlight control interface is broken and the > native backlight control interface should be used by default. This patch > sets the use_native_backlight parameter to true for t

I915 did not work whit modset=1

On 01/08/2014 05:09 PM, Jani Nikula wrote: > On Mon, 30 Dec 2013, Jani Nikula wrote: >> On Mon, 23 Dec 2013, der-b wrote: >>> Hello, >>> >>> i got a new Notebook with an Intel Core i7-3689Y whit a Intel HD >>> Graphics 4000. I got a blank screen while booting but I could use ssh. >>> This

[PATCH v2 rebased] ACPI / video: Add systems that should favor native backlight interface

ive backlight interface From: Aaron Lu <aaron...@intel.com> Date: Thu, 21 Nov 2013 11:24:48 +0800 Some system's ACPI video backlight control interface is broken and the native backlight control interface should be used by default. This patch sets the use_native_backlight parameter to true

[PATCH v2] ACPI / video: Add systems that should favor native backlight interface

-by: Reference: https://bugzilla.kernel.org/show_bug.cgi?id=62941 Signed-off-by: Aaron Lu --- v2: Add Acer Aspire 5733Z, see bug #62941; Remove Inspiron 7520 from acpi_osi_dmi_table and Yoga 13 from video_detect_dmi_table. Based on top of Rafael's linux-next branch + the following patch: [PATCH] ACPI

[Intel-gfx] [Acer Aspire V5-573G] Black screen on boot due to low brightness setting

On 11/14/2013 02:24 PM, Jani Nikula wrote: > > Hi Mario - > > On Wed, 13 Nov 2013, Mario Kleinsasser gmail.com> wrote: >> In the last three weeks I've narrowed down the bug described in the >> subject through Ubuntu launchpad. My new Laptop (Acer Aspire

[PATCH v5 0/4] Fix Win8 backlight issue

On 10/28/2013 04:09 PM, Jani Nikula wrote: > On Mon, 28 Oct 2013, Aaron Lu wrote: >> +static int __init video_set_use_native_backlight(const struct dmi_system_id >> *d) >> +{ >> +use_native_backlight = true; >> +return 0; >> +} >

[PATCH v5 0/4] Fix Win8 backlight issue

quot;Dell Inspiron 7520", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_VERSION, "Inspiron 7520"), > + }, > + }, Thanks Igor, updated patch follows: From: Aaron Lu <aaron...@intel.

[PATCH v5 0/4] Fix Win8 backlight issue

On 10/16/2013 07:33 AM, Rafael J. Wysocki wrote: > On Friday, October 11, 2013 09:27:42 PM Aaron Lu wrote: >> v5: >> 1 Introduce video.use_native_backlight module parameter and set its >> value to false by default as suggested by Rafael. For Win8 systems >> w

[PATCH v5 0/4] Fix Win8 backlight issue

in thinkpad-acpi module. Technically, patch 2/4 is not required to fix the issue here. So if you think it is not necessary, I can remove it from the series. Aaron Lu (4): backlight: introduce backlight_device_registered ACPI / video: seperate backlight control and event interface ACPI / video

[PATCH v5 1/4] backlight: introduce backlight_device_registered

. avoid register its own on Win8 systems). Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/video/backlight/backlight.c | 31 +++ include/linux/backlight.h | 4 2 files changed, 35 insertions(+) diff --git a/drivers/video/backlight/backlight.c b

[PATCH v5 2/4] ACPI / video: seperate backlight control and event interface

and/or event delivery functionality can be easily added once needed. Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/video.c | 434 +-- 1 file changed, 245 insertions(+), 189 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi

[PATCH v5 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

there are systems that don't work well with this approach, a parameter for video module named use_native_backlight is introduced and has the value of false by default. For users who have a broken ACPI video backlight interface, video.use_native_backlight=1 is needed in kernel cmdline. Signed-off-by: Aaron

[PATCH v5 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL

the handle of a video output device node, which is child of the located video controller node from tpacpi_acpi_handle_locate. The two fix are necessary for some Thinkpad models to emit notification on backlight hotkey press as a result of evaluation of _BCL. Signed-off-by: Aaron Lu aaron

Re: [PATCH v4 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

On 10/10/2013 08:59 PM, Rafael J. Wysocki wrote: On Thursday, October 10, 2013 09:02:55 AM Aaron Lu wrote: On 10/10/2013 08:29 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:40:00 PM Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up

Re: [PATCH v4 1/4] backlight: introduce backlight_device_registered

On 10/10/2013 08:25 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:39:58 PM Aaron Lu wrote: Introduce a new API for modules to query if a specific type of backlight device has been registered. This is useful for some backlight device provider module(e.g. ACPI video) to know

Re: [PATCH v4 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

On 10/10/2013 08:29 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:40:00 PM Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest

Re: [PATCH v4 1/4] backlight: introduce backlight_device_registered

On 10/10/2013 12:29 PM, Jani Nikula wrote: On Thu, 10 Oct 2013, Aaron Lu aaron...@intel.com wrote: On 10/10/2013 08:25 AM, Rafael J. Wysocki wrote: On Tuesday, October 08, 2013 02:39:58 PM Aaron Lu wrote: +bool backlight_device_registered(enum backlight_type type) +{ + bool found = false

[PATCH v4 0/4] Fix Win8 backlight issue

exists. Patch 4/4 fixes some problems in thinkpad-acpi module. Technically, patch 2/4 is not required to fix the issue here. So if you think it is not necessary, I can remove it from the series. Aaron Lu (4): backlight: introduce backlight_device_registered ACPI / video: seperate backlight

[PATCH v4 1/4] backlight: introduce backlight_device_registered

. avoid register its own on Win8 systems). Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org Tested-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/video/backlight/backlight.c | 31

[PATCH v4 2/4] ACPI / video: seperate backlight control and event interface

and/or event delivery functionality can be easily added once needed. Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org Tested-by: Mika Westerberg mika.westerb...@linux.intel.com --- drivers/acpi/video.c | 434

[PATCH v4 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

to keep ACPI video's backlight interface, the existing kernel cmdline option acpi_backlight=video can be used. Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org Tested-by: Mika Westerberg mika.westerb

[PATCH v4 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL

the handle of a video output device node, which is child of the located video controller node from tpacpi_acpi_handle_locate. The two fix are necessary for some Thinkpad models to emit notification on backlight hotkey press as a result of evaluation of _BCL. Signed-off-by: Aaron Lu aaron

Re: [PATCH v3 0/4] Fix Win8 backlight issue

:47 +0800, Aaron Lu wrote: v3: 1 Add a new patch 4/4 to fix some problems in thinkpad-acpi module; 2 Remove unnecessary function acpi_video_unregister introduced in patch 2/3 as pointed out by Jani Nikula. v2: v1 has the subject of Rework ACPI video driver and is posted here

Re: [PATCH v3 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL

On Wed, Sep 25, 2013 at 04:58:39PM -0300, Henrique de Moraes Holschuh wrote: On Tue, 24 Sep 2013, Aaron Lu wrote: locate handle for ACPI video by HID, the problem is, ACPI video node doesn't really have HID defined(i.e. no _HID control method is defined ACPI video is supposed to attach

Re: [PATCH v3 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

On Wed, Sep 25, 2013 at 07:53:13PM +0200, Rafael J. Wysocki wrote: On Tuesday, September 24, 2013 05:47:31 PM Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence

[PATCH v3 0/4] Fix Win8 backlight issue

video's backlight interface if: 1 Kernel cmdline option acpi_backlight=video is not given; 2 This is a Win8 system; 3 Native backlight control interface exists. Technically, patch 2/3 is not required to fix the issue here. So if you think it is not necessary, I can remove it from the series. Aaron Lu

[PATCH v3 1/4] backlight: introduce backlight_device_registered

. avoid register its own on Win8 systems). Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org --- drivers/video/backlight/backlight.c | 31 +++ include/linux/backlight.h

[PATCH v3 2/4] ACPI / video: seperate backlight control and event interface

and/or event delivery functionality can be easily added once needed. Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org --- drivers/acpi/video.c | 434

[PATCH v3 3/4] ACPI / video: Do not register backlight if win8 and native interface exists

to keep ACPI video's backlight interface, the existing kernel cmdline option acpi_backlight=video can be used. Signed-off-by: Aaron Lu aaron...@intel.com Tested-by: Igor Gnatenko i.gnatenko.br...@gmail.com Tested-by: Yves-Alexis Perez cor...@debian.org --- drivers/acpi/internal.h | 5

[PATCH v3 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL

the handle of a video output device node, which is child of the located video controller node from tpacpi_acpi_handle_locate. The two fix are necessary for some Thinkpad models to emit notification on backlight hotkey press as a result of evaluation of _BCL. Signed-off-by: Aaron Lu aaron

Re: [PATCH v3 2/4] ACPI / video: seperate backlight control and event interface

On 09/24/2013 05:47 PM, Aaron Lu wrote: The backlight control and event delivery functionality provided by ACPI video module is mixed together and registered all during video device enumeration time. As a result, the two functionality are also removed together on module unload time

Re: [PATCH v2 3/3] ACPI / video: Do not register backlight if win8 and native interface exists

On 09/20/2013 04:36 PM, Jani Nikula wrote: On Tue, 17 Sep 2013, Aaron Lu aaron...@intel.com wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel

Re: [PATCH v2 0/3] Fix Win8 backlight issue

On 09/18/2013 08:36 PM, Igor Gnatenko wrote: On Wed, 2013-09-18 at 20:31 +0800, Aaron Lu wrote: On 09/18/2013 02:30 PM, Igor Gnatenko wrote: On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote: On 09/17/2013 09:34 PM, Igor Gnatenko wrote: Aaron, how about fix indicator on ThinkPads ? Can you

Re: [PATCH v2 0/3] Fix Win8 backlight issue

On 09/18/2013 02:30 PM, Igor Gnatenko wrote: On Wed, 2013-09-18 at 09:03 +0800, Aaron Lu wrote: On 09/17/2013 09:34 PM, Igor Gnatenko wrote: Aaron, how about fix indicator on ThinkPads ? Can you please describe the problem in detail, is it that when you adjust brightness level through

Re: [PATCH v2 0/3] Fix Win8 backlight issue

On 09/17/2013 09:34 PM, Igor Gnatenko wrote: On Tue, 2013-09-17 at 17:23 +0800, Aaron Lu wrote: v1 has the subject of Rework ACPI video driver and is posted here: http://lkml.org/lkml/2013/9/9/74 Since the objective is really to fix Win8 backlight issues, I changed the subject in this version

[PATCH v2 3/3] ACPI / video: Do not register backlight if win8 and native interface exists

to keep ACPI video's backlight interface, the existing kernel cmdline option acpi_backlight=video can be used. This patch is an evolution from previous work done by Matthew Garrett, Chun-Yi Lee, Seth Forshee and Rafael J. Wysocki. Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi

[PATCH v2 2/3] ACPI / video: seperate backlight control and event interface

and/or event delivery functionality can be easily added once needed. Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/video.c | 451 ++- include/acpi/video.h | 2 + 2 files changed, 264 insertions(+), 189 deletions(-) diff --git a/drivers

[PATCH v2 0/3] Fix Win8 backlight issue

is not required to fix the issue here. So if you think it is not necessary, I can remove it from the series. Apply on top of v3.12-rc1. Aaron Lu (3): backlight: introduce backlight_device_registered ACPI / video: seperate backlight control and event interface ACPI / video: Do not register

[PATCH v2 1/3] backlight: introduce backlight_device_registered

. avoid register its own on Win8 systems). Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/video/backlight/backlight.c | 31 +++ include/linux/backlight.h | 4 2 files changed, 35 insertions(+) diff --git a/drivers/video/backlight/backlight.c b

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On Wed, Sep 11, 2013 at 11:45:19AM +0300, Jani Nikula wrote: On Wed, 11 Sep 2013, Aaron Lu aaron...@intel.com wrote: It is possible the i915 driver decides not to register a backlight interface for the graphics card for some reason(memory allocation failed or it knows the native control

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index f466980..75fba17 100644 --- a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On 09/10/2013 01:13 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index f466980

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On 09/10/2013 01:22 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 13:16 +0800, Aaron Lu wrote: On 09/10/2013 01:13 PM, Igor Gnatenko wrote: On Tue, 2013-09-10 at 11:27 +0800, Aaron Lu wrote: On 09/09/2013 07:44 PM, Igor Gnatenko wrote: On Mon, 2013-09-09 at 16:42 +0800, Aaron Lu wrote: diff

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

, Daniel On Mon, Sep 09, 2013 at 04:42:20PM +0800, Aaron Lu wrote: According to Matthew Garrett, Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel driver for Windows [8] doesn't

Re: [PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On Tue, Sep 10, 2013 at 09:23:04PM +0200, Rafael J. Wysocki wrote: On Tuesday, September 10, 2013 04:53:40 PM Jani Nikula wrote: On Mon, 09 Sep 2013, Rafael J. Wysocki r...@sisk.pl wrote: On Monday, September 09, 2013 05:21:18 PM Daniel Vetter wrote: On Mon, Sep 09, 2013 at 02:16:12PM

[PATCH 1/2] ACPI / video: seperate backlight control and event interface

functionality alone so the function acpi_video_remove_notify_handler is not introduced, it can be easily added when needed. Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/video.c | 451 ++- include/acpi/video.h | 2 + 2 files changed

[PATCH 0/2] Rework ACPI video driver

problems with i915's backlight control interface, a module param is introduced to give user a chance to select if they want to remove ACPI video's backlight control interface. The param is set to false by default. Aaron Lu (2): ACPI / video: seperate backlight control and event interface ACPI / video

[PATCH 2/2] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

from earlier patches of Matthew Garrett, Chun-Yi Lee and Seth Forshee and is heavily based on two patches from Rafael: https://lkml.org/lkml/2013/7/17/720 https://lkml.org/lkml/2013/7/24/806 Signed-off-by: Aaron Lu aaron...@intel.com --- drivers/acpi/internal.h | 2 ++ drivers/acpi/video.c

Backlight control only in the kernel?

On 08/07/2013 03:44 PM, Borislav Petkov wrote: > On Sun, Jun 09, 2013 at 07:01:36PM -0400, Matthew Garrett wrote: >> Windows 8 introduced new policy for backlight control by pushing it out to >> graphics drivers. This appears to have coincided with a range of vendors >> adding Windows 8 checks to

Re: Backlight control only in the kernel?

On 08/07/2013 03:44 PM, Borislav Petkov wrote: On Sun, Jun 09, 2013 at 07:01:36PM -0400, Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have coincided with a range of vendors adding Windows 8 checks to their

i915 backlight

but in graphical system brightness bar was > not moving. > > > Now I have, though, 8 possible values for brightness and brightness > bar shows its correct position. > > Josep > > On 2 August 2013 08:00, Aaron Lu wrote: >> On 08/01/2013 04:07 PM, Borislav P

i915 backlight

On 08/01/2013 04:07 PM, Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: >> Does reverting efaa14c help? > > Nope. > > But see my other reply to Aaron. Assume you have specified to use intel_backlight in xorg.conf, does booting with

i915 backlight

On 08/01/2013 05:07 PM, Aaron Lu wrote: > On 08/01/2013 04:12 PM, Borislav Petkov wrote: >> On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: >>> Can you please run acpi_listen and then press the Fn-Fx key, see if the >>> events are correctly sent out? >>

Re: i915 backlight

On 08/01/2013 05:07 PM, Aaron Lu wrote: On 08/01/2013 04:12 PM, Borislav Petkov wrote: On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: Can you please run acpi_listen and then press the Fn-Fx key, see if the events are correctly sent out? Like this? # acpi_listen video

Re: i915 backlight

On 08/01/2013 04:07 PM, Borislav Petkov wrote: On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: Does reverting efaa14c help? Nope. But see my other reply to Aaron. Assume you have specified to use intel_backlight in xorg.conf, does booting with

Re: i915 backlight

On 2 August 2013 08:00, Aaron Lu aaron...@intel.com wrote: On 08/01/2013 04:07 PM, Borislav Petkov wrote: On Wed, Jul 31, 2013 at 11:16:52PM +0200, Rafael J. Wysocki wrote: Does reverting efaa14c help? Nope. But see my other reply to Aaron. Assume you have specified to use intel_backlight

i915 backlight

On 08/01/2013 04:12 PM, Borislav Petkov wrote: > On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: >> Can you please run acpi_listen and then press the Fn-Fx key, see if the >> events are correctly sent out? > > Like this? > > # acpi_listen > video/brightne

i915 backlight

On 08/01/2013 12:36 AM, Borislav Petkov wrote: > On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: >> Dudes, >> >> has anyone already reported this (happens on Linus of today + >> tip/master): > > Oh, one more thing: I can't control the backlight anymore on this x230 > with the

Re: [Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

On 07/31/2013 08:01 AM, Rafael J. Wysocki wrote: On Thursday, July 18, 2013 02:16:09 AM Rafael J. Wysocki wrote: On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: Windows 8 introduced new policy for backlight control by pushing it out to graphics drivers. This appears to have

Re: i915 backlight

On 08/01/2013 12:36 AM, Borislav Petkov wrote: On Wed, Jul 31, 2013 at 06:22:52PM +0200, Borislav Petkov wrote: Dudes, has anyone already reported this (happens on Linus of today + tip/master): Oh, one more thing: I can't control the backlight anymore on this x230 with the Fn-Fx keys and

Re: i915 backlight

On 08/01/2013 04:12 PM, Borislav Petkov wrote: On Thu, Aug 01, 2013 at 09:13:35AM +0800, Aaron Lu wrote: Can you please run acpi_listen and then press the Fn-Fx key, see if the events are correctly sent out? Like this? # acpi_listen video/brightnessdown BRTDN 0087 video

[Update][PATCH 0/3] Fix backlight issues on some Windows 8 systems

On 07/31/2013 08:01 AM, Rafael J. Wysocki wrote: > On Thursday, July 18, 2013 02:16:09 AM Rafael J. Wysocki wrote: >> On Sunday, June 09, 2013 07:01:36 PM Matthew Garrett wrote: >>> Windows 8 introduced new policy for backlight control by pushing it out to >>> graphics drivers. This appears to

[Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

On 07/15/2013 07:42 PM, Rafael J. Wysocki wrote: > On Monday, July 15, 2013 10:36:15 AM Aaron Lu wrote: >> On 07/13/2013 08:46 AM, Rafael J. Wysocki wrote: >>> From: Rafael J. Wysocki >>> >>> According to Matthew Garrett, "Windows 8 leaves backlight cont

[Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

er use acpi_video_register_with_quirks() instead of > acpi_video_register() in i915_driver_load(). > > This change is based on earlier patches from Matthew Garrett, > Chun-Yi Lee and Seth Forshee and Aaron Lu's comments. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Aa

Re: [Update][PATCH] ACPI / video / i915: Remove ACPI backlight if firmware expects Windows 8

on earlier patches from Matthew Garrett, Chun-Yi Lee and Seth Forshee and Aaron Lu's comments. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Reviewed-by: Aaron Lu aaron...@intel.com BTW, I also tested on a Toshiba laptop Z830 where its AML code claims support of win8, the result

[PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 07/07/2013 09:19 PM, Rafael J. Wysocki wrote: > OK, the patch is appended. Please have a look and tell me what you think. > > Thanks, > Rafael > > > --- > From: Rafael J. Wysocki > Subject: ACPI / video / i915: Remove ACPI backlight if firmware expects > Windows 8 > > According to

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 07/06/2013 06:23 AM, Rafael J. Wysocki wrote: On Friday, July 05, 2013 11:40:02 PM Rafael J. Wysocki wrote: On Friday, July 05, 2013 10:00:55 PM Rafael J. Wysocki wrote: On Friday, July 05, 2013 02:20:14 PM Rafael J. Wysocki wrote: On Sunday, June 09, 2013 07:01:39 PM Matthew Garrett wrote:

[PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 07/06/2013 06:23 AM, Rafael J. Wysocki wrote: > On Friday, July 05, 2013 11:40:02 PM Rafael J. Wysocki wrote: >> On Friday, July 05, 2013 10:00:55 PM Rafael J. Wysocki wrote: >>> On Friday, July 05, 2013 02:20:14 PM Rafael J. Wysocki wrote: On Sunday, June 09, 2013 07:01:39 PM Matthew

[PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/15/2013 12:19 PM, Matthew Garrett wrote: > On Sat, Jun 15, 2013 at 12:14:42PM +0800, Aaron Lu wrote: >> On 06/15/2013 09:38 AM, Matthew Garrett wrote: >>> Well, Windows 8 will only use the ACPI backlight interface if the GPU >>> driver decides to, right? So the

[PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/15/2013 09:38 AM, Matthew Garrett wrote: > On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: >> It's not easy to decide if they work or not sometimes, e.g. I came >> across a system that claims win8 in ACPI table and has an Intel GPU, >> while its ACPI video

[PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/15/2013 01:29 AM, Matthew Garrett wrote: > On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: > >> What about a priority based solution? We can introduce a new field named >> priority to backlight_device and instead of calling another module's >> function like the u

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/10/2013 07:01 AM, Matthew Garrett wrote: Windows 8 leaves backlight control up to individual graphics drivers rather than making ACPI calls itself. There's plenty of evidence to suggest that the Intel driver for Windows doesn't use the ACPI interface, including the fact that it's broken

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/15/2013 01:29 AM, Matthew Garrett wrote: On Fri, 2013-06-14 at 14:47 +0800, Aaron Lu wrote: What about a priority based solution? We can introduce a new field named priority to backlight_device and instead of calling another module's function like the unregister one here(which cause

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/15/2013 09:38 AM, Matthew Garrett wrote: On Sat, 2013-06-15 at 09:26 +0800, Aaron Lu wrote: It's not easy to decide if they work or not sometimes, e.g. I came across a system that claims win8 in ACPI table and has an Intel GPU, while its ACPI video interface also works. With this patch

Re: [PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/15/2013 12:19 PM, Matthew Garrett wrote: On Sat, Jun 15, 2013 at 12:14:42PM +0800, Aaron Lu wrote: On 06/15/2013 09:38 AM, Matthew Garrett wrote: Well, Windows 8 will only use the ACPI backlight interface if the GPU driver decides to, right? So the logic for deciding whether to remove

[PATCH 3/3] i915: Don't provide ACPI backlight interface if firmware expects Windows 8

On 06/10/2013 07:01 AM, Matthew Garrett wrote: > Windows 8 leaves backlight control up to individual graphics drivers rather > than making ACPI calls itself. There's plenty of evidence to suggest that > the Intel driver for Windows doesn't use the ACPI interface, including the > fact that it's

New prototype computer problem with S3 suspend

On 06/07/2013 02:11 AM, Boszormenyi Zoltan wrote: > Hi, > > we are working on an Intel Atom-based embedded PC and I have to > make suspend-to-RAM work but I can't seem to succeed. > > The symptom is that quite often, the machine resumes immediately > after pm-suspend. Sometimes more than 20

Re: New prototype computer problem with S3 suspend

On 06/07/2013 02:11 AM, Boszormenyi Zoltan wrote: Hi, we are working on an Intel Atom-based embedded PC and I have to make suspend-to-RAM work but I can't seem to succeed. The symptom is that quite often, the machine resumes immediately after pm-suspend. Sometimes more than 20 times out