Re: [PATCH] drm/msm/dpu: add support for 4:2:2 and 4:4:4 planar YCbCr plane formats

2024-02-23 Thread Abhinav Kumar
On 2/22/2024 3:43 AM, Dmitry Baryshkov wrote: The DPU driver provides support for 4:2:0 planar YCbCr plane formats. Extend it to also support 4:2:2 and 4:4:4 plat formats. I checked myself and also internally on this. On sm8250, the DPU planes do not support YUV444 and YUV422 (and the

Re: i915 build error on drm-misc-next

2024-02-23 Thread Abhinav Kumar
On 2/23/2024 11:35 AM, Rodrigo Vivi wrote: On Fri, Feb 23, 2024 at 09:47:11AM -0800, Abhinav Kumar wrote: CC Dmitry Hi Rodrigo On 2/23/2024 9:00 AM, Rodrigo Vivi wrote: On Fri, Feb 23, 2024 at 08:50:06AM -0700, Jeffrey Hugo wrote: With the x86_64_defconfig I see the following when

Re: [PATCH] drm/i915: convert remaining intel_dp_vsc_sdp_pack

2024-02-23 Thread Abhinav Kumar
: Daniel Vetter Cc: Dmitry Baryshkov Cc: Abhinav Kumar Cc: Maxime Ripard Cc: Maarten Lankhorst Cc: Thomas Zimmermann Signed-off-by: Rodrigo Vivi Reviewed-by: Abhinav Kumar

Re: i915 build error on drm-misc-next

2024-02-23 Thread Abhinav Kumar
CC Dmitry Hi Rodrigo On 2/23/2024 9:00 AM, Rodrigo Vivi wrote: On Fri, Feb 23, 2024 at 08:50:06AM -0700, Jeffrey Hugo wrote: With the x86_64_defconfig I see the following when building drm-misc-next: CC drivers/gpu/drm/i915/display/intel_crt.o CC

Re: [PATCH v5] drm/msm/dpu: add current resource allocation to dumped state

2024-02-22 Thread Abhinav Kumar
once. Rest LGTM. Reviewed-by: Abhinav Kumar

Re: [PATCH 3/9] arm64: dts: qcom: sc7280: Enable MDP turbo mode

2024-02-22 Thread Abhinav Kumar
the DPU will not vote more than nominal. And like others wrote, limiting SOC frequencies is not the way and we should filter out required frequencies using link-frequencies. Hence fwiw, I am fine with this change. Reviewed-by: Abhinav Kumar

Re: [PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 2:42 PM, Dmitry Baryshkov wrote: On Wed, 21 Feb 2024 at 00:40, Abhinav Kumar wrote: On 2/19/2024 3:52 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 22:36, Abhinav Kumar wrote: On 2/14/2024 11:20 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 20:02, Abhinav

Re: [PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-20 Thread Abhinav Kumar
On 2/19/2024 3:52 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 22:36, Abhinav Kumar wrote: On 2/14/2024 11:20 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 20:02, Abhinav Kumar wrote: On 2/8/2024 6:50 AM, Dmitry Baryshkov wrote: We have several reports of vblank timeout

Re: drm/msm: Second DisplayPort regression in 6.8-rc1

2024-02-20 Thread Abhinav Kumar
Hi Johan On 2/19/2024 2:41 AM, Johan Hovold wrote: On Sat, Feb 17, 2024 at 04:14:58PM +0100, Johan Hovold wrote: On Wed, Feb 14, 2024 at 02:52:06PM +0100, Johan Hovold wrote: On Tue, Feb 13, 2024 at 10:00:13AM -0800, Abhinav Kumar wrote: Since Dmitry had trouble reproducing this issue I

[PATCH v3 2/2] drm/dp: drop the size parameter from drm_dp_vsc_sdp_pack()

2024-02-20 Thread Abhinav Kumar
Currently the size parameter of drm_dp_vsc_sdp_pack() is always the size of struct dp_sdp. Hence lets drop this parameter and use sizeof() directly. Suggested-by: Dmitry Baryshkov Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_dp_helper.c | 8 ++-- drivers/gpu/drm/i915

[PATCH v3 1/2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. changes in v2: - rebased on top of drm-tip Acked-by: Dmitry Baryshkov Signed-off-by: Abhinav Kumar Acked-by: Jani Nikula --- drivers/gpu/drm/display/drm_dp_helper.c

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 11:41 AM, Ville Syrjälä wrote: On Tue, Feb 20, 2024 at 11:27:18AM -0800, Abhinav Kumar wrote: On 2/20/2024 11:20 AM, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 21:05, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar wrote: On 2/20/2024 10:49 AM

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 11:20 AM, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 21:05, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar wrote: On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 11:05 AM, Dmitry Baryshkov wrote: On Tue, 20 Feb 2024 at 20:53, Abhinav Kumar wrote: On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move

Re: [PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-20 Thread Abhinav Kumar
On 2/20/2024 10:49 AM, Dmitry Baryshkov wrote: On Thu, 15 Feb 2024 at 21:08, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. changes in v2: - rebased on top of drm-tip Acked-by: Dmitry

Re: [PATCH v5] drm/dp: add an API to indicate if sink supports VSC SDP

2024-02-19 Thread Abhinav Kumar
Hi DRM maintainers Gentle ping for reviews on this one. Since the dependent series is mostly complete, would like to get your reviews on this one to land it. Thanks Abhinav On 2/15/2024 11:15 AM, Abhinav Kumar wrote: From: Paloma Arellano YUV420 format is supported only in the VSC SDP

[PATCH v5] drm/dp: add an API to indicate if sink supports VSC SDP

2024-02-15 Thread Abhinav Kumar
to drm_dp_helper.c [1]: https://patchwork.freedesktop.org/series/129180/ Reviewed-by: Dmitry Baryshkov Signed-off-by: Paloma Arellano Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_dp_helper.c | 23 +++ include/drm/display/drm_dp_helper.h | 2 ++ 2 files

[PATCH v2] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-15 Thread Abhinav Kumar
intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. changes in v2: - rebased on top of drm-tip Acked-by: Dmitry Baryshkov Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_dp_helper.c | 78

Re: [PATCH v3 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-15 Thread Abhinav Kumar
On 2/15/2024 12:40 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 22:15, Abhinav Kumar wrote: On 2/14/2024 11:39 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 20:04, Paloma Arellano wrote: Add support to pack and send the VSC SDP packet for DP. This therefore allows

Re: [PATCH v3 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-15 Thread Abhinav Kumar
On 2/15/2024 12:45 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 20:04, Paloma Arellano wrote: Adjust the encoder format programming in the case of video mode for DP to accommodate CDM related changes. Changes in v2: - Move timing engine programming to a separate patch from

Re: [PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-14 Thread Abhinav Kumar
On 2/14/2024 11:20 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 20:02, Abhinav Kumar wrote: On 2/8/2024 6:50 AM, Dmitry Baryshkov wrote: We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes

Re: [PATCH v3 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-14 Thread Abhinav Kumar
On 2/14/2024 11:39 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 20:04, Paloma Arellano wrote: Add support to pack and send the VSC SDP packet for DP. This therefore allows the transmision of format information to the sinks which is needed for YUV420 support over DP. Changes in v3:

Re: [PATCH v3 03/12] drm/msm/dpu: take plane rotation into account for wide planes

2024-02-14 Thread Abhinav Kumar
On 9/13/2023 10:06 PM, Dmitry Baryshkov wrote: Take into account the plane rotation and flipping when calculating src positions for the wide plane parts. This is not an issue yet, because rotation is only supported for the UBWC planes and wide UBWC planes are rejected anyway because in

Re: [PATCH v3 02/12] drm/msm/dpu: add current resource allocation to dumped state

2024-02-14 Thread Abhinav Kumar
On 9/13/2023 10:06 PM, Dmitry Baryshkov wrote: Provide atomic_print_state callback to the DPU's private object. This way the debugfs/dri/0/state will also include RM's internal state. I like this idea ! Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4

Re: [PATCH v3 01/12] drm/atomic-helper: split not-scaling part of drm_atomic_helper_check_plane_state

2024-02-14 Thread Abhinav Kumar
On 9/13/2023 10:06 PM, Dmitry Baryshkov wrote: The helper drm_atomic_helper_check_plane_state() runs several checks on plane src and dst rectangles, including the check whether required scaling fits into the required margins. The msm driver would benefit from having a function that does all

Re: [PATCH] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-14 Thread Abhinav Kumar
On 2/14/2024 10:02 AM, Ville Syrjälä wrote: On Wed, Feb 14, 2024 at 09:17:34AM -0800, Abhinav Kumar wrote: On 2/14/2024 12:15 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 01:45, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move

Re: [PATCH v2] drm/msm/dpu: make "vblank timeout" more useful

2024-02-14 Thread Abhinav Kumar
On 2/8/2024 6:50 AM, Dmitry Baryshkov wrote: We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. To allow us to identify the DPU block that gets stuck, include the actual CTL_FLUSH value into the timeout

Re: [PATCH] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-14 Thread Abhinav Kumar
On 2/14/2024 12:15 AM, Dmitry Baryshkov wrote: On Wed, 14 Feb 2024 at 01:45, Abhinav Kumar wrote: intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. Signed-off-by: Abhinav Kumar My preference would be to have packing

[PATCH] drm/dp: move intel_dp_vsc_sdp_pack() to generic helper

2024-02-13 Thread Abhinav Kumar
intel_dp_vsc_sdp_pack() can be re-used by other DRM drivers as well. Lets move this to drm_dp_helper to achieve this. Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_dp_helper.c | 78 + drivers/gpu/drm/i915/display/intel_dp.c | 73

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 1:16 PM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 23:10, Abhinav Kumar wrote: On 2/13/2024 11:31 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 20:46, Abhinav Kumar wrote: On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 19:32, Abhinav

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 11:31 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 20:46, Abhinav Kumar wrote: On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar wrote: On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:53, Paloma

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 10:23 AM, Dmitry Baryshkov wrote: On Tue, 13 Feb 2024 at 19:32, Abhinav Kumar wrote: On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:53, Paloma Arellano wrote: Adjust the encoder format programming in the case of video mode for DP to accommodate

Re: drm/msm: DisplayPort regressions in 6.8-rc1

2024-02-13 Thread Abhinav Kumar
Hi Johan Thanks for the report. I do agree that pm runtime eDP driver got merged that time but I think the issue is either a combination of that along with DRM aux bridge https://patchwork.freedesktop.org/series/122584/ OR just the latter as even that went in around the same time. Thats

Re: [PATCH v2 16/19] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-13 Thread Abhinav Kumar
On 2/13/2024 3:18 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:53, Paloma Arellano wrote: Adjust the encoder format programming in the case of video mode for DP to accommodate CDM related changes. Changes in v2: - Move timing engine programming to a separate patch from

Re: [PATCH v2 19/19] drm/msm/dp: allow YUV420 mode for DP connector when CDM available

2024-02-12 Thread Abhinav Kumar
On 2/12/2024 1:20 PM, Dmitry Baryshkov wrote: On Mon, 12 Feb 2024 at 23:13, Abhinav Kumar wrote: On 2/10/2024 1:17 PM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 21:19, Abhinav Kumar wrote: On 2/10/2024 3:33 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma

Re: [PATCH] drm/crtc: fix uninitialized variable use even harder

2024-02-12 Thread Abhinav Kumar
| 1 + 1 file changed, 1 insertion(+) Nice catch !! Reviewed-by: Abhinav Kumar

Re: [PATCH v2 19/19] drm/msm/dp: allow YUV420 mode for DP connector when CDM available

2024-02-12 Thread Abhinav Kumar
On 2/10/2024 1:17 PM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 21:19, Abhinav Kumar wrote: On 2/10/2024 3:33 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: All the components of YUV420 over DP are added. Therefore, let's mark the connector

[PATCH v4] drm/dp: add an API to indicate if sink supports VSC SDP

2024-02-12 Thread Abhinav Kumar
://patchwork.freedesktop.org/series/129180/ Reviewed-by: Dmitry Baryshkov Signed-off-by: Paloma Arellano Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_dp_helper.c | 23 +++ include/drm/display/drm_dp_helper.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/gpu/drm

Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-11 Thread Abhinav Kumar
On 2/10/2024 10:57 PM, Dmitry Baryshkov wrote: On Sun, 11 Feb 2024 at 06:06, Abhinav Kumar wrote: On 2/10/2024 1:46 PM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 20:50, Abhinav Kumar wrote: On 2/10/2024 10:14 AM, Abhinav Kumar wrote: On 2/10/2024 2:09 AM, Dmitry Baryshkov

Re: [PATCH v2 15/19] drm/msm/dp: enable SDP and SDE periph flush update

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 2:11 PM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 23:49, Abhinav Kumar wrote: On 2/10/2024 2:16 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: DP controller can be setup to operate in either SDP update flush mode or peripheral

Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 1:46 PM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 20:50, Abhinav Kumar wrote: On 2/10/2024 10:14 AM, Abhinav Kumar wrote: On 2/10/2024 2:09 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: Add support to pack and send the VSC SDP

Re: [PATCH v2 15/19] drm/msm/dp: enable SDP and SDE periph flush update

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 2:16 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: DP controller can be setup to operate in either SDP update flush mode or peripheral flush mode based on the DP controller hardware version. Starting in DP v1.2, the hardware documents

[PATCH v3] drm/dp: add an API to indicate if sink supports VSC SDP

2024-02-10 Thread Abhinav Kumar
-by: Paloma Arellano Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/display/drm_dp_helper.c | 21 + include/drm/display/drm_dp_helper.h | 1 + 2 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c

Re: [PATCH v2 19/19] drm/msm/dp: allow YUV420 mode for DP connector when CDM available

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 3:33 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: All the components of YUV420 over DP are added. Therefore, let's mark the connector property as true for DP connector when the DP type is not eDP and when there is a CDM block available.

Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 10:14 AM, Abhinav Kumar wrote: On 2/10/2024 2:09 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: Add support to pack and send the VSC SDP packet for DP. This therefore allows the transmision of format information to the sinks which is needed

Re: [PATCH v2 13/19] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-10 Thread Abhinav Kumar
On 2/10/2024 2:09 AM, Dmitry Baryshkov wrote: On Sat, 10 Feb 2024 at 03:52, Paloma Arellano wrote: Add support to pack and send the VSC SDP packet for DP. This therefore allows the transmision of format information to the sinks which is needed for YUV420 support over DP. Changes in v2:

Re: [PATCH RESEND 5/5] drm/msm/mdp5: drop global_state_lock

2024-02-09 Thread Abhinav Kumar
Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 8 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 1 - 2 files changed, 9 deletions(-) Reviewed-by: Abhinav Kumar

Re: [PATCH RESEND 4/5] drm/msm/mdp5: migrate SMP dumping to using atomic_print_state

2024-02-09 Thread Abhinav Kumar
changed, 15 insertions(+), 49 deletions(-) Nice cleanup ! Reviewed-by: Abhinav Kumar

Re: [PATCH RESEND 3/5] drm/msm/dpu: drop global_state_lock

2024-02-09 Thread Abhinav Kumar
Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 - 2 files changed, 9 deletions(-) Reviewed-by: Abhinav Kumar

Re: [PATCH RESEND 2/5] drm/msm/dpu: finalise global state object

2024-02-09 Thread Abhinav Kumar
changed, 8 insertions(+) Reviewed-by: Abhinav Kumar

Re: [PATCH v4 2/4] drm/msm/dpu: support binding to the mdp5 devices

2024-02-09 Thread Abhinav Kumar
version of msm_ioremap_mdss for vbif_nrt_phys? Anyway, its not something to block this change. Hence, Reviewed-by: Abhinav Kumar

Re: [PATCH v4 1/4] drm/msm/mdss: generate MDSS data for MDP5 platforms

2024-02-09 Thread Abhinav Kumar
++ 1 file changed, 51 insertions(+) Reviewed-by: Abhinav Kumar

Re: [PATCH v4 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

2024-02-08 Thread Abhinav Kumar
insertions(+), 59 deletions(-) + + crtc = conn_state->crtc; + if (!crtc) + return 0; + This should fix the crash and rest of the change LGTM Reviewed-by: Abhinav Kumar Please give us a couple of days to re-test this and give our Tested-by as we plan to rebase

Re: [PATCH v4] drm/msm/dsi: Document DSC related pclk_rate and hdisplay calculations

2024-02-08 Thread Abhinav Kumar
msm/dsi/dsi_host.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) Reviewed-by: Abhinav Kumar

Re: [PATCH 3/5] drm/msm: mdss: Add X1E80100 support

2024-02-08 Thread Abhinav Kumar
On 2/8/2024 5:46 AM, Abel Vesa wrote: On 24-02-08 15:42:04, Dmitry Baryshkov wrote: On Thu, 8 Feb 2024 at 15:37, Abel Vesa wrote: On 24-01-29 17:11:25, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 15:19, Abel Vesa wrote: Add support for MDSS on X1E80100. Signed-off-by: Abel Vesa

Re: [PATCH v3 2/4] drm/msm/dpu: support binding to the mdp5 devices

2024-02-07 Thread Abhinav Kumar
On 2/7/2024 11:56 AM, Dmitry Baryshkov wrote: On Wed, 7 Feb 2024 at 20:48, Abhinav Kumar wrote: On 1/5/2024 3:34 PM, Dmitry Baryshkov wrote: Existing MDP5 devices have slightly different bindings. The main register region is called `mdp_phys' instead of `mdp'. Also vbif register regions

Re: [PATCH v3 4/4] drm/msm/dpu: add support for SDM660 and SDM630 platforms

2024-02-07 Thread Abhinav Kumar
but certainly not all, but based on whatever I checked all the entries were correct in the catalog. Reviewed-by: Abhinav Kumar

Re: [PATCH v3 3/4] drm/msm: add a kernel param to select between MDP5 and DPU drivers

2024-02-07 Thread Abhinav Kumar
platforms supported by both drivers are by default handled by the MDP5 driver. To let them be handled by the DPU driver pass the `msm.prefer_mdp5=false` kernel param. Reviewed-by: Stephen Boyd Signed-off-by: Dmitry Baryshkov --- Reviewed-by: Abhinav Kumar

Re: [PATCH v3 2/4] drm/msm/dpu: support binding to the mdp5 devices

2024-02-07 Thread Abhinav Kumar
On 1/5/2024 3:34 PM, Dmitry Baryshkov wrote: Existing MDP5 devices have slightly different bindings. The main register region is called `mdp_phys' instead of `mdp'. Also vbif register regions are a part of the parent, MDSS device. Add support for handling this binding differences.

Re: [PATCH v3 1/4] drm/msm/mdss: generate MDSS data for MDP5 platforms

2024-02-07 Thread Abhinav Kumar
On 1/5/2024 3:34 PM, Dmitry Baryshkov wrote: Older (mdp5) platforms do not use per-SoC compatible strings. Instead they use a single compat entry 'qcom,mdss'. To facilitate migrating these platforms to the DPU driver provide a way to generate the MDSS / UBWC data at runtime, when the DPU

Re: [PATCH v2] drm/msm/dpu: remove CRTC frame event callback registration

2024-02-07 Thread Abhinav Kumar
On 10/5/2023 3:06 PM, Dmitry Baryshkov wrote: The frame event callback is always set to dpu_crtc_frame_event_cb() (or to NULL) and the data is always either the CRTC itself or NULL (correpondingly). Thus drop the event callback registration, call the dpu_crtc_frame_event_cb() directly and

Re: [PATCH] dt-bindings: drm/bridge: ti-sn65dsi86: Fix bouncing @codeaurora address

2024-02-02 Thread Abhinav Kumar
up to maintain this Reviewed-by: Abhinav Kumar --- .../devicetree/bindings/display/bridge/ti,sn65dsi86.yaml| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display

Re: [PATCH 11/17] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-02-01 Thread Abhinav Kumar
On 1/31/2024 8:36 PM, Dmitry Baryshkov wrote: On Thu, 1 Feb 2024 at 03:56, Abhinav Kumar wrote: On 1/27/2024 9:39 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:34, Paloma Arellano wrote: On 1/25/2024 1:48 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-02-01 Thread Abhinav Kumar
On 1/31/2024 7:17 PM, Dmitry Baryshkov wrote: On Thu, 1 Feb 2024 at 03:30, Abhinav Kumar wrote: On 1/29/2024 3:44 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 09:08, Abhinav Kumar wrote: On 1/28/2024 10:12 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 07:03, Abhinav Kumar

Re: [PATCH 11/17] drm/msm/dp: add VSC SDP support for YUV420 over DP

2024-01-31 Thread Abhinav Kumar
On 1/27/2024 9:39 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:34, Paloma Arellano wrote: On 1/25/2024 1:48 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: Add support to pack and send the VSC SDP packet for DP. This therefore allows the transmision of

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-31 Thread Abhinav Kumar
On 1/29/2024 3:44 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 09:08, Abhinav Kumar wrote: On 1/28/2024 10:12 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 07:03, Abhinav Kumar wrote: On 1/28/2024 7:42 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 04:58, Abhinav

Re: [PATCH] drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

2024-01-31 Thread Abhinav Kumar
On 1/31/2024 5:05 PM, Dmitry Baryshkov wrote: On Thu, 1 Feb 2024 at 02:48, Abhinav Kumar wrote: Currently INTF_CFG2_DATA_HCTL_EN is coupled with the enablement of widebus but this is incorrect because we should be enabling this bit independent of widebus except for cases where compression

[PATCH] drm/msm/dpu: fix the programming of INTF_CFG2_DATA_HCTL_EN

2024-01-31 Thread Abhinav Kumar
and enabling INTF_CFG2_DATA_HCTL_EN for all other cases when supported by DPU. Fixes: 3309a7563971 ("drm/msm/dpu: revise timing engine programming to support widebus feature") Suggested-by: Dmitry Baryshkov Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c

Re: [PATCH 07/17] drm/msm/dpu: disallow widebus en in INTF_CONFIG2 when DP is YUV420

2024-01-29 Thread Abhinav Kumar
On 1/29/2024 9:28 PM, Dmitry Baryshkov wrote: On Tue, 30 Jan 2024 at 06:10, Abhinav Kumar wrote: On 1/29/2024 5:43 PM, Dmitry Baryshkov wrote: On Tue, 30 Jan 2024 at 03:07, Abhinav Kumar wrote: On 1/29/2024 4:03 PM, Dmitry Baryshkov wrote: On Tue, 30 Jan 2024 at 01:51, Abhinav

Re: [PATCH 07/17] drm/msm/dpu: disallow widebus en in INTF_CONFIG2 when DP is YUV420

2024-01-29 Thread Abhinav Kumar
On 1/29/2024 5:43 PM, Dmitry Baryshkov wrote: On Tue, 30 Jan 2024 at 03:07, Abhinav Kumar wrote: On 1/29/2024 4:03 PM, Dmitry Baryshkov wrote: On Tue, 30 Jan 2024 at 01:51, Abhinav Kumar wrote: On 1/27/2024 9:33 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:16, Paloma

Re: [PATCH 07/17] drm/msm/dpu: disallow widebus en in INTF_CONFIG2 when DP is YUV420

2024-01-29 Thread Abhinav Kumar
On 1/29/2024 4:03 PM, Dmitry Baryshkov wrote: On Tue, 30 Jan 2024 at 01:51, Abhinav Kumar wrote: On 1/27/2024 9:33 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:16, Paloma Arellano wrote: On 1/25/2024 1:26 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano

Re: [PATCH 07/17] drm/msm/dpu: disallow widebus en in INTF_CONFIG2 when DP is YUV420

2024-01-29 Thread Abhinav Kumar
On 1/27/2024 9:33 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:16, Paloma Arellano wrote: On 1/25/2024 1:26 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: INTF_CONFIG2 register cannot have widebus enabled when DP format is YUV420. Therefore, program the

Re: [PATCH RFC 0/4] Support for Simulated Panels

2024-01-29 Thread Abhinav Kumar
Hi Maxime On 1/26/2024 4:45 AM, Maxime Ripard wrote: On Wed, Jan 17, 2024 at 09:36:20AM -0800, Abhinav Kumar wrote: Hi Jani and Maxime On 1/17/2024 2:16 AM, Jani Nikula wrote: On Wed, 17 Jan 2024, Maxime Ripard wrote: Hi, On Tue, Jan 16, 2024 at 02:22:03PM -0800, Jessica Zhang wrote

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 10:12 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 07:03, Abhinav Kumar wrote: On 1/28/2024 7:42 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 04:58, Abhinav Kumar wrote: On 1/27/2024 9:55 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:48, Paloma

Re: [PATCH 17/17] drm/msm/dp: allow YUV420 mode for DP connector when VSC SDP supported

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 9:05 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 06:30, Abhinav Kumar wrote: On 1/28/2024 7:52 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 05:17, Abhinav Kumar wrote: On 1/25/2024 2:05 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 7:42 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 04:58, Abhinav Kumar wrote: On 1/27/2024 9:55 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:48, Paloma Arellano wrote: On 1/25/2024 1:57 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano

Re: [PATCH 01/17] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 8:12 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 06:01, Abhinav Kumar wrote: On 1/28/2024 7:23 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 05:06, Abhinav Kumar wrote: On 1/26/2024 4:39 PM, Paloma Arellano wrote: On 1/25/2024 1:14 PM, Dmitry Baryshkov

Re: [PATCH 17/17] drm/msm/dp: allow YUV420 mode for DP connector when VSC SDP supported

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 7:52 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 05:17, Abhinav Kumar wrote: On 1/25/2024 2:05 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: All the components of YUV420 over DP are added. Therefore, let's mark the connector property

Re: [PATCH 01/17] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-01-28 Thread Abhinav Kumar
On 1/28/2024 7:23 PM, Dmitry Baryshkov wrote: On Mon, 29 Jan 2024 at 05:06, Abhinav Kumar wrote: On 1/26/2024 4:39 PM, Paloma Arellano wrote: On 1/25/2024 1:14 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: Generalize dpu_encoder_helper_phys_setup_cdm

Re: [PATCH 17/17] drm/msm/dp: allow YUV420 mode for DP connector when VSC SDP supported

2024-01-28 Thread Abhinav Kumar
On 1/25/2024 2:05 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: All the components of YUV420 over DP are added. Therefore, let's mark the connector property as true for DP connector when the DP type is not eDP and when VSC SDP is supported. Signed-off-by: Paloma

Re: [PATCH 01/17] drm/msm/dpu: allow dpu_encoder_helper_phys_setup_cdm to work for DP

2024-01-28 Thread Abhinav Kumar
On 1/26/2024 4:39 PM, Paloma Arellano wrote: On 1/25/2024 1:14 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: Generalize dpu_encoder_helper_phys_setup_cdm to be compatible with DP. Signed-off-by: Paloma Arellano ---   .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h 

Re: [PATCH 14/17] drm/msm/dpu: modify encoder programming for CDM over DP

2024-01-28 Thread Abhinav Kumar
On 1/27/2024 9:55 PM, Dmitry Baryshkov wrote: On Sun, 28 Jan 2024 at 07:48, Paloma Arellano wrote: On 1/25/2024 1:57 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: Adjust the encoder format programming in the case of video mode for DP to accommodate CDM related

Re: [PATCH 05/17] drm/msm/dp: add an API to indicate if sink supports VSC SDP

2024-01-26 Thread Abhinav Kumar
On 1/26/2024 6:40 PM, Dmitry Baryshkov wrote: On Sat, 27 Jan 2024 at 02:58, Paloma Arellano wrote: On 1/25/2024 1:23 PM, Dmitry Baryshkov wrote: On 25/01/2024 21:38, Paloma Arellano wrote: YUV420 format is supported only in the VSC SDP packet and not through MSA. Hence add an API which

Re: [PATCH] drm/msm/dpu: make "vblank timeout" more useful

2024-01-25 Thread Abhinav Kumar
On 1/5/2024 3:50 PM, Dmitry Baryshkov wrote: We have several reports of vblank timeout messages. However after some debugging it was found that there might be different causes to that. Include the actual CTL_FLUSH value into the timeout message. This allows us to identify the DPU block that

Re: [PATCH v1] drm/msms/dp: fixed link clock divider bits be over written in BPC unknown case

2024-01-24 Thread Abhinav Kumar
On 1/10/2024 12:18 PM, Kuogee Hsieh wrote: Since the value of DP_TEST_BIT_DEPTH_8 is already left shifted, in the BPC unknown case, the additional shift causes spill over to the other bits of the [DP_CONFIGURATION_CTRL] register. Fix this by changing the return value of

Re: [PATCH] drm/msm/dpu: fix kernel-doc warnings

2024-01-24 Thread Abhinav Kumar
' Signed-off-by: Randy Dunlap Cc: Rob Clark Cc: Abhinav Kumar Cc: Dmitry Baryshkov Cc: Sean Paul Cc: Marijn Suijten Cc: linux-arm-...@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedr...@lists.freedesktop.org Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc

Re: [PATCH] drm/msm/dpu: drop obsolete documentation for dpu_encoder_virt

2024-01-24 Thread Abhinav Kumar
On 12/18/2023 9:57 AM, Abhinav Kumar wrote: On 12/16/2023 4:01 PM, Dmitry Baryshkov wrote: Drop obsolete kerneldoc for several fields in struct dpu_encoder_virt Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312170641.5exlvqqx-...@intel.com/ Fixes

Re: [PATCH v3 4/5] drm/msm/dpu: move writeback's atomic_check to dpu_writeback.c

2024-01-23 Thread Abhinav Kumar
On 12/25/2023 5:08 AM, Dmitry Baryshkov wrote: dpu_encoder_phys_wb is the only user of encoder's atomic_check callback. Move corresponding checks to drm_writeback_connector's implementation and drop the dpu_encoder_phys_wb_atomic_check() function. Signed-off-by: Dmitry Baryshkov ---

[PATCH] drm/msm/dpu: check for valid hw_pp in dpu_encoder_helper_phys_cleanup

2024-01-17 Thread Abhinav Kumar
the other conditional block by making sure hw_pp is valid before dereferencing it. Reported-by: Dan Carpenter Fixes: ae4d721ce100 ("drm/msm/dpu: add an API to reset the encoder related hw blocks") Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 4 ++-

Re: [PATCH RFC 0/4] Support for Simulated Panels

2024-01-17 Thread Abhinav Kumar
Hi Jani and Maxime On 1/17/2024 2:16 AM, Jani Nikula wrote: On Wed, 17 Jan 2024, Maxime Ripard wrote: Hi, On Tue, Jan 16, 2024 at 02:22:03PM -0800, Jessica Zhang wrote: This series introduces a simulated MIPI DSI panel. Currently, the only way to validate DSI connectors is with a physical

Re: [PATCH v1] drm/msm/dp: remove mdss_dp_test_bit_depth_to_bpc()

2024-01-11 Thread Abhinav Kumar
files changed, 1 insertion(+), 24 deletions(-) Reviewed-by: Abhinav Kumar

Re: [PATCH v1] drm/msms/dp: fixed link clock divider bits be over written in BPC unknown case

2024-01-10 Thread Abhinav Kumar
2 files changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Abhinav Kumar

Re: [PATCH 5/5] drm/msm/mdp5: drop split display support

2024-01-10 Thread Abhinav Kumar
. If someone wants to add that support, I guess they have to start by reverting this commit first. If thats the plan and agreement, Reviewed-by: Abhinav Kumar

Re: [PATCH 4/5] drm/msm/dsi: remove msm_dsi::encoder

2024-01-10 Thread Abhinav Kumar
++ drivers/gpu/drm/msm/dsi/dsi_manager.c | 8 +++- 3 files changed, 6 insertions(+), 12 deletions(-) Reviewed-by: Abhinav Kumar

Re: [PATCH 3/5] drm/msm/dsi: stop calling set_split_display

2024-01-10 Thread Abhinav Kumar
s changed, 40 deletions(-) Reviewed-by: Abhinav Kumar

Re: [PATCH 2/5] drm/msm/dsi: drop msm_dsi_device_connected() function

2024-01-10 Thread Abhinav Kumar
Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dsi/dsi.h | 6 -- drivers/gpu/drm/msm/dsi/dsi_manager.c | 5 - 2 files changed, 11 deletions(-) Reviewed-by: Abhinav Kumar

Re: [PATCH 1/5] drm/msm/dsi: do not store internal bridge pointer

2024-01-10 Thread Abhinav Kumar
| 8 +--- drivers/gpu/drm/msm/dsi/dsi.h | 7 ++- drivers/gpu/drm/msm/dsi/dsi_manager.c | 19 --- 3 files changed, 15 insertions(+), 19 deletions(-) Reviewed-by: Abhinav Kumar

Re: [PATCH] drm/ci: Add msm tests

2024-01-09 Thread Abhinav Kumar
On 1/9/2024 7:31 AM, Rob Clark wrote: On Mon, Jan 8, 2024 at 6:13 PM Rob Clark wrote: On Mon, Jan 8, 2024 at 2:58 PM Abhinav Kumar wrote: On 1/8/2024 11:50 AM, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-msm hw, so I think it should be safe to enable

Re: [PATCH] drm/ci: Add msm tests

2024-01-08 Thread Abhinav Kumar
On 1/8/2024 11:50 AM, Rob Clark wrote: From: Rob Clark The msm tests should skip on non-msm hw, so I think it should be safe to enable everywhere. Signed-off-by: Rob Clark --- drivers/gpu/drm/ci/testlist.txt | 49 + 1 file changed, 49 insertions(+) I

Re: [PATCH v3 0/5] drm/msm/dpu: remove dpu_encoder_phys_ops::atomic_mode_set callback

2024-01-08 Thread Abhinav Kumar
On 12/25/2023 5:08 AM, Dmitry Baryshkov wrote: The dpu_encoder_phys_ops::atomic_mode_set() callback is mostly redundant. Implementations only set the IRQ indices there. Move statically allocated IRQs to dpu_encoder_phys_*_init() and set dynamically allocated IRQs in the irq_enable() callback.

<    1   2   3   4   5   6   7   8   9   10   >