to be added back when features such as
autorefresh get added. But, as usual, we go by what in the driver today
so I am aware that this will be a lost argument.
Hence,
Reviewed-by: Abhinav Kumar
On 12/4/2023 9:57 AM, Simon Ser wrote:
On Monday, December 4th, 2023 at 18:51, Abhinav Kumar
wrote:
Where are the IGT and userspace for this uAPI addition?
Yes, we made IGT changes to test and validate this. We will post them on
the IGT dev list shortly and CC you.
We do not have
Hi Simon
On 12/3/2023 4:15 AM, Simon Ser wrote:
On Saturday, December 2nd, 2023 at 22:41, Dmitry Baryshkov
wrote:
On Fri, 27 Oct 2023 15:32:50 -0700, Jessica Zhang wrote:
Some drivers support hardware that have optimizations for solid fill
planes. This series aims to expose these
On 12/3/2023 10:14 AM, Dmitry Baryshkov wrote:
On Sun, 3 Dec 2023 at 16:24, Laurent Pinchart
wrote:
Hi Abhinav,
Thank you for the patch (and thank to Dmitry for pinging me on IRC, this
patch got burried in my inbox).
On Wed, Sep 20, 2023 at 01:13:58PM -0700, Abhinav Kumar wrote:
While
On 7/7/2023 6:03 PM, Dmitry Baryshkov wrote:
MDP4 and MDP5 drivers enumerate supported formats each time the plane is
created. As the list of supported image formats is constant, create
corresponding data arrays to be used by MDP4 and MDP5 drivers.
Signed-off-by: Dmitry Baryshkov
---
On 12/1/2023 5:25 PM, Abhinav Kumar wrote:
On 7/7/2023 6:04 PM, Dmitry Baryshkov wrote:
Drop the function mdp_get_formats(), which became unused after
converting both MDP4 and MDP5 planes to use static formats arrays.
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp
/gpu/drm/msm/disp/mdp_kms.h| 1 -
2 files changed, 25 deletions(-)
Reviewed-by: Abhinav Kumar
file changed, 20 insertions(+), 39 deletions(-)
Reviewed-by: Abhinav Kumar
---
1 file changed, 7 insertions(+), 29 deletions(-)
Reviewed-by: Abhinav Kumar
---
1 file changed, 7 insertions(+), 30 deletions(-)
Reviewed-by: Abhinav Kumar
+++
1 file changed, 5 insertions(+), 27 deletions(-)
Reviewed-by: Abhinav Kumar
changed, 17 insertions(+), 16 deletions(-)
Reviewed-by: Abhinav Kumar
deletions(-)
Reviewed-by: Abhinav Kumar
file changed, 6 insertions(+), 34 deletions(-)
Reviewed-by: Abhinav Kumar
+++-
1 file changed, 4 insertions(+), 25 deletions(-)
Reviewed-by: Abhinav Kumar
changed, 15 insertions(+), 15 deletions(-)
Reviewed-by: Abhinav Kumar
(-)
Reviewed-by: Abhinav Kumar
/mdp5/mdp5_smp.c | 19 ---
drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.h | 1 -
3 files changed, 4 insertions(+), 19 deletions(-)
Reviewed-by: Abhinav Kumar
/disp/mdp5/mdp5_pipe.c | 10 +++---
drivers/gpu/drm/msm/disp/mdp5/mdp5_pipe.h | 4 ++--
3 files changed, 6 insertions(+), 14 deletions(-)
Reviewed-by: Abhinav Kumar
/msm/disp/mdp5/mdp5_mixer.c | 10 +++---
drivers/gpu/drm/msm/disp/mdp5/mdp5_mixer.h | 4 ++--
3 files changed, 6 insertions(+), 13 deletions(-)
Reviewed-by: Abhinav Kumar
-
drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.h | 1 -
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 --
3 files changed, 4 insertions(+), 20 deletions(-)
Reviewed-by: Abhinav Kumar
On 7/7/2023 6:03 PM, Dmitry Baryshkov wrote:
Use devm_kzalloc to create CTL manager data structure. This allows us
to remove corresponding kfree and drop mdp5_ctlm_destroy() function.
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
+---
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.h | 1 -
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 --
3 files changed, 5 insertions(+), 22 deletions(-)
Reviewed-by: Abhinav Kumar
On 11/30/2023 11:36 PM, Dmitry Baryshkov wrote:
On Fri, 1 Dec 2023 at 03:31, Jessica Zhang wrote:
Set the input_sel bit for encoders as it was missed in the initial
implementation.
Reported-by: Rob Clark
Fixes: 91143873a05d ("drm/msm/dpu: Add MISR register support for interface")
Closes:
On 12/1/2023 8:22 AM, Bjorn Andersson wrote:
On Fri, Dec 01, 2023 at 10:34:50AM +0200, Dmitry Baryshkov wrote:
On Fri, 1 Dec 2023 at 05:47, Bjorn Andersson wrote:
On Thu, Nov 30, 2023 at 05:40:55PM -0800, Paloma Arellano wrote:
[..]
@@ -2386,6 +2390,7 @@ struct drm_encoder
On 11/30/2023 11:45 PM, Dmitry Baryshkov wrote:
On Fri, 1 Dec 2023 at 03:41, Paloma Arellano wrote:
When the irq callback returns a value other than zero,
modify vblank_refcount by performing the inverse
operation of its corresponding if-else condition.
I think it might be better to
On 11/30/2023 11:20 PM, Dmitry Baryshkov wrote:
On Fri, 1 Dec 2023 at 02:41, Abhinav Kumar wrote:
On 8/30/2023 5:11 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
Add an API dpu_encoder_helper_phys_setup_cdm() which can be used by
the writeback encoder
On 11/30/2023 11:05 PM, Dmitry Baryshkov wrote:
On Fri, 1 Dec 2023 at 01:36, Abhinav Kumar wrote:
On 8/30/2023 5:00 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
CDM block comes with its own set of registers and operations
which can be done. In-line
On 8/30/2023 5:24 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
On chipsets where CDM block is not available OR where support has
not been added yet do not allow YUV formats for writeback block.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp
On 8/30/2023 5:23 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
Reserve CDM blocks for writeback if the format of the output fb
is YUV. At the moment, the reservation is done only for writeback
but can easily be extended by relaxing the checks once other
On 8/30/2023 5:11 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
Add an API dpu_encoder_helper_phys_setup_cdm() which can be used by
the writeback encoder to setup the CDM block.
Currently, this is defined and used within the writeback's physical
encoder
On 8/30/2023 5:14 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
In preparation of setting up CDM block, add the logic to disable it
properly during encoder cleanup.
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8
On 8/30/2023 5:12 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
CDM block will need its own logic to program the flush and active
bits in the dpu_hw_ctl layer.
Make necessary changes in dpu_hw_ctl to support CDM programming.
Signed-off-by: Abhinav Kumar
On 8/30/2023 5:06 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
Even though there is usually only one CDM block, it can be
used by either HDMI, DisplayPort OR Writeback interfaces.
Hence its allocation needs to be tracked properly by the
resource manager
On 8/30/2023 4:48 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
Add the RM APIs necessary to initialize and allocate CDM
blocks by the rest of the DPU pipeline.
... to be used by the rest?
Yes, thanks.
Signed-off-by: Abhinav Kumar
---
drivers
On 8/30/2023 5:00 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar wrote:
CDM block comes with its own set of registers and operations
which can be done. In-line with other hardware sub-blocks, this
change adds the dpu_hw_cdm abstraction for the CDM block.
Signed
in dpu_encoder_virt
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202312010225.2ojwlkma-...@intel.com/
Reviewed-by: Dmitry Baryshkov
Signed-off-by: Paloma Arellano
Reviewed-by: Abhinav Kumar
On 8/30/2023 3:57 PM, Dmitry Baryshkov wrote:
On Thu, 31 Aug 2023 at 01:49, Abhinav Kumar wrote:
Add CDM blocks to the sc7280 dpu_hw_catalog to support
YUV format output from writeback block.
Signed-off-by: Abhinav Kumar
---
.../gpu/drm/msm/disp/dpu1/catalog/dpu_7_2_sc7280.h | 9
: Fix reg values for a690")
Signed-off-by: Rob Clark
---
Reviewed-by: Abhinav Kumar
On 11/27/2023 3:17 PM, Dmitry Baryshkov wrote:
On Tue, 28 Nov 2023 at 00:00, Abhinav Kumar wrote:
On 11/27/2023 1:54 PM, Dmitry Baryshkov wrote:
Flush queued events when disabling the crtc. This avoids timeouts when
we come back and wait for dependencies (like the previous frame's
On 11/27/2023 1:54 PM, Dmitry Baryshkov wrote:
Flush queued events when disabling the crtc. This avoids timeouts when
we come back and wait for dependencies (like the previous frame's
flip_done).
Fixes: c8afe684c95c ("drm/msm: basic KMS driver for snapdragon")
Signed-off-by: Dmitry Baryshkov
On 11/21/2023 4:27 PM, Rob Clark wrote:
On Tue, Nov 21, 2023 at 4:41 PM Abhinav Kumar wrote:
On 10/24/2023 12:01 PM, Abhinav Kumar wrote:
On 10/23/2023 4:03 PM, Dmitry Baryshkov wrote:
On Tue, 24 Oct 2023 at 01:36, Rob Clark wrote:
On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov
On 10/24/2023 12:01 PM, Abhinav Kumar wrote:
On 10/23/2023 4:03 PM, Dmitry Baryshkov wrote:
On Tue, 24 Oct 2023 at 01:36, Rob Clark wrote:
On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov
wrote:
On Tue, 24 Oct 2023 at 01:12, Rob Clark wrote:
From: Rob Clark
Seems like we need
On 11/21/2023 9:57 AM, Linux regression tracking (Thorsten Leemhuis) wrote:
On 15.11.23 19:06, Abhinav Kumar wrote:
On 11/15/2023 12:06 AM, Johan Hovold wrote:
On Wed, Oct 25, 2023 at 12:23:10PM +0300, Dmitry Baryshkov wrote:
While developing and testing the commit bfcc3d8f94f4 ("dr
dp5_init() warn:
> variable dereferenced before check 'mdp5_kms' (see line 782)
>
> [...]
Applied, thanks!
[1/1] drm/msm: remove unnecessary NULL check
https://gitlab.freedesktop.org/drm/msm/-/commit/56466f653cb5
Best regards,
--
Abhinav Kumar
top.org/drm/msm/-/commit/21133266ca12
Best regards,
--
Abhinav Kumar
disabled and a significant boost in throughput.
>
> [...]
Applied, thanks!
[1/1] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog
https://gitlab.freedesktop.org/drm/msm/-/commit/a33b2431d11b
Best regards,
--
Abhinav Kumar
op this call, as
> there is a correctly guarded one next to the one being removed.
>
>
Applied, thanks!
[1/1] drm/msm: remove exra drm_kms_helper_poll_init() call
https://gitlab.freedesktop.org/drm/msm/-/commit/3944e343e54b
Best regards,
--
Abhinav Kumar
ktop.org/drm/msm/-/commit/b3e0f94d1570
Best regards,
--
Abhinav Kumar
change this number everytime we add a new KMS property.
Reviewed-by: Harry Wentland
Reviewed-by: Simon Ser
Signed-off-by: Melissa Wen
Reviewed-by: Abhinav Kumar
---
include/drm/drm_mode_object.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm
On 11/1/2023 12:23 PM, Abhinav Kumar wrote:
On 10/13/2023 1:25 AM, Dan Carpenter wrote:
This NULL check was required when it was added, but we shuffled the code
around and now it's not. The inconsistent NULL checking triggers a
Smatch warning:
drivers/gpu/drm/msm/disp/mdp5
On 11/16/2023 12:36 PM, Abhinav Kumar wrote:
On 11/9/2023 4:02 PM, Jonathan Marek wrote:
Use the same value as the downstream driver. This change is needed for
CPHY
mode to work correctly.
Fixes: 8b034e6771113 ("drm/msm/dsi: add support for DSI-PHY on SM8550")
One error her
rivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Good catch !
LGTM
Reviewed-by: Abhinav Kumar
diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
b/drivers/gpu/drm/msm/dsi/phy/dsi_phy_7nm.c
index 3b1ed02f644d..89a6344bc865 100644
--- a/drive
On 11/15/2023 2:44 PM, Rob Clark wrote:
From: Rob Clark
The dpu devcore's are already associated with the dpu device. So we
should associate the gpu devcore's with the gpu device, for easier
classification.
Signed-off-by: Rob Clark
Reviewed-by: Abhinav Kumar
: 4a352c2fc15a ("drm/msm/dpu: Introduce SC8280XP")
Cc: sta...@vger.kernel.org
Suggested-by: Doug Anderson
Suggested-by: Rob Clark
Signed-off-by: Bjorn Andersson
---
Matches what we have in downstream DT, hence
Reviewed-by: Abhinav Kumar
drivers/gpu/drm/msm/disp/dp
t_add+0x14/0x20
dp_display_probe+0x278/0x41c [msm]
[1] https://patchwork.freedesktop.org/patch/30/
Fixes: bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type")
Reviewed-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
Reviewed-by: Johan Hovold
Tes
On 11/8/2023 10:10 AM, Kuogee Hsieh wrote:
On 11/7/2023 1:23 PM, Dmitry Baryshkov wrote:
On Tue, 7 Nov 2023 at 23:01, Kuogee Hsieh
wrote:
On 11/6/2023 5:55 PM, Dmitry Baryshkov wrote:
On Sat, 7 Oct 2023 at 01:55, Kuogee Hsieh
wrote:
The purpose of this patch series is to incorporate pm
one next to the one being removed.
Fixes: 506efcba3129 ("drm/msm: carve out KMS code from msm_drv.c")
Signed-off-by: Dmitry Baryshkov
---
Reviewed-by: Abhinav Kumar
On 11/6/2023 2:11 PM, Dmitry Baryshkov wrote:
On Mon, 6 Nov 2023 at 20:39, Abhinav Kumar wrote:
Sorry for the delay in getting back on this. There was quite a bit of
history digging I had to do myself to give a certain response.
On 10/9/2023 10:11 AM, Dmitry Baryshkov wrote:
On sc7280
Sorry for the delay in getting back on this. There was quite a bit of
history digging I had to do myself to give a certain response.
On 10/9/2023 10:11 AM, Dmitry Baryshkov wrote:
On sc7280 there are two clk bits for WB2: control and status. While
programming the VBIF params of WB, the driver
On 11/1/2023 2:23 PM, Dmitry Baryshkov wrote:
On Wed, 1 Nov 2023 at 21:56, Abhinav Kumar wrote:
On 11/1/2023 12:39 PM, Dmitry Baryshkov wrote:
On Wed, 1 Nov 2023 at 20:43, Abhinav Kumar wrote:
On 10/31/2023 1:19 AM, Dmitry Baryshkov wrote:
On Mon, 30 Oct 2023 at 22:24, Abhinav
On 11/1/2023 12:39 PM, Dmitry Baryshkov wrote:
On Wed, 1 Nov 2023 at 20:43, Abhinav Kumar wrote:
On 10/31/2023 1:19 AM, Dmitry Baryshkov wrote:
On Mon, 30 Oct 2023 at 22:24, Abhinav Kumar wrote:
On 10/6/2023 6:14 AM, Dmitry Baryshkov wrote:
Three different features
ile changed, 8 insertions(+), 8 deletions(-)
Assuming that someone has already validated OR will validate this,
Reviewed-by: Abhinav Kumar
perspective
it makes sense to tie them together.
Plus everyone introduces bugs. If you're not introducing bugs, then
you're probably not writing a lot of code.
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
LGTM,
Reviewed-by: Abhinav Kumar
On 10/31/2023 1:19 AM, Dmitry Baryshkov wrote:
On Mon, 30 Oct 2023 at 22:24, Abhinav Kumar wrote:
On 10/6/2023 6:14 AM, Dmitry Baryshkov wrote:
Three different features, DPU_SSPP_SCALER_QSEED3, QSEED3LITE and QSEED4
are all related to different versions of the same HW scaling block
On 10/31/2023 1:16 AM, Dmitry Baryshkov wrote:
On Mon, 30 Oct 2023 at 21:52, Abhinav Kumar wrote:
On 10/6/2023 6:14 AM, Dmitry Baryshkov wrote:
As we have dropped the variadic parts of SSPP sub-blocks declarations,
deduplicate them now, reducing memory cruft.
Signed-off-by: Dmitry
On 10/6/2023 6:14 AM, Dmitry Baryshkov wrote:
Three different features, DPU_SSPP_SCALER_QSEED3, QSEED3LITE and QSEED4
are all related to different versions of the same HW scaling block.
Corresponding driver parts use scaler_blk.version to identify the
correct way to program the hardware. In
in order to be able to drop those
two macros.
funcion ---> function
Suggested-by: Abhinav Kumar
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h | 15 ---
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 4 ++--
2 files changed, 2 insertions(+),
On 10/6/2023 6:14 AM, Dmitry Baryshkov wrote:
As we have dropped the variadic parts of SSPP sub-blocks declarations,
deduplicate them now, reducing memory cruft.
Signed-off-by: Dmitry Baryshkov
---
.../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 16 +--
disconnect places preferably in
dp_display_send_hpd_notification().
That way, we would have had to make this change only in one location.
If you want to pursue that as a separate patch, I am fine as well.
Hence,
Reviewed-by: Abhinav Kumar
On 10/23/2023 4:03 PM, Dmitry Baryshkov wrote:
On Tue, 24 Oct 2023 at 01:36, Rob Clark wrote:
On Mon, Oct 23, 2023 at 3:30 PM Dmitry Baryshkov
wrote:
On Tue, 24 Oct 2023 at 01:12, Rob Clark wrote:
From: Rob Clark
Seems like we need to pick INPUT_SEL=1 when CTM is enabled. But not
that support,
Hence,
Reviewed-by: Abhinav Kumar
Overall, nice cleanup!
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 ---
drivers/gpu/drm/msm/dp/dp_debug.c | 69 ++---
drivers/gpu/drm/msm/dp/dp_debug.h | 23 +++--
drivers/gpu/drm/msm/dp/dp_display.c | 5
drm/msm/dp/dp_display.c:604)
hpd_event_thread (drivers/gpu/drm/msm/dp/dp_display.c:1110)
kthread (kernel/kthread.c:388)
ret_from_fork (arch/arm64/kernel/entry.S:858)
Fixes: bfcc3d8f94f4 ("drm/msm/dp: support setting the DP subconnector type")
Signed-off-by: Dmitry Baryshkov
---
Review
: Add a common function to free kernel buffer
objects")
Signed-off-by: Dmitry Baryshkov
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Abhinav Kumar
On 10/9/2023 1:53 PM, Dmitry Baryshkov wrote:
On 09/10/2023 22:21, Dmitry Baryshkov wrote:
On 09/10/2023 22:19, Abhinav Kumar wrote:
On 10/9/2023 11:10 AM, Dmitry Baryshkov wrote:
Make MSM HDMI driver use devm_drm_bridge_add() instead of plain
drm_bridge_add(). As the driver doesn't
---
drivers/gpu/drm/msm/msm_drv.c | 1 -
1 file changed, 1 deletion(-)
Reviewed-by: Abhinav Kumar
insertions(+), 6 deletions(-)
Reviewed-by: Abhinav Kumar
/msm/disp/mdp4/mdp4_kms.c | 4 ++--
drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 4 ++--
drivers/gpu/drm/msm/msm_drv.c| 4 ++--
drivers/gpu/drm/msm/msm_drv.h| 4 ++--
5 files changed, 10 insertions(+), 10 deletions(-)
Reviewed-by: Abhinav Kumar
try Baryshkov
---
drivers/gpu/drm/msm/msm_drv.c | 6 --
1 file changed, 6 deletions(-)
Reviewed-by: Abhinav Kumar
On 10/9/2023 12:21 PM, Dmitry Baryshkov wrote:
On 09/10/2023 22:19, Abhinav Kumar wrote:
On 10/9/2023 11:10 AM, Dmitry Baryshkov wrote:
Make MSM HDMI driver use devm_drm_bridge_add() instead of plain
drm_bridge_add(). As the driver doesn't require any additional cleanup,
stop adding
On 10/9/2023 11:10 AM, Dmitry Baryshkov wrote:
Make MSM HDMI driver use devm_drm_bridge_add() instead of plain
drm_bridge_add(). As the driver doesn't require any additional cleanup,
stop adding created bridge to the priv->bridges array.
Reviewed-by: Rob Clark
Signed-off-by: Dmitry
On 10/9/2023 12:01 PM, Dmitry Baryshkov wrote:
On 09/10/2023 21:51, Abhinav Kumar wrote:
On 10/9/2023 11:46 AM, Dmitry Baryshkov wrote:
On 09/10/2023 21:39, Abhinav Kumar wrote:
On 10/9/2023 11:10 AM, Dmitry Baryshkov wrote:
Make MSM DSI driver use devm_drm_bridge_add() instead
On 10/9/2023 11:46 AM, Dmitry Baryshkov wrote:
On 09/10/2023 21:39, Abhinav Kumar wrote:
On 10/9/2023 11:10 AM, Dmitry Baryshkov wrote:
Make MSM DSI driver use devm_drm_bridge_add() instead of plain
drm_bridge_add(). As the driver doesn't require any additional cleanup,
stop adding
On 10/9/2023 11:10 AM, Dmitry Baryshkov wrote:
Make MSM DSI driver use devm_drm_bridge_add() instead of plain
drm_bridge_add(). As the driver doesn't require any additional cleanup,
stop adding created bridge to the priv->bridges array.
Reviewed-by: Rob Clark
Signed-off-by: Dmitry Baryshkov
On 10/2/2023 3:58 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2023-09-28 17:46:11)
On 9/27/2023 3:01 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2023-09-25 09:07:18)
However for external DP case, link training can not be guarantee always
success without link rate or lane being
On 9/27/2023 3:01 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2023-09-25 09:07:18)
On 9/22/2023 6:35 PM, Abhinav Kumar wrote:
Doing link training when we get hpd instead of atomic_enable() is a
design choice we have been following for a while because for the case
when link training
On 9/27/2023 2:41 PM, Stephen Boyd wrote:
Quoting Abhinav Kumar (2023-09-22 18:35:27)
On 9/22/2023 2:54 PM, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2023-09-19 02:50:12)
This should be hpd_notify, who starts link training, not some event.
I think this driver should train the link
Hi Stephen
On 9/22/2023 2:54 PM, Stephen Boyd wrote:
Quoting Dmitry Baryshkov (2023-09-19 02:50:12)
On Mon, 18 Sept 2023 at 20:48, Kuogee Hsieh wrote:
On 9/15/2023 6:21 PM, Dmitry Baryshkov wrote:
On Sat, 16 Sept 2023 at 00:38, Kuogee Hsieh wrote:
Add pm_runtime_force_suspend()/resume()
On 9/20/2023 3:46 PM, Konrad Dybcio wrote:
Commit e550ad0e5c3d ("drm/msm/dpu: fix DSC 1.2 block lengths") changed
the block length from a wrong value to another wrong value.
Use the correct one this time.
No that change is correct as well.
After we moved to sub-blk parsing, we have enc
On 9/20/2023 3:46 PM, Konrad Dybcio wrote:
DPU_DSC_OUTPUT_CTRL should be enabled for all platforms with a CTL
CFG 1.0.0. SC7280 is one of them. Add it.
sc7280 and all other chipsets using DSC 1.2 use dpu_hw_dsc_init_1_2 and
not dpu_hw_dsc_init.
dpu_hw_dsc_init_1_2 assigns the
On 9/20/2023 3:46 PM, Konrad Dybcio wrote:
Commit 194347df5844 ("drm/msm/dpu: inline DSC_BLK and DSC_BLK_1_2
macros") unrolled a macro incorrectly. Fix that.
No, its correct from what i can tell.
Before inlining it was using PP_BLK_DITHER macro and not PP_BLK.
PP_BLK_DITHER has a len of
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Abhinav Kumar
of these calls to make sure these calls are
balanced is handled by the DRM core and we should keep it that way
to minimize the overhead in the drivers which implement these ops.
[1]: https://patchwork.freedesktop.org/patch/558387/
Signed-off-by: Abhinav Kumar
---
include/drm
Hi Laurent
On 9/19/2023 11:12 AM, Laurent Pinchart wrote:
Hi Abhinav,
Thank you for the patch.
On Tue, Sep 19, 2023 at 10:48:12AM -0700, Abhinav Kumar wrote:
drm_bridge_hpd_enable()/drm_bridge_hpd_disable() callbacks call into
the respective driver's hpd_enable()/hpd_disable() ops. These ops
() balance be maintained by the
corresponding drm_bridge_connector_enable_hpd() /
drm_bridge_connector_disable_hpd() APIs which should get called by
drm_kms_helper_disable_hpd().
changes in v2:
- minor change in commit text (Dmitry)
Signed-off-by: Abhinav Kumar
Reviewed-by: Dmitry Baryshkov
rm/msm/dsi/dsi_host.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Abhinav Kumar
Will queue it up for -fixes
On 9/11/2023 2:45 PM, Dmitry Baryshkov wrote:
Three different features, DPU_SSPP_SCALER_QSEED3, QSEED3LITE and QSEED4
are all related to different versions of the same HW scaling block.
Corresponding driver parts use scaler_blk.version to identify the
correct way to program the hardware. In
(-)
Reviewed-by: Abhinav Kumar
On 9/11/2023 2:45 PM, Dmitry Baryshkov wrote:
As we have dropped the variadic parts of SSPP sub-blocks declarations,
deduplicate them now, reducing memory cruft.
Signed-off-by: Dmitry Baryshkov
---
.../msm/disp/dpu1/catalog/dpu_3_0_msm8998.h | 16 +--
:
- move the reg read below the video mode check
- minor fixes in commit text
Closes: https://gitlab.freedesktop.org/drm/msm/-/issues/34
Fixes: a689554ba6ed ("drm/msm: Initial add DSI connector support")
Signed-off-by: Abhinav Kumar
---
drivers/gpu/drm/msm/dsi/dsi_h
401 - 500 of 2047 matches
Mail list logo
