Am 07.06.24 um 14:01 schrieb Dmitry Baryshkov:
On Fri, Jun 07, 2024 at 07:44:33PM +0800, zhaoxiong lv wrote:
hi Alex Bee
I compared these two drivers. Although the control IC is the same, the
panel is different, and the init_cmd and timing are also slightly
different, so I added a separate
Am 01.06.24 um 10:45 schrieb Zhaoxiong Lv:
Hi Zhaoxiong,
The bias IC of this kindisplay-kd101ne3 panel is placed
on the panel side, so when the panel is powered on,
there is no need to control AVDD and AVEE in the driver,
only 3.3v and reset are needed.
Signed-off-by: Zhaoxiong Lv
---
Chage
Hi Keith,
thanks a lot for working on this. See some general remarks below
Am 21.05.24 um 12:58 schrieb keith:
Add INNO common api so that it can be used by vendor
drivers which implement vendor specific extensions to Innosilicon HDMI.
Signed-off-by: keith
---
MAINTAINERS
Hi Heiko,
Am 21.05.24 um 10:03 schrieb Heiko Stübner:
Hi Alex,
Am Dienstag, 21. Mai 2024, 12:58:07 CEST schrieb keith:
Verisilicon/DC8200 display controller IP has 2 display pipes and each
pipe support a primary plane and a cursor plane .
In addition, there are four overlay planes as two
The InnoSilicon D-PHY found in RK3128 SoCs supports DSI/LVDS/TTL with a
maximum transfer rate of 1 Gbps per lane. While adding it, also add it's
clocks to RK3128_PD_VIO powerdomain as the phy is part of it.
Signed-off-by: Alex Bee
---
changes since v1:
- also added SCLK_MIPI_24M to powerdomain
Export the D-DHY's APB clock for usage in the DT. Also drop the
CLK_IGNORE_UNUSED-flag, as the clock will be enabled on demand.
Signed-off-by: Alex Bee
---
changes since v1:
- reword commit message
drivers/clk/rockchip/clk-rk3128.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Add the Designware MIPI DSI controller and it's port nodes.
Signed-off-by: Alex Bee
---
changes since v1:
- added HCLK_VIO_H2P as ahb clock
changes since v2:
- dropped ahb clock again
arch/arm/boot/dts/rockchip/rk3128.dtsi | 36 ++
1 file changed, 36 insertions
The DSI controller needs this clock to be enabled in order to be able to
access the registers. Make it critical for that purpose.
Signed-off-by: Alex Bee
---
changes since v1:
- dropped patch
changes since v2:
-re-added patch
drivers/clk/rockchip/clk-rk3128.c | 1 +
1 file changed, 1
The DesignWare MIPI DSI controller found RK3128 SoCs supports up to 4 DSI
data lanes. Similar to PX30/RK356x/RV1126 it uses an external D-PHY.
Signed-off-by: Alex Bee
---
changes since v1:
- none
.../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 20 +++
1 file changed, 20
for the additional AHB clock for the DSI controller,
as it's not part of the IP block. (Heiko)
Link to v2:
https://lore.kernel.org/linux-kernel/20240509120715.86694-1-knaerz...@gmail.com/
Please see individual patches for details about the changes.
Alex Bee (7):
dt-bindings: display: rockchip,dw-mipi-dsi
The DPHY's APB clock is required to be exposed in order to be able to
enable it and access the phy's registers.
Signed-off-by: Alex Bee
Acked-by: Conor Dooley
---
changes since v1:
- none
include/dt-bindings/clock/rk3128-cru.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt
Document the MIPI DSI controller for Rockchip RK3128. The integration is
similar to PX30 so it's bindings-constraints can be re-used.
Signed-off-by: Alex Bee
Acked-by: Conor Dooley
---
changes since v1:
- added ahb clock
changes since v2:
- revert added ahb clock
.../rockchip/rockchip,dw
for the additional AHB clock for the DSI controller,
as it's not part of the IP block. (Heiko)
Link to v2:
https://lore.kernel.org/linux-kernel/20240509120715.86694-1-knaerz...@gmail.com/
Please see individual patches for details about the changes.
Alex Bee (7):
dt-bindings: display: rockchip,dw-mipi-dsi
Am 09.05.24 um 14:43 schrieb Alex Bee:
Hi Heiko
Am 09.05.24 um 14:21 schrieb Heiko Stübner:
Hi Alex,
Am Donnerstag, 9. Mai 2024, 14:07:08 CEST schrieb Alex Bee:
This series aims to add support for the DesignWare MIPI DSI
controller and
the Innoslicon D-PHY found in RK3128 SoCs. The code
Hi Heiko
Am 09.05.24 um 14:21 schrieb Heiko Stübner:
Hi Alex,
Am Donnerstag, 9. Mai 2024, 14:07:08 CEST schrieb Alex Bee:
This series aims to add support for the DesignWare MIPI DSI controller and
the Innoslicon D-PHY found in RK3128 SoCs. The code additions are rather
tiny: It only need some
Export the D-DHY's APB clock for usage in the DT. Also drop the
CLK_IGNORE_UNUSED-flag, as the clock will be enabled on demand.
Signed-off-by: Alex Bee
---
changes since v1:
- reword commit message
drivers/clk/rockchip/clk-rk3128.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Add the Designware MIPI DSI controller and it's port nodes.
Signed-off-by: Alex Bee
---
changes since v1:
- added HCLK_VIO_H2P as ahb clock
arch/arm/boot/dts/rockchip/rk3128.dtsi | 36 ++
1 file changed, 36 insertions(+)
diff --git a/arch/arm/boot/dts/rockchip/rk3128
The InnoSilicon D-PHY found in RK3128 SoCs supports DSI/LVDS/TTL with a
maximum transfer rate of 1 Gbps per lane. While adding it, also add it's
clocks to RK3128_PD_VIO powerdomain as the phy is part of it.
Signed-off-by: Alex Bee
---
changes since v1:
- also added SCLK_MIPI_24M to powerdomain
The DesignWare MIPI DSI controller found RK3128 SoCs supports up to 4 DSI
data lanes. Similar to PX30/RK356x/RV1126 it uses an external D-PHY.
Signed-off-by: Alex Bee
---
changes since v1:
- none
.../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 20 +++
1 file changed, 20
Some integrations of the IP additionally have an AHB clock which has to be
enabled before accessing the registers is possible.
Add support for it as an optional clock.
Signed-off-by: Alex Bee
---
changes since v1:
- new patch
.../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 25
The DPHY's APB clock is required to be exposed in order to be able to
enable it and access the phy's registers.
Signed-off-by: Alex Bee
Acked-by: Conor Dooley
---
changes since v1:
- none
include/dt-bindings/clock/rk3128-cru.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt
Document the MIPI DSI controller for Rockchip RK3128. The integration is
very similar to PX30, but it has an additional AHB clock.
Signed-off-by: Alex Bee
---
changes since v1:
- added ahb clock
.../rockchip/rockchip,dw-mipi-dsi.yaml| 25 ++-
1 file changed, 24
individual patches for details about the changes.
Alex Bee (7):
dt-bindings: display: rockchip,dw-mipi-dsi: Document RK3128 DSI
dt-bindings: clock: rk3128: Add PCLK_MIPIPHY
clk: rockchip: rk3128: Export PCLK_MIPIPHY
drm/rockchip: dsi: Support optional AHB clock
drm/rockchip: dsi: Add support
The DSI controller needs this clock to be enabled in order to be able to
access the registers. Make it critical for that purpose.
Signed-off-by: Alex Bee
---
drivers/clk/rockchip/clk-rk3128.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/rockchip/clk-rk3128.c
b/drivers/clk
The InnoSilicon DPHY found in RK3128 SoCs supports DSI/LVDS/TTL with a
maximum transfer rate of 1 Gbps per lane. While at it also add the newly
exported PCLK_MIPIPHY clock id to RK3128_PD_VIO powerdomain as the phy is
part of it.
Signed-off-by: Alex Bee
---
arch/arm/boot/dts/rockchip/rk3128
Add the Designware MIPI DSI controller and it's port nodes.
Signed-off-by: Alex Bee
---
arch/arm/boot/dts/rockchip/rk3128.dtsi | 36 ++
1 file changed, 36 insertions(+)
diff --git a/arch/arm/boot/dts/rockchip/rk3128.dtsi
b/arch/arm/boot/dts/rockchip/rk3128.dtsi
index
The DesignWare MIPI DSI controller found RK3128 SoCs supports up to 4 dsi
data lanes. Similar to PX30/RK356x/RV1126 it uses an external DPHY.
Signed-off-by: Alex Bee
---
.../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 20 +++
1 file changed, 20 insertions(+)
diff --git
Document the MIPI DSI controller for Rockchip RK3128. The integration is
similar to PX30 so it's bindings-constraints can be re-used.
Signed-off-by: Alex Bee
---
.../bindings/display/rockchip/rockchip,dw-mipi-dsi.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation
The DPHY driver requires to specify a pclk so it gets exported here. I also
dropped the CLK_IGNORE_UNUSED-flag as we will enable the clock on demand.
Signed-off-by: Alex Bee
---
drivers/clk/rockchip/clk-rk3128.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk
The DPHY's APB clock is required to be exposed in order to be able to
enable it and access the phy's registers.
Signed-off-by: Alex Bee
---
include/dt-bindings/clock/rk3128-cru.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/clock/rk3128-cru.h
b/include/dt-bindings
been added when the driver was initially submitted. I tested it
with a 800x1280 DSI panel where all 4 lanes that are supported are used.
Alex Bee (7):
dt-bindings: display: rockchip,dw-mipi-dsi: Document RK3128 DSI
dt-bindings: clock: rk3128: Add PCLK_MIPIPHY
clk: rockchip: rk3128: Export
Hi Maxime,
Am 22.02.24 um 19:14 schrieb Maxime Ripard:
Now that we have all the infrastructure needed, we can add some code
that will, for a given connector state and mode, compute the best output
format and bpc.
The algorithm is equivalent to the one already found in i915 and vc4.
0.utgazgba-...@intel.com/
Fixes: d3e040f450ec ("drm/rockchip: inno_hdmi: Get rid of mode_set")
Signed-off-by: Alex Bee
---
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c
b/drivers/gpu/drm/rockchip/inno_hdmi.
Am 05.01.24 um 18:02 schrieb Heiko Stübner:
Am Freitag, 5. Januar 2024, 17:47:21 CET schrieb Alex Bee:
Hi Heiko,
Am 04.01.24 um 09:14 schrieb Heiko Stuebner:
On Fri, 22 Dec 2023 18:41:51 +0100, Alex Bee wrote:
This is version 4 of my series that aims to add support for the display
Hi Heiko,
Am 04.01.24 um 09:14 schrieb Heiko Stuebner:
On Fri, 22 Dec 2023 18:41:51 +0100, Alex Bee wrote:
This is version 4 of my series that aims to add support for the display
controller (VOP) and the HDMI controller block of RK3128 (which is very
similar to the one found in RK3036
-inclusive.
Signed-off-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- adapt to the newly introduced inno_hdmi_power_up / inno_hdmi_standby
functions
changes in v4:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 74 ++--
1 file changed, 69 insertions(+), 5
RK3128 has Innosilicon based HDMI TX controller similar to the one found in
RK3036.
Add it and the respective port nodes to the SoC device tree.
Signed-off-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- no changes
changes in v4:
- none
arch/arm/boot/dts/rockchip/rk3128.dtsi
Add an hdmi-connector node and enable the hdmi, display-subsystem and vop
nodes.
Signed-off-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- no changes
changes in v4:
- none
.../arm/boot/dts/rockchip/rk3128-xpi-3128.dts | 29 +++
1 file changed, 29 insertions
Now that we have proper pixelclock-based mode validation we can drop the
custom fill_modes hook.
CRTC size validation for the display controller has been added with
Commit 8e140cb60270 ("drm/rockchip: vop: limit maximum resolution to
hardware capabilities")
Signed-off-by: Alex Bee
-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- no changes
changes in v4:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 46 +---
1 file changed, 41 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c
b/drivers/gpu/drm/rockchip
DMT'srecommendations.
Signed-off-by: Alex Bee
Reviewed-by: Maxime Ripard
---
changes in v2:
- rename inno_mode_valid -> inno_hdmi_display_mode_valid
- fixed max_tolerance calculation
- use abs_diff() instead of abs()
- call in inno_hdmi_display_mode_valid in atomic_check
changes in v3:
- coll
The data which is currently hold in hdmi_data should not be part of device
itself but of the connector state.
Introduce a connector state subclass and move the data from hdmi_data in
there.
Suggested-by: Maxime Ripard
Signed-off-by: Alex Bee
---
changes in v2:
- new patch
changes in v3
From: Maxime Ripard
The HDMI vendor infoframe is only meant to be sent with 4k60 modes and
higher, but the controller doesn't support them. Let's drop them from
the kernel.
Suggested-by: Johan Jonker
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2
Add vop and display-subsystem nodes to RK3128's device tree.
Signed-off-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- no changes
changes in v4:
- none
arch/arm/boot/dts/rockchip/rk3128.dtsi | 27 ++
1 file changed, 27 insertions(+)
diff --git
the divider at probe time when we
don't have a mode yet.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v3:
- imported patch
changes in v4:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions
The struct member irq isn't used anywhere. Drop it.
Signed-off-by: Alex Bee
Reviewed-by: Maxime Ripard
---
changes in v2:
- new patch
changes in v3:
- collect RB
changes in v4:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm
for those modes and sets the
quantization range accordingly in the AVI infoframe.
Signed-off-by: Alex Bee
---
changes in v2:
- made rgb_limited_range part of the new custom connector state
changes in v3:
- moved assignment of rgb_limited_range to atomic check
changes in v4:
- none
drivers/gpu/drm
From: Maxime Ripard
The mode's VIC is only ever used in the inno_hdmi_setup() function so
there's no need to store it in the main structure.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
[made checkpatch happy]
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3
From: Maxime Ripard
The driver has a lot of logic to deal with multiple input formats, but
hardcodes it to RGB. This means that most of that code has been dead
code, so let's get rid of it.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
[made checkpatch happy]
Signed-off-by: Alex Bee
in
inno_hdmi_encoder_disable.
Set it to LOWER_PWR after resetting the controller.
Signed-off-by: Alex Bee
---
changes in v3:
- new patch
changes in v4:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c
b
From: Maxime Ripard
The drm_dev field in the inno_hdmi struct stores a pointer to the DRM
device but is never used anywhere in the driver. Let's remove it.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added
From: Maxime Ripard
The sink_has_audio flag is not used anywhere in the driver so let's get
rid of it. It's redundant with drm_display_info.has_audio anyway.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added
The inclusion syscon.h isn't used anywhere. Remove it.
Signed-off-by: Alex Bee
Reviewed-by: Maxime Ripard
---
changes in v2:
- new patch
changes in v3:
- collect RB
changes in v4:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu
From: Maxime Ripard
The mode_fixup implementation doesn't do anything, so we can simply
remove it.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
changes in v4:
- none
drivers/gpu/drm/rockchip
Now that the unneeded support for YUV based input formats is gone, the csc
coefficients for those formats can be dropped as well.
Signed-off-by: Alex Bee
---
changes in v2:
- new patch
changes in v3:
- none
changes in v4:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 37
t;drm/rockchip: hdmi: add Innosilicon HDMI support")
Co-developed-by: Zheng Yang
Signed-off-by: Zheng Yang
Signed-off-by: Alex Bee
---
changes in v2:
- none
changes in v3:
- none
changes in v4:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
From: Maxime Ripard
The inno_hdmi encoder still uses the !atomic variants of enable, disable
and modeset. Convert to their atomic equivalents.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
This splits setting the power mode of the controller / phy in two
functions. It's done in preparation of setting up the phy based on the
pixelclock.
No functional changes intended.
Signed-off-by: Alex Bee
---
changes in v3:
- new patch
changes in v4:
- none
drivers/gpu/drm/rockchip
From: Maxime Ripard
We're not doing anything special in atomic_mode_set so we can simply
merge it into atomic_enable.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
changes in v4:
- none
From: Maxime Ripard
The inno_hdmi driver relies on its own internal infoframe type matching
the hardware.
This works fine, but in order to make further reworks easier, let's
switch to the HDMI spec definition of those types.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off
into a separate function and make it obvious what
we are doing in the error path.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
changes in v4:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 46
The integration for this SoC is different from the currently existing: It
needs it's PHY's reference clock rate to calculate the DDC bus frequency
correctly. The controller is also part of a powerdomain, so this gets added
as an mandatory property for this variant.
Signed-off-by: Alex Bee
From: Maxime Ripard
The driver maintains a copy of the adjusted mode but doesn't use it
anywhere. Remove it.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
changes in v4:
- none
drivers/gpu/drm
polarity.
Signed-off-by: Alex Bee
---
changes in v2:
- rephrase commit message
changes in v3:
- none
changes in v4:
- none
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 13 -
drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 3 +++
2 files changed, 15 insertions(+), 1 deletion(-)
diff
://lore.kernel.org/all/20231216162639.125215-1-knaerz...@gmail.com/
[5] https://lore.kernel.org/all/20231219170100.188800-1-knaerz...@gmail.com/
Alex Bee (17):
dt-bindings: display: rockchip,inno-hdmi: Document RK3128 compatible
drm/rockchip: vop: Add output selection registers for RK312x
drm/rockchip
RK3128 has Innosilicon based HDMI TX controller similar to the one found in
RK3036.
Add it and the respective port nodes to the SoC device tree.
Signed-off-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- no changes
arch/arm/boot/dts/rockchip/rk3128.dtsi | 33
Add vop and display-subsystem nodes to RK3128's device tree.
Signed-off-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- no changes
arch/arm/boot/dts/rockchip/rk3128.dtsi | 27 ++
1 file changed, 27 insertions(+)
diff --git a/arch/arm/boot/dts/rockchip
-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- no changes
drivers/gpu/drm/rockchip/inno_hdmi.c | 46 +---
1 file changed, 41 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c
b/drivers/gpu/drm/rockchip/inno_hdmi.c
index
From: Maxime Ripard
The drm_dev field in the inno_hdmi struct stores a pointer to the DRM
device but is never used anywhere in the driver. Let's remove it.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added
into a separate function and make it obvious what
we are doing in the error path.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
drivers/gpu/drm/rockchip/inno_hdmi.c | 46 ++--
1 file
in
inno_hdmi_encoder_disable.
Set it to LOWER_PWR after resetting the controller.
Signed-off-by: Alex Bee
---
changes in v3:
- new patch
drivers/gpu/drm/rockchip/inno_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c
b/drivers/gpu/drm/rockchip
Now that we have proper pixelclock-based mode validation we can drop the
custom fill_modes hook.
CRTC size validation for the display controller has been added with
Commit 8e140cb60270 ("drm/rockchip: vop: limit maximum resolution to
hardware capabilities")
Signed-off-by: Alex Bee
From: Maxime Ripard
We're not doing anything special in atomic_mode_set so we can simply
merge it into atomic_enable.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
drivers/gpu/drm/rockchip
Add an hdmi-connector node and enable the hdmi, display-subsystem and vop
nodes.
Signed-off-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- no changes
.../arm/boot/dts/rockchip/rk3128-xpi-3128.dts | 29 +++
1 file changed, 29 insertions(+)
diff --git a/arch
From: Maxime Ripard
The driver has a lot of logic to deal with multiple input formats, but
hardcodes it to RGB. This means that most of that code has been dead
code, so let's get rid of it.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
[made checkpatch happy]
Signed-off-by: Alex Bee
The data which is currently hold in hdmi_data should not be part of device
itself but of the connector state.
Introduce a connector state subclass and move the data from hdmi_data in
there.
Suggested-by: Maxime Ripard
Signed-off-by: Alex Bee
---
changes in v2:
- new patch
changes in v3
From: Maxime Ripard
The driver maintains a copy of the adjusted mode but doesn't use it
anywhere. Remove it.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
drivers/gpu/drm/rockchip/inno_hdmi.c
for those modes and sets the
quantization range accordingly in the AVI infoframe.
Signed-off-by: Alex Bee
---
changes in v2:
- made rgb_limited_range part of the new custom connector state
changes in v3:
- moved assignment of rgb_limited_range to atomic check
drivers/gpu/drm/rockchip/inno_hdmi.c | 60
DMT'srecommendations.
Signed-off-by: Alex Bee
Reviewed-by: Maxime Ripard
---
changes in v2:
- rename inno_mode_valid -> inno_hdmi_display_mode_valid
- fixed max_tolerance calculation
- use abs_diff() instead of abs()
- call in inno_hdmi_display_mode_valid in atomic_check
changes in v3:
- coll
The struct member irq isn't used anywhere. Drop it.
Signed-off-by: Alex Bee
Reviewed-by: Maxime Ripard
---
changes in v2:
- new patch
changes in v3:
- collect RB
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c
b
From: Maxime Ripard
The mode_fixup implementation doesn't do anything, so we can simply
remove it.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
drivers/gpu/drm/rockchip/inno_hdmi.c | 8
The inclusion syscon.h isn't used anywhere. Remove it.
Signed-off-by: Alex Bee
Reviewed-by: Maxime Ripard
---
changes in v2:
- new patch
changes in v3:
- collect RB
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c
From: Maxime Ripard
The mode's VIC is only ever used in the inno_hdmi_setup() function so
there's no need to store it in the main structure.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
[made checkpatch happy]
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3
This splits setting the power mode of the controller / phy in two
functions. It's done in preparation of setting up the phy based on the
pixelclock.
No functional changes intended.
Signed-off-by: Alex Bee
---
changes in v3:
- new patch
drivers/gpu/drm/rockchip/inno_hdmi.c | 54
-inclusive.
Signed-off-by: Alex Bee
---
changes in v2:
- no changes
changes in v3:
- adapt to the newly introduced inno_hdmi_power_up / inno_hdmi_standby
functions
drivers/gpu/drm/rockchip/inno_hdmi.c | 74 ++--
1 file changed, 69 insertions(+), 5 deletions(-)
diff --git
From: Maxime Ripard
The HDMI vendor infoframe is only meant to be sent with 4k60 modes and
higher, but the controller doesn't support them. Let's drop them from
the kernel.
Suggested-by: Johan Jonker
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2
From: Maxime Ripard
The sink_has_audio flag is not used anywhere in the driver so let's get
rid of it. It's redundant with drm_display_info.has_audio anyway.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added
Now that the unneeded support for YUV based input formats is gone, the csc
coefficients for those formats can be dropped as well.
Signed-off-by: Alex Bee
---
changes in v2:
- new patch
changes in v3:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 37
1
From: Maxime Ripard
The inno_hdmi encoder still uses the !atomic variants of enable, disable
and modeset. Convert to their atomic equivalents.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v2:
- imported patch
changes in v3:
- added my SoB
t;drm/rockchip: hdmi: add Innosilicon HDMI support")
Co-developed-by: Zheng Yang
Signed-off-by: Zheng Yang
Signed-off-by: Alex Bee
---
changes in v2:
- none
changes in v3:
- none
drivers/gpu/drm/rockchip/inno_hdmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drive
the divider at probe time when we
don't have a mode yet.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off-by: Alex Bee
---
changes in v3:
- imported patch
drivers/gpu/drm/rockchip/inno_hdmi.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu
From: Maxime Ripard
The inno_hdmi driver relies on its own internal infoframe type matching
the hardware.
This works fine, but in order to make further reworks easier, let's
switch to the HDMI spec definition of those types.
Signed-off-by: Maxime Ripard
Tested-by: Alex Bee
Signed-off
polarity.
Signed-off-by: Alex Bee
---
changes in v2:
- rephrase commit message
changes in v3:
- none
drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 13 -
drivers/gpu/drm/rockchip/rockchip_vop_reg.h | 3 +++
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm
The integration for this SoC is different from the currently existing: It
needs it's PHY's reference clock rate to calculate the DDC bus frequency
correctly. The controller is also part of a powerdomain, so this gets added
as an mandatory property for this variant.
Signed-off-by: Alex Bee
/20231213195125.212923-1-knaerz...@gmail.com/
[4] https://lore.kernel.org/all/20231216162639.125215-1-knaerz...@gmail.com/
Alex Bee (17):
dt-bindings: display: rockchip,inno-hdmi: Document RK3128 compatible
drm/rockchip: vop: Add output selection registers for RK312x
drm/rockchip: inno_hdmi: Fix video
Hi Heiko
Am 12.12.23 um 21:03 schrieb Heiko Stuebner:
Hi Alex,
Am Dienstag, 29. August 2023, 19:16:16 CET schrieb Alex Bee:
this series fixes some issues I found when testing my "new" RK3128 board
with the mainline kernel and adds some core functionality like SMP bringup,
usb and
coming from userspace not being verfied against the
defined ranges and prevents firmware loading for meta cores.
Fixes: ff5f643de0bf ("drm/imagination: Add GEM and VM related code")
Signed-off-by: Alex Bee
---
drivers/gpu/drm/imagination/pvr_vm.c | 2 +-
1 file changed, 1 insertion(+),
Hi Johan,
Am 04.12.23 um 18:40 schrieb Johan Jonker:
Add hdmi-connector node to comply with the inno_hdmi binding.
Signed-off-by: Johan Jonker
---
arch/arm/boot/dts/rockchip/rk3036-kylin.dts | 17 +
1 file changed, 17 insertions(+)
diff --git
Hi Johan,
Am 04.12.23 um 18:39 schrieb Johan Jonker:
Convert inno_hdmi-rockchip.txt to yaml.
Nice - I'm having something very similar on my queue :)
Signed-off-by: Johan Jonker
---
Note for rob+dt:
Used enum to "soon" be able to add "rockchip,rk3128-inno-hdmi"
Yeah, actually I'm
Hi Heiko,
Am 03.12.23 um 17:42 schrieb Heiko Stübner:
Hi Alex,
Am Sonntag, 3. Dezember 2023, 17:05:47 CET schrieb Alex Bee:
Am 02.12.23 um 18:46 schrieb Heiko Stübner:
Am Samstag, 2. Dezember 2023, 17:36:15 CET schrieb Alex Bee:
Am 02.12.23 um 16:51 schrieb Heiko Stübner:
Am Samstag, 2
1 - 100 of 184 matches
Mail list logo
