On 2024-01-26 09:28, Melissa Wen wrote:
Replace raw edid handling (struct edid) with the opaque EDID type
(struct drm_edid) on amdgpu_dm_connector for consistency. It may also
prevent mismatch of approaches in different parts of the driver code.
Working in progress. There are a couple of cast
Thanks for catching this.
Reviewed-by: Alex Hung
On 2023-12-08 02:58, Harshit Mogalapalli wrote:
'wb_info' needs to be freed on error paths or it would leak the memory.
Smatch pointed this out.
Fixes: c81e13b929df ("drm/amd/display: Hande writeback request from userspace")
[WHY]
edid_override and drm_edid_override_connector_update, according to drm
documentation, should not be referred outside drm_edid.
[HOW]
Remove and replace them accordingly. This can tested by IGT's
kms_hdmi_inject test.
Signed-off-by: Alex Hung
---
.../gpu/drm/amd/display/amdgpu_dm
On 2023-09-18 04:25, Jani Nikula wrote:
On Fri, 15 Sep 2023, Alex Hung wrote:
[WHY]
edid_override and drm_edid_override_connector_update, according to drm
documentation, should not be referred outside drm_edid.
[HOW]
Remove and replace them accordingly. This can tested by IGT's
[WHY]
edid_override and drm_edid_override_connector_update, according to drm
documentation, should not be referred outside drm_edid.
[HOW]
Remove and replace them accordingly. This can tested by IGT's
kms_hdmi_inject test.
Signed-off-by: Alex Hung
---
V2 - add comments for drm_get_edid
[WHY]
edid_override and drm_edid_override_connector_update, according to drm
documentation, should not be referred outside drm_edid.
[HOW]
Remove and replace them accordingly.
Signed-off-by: Alex Hung
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 23 ++-
1 file changed, 2
On 2023-08-30 01:29, Jani Nikula wrote:
On Tue, 29 Aug 2023, Alex Hung wrote:
On 2023-08-29 11:03, Jani Nikula wrote:
On Tue, 29 Aug 2023, Jani Nikula wrote:
On Tue, 29 Aug 2023, Alex Deucher wrote:
On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote:
On Wed, 23 Aug 2023, Jani Nikula
On 2023-08-29 11:03, Jani Nikula wrote:
On Tue, 29 Aug 2023, Jani Nikula wrote:
On Tue, 29 Aug 2023, Alex Deucher wrote:
On Tue, Aug 29, 2023 at 6:48 AM Jani Nikula wrote:
On Wed, 23 Aug 2023, Jani Nikula wrote:
On Tue, 22 Aug 2023, Alex Hung wrote:
On 2023-08-22 06:01, Jani Nikula
the function as reverting these patches causes regressions.
Cheers,
Alex
BR,
Jani.
Cc: Alex Deucher
Cc: Alex Hung
Cc: Chao-kai Wang
Cc: Daniel Wheeler
Cc: Harry Wentland
Cc: Hersen Wu
Cc: Leo Li
Cc: Rodrigo Siqueira
Cc: Wenchieh Chien
Cc: David Airlie
Cc: Daniel Vetter
Jani Nikula (4
Tested-by: Alex Hung
On 2023-07-31 02:35, Melissa Wen wrote:
Don't set predefined degamma curve to cursor plane if the cursor
attribute flag is not set. Applying a degamma curve to the cursor by
default breaks userspace expectation. Checking the flag before
performing any color transformation
This is a copy-and-paste error. Fix the comment to match the macro
definition.
Signed-off-by: Alex Hung
---
drivers/gpu/drm/amd/display/dc/dml/dcn10/dcn10_fpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn10/dcn10_fpu.h
b/drivers
Implement the 3D LUT interface, convert and pass the data for amdgpu
driver.
Note: A patchset "IGT tests for pre-blending 3D LUT interfaces" for this
proposal is sent to IGT mailing list.
Signed-off-by: Alex Hung
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 13 ++
.../g
Enable the 3D LUT mode supported by amdgpu.
Note: A patchset "IGT tests for pre-blending 3D LUT interfaces" for this
proposal is sent to IGT mailing list.
Signed-off-by: Alex Hung
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++
drivers/gpu/drm/drm_color_mgmt.c
Add a 3D LUT mode supported by amdgpu driver.
Note: A patchset "IGT tests for pre-blending 3D LUT interfaces" for this
proposal is sent to IGT mailing list.
Signed-off-by: Alex Hung
---
.../gpu/drm/amd/display/modules/color/color_gamma.h | 12
1 file changed, 12
t.
Signed-off-by: Alex Hung
---
.../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++
drivers/gpu/drm/drm_atomic_state_helper.c | 3 ++
drivers/gpu/drm/drm_atomic_uapi.c | 11 ++
drivers/gpu/drm/drm_color_mgmt.c | 37 +++
include/drm/drm_mod
A struct is defined for 3D LUT modes to be supported by hardware.
The elements includes lut_isze, lut_stride, bit_depth, color_format
and flags.
Note: A patchset "IGT tests for pre-blending 3D LUT interfaces" for this
proposal is sent to IGT mailing list.
Signed-off-by: Alex Hung
--
_3d_mode_17_12bit;
};
struct drm_color_pipeline_lut3d_data {
*lut_3d;
};
and etc.
3. A patchset "IGT tests for pre-blending 3D LUT interfaces" for this
proposal is sent to IGT mailing list.
Related Work:
- Enable 3D LUT to AMD display drivers
(https://www.spinics.net/lists/amd-gfx/msg83032.h
On 2022-09-14 10:55, Michel Dänzer wrote:
[ Adding the dri-devel list ]
On 2022-09-14 18:30, Alex Hung wrote:
On 2022-09-14 07:40, Michel Dänzer wrote:
On 2022-09-14 15:31, Michel Dänzer wrote:
On 2022-09-14 07:10, Wayne Lin wrote:
From: Alex Hung
[Why & How]
This fixes kernel er
On 2020-07-19 1:50 p.m., Karol Herbst wrote:
> On Fri, Jul 17, 2020 at 9:52 PM Alex Hung wrote:
>>
>> On 2020-07-17 1:05 p.m., Karol Herbst wrote:
>>> It's hard to figure out what systems are actually affected and right now I
>>> don't see a good way of remov
ems those workaround
> applies to, which might be any so those should get removed asap and if
> new issues arrise removing those please do a proper bug report and we can
> look into it and come up with a proper fix (and keep this patch out until
> we resolve all of those).
>
> S
patches) so they won't affect others.
Acked-by: Alex Hung
On Thu, Sep 5, 2019 at 10:26 AM Rafael J. Wysocki wrote:
>
> On Thursday, September 5, 2019 5:51:23 PM CEST Karol Herbst wrote:
> > is there any update on the testing with my patches? On the hardware I
> > had acces
gt; > on the hardware for which those workarounds where actually added.
>
> Alex Hung and Mario need to answer this question I think.
Sorry for taking a long time. I don't have full testing results yet
but we found at least a regression occurred with _OSI string removed -
it is not on nVi
preciate better fixes and want to retire the hacks too.
I am going to notify hardware owners to test these patches on the
original intended systems, and will report whether there are
regressions.
>
> Signed-off-by: Karol Herbst
> CC: Alex Hung
> CC: Rafael J. Wysocki
> CC: D
gt; the
> driver, not adding some hacky workaround through ACPI tricks.
>
> And what out of tree drivers do or do not support we don't care one bit
> anyway.
>
> Signed-off-by: Karol Herbst
> CC: Alex Hung
> CC: Rafael J. Wysocki
> CC: Dave Airlie
> CC: Lyude Paul
24 matches
Mail list logo
