Re: [PATCH v2 1/2] drm: Add color management LUT validation helper (v2)

Hi, On Thu, Dec 13, 2018 at 01:55:25PM -0800, Matt Roper wrote: > Some hardware may place additional restrictions on the gamma/degamma > curves described by our LUT properties. E.g., that a gamma curve never > decreases or that the red/green/blue channels of a LUT's entries must be > equal.

Re: [PATCH v1] drm/arm: Delete redundant CONFIG_DRM_ARM

Hi James, On Wed, Dec 05, 2018 at 03:41:35AM +, james qian wang (Arm Technology China) wrote: > Delete redundant CONFIG_DRM_ARM, and add a menu "ARM devices" to subclass > ARM device drivers. > > Signed-off-by: James (Qian) Wang Reviewed-by: Alexandru Gheorghe > --- >

Re: [PATCH] drm/arm/malidp: Consider rotation memory requirement in case of AFBC framebuffer

Hi Ayan, On Fri, Nov 09, 2018 at 10:37:19AM +, Ayan Halder wrote: > Rotation memory for layers is shared with AFBC decoder block. Thus one needs > to > calculate rotation memory requirement in case of AFBC framebuffer. This is > used later to verify if it can be sufficed by the hardware

[PATCH] drm/selftests: Fix build warning -Wframe-larger-than

It seems for some random configuration drm_device is bigger than 2048 bytes. The fix is to make the mock objects static variables. Bug reported by 0-DAY Kernel test infrastructure here: https://lists.01.org/pipermail/kbuild-all/2018-November/054431.html Fixes: 6ff3d9ffdcbb ("drm/selftests: Add

[PATCH v8] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

For some pixel formats .cpp structure in drm_format info it's not enough to describe the peculiarities of the pixel layout, for example tiled formats or packed formats at bit level. What's implemented here is to add three new members to drm_format_info that could describe such formats: -

[RESEND v7 7/7] drm/selftests: Add tests for drm_internal_framebuffer_create

Add tests that verify that drm_internal_framebuffer_create creates buffers correctly by creating a dummy drm_device with a mock function for the fb_create callback. To decide if a buffer has been created or not it just checks if fb_create callback has been called for the particular

[RESEND v7 3/7] drm: mali-dp: Enable Mali-DP tiled buffer formats

Enable the following formats - DRM_FORMAT_X0L0: DP650 - DRM_FORMAT_X0L2: DP550, DP650 Reviewed-by: Brian Starkey Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_hw.c | 14 +++--- drivers/gpu/drm/arm/malidp_planes.c | 28 +--- 2 files

[RESEND v7 6/7] drm: Add macro to export functions only when CONFIG_DRM_DEBUG_SELFTEST is enabled

If we want to be able to write drmselftests for non-static core functions that are not intended to be used by drivers we need this functions to be exported. This adds a macro that is tied of CONFIG_DRM_DEBUG_SELFTEST, and uses that to export drm_internal_framebuffer_create, in order for

[RESEND v7 4/7] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0

For formats that are supported only with non-linear modifiers it doesn't make to much sense to define cpp or char_per_block, so that will be set to 0. This patch adds a restriction to force having a modifier attached when cpp/char_per_block is 0, and to bypass checking the pitch restriction.

[RESEND v7 5/7] drm/selftests: Add tests for drm_format_info* helpers

Add selftests for the following newly added functions: - drm_format_info_block_width - drm_format_info_block_height - drm_format_info_min_pitch Signed-off-by: Alexandru Gheorghe Reviewed-by: Daniel Vetter --- drivers/gpu/drm/selftests/Makefile| 3 +-

[RESEND v7 1/7] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

For some pixel formats .cpp structure in drm_format info it's not enough to describe the peculiarities of the pixel layout, for example tiled formats or packed formats at bit level. What's implemented here is to add three new members to drm_format_info that could describe such formats: -

[RESEND v7 2/7] drm/fourcc: Add fourcc for Mali linear tiled formats

Mali-DP implements a number of tiled yuv formats which are not currently described in drm_fourcc.h. This adds those definitions and describes their memory layout by using the newly added char_per_block, block_w, block_h. Reviewed-by: Brian Starkey Reviewed-by: Daniel Vetter Signed-off-by:

[RESEND v7 0/7] Add method to describe tile/bit_level_packed formats

Basically, just a resend before I merge these patches in drm-misc-next. Changes since v6: - Collected Reviewed-by. - Fixed author, seems dim it's not smart enough to know "Alexandru Gheorghe" is the same with Alexandru-Cosmin Gheorghe :). - Fixed conflicts against latest drm

Re: [PATCH v6 3/9] drm: mali-dp: Enable Mali-DP tiled buffer formats

Hi, Liviu, can I merge this through drm-misc-next. On Mon, Oct 29, 2018 at 05:14:38PM +, Alexandru-Cosmin Gheorghe wrote: > Enable the following formats > - DRM_FORMAT_X0L0: DP650 > - DRM_FORMAT_X0L2: DP550, DP650 > > Reviewed-by: Brian Starkey > Signed-off-by:

[PATCH v6 4/9] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0

For formats that are supported only with non-linear modifiers it doesn't make to much sense to define cpp or char_per_block, so that will be set to 0. This patch adds a restriction to force having a modifier attached when cpp/char_per_block is 0, and to bypass checking the pitch restriction.

[PATCH v6 5/9] drm/fourcc: Add AFBC yuv fourccs for Mali

From: Brian Starkey As we look to enable AFBC using DRM format modifiers, we run into problems which we've historically handled via vendor-private details (i.e. gralloc, on Android). AFBC (as an encoding) is fully flexible, and for example YUV data can be encoded into 1, 2 or 3 encoded

[PATCH v6 7/9] drm/selftests: Add tests for drm_format_info* helpers

Add selftests for the following newly added functions: - drm_format_info_block_width - drm_format_info_block_height - drm_format_info_min_pitch Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/selftests/Makefile| 3 +- .../gpu/drm/selftests/drm_modeset_selftests.h | 3 +

[PATCH v6 9/9] drm/selftests: Add tests for drm_internal_framebuffer_create

Add tests that verify that drm_internal_framebuffer_create creates buffers correctly by creating a dummy drm_device with a mock function for the fb_create callback. To decide if a buffer has been created or not it just checks if fb_create callback has been called for the particular

[PATCH v6 3/9] drm: mali-dp: Enable Mali-DP tiled buffer formats

Enable the following formats - DRM_FORMAT_X0L0: DP650 - DRM_FORMAT_X0L2: DP550, DP650 Reviewed-by: Brian Starkey Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_hw.c | 14 +++--- drivers/gpu/drm/arm/malidp_planes.c | 28 +--- 2 files

[PATCH v6 2/9] drm/fourcc: Add fourcc for Mali linear tiled formats

Mali-DP implements a number of tiled yuv formats which are not currently described in drm_fourcc.h. This adds those definitions and describes their memory layout by using the newly added char_per_block, block_w, block_h. Reviewed-by: Brian Starkey Signed-off-by: Alexandru Gheorghe ---

[PATCH v6 1/9] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

For some pixel formats .cpp structure in drm_format info it's not enough to describe the peculiarities of the pixel layout, for example tiled formats or packed formats at bit level. What's implemented here is to add three new members to drm_format_info that could describe such formats: -

[PATCH v6 8/9] drm: Add macro to export functions only when CONFIG_DRM_DEBUG_SELFTEST is enabled

If we want to be able to write drmselftests for non-static core functions that are not intended to be used by drivers we need this functions to be exported. This adds a macro that is tied of CONFIG_DRM_DEBUG_SELFTEST, and uses that to export drm_internal_framebuffer_create, in order for

[PATCH v6 6/9] drm/afbc: Add AFBC modifier usage documentation

From: Brian Starkey AFBC is a flexible, proprietary, lossless compression protocol and format, with a number of defined DRM format modifiers. To facilitate consistency and compatibility between different AFBC producers and consumers, document the expectations for usage of the AFBC DRM format

[PATCH v6 0/9] Add method to describe tile/bit_level_packed formats

Changes since v5: - Added selftests for drm_internal_framebuffer_create - Added a macro to export internal function only when DRM_DEBUG_SELFTEST is enabled, suggested by Daniel Vetter, here [5]. - Cosmetic fixes suggested by Brian Starkey. - Rebased against drm-misc-next Changes

Re: [PATCH 21/21] drm/doc: kerneldoc for quirk_addfb_prefer_xbgr_30bpp

Hi, Daniel, On Thu, Oct 04, 2018 at 10:24:46PM +0200, Daniel Vetter wrote: > Shuts up warning noise. > > Signed-off-by: Daniel Vetter Reviewed-by: Alexandru Gheorghe > --- > include/drm/drm_mode_config.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [PATCH v5 9/9] drm/selftests: Add tests for drm_format_info* helpers

On Fri, Oct 19, 2018 at 05:29:15PM +0200, Daniel Vetter wrote: > On Fri, Oct 19, 2018 at 11:57:52AM +0100, Alexandru Gheorghe wrote: > > Add selftests for the following newly added functions: > > - drm_format_info_block_width > > - drm_format_info_block_height > > - drm_format_info_min_pitch >

Re: [PATCH v5 5/9] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0

On Fri, Oct 19, 2018 at 02:21:46PM +0100, Brian Starkey wrote: > Hi Alex, > > On Fri, Oct 19, 2018 at 11:57:48AM +0100, Alexandru Gheorghe wrote: > >For formats that are supported only with non-linear modifiers it > >doesn't make to much sense to define cpp or char_per_block, so that > >will be

Re: [PATCH v5 4/9] drm: mali-dp: Enable Mali-DP tiled buffer formats

On Fri, Oct 19, 2018 at 02:17:22PM +0100, Brian Starkey wrote: > Hi Alex, > > On Fri, Oct 19, 2018 at 11:57:47AM +0100, Alexandru Gheorghe wrote: > >Enable the following formats > >- DRM_FORMAT_X0L0: DP650 > >- DRM_FORMAT_X0L2: DP550, DP650 > > > >Signed-off-by: Alexandru Gheorghe > > A couple

Re: [PATCH v5 2/9] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

On Fri, Oct 19, 2018 at 02:09:38PM +0100, Brian Starkey wrote: > Hi Alex, > > On Fri, Oct 19, 2018 at 11:57:45AM +0100, Alexandru Gheorghe wrote: > >For some pixel formats .cpp structure in drm_format info it's not > >enough to describe the peculiarities of the pixel layout, for example > >tiled

Re: [PATCH v5 8/9] drm/selftest: Refactor test-drm_plane_helper

Hi Daniel, On Fri, Oct 19, 2018 at 05:14:51PM +0200, Daniel Vetter wrote: > On Fri, Oct 19, 2018 at 11:57:51AM +0100, Alexandru Gheorghe wrote: > > The idea is to split test implementations in different compilation > > units, but have one single place where we define the list of tests, > > in

Re: [PATCH v5 1/9] drm: fourcc: Convert drm_format_info kerneldoc to in-line member documentation

Hi Maxime, Thanks for the review, pushed the patch to drm-misc-next. On Fri, Oct 19, 2018 at 02:54:18PM +0200, Maxime Ripard wrote: > On Fri, Oct 19, 2018 at 11:57:44AM +0100, Alexandru Gheorghe wrote: > > In-line member documentation seems to be desired way of documenting > > structure members.

Re: [PATCH v2 2/2] drm/selftest: Add drm damage helper selftest

On Sat, Oct 20, 2018 at 01:27:48PM +, Deepak Singh Rawat wrote: > > > Hi Deepak, > > > > Something to consider, with this approach we kind of break the > > following behaviour: > > "Only tests enabled as module parameters are run, if no test is > > explicitly enabled then all of them are

Re: [PATCH v2 2/2] drm/selftest: Add drm damage helper selftest

Hi Deepak, Something to consider, with this approach we kind of break the following behaviour: "Only tests enabled as module parameters are run, if no test is explicitly enabled then all of them are run" What I think we should do is have just one header where we put the

Re: [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

On Tue, Oct 16, 2018 at 02:21:17PM +0200, Daniel Vetter wrote: > On Mon, Oct 15, 2018 at 04:11:41PM +, Deepak Singh Rawat wrote: > > > On Wed, Oct 10, 2018 at 05:16:43PM -0700, Deepak Rawat wrote: > > > > Selftest for drm damage helper iterator functions. > > > > > > > > Cc:

Re: [PATCH v3 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

Hi Swati, On Mon, Oct 15, 2018 at 01:39:54PM +0530, swatisha...@outlook.ms-acdc.office.com wrote: Btw, I can't reply to this address. > From: Vidya Srinivas > > > The following pixel formats are packed format that follows 4:2:2 > chroma sampling. For memory represenation each component is >

Re: [PATCH v3 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

Hi Swati, On Mon, Oct 15, 2018 at 01:39:54PM +0530, swatisha...@outlook.ms-acdc.office.com wrote: > From: Vidya Srinivas > > The following pixel formats are packed format that follows 4:2:2 > chroma sampling. For memory represenation each component is > allocated 16 bits each. Thus each pixel

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

On Thu, Oct 11, 2018 at 10:29:42AM +0200, Daniel Vetter wrote: > On Mon, Oct 08, 2018 at 09:52:04AM +0000, Alexandru-Cosmin Gheorghe wrote: > > Hi Daniel, > > > > Thanks for having a look. > > > > On Fri, Oct 05, 2018 at 04:51:48PM +0200, Daniel Vetter wrote: &g

Re: [PATCH v3 0/6] Add method to describe tile/bit_level_packed formats

On Fri, Oct 05, 2018 at 04:58:38PM +0200, Daniel Vetter wrote: > On Fri, Oct 05, 2018 at 09:26:43AM +0000, Alexandru-Cosmin Gheorghe wrote: > > There has been some discussion about extending drm core to handle > > linear tile formats, in the series sent by me here [1] and how to >

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

Hi Daniel, Thanks for having a look. On Fri, Oct 05, 2018 at 04:51:48PM +0200, Daniel Vetter wrote: > On Fri, Oct 05, 2018 at 09:26:47AM +0000, Alexandru-Cosmin Gheorghe wrote: > > For some pixel formats .cpp structure in drm_format info it's not > > enough to describe th

[PATCH v3 3/6] drm: mali-dp: Enable Mali-DP tiled buffer formats

Enable the following formats - DRM_FORMAT_X0L0: DP650 - DRM_FORMAT_X0L2: DP550, DP650 Signed-off-by: Alexandru Gheorghe Reviewed-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_hw.c | 14 +++--- drivers/gpu/drm/arm/malidp_planes.c | 23 +-- 2 files changed, 32

[PATCH v3 4/6] drm: Extend framebuffer_check to handle formats with cpp/char_per_block 0

For formats that are supported only with non-linear modifiers it doesn't make to much sense to define cpp or char_per_block, so that will be set to 0. This patch adds a restriction to force having a modifier attached when cpp/char_per_block is 0, and to bypass checking the pitch restriction.

[PATCH v3 5/6] drm/fourcc: Add AFBC yuv fourccs for Mali

From: Brian Starkey As we look to enable AFBC using DRM format modifiers, we run into problems which we've historically handled via vendor-private details (i.e. gralloc, on Android). AFBC (as an encoding) is fully flexible, and for example YUV data can be encoded into 1, 2 or 3 encoded

[PATCH v3 6/6] drm/afbc: Add AFBC modifier usage documentation

From: Brian Starkey AFBC is a flexible, proprietary, lossless compression protocol and format, with a number of defined DRM format modifiers. To facilitate consistency and compatibility between different AFBC producers and consumers, document the expectations for usage of the AFBC DRM format

[PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

For some pixel formats .cpp structure in drm_format info it's not enough to describe the peculiarities of the pixel layout, for example tiled formats or packed formats at bit level. What's implemented here is to add three new members to drm_format_info that could describe such formats: -

[PATCH v3 2/6] drm/fourcc: Add fourcc for Mali linear tiled formats

Mali-DP implements a number of tiled yuv formats which are not currently described in drm_fourcc.h. This adds those definitions and describes their memory layout by using the newly added char_per_block, block_w, block_h. Signed-off-by: Alexandru Gheorghe Reviewed-by: Liviu Dudau ---

[PATCH v3 0/6] Add method to describe tile/bit_level_packed formats

There has been some discussion about extending drm core to handle linear tile formats, in the series sent by me here [1] and how to handle formats that are intended to be used just with modifiers(particularly AFBC modifiers) on Brian series [2] and on IRC here [3] and [4]. Hence, this big-merged

Re: [PATCH v10 1/2] drm: Introduce new DRM_FORMAT_XYUV

On Thu, Oct 04, 2018 at 12:04:57PM +, Lisovskiy, Stanislav wrote: > On Wed, 2018-10-03 at 08:07 +0000, Alexandru-Cosmin Gheorghe wrote: > > On Wed, Oct 03, 2018 at 06:39:00AM +, Lisovskiy, Stanislav wrote: > > > On Tue, 2018-10-02 at 15:28 +, Alexandru-Cosmin Gheorghe

Re: [PATCH 1/4] drm: Add P010, P012, P016 format definitions and fourcc

ame question on the DRM_FORMAT_XYUV thread, do we need to wait for userspace to get new fourcc merged. > > https://lists.freedesktop.org/archives/intel-gfx/2018-September/174877.html > > /Juha-Pekka > > On 02.10.2018 18:00, Alexandru-Cosmin Gheorghe wrote: > >Hi, > > > >How is this

Re: [PATCH v10 1/2] drm: Introduce new DRM_FORMAT_XYUV

On Wed, Oct 03, 2018 at 06:39:00AM +, Lisovskiy, Stanislav wrote: > On Tue, 2018-10-02 at 15:28 +0000, Alexandru-Cosmin Gheorghe wrote: > > Hi, > > > > On Tue, Oct 02, 2018 at 02:15:42PM +0300, Stanislav Lisovskiy wrote: > > > v5: This is YUV444 packed format s

Re: [PATCH v10 1/2] drm: Introduce new DRM_FORMAT_XYUV

Hi, On Tue, Oct 02, 2018 at 02:15:42PM +0300, Stanislav Lisovskiy wrote: > v5: This is YUV444 packed format same as AYUV, but without alpha, > as supported by i915. > > v6: Removed unneeded initializer for new XYUV format. > > v7: Added is_yuv field initialization according to latest >

Re: [PATCH 1/4] drm: Add P010, P012, P016 format definitions and fourcc

Hi, How is this going on, anything holding it back from getting merged ? I'm interested in adding/using P010, [1] Thank you, Alex Gheorghe [1] https://lists.freedesktop.org/archives/dri-devel/2018-August/186963.html On Thu, Aug 30, 2018 at 03:41:11PM +0300, Juha-Pekka Heikkila wrote: > Add

Re: [PATCH 1/2] drm/atomic: Initialise planes with opaque alpha values

On Thu, Sep 20, 2018 at 11:03:12AM +0100, Kieran Bingham wrote: > Hi Alexandru, > > On 19/09/18 17:43, Alexandru-Cosmin Gheorghe wrote: > > Hi Kieran, > > > > > > On Wed, Sep 19, 2018 at 07:15:45PM +0300, Ville Syrjälä wrote: > >> On Wed, Sep 19, 2018

Re: [PATCH 1/2] drm/atomic: Initialise planes with opaque alpha values

Hi Kieran, On Wed, Sep 19, 2018 at 07:15:45PM +0300, Ville Syrjälä wrote: > On Wed, Sep 19, 2018 at 04:56:58PM +0100, Kieran Bingham wrote: > > Planes without an alpha property, using __drm_atomic_helper_plane_reset > > will have their plane state alpha initialised as zero, which represents > >

Re: [RFC v5 2/8] drm: Add Plane Degamma properties

Hi, On Sun, Sep 16, 2018 at 01:45:25PM +0530, Uma Shankar wrote: > Add Plane Degamma as a blob property and plane degamma size as > a range property. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to

Re: [RFC v5 0/8] Add Plane Color Properties

ok ok. Based on community feedback on interfaces, we will implement > IGT tests to validate plane color features. This is un-tested currently. > > Userspace implementation using these properties have been done in drm > hwcomposer by "Alexandru-Cosmin Gheorghe alexandru-cosmin.gheor...

Re: [PATCH] drm: rcar-du: Revert "drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying the logic"

Hi Kieran, On Mon, Sep 17, 2018 at 11:56:23AM +0100, Kieran Bingham wrote: > Hi Alexandru, > > On 17/09/18 10:10, Alexandru-Cosmin Gheorghe wrote: > > Hi Kieran, > > > > Sorry for that and thanks for getting to the bottom of it. > > No worries, > >

Re: [PATCH] drm: rcar-du: Revert "drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying the logic"

Hi Kieran, Sorry for that and thanks for getting to the bottom of it. On Fri, Sep 14, 2018 at 11:28:05PM +0100, Kieran Bingham wrote: > Hi Laurent, > > I've looked through a bit further to try to understand this issue and I > think I have identified a possible/probable cause. > > Before

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

Hi, On Mon, Sep 17, 2018 at 08:27:18AM +, Lisovskiy, Stanislav wrote: > On Fri, 2018-09-14 at 14:59 +0000, Alexandru-Cosmin Gheorghe wrote: > > On Fri, Sep 14, 2018 at 02:49:09PM +, Lisovskiy, Stanislav wrote: > > > On Fri, 2018-09-14 at 15:34 +0100, Saarinen, Jani

Re: [Intel-gfx] [PATCH v10 0/2] Add XYUV format support

gt; > > > Currently for userspace we have VLC(checked with Juha-Pekka) and > > > also IGT > > > test case. > > > > > > I think those guys were from ARM and they were adding also support > > > for > > > XYUV. The only difference was

Re: [PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

On Tue, Sep 11, 2018 at 04:45:25PM +0300, Ville Syrjälä wrote: > On Tue, Sep 11, 2018 at 02:20:22PM +0100, Alexandru-Cosmin Gheorghe wrote: > > Hi Ville, > > > > On Tue, Sep 11, 2018 at 03:27:09PM +0300, Ville Syrjälä wrote: > > > On Mon, Sep 10, 2018 at 06:29:46PM +

Re: [PATCH v2] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

Hi Ville, On Tue, Sep 11, 2018 at 03:27:09PM +0300, Ville Syrjälä wrote: > On Mon, Sep 10, 2018 at 06:29:46PM +0100, Alexandru Gheorghe wrote: > > DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear > > to me, so try to clarify that with a bit of ascii graphics. > > > > Changes

Re: [PATCH] drm: Describe pixel_blend_mode in drm_plane_state

Hi Sean, On Fri, Aug 31, 2018 at 11:09:25AM -0400, Sean Paul wrote: > From: Sean Paul > > Adds docs for pixel_blend_mode in drm_plane_state. Fixes the warning > found by kbuild test robot: > > htmldocs: include/drm/drm_plane.h:189: warning: Function parameter or member > 'pixel_blend_mode'

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

On Mon, Sep 03, 2018 at 09:26:24AM +0200, Daniel Vetter wrote: > On Fri, Aug 31, 2018 at 05:26:37PM +0100, Alexandru-Cosmin Gheorghe wrote: > > Hi, > > > > On Fri, Aug 31, 2018 at 05:12:24PM +0200, Daniel Vetter wrote: > > > On Fri, Aug 31, 2018 at 02:20:3

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

Hi, On Fri, Aug 31, 2018 at 05:12:24PM +0200, Daniel Vetter wrote: > On Fri, Aug 31, 2018 at 02:20:31PM +0300, Ville Syrjälä wrote: > > On Fri, Aug 31, 2018 at 10:14:14AM +0200, Daniel Vetter wrote: > > > On Thu, Aug 23, 2018 at 06:43:40PM +0100, Alexandru-Cosmin Gheorghe wro

Re: [PATCH v2] drm: Fix crtc color management when doing suspend/resume

On Tue, Aug 28, 2018 at 04:48:45PM +0100, Brian Starkey wrote: > Hi Alex, > > On Tue, Aug 28, 2018 at 04:33:20PM +0100, Alexandru Gheorghe wrote: > >When doing suspend/resume drivers usually use the > >drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the > >state and then

Re: [PATCH v2] drm: Fix crtc color management when doing suspend/resume

On Tue, Aug 28, 2018 at 06:46:07PM +0300, Ville Syrjälä wrote: > On Tue, Aug 28, 2018 at 04:33:20PM +0100, Alexandru Gheorghe wrote: > > When doing suspend/resume drivers usually use the > > drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the > > state and then re-comitting it.

Re: [PATCH 1/4] drm: Add Y210, Y212, Y216 format definitions and fourcc

Hi Swati, On Mon, Aug 27, 2018 at 12:17:45PM +0530, Swati Sharma wrote: > From: Vidya Srinivas > > The following pixel formats are packed format that follows 4:2:2 > chroma sampling. For memory represenation each component is > allocated 16 bits each. Thus each pixel occupies a DWORD. > >

Re: [PATCH] drm: Fix crtc color management when doing suspend/resume

Hi, On Fri, Aug 24, 2018 at 09:51:03AM +0200, Maarten Lankhorst wrote: > Op 23-08-18 om 17:11 schreef Alexandru Gheorghe: > > When doing suspend/resume drivers usually use the > > drm_atomic_helper_suspend/drm_atomic_helper_resume pair for saving the > > state and then re-comitting it. > > > >

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

On Thu, Aug 23, 2018 at 08:25:46PM +0300, Ville Syrjälä wrote: > On Thu, Aug 23, 2018 at 06:19:31PM +0100, Alexandru-Cosmin Gheorghe wrote: > > On Thu, Aug 23, 2018 at 05:30:36PM +0300, Ville Syrjälä wrote: > > > On Wed, Aug 22, 2018 at 09:48:29PM +0200, Daniel Vetter wrote: >

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

On Wed, Aug 22, 2018 at 10:18:51PM +0200, Daniel Vetter wrote: > On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexandru Gheorghe wrote: > > The previous patch added tile_w and tile_h, which represent the > > horizontal and vertical sizes of a tile. > > > > This one uses that to plumb through drm

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

On Thu, Aug 23, 2018 at 05:30:36PM +0300, Ville Syrjälä wrote: > On Wed, Aug 22, 2018 at 09:48:29PM +0200, Daniel Vetter wrote: > > On Wed, Aug 22, 2018 at 4:05 PM, Alexandru-Cosmin Gheorghe > > wrote: > > > On Wed, Aug 22, 2018 at 04:45:34PM +0300, Ville Syrjälä wrot

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

On Wed, Aug 22, 2018 at 04:45:34PM +0300, Ville Syrjälä wrote: > On Wed, Aug 22, 2018 at 02:36:06PM +0100, Alexandru-Cosmin Gheorghe wrote: > > On Wed, Aug 22, 2018 at 04:18:54PM +0300, Ville Syrjälä wrote: > > > On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexan

Re: [PATCH v2 4/5] drm: Add support for handling linear tile formats

On Wed, Aug 22, 2018 at 04:18:54PM +0300, Ville Syrjälä wrote: > On Tue, Aug 21, 2018 at 07:30:03PM +0100, Alexandru Gheorghe wrote: > > The previous patch added tile_w and tile_h, which represent the > > horizontal and vertical sizes of a tile. > > > > This one uses that to plumb through drm

Re: [PATCH v2 1/5] drm/fourcc: Add new fourcc for malidp uncompressed formats

Hi, On Wed, Aug 22, 2018 at 01:39:16PM +0300, Juha-Pekka Heikkilä wrote: > > On 22.08.2018 12:40, Daniel Vetter wrote: > >On Tue, Aug 21, 2018 at 8:30 PM, Alexandru Gheorghe > > wrote: > >>Malidp implements a number of yuv buffer formats which are not > >>currently described in drm_fourcc.h. >

Re: [PATCH] drm/fourcc: Add DOC: overview comment

On Tue, Aug 21, 2018 at 06:51:26PM +0200, Daniel Vetter wrote: > On Tue, Aug 21, 2018 at 05:16:11PM +0100, Brian Starkey wrote: > > There's a number of things which haven't previously been documented > > around the usage of format modifiers. Capture the current > > understanding in an overview

Re: [RFC v4 7/8] drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms

Hi Uma, On Fri, Aug 17, 2018 at 07:48:50PM +0530, Uma Shankar wrote: > Implement Plane Gamma feature for BDW and Gen9 platforms. > > v2: Used newly added drm_color_lut_ext structure for enhanced > precision for Gamma LUT entries. > > v3: Rebase > > Signed-off-by: Uma Shankar > --- >

Re: [RFC v4 5/8] drm: Define helper function for plane color enabling

Hi Uma, On Fri, Aug 17, 2018 at 07:48:48PM +0530, Uma Shankar wrote: > Define helper function to enable Plane color features > to attach plane color properties to plane structure. > > v2: Rebase > > v3: Modiefied the function to use updated property names. > > v4: Rebase > > Signed-off-by:

Re: [RFC v4 4/8] drm: Add Plane Gamma properties

Hi Uma, On Fri, Aug 17, 2018 at 07:48:47PM +0530, Uma Shankar wrote: > Add plane gamma as blob property and size as a > range property. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to instantiate > these

Re: [RFC v4 3/8] drm: Add Plane CTM property

Hi Uma, On Fri, Aug 17, 2018 at 07:48:46PM +0530, Uma Shankar wrote: > Add a blob property for plane CSC usage. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to instantiate > these properties and removed

Re: [RFC v4 2/8] drm: Add Plane Degamma properties

Hi Uma, On Fri, Aug 17, 2018 at 07:48:45PM +0530, Uma Shankar wrote: > Add Plane Degamma as a blob property and plane degamma size as > a range property. > > v2: Rebase > > v3: Fixed Sean, Paul's review comments. Moved the property from > mode_config to drm_plane. Created a helper function to

Re: [RFC v4 1/8] drm: Add Enhanced Gamma LUT precision structure

Hi Uma, On Fri, Aug 17, 2018 at 07:48:44PM +0530, Uma Shankar wrote: > Existing LUT precision structure is having only 16 bit > precision. This is not enough for upcoming enhanced hardwares > and advance usecases like HDR processing. Hence added a new > structure with 32 bit precision values.

Re: [PATCH] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

Hi, On Tue, Aug 21, 2018 at 10:54:52AM +0200, Daniel Vetter wrote: > On Mon, Aug 20, 2018 at 10:10:52AM +0100, Alexandru-Cosmin Gheorghe wrote: > > On Tue, Aug 14, 2018 at 10:36:58AM +0200, Daniel Vetter wrote: > > > On Fri, Aug 10, 2018 at 06:50:31PM +0100, Alexan

Re: [PATCH] drm: Clarify DRM_MODE_REFLECT_X/Y documentation

On Tue, Aug 14, 2018 at 10:36:58AM +0200, Daniel Vetter wrote: > On Fri, Aug 10, 2018 at 06:50:31PM +0100, Alexandru Gheorghe wrote: > > DRM_MODE_REFLECT_X and DRM_MODE_REFLECT_Y meaning seems a bit unclear > > to me, so try to clarify that with a bit of ascii graphics. > > > > Signed-off-by:

Re: [PATCH 2/3] drm: Make drm_gem_fb_alloc available for drivers to use

On Wed, Aug 15, 2018 at 01:54:12PM +0200, Daniel Vetter wrote: > On Wed, Aug 15, 2018 at 12:08:38PM +0100, Liviu Dudau wrote: > > On Thu, Jul 26, 2018 at 03:10:04PM +0100, Alexandru Gheorghe wrote: > > > Some drivers can't use drm_gem_fb_create, so instead of copying the > > > logic that does the

Re: [PATCH v5 1/2] drm: Introduce new DRM_FORMAT_XYUV

Hi Stanislav, FYI, we are trying to add same format under a slightly different name. See https://lists.freedesktop.org/archives/dri-devel/2018-July/184598.html On Fri, Aug 10, 2018 at 04:19:03PM +0300, StanLis wrote: > From: Stanislav Lisovskiy > > v5: This is YUV444 packed format same as

Re: [PATCH v3 09/10] drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the logic

Hi Eric, On Mon, Aug 06, 2018 at 12:58:20PM -0700, Eric Anholt wrote: > Alexandru Gheorghe writes: > > > A new helper function(__drm_atomic_helper_plane_reset) has been added > > for linking a plane with its state and resetting the core > > properties(alpha, rotation, etc.) to their default

Re: [PATCH v3 10/10] drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the logic

Hi Sinclair, Is it ok if I merge this patch through drm-misc-next ? Thank you, Alex Gheorghe On Mon, Aug 06, 2018 at 09:57:53AM -0700, Sinclair Yeh wrote: > Acked-by: Sinclair Yeh > > On Sat, Aug 04, 2018 at 05:15:30PM +0100, Alexandru Gheorghe wrote: > > A new helper

Re: [PATCH v3 00/10] Add helper for plane reset

On Mon, Aug 06, 2018 at 02:45:42PM +0300, Laurent Pinchart wrote: Hi Laurent, > Hi Alex, > > On Monday, 6 August 2018 14:07:27 EEST Alexandru-Cosmin Gheorghe wrote: > > Hi, > > > > On Sat, Aug 04, 2018 at 05:15:20PM +0100, Alexandru Gheorghe wrote: > > > N

Re: [PATCH v3 00/10] Add helper for plane reset

Hi, On Sat, Aug 04, 2018 at 05:15:20PM +0100, Alexandru Gheorghe wrote: > No significant change since v2, fixed a spelling mistake and > added/removed some newlines in 01 and 07 patches. > > I plan to apply the first patch of the series and the patches for > the drivers maintained through

Re: [PATCH v3 06/10] drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic

On Mon, Aug 06, 2018 at 08:29:13AM +0200, Philipp Zabel wrote: Hi, > Hi Alexandru, > > On Sat, 2018-08-04 at 17:15 +0100, Alexandru Gheorghe wrote: > > A new helper function(__drm_atomic_helper_plane_reset) has been added > > for linking a plane with its state and resetting the core > >

Re: [PATCH 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset

On Tue, Jul 24, 2018 at 10:16:56AM +0200, Boris Brezillon wrote: > On Tue, 24 Jul 2018 09:14:02 +0100 > Alexandru-Cosmin Gheorghe wrote: > > > On Tue, Jul 24, 2018 at 09:48:53AM +0200, Philipp Zabel wrote: > > > Hi Alexandru, > > > > > > On Fri, 201

Re: [PATCH 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset

On Tue, Jul 24, 2018 at 09:48:53AM +0200, Philipp Zabel wrote: > Hi Alexandru, > > On Fri, 2018-07-20 at 22:15 +0100, Alexandru Gheorghe wrote: > > There are a lot of drivers that subclass drm_plane_state, all of them > > duplicate the code that links toghether the plane with plane_state. > > >

Re: [PATCH 09/10] drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the logic

Hi Maxime, On Tue, Jul 24, 2018 at 08:57:20AM +0200, Maxime Ripard wrote: > On Fri, Jul 20, 2018 at 10:15:08PM +0100, Alexandru Gheorghe wrote: > > Signed-off-by: Alexandru Gheorghe > > --- > > drivers/gpu/drm/vc4/vc4_plane.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > >

Re: [PATCH v2 3/3] drm: mali-dp: Set encoder possible_clones

On Fri, Jul 13, 2018 at 11:47:33AM -0400, Sean Paul wrote: > On Fri, Jul 13, 2018 at 11:40:13AM -0400, Sean Paul wrote: > > On Fri, Jul 13, 2018 at 04:11:00PM +0100, Alexandru Gheorghe wrote: > > > Set possible_clones field to report that the writeback connector and > > > the one driving the

Re: [RFC v3 0/8] Add Plane Color Properties

Hi Uma, On Tue, Jun 12, 2018 at 04:01:31AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of > >Alexandru-Cosmin Gheorghe > >Sent: Monday, June 11, 2018 3:47 PM >

Re: [PATCH] drm: mali-dp: Set encoder possible_clones

On Thu, Jul 12, 2018 at 03:37:36PM +0300, Ville Syrjälä wrote: > On Thu, Jul 12, 2018 at 09:48:56AM +0100, Alexandru Gheorghe wrote: > > Set possible_clones field to report that the writeback connector and > > the one driving the display could be enabled at the same time. > > > > Signed-off-by:

Re: [PATCH] drm/probe-helper: Fix modes reporting for writeback connector

On Thu, Jul 12, 2018 at 10:55:47AM +0200, Daniel Vetter wrote: > On Thu, Jul 12, 2018 at 09:48:02AM +0100, Alexandru Gheorghe wrote: > > Writeback connector is reported as disconnected, currently this causes > > the setting of the edid property to null and then exit. > > In order to properly get

Re: [PATCH] drm/atomic: Set current atomic state in drm_private_state

On Fri, Jun 15, 2018 at 11:38:44PM +0300, Ville Syrjälä wrote: > On Wed, May 30, 2018 at 11:22:27PM +0300, Ville Syrjälä wrote: > > On Wed, May 30, 2018 at 06:30:52PM +0100, Alexandru Gheorghe wrote: > > > drm_private_state has a back pointer to the drm_atomic_state, > > > however that was not

Re: [RFC v3 0/8] Add Plane Color Properties

On Tue, Jun 12, 2018 at 04:01:31AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of > >Alexandru-Cosmin Gheorghe > >Sent: Monday, June 11, 2018 3:47 PM > >To: Shankar

Re: [RFC v3 0/8] Add Plane Color Properties

Hi Uma, Any progress on userspace for this? I was thinking on working on using this in drm_hwcomposer. Thank you, Alex Gheorghe On Fri, Mar 09, 2018 at 11:47:41PM +0530, Uma Shankar wrote: > This patch series adds properties for plane color features. It adds > properties for degamma used to

  1   2   >