The Graphics and DRM Microconference was accepted for Linux Plumbers
2024! Please, submit your proposal in the following page:
https://lpc.events/event/18/abstracts/
Remember to select "Graphics & DRM MC" in the Track field. The deadline
for submissions is Sunday 30th June. The
amdgpu can handle async flips on overlay planes, so mark it as true
during the plane initialization.
Signed-off-by: André Almeida
---
v4: new patch
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm
Different planes may have different capabilities of doing async flips,
so create a field to let drivers allow async flip per plane type.
Signed-off-by: André Almeida
---
v4: new patch
drivers/gpu/drm/drm_atomic_uapi.c | 4 ++--
drivers/gpu/drm/drm_plane.c | 3 +++
include/drm/drm_plane.h
Allow userspace to use explicit synchronization with atomic async flips.
That means that the flip will wait for some hardware fence, and then
will flip as soon as possible (async) in regard of the vblank.
Signed-off-by: André Almeida
---
v4: no changes
drivers/gpu/drm/drm_atomic_uapi.c | 4
://lore.kernel.org/dri-devel/20240116045159.1015510-1-andrealm...@igalia.com/
André Almeida (3):
drm/atomic: Allow userspace to use explicit sync with atomic async
flips
drm: Allow drivers to choose plane types to async flip
drm/amdgpu: Make it possible to async flip overlay planes
amdgpu can handle async flips on overlay planes, so mark it as true
during the plane initialization.
Signed-off-by: André Almeida
---
v4: new patch
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm
Allow userspace to use explicit synchronization with atomic async flips.
That means that the flip will wait for some hardware fence, and then
will flip as soon as possible (async) in regard of the vblank.
Signed-off-by: André Almeida
---
v4: no changes
drivers/gpu/drm/drm_atomic_uapi.c | 4
Different planes may have different capabilities of doing async flips,
so create a field to let drivers allow async flip per plane type.
Signed-off-by: André Almeida
---
v4: new patch
drivers/gpu/drm/drm_atomic_uapi.c | 4 ++--
drivers/gpu/drm/drm_plane.c | 3 +++
include/drm/drm_plane.h
://lore.kernel.org/dri-devel/20240116045159.1015510-1-andrealm...@igalia.com/
André Almeida (3):
drm/atomic: Allow userspace to use explicit sync with atomic async
flips
drm: Allow drivers to choose plane types to async flip
drm/amdgpu: Make it possible to async flip overlay planes
Hi Sima,
Em 30/01/2024 07:56, Daniel Vetter escreveu:
On Sun, Jan 28, 2024 at 06:25:15PM -0300, André Almeida wrote:
AMD GPUs can do async flips with changes on more properties than just
the FB ID, so implement a custom check_async_props for AMD planes.
Allow amdgpu to do async flips
Hi Pekka,
Em 29/01/2024 05:49, Pekka Paalanen escreveu:
On Sun, 28 Jan 2024 18:25:13 -0300
André Almeida wrote:
Some hardware are more flexible on what they can flip asynchronously, so
rework the plane check so drivers can implement their own check, lifting
up some of the restrictions
AMD GPUs can do async flips with changes on more properties than just
the FB ID, so implement a custom check_async_props for AMD planes.
Allow amdgpu to do async flips with overlay planes as well.
Signed-off-by: André Almeida
---
v3: allow overlay planes
.../amd/display/amdgpu_dm
:
https://lore.kernel.org/dri-devel/20240116045159.1015510-1-andrealm...@igalia.com/
André Almeida (3):
drm/atomic: Allow drivers to write their own plane check for async
flips
drm/atomic: Allow userspace to use explicit sync with atomic async
flips
drm/amdgpu: Implement
Some hardware are more flexible on what they can flip asynchronously, so
rework the plane check so drivers can implement their own check, lifting
up some of the restrictions.
Signed-off-by: André Almeida
---
v3: no changes
drivers/gpu/drm/drm_atomic_uapi.c | 62
Allow userspace to use explicit synchronization with atomic async flips.
That means that the flip will wait for some hardware fence, and then
will flip as soon as possible (async) in regard of the vblank.
Signed-off-by: André Almeida
---
v3: new patch
drivers/gpu/drm/drm_atomic_uapi.c | 3
Hi Ville,
Em 19/01/2024 15:25, Ville Syrjälä escreveu:
On Fri, Jan 19, 2024 at 03:12:35PM -0300, André Almeida wrote:
AMD GPUs can do async flips with changes on more properties than just
the FB ID, so implement a custom check_async_props for AMD planes.
Allow amdgpu to do async flips
for now is to use TEST_ONLY commits.
Signed-off-by: André Almeida
---
v2: Drop overlay plane option for now
.../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 29 +++
1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
b/drivers/gpu
. Userspace can query if a driver supports this with TEST_ONLY
commits.
I will left overlay planes for a next iteration.
Changes from v1:
- Drop overlay planes option for now
v1:
https://lore.kernel.org/dri-devel/20240116045159.1015510-1-andrealm...@igalia.com/
André
André Almeida (2):
drm
Some hardware are more flexible on what they can flip asynchronously, so
rework the plane check so drivers can implement their own check, lifting
up some of the restrictions.
Signed-off-by: André Almeida
---
drivers/gpu/drm/drm_atomic_uapi.c | 62 ++-
include/drm
+ Joshua
Em 16/01/2024 10:14, Pekka Paalanen escreveu:
On Tue, 16 Jan 2024 08:50:59 -0300
André Almeida wrote:
Hi Pekka,
Em 16/01/2024 06:45, Pekka Paalanen escreveu:
On Tue, 16 Jan 2024 01:51:57 -0300
André Almeida wrote:
Hi,
AMD hardware can do more on the async flip path than
Hi Pekka,
Em 16/01/2024 06:45, Pekka Paalanen escreveu:
On Tue, 16 Jan 2024 01:51:57 -0300
André Almeida wrote:
Hi,
AMD hardware can do more on the async flip path than just the primary plane, so
to lift up the current restrictions, this patchset allows drivers to write their
own check
AMD GPUs can do async flips with overlay planes and other props rather
than just FB ID, so implement a custom check_async_props for AMD planes.
Signed-off-by: André Almeida
---
.../amd/display/amdgpu_dm/amdgpu_dm_plane.c | 30 +++
1 file changed, 30 insertions(+)
diff --git
want to expand the other object types (crtc, connector) we would
need to add their own drm_XXX_funcs, so feedbacks are welcome!
André
André Almeida (2):
drm/atomic: Allow drivers to write their own plane check for async
flips
drm/amdgpu: Implement check_async_props for planes
Some hardware are more flexible on what they can flip asynchronously, so
rework the plane check so drivers can implement their own check, lifting
up some of the restrictions.
Signed-off-by: André Almeida
---
drivers/gpu/drm/drm_atomic_uapi.c | 62 ++-
include/drm
Em 11/01/2024 14:59, Xaver Hugl escreveu:
Am Do., 11. Jan. 2024 um 18:13 Uhr schrieb Simon Ser
mailto:cont...@emersion.fr>>:
Are we sure that all drivers handle these two props properly with async
page-flips? This is a new codepath not taken by the legacy uAPI.
I've only tested on
Hi Xaver,
Em 11/01/2024 13:56, Xaver Hugl escreveu:
Like with FB_ID, the driver never has to do bandwidth validation to use
these properties, so there's no reason not to allow them.
Signed-off-by: Xaver Hugl
Reviewed-by: André Almeida
---
drivers/gpu/drm/drm_atomic_uapi.c | 4 +++-
1
From: Pekka Paalanen
Specify how the atomic state is maintained between userspace and
kernel, plus the special case for async flips.
Signed-off-by: Pekka Paalanen
Signed-off-by: André Almeida
---
This is a standalone patch from the following serie, the other patches are
already merged:
https
Em 23/11/2023 13:24, Simon Ser escreveu:
Thanks! This iteration of the first 3 patches LGTM, I've pushed them to
drm-misc-next. I've made two adjustments to make checkpatch.pl happy:
Thank you!
- s/uint64_t/u64/
- Fix indentation for a drm_dbg_atomic()
ops :)
Hi Hamza,
Em 22/11/2023 17:23, Hamza Mahfooz escreveu:
Hi André,
On 11/22/23 11:19, André Almeida wrote:
Hi,
This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC
through
the atomic API. This feature is already available via the legacy API.
The use
case is to be able
From: Pekka Paalanen
Specify how the atomic state is maintained between userspace and
kernel, plus the special case for async flips.
Signed-off-by: Pekka Paalanen
Signed-off-by: André Almeida
---
v9:
- no changes
v8:
- no changes
v7:
- add a note that drivers can make exceptions for ad-hoc
-by: Simon Ser
Reviewed-by: André Almeida
Reviewed-by: Alex Deucher
Signed-off-by: André Almeida
---
v9: no changes
---
---
drivers/gpu/drm/drm_ioctl.c | 4
include/uapi/drm/drm.h | 10 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_ioctl.c
to
something else. For instance, Xorg falls back to a blit.
Another option is to wait as close to the next vblank as
possible before performing the page-flip to reduce latency.
Signed-off-by: Simon Ser
Reviewed-by: Alex Deucher
Co-developed-by: André Almeida
Signed-off-by: André Almeida
---
v9
Given that prop changes may lead to modesetting, which would defeat the
fast path of the async flip, refuse any atomic prop change for async
flips in atomic API. The only exception is the framebuffer ID to flip
to. Currently the only plane type supported is the primary one.
Signed-off-by: André
the KMS atomic state set
v3:
https://lore.kernel.org/dri-devel/20220929184307.258331-1-cont...@emersion.fr/
André Almeida (1):
drm: Refuse to async flip with atomic prop changes
Pekka Paalanen (1):
drm/doc: Define KMS atomic state set
Simon Ser (2):
drm: allow DRM_MODE_PAGE_FLIP_ASYNC
Document what each amdgpu driver reset method does.
Signed-off-by: André Almeida
---
v2: Add more details and small correction (Alex)
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b
DRM atomic API should reject modesetting during an async flip, so
test if the kernel properly rejects to flip with prop changes.
Signed-off-by: André Almeida
---
tests/kms_async_flips.c | 68 +
1 file changed, 68 insertions(+)
diff --git a/tests
From: Simon Ser
This adds a simple test for DRM_MODE_PAGE_FLIP_ASYNC with the
atomic uAPI.
Signed-off-by: Simon Ser
Signed-off-by: André Almeida
---
include/drm-uapi/drm.h | 8
tests/kms_async_flips.c | 37 +
2 files changed, 45 insertions
This series adds tests for async page flip for DRM Atomic API. Kernel patches:
https://lore.kernel.org/dri-devel/20231025005318.293690-1-andrealm...@igalia.com/
André Almeida (1):
tests/kms_async_flips: Add test for atomic prop changes
Simon Ser (1):
tests/kms_async_flips: add atomic test
Document what each amdgpu driver reset method does.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index a79d53bdbe13
Almeida
Reviewed-by: Alex Deucher
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index dec6e43e7198
From: Pekka Paalanen
Specify how the atomic state is maintained between userspace and
kernel, plus the special case for async flips.
Signed-off-by: Pekka Paalanen
Signed-off-by: André Almeida
---
v8:
- no changes
v7:
- add a note that drivers can make exceptions for ad-hoc prop changes
- add
Signed-off-by: André Almeida
---
v8: add a check for plane type, we can only flip primary planes
v7: drop the mode_id exception for prop changes
---
---
drivers/gpu/drm/drm_atomic_uapi.c | 54 +++--
drivers/gpu/drm/drm_crtc_internal.h | 2 +-
drivers/gpu/drm
missing atomic support for async flips. New drivers should not
set this flag, instead they should support atomic async flips (if
they support async flips at all). IOW, we don't want more drivers
with async flip support for legacy but not atomic.
Signed-off-by: Simon Ser
Reviewed-by: André Almeida
-by: Simon Ser
Reviewed-by: André Almeida
Reviewed-by: Alex Deucher
Signed-off-by: André Almeida
---
drivers/gpu/drm/drm_ioctl.c | 5 +
include/uapi/drm/drm.h | 10 +-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm
to
something else. For instance, Xorg falls back to a blit.
Another option is to wait as close to the next vblank as
possible before performing the page-flip to reduce latency.
Signed-off-by: Simon Ser
Reviewed-by: Alex Deucher
Co-developed-by: André Almeida
Signed-off-by: André Almeida
/20220929184307.258331-1-cont...@emersion.fr/
André Almeida (1):
drm: Refuse to async flip with atomic prop changes
Pekka Paalanen (1):
drm/doc: Define KMS atomic state set
Simon Ser (4):
drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits
drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP
drm: introduce
-by: André Almeida
---
v7: drop the mode_id exception for prop changes
---
drivers/gpu/drm/drm_atomic_uapi.c | 47 +++--
drivers/gpu/drm/drm_crtc_internal.h | 2 +-
drivers/gpu/drm/drm_mode_object.c | 2 +-
3 files changed, 46 insertions(+), 5 deletions(-)
diff --git
From: Pekka Paalanen
Specify how the atomic state is maintained between userspace and
kernel, plus the special case for async flips.
Signed-off-by: Pekka Paalanen
Signed-off-by: André Almeida
---
v7:
- add a note that drivers can make exceptions for ad-hoc prop changes
- add a note about
Almeida
Reviewed-by: Alex Deucher
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 9d5742923aed
-by: Simon Ser
Reviewed-by: André Almeida
Reviewed-by: Alex Deucher
Signed-off-by: André Almeida
---
drivers/gpu/drm/drm_ioctl.c | 5 +
include/uapi/drm/drm.h | 10 +-
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm
missing atomic support for async flips. New drivers should not
set this flag, instead they should support atomic async flips (if
they support async flips at all). IOW, we don't want more drivers
with async flip support for legacy but not atomic.
Signed-off-by: Simon Ser
Reviewed-by: André Almeida
the KMS atomic state set
v3:
https://lore.kernel.org/dri-devel/20220929184307.258331-1-cont...@emersion.fr/
André Almeida (1):
drm: Refuse to async flip with atomic prop changes
Pekka Paalanen (1):
drm/doc: Define KMS atomic state set
Simon Ser (4):
drm: allow DRM_MODE_PAGE_FLIP_ASYNC
to
something else. For instance, Xorg falls back to a blit.
Another option is to wait as close to the next vblank as
possible before performing the page-flip to reduce latency.
Signed-off-by: Simon Ser
Reviewed-by: Alex Deucher
Co-developed-by: André Almeida
Signed-off-by: André Almeida
On 10/16/23 16:52, Pekka Paalanen wrote:
On Mon, 16 Oct 2023 15:42:16 +0200
André Almeida wrote:
Hi Pekka,
On 10/16/23 14:18, Pekka Paalanen wrote:
On Mon, 16 Oct 2023 12:52:32 +0200
André Almeida wrote:
Hi Michel,
On 8/17/23 12:37, Michel Dänzer wrote:
On 8/15/23 20:57, André
Hi Pekka,
On 10/16/23 14:18, Pekka Paalanen wrote:
On Mon, 16 Oct 2023 12:52:32 +0200
André Almeida wrote:
Hi Michel,
On 8/17/23 12:37, Michel Dänzer wrote:
On 8/15/23 20:57, André Almeida wrote:
From: Pekka Paalanen
Specify how the atomic state is maintained between userspace
Hi Michel,
On 8/17/23 12:37, Michel Dänzer wrote:
On 8/15/23 20:57, André Almeida wrote:
From: Pekka Paalanen
Specify how the atomic state is maintained between userspace and
kernel, plus the special case for async flips.
Signed-off-by: Pekka Paalanen
Signed-off-by: André Almeida
,height} and
fb_plane_{width,height} call to drm_format_info_plane_{width,height}
and remove them.
Signed-off-by: Carlos Eduardo Gallo Filho
Reviewed-by: André Almeida
than that,
Reviewed-by: André Almeida
Signed-off-by: Carlos Eduardo Gallo Filho
---
include/drm/drm_fourcc.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
index 532ae78ca747..ccf91daa4307 100644
--- a/include/drm
Create a section that specifies how to deal with DRM device resets for
kernel and userspace drivers.
Acked-by: Pekka Paalanen
Acked-by: Sebastian Wick
Signed-off-by: André Almeida
---
v8 changes:
- Add acked-by tags
v7:
https://lore.kernel.org/dri-devel/20230818200642.276735-1-andrealm
Em 11/09/2023 14:21, Hamza Mahfooz escreveu:
On 9/11/23 13:12, André Almeida wrote:
As suggested by Christian at [0], this patchset merges all debug modules
parameters and creates a new one for disabling soft recovery:
Maybe we can overload the amdgpu_gpu_recovery module option
Create a module option to disable soft recoveries on amdgpu, making
every recovery go through the device reset path. This option makes
easier to force device resets for testing and debugging purposes.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu
Merge all developer debug options available as separated module
parameters in one, making it obvious that are for developers.
Drop the obsolete module options in favor of the new ones.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
v3:
- move from include/amd_shared.h to amdgpu
lore.kernel.org/lkml/20230824162505.173399-1-andrealm...@igalia.com/
André Almeida (2):
drm/amdgpu: Merge debug module parameters
drm/amdgpu: Create an option to disable soft recovery
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
drivers/gpu
Christian, Alex, I think this series is ready to be picked as well.
Em 31/08/2023 12:29, André Almeida escreveu:
As suggested by Christian at [0], this patchset merges all debug modules
parameters and creates a new one for disabling soft recovery:
Maybe we can overload the amdgpu_gpu_recovery
1-andrealm...@igalia.com/
- Drop "Mark contexts guilty for causing soft recoveries" patch
- Use GFP_NOWAIT for devcoredump allocatio
André Almeida (5):
drm/amdgpu: Allocate coredump memory in a nonblocking way
drm/amdgpu: Rework coredump to use memory dynamically
drm/amdgpu: Encapsulate a
Instead of storing coredump information inside amdgpu_device struct,
move if to a proper separated struct and allocate it dynamically. This
will make it easier to further expand the logged information.
Signed-off-by: André Almeida
Reviewed-by: Shashank Sharma
---
v6: no change
v5: no change
v4
During a GPU reset, a normal memory reclaim could block to reclaim
memory. Giving that coredump is a best effort mechanism, it shouldn't
disturb the reset path. Change its memory allocation flag to a
nonblocking one.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
v5: no change
Giving that we use codedump just for device resets, move it's functions
and structs to a more semantic file, the amdgpu_reset.{c, h}.
Signed-off-by: André Almeida
Reviewed-by: Shashank Sharma
---
v6: no change
v5: no change
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 9 ---
drivers/gpu
.
Signed-off-by: André Almeida
Reviewed-by: Shashank Sharma
---
v6: no change
---
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
b/drivers/gpu/drm/amd
To better organize struct amdgpu_device, keep all reset information
related fields together in a separated struct.
Signed-off-by: André Almeida
Reviewed-by: Shashank Sharma
---
v6: no changes
v5: new patch, as required by Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 34
Create a module option to disable soft recoveries on amdgpu, making
every recovery go through the device reset path. This option makes
easier to force device resets for testing and debugging purposes.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu
Merge all developer debug options available as separated module
parameters in one, making it obvious that are for developers.
Drop the obsolete module options in favor of the new ones.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
v3:
- move from include/amd_shared.h to amdgpu
.c
v2: https://lore.kernel.org/lkml/20230830220808.421935-1-andrealm...@igalia.com/
- drop old module params
- use BIT() macros
- replace global var with adev-> vars
v1: https://lore.kernel.org/lkml/20230824162505.173399-1-andrealm...@igalia.com/
André Almeida (2):
drm/amdgpu: Merge debug module paramete
Merge all developer debug options available as separated module
parameters in one, making it obvious that are for developers.
Drop the obsolete module options in favor of the new ones.
Signed-off-by: André Almeida
---
v2:
- drop old module params
- use BIT() macros
- replace global var
Create a module option to disable soft recoveries on amdgpu, making
every recovery go through the device reset path. This option makes
easier to force device resets for testing and debugging purposes.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu
ev-> vars
v1: https://lore.kernel.org/lkml/20230824162505.173399-1-andrealm...@igalia.com/
André Almeida (2):
drm/amdgpu: Merge debug module parameters
drm/amdgpu: Create an option to disable soft recovery
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 +++
drivers/gpu/drm/amd/amdgpu/amd
Em 25/08/2023 09:29, Christian König escreveu:
Am 25.08.23 um 14:24 schrieb André Almeida:
Em 25/08/2023 03:56, Christian König escreveu:
> Am 24.08.23 um 18:25 schrieb André Almeida:
>> Merge all developer debug options available as separated module
>> parameters in one, ma
Em 25/08/2023 03:56, Christian König escreveu:
> Am 24.08.23 um 18:25 schrieb André Almeida:
>> Merge all developer debug options available as separated module
>> parameters in one, making it obvious that are for developers.
>>
>> Signed-off-by: André Almeida
>
Merge all developer debug options available as separated module
parameters in one, making it obvious that are for developers.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24
drivers/gpu/drm/amd/include/amd_shared.h | 9 +
2 files
Create a module option to disable soft recoveries on amdgpu, making
every recovery go through the device reset path. This option makes
easier to force device resets for testing and debugging purposes.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu
ug option. This way it should be pretty obvious that this
> isn't meant to be used by someone who doesn't know how to use it.
[0]
https://lore.kernel.org/dri-devel/55f69184-1aa2-55d6-4a10-1560d75c7...@amd.com/
André Almeida (2):
drm/amdgpu: Merge debug module parameters
drm/amdgpu: Crea
Hi Rodrigo,
Em 23/08/2023 14:31, Rodrigo Vivi escreveu:
On Fri, Aug 18, 2023 at 05:06:42PM -0300, André Almeida wrote:
Create a section that specifies how to deal with DRM device resets for
kernel and userspace drivers.
Signed-off-by: André Almeida
---
v7 changes:
- s/application
Hi Michel,
Em 17/08/2023 07:37, Michel Dänzer escreveu:
On 8/15/23 20:57, André Almeida wrote:
From: Pekka Paalanen
Specify how the atomic state is maintained between userspace and
kernel, plus the special case for async flips.
Signed-off-by: Pekka Paalanen
Signed-off-by: André Almeida
Create a section that specifies how to deal with DRM device resets for
kernel and userspace drivers.
Signed-off-by: André Almeida
---
v7 changes:
- s/application/graphical API contex/ in the robustness part (Michel)
- Grammar fixes (Randy)
v6: https://lore.kernel.org/lkml
.
Signed-off-by: André Almeida
---
v5: new patch
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
index
Giving that we use codedump just for device resets, move it's functions
and structs to a more semantic file, the amdgpu_reset.{c, h}.
Signed-off-by: André Almeida
---
v5: no change
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 9 ---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 78
To better organize struct amdgpu_device, keep all reset information
related fields together in a separated struct.
Signed-off-by: André Almeida
---
v5: new patch, as requested by Shashank Sharma
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 34 +
drivers/gpu/drm/amd
Instead of storing coredump information inside amdgpu_device struct,
move if to a proper separated struct and allocate it dynamically. This
will make it easier to further expand the logged information.
Signed-off-by: André Almeida
---
v5: no change
v4: change kmalloc to kzalloc
---
drivers/gpu
evcoredump allocatio
André Almeida (5):
drm/amdgpu: Allocate coredump memory in a nonblocking way
drm/amdgpu: Rework coredump to use memory dynamically
drm/amdgpu: Encapsulate all device reset info
drm/amdgpu: Move coredump code to amdgpu_reset file
drm/amdgpu: Create version number for
During a GPU reset, a normal memory reclaim could block to reclaim
memory. Giving that coredump is a best effort mechanism, it shouldn't
disturb the reset path. Change its memory allocation flag to a
nonblocking one.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
v5: no change
Em 17/08/2023 12:26, Shashank Sharma escreveu:
On 17/08/2023 17:17, André Almeida wrote:
Em 17/08/2023 12:04, Shashank Sharma escreveu:
On 17/08/2023 15:45, André Almeida wrote:
Hi Shashank,
Em 17/08/2023 03:41, Shashank Sharma escreveu:
Hello Andre,
On 15/08/2023 21:50, André
Em 17/08/2023 12:04, Shashank Sharma escreveu:
On 17/08/2023 15:45, André Almeida wrote:
Hi Shashank,
Em 17/08/2023 03:41, Shashank Sharma escreveu:
Hello Andre,
On 15/08/2023 21:50, André Almeida wrote:
Instead of storing coredump information inside amdgpu_device struct,
move
Hi Shashank,
Em 17/08/2023 03:41, Shashank Sharma escreveu:
Hello Andre,
On 15/08/2023 21:50, André Almeida wrote:
Instead of storing coredump information inside amdgpu_device struct,
move if to a proper separated struct and allocate it dynamically. This
will make it easier to further expand
.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 3 +++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
index 46c8d6ce349c
Giving that we use codedump just for device resets, move it's functions
and structs to a more semantic file, the amdgpu_reset.{c, h}.
Signed-off-by: André Almeida
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 9 ---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 78
Instead of storing coredump information inside amdgpu_device struct,
move if to a proper separated struct and allocate it dynamically. This
will make it easier to further expand the logged information.
Signed-off-by: André Almeida
---
v4: change kmalloc to kzalloc
---
drivers/gpu/drm/amd/amdgpu
During a GPU reset, a normal memory reclaim could block to reclaim
memory. Giving that coredump is a best effort mechanism, it shouldn't
disturb the reset path. Change its memory allocation flag to a
nonblocking one.
Signed-off-by: André Almeida
Reviewed-by: Christian König
---
drivers/gpu/drm
/dri-devel/20230711213501.526237-1-andrealm...@igalia.com/
- Drop "Mark contexts guilty for causing soft recoveries" patch
- Use GFP_NOWAIT for devcoredump allocation
André Almeida (4):
drm/amdgpu: Allocate coredump memory in a nonblocking way
drm/amdgpu: Rework coredump to use memo
From: Pekka Paalanen
Specify how the atomic state is maintained between userspace and
kernel, plus the special case for async flips.
Signed-off-by: Pekka Paalanen
Signed-off-by: André Almeida
---
v5: Add note that not every redundant attribute will result in no-op
v4: total rework by Pekka
-by: André Almeida
---
v5: no changes
v4: new patch
---
drivers/gpu/drm/drm_atomic_helper.c | 5 +++
drivers/gpu/drm/drm_atomic_uapi.c | 52 +++--
drivers/gpu/drm/drm_crtc_internal.h | 2 +-
drivers/gpu/drm/drm_mode_object.c | 2 +-
4 files changed, 56 insertions(+), 5
1 - 100 of 250 matches
Mail list logo
