Re: [PATCH RFC v2 04/11] ARM: dts: omap4: Add device tree entry for SGX GPU

2024-01-15 Thread Andreas Kemnade
Hi, On Mon, 15 Jan 2024 09:55:00 +0100 "H. Nikolaus Schaller" wrote: > > There's no reason to disable it in the DT: the hardware block would > > still be there and it's rendering to memory so it still could be useful. > > Well, if you know that the board does not have a dm3730 but a dm3725 w

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Andreas Kemnade
On Tue, 5 Dec 2023 09:45:44 +0100 Krzysztof Kozlowski wrote: > > Sure the clock nodes can be there for the child IP, but they won't do > > anything. And still need to be managed separately by the device driver if > > added. > > So if OS does not have runtime PM, the bindings are wrong? Binding

Re: [PATCH RFC 01/10] dt-bindings: gpu: Add PowerVR Series5 SGX GPUs

2023-12-05 Thread Andreas Kemnade
On Tue, 5 Dec 2023 10:27:56 +0100 Krzysztof Kozlowski wrote: > On 05/12/2023 10:02, Andreas Kemnade wrote: > > On Tue, 5 Dec 2023 09:45:44 +0100 > > Krzysztof Kozlowski wrote: > > > >>> Sure the clock nodes can be there for the child IP, but they won't d

Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4

2023-09-17 Thread Andreas Kemnade
Am Wed, 13 Sep 2023 15:58:11 +0300 schrieb Tomi Valkeinen : > On 13/09/2023 15:48, Tony Lindgren wrote: > > * Tomi Valkeinen [230913 12:11]: > >> I'm somewhat sure that the upstream driver used to work on omap4 > >> sdp, which has two DSI panels. But I can't even remember what > >> omap4 versio

Re: [RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4

2023-09-13 Thread Andreas Kemnade
On Wed, 13 Sep 2023 15:11:08 +0300 Tomi Valkeinen wrote: > On 13/09/2023 09:59, Andreas Kemnade wrote: > > Some 3.0 source has it set behind a if (omap4). > > Maybe it is helpful maybe not, at least in the omap4460 > > trm these bits are marked as reserved. > > Bu

[RFC PATCH] drm: omapdrm: dsi: add refsel also for omap4

2023-09-13 Thread Andreas Kemnade
Some 3.0 source has it set behind a if (omap4). Maybe it is helpful maybe not, at least in the omap4460 trm these bits are marked as reserved. But maybe some dsi video mode panel starts magically working. Signed-off-by: Andreas Kemnade --- drivers/gpu/drm/omapdrm/dss/dsi.c | 2 +- 1 file

Re: [RFC PATCH 00/16] drm/rockchip: Rockchip EBC ("E-Book Controller") display driver

2022-04-20 Thread Andreas Kemnade
On Wed, 13 Apr 2022 17:19:00 -0500 Samuel Holland wrote: [...] > Waveform Selection From Userspace > = > EPDs use different waveforms for different purposes: high-quality > grayscale vs. monochrome text vs. dithered monochrome video. How can > userspace select whic

Re: [RFC PATCH 02/16] dt-bindings: display: rockchip: Add EBC binding

2022-04-15 Thread Andreas Kemnade
On Thu, 14 Apr 2022 22:00:09 -0500 Samuel Holland wrote: > Hi Andreas, > > Thanks for the comments. > > On 4/14/22 3:15 AM, Andreas Kemnade wrote: > > Hi Samuel, > > > > for comparison, here is my submission for the IMX EPDC bindings: > > >

Re: [RFC PATCH 02/16] dt-bindings: display: rockchip: Add EBC binding

2022-04-14 Thread Andreas Kemnade
Hi Samuel, for comparison, here is my submission for the IMX EPDC bindings: https://lore.kernel.org/linux-devicetree/20220206080016.796556-2-andr...@kemnade.info/ On Wed, 13 Apr 2022 17:19:02 -0500 Samuel Holland wrote: [...] we have sy7636a driver in kernel which should be suitable for poweri

Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC

2022-03-14 Thread Andreas Kemnade
; well-defined timing. VCOM can be handled separately, but can also be > > incorporated into that single bit. > > > > Signed-off-by: Andreas Kemnade > > --- > > .../bindings/display/imx/fsl,mxc-epdc.yaml| 159 ++ > > 1 file changed, 159 ins

Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC

2022-02-17 Thread Andreas Kemnade
On Thu, 17 Feb 2022 10:21:15 +0100 Krzysztof Kozlowski wrote: > On 06/02/2022 09:00, Andreas Kemnade wrote: > > Add a binding for the Electrophoretic Display Controller found at least > > in the i.MX6. > > The timing subnode is directly here to avoid having display parameter

Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC

2022-02-14 Thread Andreas Kemnade
Hi Rob, On Fri, 11 Feb 2022 09:46:27 -0600 Rob Herring wrote: > On Sun, Feb 06, 2022 at 09:00:11AM +0100, Andreas Kemnade wrote: > > Add a binding for the Electrophoretic Display Controller found at least > > in the i.MX6. > > The first version was in i.MX50 (I helpe

[RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC

2022-02-07 Thread Andreas Kemnade
for that purpose, like the TPS65185, the SY7636A and MAX17135 have typically a single bit to start a bunch of regulators of higher or negative voltage with a well-defined timing. VCOM can be handled separately, but can also be incorporated into that single bit. Signed-off-by: Andreas Kemnade

[RFC PATCH 6/6] arm: dts: imx6sl: Add EPDC

2022-02-07 Thread Andreas Kemnade
Extend definition of EPDC. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sl.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi index c7d907c5c352..919e86e4fc74 100644 --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch

[RFC PATCH 3/6] drm: mxc-epdc: Add display and waveform initialisation

2022-02-07 Thread Andreas Kemnade
Adds display parameter initialisation, display power up/down and waveform loading Signed-off-by: Andreas Kemnade --- drivers/gpu/drm/mxc-epdc/Makefile| 2 +- drivers/gpu/drm/mxc-epdc/epdc_hw.c | 495 +++ drivers/gpu/drm/mxc-epdc/epdc_hw.h | 8

[RFC PATCH 2/6] drm: Add skeleton for EPDC driver

2022-02-07 Thread Andreas Kemnade
This driver is for the EPD controller in the i.MX SoCs. Add a skeleton and basic things for the driver Signed-off-by: Andreas Kemnade --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/mxc-epdc/Kconfig| 15 + drivers

[RFC PATCH 0/6] drm: EPDC driver for i.MX6

2022-02-07 Thread Andreas Kemnade
kernel fork uses that for rotation and mysterious waveform handling. That is not planed to be upstreamed in the first step. Also it does not provide any special userspace API to fine-tune updates. That is also IMHO something for a second step. Andreas Kemnade (6): dt-bindings: display: imx: Add

[RFC PATCH 4/6] drm: mxc-epdc: Add update management

2022-02-07 Thread Andreas Kemnade
Clara HD, Tolino Shine 3, and Tolino Shine 2HD. Also the waveform called epdc_E060SCM.fw from NXP BSP works with the i.MX6SL devices. Signed-off-by: Andreas Kemnade --- drivers/gpu/drm/mxc-epdc/Makefile |2 +- drivers/gpu/drm/mxc-epdc/epdc_hw.c |2 + drivers/gpu/drm/mxc-epdc

[RFC PATCH 5/6] ARM: dts: imx6sll: add EPDC

2022-02-07 Thread Andreas Kemnade
The commercial variant has a controller for e-Paper displays. Signed-off-by: Andreas Kemnade --- arch/arm/boot/dts/imx6sll.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi index d4a000c3dde7..042e8a391b2f 100644

Re: [Letux-kernel] [PATCH 07/14] MIPS: DTS: CI20: fix PMU definitions for ACT8600

2020-02-12 Thread Andreas Kemnade
On Tue, 11 Feb 2020 22:41:24 +0100 "H. Nikolaus Schaller" wrote: > There is a ACT8600 on the CI20 board and the bindings of the > ACT8865 driver have changed without updating the CI20 device > tree. Therefore the PMU can not be probed successfully and > is running in power-on reset state. > > Fi

Re: [RFCv1 33/42] drm/omap: dsi: use atomic helper for dirtyfb

2019-11-19 Thread Andreas Kemnade
On Tue, 19 Nov 2019 17:55:57 +0200 Tomi Valkeinen wrote: > On 19/11/2019 17:06, Tony Lindgren wrote: > > >> The userspace apps need to do this. If they're using single-buffering, then > >> using the dirtyfb ioctl should do the trick, after the SGX has finished > >> drawing. > > > > Sounds lik

Re: [PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-10-30 Thread Andreas Kemnade
Hi, On Mon, 28 Oct 2019 18:25:56 -0500 Rob Herring wrote: > On Thu, Sep 12, 2019 at 4:33 PM Andreas Kemnade wrote: > > > > add enable-gpios to describe HWEN pin > > > > Signed-off-by: Andreas Kemnade > > Acked-by: Daniel Thompson > > This br

[PATCH next] dt-bindings: backlight: lm3630a: fix missing include

2019-10-30 Thread Andreas Kemnade
example failed to compile due to undefined GPIO_ACTIVE_HIGH fix that by adding the needed #include to the exammple Fixes: ae92365cdd75 ("dt-bindings: backlight: lm3630a: Add enable-gpios to describe HWEN pin") Signed-off-by: Andreas Kemnade --- .../devicetree/bindings/leds/backlig

Re: [Letux-kernel] [PATCH 4/5] drm/panel: tpo-td028ttec1: Fix SPI alias

2019-10-08 Thread Andreas Kemnade
us Schaller > Signed-off-by: Laurent Pinchart Tested-by: Andreas Kemnade > --- > drivers/gpu/drm/panel/panel-tpo-td028ttec1.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-tpo-td028ttec1.c > b/drivers/gpu/drm/pan

Re: [PATCH] drm: panels: fix spi aliases of former omap panels

2019-10-08 Thread Andreas Kemnade
On Mon, 7 Oct 2019 19:04:46 +0200 Sebastian Reichel wrote: > Hi, > > On Mon, Oct 07, 2019 at 06:41:30PM +0200, Andreas Kemnade wrote: > > When the panels were moved from omap/displays/ to panel/ > > omapdss prefix was stripped, which cause spi modalias > > to no

[PATCH] drm: panels: fix spi aliases of former omap panels

2019-10-07 Thread Andreas Kemnade
dalias=spi:td028ttec1 This is consistent with other drivers. Tested the td028ttec.c only, but the pattern looks the same for the other ones. Fixes: 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers") Signed-off-by: Andreas Kemnade --- drivers/gpu/drm/panel/panel-lg-lb03

Re: [PATCH] backlight: lm3630a: fix module aliases

2019-10-05 Thread Andreas Kemnade
Hi, hmm, this bugfix has not arrived in -next or any -fixes branch I am aware of yet. I hope it is not forgotten... so a friendly ping. Regards, Andreas On Wed, 11 Sep 2019 11:51:48 +0100 Daniel Thompson wrote: > On Tue, Sep 10, 2019 at 05:23:59PM +0200, Andreas Kemnade wrote: > > D

Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-15 Thread Andreas Kemnade
Hi, On Sun, 15 Sep 2019 18:52:04 +0200 Pavel Machek wrote: > Hi! > > > > > > Is this needed? > > > > > > > > > > This is a remove path, not a power management path, and we have no > > > > > idea > > > > > what the original status of the pin was anyway? > > > > > > > > > > > > > Looking

[PATCH v4 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-12 Thread Andreas Kemnade
For now just enable it in the probe function to allow i2c access. Disabling also means resetting the register values to default and according to the datasheet does not give power savings. Tested on Kobo Clara HD. Signed-off-by: Andreas Kemnade Reviewed-by: Dan Murphy Reviewed-by: Daniel

[PATCH v4 0/2] backlight_lm3630a: add enable_gpios property

2019-09-12 Thread Andreas Kemnade
bindings example Andreas Kemnade (2): dt-bindings: backlight: lm3630a: add enable_gpios backlight: lm3630a: add an enable gpio for the HWEN pin .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 + drivers/video/backlight/lm3630a_bl.c | 9 + 2 files

[PATCH v4 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-12 Thread Andreas Kemnade
add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade Acked-by: Daniel Thompson --- changes in v2: added example changes in v3: added Acked-by changes in v4: moved enable-gpios to the right position in the example .../bindings/leds/backlight/lm3630a-backlight.yaml

Re: [PATCH v3 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-12 Thread Andreas Kemnade
On Thu, 12 Sep 2019 06:39:50 -0500 Dan Murphy wrote: > Andreas > > On 9/11/19 12:21 PM, Andreas Kemnade wrote: > > add enable-gpios to describe HWEN pin > > > > Signed-off-by: Andreas Kemnade > > Acked-by: Daniel Thompson > > --- > > changes in v2:

Re: [PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-11 Thread Andreas Kemnade
On Wed, 11 Sep 2019 13:48:36 -0500 Dan Murphy wrote: > >> @@ -535,6 +538,13 @@ static int lm3630a_probe(struct i2c_client *client, > >>} > >>pchip->pdata = pdata; > >> > >> + pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable", > >> +

[PATCH v3 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-11 Thread Andreas Kemnade
For now just enable it in the probe function to allow i2c access. Disabling also means resetting the register values to default and according to the datasheet does not give power savings. Tested on Kobo Clara HD. Signed-off-by: Andreas Kemnade --- changes in v2: - simplification - correct gpio

[PATCH v3 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-11 Thread Andreas Kemnade
add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade Acked-by: Daniel Thompson --- changes in v2: added example changes in v3: added Acked-by .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation

[PATCH v3 0/2] backlight_lm3630a: add enable_gpios property

2019-09-11 Thread Andreas Kemnade
To be able to handle the HWEN pin of the lm3630a, add an enable gpio to the driver and a property. Tested on Kobo Clara HD. Changes in v2: simplification and reordering Changes in v3: added acked-by removed legacy include Andreas Kemnade (2): dt-bindings: backlight: lm3630a: add enable_gpios

[PATCH v2 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-10 Thread Andreas Kemnade
For now just enable it in the probe function to allow i2c access. Disabling also means resetting the register values to default and according to the datasheet does not give power savings Tested on Kobo Clara HD. Signed-off-by: Andreas Kemnade --- changes in v2: - simplification - correct gpio

[PATCH v2 0/2] backlight_lm3630a: add enable_gpios property

2019-09-10 Thread Andreas Kemnade
To be able to handle the HWEN pin of the lm3630a, add an enable gpio to the driver and a property. Tested on Kobo Clara HD. Changes in v2: simplification and reordering Andreas Kemnade (2): dt-bindings: backlight: lm3630a: add enable_gpios backlight: lm3630a: add an enable gpio for the HWEN

[PATCH v2 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-10 Thread Andreas Kemnade
add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade --- changes in v2: add example .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b

Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-10 Thread Andreas Kemnade
On Tue, 10 Sep 2019 11:21:56 +0100 Daniel Thompson wrote: [...] > > > Is this needed? > > > > > > This is a remove path, not a power management path, and we have no idea > > > what the original status of the pin was anyway? > > > > > > > Looking at Ishdn on page 5 of the datasheet, switching

[PATCH] backlight: lm3630a: fix module aliases

2019-09-10 Thread Andreas Kemnade
Devicetree aliases are missing, so that module autoloading does not work properly. Signed-off-by: Andreas Kemnade --- drivers/video/backlight/lm3630a_bl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight

Re: [PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-09 Thread Andreas Kemnade
On Mon, 9 Sep 2019 11:57:29 +0100 Daniel Thompson wrote: > On Sun, Sep 08, 2019 at 10:37:03PM +0200, Andreas Kemnade wrote: > > For now just enable it in the probe function to allow i2c > > access and disable it on remove. Disabling also means resetting > > the regis

[PATCH 0/2] backlight_lm3630a: add enable_gpios property

2019-09-09 Thread Andreas Kemnade
To be able to handle the HWEN pin of the lm3630a, add an enable gpio to the driver and a property. Tested on Kobo Clara HD Andreas Kemnade (2): backlight: lm3630a: add an enable gpio for the HWEN pin dt-bindings: backlight: lm3630a: add enable_gpios .../leds/backlight/lm3630a

[PATCH 2/2] dt-bindings: backlight: lm3630a: add enable_gpios

2019-09-09 Thread Andreas Kemnade
add enable-gpios to describe HWEN pin Signed-off-by: Andreas Kemnade --- .../devicetree/bindings/leds/backlight/lm3630a-backlight.yaml | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree

[PATCH 1/2] backlight: lm3630a: add an enable gpio for the HWEN pin

2019-09-09 Thread Andreas Kemnade
For now just enable it in the probe function to allow i2c access and disable it on remove. Disabling also means resetting the register values to default. Tested on Kobo Clara HD. Signed-off-by: Andreas Kemnade --- drivers/video/backlight/lm3630a_bl.c | 18 ++ 1 file changed, 18

Re: [PATCH v2 0/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-02-18 Thread Andreas Kemnade
Hi, On Fri, 8 Feb 2019 11:13:33 +0200 Tomi Valkeinen wrote: > On 05/02/2019 08:38, Andreas Kemnade wrote: > > This panel has a backlight, so add a property describing that and > > add the code to use that. > > This makes things like xset dpms force off > > also turn

[PATCH v2 2/2] dt-bindings: panel: td028ttec1: add backlight property

2019-02-05 Thread Andreas Kemnade
This adds an additional backlight property as described in panel-common.txt Signed-off-by: Andreas Kemnade --- Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1

[PATCH v2 1/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-02-05 Thread Andreas Kemnade
-by: Andreas Kemnade --- Changes in v2: - do not reorder initialisation - fix commit message drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c b/drivers/gpu/drm/omapdrm

[PATCH v2 0/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-02-05 Thread Andreas Kemnade
This panel has a backlight, so add a property describing that and add the code to use that. This makes things like xset dpms force off also turn off the backlight, so we do not need to rely on additional userspace programs to do that. Andreas Kemnade (2): drm/omap: panel-tpo-td028ttec1: add

Re: [PATCH 1/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-02-05 Thread Andreas Kemnade
Hi, On Mon, 4 Feb 2019 10:13:46 +0200 Tomi Valkeinen wrote: > Hi, > > On 19/01/2019 20:21, Andreas Kemnade wrote: > > This panel has a backlight, so fetch it from devicetree using the > > as documented in panel-common.txt. It is implemented the same way as in > >

Re: [PATCH 0/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-02-01 Thread Andreas Kemnade
ping On Sat, 19 Jan 2019 19:21:29 +0100 Andreas Kemnade wrote: > This panel has a backlight, so add a property describing that and > add the code to use that. > This makes things like xset dpms force off > also turn off the backlight, so we do not need to rely on additional > use

[PATCH 1/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-01-20 Thread Andreas Kemnade
This panel has a backlight, so fetch it from devicetree using the as documented in panel-common.txt. It is implemented the same way as in panel-dpi.c This ensures the backlight is also disabled when the display is turned off like when doing xset dpms force off. Signed-off-by: Andreas Kemnade

[PATCH 0/2] drm/omap: panel-tpo-td028ttec1: add backlight support

2019-01-20 Thread Andreas Kemnade
This panel has a backlight, so add a property describing that and add the code to use that. This makes things like xset dpms force off also turn off the backlight, so we do not need to rely on additional userspace programs to do that. Andreas Kemnade (2): drm/omap: panel-tpo-td028ttec1: add

[PATCH 2/2] dt-bindings: panel: td028ttec1: add backlight property

2019-01-20 Thread Andreas Kemnade
This add an additional backlight property as described in panel-common.txt Signed-off-by: Andreas Kemnade --- Documentation/devicetree/bindings/display/panel/tpo,td028ttec1.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/tpo,td028ttec1