Re: [PATCH 01/12] kbuild: make -Woverride-init warnings more consistent

2024-03-26 Thread Andrew Jeffery
ivers/gpu/drm/xe/Makefile| 4 ++-- > drivers/net/ethernet/renesas/sh_eth.c | 2 +- > drivers/pinctrl/aspeed/Makefile| 2 +- For the Aspeed change: Acked-by: Andrew Jeffery Thanks!

Re: [PATCH] drm: Use device_get_match_data()

2023-10-24 Thread Andrew Jeffery
on to remove implicit includes within the DT headers > (of_device.h in particular). > > Signed-off-by: Rob Herring > --- > drivers/gpu/drm/armada/armada_crtc.c| 24 +++- > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 10 -- For Aspeed: Reviewed-by: Andrew Jeffery Thanks!

Re: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses

2023-10-10 Thread Andrew Jeffery
On Wed, 11 Oct 2023, at 09:29, Guenter Roeck wrote: > On Tue, Oct 10, 2023 at 08:58:06PM +0200, Wolfram Sang wrote: >> Hi Guenter, >> >> > > > Reference to Andrew's previous proposal: >> > > > https://lore.kernel.org/all/20200914122811.3295678-1-and...@aj.id.au/ >> > > >> > > I do totally agree

Re: [PATCH] dt-bindings: gpu: Convert aspeed-gfx bindings to yaml

2022-03-03 Thread Andrew Jeffery
On Fri, 4 Mar 2022, at 08:05, Joel Stanley wrote: > On Thu, 3 Mar 2022 at 19:34, Rob Herring wrote: >> >> On Wed, Mar 2, 2022 at 12:01 PM Rob Herring wrote: >> > >> > On Wed, Mar 02, 2022 at 03:40:56PM +1030, Joel Stanley wrote: >> > > Convert the bindings to yaml and add the ast2600

Re: [PATCH v3 1/2] drm/aspeed: Look up syscon by phandle

2021-02-09 Thread Andrew Jeffery
they won't need fallback paths. > > Signed-off-by: Joel Stanley Reviewed-by: Andrew Jeffery ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/aspeed: Add sysfs for output settings

2020-09-17 Thread Andrew Jeffery
struct aspeed_gfx *priv = dev_get_drvdata(dev); > + u32 val; > + int rc; > + > + rc = kstrtou32(buf, 0, ); > + if (rc) > + return rc; > + > + if (val < 0 || val > 3) val is unsigned so can't be less than zero. Otherwise, Reviewed-by: Andrew Jeffer

Re: [PATCH] drm: aspeed: Fix GENMASK misuse

2020-02-24 Thread Andrew Jeffery
ng was done. I think someone's sent a patch previously, and last time it turned into a discussion about how the macros aren't actually used and could be removed. Regardless: Reviewed-by: Andrew Jeffery ___ dri-devel mailing list dri-devel@lists.

Re: [PATCH 2/7] docs: dt: fix several broken references due to renames

2020-02-24 Thread Andrew Jeffery
... > .../bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +- > .../bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +- > .../bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +- Acked-by: Andrew Jeffery

Re: [PATCH 03/12] drm: aspeed_gfx: Fix misuse of GENMASK macro

2019-07-24 Thread Andrew Jeffery
NE_MASK) > > -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) > > +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) Reviewed-by: Andrew Jeffery > > ping? > > >

Re: [PATCH v3 3/3] MAINTAINERS: Add ASPEED BMC GFX DRM driver entry

2019-04-04 Thread Andrew Jeffery
On Wed, 3 Apr 2019, at 10:49, Joel Stanley wrote: > This hardware is found inside ASPEED Baseboard Management Controller > (BMC) system on chips. It is called the 'SOC Display Controller' or 'GFX'. > > Signed-off-by: Joel Stanley Acked-by: Andrew Jeffery > --- > MAINTAINERS

Re: [PATCH v2 1/3] dt-bindings: gpu: Add ASPEED GFX bindings document

2019-04-02 Thread Andrew Jeffery
aspeed,ast2400-gfx > +* In addition, the ASPEED pinctrl bindings require the 'syscon' > property to > + be present Lets remove [1] now that we have this document as what you've described here is a super-set. Happy for that to be a follow-up patch, so: Reviewed-by: Andrew Jeff