-initting alloc
functions if you really need to.
Let's switch the function to use an allocation function that zeros the
memory. For me, this avoids the crash.
Fixes: 01389b324c97 ("drm/mediatek: Add connector dynamic selection capability")
Signed-off-by: Douglas Anderson
Reviewed-
Il 30/03/24 21:43, Krzysztof Kozlowski ha scritto:
Simplify the code by dropping unnecessary .owner initialization in the
driver.
For the entire series:
Reviewed-by: AngeloGioacchino Del Regno
Best regards,
Krzysztof
---
Krzysztof Kozlowski (11):
drm/mediatek: aal: drop driver
d it, but not since
the values were increased. As long as it’s acceptable I won’t over-think
it but if more testing is needed I can look at it more.
Thanks for clarifying.
Reviewed-by: AngeloGioacchino Del Regno
Il 22/03/24 17:45, Christian Hewitt ha scritto:
Increase the timeout value to prevent system logs on Amlogic boards flooding
with power transition warnings:
[ 13.047638] panfrost ffe4.gpu: shader power transition timeout
[ 13.048674] panfrost ffe4.gpu: l2 power transition timeout
[
Il 22/03/24 02:27, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename all "mtk_drm_plane" to "mtk_plane":
- To align the naming rule
- To reduce the code size
Reviewed-by: AngeloGiaocchino Del Regno
Shawn - please - can you fix my typo'ed name also here and on all of the
patches of this
Il 01/02/24 13:53, AngeloGioacchino Del Regno ha scritto:
This series performs some cleanups for DDP component CRTC search and
correctly iounmaps the previously of_iomap() calls from drm_ddp_comp.
Tested on MT8195 Cherry Tomato
Hello CK,
gentle ping for this series.
Cheers,
Angelo
Il 20/03/24 03:42, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename files mtk_drm_ddp_comp.c to mtk_ddp_comp.c and
modify the Makefile accordingly.
Reviewed-by: CK Hu
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGioacchino Del Regno
Il 20/03/24 03:42, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename files mtk_drm_crtc.c to mtk_crtc.c and
modify the Makefile accordingly.
Reviewed-by: CK Hu
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGioacchino Del Regno
ctually possible, since
I write the tags by hand), or what actually happened to my Reviewed-by tags on
the entire series.
Can you please fix the typo in the tag?
Reviewed-by: AngeloGioacchino Del Regno
Use this one, please.
Thanks,
Angelo
Reviewed-by: CK Hu
Signed-off-by: Hsiao Chien Sung
Il 19/03/24 08:02, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename files mtk_drm_plane.c to mtk_plane.c and
modify the Makefile accordingly.
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGioacchino Del Regno
p the #ifdef CONFIG_PM section around panthor_pm_ops's definition
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202403031944.eoimq8wk-...@intel.com/
Signed-off-by: Boris Brezillon
Reviewed-by: AngeloGioacchino Del Regno
---
Tested by faking CONFIG_PM=n in
Il 15/03/24 02:52, Liankun Yang ha scritto:
By adjusting the order of link training and relocating it to HPD,
link training can identify the usability of each lane in the current link.
It also supports handling signal instability and weakness due to
environmental issues, enabling the acquisition
Il 15/03/24 08:29, Shuijing Li ha scritto:
This patch correct calculation formula of PHY timing.
Make actual phy timing more accurate.
More accurate in which cases? By how much? On which SoC(s)?
I agree about those changes if those are improving the PHY timing, but
can you please document wha
Il 14/03/24 10:41, Shuijing Li ha scritto:
Adding the per-frame lp function of mt8188, which can keep HFP in HS and
reduce the time required for each line to enter and exit low power.
Per Frame LP:
|<--One Active Frame>|
--___
Il 12/03/24 15:50, Alexandre Mergnat ha scritto:
On 26/02/2024 16:25, AngeloGioacchino Del Regno wrote:
+ if (enable) {
+ /* set gpio mosi mode */
+ regmap_write(priv->regmap, MT6357_GPIO_MODE2_CLR,
GPIO_MODE2_CLEAR_ALL);
+ regmap_write(priv->
buffer on an MT8188 and
verifying that we now return EINVAL.
Signed-off-by: Justin green
You need a Fixes tag for this one. Please add the right one and resend.
After adding the correct Fixes tag,
Reviewed-by: AngeloGioacchino Del Regno
Cheers,
Angelo
---
drivers/gpu/drm/mediatek
Il 01/03/24 09:56, Laurent Pinchart ha scritto:
On Fri, Mar 01, 2024 at 09:44:36AM +0100, AngeloGioacchino Del Regno wrote:
Il 01/03/24 07:30, Laurent Pinchart ha scritto:
On Thu, Feb 29, 2024 at 07:12:15PM -0500, Nícolas F. R. A. Prado wrote:
Given that failing to find a DSI host causes the
Apart from patch [8/9], where you're going over 100 cols, this series looks
good.
After fixing that, on v3, please feel free to add my
Reviewed-by: AngeloGioacchino Del Regno
...to all of the patches in this series (and the one that you'll fix as well).
Cheers!
Angelo
.
Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC
panels")
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/panel/panel-novatek-nt35950.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
di
defer
probe reason available and avoids alerting userspace about something
that is not necessarily an error.
Suggested-by: AngeloGioacchino Del Regno
Signed-off-by: Nícolas F. R. A. Prado
---
drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions
Acked-by: Krzysztof Kozlowski
Reviewed-by: AngeloGioacchino Del Regno
Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
Since MT8195 compatible is in the single enum group, we have to add its
compatible into mediatek-drm component binding table to ensure that
it can be bound as a ddp_comp.
Reviewed-by: AngeloGioacchino Del Regno
Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
The gamma LUT setting of MT8188 and MT8195 are the same, so we create
a one of items for MT8188 to reuse the driver data settings of MT8195.
Signed-off-by: Jason-JH.Lin
Reviewed-by: AngeloGioacchino Del Regno
Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
Since MT8195 gamma has multiple bank for 12 bits LUT and it is
different from any other SoC LUT setting.
So we move MT8195 compatible from the one of items to the
single enum group.
Signed-off-by: Jason-JH.Lin
---
.../devicetree/bindings/display/me
Il 28/02/24 10:57, Alexandre Mergnat ha scritto:
I think I got it.
- mediatek,i2s-shared-clock: will be remove from DT
- mediatek,dmic-iir-on: will be remove from DT
- mediatek,dmic-irr-mode: will be remove from DT
- mediatek,dmic-two-wire-mode: rephrase description needed
I've did abstraction
t noticed that, in this driver, of_node_put() is never called for
the
`mipi_host_node`, so the reference is never dropped... but that can come
later
and not necessarily in the eventual series that fixes the err message
strategy.
In the meanwhile, for this commit
Reviewed-
Il 27/02/24 11:23, Alexandre Mergnat ha scritto:
On 26/02/2024 16:30, AngeloGioacchino Del Regno wrote:
Il 26/02/24 15:01, Alexandre Mergnat ha scritto:
Add soundcard bindings for the MT8365 SoC with the MT6357 audio codec.
Signed-off-by: Alexandre Mergnat
---
.../bindings/sound/mediatek
Il 26/02/24 15:01, Alexandre Mergnat ha scritto:
Add soundcard bindings for the MT8365 SoC with the MT6357 audio codec.
Signed-off-by: Alexandre Mergnat
---
.../bindings/sound/mediatek,mt8365-mt6357.yaml | 127 +
1 file changed, 127 insertions(+)
diff --git
a/Docume
Il 26/02/24 15:01, amerg...@baylibre.com ha scritto:
From: Fabien Parent
Add MT6357 codec entry in the MFD driver.
Signed-off-by: Fabien Parent
Signed-off-by: Alexandre Mergnat
Reviewed-by: AngeloGioacchino Del Regno
---
drivers/mfd/mt6397-core.c | 3 +++
1 file changed, 3
Il 26/02/24 15:01, amerg...@baylibre.com ha scritto:
From: Nicolas Belin
Add the support of MT6357 PMIC audio codec.
Signed-off-by: Nicolas Belin
Signed-off-by: Alexandre Mergnat
---
sound/soc/codecs/Kconfig |7 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/mt6357.c | 1805
Il 26/02/24 15:01, amerg...@baylibre.com ha scritto:
From: Nicolas Belin
Add a specific soundcard for mt8365-evk. It supports audio jack
in/out, dmics, the amic and lineout.
Signed-off-by: Nicolas Belin
Signed-off-by: Alexandre Mergnat
---
sound/soc/mediatek/mt8365/mt8365-mt6357.c | 379 ++
Il 26/02/24 15:01, Alexandre Mergnat ha scritto:
This serie aim to add the following audio support for the Genio 350-evk:
- Playback
- 2ch Headset Jack (Earphone)
- 1ch Line-out Jack (Speaker)
- 8ch HDMI Tx
- Capture
- 1ch DMIC (On-board Digital Microphone)
- 1ch AMIC (On-board Ana
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename all "mtk_drm_crtc" to "mtk_crtc" due to the following benefits:
- Lower the matches when searching the native drm_crtc* codes
- Reduce the code size
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regn
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename all "mtk_drm_hdmi" to "mtk_hdmi":
- To align the naming rule
- To reduce the code size
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regno
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename "pending_needs_vblank" to "needs_vblank" to reduce the code size.
This decreases human readability though, so I would prefer that we omit this
one.
Regards,
Angelo
Signed-off-by: Hsiao Chien Sung
---
drivers/gpu/d
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename all "mtk_drm_gem" to "mtk_gem":
- To align the naming rule
- To reduce the code size
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regno
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename all "mtk_drm_ddp_comp" to "mtk_ddp_comp":
- To align the naming rule
- To reduce the code size
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regno
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename all "mtk_drm_plane" to "mtk_plane":
- To align the naming rule
- To reduce the code size
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regno
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename files mtk_drm_crtc.* to mtk_crtc.*.
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regno
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename files mtk_drm_gem.* to mtk_gem.*.
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regno
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename files mtk_drm_plane.* to mtk_plane.*.
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regno
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename files mtk_drm_ddp_comp.* to mtk_ddp_comp.*.
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regno
Il 26/02/24 09:50, Shawn Sung ha scritto:
From: Hsiao Chien Sung
Rename functions of mtk_ddp_comp:
- To align the naming rule
- To reduce the code size
Signed-off-by: Hsiao Chien Sung
Reviewed-by: AngeloGiaocchino Del Regno
Il 26/02/24 09:21, Fei Shao ha scritto:
On Thu, Feb 22, 2024 at 4:43 PM AngeloGioacchino Del Regno
wrote:
Il 21/02/24 17:56, Justin Green ha scritto:
Add MT8188 overlay driver configuration data. This change consequently
enables 10-bit overlay support on MT8188 devices.
Tested by running
Il 22/02/24 16:41, Chun-Kuang Hu ha scritto:
cmdq_pkt_jump_rel() append relative jump command to the packet.
Relative jump change PC to the target address with offset from
current PC.
Signed-off-by: Chun-Kuang Hu
Reviewed-by: AngeloGioacchino Del Regno
t;)
Signed-off-by: Chun-Kuang Hu
Reviewed-by: AngeloGioacchino Del Regno
Il 22/02/24 16:41, Chun-Kuang Hu ha scritto:
In order to distinguish absolute jump and relative jump,
cmdq_pkt_jump() append absolute jump command, so rename it to
cmdq_pkt_jump_abs().
Signed-off-by: Chun-Kuang Hu
Reviewed-by: AngeloGioacchino Del Regno
Il 21/02/24 17:56, Justin Green ha scritto:
Add MT8188 overlay driver configuration data. This change consequently
enables 10-bit overlay support on MT8188 devices.
Tested by running ChromeOS UI on MT8188 and using modetest -P. AR30 and
BA30 overlays are confirmed to work from modetest.
Signed-
Il 15/02/24 11:11, Hsiao Chien Sung ha scritto:
Register CRC related function pointers to support
CRC retrieval.
Signed-off-by: Hsiao Chien Sung
---
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 239
drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 39
drivers/gpu/dr
Il 15/02/24 11:11, Hsiao Chien Sung ha scritto:
Support "Pre-multiplied" and "None" blend mode on MediaTek's chips.
Before this patch, only the "Coverage" mode is supported.
Please refer to the description of the commit
"drm/mediatek: Support alpha blending in display driver"
for more informatio
pha for the composited
layer will take effects.
Signed-off-by: Hsiao Chien Sung
Reviewed-by: CK Hu
Reviewed-by: AngeloGioacchino Del Regno
n any case, it's not mandatory as that depends on what the maintainer prefers,
so it's CK's call anyway.
Besides that,
Reviewed-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 2 +-
drivers/gpu/drm/mediatek/mtk_ethdr.c| 7
Register the DSI host after getting clocks, iospace and PHY.
This wil also allow to simplify the error paths in a later commit.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 28 ++--
1 file changed, 14 in
e any extra-spec format support and/or
because the data rate (hence, the HS clock) will be wrong.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff
All entries fit in 82 columns, which is acceptable: compress all of
the mtk_dsi_of_match[] entries to a single line for each.
While at it, also add the usual sentinel comment to the last entry.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm
Reviewed-by: CK Hu
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 95 --
1 file changed, 50 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 0a83875ec1ba
In mtk_dsi_phy_timconfig(), we're dividing the `data_rate` variable,
expressed in Hz to retrieve a value in MHz: instead of open-coding,
use the HZ_PER_MHZ definition, available in linux/units.h.
Reviewed-by: Alexandre Mergnat
Reviewed-by: CK Hu
Signed-off-by: AngeloGioacchino Del
Change magic numerical masks with usage of the GENMASK() macro
to improve readability.
This commit brings no functional changes.
Reviewed-by: Alexandre Mergnat
Reviewed-by: CK Hu
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 45
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 78 ++
1 file changed, 25 insertions(+), 53 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 8af0afbe9e3d..0a83875ec1ba 100644
ister() function in the devm_request_irq() error
path, allowing to also remove the same label.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 60 +-
1 file changed, 18 insertions(+), 42 deletions(-)
diff
d, 18-bits for MIPI_DSI_FMT_RGB666_PACKED
Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
Reviewed-by: Alexandre Mergnat
Reviewed-by: CK Hu
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 10 +-
1 file changed, 5 insertions(+), 5 dele
panel).
AngeloGioacchino Del Regno (9):
drm/mediatek: dsi: Use GENMASK() for register mask definitions
drm/mediatek: dsi: Fix DSI RGB666 formats and definitions
drm/mediatek: dsi: Cleanup functions mtk_dsi_ps_control{_vact}()
drm/mediatek: dsi: Use bitfield macros where useful
drm/mediate
All entries fit in 82 columns, which is acceptable: compress all of
the mtk_dsi_of_match[] entries to a single line for each.
While at it, also add the usual sentinel comment to the last entry.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm
Register the DSI host after getting clocks, iospace and PHY.
This wil also allow to simplify the error paths in a later commit.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 28 ++--
1 file changed, 14 in
In mtk_dsi_phy_timconfig(), we're dividing the `data_rate` variable,
expressed in Hz to retrieve a value in MHz: instead of open-coding,
use the HZ_PER_MHZ definition, available in linux/units.h.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gp
e any extra-spec format support and/or
because the data rate (hence, the HS clock) will be wrong.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff
ister() function in the devm_request_irq() error
path, allowing to also remove the same label.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 60 +-
1 file changed, 18 insertions(+), 42 deletions(-)
diff
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 97 --
1 file changed, 52 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 7d38e9500700..a330bb94c44a 100644
Change magic numerical masks with usage of the GENMASK() macro
to improve readability.
This commit brings no functional changes.
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 45 +++---
1 file changed
: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 76 +-
1 file changed, 23 insertions(+), 53 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 8af0afbe9e3d..7d38e9500700 100644
--- a/drivers/gpu/drm
d, 18-bits for MIPI_DSI_FMT_RGB666_PACKED
Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
Reviewed-by: Alexandre Mergnat
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --g
, enhancing human
readability, using kernel provided macros where possible and
also reducing code size.
Tested on MT8173 and MT8192 Chromebooks (using a DSI<->DP bridge)
and on MT6795 Sony Xperia M5 (DSI video mode panel).
AngeloGioacchino Del Regno (9):
drm/mediatek: dsi: Use GENMASK
Il 06/02/24 15:47, Alexandre Mergnat ha scritto:
On 06/02/2024 13:07, AngeloGioacchino Del Regno wrote:
Change magic numerical masks with usage of the GENMASK() macro
to improve readability.
While at it, also fix the DSI_PS_SEL mask to include all bits instead
of just a subset of them.
This
Il 05/02/24 06:50, mac.shen ha scritto:
Add HDCP2.x feature for DisplayPort.
When userspace request the kernel protect future content communicated
over the link with Content_Protection property, the feature will do
HDCP2.x authentication if the sink support HDCP2.X.
Changes in v2:
- remove switc
Il 05/02/24 06:50, mac.shen ha scritto:
Add tee client application which will be used for
HDCP 1.x and 2.x authentication in DisplayPort.
Changes in v2:
- remove ca folder, and change file name with lower case
- refine the tci_t structure to make the data to tee can
through this structure
- r
Il 03/08/23 10:37, CK Hu (胡俊光) ha scritto:
Hi, Angelo:
On Thu, 2023-08-03 at 10:25 +0200, AngeloGioacchino Del Regno wrote:
Il 03/08/23 08:28, CK Hu (胡俊光) ha scritto:
Hi, Angelo:
On Wed, 2023-08-02 at 12:41 +0200, AngeloGioacchino Del Regno
wrote:
Il 02/08/23 08:24, CK Hu (胡俊光) ha scritto
Il 06/02/24 09:57, CK Hu (胡俊光) ha scritto:
Hi, Angelo:
On Wed, 2024-01-31 at 12:34 +0100, AngeloGioacchino Del Regno wrote:
Change magic numerical masks with usage of the GENMASK() macro
to improve readability.
While at it, also fix the DSI_PS_SEL mask to include all bits instead
of just a
e any extra-spec format support and/or
because the data rate (hence, the HS clock) will be wrong.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/med
All entries fit in 82 columns, which is acceptable: compress all of
the mtk_dsi_of_match[] entries to a single line for each.
While at it, also add the usual sentinel comment to the last entry.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 17
Function mtk_dsi_ps_control() is a subset of mtk_dsi_ps_control_vact():
merge the two in one mtk_dsi_ps_control() function by adding one
function parameter `config_vact` which, when true, writes the VACT
related registers.
Reviewed-by: Fei Shao
Signed-off-by: AngeloGioacchino Del Regno
also reducing code size.
Tested on MT8173 and MT8192 Chromebooks (using a DSI<->DP bridge)
and on MT6795 Sony Xperia M5 (DSI video mode panel).
AngeloGioacchino Del Regno (9):
drm/mediatek: dsi: Use GENMASK() for register mask definitions
drm/mediatek: dsi: Fix DSI RGB666 formats and defin
Change magic numerical masks with usage of the GENMASK() macro
to improve readability.
While at it, also fix the DSI_PS_SEL mask to include all bits instead
of just a subset of them.
This commit brings no functional changes.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm
Register the DSI host after getting clocks, iospace and PHY.
This wil also allow to simplify the error paths in a later commit.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
di
In mtk_dsi_phy_timconfig(), we're dividing the `data_rate` variable,
expressed in Hz to retrieve a value in MHz: instead of open-coding,
use the HZ_PER_MHZ definition, available in linux/units.h.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++-
1
d, 18-bits for MIPI_DSI_FMT_RGB666_PACKED
Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver")
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_
ister() function in the devm_request_irq() error
path, allowing to also remove the same label.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 60 +-
1 file changed, 18 insertions(+), 42 deletions(-)
diff --git a/drivers/gpu/drm/med
Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 97 --
1 file changed, 52 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
b/drivers/gpu/drm/mediatek/mtk_dsi.c
index b025886be680..26c221737387 100644
--- a/drivers/gpu/drm/mediatek
Il 06/02/24 10:50, CK Hu (胡俊光) ha scritto:
Hi, Angelo:
On Wed, 2024-01-31 at 12:34 +0100, AngeloGioacchino Del Regno wrote:
Function mtk_dsi_ps_control() is a subset of
mtk_dsi_ps_control_vact():
merge the two in one mtk_dsi_ps_control() function by adding one
function parameter `config_vact
Move the simple component check to a new mtk_ddp_is_simple_comp()
internal helper to reduce code duplication.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 57 +++--
1 file changed, 31 insertions(+), 26 deletions(-)
diff --git a
tmask of the found
possible CRTC; and
- mtk_drm_find_possible_crtc_by_comp() always returns either a
bitmask of the possible CRTC, or zero if none available.
Fixes: 01389b324c97 ("drm/mediatek: Add connector dynamic selection capability")
Signed-off-by: AngeloGioacchino Del Regno
-
from sub driver to
DRM driver")
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 38 -
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 +
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 ++-
3 files changed, 41 insertions(+), 2
This series performs some cleanups for DDP component CRTC search and
correctly iounmaps the previously of_iomap() calls from drm_ddp_comp.
Tested on MT8195 Cherry Tomato
AngeloGioacchino Del Regno (3):
drm/mediatek: drm_ddp_comp: Fix and cleanup DDP component CRTC search
drm/mediatek
Il 12/12/23 13:19, Hsiao Chien Sung ha scritto:
This series is based on mediatek-drm-next.
This series adds support for running IGT (Intel GPU Tool) tests
with MediaTek display driver. The following changes will be
applied:
1. Add a new API for creating GCE thread loop to retrieve CRCs
from
Il 31/01/24 13:25, Jiaxin Yu (俞家鑫) ha scritto:
On Wed, 2024-01-31 at 12:42 +0100, AngeloGioacchino Del Regno wrote:
Il 03/08/23 21:33, Mark Brown ha scritto:
On Thu, Aug 03, 2023 at 07:20:15AM +, Jiaxin Yu (俞家鑫) wrote:
I agree with you, in fact the speaker is indeed doing this way.
But
Il 03/08/23 21:33, Mark Brown ha scritto:
On Thu, Aug 03, 2023 at 07:20:15AM +, Jiaxin Yu (俞家鑫) wrote:
I agree with you, in fact the speaker is indeed doing this way. But
about the hdmi that on the board, I did not find a defination link
snd_soc_dapm_hdmi, so I use snd_soc_dapm_line to repl
Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 97 --
1 file changed, 52 insertions(+), 45 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
b/drivers/gpu/drm/mediatek/mtk_dsi.c
index 8414ce73ce9f..cba63de5092d 100644
--- a/drivers/gpu/drm/mediatek
ister() function in the devm_request_irq() error
path, allowing to also remove the same label.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 60 +-
1 file changed, 18 insertions(+), 42 deletions(-)
diff --git a/drivers/gpu/drm/med
In mtk_dsi_phy_timconfig(), we're dividing the `data_rate` variable,
expressed in Hz to retrieve a value in MHz: instead of open-coding,
use the HZ_PER_MHZ definition, available in linux/units.h.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++-
1
Function mtk_dsi_ps_control() is a subset of mtk_dsi_ps_control_vact():
merge the two in one mtk_dsi_ps_control() function by adding one
function parameter `config_vact` which, when true, writes the VACT
related registers.
Reviewed-by: Fei Shao
Signed-off-by: AngeloGioacchino Del Regno
Change magic numerical masks with usage of the GENMASK() macro
to improve readability.
While at it, also fix the DSI_PS_SEL mask to include all bits instead
of just a subset of them.
This commit brings no functional changes.
Signed-off-by: AngeloGioacchino Del Regno
---
drivers/gpu/drm
201 - 300 of 1508 matches
Mail list logo
