Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

Hi Maxime, On 28/05/24 17:13, Maxime Ripard wrote: > On Fri, May 24, 2024 at 04:38:13PM GMT, Aradhya Bhatia wrote: >> Hi Maxime, >> >> On 21/05/24 18:45, Maxime Ripard wrote: >>> Hi, >>> >>> On Thu, May

Re: [PATCH 1/7] drm/tidss: Add CRTC mode_fixup

Hi Maxime, On 21/05/24 18:48, Maxime Ripard wrote: > On Thu, May 16, 2024 at 04:33:40PM GMT, Aradhya Bhatia wrote: >> Hi Maxime, >> >> Thank you for reviewing the patches. >> >> On 16/05/24 13:40, Maxime Ripard wrote: >>> Hi, >>> >>> On

[PATCH v2 6/9] drm/bridge: cdns-dsi: Reset the DCS write FIFO

this reset. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index 05d2f4cc50da..87fdd07ca0bc 100644 --- a/drivers

[PATCH v2 9/9] drm/bridge: cdns-dsi: Use pre_enable/post_disable to enable/disable

get cdns-dsi ready and running before the tidss videoport to get pass the color shift issues. [0]: See section 12.6.5.7.3 "Start-up Procedure" in J721E SoC TRM TRM Link: http://www.ti.com/lit/pdf/spruil1 Signed-off-by: Aradhya Bhatia --- .../gpu/drm/bridge/cadence/cdns-dsi-core.c

[PATCH v2 8/9] drm/atomic-helper: Re-order bridge chain pre-enable and post-disable

TC is also a source feeding the bridge, it should not be enabled before the bridges in the pipeline are pre_enabled. Fix that by re-ordering the sequence of bridge pre_enable and bridge post_disable. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/drm_atomic_helper.c | 70 ++

[PATCH v2 7/9] drm/bridge: cdns-dsi: Support atomic bridge APIs

Change the existing (and deprecated) bridge hooks, to the bridge atomic APIs. Add drm helpers for duplicate_state, destroy_state, and bridge_reset bridge hooks. Further add support for the input format negotiation hook. Signed-off-by: Aradhya Bhatia --- .../gpu/drm/bridge/cadence/cdns-dsi

[PATCH v2 4/9] drm/bridge: cdns-dsi: Fix the clock variable for mode_valid()

Allow the D-Phy config checks to use mode->clock instead of mode->crtc_clock during mode_valid checks, like everywhere else in the driver. Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/cadence/cdn

[PATCH v2 5/9] drm/bridge: cdns-dsi: Wait for Clk and Data Lanes to be ready

edure" in J721E SoC TRM TRM Link: http://www.ti.com/lit/pdf/spruil1 Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff

[PATCH v2 1/9] drm/bridge: cdns-dsi: Fix OF node pointer

Fix the OF node pointer passed to the of_drm_find_bridge() call to find the next bridge in the display chain. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 2 +- 1 file changed, 1 inser

[PATCH v2 0/9] drm/bridge: cdns-dsi: Fix the color-shift issue

pre_enable/post_disable APIs instead to do bridge enable/disable. Previous versions: v1: https://lore.kernel.org/all/20240511153051.1355825-1-a-bhat...@ti.com/ Aradhya Bhatia (9): drm/bridge: cdns-dsi: Fix OF node pointer drm/bridge: cdns-dsi: Fix the phy_initialized variable drm/bridge: cdns

[PATCH v2 3/9] drm/bridge: cdns-dsi: Fix the link and phy init order

; in J721E SoC TRM TRM Link: http://www.ti.com/lit/pdf/spruil1 Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework") Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dr

[PATCH v2 2/9] drm/bridge: cdns-dsi: Fix the phy_initialized variable

Update the Phy initialized state to "not initialized" when the driver (and the hardware by extension) gets suspended. This will allow the Phy to get initialized again after resume. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-by: Aradhya Bhatia

Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

Hi Maxime, On 21/05/24 18:45, Maxime Ripard wrote: > Hi, > > On Thu, May 16, 2024 at 03:10:15PM GMT, Aradhya Bhatia wrote: >>>>/** >>>> * @pre_enable: >>>> * >>>> @@ -285,6 +319,26 @@ struct drm_bridge_funcs { >

Re: [PATCH v3 3/6] dt-bindings: display: simple: Add Microtips & Lincolntech Dual-LVDS Panels

Hi Liu, Thanks for reviewing the patch. On 16/05/24 07:49, Liu Ying wrote: > On 5/15/24 17:51, Aradhya Bhatia wrote: >> Add the Microtips Technology USA's MF-101HIEBCAF0 10.1"[0] panel, >> MF-103HIEB0GA0 10.25"[1] panel, and Lincoln Technology Solutions' >&

Re: [PATCH 1/7] drm/tidss: Add CRTC mode_fixup

Hi Maxime, Thank you for reviewing the patches. On 16/05/24 13:40, Maxime Ripard wrote: > Hi, > > On Sat, May 11, 2024 at 09:00:45PM +0530, Aradhya Bhatia wrote: >> Add support for mode_fixup for the tidss CRTC. >> >> Some bridges like the cdns-dsi consume t

Re: [PATCH 2/7] drm/bridge: cdns-dsi: Fix minor bugs

On 16/05/24 13:41, Maxime Ripard wrote: > On Sat, May 11, 2024 at 09:00:46PM +0530, Aradhya Bhatia wrote: >> Update the Phy initialized state to "not initialized" when the driver >> (and the hardware by extension) gets suspended. This will allow the Phy >> to get

Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

Hi Maxime, Thank you for reviewing the patches! On 16/05/24 13:52, Maxime Ripard wrote: > On Sat, May 11, 2024 at 09:00:50PM +0530, Aradhya Bhatia wrote: >> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h >> index 4baca0d9107b..40f93230abb2 100644 >&

[PATCH v3 6/6] drm/panel: simple: Add Microtips Technology MF-103HIEB0GA0 panel

d-off-by: Aradhya Bhatia --- drivers/gpu/drm/panel/panel-simple.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 3a0d8f0ff267..1b0a6b4e034c 100644 --- a/drivers/gpu/drm/panel/

[PATCH v3 4/6] drm/panel: simple: Add Lincoln Tech Sol LCD185-101CT panel

d-off-by: Aradhya Bhatia --- drivers/gpu/drm/panel/panel-simple.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index dcb6d0b6ced0..10e974bffd28 100644 --- a/drivers/gpu/drm/panel/panel-sim

[PATCH v3 2/6] dt-bindings: vendor-prefixes: Add lincolntech

Add document vendor prefix for Lincoln Technology Solutions (lincolntech). Signed-off-by: Aradhya Bhatia Acked-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH v3 5/6] drm/panel: simple: Add Microtips Technology 13-101HIEBCAF0-C panel

d-off-by: Aradhya Bhatia --- drivers/gpu/drm/panel/panel-simple.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 10e974bffd28..3a0d8f0ff267 100644 --- a/drivers/gpu/drm/panel/panel-sim

[PATCH v3 3/6] dt-bindings: display: simple: Add Microtips & Lincolntech Dual-LVDS Panels

/13-101HIEBCAF0-S_V1.1_20221104.pdf [1]: https://simplespec.microtipsusa.com/uploads/spec/datasheetFile/2660/13-103HIEB0GA0-S_V1.0_20211206.pdf [2]: https://lincolntechsolutions.com/wp-content/uploads/2023/04/LCD185-101CTL1ARNTT_DS_R1.3.pdf Signed-off-by: Aradhya Bhatia --- .../display/panel/pa

[PATCH v3 1/6] dt-bindings: vendor-prefixes: Add microtips

Add document vendor prefix for Microtips Technology USA (microtips). Signed-off-by: Aradhya Bhatia Acked-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation

[PATCH v3 0/6] drm/panel: simple: Add Panels and Panel Vendors

- Made dt-binding syntax corrections in Patch 3/4, based on comments by Krzysztof Kozlowski and Laurent Pinchart. V2: https://lore.kernel.org/all/20230124101238.4542-1-a-bhat...@ti.com/ V1: https://lore.kernel.org/all/20230103064615.5311-1-a-bhat...@ti.com/ Aradhya Bhatia (6): dt-bindin

Re: [PATCH 1/4] dt-bindings: display: ti,am65x-dss: Minor Cleanup

On 14/05/24 00:49, Rob Herring wrote: > On Sun, May 12, 2024 at 01:00:52AM +0530, Aradhya Bhatia wrote: >> Reduce tab size from 8 spaces to 4 spaces to make the bindings >> consistent, and easy to expand. > > "Re-indent the example" would be mor

Re: [PATCH 3/4] dt-bindings: display: ti,am65x-dss: Add OLDI properties for AM625 DSS

On 14/05/24 01:05, Rob Herring wrote: > On Sun, May 12, 2024 at 01:00:54AM +0530, Aradhya Bhatia wrote: >> The DSS in AM625 SoC has 2 OLDI TXes. Refer the OLDI schema to add the >> properties. >> >> Signed-off-by: Aradhya Bhatia >> --- >> .../bindings

Re: [PATCH 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

Hi Rob, Thank you for reviewing the patches! On 14/05/24 01:00, Rob Herring wrote: > On Mon, May 13, 2024 at 02:07:44PM +0530, Aradhya Bhatia wrote: >> Hi Laurent, >> >> Thank you for reviewing the patches! >> >> On 13-May-24 01:04, Laurent Pinchart wrote:

Re: [PATCH 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

Hi Laurent, Thank you for reviewing the patches! On 13-May-24 01:04, Laurent Pinchart wrote: > Hi Aradhya, > > Thank you for the patch. > > On Sun, May 12, 2024 at 01:00:53AM +0530, Aradhya Bhatia wrote: >> Add devicetree binding schema for AM625 OLDI Transmitters. >>

Re: [PATCH 4/4] drm/tidss: Add OLDI bridge support

Hi Francesco, On 12/05/24 17:18, Francesco Dolcini wrote: > Hello Aradhya, thanks for you patch, I should be able to test your patch on my > hardware in the coming days. That's appreciated. Thank you! =) > > On Sun, May 12, 2024 at 01:00:55AM +0530, Aradhya Bhatia wrote: &g

[PATCH 1/4] dt-bindings: display: ti,am65x-dss: Minor Cleanup

Reduce tab size from 8 spaces to 4 spaces to make the bindings consistent, and easy to expand. Signed-off-by: Aradhya Bhatia --- .../bindings/display/ti/ti,am65x-dss.yaml | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/Documentation/devicetree

[PATCH 4/4] drm/tidss: Add OLDI bridge support

support the new LVDS configurations. Signed-off-by: Aradhya Bhatia --- Note: The OLDI configuration should happen before the video-port configuration takes place in tidss_crtc_atomic_enable hook. I have posted a patch allowing DRM bridges to get enabled before the CRTC of that bridge is enabled

[PATCH 0/4] drm/tidss: Add OLDI bridge support

eries - v9 https://lore.kernel.org/all/20230616150900.6617-1-a-bhat...@ti.com/ [3]: GitHub Fork for OLDI tests https://github.com/aradhya07/linux-ab/tree/next_oldi_finals-v1-tests Aradhya Bhatia (4): dt-bindings: display: ti,am65x-dss: Minor Cleanup dt-bindings: display: ti: Add schema for

[PATCH 3/4] dt-bindings: display: ti, am65x-dss: Add OLDI properties for AM625 DSS

The DSS in AM625 SoC has 2 OLDI TXes. Refer the OLDI schema to add the properties. Signed-off-by: Aradhya Bhatia --- .../bindings/display/ti/ti,am65x-dss.yaml | 136 +- 1 file changed, 135 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display

[PATCH 2/4] dt-bindings: display: ti: Add schema for AM625 OLDI Transmitter

Add devicetree binding schema for AM625 OLDI Transmitters. Signed-off-by: Aradhya Bhatia --- .../bindings/display/ti/ti,am625-oldi.yaml| 153 ++ MAINTAINERS | 1 + 2 files changed, 154 insertions(+) create mode 100644 Documentation

[PATCH 7/7] drm/bridge: cdns-dsi: Implement early_enable and late_disable

the color issues. Signed-off-by: Aradhya Bhatia --- .../gpu/drm/bridge/cadence/cdns-dsi-core.c| 36 --- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index

[PATCH 4/7] drm/bridge: cdns-dsi: Reset the DCS write FIFO

Allow the DCS Write FIFO in the cdns-dsi controller to reset before any DCS packet is transmitted to the DSI sink device. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/cadence/cdns

[PATCH 5/7] drm/bridge: cdns-dsi: Support atomic bridge APIs

Change the existing (and deparacated) bridge hooks, to the bridge atomic APIs. Add drm helpers for duplicate_state, destroy_state, and bridge_reset bridge hooks. Further add support for the input format negotiation hook. Signed-off-by: Aradhya Bhatia --- .../gpu/drm/bridge/cadence/cdns-dsi

[PATCH 1/7] drm/tidss: Add CRTC mode_fixup

Add support for mode_fixup for the tidss CRTC. Some bridges like the cdns-dsi consume the crtc_* timing parameters for programming the blanking values. Allow for the normal timing parameters to get copied to crtc_* timing params. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/tidss

[PATCH 2/7] drm/bridge: cdns-dsi: Fix minor bugs

fig checks to use mode->clock instead of mode->crtc_clock during mode_valid checks, like everywhere else in the driver. Fixes: e19233955d9e ("drm/bridge: Add Cadence DSI driver") Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 7 --- 1 file c

[PATCH 6/7] drm/bridge: Introduce early_enable and late disable

e. Some bridges need to be up and running before and after their source gets enabled and has run. In some case, that source is a display unit, controlled as part of _crtc. For those bridges, add support for early_enable and late_disable function hooks. Signed-off-by: Aradhya Bhatia

[PATCH 0/7] drm/bridge: cdns-dsi: Fix the color-shift issue

://github.com/aradhya07/linux-ab/tree/next_dsi_finals-v1-test_rpi Aradhya Bhatia (7): drm/tidss: Add CRTC mode_fixup drm/bridge: cdns-dsi: Fix minor bugs drm/bridge: cdns-dsi: Wait for Clk and Data Lanes to be ready drm/bridge: cdns-dsi: Reset the DCS write FIFO drm/bridge: cdns-dsi: Support

[PATCH 3/7] drm/bridge: cdns-dsi: Wait for Clk and Data Lanes to be ready

e DSI driver") Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c index 557b037bbc67..05

Re: [PATCH v5 0/4] Add common1 region for AM62, AM62A & AM65x

64: dts: ti: Add common1 register space for AM62A SoC For the series, Reviewed-by: Aradhya Bhatia Regards Aradhya > > .../devicetree/bindings/display/ti/ti,am65x-dss.yaml | 7 +-- > arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 5 +++-- > arch/arm64/

Re: [PATCH v3 1/2] dt-bindings: display: ti,am65x-dss: Add support for common1 region

ing for "common1" register region too as supported by the > hardware. > > [1]: > AM62x TRM: > https://www.ti.com/lit/pdf/spruiv7 (Section 14.8.9.1 DSS Registers) > > AM65x TRM: > https://www.ti.com/lit/pdf/spruid7 (Section 12.6.5 DSS Registers) Can you add the

Re: [PATCH 2/2] drm/tidss: Fix sync-lost issue with two displays

that the > OVR's CHANNELIN field has similar issue. So we may need to revisit this > when we find out more about the core issue. > > Signed-off-by: Tomi Valkeinen > Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display > SubSystem") Reviewed-by:

Re: [PATCH 1/2] drm/tidss: Fix initial plane zpos values

milar in this > option, and I'm not aware that this would actually help us in any way. > So, to keep the code simple, I opted for the 0, 1, 2, 3 values. > > Signed-off-by: Tomi Valkeinen > Fixes: 32a1795f57ee ("drm/tidss: New driver for TI Keystone platform Display > SubSyst

Re: [PATCH v3 2/2] arm64: dts: ti: Add common1 register space for AM62x, AM62A & AM65x SoCs

-dss.yaml > > Fixes: 3618811657b3 ("arm64: dts: ti: k3-am62a-main: Add node for Display > SubSystem (DSS)") > Fixes: 8ccc1073c7bb ("arm64: dts: ti: k3-am62-main: Add node for DSS") > Fixes: fc539b90eda2 ("arm64: dts: ti: am654: Add DSS node") > Sig

Re: [PATCH 0/2] drm/bridge: sii902x: Crash fixes

ted kernel boot on SK-AM62, SK-AM62-LP, SK-AM62A, and I couldn't reproduce the issue. The kernel booted fine every time. For the series, Reviewed-by: Aradhya Bhatia > > drivers/gpu/drm/bridge/sii902x.c | 42 > +++- > 1 file changed, 29 insertions

Re: [PATCH v2 0/2] drm/bridge: tc358767: Fix DRM_BRIDGE_ATTACH_NO_CONNECTOR case

quires DSI to be up for the AUX transactions? > >  Tomi > >> Best regards, >> Alexander >> >>> Signed-off-by: Tomi Valkeinen >>> --- >>> Changes in v2: >>> - Update the format negotiation patch as discussed in >>> https://lor

Re: [PATCH] drm/panel: re-alphabetize the menu list

On 07/12/23 22:28, Randy Dunlap wrote: > > > On 12/7/23 01:52, Aradhya Bhatia wrote: >> Hi Randy, >> >> Thanks for the patch! >> >> On 07/12/23 11:52, Randy Dunlap wrote: >>> A few of the DRM_PANEL entries have become out of alphabetical order

Re: [PATCH] drm/panel: re-alphabetize the menu list

Hi Randy, Thanks for the patch! On 07/12/23 11:52, Randy Dunlap wrote: > A few of the DRM_PANEL entries have become out of alphabetical order, > so move them around a bit to restore alpha order. > > Signed-off-by: Randy Dunlap > Cc: Neil Armstrong > Cc: Jessica Zhang > Cc: Sam Ravnborg >

Re: [PATCH v2 00/11] drm/tidss: Probe related fixes and cleanups

/tidss: Fix dss reset > drm/tidss: IRQ code cleanup > drm/tidss: Fix atomic_flush check > drm/tidss: Use DRM_PLANE_COMMIT_ACTIVE_ONLY For the series, Reviewed-by: Aradhya Bhatia Regards Aradhya > > drivers/gpu/drm/tidss/tidss_crtc.c | 12 ++ > drivers/g

[PATCH v3 2/2] drivers/tidss: Add support for AM62A7 DSS

off inside the SoC. Also add and use a new type of VP, DISPC_VP_TIED_OFF, for the tied-off VP1 of AM62A DSS. Signed-off-by: Aradhya Bhatia --- Notes: Changes from V2: * Add new DISPC_VP_TIED_OFF for tied-off video-ports. Changes from V1: * Correctly sort DISPC_AM62A7

[PATCH v3 1/2] dt-bindings: display: ti: Add support for am62a7 dss

-by: Aradhya Bhatia Reviewed-by: Krzysztof Kozlowski --- .../bindings/display/ti/ti,am65x-dss.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml

[PATCH v3 0/2] Add DSS support for TI AM62A7 SoC

62A7 macro after DISPC_AM625 in patch 2/2. Previous Versions: V1: https://lore.kernel.org/all/20230818131750.4779-1-a-bhat...@ti.com/ V2: https://lore.kernel.org/all/20230818142124.8561-1-a-bhat...@ti.com/ Aradhya Bhatia (2): dt-bindings: display: ti: Add support for am62a7 dss drivers/ti

Re: [PATCH] drm/bridge: tc358767: Support input format negotiation hook

Hi Sam, On 07-Nov-23 21:11, Sam Ravnborg wrote: > Hi Aradhya, > > On Tue, Nov 07, 2023 at 01:17:03AM +0530, Aradhya Bhatia wrote: >> Hi Sam, >> >> Thank you for the suggestion! >> >> On 06-Nov-23 18:08, Sam Ravnborg wrote: >>> Hi Aradhya, >>&

Re: [PATCH] drm/bridge: tc358767: Support input format negotiation hook

Hi Sam, Thank you for the suggestion! On 06-Nov-23 18:08, Sam Ravnborg wrote: > Hi Aradhya, > > On Tue, Oct 31, 2023 at 12:58:46AM +0530, Aradhya Bhatia wrote: >> With new connector model, tc358767 will not create the connector, when >> DRM_BRIDGE_ATTACH_NO_CONNECT

Re: [PATCH] drm/tilcdc: Fix irq free on unload

rq, causing issues on loading the driver a second time. > > Fixes: b6366814fa77 ("drm/tilcdc: Convert to Linux IRQ interfaces") > Cc: Thomas Zimmermann > Signed-off-by: Tomi Valkeinen > --- Reviewed-by: Aradhya Bhatia Regards Aradhya > drivers/gpu/drm/tilcdc/tilcdc_drv

Re: [PATCH 2/2] drm/bridge: tc358767: Fix link properties discovery

> Closes: > https://lore.kernel.org/all/24282420-b4dd-45b3-bb1c-fc37fe4a8...@siemens.com/ > Signed-off-by: Tomi Valkeinen > --- Thank you, Tomi, for quickly debugging this! Reviewed-by: Aradhya Bhatia Regards Aradhya > drivers/gpu/drm/bridge/tc358767.c | 7 +++ >

[PATCH] drm/bridge: tc358767: Support input format negotiation hook

DRM_BRIDGE_ATTACH_NO_CONNECTOR support. Input format is selected to MEDIA_BUS_FMT_RGB888_1X24 as default, as is the case with older model. Reported-by: Jan Kiszka Signed-off-by: Aradhya Bhatia --- Notes: * Since I do not have hardware with me, this was just build tested. I would appreciate

Re: [PATCH v7 7/8] drm/tidss: Update encoder/bridge chain connect model

On 30-Oct-23 14:55, Jan Kiszka wrote: > On 06.06.23 10:21, Aradhya Bhatia wrote: >> With the new encoder/bridge chain model, the display controller driver >> is required to create a drm_connector entity instead of asking the >> bridge to do so during drm_bridge_attach. Mor

Re: [PATCH 2/2] Revert "drm/omapdrm: Annotate dma-fence critical section in commit path"

tl from drm_ioctl+0x210/0x4a8 > drm_ioctl from sys_ioctl+0x138/0xf00 > sys_ioctl from ret_fast_syscall+0x0/0x1c > Exception stack(0xf1011fa8 to 0xf1011ff0) > 1fa0: 00466d58 be9ab510 0003 c03864bc be9ab510 be9ab4e0 > 1fc0: 00466d58 be9ab510 c03864bc 0036 00

Re: [PATCH 1/2] Revert "drm/tidss: Annotate dma-fence critical section in commit path"

kms_helper] > drm_atomic_helper_commit+0x1a8/0x1c0 [drm_kms_helper] > drm_atomic_commit+0xa8/0xe0 [drm] > drm_mode_atomic_ioctl+0x9ec/0xc80 [drm] > drm_ioctl_kernel+0xc4/0x170 [drm] > drm_ioctl+0x234/0x4b0 [drm] > drm_compat_ioctl+0x110/0x12c [drm] > __arm64_compat_sys_ioctl+0x128/0x15

Re: [PATCH v2] drm: bridge: it66121: Fix invalid connector dereference

hed. > > Fixes: e0fd83dbe924 ("drm: bridge: it66121: Add audio support") > Reported-by: Nishanth Menon > Closes: https://lore.kernel.org/all/20230825105849.crhon42qndxqif4i@gondola/ > Reviewed-by: Helen Koike > Signed-off-by: Jai Luthra Reviewed-by: Aradhya Bhat

Re: [PATCH] drm: bridge: it66121: Fix invalid connector dereference

Hi Jai, Thanks for debugging the issue. On 25-Aug-23 16:32, Jai Luthra wrote: > Fix the NULL pointer dereference when no monitor is connected, and the > sound card is opened from userspace. > > Instead return an error as EDID information cannot be provided to > the sound framework if there is

[PATCH v2 2/2] drivers/tidss: Add support for AM62A7 DSS

off inside the SoC. Signed-off-by: Aradhya Bhatia --- Notes: Changes from V1: * Correctly sort DISPC_AM62A7 macro after DISPC_AM625. drivers/gpu/drm/tidss/tidss_dispc.c | 53 + drivers/gpu/drm/tidss/tidss_dispc.h | 2 ++ drivers/gpu/drm/tidss

[PATCH v2 1/2] dt-bindings: display: ti: Add support for am62a7 dss

-by: Aradhya Bhatia --- Notes: Changes from V1: * No change from V1. .../bindings/display/ti/ti,am65x-dss.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings

[PATCH v2 0/2] Add DSS support for TI AM62A7 SoC

] in the branch "next_am62a-v2". Regards Aradhya [0]: https://github.com/aradhya07/linux-ab/tree/next_am62a-v2 Change Log: V1 -> V2: - Correctly sort DISPC_AM62A7 macro after DISPC_AM625 in patch 2/2. Previous Versions: V1: https://lore.kernel.org/all/20230818131750.4779-1-a-bhat...@ti.

[PATCH 1/2] dt-bindings: display: ti: Add support for am62a7 dss

-by: Aradhya Bhatia --- .../bindings/display/ti/ti,am65x-dss.yaml | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml b/Documentation/devicetree/bindings/display/ti/ti,am65x-dss.yaml index ae09cd3cbce1..b6767ef0d24d

Re: [PATCH 2/2] drivers/tidss: Add support for AM62A7 DSS

On 18-Aug-23 18:47, Aradhya Bhatia wrote: > Add support for the DSS controller on TI's AM62A7 SoC in the tidss > driver. > > This contrller has 2 video pipelines that can render 2 video planes on > over a screen, using the overlay managers. The output of the DSS comes > from

[PATCH 0/2] Add DSS support for TI AM62A7 SoC

] in the branch "next_am62a". Regards Aradhya [0]: https://github.com/aradhya07/linux-ab/tree/next_am62a Aradhya Bhatia (2): dt-bindings: display: ti: Add support for am62a7 dss drivers/tidss: Add support for AM62A7 DSS .../bindings/display/ti/ti,am65x-dss.yaml | 14 + drivers/gpu

[PATCH 2/2] drivers/tidss: Add support for AM62A7 DSS

off inside the SoC. Signed-off-by: Aradhya Bhatia --- drivers/gpu/drm/tidss/tidss_dispc.c | 53 + drivers/gpu/drm/tidss/tidss_dispc.h | 2 ++ drivers/gpu/drm/tidss/tidss_drv.c | 1 + 3 files changed, 56 insertions(+) diff --git a/drivers/gpu/drm/tidss

Re: [PATCH v7 5/8] drm/bridge: sii902x: Support format negotiation hooks

Hi Sam, On 10-Jul-23 20:38, Sam Ravnborg wrote: > Hi Aradhya, > > On Tue, Jun 06, 2023 at 01:51:39PM +0530, Aradhya Bhatia wrote: >> With new connector model, sii902x will not create the connector, when >> DRM_BRIDGE_ATTACH_NO_CONNECTOR is set and SoC driver will rely on

[PATCH v9 1/2] dt-bindings: display: ti, am65x-dss: Add am625 dss compatible

video port is same from AM65x DSS and it outputs DPI video data. It can support 2K resolutions @ 60fps, independently. Add the new controller's compatible and update descriptions. Signed-off-by: Aradhya Bhatia Acked-by: Krzysztof Kozlowski Reviewed-by: Tomi Valkeinen --- Notes: Changes from

[PATCH v9 2/2] drm/tidss: Add support for AM625 DSS

utputs DPI data directly out of the SoC. It has 24 data lines and can support a maximum of RGB888 output bus format. Signed-off-by: Aradhya Bhatia Reviewed-by: Tomi Valkeinen --- Notes: Changes from v8: * Update commit message. * Add Tomi Valkeinen's R-b tag. Changes from v7: * Drop a

[PATCH v9 0/2] Add DSS support for AM625 SoC

ned panels. 4. Drop the OLDI clock set patch. 5. Drop rgb565-to-888 patch. V3: - Change yaml enum in alphabetical order. - Correct a typo. V2: - Remove redundant register array. Aradhya Bhatia (2): dt-bindings: display: ti,am65x-dss: Add am625 dss compatible drm/tidss: Add support

Re: [PATCH v8 2/2] drm/tidss: Add support for AM625 DSS

Hi Tomi, Thank you for the reviews! On 16-Jun-23 18:15, Tomi Valkeinen wrote: > Hi, > > On 08/06/2023 19:37, Aradhya Bhatia wrote: >> Add support for the DSS controller on TI's AM625 SoC in the tidss >> driver. >> >> The AM625 DSS supports 2 video p

[PATCH v8 2/2] drm/tidss: Add support for AM625 DSS

Signed-off-by: Aradhya Bhatia --- Notes: Changes from v7: * Drop all changes made after v3. - Drop output bus type support. All outputs from DSS will be the video port outptus. * Make the first video port type as INTERNAL from OLDI. drivers/gpu/drm/tidss/tidss_di

[PATCH v8 1/2] dt-bindings: display: ti, am65x-dss: Add am625 dss compatible

video port is same from AM65x DSS and it outputs DPI video data. It can support 2K resolutions @ 60fps, independently. Add the new controller's compatible and update descriptions. Signed-off-by: Aradhya Bhatia --- Notes: Changes from v7: * Drop the 3rd port property and update descriptions

[PATCH v8 0/2] Add DSS support for AM625 SoC

set patch. 5. Drop rgb565-to-888 patch. V3: - Change yaml enum in alphabetical order. - Correct a typo. V2: - Remove redundant register array. Aradhya Bhatia (2): dt-bindings: display: ti,am65x-dss: Add am625 dss compatible drm/tidss: Add support for AM625 DSS .../bindings/display/t

Re: [PATCH v7 0/8] drm/tidss: Use new connector model for tidss

Hi Neil, Thank you for reviewing the previous patches! On 06-Jun-23 14:37, Neil Armstrong wrote: > Hi, > > On 06/06/2023 10:21, Aradhya Bhatia wrote: >> Hi all, >> >> I have picked up this long standing series from Nikhil Devshatwar[1]. >> >> This series

[PATCH v7 7/8] drm/tidss: Update encoder/bridge chain connect model

entity to expose it to userspace. Update the encoder/bridge initialization sequence in tidss as per the new model. Signed-off-by: Aradhya Bhatia --- Notes: changes from v5: * Drop patches 5 and 6 from the original series. * Instead add this patch that addresses Boris Brezillon's

[PATCH v7 8/8] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

Valkeinen Signed-off-by: Aradhya Bhatia --- Notes: changes from v2: * Fix the interrupt enable logic at other places in code * Reorder functions so that they can be used earlier in the program changes from v5: * Manual rebase to linux-next. .../drm/bridge/cadence/cdns-

[PATCH v7 6/8] drm/bridge: sii902x: Set input_bus_flags in atomic_check

off-by: Aradhya Bhatia Reviewed-by: Neil Armstrong --- Notes: changes from v6: * Add Neil Armstrong's R-b tag. drivers/gpu/drm/bridge/sii902x.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c in

[PATCH v7 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

. This patch adds the minimal required support to avoid failure after moving to new connector model. Signed-off-by: Nikhil Devshatwar [a-bhatia1: Drop the output_fmt check condition] Signed-off-by: Aradhya Bhatia --- Notes: changes from v1: * cosmetic fixes, commit message update

[PATCH v7 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

hil Devshatwar [a-bhatia1: replace timings in cdns_mhdp_platform_info by input_bus_flags] Signed-off-by: Aradhya Bhatia Reviewed-by: Neil Armstrong --- Notes: changes from v5: * remove the wrongly addded return statement in tfp410 driver. * replace the timings field in cdns_mhdp_platform_i

[PATCH v7 0/8] drm/tidss: Use new connector model for tidss

ridge to encoder with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. - Add format negotiation support for sii902x driver. Previous versions: V1 to V6: https://patchwork.freedesktop.org/series/82765/ Aradhya Bhatia (3): drm/bridge: sii902x: Support format negotiation hooks drm/bridge: sii902x: Set

[PATCH v7 1/8] drm/bridge: tfp410: Support format negotiation hooks

selected by the bridge from DT properties. Signed-off-by: Nikhil Devshatwar [a-bhatia1: Removed output fmt condition check] Signed-off-by: Aradhya Bhatia --- Notes: changes from v1: * Use only MEDIA_BUS_FMT_FIXED for output changes from V5: * Drop the output format check condition

[PATCH v7 5/8] drm/bridge: sii902x: Support format negotiation hooks

format is selected to MEDIA_BUS_FMT_RGB888_1X24 as default, as is the case with older model. Signed-off-by: Aradhya Bhatia Reviewed-by: Neil Armstrong --- Notes: changes from v6: * Add Neil Armstrong's R-b tag. drivers/gpu/drm/bridge/sii902x.c | 25 + 1 file

[PATCH v7 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

ook for the same. Signed-off-by: Nikhil Devshatwar Signed-off-by: Aradhya Bhatia Reviewed-by: Neil Armstrong --- Notes: changes from v4: * fix a warning Reported-by: kernel test robot changes from v5: * Move the return statement here from patch 4 (where it was added by mist

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

Hi Tomi, Thank you for taking a look at this. On 26/05/23 14:59, Tomi Valkeinen wrote: > On 16/05/2023 17:25, Aradhya Bhatia wrote: >> Hi Neil, >> >> Thank you for reviewing the patch. >> >> On 16-May-23 12:51, Neil Armstrong wrote: >>> On 15/05/2023

Re: [PATCH v6 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

Hi Neil, On 22-May-23 13:35, neil.armstr...@linaro.org wrote: > On 17/05/2023 07:48, Aradhya Bhatia wrote: >> Hi Neil, >> >> On 16-May-23 12:54, Neil Armstrong wrote: >>> On 09/05/2023 11:30, Aradhya Bhatia wrote: >>>> From: Nikhil Devshatwa

Re: [PATCH v6 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

Hi Neil, On 16-May-23 12:54, Neil Armstrong wrote: > On 09/05/2023 11:30, Aradhya Bhatia wrote: >> From: Nikhil Devshatwar >> >> input_bus_flags are specified in drm_bridge_timings (legacy) as well >> as drm_bridge_state->input_bus_cfg.flags >> >> The

Re: [PATCH v6 2/8] drm/bridge: tfp410: Set input_bus_flags in atomic_check

Hi Neil, On 16-May-23 12:55, Neil Armstrong wrote: > On 09/05/2023 11:30, Aradhya Bhatia wrote: >> From: Nikhil Devshatwar >> >> input_bus_flags are specified in drm_bridge_timings (legacy) as well >> as drm_bridge_state->input_bus_cfg.flags >> >> The

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

Hi Neil, Thank you for reviewing the patch. On 16-May-23 12:51, Neil Armstrong wrote: > On 15/05/2023 17:59, Aradhya Bhatia wrote: >> Hi Tomi, >> >> On 12-May-23 14:45, Tomi Valkeinen wrote: >>> On 09/05/2023 12:30, Aradhya Bhatia wrote: >>>> From: Nikhi

Re: [PATCH v6 3/8] drm/bridge: mhdp8546: Add minimal format negotiation

Hi Tomi, On 12-May-23 14:45, Tomi Valkeinen wrote: > On 09/05/2023 12:30, Aradhya Bhatia wrote: >> From: Nikhil Devshatwar >> >> With new connector model, mhdp bridge will not create the connector and >> SoC driver will rely on format negotiation to setup the en

[PATCH v6 6/8] drm/bridge: sii902x: Set input_bus_flags in atomic_check

off-by: Aradhya Bhatia --- drivers/gpu/drm/bridge/sii902x.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index 662b6cb4aa62..4d1f10532fa6 100644 --- a/drivers/gpu/drm/bridge/sii902x.c +++ b/drivers/gpu/drm/bri

[PATCH v6 1/8] drm/bridge: tfp410: Support format negotiation hooks

selected by the bridge from DT properties. Signed-off-by: Nikhil Devshatwar [a-bhatia1: Removed output fmt condition check] Signed-off-by: Aradhya Bhatia --- Notes: changes from v1: * Use only MEDIA_BUS_FMT_FIXED for output changes from V5: * Dropped the output format check condition

[PATCH v6 4/8] drm/bridge: mhdp8546: Set input_bus_flags from atomic_check

hil Devshatwar [a-bhatia1: replace timings in cdns_mhdp_platform_info by input_bus_flags] Signed-off-by: Aradhya Bhatia --- Notes: changes from v5: * removed the wrongly addded return statement in tfp410 driver. * replaced the timings field in cdns_mhdp_platform_info by input_bus_fl

[PATCH v6 8/8] drm/bridge: cdns-mhdp8546: Fix the interrupt enable/disable

From: Nikhil Devshatwar When removing the tidss driver, there is a warning reported by kernel about an unhandled interrupt for mhdp driver. [ 43.238895] irq 31: nobody cared (try booting with the "irqpoll" option) ... [snipped backtrace] [ 43.330735] handlers: [ 43.333020]

  1   2   >