[PATCH] MAINTAINERS: mark FRAMEBUFFER LAYER as Orphan

2020-09-24 Thread Bartlomiej Zolnierkiewicz
It has been a fun ride since 2017 but unfortunately I don't have enough time to look after it properly anymore. Signed-off-by: Bartlomiej Zolnierkiewicz --- MAINTAINERS |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: b/MAINTAINERS

Re: [PATCH v3 00/12] video: fbdev: use generic power management

2020-09-08 Thread Bartlomiej Zolnierkiewicz
drivers/video/fbdev/vt8623fb.c | 41 ++--- > include/linux/via-core.h | 2 - > 17 files changed, 267 insertions(+), 256 deletions(-) Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Ele

Re: [PATCH 22/29] video: fbdev: Avoid comma separated statements

2020-09-08 Thread Bartlomiej Zolnierkiewicz
On 8/25/20 6:56 AM, Joe Perches wrote: > Use semicolons and braces. > > Signed-off-by: Joe Perches Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/tgafb.c | 12 ++

Re: [PATCH] video: fbdev: radeon: Fix memleak in radeonfb_pci_register

2020-09-08 Thread Bartlomiej Zolnierkiewicz
eon_kick_out_firmware_fb(pdev); >> if (ret) >> - return ret; >> + goto err_release_fb; > > Good catch ! Thanks > > Reviewed-by: Mathieu Malaterre Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sams

Re: [PATCH] video: fbdev: replace spurious snprintf() with sprintf()

2020-09-08 Thread Bartlomiej Zolnierkiewicz
On 8/24/20 7:44 PM, Alex Dewar wrote: > par->vgapass is a u8, so if we are assuming that buf is at least > PAGE_SIZE then the extra checking is pointless. > > Signed-off-by: Alex Dewar Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sams

Re: [PATCH] docs: fb: Correcting the location of FRAMEBUFFER_CONSOLE option.

2020-09-08 Thread Bartlomiej Zolnierkiewicz
Device Drivers->Graphics Support-> > Console display driver support->Framebuffer Console Support. > > Correcting it in the docs. > > Signed-off-by: Bilal Wasim Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Polan

Re: [PATCH] video: fbdev: remove set but not used 'ulBestVCO'

2020-09-08 Thread Bartlomiej Zolnierkiewicz
’ set but not used [-Wunused-but-set-variable] > 123 | u32 ulBestVCO = 0, ulBestClk = 0, ulBestScore = 0; > | ^ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Sam

Re: [PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings

2020-09-08 Thread Bartlomiej Zolnierkiewicz
t; CC: Denis Efremov > Signed-off-by: kernel test robot > Signed-off-by: Julia Lawall Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > > tree: https://git.kernel.org/pub/scm/linu

Re: [PATCH] fbdev: remove mbx framebuffer driver

2020-09-08 Thread Bartlomiej Zolnierkiewicz
ere is no > point to keep the obsolete framebuffer driver. > > Signed-off-by: Mike Rapoport Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > .../userspace-api/ioctl/ioctl-number.rst

Re: [PATCH v1 0/2] video: fbdev: radeonfb: PCI PM framework upgrade and fix-ups.

2020-09-08 Thread Bartlomiej Zolnierkiewicz
gt; video: fbdev: aty: radeon_pm: remove redundant CONFIG_PM container > fbdev: radeonfb:use generic power management > > drivers/video/fbdev/aty/radeon_base.c | 10 --- > drivers/video/fbdev/aty/radeon_pm.c | 38 --- > drivers/video/fbdev/aty/rad

Re: [PATCH] video: fbdev: remove set but not used 'ulCoreClock'

2020-09-08 Thread Bartlomiej Zolnierkiewicz
’ set but not used [-Wunused-but-set-variable] // yanaijie > fixed > 247 | u32 ulCoreClock; > | ^~~ > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institut

Re: [PATCH] omapfb: fix spelling mistake "propert" -> "property"

2020-09-08 Thread Bartlomiej Zolnierkiewicz
On 8/5/20 12:28 PM, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a pr_err message. Fix it. > > Signed-off-by: Colin Ian King Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Sams

Re: [PATCH] coccinelle: api: fix device_attr_show.cocci warnings

2020-09-08 Thread Bartlomiej Zolnierkiewicz
@ -3506,7 +3506,7 @@ static ssize_t show_cursor_blink(struct > blink = (ops->flags & FBCON_FLAGS_CURSOR_TIMER) ? 1 : 0; > err: > console_unlock(); > - return snprintf(buf, PAGE_SIZE, "%d\n", blink); > + return scnprintf(buf, PAGE_SIZE, "%d\n&qu

Re: [PATCH] video: fbdev: sis: fix null ptr dereference

2020-09-08 Thread Bartlomiej Zolnierkiewicz
gt; queuedata is not set in the else block > > Reviewing the old code, the arrays FQBQData730 and FQBQData were > used directly. > > So hoist the setting of queuedata out of the if-else block. > > Fixes: 544393fe584d ("[PATCH] sisfb update") > > Signed-off-by:

Re: [PATCH v4] video: fbdev: ssd1307fb: Added support to Column offset

2020-09-08 Thread Bartlomiej Zolnierkiewicz
, 7 insertions(+), 2 deletions(-) >> > > Acked-by: Rob Herring Applied to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics ___ dri-devel mailing

Re: [PATCH] video: fbdev: fix setting of pixclock because a pass-by-value error

2020-09-08 Thread Bartlomiej Zolnierkiewicz
lated code. Very > little is now left.") > Signed-off-by: Colin Ian King Applied to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/vga16fb.c | 14 +++---

Re: [PATCH] fbdev: sm712fb: handle ioremap() errors in probe

2020-09-08 Thread Bartlomiej Zolnierkiewicz
d to drm-misc-next tree, thanks and sorry for the delay. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sm712fb.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/video/fbdev/sm712fb.

Re: [PATCH 1/1] fbmem: add margin check to fb_check_caps()

2020-09-08 Thread Bartlomiej Zolnierkiewicz
o validate xres and yres settings. >> >> Signed-off-by: George Kennedy >> Suggested-by: Dan Carpenter > > Suggested-by is perhaps a bit strong. Let's change that to: > > Reviewed-by: Dan Carpenter Applied to drm-misc-next tree, thanks and sorry for the delay. Best reg

Re: [PATCH v2 00/41] spi / fbdev / cpufreq / usb / mmc / hwmon / ARM: Prepare for multiplatform S3C

2020-08-21 Thread Bartlomiej Zolnierkiewicz
ist/?series=185855=* >> > > Hi All, Hi Krzysztof, > I applied second part of the set which finishes this step of S3C > cleanup. Thanks to Arnd for the work! Thank you (& Arnd) for working on this! PS I've checked fbdev related changes no

Re: [PATCH] video: fbdev: controlfb: Fix build for COMPILE_TEST=y && PPC_PMAC=n

2020-08-21 Thread Bartlomiej Zolnierkiewicz
pport") > Signed-off-by: Michael Ellerman Acked-by: Bartlomiej Zolnierkiewicz Thanks for fixing this. > --- > drivers/video/fbdev/controlfb.c | 2 ++ > 1 file changed, 2 insertions(+) > > Does anyone mind if I apply this via the powerpc tree for v5.9? > > It wo

Re: [PATCH] MAINTAINERS: enlist Greg formally for console stuff

2020-08-04 Thread Bartlomiej Zolnierkiewicz
dev maintainership > - lots of stuff in drivers/tty/vt, which is already under Greg's > maintainership. > > So I think this match gives reasonably useful Cc: lists for the files > and places I've tested. > > Cc: Bartlomiej Zolnierkiewicz > Cc: Greg KH > Cc: dr

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2020-08-03 Thread Bartlomiej Zolnierkiewicz
2017 I've tried to act as the last resort Maintainer for console stuff (AFAIK there are no "lost" patches) but it really deserves its own entry. Also most console patches make it through you nowadays anyway: $ git log --pretty=fuller --since=2017 drivers/video/console/|grep "Commit\:

Re: [PATCH] vgacon: fix out of bounds write to the scrollback buffer

2020-07-29 Thread Bartlomiej Zolnierkiewicz
wei.com/ and the patch is currently under review period (to give people chance to comment on it) and in my "to apply if no objections" folder. I see that your/Yunhai patch addresses the root source of the issue so I'll be happy to apply/ACK it instead of Yang's patch once the final version is pos

Re: [PATCH v2] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.

2020-07-24 Thread Bartlomiej Zolnierkiewicz
ot;struct >>>> fbcon_ops"->clear_margins. >>>> from >>>> https://lkml.kernel.org/r/20200715015102.3814-1-penguin-ker...@i-love.sakura.ne.jp >>> >>> That should be taken by the fbdev maintainer, but I can take it too if >>> people

Re: [PATCH v2] efi: avoid error message when booting under Xen

2020-07-14 Thread Bartlomiej Zolnierkiewicz
287b7f4 ("fbdev/efifb: Honour UEFI memory map attributes when > mapping the FB") > Signed-off-by: Juergen Gross Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/efifb.c

Re: [PATCH] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.

2020-07-14 Thread Bartlomiej Zolnierkiewicz
t; and somehow hit unexpectedly long bit_clear_margins() loops. I don't know > why syzbot does not hit general protection fault, but it would depend on > environment because in my VMware environment ioctl(FBIOPUT_VSCREENINFO) > returns -EINVAL if var.xres == var.yres == 0. > > [1]

Re: [PATCH] video: fbdev: vt8623fb: Constify static vga_regsets

2020-07-10 Thread Bartlomiej Zolnierkiewicz
623fb.o > > After: >textdata bss dec hex filename > 265336904 64 3350182dd drivers/video/fbdev/vt8623fb.o > > Signed-off-by: Rikard Falkeborn Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R

Re: [PATCH] fbdev: sm712fb: set error code in probe

2020-07-10 Thread Bartlomiej Zolnierkiewicz
ication project (linuxtesting.org). > > Signed-off-by: Evgeny Novikov Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sm712fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletio

Re: [PATCH][next] fbdev/fb.h: Use struct_size() helper in kzalloc()

2020-07-10 Thread Bartlomiej Zolnierkiewicz
lab.h:#include include/linux/vmalloc.h:#include so I've applied the patch as it is (hoping that the issue is so widespread that no-one tries to remove overflow.h from slab.h without fixing drivers at the same time).. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electro

Re: [PATCH] video: fbdev: neofb: fix memory leak in neo_scan_monitor()

2020-07-10 Thread Bartlomiej Zolnierkiewicz
xtesting.org). > > Signed-off-by: Evgeny Novikov Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/neofb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH] omapfb: fix multiple reference count leaks due to pm_runtime_get_sync

2020-07-10 Thread Bartlomiej Zolnierkiewicz
. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 7 +-- > drivers/video/fbdev/omap2/omapfb/dss/dsi.c | 7 +-- > drivers/video/fbdev/omap2/omapfb/dss/dss.c | 7 +-- > dr

Re: [PATCH] fbdev: da8xx-fb: go to proper label on error handling paths in probe

2020-07-10 Thread Bartlomiej Zolnierkiewicz
kes fb_probe() to go to label err_release_fb on > corresponding error handling paths. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Evgeny Novikov Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung

Re: [PATCH] omapfb: dss: Fix max fclk divider for omap36xx

2020-07-10 Thread Bartlomiej Zolnierkiewicz
applicable to stable 4.5+ while merging) Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > Linux 4.4 will need a similar patch, but it doesn't apply cleanly. > > The DRM version of this same fix is: > e2c4ed148cf3 ("drm/omap: fix

Re: [PATCH] video: fbdev: savage: fix memory leak on error handling path in probe

2020-07-10 Thread Bartlomiej Zolnierkiewicz
> Signed-off-by: Evgeny Novikov Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/savage/savagefb_driver.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH][next] fbcon: Use array3_size() helper in scr_memcpyw()

2020-07-10 Thread Bartlomiej Zolnierkiewicz
le and, audited and fixed > manually. > > Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 > Signed-off-by: Gustavo A. R. Silva Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > dri

Re: [PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/2/20 2:03 PM, Geert Uytterhoeven wrote: > On Tue, Jun 2, 2020 at 1:50 PM Bartlomiej Zolnierkiewicz > wrote: >> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote: >>> These #ifdefs are relics from APUS (Amiga Power-Up System), which >>> added a PPC board. APUS

Re: [PATCH v3] video: fbdev: ssd1307fb: Added support to Column offset

2020-07-10 Thread Bartlomiej Zolnierkiewicz
n SEG2 and ends in SEG129. > > Signed-off-by: Rodrigo Alencar <455.rodrigo.alen...@gmail.com> Please resend with "From:" & "Signed-off-by:" tags fixed to match so I can merge the patch. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Sam

Re: [PATCH v2 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

2020-07-10 Thread Bartlomiej Zolnierkiewicz
On 6/2/20 2:03 PM, Geert Uytterhoeven wrote: > On Tue, Jun 2, 2020 at 1:52 PM Bartlomiej Zolnierkiewicz > wrote: >> Since we lack the hardware (or proper emulator setup) for >> testing needed changes add FIXMEs to document the issues >> (so at least they are not forgo

Re: [PATCH][next] fbdev/fb.h: Use struct_size() helper in kzalloc()

2020-07-10 Thread Bartlomiej Zolnierkiewicz
-off-by: Gustavo A. R. Silva Applied to drm-misc-next tree, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > include/linux/fb.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/include/lin

Re: [PATCH] efi: avoid error message when booting under Xen

2020-07-10 Thread Bartlomiej Zolnierkiewicz
  if ((efifb_fix.smem_start + efifb_fix.smem_len) > >>>   (md.phys_addr + (md.num_pages << EFI_PAGE_SHIFT))) { >>> >> > > In case I see no reaction from the maintainer for another week I'll take > this patch through

Re: [Bug Report] drivers/video/fbdev/da8xx-fb.c: undefined behavior when left shifting

2020-06-09 Thread Bartlomiej Zolnierkiewicz
& 0xff) << 16) | (((u32)(pulse_width - 1) & 0x3f) << 10); lcdc_write(reg, LCD_RASTER_TIMING_1_REG); } Also it would be helpful to disallow negative values being passed from user-space in fb_ioctl(). Best regards, -- Bartlomiej Zolnierkiewicz Sams

Re: [Bug Report] drivers/video/fbdev/kyro/fbdev.c: unsigned integer wrap-around might cause unexpected behavior

2020-06-09 Thread Bartlomiej Zolnierkiewicz
ely maintained so I worry that without somebody with the access to hardware and time to investigate it further I cannot do much about the problem. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > Best, > Changming Liu > ___

Re: [PATCH v2] fbdev: geode: Add the missed pci_disable_device() in gx1fb_map_video_memory()

2020-06-09 Thread Bartlomiej Zolnierkiewicz
a/fbdev.c In order to bring back pci_disable_device() calls to gx1fb driver (and other affected ones) you should verify that the issue described in the above commit is no longer present (preferably with testing modified driver on a real hardware). Best regards, -- Bartlomiej Zolnierkiewicz Samsun

[PATCH v2] video: fbdev: uvesafb: fix "noblank" option handling

2020-06-09 Thread Bartlomiej Zolnierkiewicz
Fix the recent regression. Fixes: dbc7ece12a38 ("video: uvesafb: use true,false for bool variables") Cc: Jason Yan Reviewed-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: - added Reviewed-by tag from Sam - removed no longer working Michal's email address from Cc:

[PATCH v2 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

2020-06-02 Thread Bartlomiej Zolnierkiewicz
Since we lack the hardware (or proper emulator setup) for testing needed changes add FIXMEs to document the issues (so at least they are not forgotten). Cc: Al Viro Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: - rebased on top of updated patch #1/2 drivers/video

[PATCH v2 1/2] video: fbdev: amifb: add FIXME about dead APUS support

2020-06-02 Thread Bartlomiej Zolnierkiewicz
G_APUS. Add FIXME about using the C code variants (APUS ones) in the future. Reported-by: Al Viro Reported-by: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: - added FIXME comment instead of removing the C code variants drivers/video/fbdev/amifb.c |6 ++ 1 fil

Re: [PATCH 1/2] video: fbdev: amifb: remove dead APUS support

2020-06-02 Thread Bartlomiej Zolnierkiewicz
The only exception is the >> DIVUL() macro, which is used once during initialization, thus also not >> performance critical. > I see, thanks. Since the code in question is not performance critical it indeed seems to be good idea to use C version. However it still would need be tested on the hard

[PATCH 2/2] video: fbdev: amifb: add FIXMEs about {put,get}_user() failures

2020-06-02 Thread Bartlomiej Zolnierkiewicz
Since we lack the hardware (or proper emulator setup) for testing needed changes add FIXMEs to document the issues (so at least they are not forgotten). Cc: Al Viro Cc: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/amifb.c |2 ++ 1 file changed, 2

[PATCH 1/2] video: fbdev: amifb: remove dead APUS support

2020-06-02 Thread Bartlomiej Zolnierkiewicz
CONFIG_APUS. Reported-by: Al Viro Reported-by: Geert Uytterhoeven Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/amifb.c | 63 1 file changed, 63 deletions(-) Index: b/drivers/video/f

Re: [PATCH] video: pxafb: Fix the function used to balance a 'dma_alloc_coherent()' call

2020-06-01 Thread Bartlomiej Zolnierkiewicz
quot;[ARM] pxafb: allow video memory size to be > configurable") > Signed-off-by: Christophe JAILLET Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > driver

Re: [PATCH] video: fbdev: pxafb: Use correct return value for pxafb_probe()

2020-06-01 Thread Bartlomiej Zolnierkiewicz
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/pxafb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c > index 00b96a7..423331

Re: [PATCH] drivers/video: cleanup coding style in video a bit

2020-06-01 Thread Bartlomiej Zolnierkiewicz
On 4/27/20 10:05 AM, Bernard Zhao wrote: > Eliminate the magic numbers, add vender infoframe size macro > like other hdmi modules. > > Signed-off-by: Bernard Zhao Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewi

Re: [PATCH v3] console: newport_con: fix an issue about leak related system resources

2020-06-01 Thread Bartlomiej Zolnierkiewicz
d also > add release_mem_region() on device removal. > > Fixes: e86bb8acc0fdc ("[PATCH] VT binding: Make newport_con support binding") > Cc: Andy Shevchenko > Suggested-by: Bartlomiej Zolnierkiewicz > Signed-off-by: Dejin Zheng Applied to drm-misc-next tree (patch should

Re: [trivial PATCH] video: fbdev: Use IS_BUILTIN

2020-06-01 Thread Bartlomiej Zolnierkiewicz
. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/aty128fb.c | 6 +- > drivers/video/fbdev/aty/atyfb_base.c | 7 +-- > drivers/video/fbdev/aty/radeon_base.c | 6 +- > drivers/video/fbdev/nvidia/nvi

Re: [PATCH v1] video: fbdev: sm712fb: fix an issue about iounmap for a wrong address

2020-06-01 Thread Bartlomiej Zolnierkiewicz
th fbdev") > CC: Andy Shevchenko > Signed-off-by: Dejin Zheng Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/sm712fb.c | 2 ++ > 1 fil

Re: [PATCH] omapfb/dss: fix comparison to bool warning

2020-06-01 Thread Bartlomiej Zolnierkiewicz
gt; Signed-off-by: Jason Yan Applied to drm-misc-next tree (patch should show up in v5.9), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 2 +- > drivers/video/fbdev/omap2/omapf

Re: [PATCH] video: uvesafb: use true,false for bool variables

2020-06-01 Thread Bartlomiej Zolnierkiewicz
nocrtc = true; > else if (!strcmp(this_opt, "noedid")) > - noedid = 1; > + noedid = true; > else if (!strcmp(this_opt, "noblank")) > - blank = 0; > +

Re: [PATCH v2 2/2] powerpc/configs: replace deprecated riva/nvidia with nouveau

2020-05-18 Thread Bartlomiej Zolnierkiewicz
short on features and overall below par >>> >>> Users are encouraged to switch to the nouveau drm driver instead. >>> >>> v2: Split configs to separate patch, enable nouveau (Bartlomiej) >>> >>> Cc: Antonino Daplas >>> Cc: Bartlomiej Zolni

Re: [PATCH] fbdev: annotate rivafb/nvidiafb as obsolete

2020-05-14 Thread Bartlomiej Zolnierkiewicz
> Considering nouveau supports all that hardware (modulo nv03) just mark > these as obsolete/broken, referring to nouveau in the help text. > > Cc: Antonino Daplas > Cc: Bartlomiej Zolnierkiewicz > Cc: linux-fb...@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Sign

Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

2020-04-29 Thread Bartlomiej Zolnierkiewicz
ect solution but at the cost of 2 ifdefs it allows controlfb driver to be compile tested on any arch. Being able to compile test fbdev device drivers is really useful for me and saves me a lot of time when doing fbdev maintainer duties. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Inst

Re: [PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

2020-04-29 Thread Bartlomiej Zolnierkiewicz
On 4/29/20 1:54 PM, Sam Ravnborg wrote: > Hi Bartlomiej. > > On Wed, Apr 29, 2020 at 12:48:24PM +0200, Bartlomiej Zolnierkiewicz wrote: >> >> powerpc allyesconfig fails like this: >> >> drivers/video/fbdev/controlfb.c: In function 'controlfb_mmap': >>

Re: linux-next: build failure after merge of the drm-misc tree

2020-04-29 Thread Bartlomiej Zolnierkiewicz
On 4/29/20 10:09 AM, Bartlomiej Zolnierkiewicz wrote: > > Hi Stephen, > > On 4/29/20 12:33 AM, Stephen Rothwell wrote: >> Hi all, >> >> On Mon, 20 Apr 2020 13:01:18 +1000 Stephen Rothwell >> wrote: >>> >>> After merging the drm-misc tr

[PATCH v2] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

2020-04-29 Thread Bartlomiej Zolnierkiewicz
adding missing PPC32 dependency. Fixes: a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support") Reported-by: Stephen Rothwell Reported-by: kbuild test robot Cc: Sam Ravnborg Cc: Daniel Vetter Signed-off-by: Bartlomiej Zolnierkiewicz --- v2: fix implicit btext_update_di

Re: linux-next: build failure after merge of the drm-misc tree

2020-04-29 Thread Bartlomiej Zolnierkiewicz
ill appears to have not been addressed. Sorry for the delay, I've just posted a patch (also included below): "[PATCH] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n" which should fix it. Please verify it, thank you! Best regards, -- Bartlomiej Zo

[PATCH] video: fbdev: controlfb: fix build for COMPILE_TEST=y && PPC_PMAC=y && PPC32=n

2020-04-29 Thread Bartlomiej Zolnierkiewicz
adding missing PPC32 dependency. Fixes: a07a63b0e24d ("video: fbdev: controlfb: add COMPILE_TEST support") Reported-by: Stephen Rothwell Reported-by: kbuild test robot Cc: Sam Ravnborg Cc: Daniel Vetter Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c |

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

2020-04-23 Thread Bartlomiej Zolnierkiewicz
On 4/23/20 5:05 PM, Andy Shevchenko wrote: > On Thu, Apr 23, 2020 at 5:55 PM Bartlomiej Zolnierkiewicz > wrote: > >>> + if (err) >>> + iounmap((void *)npregs); >> >> Looks OK but while you are at it, could you please also add m

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

2020-04-23 Thread Bartlomiej Zolnierkiewicz
= do_take_over_console(_con, 0, MAX_NR_CONSOLES - 1, 1); console_unlock(); return err; } static void newport_remove(struct gio_device *dev) { give_up_console(_con); iounmap((void *)npregs); } ? > return err; > } > Best regards, -- Bartlomiej Zolnie

Re: [PATCH v4] video: fbdev: arcfb: add missed free_irq and fix the order of request_irq

2020-04-17 Thread Bartlomiej Zolnierkiewicz
g Yuan Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > Changes in v4: > - Use info->par->irq instead of par->irq to avoid dereferencing NULL > pointer. > > drivers/video/fbdev/arcfb.c | 10

Re: [PATCH v4] video: fbdev: vesafb: add missed release_region

2020-04-17 Thread Bartlomiej Zolnierkiewicz
er request_region() succeeds. > Then only call release_region() when "region" is not null. > > Signed-off-by: Chuhong Yuan Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > Changes in v4:

Re: [PATCH] video: fbdev: aty128fb: remove unused 'sdr_64'

2020-04-17 Thread Bartlomiej Zolnierkiewicz
> > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/aty/aty128fb.c | 14 -- > 1 file changed, 14 deletion

Re: [PATCH v3] fbdev: s1d13xxxfb: add missed unregister_framebuffer in remove

2020-04-17 Thread Bartlomiej Zolnierkiewicz
; > Signed-off-by: Chuhong Yuan Patch queued for v5.8 (w/ extra newline removed), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > Changes in v3: > - Fix code style. > - Set __s1d13xxxfb_remove() to return void. >

Re: [PATCH v2 RESEND] ARM/fbdev: sa11x0: Switch to use GPIO descriptors

2020-04-17 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] On 4/15/20 6:50 PM, Linus Walleij wrote: > This converts the SA11x0 frame buffer driver to use > GPIO descriptors. Get the GPIO optional and register > a look-up table specifically for the Shannon machine. > > Cc: Russell King > Cc: Bartlom

Re: [PATCH v1 3/5] video: ssd1307fb: Make use of device properties

2020-04-17 Thread Bartlomiej Zolnierkiewicz
ued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/ssd1307fb.c | 40 - > 1 file changed, 19 insertions(+), 21 deletions(-) > > diff --git a/drivers/video/fbdev/

Re: [PATCH] video: vt8500lcdfb: fix fallthrough warning

2020-04-17 Thread Bartlomiej Zolnierkiewicz
89408 ("fbdev: Implement simple blanking in pseudocolor modes > for vt8500lcdfb") > Cc: Alexey Charkov > Cc: Paul Mundt > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fb...@vger.kernel.org > Cc: # v2.6.38+ Patch queued for v5.8, thanks

Re: [PATCH v2 0/6] video: fbdev: controlfb: small cleanup

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 3/24/20 2:45 PM, Bartlomiej Zolnierkiewicz wrote: > Hi, > > Small cleanup for controlfb driver: > > - fix sparse warnings > - remove not working module support > - add COMPILE_TEST support > - remove redundant function prototypes > > Changes since v1 &

Re: [PATCH v1 2/5] video: ssd1307fb: Introduce temporary variable to increase readability

2020-04-17 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] On 3/24/20 6:05 PM, Andy Shevchenko wrote: > Introduce temporary variable to increase readability of the code. > > Signed-off-by: Andy Shevchenko Patch queued for v5.8 (w/ few lines over 80 characters fixed), thanks. Best regards, -- Bartlomiej Zolni

Re: [PATCH -next] omapfb/dss: remove unused varible 'venc_config_pal_bdghi'

2020-04-17 Thread Bartlomiej Zolnierkiewicz
ig_pal_bdghi = { > ^ > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Patch queued for v5.8 (w/ typo in the patch summary fixed), thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland > --- > drivers/video/fbdev/omap2/omapfb/dss/venc.c | 43 -

Re: [PATCH v1 5/5] video: ssd1307fb: Remove redundant forward declaration

2020-04-17 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel ML to Cc: ] On 3/24/20 6:05 PM, Andy Shevchenko wrote: > There is no need to have forward declaration of struct ssd1307fb_par. > Drop it for good. > > Signed-off-by: Andy Shevchenko Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewi

Re: [PATCH] video: fbdev: imxfb: ensure balanced regulator usage

2020-04-17 Thread Bartlomiej Zolnierkiewicz
> unbalanced disables for lcd supply > > which can be triggered by doing > > echo 4 > /sys/class/lcd/imxfb-lcd/lcd_power > > twice. > > Signed-off-by: Uwe Kleine-König Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewic

Re: [PATCH v1 4/5] video: ssd1307fb: Convert to atomic PWM API

2020-04-17 Thread Bartlomiej Zolnierkiewicz
e also make use of the pwm_set_relative_duty_cycle() helper to ease > relative to absolute duty_cycle conversion. > > Signed-off-by: Andy Shevchenko Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > driver

Re: [PATCH v2 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type

2020-04-17 Thread Bartlomiej Zolnierkiewicz
On 3/24/20 9:45 PM, Daniel Vetter wrote: > On Tue, Mar 24, 2020 at 02:45:03PM +0100, Bartlomiej Zolnierkiewicz wrote: >> Use in_le32() instead of le32_to_cpup() to fix sparse warning about >> improper type of the argument. >> >> Also add missing inline keyword to cont

Re: [PATCH v1 1/5] video: ssd1307fb: Convert driver to use ->probe_new()

2020-04-17 Thread Bartlomiej Zolnierkiewicz
chenko Patch queued for v5.8, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > drivers/video/fbdev/ssd1307fb.c | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/video/fbdev/ssd1307fb

Re: [PATCH v1 1/5] video: ssd1307fb: Convert driver to use ->probe_new()

2020-04-15 Thread Bartlomiej Zolnierkiewicz
ing of fbdev patches posted too late for v5.7 has been postponed after v5.7-rc1 release. LGTM after quick look. I'll review it properly / apply later this week (hopefully tomorrow). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics >>&g

Re: framebuffer bug (Re: general protection fault in do_syscall_64)

2020-03-31 Thread Bartlomiej Zolnierkiewicz
ime to time so any help in fixing this and other syzbot reports is welcomed. PS fbdev is maintained through drm-misc tree so patches can also be handled by other drm-misc maintainers in case I'm not available. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronic

Re: INFO: trying to register non-static key in try_to_wake_up

2020-03-31 Thread Bartlomiej Zolnierkiewicz
; > +fbdev maintainers Thank you for the report. fbdev is in the maintenance mode and no new features or drivers are being added so syzbot reports are not for a new bugs (regressions) and are not a priority (at least to me). I have only resources to review/merge pending fbdev patches from time

Re: [PATCH 0/3] video: Use scnprintf() for avoiding potential buffer overflow

2020-03-31 Thread Bartlomiej Zolnierkiewicz
On 3/27/20 9:25 AM, Takashi Iwai wrote: > On Fri, 20 Mar 2020 14:42:51 +0100, > Bartlomiej Zolnierkiewicz wrote: >> >> >> On 3/19/20 4:49 PM, Takashi Iwai wrote: >>> On Wed, 11 Mar 2020 10:32:27 +0100, >>> Takashi Iwai wrote: >>>> >&

Re: [PATCH v2 2/2] powerpc: Remove Xilinx PPC405/PPC440 support

2020-03-31 Thread Bartlomiej Zolnierkiewicz
delete mode 100644 arch/powerpc/platforms/40x/virtex.c > delete mode 100644 arch/powerpc/platforms/44x/virtex.c > delete mode 100644 arch/powerpc/platforms/44x/virtex_ml510.c > delete mode 100644 arch/powerpc/sysdev/xilinx_intc.c > delete mode 100644 arch/powerpc/sysdev/xilinx_pci.

Re: [PATCH v3] video: fbdev: vesafb: add missed release_region

2020-03-24 Thread Bartlomiej Zolnierkiewicz
On 3/24/20 2:35 PM, Chuhong Yuan wrote: > On Fri, Mar 20, 2020 at 8:01 PM Bartlomiej Zolnierkiewicz > wrote: >> >> >> On 3/10/20 3:35 AM, Chuhong Yuan wrote: >>> The driver forgets to free the I/O region in remove and probe >>> failure. >>>

[PATCH v2 2/6] video: fbdev: controlfb: add COMPILE_TEST support

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Add COMPILE_TEST support to controlfb driver for better compile testing coverage. While at it: - convert driver to use eieio() and dcbf() helpers instead of open-coding them - add invalid_vram_cache() helper to avoid code duplication Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej

[PATCH v2 0/6] video: fbdev: controlfb: small cleanup

2020-03-24 Thread Bartlomiej Zolnierkiewicz
of le32_to_cpup() - use eieio() and dcbf() helpers - add invalid_vram_cache() helper - add more dummy CONFIG_PPC_PMAC=n helpers to avoid ifdefs - add ACKs from Sam Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics Bartlomiej Zolnierkiewicz (6): video: fbdev

[PATCH v2 3/6] video: fbdev: controlfb: remove obsolete module support

2020-03-24 Thread Bartlomiej Zolnierkiewicz
CONFIG_FB_CONTROL is bool, hence the Apple "control" frame buffer driver cannot be built as a module. Replace module_init() by device_initcall(). Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 25 + 1 fi

[PATCH v2 6/6] video: fbdev: controlfb: remove function prototypes part #3

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Reorder code a bit and then remove no longer needed function prototypes. Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 302 +++- 1 file changed, 145 insertions(+), 157 deletions(-) diff --git a/drivers/video

[PATCH v2 5/6] video: fbdev: controlfb: remove function prototypes part #2

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Reorder code a bit and then remove no longer needed function prototypes. Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 410 +++- 1 file changed, 198 insertions(+), 212 deletions(-) diff --git a/drivers/video

[PATCH v2 4/6] video: fbdev: controlfb: remove function prototypes part #1

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Reorder code a bit and then remove no longer needed function prototypes. Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/controlfb.c | 41 +++-- 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a/drivers/video

[PATCH v2 1/6] video: fbdev: controlfb: fix sparse warning about using incorrect type

2020-03-24 Thread Bartlomiej Zolnierkiewicz
Use in_le32() instead of le32_to_cpup() to fix sparse warning about improper type of the argument. Also add missing inline keyword to control_par_to_var() definition (to match function prototype). Acked-by: Sam Ravnborg Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev

Re: fbdev: fix -Wextra build warnings

2020-03-20 Thread Bartlomiej Zolnierkiewicz
|8 > drivers/video/fbdev/savage/savagefb.h |2 +- > drivers/video/fbdev/via/debug.h|6 -- > drivers/video/fbdev/via/viafbdev.c |2 +- > 8 files changed, 14 insertions(+), 12 deletions(-) Patches #1-6 queued for v5.7, t

Re: [PATCH] omapfb: Remove unused writeback code

2020-03-20 Thread Bartlomiej Zolnierkiewicz
On 3/13/20 1:24 PM, Tomi Valkeinen wrote: > Remove unused writeback code. This code will never be used, as omapfb is > being deprecated. > > Signed-off-by: Tomi Valkeinen Patch queued for v5.7, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung

Re: [PATCH 0/3] video: Use scnprintf() for avoiding potential buffer overflow

2020-03-20 Thread Bartlomiej Zolnierkiewicz
> > Just a gentle ping about those patches. > Let me know if any further changes needed. Patches #1-3 queued for v5.7, thanks! Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] Fix off by one in nvidia driver strncpy size arg

2020-03-20 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Random J Developer using your real name (sorry, no pseudonyms or anonymous contributions.) ... Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics > --- > > Notes: > The bug could also be fixed by changing the size argume

Re: [PATCH v2] fbdev: s1d13xxxfb: add missed unregister_framebuffer in remove

2020-03-20 Thread Bartlomiej Zolnierkiewicz
> struct s1d13xxxfb_par *default_par; > @@ -895,7 +906,7 @@ static int s1d13xxxfb_probe(struct platform_device *pdev) > return 0; > > bail: > - s1d13xxxfb_remove(pdev); > + __s1d13xxxfb_remove(pdev); > return ret; > > } > Best regards

  1   2   3   4   5   6   7   >