Make ga100_mc_device static as it isn't exported, to
fix the following sparse warning:
drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: warning: symbol
'ga100_mc_device' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c | 2
Make wpr_generic_header_dump static to avoid the
following sparse warning:
drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c:49:1: warning: symbol
'wpr_generic_header_dump' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/nvkm/nvfw/acr.c | 2 +-
1 file changed
Make gf100_fifo_nonstall_block as it isn't exported, to
silence the following sparse warning:
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gf100.c:451:1: warning: symbol
'gf100_fifo_nonstall_block' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/nvkm
The ga102_gsps is not exported, so make it static to avoid the
following sparse warning:
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c:49:1: warning: symbol
'ga102_gsps' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/ga102.c | 2
tems:
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
The malidp_mw_connector_helper_funcs is not referenced by name
outside of the file it is in, so make it static to avoid the
following warning:
drivers/gpu/drm/arm/malidp_mw.c:59:41: warning: symbol
'malidp_mw_connector_helper_funcs' was not declared. Should it be static?
Signed-off-by: Ben
The armada_overlay_duplicate_state is not declared outside
the unit, so make it static to avoid the following sparse
warning:
drivers/gpu/drm/armada/armada_overlay.c:328:24: warning: symbol
'armada_overlay_duplicate_state' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc
?
Signed-off-by: Ben Dooks
---
Cc: Thierry Reding
Cc: dri-devel@lists.freedesktop.org
Cc: linux-te...@vger.kernel.org
---
drivers/gpu/host1x/cdma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/host1x/cdma.c b/drivers/gpu/host1x/cdma.c
index 48c84c48299c
The drm_need_swiotlb is declared in
which should be included in drivers/gpu/drm/drm_memory.c
to silence the following warning:
drivers/gpu/drm/drm_memory.c:159:6: warning: symbol 'drm_need_swiotlb' was not
declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Maarten Lankhorst
Cc
:6: warning: symbol
'malidp_error_stats_dump' was not declared. Should it be static?
drivers/gpu/drm/arm/malidp_drv.c:668:1: warning: symbol 'dev_attr_core_id' was
not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Liviu Dudau
Cc: Brian Starkey
Cc: David Airlie
Cc: Daniel
'drm_fb_cma_get_gem_addr' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
Cc: linux-ker...@vger.kernel.org
---
drivers/gpu/drm/drm_fb_cma_helper.c
Include for drm_timeout_abs_to_jiffies
definiton to fix the following sparse warning:
drivers/gpu/drm/drm_syncobj.c:1019:13: warning: symbol
'drm_timeout_abs_to_jiffies' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Maarten Lankhorst
Cc: Maxime Ripard
Cc: Sean Paul
The special_groups[] in nouveau_hwmon_init() is an
array of pointers, so use NULL instead of '0' as
the initialiser.
Fixes the following sparse warning:
drivers/gpu/drm/nouveau/nouveau_hwmon.c:744:29: warning: Using plain integer as
NULL pointer
Signed-off-by: Ben Dooks
---
Cc: Ben Skeggs
Cc
?
drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c:43:1: warning: symbol
'gv100_disp_core_mthd_sor' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Bad divisor in main::vcs_assign: 0
Cc: Ben Skeggs
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
Cc: nouv
On 09/10/2019 13:14, Ben Dooks wrote:
The drm_sched_fence_ops_{scheduled,finished} are not exported
from the file so make them static to avoid the following
warnings from sparse:
drivers/gpu/drm/scheduler/sched_fence.c:131:28: warning: symbol
'drm_sched_fence_ops_scheduled' was not declared
/a5xx_gpu.c:1302:6: warning: symbol 'a5xx_show' was
not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Rob Clark
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
Cc: linux-arm-...@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedr...@lists.freedesktop.org
The rockchip_gem_alloc_object function is not exported so
make it static to avoid the following sparse warning:
drivers/gpu/drm/rockchip/rockchip_drm_gem.c:297:28: warning: symbol
'rockchip_gem_alloc_object' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Sandy Huang
The nvkm_uclient_sclass object is not used outside the file
it is defined in, so make it static to avoid the following
sparse warning:
drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol
'nvkm_uclient_sclass' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc
. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/drm_fb_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
index a7ba5b4902d6..23e10075619f 100644
--- a/drivers/gpu/drm/drm_fb_helper.c
+++ b/drivers/gpu/drm
: warning: symbol
'msm8917_config' was not declared. Should it be static?
drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c:633:26: warning: symbol
'msm8998_config' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Rob Clark
Cc: Sean Paul
Cc: David Airlie
Cc: Daniel Vetter
Cc: linux
/scheduler/sched_fence.c:137:28: warning: symbol
'drm_sched_fence_ops_finished' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/scheduler/sched_fence.c | 4 ++--
1 file changed, 2
Include rockchip_drm_drv.h for definition of vop_platform_driver
to avoid the following sparse warning:
drivers/gpu/drm/rockchip/rockchip_vop_reg.c:982:24: warning: symbol
'vop_platform_driver' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Sandy Huang
Cc: "
/msgqueue_0148cdec.c:241:1: warning: symbol
'msgqueue_0148cdec_func' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
Cc: Ben Skeggs
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-devel@lists.freedesktop.org
Cc: nouv...@lists.freedesktop.org
Cc: linux-ker...@vger.kernel.org
Include drm_crtc_helper_internal.h for drm_fb_helper_modinit
definition to fix the following warning:
drivers/gpu/drm/drm_fb_helper.c:2410:12: warning: symbol
'drm_fb_helper_modinit' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/drm_fb_helper.c | 1 +
1
/gf100.c:760:1: warning: symbol
'gf100_gr_fecs_stop_ctxsw' was not declared. Should it be static?
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c:2071:1: warning: symbol
'gf100_gr_ctor_fw_legacy' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/nvkm
The gv100_disp_wimm is not declared, so make it static
to avoid the following warning:
drivers/gpu/drm/nouveau/nvkm/engine/disp/wimmgv100.c:39:1: warning: symbol
'gv100_disp_wimm' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/nvkm/engine/disp
Do not export gv100_fifo_runlist as it isn't not used
to remove the following morning:
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100.c:56:1: warning: symbol
'gv100_fifo_runlist' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/gv100
?
drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c:140:1: warning: symbol
'gv100_disp_wndw' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
The tu102_fifo_runlist is not exorted, so make it static
to avoid the following warning:
drivers/gpu/drm/nouveau/nvkm/engine/fifo/tu102.c:47:1: warning: symbol
'tu102_fifo_runlist' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo
: symbol
'headc57d_olut_set' was not declared. Should it be static?
drivers/gpu/drm/nouveau/dispnv50/headc57d.c:155:1: warning: symbol
'headc57d_olut' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/dispnv50/headc57d.c | 6 +++---
1 file changed, 3
The base917c_format isn't exported, so make it static to
avoid the following warning:
drivers/gpu/drm/nouveau/dispnv50/base917c.c:26:1: warning: symbol
'base917c_format' was not declared. Should it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/dispnv50/base917c.c | 2 +-
1
it be static?
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 ++
drivers/gpu/drm/nouveau/nv50_display.h | 3 ---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index b46be8a091e9
if there was a NULL
inline version of dev_iommu_fwspec_get() in the include/linux/iommu.h
header? The compiler should then optimise the lot out if the config
is not set.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink -
quot; here, it's not
something wrong, just code that has a better call available.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
On 2019-04-10 23:47, Stefan Agner wrote:
In case the IOMMU API is not available compiling host1x fails with
the following error:
In file included from drivers/gpu/host1x/hw/host1x06.c:27:
drivers/gpu/host1x/hw/channel_hw.c: In function
‘host1x_channel_set_streamid’:
2.c:529:41:got void *[addressable] [assigned] handle
Signed-off-by: Ben Dooks
---
drivers/gpu/drm/drm_ioc32.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/drm_ioc32.c b/drivers/gpu/drm/drm_ioc32.c
index 67b1fca39aa6..0e3043e08c69 100644
--- a/drive
On Thu, Feb 26, 2015 at 10:56:58AM +0100, Philipp Zabel wrote:
> Am Donnerstag, den 26.02.2015, 09:02 + schrieb Ben Dooks:
> > On Wed, Feb 25, 2015 at 09:27:57AM -0800, Mike Turquette wrote:
> [...]
> > > From: Michael Turquette
> > > Date: Wed, 25 Feb 201
must not dereference struct clk), but did not cause any
> regressions until the per-user struct clk patch was merged. Now the test
> for matching clk's will always fail with per-user struct clk's.
>
> clk_is_match is introduced to fix the regression and prevent drivers
> fro
38 matches
Mail list logo
