Re: [PATCH] drm/nouveau/nvkm/dp: Add hack to fix DP 1.3+ DPCD issues

2023-07-18 Thread Ben Skeggs
On Sat, 8 Jul 2023 at 07:59, Lyude Paul wrote: > > Currently we use the drm_dp_dpcd_read_caps() helper in the DRM side of > nouveau in order to read the DPCD of a DP connector, which makes sure we do > the right thing and also check for extended DPCD caps. However, it turns > out we're not

Re: [Nouveau] [PATCH v2] drm/nouveau: bring back blit subchannel for pre nv50 GPUs

2023-07-12 Thread Ben Skeggs
at least this part. > > v2: Only do it for NV11+ GPUs > > Closes: https://gitlab.freedesktop.org/drm/nouveau/-/issues/201 > Fixes: 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") > Signed-off-by: Karol Herbst Reviewed-by: Ben Skeggs > --- > driv

Re: [Nouveau] [PATCH] drm/nouveau/acr: Abort loading ACR if no firmware was found

2023-07-12 Thread Ben Skeggs
On Thu, 13 Jul 2023 at 05:31, Dave Airlie wrote: > > On Tue, 23 May 2023 at 19:37, Karol Herbst wrote: > > > > On Mon, May 22, 2023 at 10:18 PM Karol Herbst wrote: > > > > > > This fixes a NULL pointer access inside nvkm_acr_oneinit in case necessary > > > firmware files couldn't be loaded. > >

Re: [PATCH] drm/nouveau/fb: add missing sysmen flush callbacks

2023-04-10 Thread Ben Skeggs
rebase somehow. Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gf108.c | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk104.c | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gk110.c | 1 + > drivers/gpu/drm/nouveau/nvkm/subdev/fb/gm107.c | 1 + > 4 fi

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-02-20 Thread Ben Skeggs
On Mon, 20 Feb 2023 at 21:27, Karol Herbst wrote: > > On Mon, Feb 20, 2023 at 11:51 AM Chris Clayton > wrote: > > > > > > > > On 20/02/2023 05:35, Ben Skeggs wrote: > > > On Sun, 19 Feb 2023 at 04:55, Chris Clayton > > > wrote: > > &

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-02-19 Thread Ben Skeggs
es are configured via udev, the root partition is > >>> mounted and the drivers can get at the firmware. > >>> > >>> I've found, by turning on nouveau debug and taking a video of the screen > >>> as the system shuts down, that nouveau seems to > >>> be trying

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-01-30 Thread Ben Skeggs
On Tue, 31 Jan 2023 at 09:09, Chris Clayton wrote: > > Hi again. > > On 30/01/2023 20:19, Chris Clayton wrote: > > Thanks, Ben. > > > > >> Hey, > >> > >> This is a complete shot-in-the-dark, as I don't see this behaviour on > >> *any* of my boards. Could you try the attached patch please? > > >

Re: [PATCH 1/3] drm/nouveau/devinit/tu102-: wait for GFW_BOOT_PROGRESS == COMPLETED

2023-01-30 Thread Ben Skeggs
On Tue, 31 Jan 2023 at 09:19, Lyude Paul wrote: > > For the whole series: > > Reviewed-by: Lyude Paul > > Will push to drm-misc-fixes in just a moment Thank you Lyude! Much appreciated. Ben. > > On Tue, 2023-01-31 at 08:37 +1000, Ben Skeggs wrote: > > St

[PATCH 3/3] drm/nouveau/acr/gm20b: regression fixes

2023-01-30 Thread Ben Skeggs
Missed some Tegra-specific quirks when reworking ACR to support Ampere. Fixes: 2541626cfb79 ("drm/nouveau/acr: use common falcon HS FW code for ACR FWs") Signed-off-by: Ben Skeggs Tested-by: Diogo Ivo Tested-By: Nicolas Chauvet --- drivers/gpu/drm/nouveau/nvkm/core/firmware

[PATCH 2/3] drm/nouveau/fb/tu102-: fix register used to determine scrub status

2023-01-30 Thread Ben Skeggs
Turing apparently needs to use the same register we use on Ampere. Not executing the scrubber ucode when required would result in large areas of VRAM being inaccessible to the driver. Signed-off-by: Ben Skeggs --- .../gpu/drm/nouveau/include/nvkm/subdev/fb.h | 1 + .../gpu/drm/nouveau/nvkm

[PATCH 1/3] drm/nouveau/devinit/tu102-: wait for GFW_BOOT_PROGRESS == COMPLETED

2023-01-30 Thread Ben Skeggs
on some systems, where we get control of the HW before it's been fully reinitialised after resume from suspend. Signed-off-by: Ben Skeggs --- .../drm/nouveau/nvkm/subdev/devinit/tu102.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev

Re: linux-6.2-rc4+ hangs on poweroff/reboot: Bisected

2023-01-29 Thread Ben Skeggs
On Sat, 28 Jan 2023 at 21:29, Chris Clayton wrote: > > > > On 28/01/2023 05:42, Linux kernel regression tracking (Thorsten Leemhuis) > wrote: > > On 27.01.23 20:46, Chris Clayton wrote: > >> [Resend because the mail client on my phone decided to turn HTML on behind > >> my back, so my reply got

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-29 Thread Ben Skeggs
On Fri, 27 Jan 2023 at 20:42, Diogo Ivo wrote: > > On Fri, Jan 27, 2023 at 04:00:59PM +1000, Ben Skeggs wrote: > > On Fri, 20 Jan 2023 at 21:37, Diogo Ivo > > wrote: > > > > > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > > &

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-26 Thread Ben Skeggs
On Fri, 20 Jan 2023 at 21:37, Diogo Ivo wrote: > > On Wed, Jan 18, 2023 at 11:28:49AM +1000, Ben Skeggs wrote: > > On Mon, 16 Jan 2023 at 22:27, Diogo Ivo > > wrote: > > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > > > >

Re: [REGRESSION] GM20B probe fails after commit 2541626cfb79

2023-01-17 Thread Ben Skeggs
On Mon, 16 Jan 2023 at 22:27, Diogo Ivo wrote: > > On Mon, Jan 16, 2023 at 07:45:05AM +1000, David Airlie wrote: > > On Thu, Dec 29, 2022 at 12:58 AM Diogo Ivo > > wrote: > > As a quick check can you try changing > > > > drivers/gpu/drm/nouveau/nvkm/core/firmware.c:nvkm_firmware_mem_target > >

[PULL] nouveau-next

2022-11-07 Thread Ben Skeggs
to 6dd08133e9f705f6565e18f114cfeca3f3a6970a: drm/nouveau/gr/ga102: initial support (2022-11-08 15:46:01 +1000) Ben Skeggs (124): drm/nouveau/disp: move and extend the role of outp acquire/release methods drm/nouveau/disp

Re: [PATCH] drm/nouveau/bios: Rename prom_init() and friends functions

2022-03-18 Thread Ben Skeggs
On Sat, 19 Mar 2022 at 04:11, Lyude Paul wrote: > > Whoops, sorry! I was unsure of the preference in name we should go with so I > poked Ben on the side to ask them, but I can see they haven't yet responded. > I'll poke thme again and see if I can get a response. Yeah, please keep _prom as

Re: [Nouveau] [PATCH] drm/nouveau: wait for the exclusive fence after the shared ones v2

2021-12-15 Thread Ben Skeggs
sch > > Thanks. > > > > > Please also add a cc for linux-stable, so that this is fixed in 5.15.x > > Sure, but I still need some acked-by or rb from one of the Nouveau guys. > So gentle ping on that. Acked-by: Ben Skeggs > > Regards, > Christian. > >

Re: [Nouveau] [PATCH] drm/nouveau/acr: fix a couple NULL vs IS_ERR() checks

2021-11-18 Thread Ben Skeggs
On Thu, 18 Nov 2021 at 21:13, Dan Carpenter wrote: > > The nvkm_acr_lsfw_add() function never returns NULL. It returns error > pointers on error. > > Fixes: 22dcda45a3d1 ("drm/nouveau/acr: implement new subdev to replace > "secure boot"") > Signed-off-b

Re: [Nouveau] [PATCH] MAINTAINERS: update information for nouveau

2021-11-10 Thread Ben Skeggs
ave push access to drm-misc > (where changes are pushed to after landing in gitlab) and are known > nouveau developers. > We did this already for some trivial changes and critical bug fixes > already, we just weren't thinking about updating the MAINTAINERS file. > > Cc: Ben Skeggs >

Re: [Nouveau] [PATCH] drm/nouveau: set RGB quantization range to FULL

2021-11-10 Thread Ben Skeggs
ctly. Now displays that advertise RGB Selectable > Quantization Range in their EDID will understand that full range is > transmitted > by the HDMI output. This is consistent to how the Nvidia's driver behaves. > > Signed-off-by: Hans Verkuil Reviewed-by: Ben Skeggs > --- > diff --git a/

Re: [Nouveau] [PATCH] drm/nouveau: hdmigv100.c: fix corrupted HDMI Vendor InfoFrame

2021-11-10 Thread Ben Skeggs
in the HDMI Vendor > InfoFrame when transmitting 4kp30. > > Signed-off-by: Hans Verkuil > Fixes: 290ffeafcc1a (drm/nouveau/disp/gv100: initial support) Reviewed-by: Ben Skeggs > --- > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/hdmigv100.c > b/drivers/gpu/drm/nouve

Re: [PATCH v1 2/7] nouveau: ACPI: Use the ACPI_COMPANION() macro directly

2021-10-12 Thread Ben Skeggs
so it is way more > straightforward to evaluate the latter directly instead of passing > the handle produced by the former to acpi_bus_get_device(). > > Modify nouveau_acpi_edid() accordingly (no intentional functional > impact). > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Ben Sk

Re: [Nouveau] [PATCH] drm/nouveau/mmu/gp100: remove unused variable

2021-10-12 Thread Ben Skeggs
00-: drop unneeded assignment in the > if condition.") > Signed-off-by: Karol Herbst Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nvkm/subdev/mmu/vmmgp100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mmu/

Re: [PATCH] drm/nouveau/fifo: Reinstate the correct engine bit programming

2021-10-07 Thread Ben Skeggs
On Fri, 8 Oct 2021 at 07:46, Karol Herbst wrote: > > Reviewed-by: Karol Herbst Reviewed-by: Ben Skeggs > > I haven't checked if other places need fixing up yet, and I still want > to test this patch, but I won't get to it until Monday. But if > everything is in place we c

[PATCH] drm/nouveau/fifo/ga102: initialise chid on return from channel creation

2021-09-21 Thread Ben Skeggs
From: Ben Skeggs Turns out caller isn't zero-initialised after-all. Fixes: 6b457230bfa1 ("drm/nouveau/ga102-: support ttm buffer moves via copy engine") Reported-by: Karol Herbst Signed-off-by: Ben Skeggs --- drivers/gpu/drm/nouveau/nvkm/engine/fifo/ga102.c | 3 +++ 1 file

[PATCH v2] drm/nouveau/ga102-: support ttm buffer moves via copy engine

2021-09-16 Thread Ben Skeggs
From: Ben Skeggs We don't currently have any kind of real acceleration on Ampere GPUs, but the TTM memcpy() fallback paths aren't really designed to handle copies between different devices, such as on Optimus systems, and result in a kernel OOPS. A few options were investigated to try and fix

Re: [PATCH 1/2] drm/nouveau/ga102-: support ttm buffer moves via copy engine

2021-09-08 Thread Ben Skeggs
On Thu, 9 Sept 2021 at 04:19, Daniel Vetter wrote: > > On Mon, Sep 06, 2021 at 10:56:27AM +1000, Ben Skeggs wrote: > > From: Ben Skeggs > > > > We don't currently have any kind of real acceleration on Ampere GPUs, > > but the TTM memcpy() fallback paths ar

Re: [PATCH 1/2] drm/nouveau/ga102-: support ttm buffer moves via copy engine

2021-09-06 Thread Ben Skeggs
On Tue, 7 Sept 2021 at 10:28, Karol Herbst wrote: > > On Tue, Sep 7, 2021 at 1:28 AM Ben Skeggs wrote: > > > > On Tue, 7 Sept 2021 at 09:17, Karol Herbst wrote: > > > > > > ." > > > > > > > > > On Mon, Sep 6,

Re: [PATCH 1/2] drm/nouveau/ga102-: support ttm buffer moves via copy engine

2021-09-06 Thread Ben Skeggs
On Tue, 7 Sept 2021 at 09:17, Karol Herbst wrote: > > ." > > > On Mon, Sep 6, 2021 at 2:56 AM Ben Skeggs wrote: > > > > From: Ben Skeggs > > > > We don't currently have any kind of real acceleration on Ampere GPUs, > > but the TTM memcpy

[PATCH 2/2] drm/nouveau/kms/tu102-: delay enabling cursor until after assign_windows

2021-09-05 Thread Ben Skeggs
From: Ben Skeggs Prevent NVD core channel error code 67 occuring and hanging display, managed to reproduce on GA102 while testing suspend/resume scenarios. Required extension of earlier commit to fix interactions with EFI. Fixes: e78b1b545c6c ("drm/nouveau/kms/nv50: workaround EFI GOP w

[PATCH 1/2] drm/nouveau/ga102-: support ttm buffer moves via copy engine

2021-09-05 Thread Ben Skeggs
From: Ben Skeggs We don't currently have any kind of real acceleration on Ampere GPUs, but the TTM memcpy() fallback paths aren't really designed to handle copies between different devices, such as on Optimus systems, and result in a kernel OOPS. A few options were investigated to try and fix

Re: [PATCH] drm/ttm: Fix ttm_bo_move_memcpy() for subclassed struct ttm_resource

2021-08-30 Thread Ben Skeggs
copy we handed it was subclassed and worse, the original could have > been freed at this point. > > Fix this by using the original struct ttm_resource before it is > potentially freed in ttm_bo_move_sync_cleanup() > > Reported-by: Ben Skeggs > Reported-by: Dave Airlie > Cc: Christian

[PULL] nouveau-fixes 5.14

2021-08-18 Thread Ben Skeggs
linux-5.14 for you to fetch changes up to 59f216cf04d973b4316761cbf3e7cb9556715b7a: drm/nouveau: rip out nvkm_client.super (2021-08-18 19:00:15 +1000) Ben Skeggs (6): drm/nouveau: recognise GA107 drm/nouveau/disp: power

Re: [PATCH v8 8/8] nouveau/svm: Implement atomic SVM access

2021-05-20 Thread Ben Skeggs
notifiers to revoke the atomic access. The original page table > entries are then restored allowing CPU access to proceed. > > Signed-off-by: Alistair Popple The Nouveau bits at least look good to me. For patches 7/8: Reviewed-by: Ben Skeggs > > --- > > v7: > * Removed magic v

[PULL] nouveau-fixes 5.12

2021-03-24 Thread Ben Skeggs
Single regression fix. Thanks, Ben. The following changes since commit d27ce83fa4baa5cb908a42e9878564cad6ea0eb3: Merge tag 'du-fixes-20210316' of git://linuxtv.org/pinchartl/media into drm-fixes (2021-03-22 13:49:55 +1000) are available in the Git repository at:

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv04: use vzalloc for nv04_display

2021-03-24 Thread Ben Skeggs
On Mon, 8 Mar 2021 at 03:49, Ilia Mirkin wrote: > > The struct is giant, and triggers an order-7 allocation (512K). There is > no reason for this to be kmalloc-type memory, so switch to vmalloc. This > should help loading nouveau on low-memory and/or long-running systems. > > Reported-by: Nathan

Re: [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable

2021-03-24 Thread Ben Skeggs
On Wed, 17 Mar 2021 at 19:51, ChunyouTang wrote: > > From: tangchunyou > > disable,delete disable and return 0 > > Signed-off-by: tangchunyou Thanks! > --- > drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [PATCH v2] drm/nouveau/kms/nv50-: Correct size checks for cursors

2021-03-24 Thread Ben Skeggs
On Fri, 19 Mar 2021 at 09:04, Lyude Paul wrote: > > Found this while trying to make some changes to the kms_cursor_crc test. > curs507a_acquire checks that the width and height of the cursor framebuffer > are equal (asyw->image.{w,h}). This isn't entirely correct though, as the > height of the

Re: [Nouveau] [PATCH -next] drm/nouveau/core/client: Mark nvkm_uclient_sclass with static keyword

2021-03-24 Thread Ben Skeggs
On Tue, 23 Mar 2021 at 17:03, Zou Wei wrote: > > Fix the following sparse warning: > > drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol > 'nvkm_uclient_sclass' was not declared. Should it be static? > > Signed-off-by: Zou Wei Applied, thanks. > --- >

[PULL] nouveau-fixes 5.12

2021-03-02 Thread Ben Skeggs
) Ben Skeggs (1): drm/nouveau/fifo/gk104-gp1xx: fix creation of sw class drivers/gpu/drm/nouveau/nvkm/engine/fifo/gk104.c | 3 +++ 1 file changed, 3 insertions(+) ___ dri-devel mailing list dri

Re: [PATCH v2] drm/nouveau/pmu: fix timeout on GP108

2021-02-24 Thread Ben Skeggs
On Wed, 17 Feb 2021 at 13:30, Alexandre Courbot wrote: > > On Wed, Feb 17, 2021 at 1:20 AM Diego Viola wrote: > > > > This code times out on GP108, probably because the BIOS puts it into a > > bad state. > > > > Since we reset the PMU on driver load anyway, we are at no risk from > > missing a

[PULL] nouveau-next 5.12

2021-02-10 Thread Ben Skeggs
for you to fetch changes up to f6df392dddbb9e637b785e7e3d9337a74923dc10: drm/nouveau/top/ga100: initial support (2021-02-11 11:50:04 +1000) Ben Skeggs (87): drm/nouveau/engine: use refcount_t + private mutex drm

nouveau-next 5.12

2021-01-28 Thread Ben Skeggs
Ben Skeggs (3): drm/nouveau/kms/nv50-gp1xx: wait for less EVO pushbuf space for core updates without notify drm/nouveau/kms/gv100-: wait for less NVD pushbuf space for core updates without notify drm/nouveau/kms/nv50-: add module option to select EVO/NVD push buffer location

[PULL] nouveau-fixes 5.11

2021-01-26 Thread Ben Skeggs
000) Bastian Beranek (1): drm/nouveau/dispnv50: Restore pushing of all data. Ben Skeggs (1): drm/nouveau/nvif: fix method count when pushing an array Karol Herbst (1): drm/nouveau/svm: fail NOUVEAU_SVM_INIT ioctl on unsupported devices Lyude Paul (3): drivers/nouv

[PULL] nouveau: ampere modesetting

2021-01-14 Thread Ben Skeggs
/skeggsb/linux 04.01-ampere-lite for you to fetch changes up to 8ef23b6f6a79e6fa2a169081d2d76011fffa0482: drm/nouveau/disp/ga10[24]: initial support (2021-01-15 10:25:24 +1000) Ben Skeggs (15): drm/nouveau/core: recognise

[PULL] nouveau-fixes 5.11

2021-01-14 Thread Ben Skeggs
is at offset 0 (2021-01-15 10:25:17 +1000) Ben Skeggs (7): drm/nouveau/bios: fix issue shadowing expansion ROMs drm/nouveau/privring: ack interrupts the same way as RM drm/nouveau/i2c/gk110: split out from i2c/gk104

Re: [Nouveau] [PATCH] drm/nouveau: bail out of nouveau_channel_new if channel init fails

2020-11-15 Thread Ben Skeggs
On Mon, 16 Nov 2020 at 05:19, Karol Herbst wrote: > > On Sun, Nov 15, 2020 at 6:43 PM Salvatore Bonaccorso > wrote: > > > > Hi, > > > > On Fri, Aug 28, 2020 at 11:28:46AM +0200, Frantisek Hrbata wrote: > > > Unprivileged user can crash kernel by using > > > DRM_IOCTL_NOUVEAU_CHANNEL_ALLOC > >

Re: [Nouveau] [PATCH 1/8] drm/nouveau/kms/nv50-: Use atomic encoder callbacks everywhere

2020-11-13 Thread Ben Skeggs
I've merged all of these. Sent the first to 5.10-fixes for the regression there, the rest will go in with a later -next pull request. Thanks, Ben. On Sat, 14 Nov 2020 at 10:14, Lyude Paul wrote: > > It turns out that I forgot to go through and make sure that I converted all > encoder callbacks

[PULL] nouveau-next 5.11

2020-11-13 Thread Ben Skeggs
) Ben Skeggs (1): drm/nouveau/ttm: avoid using nouveau_drm.ttm.type_vram prior to nv50 drivers/gpu/drm/nouveau/nouveau_bo.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ___ dri-devel mailing list dri-devel@lists.freedesktop.org https

[PULL] nouveau-fixes 5.10

2020-11-13 Thread Ben Skeggs
/kms/nv50-: Use atomic encoder callbacks everywhere (2020-11-14 14:19:18 +1000) Alexander Kapshuk (1): drm/nouveau/kms: Fix NULL pointer dereference in nouveau_connector_detect_depth Ben Skeggs (1): drm/nouveau/ttm: avoid

[PULL] nouveau-fixes 5.10

2020-11-11 Thread Ben Skeggs
: drm/nouveau/ttm: avoid using nouveau_drm.ttm.type_vram prior to nv50 (2020-11-12 14:09:45 +1000) Alexander Kapshuk (1): drm/nouveau/kms: Fix NULL pointer dereference in nouveau_connector_detect_depth Ben Skeggs (1

Re: [PATCH] drm/nouveau: Fix out-of-bounds access when deferencing MMU type

2020-11-11 Thread Ben Skeggs
785646] __kmalloc_track_caller+0x1be/0x390 > >>> [ 18.792165] kstrdup_const+0x46/0x70 > >>> [ 18.797686] kobject_set_name_vargs+0x2f/0xb0 > >>> [ 18.803992] kobject_init_and_add+0x9d/0xf0 > >>> [ 18.810117] ttm_mem_global_init+0x12c/0x210 [ttm]

[PULL] nouveau-fixes 5.10

2020-10-29 Thread Ben Skeggs
The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: git://github.com/skeggsb/linux linux-5.10 for you to fetch changes up to d7787cc04e0a1f2043264d1550465081096bd065:

Re: [Nouveau] [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-09-30 Thread Ben Skeggs
On Wed, 30 Sep 2020 at 19:37, Daniel Vetter wrote: > > On Wed, Sep 30, 2020 at 10:45:05AM +1000, Ben Skeggs wrote: > > On Wed, 30 Sep 2020 at 00:52, Daniel Vetter wrote: > > > > > > On Thu, Sep 17, 2020 at 3:15 PM Daniel Vetter > > > wrote: > > &

Re: [PATCH 18/45] drm/nouveau: handle move notify inside move callback.

2020-09-29 Thread Ben Skeggs
On Thu, 24 Sep 2020 at 15:20, Dave Airlie wrote: > > From: Dave Airlie > > Don't use explicit move notify for moves just do it in the driver side. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 62 > 1 file changed, 44 insertions(+),

Re: [PATCH 00/45] TTM move refactoring

2020-09-29 Thread Ben Skeggs
oo caught up in each patches changes unless the end result > is a problem. I've looked over the nouveau-specific patches, and the ttm ones (mostly ignoring the changes to other drivers beyond a quick glance over). For all but 37/45 and the patches that depend on it: Reviewed-by: Ben Skeggs I'll

Re: [Nouveau] [PATCH] drm/nouveau: Drop mutex_lock_nested for atomic

2020-09-29 Thread Ben Skeggs
ith atomic: With atomic the bo pinning and > > > > actual modeset commit is completely separated in the code patsh. > > > > > > > > This annotation was originally added in > > > > > > > > commit 060810d7abaabcab282e062c595871d661561400 > > &g

Re: Why is nouveau using a separate swap storage?

2020-09-17 Thread Ben Skeggs
On Thu, 17 Sep 2020 at 20:06, Christian König wrote: > > Hi guys, > > just another TTM feature which is only used by nouveau. > > We have this bo->bo.persistent_swap_storage pointer which is only set by > nouveau to the GEM filp and used when a BO is swapped to a shmem file. > > As far as I can

Re: [Nouveau] [PATCH] drm/nouveau: Add fine-grain temperature reporting

2020-09-09 Thread Ben Skeggs
On Thu, 10 Sep 2020 at 00:07, Jeremy Cline wrote: > > On Wed, Sep 09, 2020 at 10:22:14AM +0200, Karol Herbst wrote: > > On Wed, Sep 9, 2020 at 6:06 AM Ben Skeggs wrote: > > > > > > On Thu, 13 Aug 2020 at 06:50, Jeremy Cline wrote: > > > > > > &

Re: [Nouveau] [PATCH] drm/nouveau: Add fine-grain temperature reporting

2020-09-08 Thread Ben Skeggs
On Thu, 13 Aug 2020 at 06:50, Jeremy Cline wrote: > > Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation of > new gp1xx temperature sensor") added support for reading finer-grain > temperatures, but continued to report temperatures in 1 degree Celsius > increments via

Re: [Nouveau] [PATCH v5 1/2] drm/nouveau/kms/nv50-: Program notifier offset before requesting disp caps

2020-09-07 Thread Ben Skeggs
On Sat, 5 Sep 2020 at 06:28, Lyude Paul wrote: > > Not entirely sure why this never came up when I originally tested this > (maybe some BIOSes already have this setup?) but the ->caps_init vfunc > appears to cause the display engine to throw an exception on driver > init, at least on my ThinkPad

Re: [PATCH 00/13] ttm tt refactor repost of part 1

2020-09-07 Thread Ben Skeggs
On Tue, 8 Sep 2020 at 06:46, Dave Airlie wrote: > > Most of these have r-b or acks already, patch 1 I may have > posted before but found in my tree, so reposting it, and patch > 5 for radeon I think were what needed re-review. R-b for ttm and nouveau changes, A-b for the other drivers. Ben. > >

[PULL] nouveau-fixes 5.9

2020-09-02 Thread Ben Skeggs
(2020-09-03 15:32:24 +1000) Ben Skeggs (3): drm/nouveau/kms/nv50-: add some whitespace before debug message drm/nouveau/kms/nv50-gp1xx: disable notifies again after core update drm/nouveau/kms/nv50-gp1xx: add WAR

Re: [Nouveau] [PATCH v4] drm/nouveau/kms/nv50-: Program notifier offset before requesting disp caps

2020-09-02 Thread Ben Skeggs
On Wed, 2 Sep 2020 at 09:43, Lyude Paul wrote: > > Not entirely sure why this never came up when I originally tested this > (maybe some BIOSes already have this setup?) but the ->caps_init vfunc > appears to cause the display engine to throw an exception on driver > init, at least on my ThinkPad

Re: [PATCH 1/3] drm/ttm: make sure that we always zero init mem.bus v2

2020-09-02 Thread Ben Skeggs
On Wed, 2 Sep 2020 at 01:05, Christian König wrote: > > We are trying to remove the io_lru handling and depend > on zero init base, offset and addr here. > > v2: init addr as well Looks like the issues I noticed in the previous version have been dealt with, so, for the series: R

Re: nouveau PUSHBUFFER_ERR on 5.9.0-rc2-next-20200824

2020-08-30 Thread Ben Skeggs
r0 & 0x001f) { > u32 chid = __ffs(intr0 & 0x001f) - 16; > nv50_disp_intr_error(disp, chid); > intr0 &= ~(0x0001 << chid); > } > ... > } > > Could this be in any way related to this series of commits? > commit 0a9609969

Re: [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: Program notifier offset before requesting disp caps

2020-08-30 Thread Ben Skeggs
On Wed, 26 Aug 2020 at 02:52, Lyude Paul wrote: > > On Tue, 2020-08-25 at 08:28 +1000, Ben Skeggs wrote: > > On Tue, 25 Aug 2020 at 04:33, Lyude Paul wrote: > > > Not entirely sure why this never came up when I originally tested this > > > (maybe some

Re: [Nouveau] [PATCH 1/2] drm/nouveau/kms/nv50-: Program notifier offset before requesting disp caps

2020-08-24 Thread Ben Skeggs
On Tue, 25 Aug 2020 at 04:33, Lyude Paul wrote: > > Not entirely sure why this never came up when I originally tested this > (maybe some BIOSes already have this setup?) but the ->caps_init vfunc > appears to cause the display engine to throw an exception on driver > init, at least on my ThinkPad

Re: [Nouveau] [RFC 20/20] drm/nouveau/kms: Start using drm_dp_read_dpcd_caps()

2020-08-11 Thread Ben Skeggs
gned-off-by: Lyude Paul Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_dp.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c > b/drivers/gpu/drm/nouveau/nouveau_dp.c > in

Re: [RFC 17/20] drm/nouveau/kms/nv50-: Add support for DP_SINK_COUNT

2020-08-11 Thread Ben Skeggs
ongle in before > plugging something into the dongle. > > So, let's fix this by checking the sink count in both > nouveau_dp_probe_dpcd() and nouveau_dp_irq(), and reprobing the > connector if things change. > > Signed-off-by: Lyude Paul Reviewed-by: Ben Skeggs > --- > dr

Re: [RFC 10/20] drm/nouveau/kms: Use new drm_dp_has_mst() helper for checking MST caps

2020-08-11 Thread Ben Skeggs
On Wed, 12 Aug 2020 at 06:06, Lyude Paul wrote: > > Signed-off-by: Lyude Paul Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_dp.c | 16 +++- > 1 file changed, 3 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_

Re: [RFC 01/20] drm/nouveau/kms: Fix some indenting in nouveau_dp_detect()

2020-08-11 Thread Ben Skeggs
On Wed, 12 Aug 2020 at 06:05, Lyude Paul wrote: > > Signed-off-by: Lyude Paul Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_dp.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c > b

Re: [git pull] drm next for 5.9-rc1

2020-08-10 Thread Ben Skeggs
On Tue, 11 Aug 2020 at 04:46, Dave Airlie wrote: > > On Mon, 10 Aug 2020 at 22:23, Christoph Hellwig wrote: > > > > On Thu, Aug 06, 2020 at 11:07:02AM +1000, Dave Airlie wrote: > > > nouveau: > > > - add CRC support > > > - start using NVIDIA published class header files > > > > Where does Nvdia

Re: [PATCH 59/59] drm/ttm: rename ttm_mem_reg to ttm_resource.

2020-08-04 Thread Ben Skeggs
f-by: Dave Airlie > > Acked-by: Christian König Reviewed-by: Ben Skeggs > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 6 +-- > > drivers/gpu/drm/amd/amdgpu/amdgpu_object.c| 4 +- > > drivers/gpu/drm/amd/amdgpu/amdgpu_o

Re: [PATCH 58/59] drm/ttm: rename ttm_mem_type_manager -> ttm_resource_manager.

2020-08-04 Thread Ben Skeggs
> Signed-off-by: Dave Airlie > > Acked-by: Christian König Reviewed-by: Ben Skeggs > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 2 +- > > drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c| 2 +- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c

Re: [PATCH 57/59] drm/ttm: rename bo manager to range manager.

2020-08-04 Thread Ben Skeggs
e Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > > > --- > > drivers/gpu/drm/ttm/Makefile | 2 +- > > .../{ttm_bo_manager.c => ttm_range_manager.c} | 26 +-- > > 2 files changed, 14 insertions(+), 14 deletion

Re: [PATCH 56/59] drm/ttm: add a wrapper for checking if manager is in use

2020-08-04 Thread Ben Skeggs
e Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > > > --- > > drivers/gpu/drm/nouveau/nouveau_ttm.c | 1 - > > drivers/gpu/drm/ttm/ttm_bo.c | 2 +- > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 14 +++--- > > in

Re: [PATCH 55/59] drm/ttm: drop type manager has_type

2020-08-04 Thread Ben Skeggs
sed api. > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 +- > > drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c | 2 +- > > drivers/g

Re: [PATCH 53/59] drm/ttm: drop man->bdev link.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > This link isn't needed anymore, drop it from the init interface. > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_gtt_mgr.c | 2 +- >

Re: [PATCH 54/59] drm/ttm: drop list of memory managers from device. (v2)

2020-08-04 Thread Ben Skeggs
ign it as a driver manager > > to simplify the lookup sequence. > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > > > --- > > drivers/gpu/drm/ttm/ttm_bo.c| 6 +++--- > > include/drm/ttm/ttm_bo_driver

Re: [PATCH 51/59] drm/ttm: drop priv pointer in memory manager

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > This isn't needed anymore by any drivers. > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > include/drm/ttm/ttm_bo_driver.h | 2 -- > 1 file ch

Re: [PATCH 50/59] drm/nouveau/ttm: move to driver allocated manager

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 45 +++ > 1 file changed, 32 insertions(+), 13 deletions(-) > > d

Re: [PATCH 47/59] drm/ttm: move range manager to subclassed driver allocation

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo_manager.c | 31 +--- > 1 file changed, 19 ins

Re: [PATCH 46/59] drm/ttm: make ttm_range_man_init/takedown take type + args

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:35, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > This makes it easier to move these to a driver allocated system > > > > Signed-off-by: Dave Airlie > > Reviewed-by

Re: [PATCH 44/59] drm/ttm: allow drivers to provide their own manager subclasses

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:30, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > This will get removed eventually and all drivers will use this. > > > > Signed-off-by: Dave Airlie > > Reviewed-by

Re: [PATCH 43/59] drm/ttm: rename manager variable to make sure wrapper is used.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:30, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > Other users of this should notice this change and switch to wrapper. > > > > Signed-off-by: Dave Airlie > > Reviewed-by

Re: [PATCH 36/59] drm/ttm: add wrapper to get manager from bdev.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 21:25, Christian König wrote: > > Am 04.08.20 um 04:56 schrieb Dave Airlie: > > From: Dave Airlie > > > > This will allow different abstractions later. > > > > Signed-off-by: Dave Airlie > > Acked-by: Christian König Reviewed-by

Re: [PATCH 39/59] drm/nouveau/ttm: use wrapper to access memory managers

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gp

Re: [PATCH 35/59] drm/ttm: make TTM responsible for cleaning system only.

2020-08-04 Thread Ben Skeggs
önig > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo.c| 54 +++-- > include/drm/ttm/ttm_bo_api.h| 28 - > include/drm/ttm/ttm_bo_driver.h | 10 -- > 3 files changed, 4 insertions(+), 88

Re: [PATCH 34/59] drm/ttm: remove range manager legacy takedown path

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Now all drivers have been converted, drop the non-driver path. > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/dr

Re: [PATCH 30/59] drm/nouveau: use new cleanup paths

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:58, Dave Airlie wrote: > > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 41 --- > 1 file changed, 30 insertions(+), 11 deletions(-) > > d

Re: [PATCH 26/59] drm/ttm: start allowing drivers to use new takedown path (v2)

2020-08-04 Thread Ben Skeggs
e Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > > > --- > > drivers/gpu/drm/ttm/ttm_bo.c | 12 +++- > > drivers/gpu/drm/ttm/ttm_bo_manager.c | 21 +++-- > > include/drm/ttm/ttm_bo_driver.h | 24 ++

Re: [PATCH 25/59] drm/ttm: make some inline helper functions for cleanup paths. (v2)

2020-08-04 Thread Ben Skeggs
d docs. > > rename to ttm_mem_type_manager namespace > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König Reviewed-by: Ben Skeggs > > > --- > > drivers/gpu/drm/ttm/ttm_bo.c| 6 ++ > > include/drm/ttm/ttm_bo_driver.h | 26

Re: [PATCH 24/59] drm/ttm: pass man around instead of mem_type in some places

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > This makes it easier to cleanup things > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo.c | 14 ++ >

Re: [PATCH 23/59] drm/ttm: purge old manager init path.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo.c | 19 -- > drivers/gpu/drm/t

Re: [PATCH 22/59] drm/ttm: convert system manager init to new code.

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > Remove the exit path, since this can't fail now. > > Reviewed-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/ttm/ttm_bo.c | 30 +

Re: [PATCH 19/59] drm/nouveau: use new memory manager init paths

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 43 --- > 1 file changed, 19 insertions(+), 24 deletions(-) > > d

Re: [PATCH 09/59] drm/nouveau/ttm: don't fill in blank ttm debug callback

2020-08-04 Thread Ben Skeggs
On Tue, 4 Aug 2020 at 12:57, Dave Airlie wrote: > > From: Dave Airlie > > Acked-by: Christian König > Signed-off-by: Dave Airlie Reviewed-by: Ben Skeggs > --- > drivers/gpu/drm/nouveau/nouveau_ttm.c | 9 - > 1 file changed, 9 deletions(-) > > diff -

Re: [PATCH 08/59] drm/ttm: export memory type debug entrypoint.

2020-08-04 Thread Ben Skeggs
> (don't need to test for system as it won't init it). > > > > rename it to be more consistent with object name for now. > > (we may rename all the objects later.) > > > > Signed-off-by: Dave Airlie > > Reviewed-by: Christian König Review

  1   2   3   4   5   6   7   >