RE: [PATCH v5 3/3] drm/bridge/analogix/anx78xx: Drop conditionals around of_node pointers

2023-08-31 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 3/3] drm/bridge/analogix/anx78xx: Drop conditionals > around of_node pointers > > Hi Biju, > > Thank you for the patch. > > On Wed, Aug 30, 2023 at 06:08:19PM +0100, Biju Das wrote: > > Having

[PATCH v5 3/3] drm/bridge/analogix/anx78xx: Drop conditionals around of_node pointers

2023-08-30 Thread Biju Das
Having conditional around the of_node pointers turns out to make driver code use ugly #ifdef and #if blocks. So drop the conditionals. Suggested-by: Douglas Anderson Signed-off-by: Biju Das --- v5: * Split from patch#2 --- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 -- 1 file

[PATCH v5 2/3] drm/bridge: Drop conditionals around of_node pointers

2023-08-30 Thread Biju Das
Signed-off-by: Biju Das --- v5: * Split from patch#2 * Updated commit description * Added struct device_node forward declaration. --- include/drm/drm_bridge.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h index c3

[PATCH v5 1/3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-30 Thread Biju Das
The driver has an ID table, but it uses the wrong API for retrieving match data and that will lead to a crash, if it is instantiated by user space or using ID. From this, there is no user for the ID table and let's drop it from the driver as it saves some memory. Signed-off-by: Biju Das Reviewed

[PATCH v5 0/3] Drop ID table and conditionals around of_node pointers for anx78xx driver

2023-08-30 Thread Biju Das
h#2. * Updated commit description for patch#2 v3->v4: * Created patch#2 for dropping conditionals around of_node pointers. * Added Rb tag from Laurent and Douglas Anderson for patch#1. v2->v3: * Updated commit header. v1->v2: * Dropped ID table support. Biju Das (3): drm/bridge/anal

[PATCH v2 8/8] drm: adv7511: Add hpd_override_enable variable to struct adv7511_chip_info

2023-08-30 Thread Biju Das
. To avoid this we ignore the HPD pin for the first few seconds after enabling the output. On the other hand, adv7535 require to enable HPD Override bit for proper HPD. Add hpd_override_enable variable to struct adv7511_chip_info to handle this scenario. Signed-off-by: Biju Das --- v1->

[PATCH v2 7/8] drm: adv7511: Add link_config variable to struct adv7511_chip_info

2023-08-30 Thread Biju Das
The ADV7511 needs link configuration whereas ADV75{33,35} does not need it. Add a variable link_config to struct adv7511_chip_info to handle this difference. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart --- v1->v2: * Add Rb tag from Laurent. * Replaced variable type from unsig

[PATCH v2 6/8] drm: adv7511: Add has_dsi variable to struct adv7511_chip_info

2023-08-30 Thread Biju Das
The ADV7533 and ADV7535 have DSI support. Add a variable has_dsi to struct adv7511_chip_info for handling configuration related to DSI. Signed-off-by: Biju Das --- v1->v2: * Replaced variable type from unsigned->bool. * Restored check using type for low_refres

[PATCH v2 5/8] drm: adv7511: Add reg_cec_offset variable to struct adv7511_chip_info

2023-08-30 Thread Biju Das
and also testing for multiple chip types for calling adv7533_patch_cec_registers(). Signed-off-by: Biju Das --- v2: * New patch. --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 2 +- drivers/gpu/drm/bridge/adv7511/adv7511_cec.c | 14 +++--- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

[PATCH v2 4/8] drm: adv7511: Add supply_names and num_supplies variables to struct adv7511_chip_info

2023-08-30 Thread Biju Das
The ADV7511 has 5 power supplies compared to 7 that of ADV75{33,35}. Add supply_names and num_supplies variables to struct adv7511_chip_info to handle this difference. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart --- v1->v2: * Added Rb tag from Laurent. * Added trailing com

[PATCH v2 3/8] drm: adv7511: Add max_lane_freq_khz variable to struct adv7511_chip_info

2023-08-30 Thread Biju Das
The ADV7533 supports a maximum lane clock of 800MHz whereas it is 891MHz for ADV7535. Add max_lane_freq_khz variable to struct adv7511_chip_info to handle this difference. While at it, drop the unused local variable max_lane_freq. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart --- v1

[PATCH v2 2/8] drm: adv7511: Add max_mode_clock_khz variable to struct adv7511_chip_info

2023-08-30 Thread Biju Das
The ADV7533 supports a maximum pixel clock of 80MHz whereas it is 148.5MHz for ADV7535. Add max_mode_clock_khz variable to struct adv7511_chip_info to handle this difference. Signed-off-by: Biju Das Reviewed-by: Adam Ford Tested-by: Adam Ford #imx8mm-beacon Reviewed-by: Laurent Pinchart

[PATCH v2 1/8] drm: adv7511: Add struct adv7511_chip_info and use i2c_get_match_data()

2023-08-30 Thread Biju Das
for both OF and ID tables instead of the device type. Simplify the probe() by replacing of_device_get_match_data() and ID lookup for retrieving match data with i2c_get_match_data(). Signed-off-by: Biju Das Tested-by: Fabio Estevam Reviewed-by: Adam Ford Reviewed-by: Laurent Pinchart --- v1->

[PATCH v2 0/8] ADV7511 driver enhancements

2023-08-30 Thread Biju Das
ype for low_refresh_rate and regmap_register_patch(). * Replaced link_config variable type from unsigned->bool. * Restored enum adv7511_type as there are users. * Replaced hpd_override_enable variable type from unsigned->bool. Biju Das (8): drm: adv7511: Add struct adv7511_chip_info and use i2c_g

RE: [PATCH 5/7] drm: adv7511: Add has_dsi feature bit to struct adv7511_chip_info

2023-08-29 Thread Biju Das
Hi Laurent Pinchart, Thanks for the feedback. > Subject: Re: [PATCH 5/7] drm: adv7511: Add has_dsi feature bit to struct > adv7511_chip_info > > Hi Biju, > > On Tue, Aug 29, 2023 at 02:19:02PM +, Biju Das wrote: > > Subject: Re: [PATCH 5/7] drm: adv7511:

RE: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

2023-08-29 Thread Biju Das
Hi Laurent Pinchart, > Subject: Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node > pointers > > Hi Biju, > > Thank you for the patch. > > On Sat, Aug 26, 2023 at 08:19:01AM +0100, Biju Das wrote: > > Having conditional around the of_node pointer

RE: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

2023-08-29 Thread Biju Das
Hi Helen Mae Koike Fornazier, > Subject: Re: [PATCH v4 2/2] drm/bridge: Drop conditionals around of_node > pointers > > Hello! > > Thanks for the patch. > > On Saturday, August 26, 2023 04:19 -03, Biju Das > wrote: > > > Having conditional around th

RE: [PATCH 7/7] drm: adv7511: Add hpd_override_enable feature bit to struct adv7511_chip_info

2023-08-29 Thread Biju Das
Hi Laurent, > Subject: Re: [PATCH 7/7] drm: adv7511: Add hpd_override_enable feature bit > to struct adv7511_chip_info > > On Fri, Aug 18, 2023 at 07:41:45AM -0500, Adam Ford wrote: > > On Sun, Aug 13, 2023 at 1:06 PM Biju Das > wrote: > > > > > > As p

RE: [PATCH 6/7] drm: adv7511: Add link_config feature bit to struct adv7511_chip_info

2023-08-29 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH 6/7] drm: adv7511: Add link_config feature bit to > struct adv7511_chip_info > > Hi Biju, > > Thank you for the patch. > > On Sun, Aug 13, 2023 at 07:05:11PM +0100, Biju Das wrote: > > The ADV7511 ne

RE: [PATCH 5/7] drm: adv7511: Add has_dsi feature bit to struct adv7511_chip_info

2023-08-29 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH 5/7] drm: adv7511: Add has_dsi feature bit to struct > adv7511_chip_info > > Hi Biju, > > Thank you for the patch. > > On Sun, Aug 13, 2023 at 07:05:10PM +0100, Biju Das wrote: > > The ADV7533 and

RE: [PATCH 4/7] drm: adv7511: Add supply_names and num_supplies variables to struct adv7511_chip_info

2023-08-29 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH 4/7] drm: adv7511: Add supply_names and num_supplies > variables to struct adv7511_chip_info > > Hi Biju, > > Thank you for the patch. > > On Sun, Aug 13, 2023 at 07:05:09PM +0100, Biju Das wrote: > > Th

RE: [PATCH 3/7] drm: adv7511: Add max_lane_freq variable to struct adv7511_chip_info

2023-08-29 Thread Biju Das
Hi Laurent, > Subject: Re: [PATCH 3/7] drm: adv7511: Add max_lane_freq variable to struct > adv7511_chip_info > > Hi Biju, > > Thank you for the patch. > > On Sun, Aug 13, 2023 at 07:05:08PM +0100, Biju Das wrote: > > The ADV7533 supports a maximum lane clock of 8

RE: [PATCH 2/7] drm: adv7511: Add max_mode_clock variable to struct adv7511_chip_info

2023-08-29 Thread Biju Das
Hi Laurent Pinchart, Thanks for the feedback. > Subject: Re: [PATCH 2/7] drm: adv7511: Add max_mode_clock variable to > struct adv7511_chip_info > > Hi Biju, > > Thank you for the patch. > > On Sun, Aug 13, 2023 at 07:05:07PM +0100, Biju Das wrote: > > The AD

RE: [PATCH 1/7] drm: adv7511: Add struct adv7511_chip_info and use i2c_get_match_data()

2023-08-29 Thread Biju Das
Hi Laurent Pinchart, Thanks for the feedback. > Subject: Re: [PATCH 1/7] drm: adv7511: Add struct adv7511_chip_info and use > i2c_get_match_data() > > Hi Biju, > > Thank you for the patch. > > On Sun, Aug 13, 2023 at 07:05:06PM +0100, Biju Das wrote: > > Add stru

[PATCH v4 2/2] drm/bridge: Drop conditionals around of_node pointers

2023-08-26 Thread Biju Das
Having conditional around the of_node pointers turns out to make driver code use ugly #ifdef and #if blocks. So drop the conditionals. Suggested-by: Douglas Anderson Signed-off-by: Biju Das --- v4: * New patch --- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 -- include/drm

[PATCH v4 1/2] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-26 Thread Biju Das
The driver has an ID table, but it uses the wrong API for retrieving match data and that will lead to a crash, if it is instantiated by user space or using ID. From this, there is no user for the ID table and let's drop it from the driver as it saves some memory. Signed-off-by: Biju Das Reviewed

[PATCH v4 0/2] Drop ID table and conditionals around of_node pointers for anx78xx driver

2023-08-26 Thread Biju Das
v2->v3: * Updated commit header. v1->v2: * Dropped ID table support. Biju Das (2): drm/bridge/analogix/anx78xx: Drop ID table drm/bridge: Drop conditionals around of_node pointers drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 9 - include/drm/drm

RE: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-24 Thread Biju Das
Hi Laurent Pinchart, Thanks for the feedback. > Subject: Re: [PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table > > Hi Biju, > > Thank you for the patch. > > On Thu, Aug 24, 2023 at 07:15:46PM +0100, Biju Das wrote: > > The driver has an ID table, but it uses t

[PATCH v3] drm/bridge/analogix/anx78xx: Drop ID table

2023-08-24 Thread Biju Das
The driver has an ID table, but it uses the wrong API for retrieving match data and that will lead to a crash, if it is instantiated by user space or using ID. From this, there is no user for the ID table and let's drop it from the driver as it saves some memory. Signed-off-by: Biju Das --- v2

[PATCH v2] drm/bridge/analogix/anx78xx: Extend match data support for ID table

2023-08-24 Thread Biju Das
The driver has an ID table, but it uses the wrong API for retrieving match data and that will lead to a crash, if it is instantiated by user space or using ID. From this, there is no user for the ID table and let's drop it from the driver as it saves some memory. Signed-off-by: Biju Das --- v1

RE: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support for ID table

2023-08-24 Thread Biju Das
Hi Andy Shevchenko, > Subject: Re: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support > for ID table > > On Wed, Aug 23, 2023 at 9:39 PM Doug Anderson > wrote: > > On Wed, Aug 23, 2023 at 10:10 AM Andy Shevchenko > > wrote: > > > > > > > No. Please, do not remove the I2C ID table.

RE: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support for ID table

2023-08-23 Thread Biju Das
Hi Doug Anderson, > Subject: Re: [PATCH] drm/bridge/analogix/anx78xx: Extend match data support > for ID table > > Hi, > > On Sun, Aug 13, 2023 at 1:51 AM Biju Das > wrote: > > > > The driver has ID table, but still it uses device_get_match_data() >

RE: [PATCH v10 0/4] Add RZ/{G2L, G2LC} and RZ/V2L Display Unit support

2023-08-22 Thread Biju Das
LCDC references from bindings > > * Changed clock name from du.0->aclk from bindings > > * Changed reset name from du.0->du from bindings > > * Replaced crtc_helper_funcs->rcar_crtc_helper_funcs > > * Updated macro DRM_RZG2L_LCDC->DRM_RZG2L_DU > > * Replaced rzg2l-lcdc-drm-&g

RE: [PATCH] drm: bridge: it66121: Extend match support for OF tables

2023-08-21 Thread Biju Das
Hi Laurent Pinchart, Thanks for the feedback. > Subject: Re: [PATCH] drm: bridge: it66121: Extend match support for OF > tables > > Hi Biju, > > On Mon, Aug 14, 2023 at 09:06:46AM +, Biju Das wrote: > > Hi Laurent Pinchart, > > > > Thanks for the fee

[PATCH v3 2/2] drm: bridge: it66121: Simplify probe()

2023-08-18 Thread Biju Das
Simplify probe() by replacing of_device_get_match_data() and ID lookup for retrieving match data by i2c_get_match_data(). Signed-off-by: Biju Das Reviewed-by: Andy Shevchenko --- v2->v3: * Added Rb tag from Andy. v1->v2: * Dropped sentence for dropping local variable as it is integra

[PATCH v3 1/2] drm: bridge: it66121: Extend match support for OF tables

2023-08-18 Thread Biju Das
() if the devices are registered via OF. Signed-off-by: Biju Das Reviewed-by: Andy Shevchenko --- v2->v3: * Removed fixes tag as nothing broken. * Added Rb tag from Andy. v2: * New patch. --- drivers/gpu/drm/bridge/ite-it66121.c | 19 +++ 1 file changed, 11 insertions(+)

[PATCH v3 0/2] Match data improvements for it66121 driver

2023-08-18 Thread Biju Das
es tag. * patch#2 simplifies the probe() by using i2c_get_match_data. * Dropped sentence for dropping local variable as it is integral part of the patch. Biju Das (2): drm: bridge: it66121: Extend match support for OF tables drm: bridge: it66121: Simplify probe() drivers/gpu/drm/bridge/ite-it6

RE: [PATCH v2 1/2] drm: bridge: it66121: Extend match support for OF tables

2023-08-18 Thread Biju Das
Hi Andy Shevchenko, > Subject: Re: [PATCH v2 1/2] drm: bridge: it66121: Extend match support for > OF tables > > On Fri, Aug 18, 2023 at 05:54:51PM +0100, Biju Das wrote: > > The driver has OF match table, still it uses ID lookup table for > > retrieving match da

[PATCH v2 2/2] drm: bridge: it66121: Simplify probe()

2023-08-18 Thread Biju Das
Simplify probe() by replacing of_device_get_match_data() and ID lookup for retrieving match data by i2c_get_match_data(). Signed-off-by: Biju Das --- v1->v2: * Dropped sentence for dropping local variable as it is integral part of the patch. --- drivers/gpu/drm/bridge/ite-it66121.c

[PATCH v2 1/2] drm: bridge: it66121: Extend match support for OF tables

2023-08-18 Thread Biju Das
() if the devices are registered via OF. Fixes: 9a9f4a01bdae ("drm: bridge: it66121: Move VID/PID to new it66121_chip_info structure") Signed-off-by: Biju Das --- v2: * New patch. --- drivers/gpu/drm/bridge/ite-it66121.c | 19 +++ 1 file changed, 11 insertions(+), 8

[PATCH v2 0/2] Match data improvements for it66121 driver

2023-08-18 Thread Biju Das
nce for dropping local variable as it is integral part of the patch. Biju Das (2): drm: bridge: it66121: Extend match support for OF tables drm: bridge: it66121: Simplify probe() drivers/gpu/drm/bridge/ite-it66121.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) -- 2.25.1

RE: [PATCH 7/7] drm: adv7511: Add hpd_override_enable feature bit to struct adv7511_chip_info

2023-08-18 Thread Biju Das
Hi Adam, > Subject: Re: [PATCH 7/7] drm: adv7511: Add hpd_override_enable feature bit > to struct adv7511_chip_info > > On Fri, Aug 18, 2023 at 8:35 AM Biju Das > wrote: > > > > Hi Adam Ford, > > > > Thanks for the feedback. > > >

RE: [PATCH 7/7] drm: adv7511: Add hpd_override_enable feature bit to struct adv7511_chip_info

2023-08-18 Thread Biju Das
Hi Adam Ford, Thanks for the feedback. > Subject: Re: [PATCH 7/7] drm: adv7511: Add hpd_override_enable feature bit > to struct adv7511_chip_info > > On Sun, Aug 13, 2023 at 1:06 PM Biju Das > wrote: > > > > As per spec, it is allowed to pulse the HPD signal to

RE: [PATCH] drm: bridge: it66121: Extend match support for OF tables

2023-08-14 Thread Biju Das
Hi Laurent Pinchart, Thanks for the feedback. > Subject: Re: [PATCH] drm: bridge: it66121: Extend match support for OF > tables > > Hi Biju, > > Thank you for the patch. > > On Sun, Aug 13, 2023 at 09:05:20AM +0100, Biju Das wrote: > > The driver has OF match

[PATCH 7/7] drm: adv7511: Add hpd_override_enable feature bit to struct adv7511_chip_info

2023-08-13 Thread Biju Das
as it is unused. Signed-off-by: Biju Das --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 8 +--- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 12 +--- 2 files changed, 6 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge

[PATCH 6/7] drm: adv7511: Add link_config feature bit to struct adv7511_chip_info

2023-08-13 Thread Biju Das
The ADV7511 needs link configuration whereas ADV75{33,35} does not need it. Add a feature bit link_config to struct adv7511_chip_info to handle this difference. Signed-off-by: Biju Das --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 + drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 7

[PATCH 5/7] drm: adv7511: Add has_dsi feature bit to struct adv7511_chip_info

2023-08-13 Thread Biju Das
The ADV7533 and ADV7535 have DSI support. Add a feature bit has_dsi to struct adv7511_chip_info for handling configuration related to DSI. Signed-off-by: Biju Das --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 + drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 20 +++- 2

[PATCH 4/7] drm: adv7511: Add supply_names and num_supplies variables to struct adv7511_chip_info

2023-08-13 Thread Biju Das
The ADV7511 has 5 power supplies compared to 7 that of ADV75{33,35}. Add supply_names and num_supplies variables to struct adv7511_chip_info to handle this difference. Signed-off-by: Biju Das --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 3 +- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c

[PATCH 3/7] drm: adv7511: Add max_lane_freq variable to struct adv7511_chip_info

2023-08-13 Thread Biju Das
The ADV7533 supports a maximum lane clock of 800MHz whereas it is 891MHz for ADV7535. Add max_lane_freq variable to struct adv7511_chip_info to handle this difference. While at it, drop the unused local variable max_lane_freq. Signed-off-by: Biju Das --- drivers/gpu/drm/bridge/adv7511/adv7511

[PATCH 2/7] drm: adv7511: Add max_mode_clock variable to struct adv7511_chip_info

2023-08-13 Thread Biju Das
The ADV7533 supports a maximum pixel clock of 80MHz whereas it is 148.5MHz for ADV7535. Add max_mode_clock variable to struct adv7511_chip_info to handle this difference. Signed-off-by: Biju Das --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 1 + drivers/gpu/drm/bridge/adv7511

[PATCH 1/7] drm: adv7511: Add struct adv7511_chip_info and use i2c_get_match_data()

2023-08-13 Thread Biju Das
ID lookup for retrieving match data with i2c_get_match_data() by adding adv7511_chip_info as device data for both OF and ID tables. Signed-off-by: Biju Das --- drivers/gpu/drm/bridge/adv7511/adv7511.h | 6 +- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 68 +++- driver

[PATCH 0/7] ADV7511 driver enhancements

2023-08-13 Thread Biju Das
://patchwork.kernel.org/project/linux-renesas-soc/list/?series=762260 Biju Das (7): drm: adv7511: Add struct adv7511_chip_info and use i2c_get_match_data() drm: adv7511: Add max_mode_clock variable to struct adv7511_chip_info drm: adv7511: Add max_lane_freq variable to struct adv7511_chip_info drm: adv7511

[PATCH] drm/bridge/analogix/anx78xx: Extend match data support for ID table

2023-08-13 Thread Biju Das
The driver has ID table, but still it uses device_get_match_data() for retrieving match data. Replace device_get_match_data-> i2c_get_match_data() for retrieving OF/ACPI/I2C match data by adding match data for ID table similar to OF table. Signed-off-by: Biju Das --- This patch is only comp

[PATCH] drm: bridge: it66121: Extend match support for OF tables

2023-08-13 Thread Biju Das
The driver has OF match table, still it uses ID lookup table for retrieving match data. Replace ID look up with i2c_get_match_data() for retrieving OF/ACPI/I2C match data by adding similar match data for OF table. While at it, drop unused local varibale id from probe(). Signed-off-by: Biju Das

RE: [PATCH v10 0/4] Add RZ/{G2L, G2LC} and RZ/V2L Display Unit support

2023-08-07 Thread Biju Das
lcdc-drm->rzg2l-du-drm > * Added forward declaration for struct reset_control > > [1] > https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwor > k.kernel.org%2Fproject%2Flinux-renesas-soc%2Fpatch%2F20220312084205.31462- > 2- > biju.das.jz%40bp.renesas.com%

[PATCH v10 4/4] MAINTAINERS: Add maintainer for RZ DU drivers

2023-07-04 Thread Biju Das
Add my self as maintainer for RZ DU drivers. While at it, update the entries for common parts, rcar-du and shmobile. Signed-off-by: Biju Das Reviewed-by: Laurent Pinchart --- v9->v10: * No change. v8->v9: * Added Rb tag from Laurent. * Updated entries for common parts(Makefile and K

[PATCH v10 3/4] drm: renesas: Add RZ/G2L DU Support

2023-07-04 Thread Biju Das
module is connected to VSPD. Add RZ/G2L DU support for RZ/G2L alike SoCs. Signed-off-by: Biju Das --- Ref: https://lore.kernel.org/linux-renesas-soc/os0pr01mb5922717e4ccfe07f3c25fbc986...@os0pr01mb5922.jpnprd01.prod.outlook.com/#t v9->v10: * Dropped ARM64 dependency from Kconfig. * Sor

[PATCH v10 2/4] dt-bindings: display: renesas, rzg2l-du: Document RZ/V2L DU bindings

2023-07-04 Thread Biju Das
Document DU found in RZ/V2L SoC. The DU block is identical to RZ/G2L SoC and therefore use RZ/G2L fallback to avoid any driver changes. Signed-off-by: Biju Das Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart Reviewed-by: Geert Uytterhoeven --- v9->v10: * No change. V8->v9: * Ad

[PATCH v10 1/4] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-07-04 Thread Biju Das
) for Parallel Output This patch documents the DU module found on RZ/G2L LCDC. Signed-off-by: Biju Das Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart --- v9->v10: * Added Rb tag from Laurent * Updated the commit description. * Updated description of the port by dropping the t

[PATCH v10 0/4] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-07-04 Thread Biju Das
d macro DRM_RZG2L_LCDC->DRM_RZG2L_DU * Replaced rzg2l-lcdc-drm->rzg2l-du-drm * Added forward declaration for struct reset_control [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20220312084205.31462-2-biju.das...@bp.renesas.com/ Biju Das (4): dt-bindings: display:

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-20 Thread Biju Das
Hi Laurent, > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Wed, Jun 14, 2023 at 11:30:48AM +0000, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > > API On Wed, Jun 14, 2023 at 08:21

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-19 Thread Biju Das
Hi All, > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > > > Without of_node, devm_clk_get() and friends falls back to registered > > > clkdevs. So you could call clk_register_clkdev() from within the > > > PMIC driver, and can keep on using

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Wed, Jun 14, 2023 at 08:21:38AM +0000, Biju Das wrote: > > Hi Laurent, > > > > Thanks for the feedback. > > > > >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Wed, Jun 14, 2023 at 10:21 AM Biju Das > wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > &g

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Tue, Jun 13, 2023 at 07:31:46PM +0000, Biju Das wrote: > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > > API > >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-14 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Tue, Jun 13, 2023 at 6:11 PM Biju Das > wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Wolfram, > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Wolfram, > > Thanks for the feedback. > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > Hi Wolfram, > > > > Thanks for the feedback. > > > > > Subject: Re:

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Wolfram, Thanks for the feedback. > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Wolfram, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > Hi everyone, > > > > > Perhaps we should first

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Tue, Jun 13, 2023 at 12:45 PM Biju Das > wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Wolfram, > > On Mon, Jun 12, 2023 at 10:43 PM Wolfram Sang wrote: > > > Perhaps we should first think through what an ancillary device > > > really is. My understanding is that

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-13 Thread Biju Das
Hi Wolfram, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi everyone, > > > Perhaps we should first think through what an ancillary device really > > is. My understanding is that it is used to talk to secondary > > addresses of a

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Biju Das
Hi Wolfram, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > > DT-Maintainers suggestion: > > [1] > > raa215300: pmic@12 { > > compatible = "renesas,raa215300"; > > reg = <0x12>, <0x6f>; > > reg-names = "main",

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Mon, Jun 12, 2023 at 09:53:02AM +0000, Biju Das wrote: > > Hi All, > > > > How do we proceed here between [1] and [2]? > > > > DT-Mainta

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-12 Thread Biju Das
uot;renesas,raa215300-isl1208"; reg = <0x6f>; /* Add Optional shared IRQ */ clocks = <>; clock-names = "xin"; renesas,raa215300-pmic = <>; /* Parse the handle to get PMIC version to che

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-08 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Thu, Jun 08, 2023 at 11:00:19AM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > &

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-08 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Thu, Jun 08, 2023 at 06:41:35AM +, Biju Das wrote: > > > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device >

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-08 Thread Biju Das
Hi Wolfram, > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > > Hi Wolfram, > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > Hi all, > > > > sorry for not being able to chime in earlier. > > > > > In Biju's particular use

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-07 Thread Biju Das
Hi Wolfram, > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi all, > > sorry for not being able to chime in earlier. > > > In Biju's particular use case, the i2c device responds to two > > addresses, which is the standard i2c ancillary use case. However, > >

RE: [PATCH v2] drm: rcar-du: Use dev_err_probe() to record cause of KMS init errors

2023-06-02 Thread Biju Das
Hi Laurent, Thanks for the patch. > Subject: [PATCH v2] drm: rcar-du: Use dev_err_probe() to record cause of > KMS init errors > > The (large) rcar_du_modeset_init() function can fail for many reasons, > two of two involving probe deferral. Use dev_err_probe() in those code > paths to record

RE: [PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support

2023-06-02 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support > > Hi Biju, > > On Thu, Jun 01, 2023 at 12:08:44PM +, Biju Das wrote: > > > Subject: Re: [PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support > > > >

[PATCH v6 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-02 Thread Biju Das
the code between i2c_new_dummy_device and i2c_new_ancillary_device(). Also added helper function __i2c_new_client_device() to pass parent dev parameter, so that the ancillary device can assign its parent during creation. Suggested-by: Geert Uytterhoeven Signed-off-by: Biju Das Reviewed-by: Hans

RE: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-06-02 Thread Biju Das
Hi Laurent, > -Original Message- > From: Laurent Pinchart > Sent: Friday, June 2, 2023 12:15 PM > To: Biju Das > Cc: David Airlie ; Daniel Vetter ; > Philipp Zabel ; Geert Uytterhoeven > ; Kieran Bingham > ; dri- > de...@lists.freedesktop.org; linux-renesas-..

RE: [PATCH 3/3] drm: Fix references to drm_plane_helper_check_state()

2023-06-02 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: [PATCH 3/3] drm: Fix references to > drm_plane_helper_check_state() > > As of commit a01cb8ba3f628293 ("drm: Move drm_plane_helper_check_state() > into drm_atomic_helper.c"), drm_plane_helper_check_state() no longer > exists, but is part of

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-06-02 Thread Biju Das
Hi All, > Subject: RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Laurent, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > API > > > > On Wed, May 31, 2023 at 12:53:18PM

RE: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-06-01 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display > Unit support > > On Mon, May 29, 2023 at 02:22:06PM +0000, Biju Das wrote: > > HI Laurent, > > > > Thanks for the feedback. > > > > > S

RE: [PATCH v9 RESEND 4/5] drm: Add RZ/G2L DU Support

2023-06-01 Thread Biju Das
and make review > easier. I agree v10 will simplify the code as I have do clean-ups based on your review commnet. > > On Tue, May 02, 2023 at 11:09:11AM +0100, Biju Das wrote: > > The LCD controller is composed of Frame Compression Processor (FCPVD), > > Video

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Wed, May 31, 2023 at 2:53 PM Biju Das > wrote: > > > > * This function creates and returns an I2C ancillary client whose > > &g

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > On Wed, May 31, 2023 at 12:53:18PM +0000, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > > > API On Wed,

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Wed, May 31, 2023 at 09:34:06AM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > &

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-31 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Mon, May 29, 2023 at 09:00:43AM +, Biju Das wrote: > > > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device > &

RE: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-05-29 Thread Biju Das
HI Laurent, Thanks for the feedback. > Subject: Re: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display > Unit support > > Hi Biju, > > On Thu, May 25, 2023 at 02:30:10PM +, Biju Das wrote: > > Hi DRM maintainers, > > > > Gentle ping. > > S

RE: [PATCH v9 RESEND 2/5] dt-bindings: display: Document Renesas RZ/G2L DU bindings

2023-05-29 Thread Biju Das
Hi Laurent, > Subject: Re: [PATCH v9 RESEND 2/5] dt-bindings: display: Document > Renesas RZ/G2L DU bindings > > Hi Biju, > > Thank you for the patch. > > On Tue, May 02, 2023 at 11:09:09AM +0100, Biju Das wrote: > > The RZ/G2L LCD controller is composed

RE: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-29 Thread Biju Das
Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > Thank you for the patch. > > On Mon, May 22, 2023 at 11:18:39AM +0100, Biju Das wrote: > > Renesas PMIC RAA215300 exposes tw

RE: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-05-25 Thread Biju Das
> -Original Message- > From: Biju Das > Sent: Monday, May 15, 2023 8:58 AM > To: David Airlie ; Daniel Vetter ; > Philipp Zabel ; Geert Uytterhoeven > ; Laurent Pinchart > ; Kieran Bingham > > Cc: dri-devel@lists.freedesktop.org; linux-renesas-...@vger.ke

[PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-22 Thread Biju Das
i2c_new_dummy_device and i2c_new_ancillary_device(). Also added helper function __i2c_new_client_device() to pass parent dev parameter, so that the ancillary device can assign its parent during creation. Suggested-by: Geert Uytterhoeven Signed-off-by: Biju Das --- v4->v5: * Replaced parameter

RE: [PATCH v4 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-19 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v4 01/11] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Thu, May 18, 2023 at 1:37 PM Biju Das > wrote: > > Renesas PMIC RAA215300 exposes two separate i2c devices, one for the > > main dev

[PATCH v4 01/11] i2c: Enhance i2c_new_ancillary_device API

2023-05-18 Thread Biju Das
i2c_new_dummy_device and i2c_new_ancillary_device(). Also added helper function __i2c_new_client_device() to pass parent dev parameter, so that the ancillary device can assign its parent during creation. Suggested-by: Geert Uytterhoeven Signed-off-by: Biju Das --- v3->v4: * Dropped Rb tag from Ge

RE: [PATCH v3 1/5] i2c: Enhance i2c_new_ancillary_device API

2023-05-16 Thread Biju Das
Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v3 1/5] i2c: Enhance i2c_new_ancillary_device API > > Hi Biju, > > On Sat, May 13, 2023 at 6:52 PM Biju Das > wrote: > > Renesas PMIC RAA215300 exposes two separate i2c devices, one for the > > main dev

RE: [PATCH v9 RESEND 0/5] Add RZ/{G2L,G2LC} and RZ/V2L Display Unit support

2023-05-15 Thread Biju Das
cdc' replaced with 'rzg2l_du' > * Updated commit description for bindings > * Removed LCDC references from bindings > * Changed clock name from du.0->aclk from bindings > * Changed reset name from du.0->du from bindings > * Replaced crtc_helper_funcs->rcar_crtc_helper_fun

[PATCH v3 1/5] i2c: Enhance i2c_new_ancillary_device API

2023-05-13 Thread Biju Das
Renesas PMIC RAA215300 exposes two separate i2c devices, one for the main device and another for rtc device. Enhance i2c_new_ancillary_device() to instantiate a real device. (eg: Instantiate rtc device from PMIC driver) Signed-off-by: Biju Das --- v3: * New patch Ref: https

<    1   2   3   4   5   6   >