Re: [PATCH v3 04/12] drm/mediatek: add clock factor for different IC

Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > different IC has different clock designed in HDMI, the factor for > calculate clock should be different. Usinng the data in of_node > to find this factor. > Reviewed-by: CK Hu > S

Re: [PATCH v3 02/12] drm/mediatek: move hardware register to node data

Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > The address of register DPI_H_FRE_CON is different in different IC. > Using of_node data to find this address. > Reviewed-by: CK Hu > Signed-off-by: chunhui dai > --- >

Re: [PATCH v3 01/12] drm/mediatek: add refcount for DPI power on/off

Hi, Bibby: On Fri, 2018-09-21 at 11:28 +0800, Bibby Hsieh wrote: > From: chunhui dai > > After the kernel 4.4, the DRM disable flow was changed, if DPI was > disableed before CRTC, it will cause warning message as following: > > [ cut here ] > WARNING: CPU: 0 PID: 1339

Re: [PATCH v1 1/1] drm/mediatek: add function to match the connector and crtc

Hi, Stu: On Wed, 2018-09-12 at 14:02 +0800, Stu Hsieh wrote: > This patch add function to match the connector and crtc > > Because the connector set the possible_crtc to match the crtc. > > This function would search the connector in every ddp path and > return the corresponding value for

Re: [PATCH v2 07/13] drm/mediatek: separae hdmi phy to different file

Hi, Bibby: On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > Different IC has different phy setting of HDMI. > This patch separaes the phy hardware relate part for mt8173. > > Signed-off-by: chunhui dai > --- > drivers/gpu/drm/mediatek/Makefile | 15

Re: [PATCH v2 10/13] drm/mediatek: add hdmi driver for MT2701 and MT7623

Hi, Bibby: On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > This patch adds hdmi dirver suppot for both MT2701 and MT7623. > And also support other (existing or future) chips that use > the same binding and driver. > > Signed-off-by: chunhui dai > --- >

Re: [PATCH v2 07/13] drm/mediatek: separae hdmi phy to different file

Hi, Bibby: On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > Different IC has different phy setting of HDMI. > This patch separaes the phy hardware relate part for mt8173. I guess 'separae' is 'separate'. Am I right? Regards, CK > > Signed-off-by: chunhui dai >

Re: [PATCH v2 13/13] drm/mediatek: config component output by device node port

Hi, Bibby: On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > We can select output component by decive node port. > Main path default output component is DSI. > External path default output component is DPI. > > Signed-off-by: Bibby Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c |

Re: [PATCH v2 11/13] drm/mediatek: implement connection from BLS to DPI0

Hi, Bibby: On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > Modify display driver to support connection from BLS to DPI. > > Signed-off-by: Bibby Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 19 ++- > 1 file changed, 1

Re: [PATCH v2 08/13] drm/mediatek: register hdmi codec more earlier

Hi, Bibby: On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > sometimes hdmi reprobe due to encoder probe late, > but audio dai probe earlier than hdmi. it would make > audio dai cannot find the hdmi codec. we need to > register hdmi codec earlier, and the base name

Re: [PATCH v2 09/13] drm/mediatek: add support for SPDIF audio in HDMI

Hi, Bibby: On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > add support for SPDIF audio in HDMI > > Signed-off-by: chunhui dai Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 5 + > 1 file changed, 5 inser

Re: [PATCH v2 06/13] drm/mediatek: add dpi driver for mt2701 and mt7623

Hi, Bibby: One inline comment. On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > This patch adds dpi dirver suppot for both mt2701 and mt7623. > And also support other (existing or future) chips that use > the same binding and driver. > > Signed-off-by: chunhui dai

Re: [PATCH v2 04/13] drm/mediatek: add clock factor for different IC

Hi, Bibby: One inline comment. On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > different IC has different clock designed in HDMI, the factor for > calculate clock should be different. Usinng the data in of_node > to find this factor. > > Signed-off-by: chunhui

Re: [PATCH v2 05/13] drm/mediatek: dpi use new API for finding bridge

Hi, Bibby: On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > Using new API for finding bridge. > This patch looks good, but your description is so simple that we don't know why you want to do this. In [1], Rob wants to clean up OF graph API, so in [2], mtk_dsi.c

Re: [PATCH v2 03/13] drm/mediatek: adjust EDGE to match clock and data

Hi, Bibby: On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > The default timing of DPI data and clock is not match. > We could adjust this bit to make them match. > > Signed-off-by: chunhui dai Reviewed-by: CK Hu > --- > drivers/gp

Re: [PATCH v2 02/13] drm/mediatek: move hardware register to node data

Hi, Bibby: One more inline comment. On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > The address of register DPI_H_FRE_CON is different in different IC. > Using of_node data to find this address. > > Signed-off-by: chunhui dai > --- >

Re: [PATCH v2 02/13] drm/mediatek: move hardware register to node data

Hi, Bibby: One inline comment. On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh wrote: > From: chunhui dai > > The address of register DPI_H_FRE_CON is different in different IC. > Using of_node data to find this address. > > Signed-off-by: chunhui dai > --- >

Re: [PATCH v2 01/13] drm/mediatek: add refcount for DPI power on/off

Hi, Bibby: This looks reasonable, but why MT8173 doesn't need this patch? So describe more about why MT7623 need this patch. If this is caused by latest DRM core flow change, I think we should treat this patch independent with MT7623. Regards, CK On Wed, 2018-09-05 at 16:31 +0800, Bibby Hsieh

[GIT PULL] mediatek drm fixes for 4.19

Hi, Dave: Here are some fixes for mediatek drm driver. Regards, CK The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the git repository at: https://github.com/ckhu-mediatek/linux.git-tags.git

Re: [PATCH v4 00/14] Add RDMA memory mode support for mediatek SOC MT2712

Hi, Stu: For the series, applied to mediatek-drm-next-4.19 [1], but I modified 'drm/mediatek: add RGB color format support for RDMA' and 'drm/mediatek: add YUYV/UYVY color format support for RDMA' because I would like to place related register definition together. [1]

Re: [PATCH v4 12/14] drm/mediatek: use layer_nr function to get layer number to init plane

hird ddp, it use RDMA to read memory. > RDMA can read 1 memory address, so it just init one plane. > > For compatibility, this patch use mtk_ddp_comp_layer_nr function > to get layer number from their HW component in ddp for plane init. > > Signed-off-by: Stu Hsieh Reviewed-by: CK

Re: [PATCH v4 08/14] drm/mediatek: add YUYV/UYVY color format support for RDMA

Hi, Stu: On Thu, 2018-08-09 at 10:15 +0800, Stu Hsieh wrote: > This patch add YUYV/UYVY color format support for RDMA > and transform matrix for YUYV/UYVY. > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 20

Re: [PATCH v4 07/14] drm/mediatek: add the comment about color format setting for OVL

Hi, Stu: On Thu, 2018-08-09 at 10:15 +0800, Stu Hsieh wrote: > This patch add the comment about color format setting for OVL > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 + > 1 file changed, 5 insertions(+) > &

Re: [PATCH v4 06/14] drm/mediatek: add RGB color format support for RDMA

Hi, Stu: On Thu, 2018-08-09 at 10:15 +0800, Stu Hsieh wrote: > This patch add RGB color format support for RDMA, > including RGB565, RGB888, RGBA and ARGB. > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mt

Re: [PATCH v3 11/13] drm/mediatek: use layer_nr function to get layer number to init plane

Hi, Stu: On Mon, 2018-08-06 at 19:58 +0800, Stu Hsieh wrote: > This patch use layer_nr function to get layer number to init plane > > When plane init in crtc create, > it use the number of OVL layer to init plane. > That's OVL can read 4 memory address. > > For mt2712 third ddp, it use RDMA to

Re: [PATCH v3 10/13] drm/mediatek: add callback function to return RDMA layer number

r than callback function. OVL does not register callback function to crtc and crtc call OVL function directly. The modification is good to me, so Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gp

Re: [PATCH v3 09/13] drm/mediatek: add callback function to return OVL layer number

unction pointer rather than callback function. OVL does not register callback function to crtc and crtc call OVL function directly. The modification is good to me, so Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 6 ++ > 1 file changed, 6 insertions(+) > >

Re: [PATCH v3 08/13] drm/mediatek: add function to get layer number for component

Hi, Stu: On Mon, 2018-08-06 at 19:58 +0800, Stu Hsieh wrote: > This patch add function to get layer number for component > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 9 + > 1 file changed, 9 insertions(

Re: [PATCH v3 07/13] drm/mediatek: add YUYV/UYVY color format support for RDMA

Hi, Stu: On Mon, 2018-08-06 at 19:58 +0800, Stu Hsieh wrote: > This patch add YUYV/UYVY color format support for RDMA > and transform matrix for YUYV/UYVY. > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 15 +++ > 1 file changed, 15 insertions(+) >

Re: [PATCH v3 06/13] drm/mediatek: add RGB color format support for RDMA

Hi, Stu: On Mon, 2018-08-06 at 19:58 +0800, Stu Hsieh wrote: > This patch add RGB color format support for RDMA, > including RGB565, RGB888, RGBA and ARGB. > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 41 > > 1 file

Re: [PATCH v3 05/13] drm/mediatek: add memory mode and layer_config for RDMA

> > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 21 + > 1 file changed, 21 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c > b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c &g

Re: [PATCH v1 06/15] drm/mediatek: add memory mode for RDMA

Hi, Stu: On Thu, 2018-08-02 at 19:36 +0800, Stu Hsieh wrote: > Hi, CK: > > On Wed, 2018-07-25 at 10:40 +0800, CK Hu wrote: > > Hi, Stu: > > > > On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > > > This patch add memory mode for RDMA > > >

Re: [PATCH v2 15/15] drm/mediatek: fix connection from RDMA2 to DSI1

Hi, Stu: On Fri, 2018-08-03 at 11:11 +0800, Stu Hsieh wrote: > This patch fix connection from RDMA2 to DSI1 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH v2 14/15] drm/mediatek: update some variable name from ovl to comp

Hi, Stu: On Fri, 2018-08-03 at 11:11 +0800, Stu Hsieh wrote: > This patch update some variable name from ovl to comp > > Because RDMA would be first HW in ddp, the naming ovl > should be change to comp. > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- >

Re: [PATCH v2 13/15] drm/mediatek: use layer_nr function to get layer number to init plane

Hi, Stu: On Fri, 2018-08-03 at 11:11 +0800, Stu Hsieh wrote: > This patch use layer_nr function to get layer number to init plane > > When plane init in crtc create, > it use the number of OVL layer to init plane. > That's OVL can read 4 memory address. > > For mt2712 third ddp, it use RDMA to

Re: [PATCH v2 12/15] drm/mediatek: add callback function to return RDMA layer number

Hi, Stu: On Fri, 2018-08-03 at 11:11 +0800, Stu Hsieh wrote: > This patch add callback function to return RDMA layer number > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [PATCH v2 11/15] drm/mediatek: add callback function to return OVL layer number

Hi, Stu: On Fri, 2018-08-03 at 11:11 +0800, Stu Hsieh wrote: > This patch add callback function to return OVL layer number > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [PATCH v2 10/15] drm/mediatek: add function to get layer number for component

Hi, Stu: On Fri, 2018-08-03 at 11:11 +0800, Stu Hsieh wrote: > This patch add function to get layer number for component > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 7 +++ > 1 file changed, 7 insertions(

Re: [PATCH v2 04/15] drm/mediatek: add connection from RDMA2 to DSI0

Hi, Stu: On Fri, 2018-08-03 at 11:10 +0800, Stu Hsieh wrote: > This patch add connection from RDMA2 to DSI0 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

Re: [PATCH v2 03/15] drm/mediatek: add connection from RDMA1 to DSI0

Hi, Stu: On Fri, 2018-08-03 at 11:10 +0800, Stu Hsieh wrote: > This patch add connection from RDMA1 to DSI0 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

Re: [PATCH v2 02/15] drm/mediatek: add connection from RDMA0 to DSI1

Hi, Stu: On Fri, 2018-08-03 at 11:10 +0800, Stu Hsieh wrote: > This patch add connection from RDMA0 to DSI1 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

Re: [PATCH v2 01/15] drm/mediatek: add connection from RDMA0 to DPI1

Hi, Stu: On Fri, 2018-08-03 at 11:10 +0800, Stu Hsieh wrote: > This patch add connection from RDMA0 to DPI1 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

Re: [PATCH] drm/mediatek: Replace drm_dev_unref with drm_dev_put

Hi, Thomas: On Tue, 2018-07-17 at 12:21 +0200, Philipp Zabel wrote: > On Tue, 2018-07-17 at 10:35 +0200, Thomas Zimmermann wrote: > > This patch unifies the naming of DRM functions for reference counting > > of struct drm_device. The resulting code is more aligned with the rest > > of the Linux

Re: [SPAM]Re: [PATCH] drm/mediatek: Convert drm_atomic_helper_suspend/resume()

Hi, Souptick: On Mon, 2018-07-30 at 10:21 +0530, Souptick Joarder wrote: > On Mon, Jul 30, 2018 at 9:23 AM, CK Hu wrote: > > Hi, Souptick: > > > > On Sat, 2018-07-28 at 19:08 +0530, Souptick Joarder wrote: > >> convert drm_atomic_

Re: [PATCH] drm/mediatek: Convert drm_atomic_helper_suspend/resume()

Hi, Souptick: On Sat, 2018-07-28 at 19:08 +0530, Souptick Joarder wrote: > convert drm_atomic_helper_suspend/resume() to use > drm_mode_config_helper_suspend/resume(). > Reviewed-by: CK Hu > Signed-off-by: Souptick Joarder > Signed-off-by: Ajit Negi > --- > dri

Re: [PATCH v1 11/15] drm/mediatek: add dummy buffer for RDMA memory mode

Hi, Stu: On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > This patch add dummy buffer for RDMA memory mode > > When display power on, the drm frame work would modeset and > set up the display HW. > > In this time, the RDMA would start wroking and read the data from memory. > But, user

Re: [PATCH v1 14/15] drm/mediatek: fixed the error value for add DSI1 in mutex

Hi, Stu: On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > This patch fixed the error value for add DSI1 in mutex > English is not my mother language, but should it be 'fix' rather than 'fixed'? Regards, CK > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 2

Re: [PATCH v1 12/15] drm/mediatek: add layer number condition for RDMA to control plane

Hi, Stu: On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > This patch add layer number condition for RDMA to control plane > > When plane init in crtc create, > it use the number of OVL layer to init plane. > That's OVL can read 4 memory address. > > For mt2712 third ddp, it use RDMA to

Re: [PATCH v1 06/15] drm/mediatek: add memory mode for RDMA

Hi, Stu: On Tue, 2018-07-24 at 16:17 +0800, Stu Hsieh wrote: > This patch add memory mode for RDMA > > If use RDMA to read data from memory, it should set memory mode to RDMA > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 16 +++- > 1 file changed,

Re: [PATCH v1 00/15] Add RDMA memory mode support for mediatek SOC MT2712

Hi, Stu: It looks like the series is a bug fix of [1]. In [1], you create third crtc but it does not work unless apply this series. So for all the patches in this series, you should refer to [2] to add 'Fixes:' and 'Cc:' in commit message. [1]

[GIT PULL] mediatek drm next for 4.19

-tags.git mediatek-drm-next-4.19 for you to fetch changes up to 57c7f58111806faa0165b88155bff15679024122: drm/mtk: mtk_drm_fb -> drm_framebuffer (2018-06-28 00:27:36 +0800) ---- CK Hu (1): drm/mediatek: Split line to not over

Re: [PATCH v2 1/3] drm/mtk: Remove impossible internal error

int > testing for it. > > v2: Remove the error entirely. (Sean, CK, Thierry) > > Signed-off-by: Daniel Stone > Cc: Sean Paul > Cc: Thierry Reding > Cc: CK Hu > Cc: Philipp Zabel > --- > drivers/gpu/drm/mediatek/mtk_drm_plane.c | 5 - > 1 file changed, 5 del

Re: [PATCH v7 00/29] Add support for mediatek SOC MT2712

Hi, Stu: On Wed, 2018-06-20 at 16:19 +0800, Stu Hsieh wrote: > This patch add support for the Mediatek MT2712 DISP subsystem. > MT2712 is base on MT8173, there are some difference as following: > MT2712 support three disp output(two ovl and one rdma) > For the series, applied to

Re: [PATCH v7 12/29] drm/mediatek: Update the definition of connection from RDMA1 to DPI0

SOUT is better. > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c > b/drivers/gpu/drm/medi

Re: [PATCH v6 24/29] drm/mediatek: add connection from RDMA2 to DSI3

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DSI3 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/

Re: [PATCH v6 23/29] drm/mediatek: add connection from RDMA2 to DSI2

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DSI2 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/

Re: [PATCH v6 22/29] drm/mediatek: add connection from RDMA2 to DSI1

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DSI1 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/

Re: [PATCH v6 21/29] drm/mediatek: add connection from RDMA2 to DPI1

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DPI1 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/

Re: [PATCH v6 20/29] drm/mediatek: add connection from RDMA2 to DPI0

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DPI0 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/

Re: [PATCH v6 19/29] drm/mediatek: add connection from RDMA1 to DSI3

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA1 to DSI3 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/

Re: [PATCH v6 18/29] drm/mediatek: add connection from RDMA1 to DSI2

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA1 to DSI2 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/

Re: [PATCH v6 17/29] drm/mediatek: add connection from RDMA1 to DSI1

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA1 to DSI1 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/

Re: [PATCH v6 16/29] drm/mediatek: add connection from RDMA1 to DPI1

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA1 to DPI1 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/

Re: [PATCH v6 15/29] drm/mediatek: add connection from RDMA0 to DSI3

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA0 to DSI3 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

Re: [PATCH v6 14/29] drm/mediatek: add connection from RDMA0 to DSI2

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA0 to DSI2 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

Re: [PATCH v6 13/29] drm/mediatek: add connection from RDMA0 to DPI0

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA0 to DPI0 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/

Re: [PATCH v6 12/29] drm/mediatek: Update the definition of connection from RDMA1 to DPI0

Hi, Stu: On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch update the definition of connection from RDMA1 to DPI0. > Change the term MOUT to SOUT. > I would like commit message describe 'why' of this patch. Both you and me know 'why' of this patch because we have discuss

Re: [PATCH v6 10/29] drm/mediatek: add the DSI1 for component init condition

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the DSI1 for component init condition > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/

Re: [PATCH v6 07/29] drm/mediatek: add component DPI1

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the component DPI1 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + > 2 files

Re: [PATCH v6 09/29] drm/mediatek: add component DSI3

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the component DSI3 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + > 2 files

Re: [PATCH v6 08/29] drm/mediatek: add component DSI2

On Tue, 2018-06-19 at 15:34 +0800, Stu Hsieh wrote: > This patch add the component DSI2 > Reviewed-by: CK Hu > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 ++ > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + > 2 files

Re: [PATCH 19/28] drm/mediatek: add connection from RDMA2 to DPI1

Hi, Stu: On Wed, 2018-06-13 at 16:58 +0800, Stu Hsieh wrote: > Hi, CK: > > On Wed, 2018-06-13 at 16:14 +0800, CK Hu wrote: > > Hi, Stu: > > > > On Wed, 2018-06-13 at 16:01 +0800, Stu Hsieh wrote: > > > Hi, CK: > > > > > > > > >

Re: [PATCH 14/28] drm/mediatek: add connection from RDMA1 to DPI1

Hi, Stu: On Wed, 2018-06-13 at 15:56 +0800, Stu Hsieh wrote: > Hi, CK: > > On Wed, 2018-06-13 at 14:13 +0800, CK Hu wrote: > > Hi, Stu: > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > This patch add the connection from RDMA1 to DPI1 &

Re: [PATCH 19/28] drm/mediatek: add connection from RDMA2 to DPI1

Hi, Stu: On Wed, 2018-06-13 at 16:01 +0800, Stu Hsieh wrote: > Hi, CK: > > > On Wed, 2018-06-13 at 15:13 +0800, CK Hu wrote: > > Hi, Stu: > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > > This patch add the connection from RDMA2 to DPI

Re: [PATCH 13/28] drm/mediatek: add connection from RDMA0 to DSI3

Hi, Stu: On Wed, 2018-06-13 at 15:46 +0800, Stu Hsieh wrote: > Hi, CK: > > On Wed, 2018-06-13 at 13:45 +0800, CK Hu wrote: > > Hi, Stu: > > > > Two inline comment. > > > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > >

Re: [PATCH 28/28] drm/mediatek: Add support for mediatek SOC MT2712

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add support for the Mediatek MT2712 DISP subsystem. > There are two OVL engine and three disp output in MT2712. > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/

Re: [PATCH 27/28] drm/mediatek: add third ddp path

On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch create third crtc by third ddp path > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 5 + > dri

Re: [PATCH 26/28] drm/mediatek: add DPI1/DSI1/DSI2/DSI3 in comp_init

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add components DPI1/DSI1/DSI2/DSI3 in comp_init. > Because the some parameter for these components initialized > in their driver. > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 4

Re: [PATCH 23/28] drm/mediatek: add DPI1 support for mutex

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the DPI1 support for mutex > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/

Re: [PATCH 25/28] drm/mediatek: add DSI3 support for mutex

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the DSI3 support for mutex > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/

Re: [PATCH 24/28] drm/mediatek: add DSI2 support for mutex

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the DSI2 support for mutex > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/

Re: [PATCH 22/28] drm/mediatek: add connection from RDMA2 to DSI3

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DSI3 > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c

Re: [PATCH 21/28] drm/mediatek: add connection from RDMA2 to DSI2

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DSI2 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff

Re: [PATCH 20/28] drm/mediatek: add connection from RDMA2 to DSI1

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DSI1 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff

Re: [PATCH 19/28] drm/mediatek: add connection from RDMA2 to DPI1

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DPI1 > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c

Re: [PATCH 18/28] drm/mediatek: add connection from RDMA2 to DPI0

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA2 to DPI0 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 9 + > 1 file changed, 9 insertions(+) > > diff

Re: [PATCH 17/28] drm/mediatek: add connection from RDMA1 to DSI3

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA1 to DSI3 > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c

Re: [PATCH 16/28] drm/mediatek: add connection from RDMA1 to DSI2

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA1 to DSI2 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 9 + > 1 file changed, 9 insertions(+) > > diff

Re: [PATCH 15/28] drm/mediatek: add connection from RDMA1 to DSI1

Hi, Stu: On Wed, 2018-06-13 at 14:44 +0800, CK Hu wrote: > Hi, Stu: > > On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > > This patch add the connection from RDMA1 to DSI1 > > > > Signed-off-by: Stu Hsieh > > --- > > drivers/gpu/drm/mediatek/

Re: [PATCH 15/28] drm/mediatek: add connection from RDMA1 to DSI1

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA1 to DSI1 > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c

Re: [PATCH 14/28] drm/mediatek: add connection from RDMA1 to DPI1

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA1 to DPI1 > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp.c

Re: [PATCH 13/28] drm/mediatek: add connection from RDMA0 to DSI3

Hi, Stu: Two inline comment. On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA0 to DSI3 > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- > 2 files

Re: [PATCH 12/28] drm/mediatek: add connection from RDMA0 to DSI2

On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA0 to DSI2 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/

Re: [PATCH 11/28] drm/mediatek: add connection from RDMA0 to DPI0

On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the connection from RDMA0 to DPI0 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/

Re: [PATCH 09/28] drm/mediatek: add component DSI3

Hi, Stu: On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the component DSI3 > > Signed-off-by: Stu Hsieh > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git

Re: [PATCH 08/28] drm/mediatek: add component DSI2

On Mon, 2018-06-11 at 11:26 +0800, Stu Hsieh wrote: > This patch add the component DSI2 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + > 2 files changed, 2 in

Re: [PATCH 07/28] drm/mediatek: add component DPI1

On Mon, 2018-06-11 at 11:25 +0800, Stu Hsieh wrote: > This patch add the component DPI1 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + > 2 files changed, 2 in

Re: [PATCH 04/28] drm/mediatek: add ddp component OD1

On Mon, 2018-06-11 at 11:25 +0800, Stu Hsieh wrote: > This patch add the component OD1 and > rename the OD to OD0 > > Signed-off-by: Stu Hsieh Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_ddp.c | 4 ++-- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c |

Re: [PATCH v1 6/7] drm/mediatek: add a error return value when clock driver has been prepared

Hi, Bibby: On Mon, 2018-05-14 at 15:52 +0800, Bibby Hsieh wrote: > DRM driver get the comp->clk by of_clk_get(), we only > assign NULL to comp->clk when error happened, but do > not return the error number. > Reviewed-by: CK Hu <ck...@mediatek.com> > Signed-of

Re: [PATCH v1 3/7] drm/mediatek: add dpi driver for mt2701 and mt7623

Hi, Bibby: On Mon, 2018-05-14 at 15:52 +0800, Bibby Hsieh wrote: > From: chunhui dai > > This patch adds dpi driver suppot for both mt2701 and mt7623. > And also support other (existing or future) chips that use > the same binding and driver. > > Signed-off-by:

<    1   2   3   4   5   6   7   8   >