RE: [PATCH] drm/scheduler: Partially revert "drm/scheduler: track GPU active time per entity"

2023-08-16 Thread Chen, Guchun
[Public] Hi Xinhui, That patch has been reverted on Linux mainline. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/scheduler/sched_main.c?h=v6.5-rc6=baad10973fdb442912af676de3348e80bd8fe602 Regards, Guchun > -Original Message- > From: amd-gfx

RE: [PATCH] drm/ttm: check null pointer before accessing when swapping

2023-07-27 Thread Chen, Guchun
[Public] > -Original Message- > From: Koenig, Christian > Sent: Thursday, July 27, 2023 3:28 PM > To: Alex Deucher ; Chen, Guchun > > Cc: Deucher, Alexander ; airl...@gmail.com; > dan...@ffwll.ch; dri-devel@lists.freedesktop.org; Mikhail Gavrilov > > Subject:

RE: [PATCH] drm/amdgpu: display/Kconfig: replace leading spaces with tab

2023-06-07 Thread Chen, Guchun
[Public] It's https://gitlab.freedesktop.org/agd5f/linux/-/tree/amd-staging-drm-next?ref_type=heads. Latest patches including yours's will be pushed to this branch after a while. Regards, Guchun > -Original Message- > From: amd-gfx On Behalf Of Sui > Jingfeng > Sent: Wednesday, June

RE: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields

2023-05-31 Thread Chen, Guchun
[Public] > -Original Message- > From: amd-gfx On Behalf Of Ma > Jun > Sent: Wednesday, May 31, 2023 1:31 PM > To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Koenig, > Christian > Cc: Ma, Jun > Subject: [PATCH v2] drm/ttm: Remove redundant code in ttm_tt_init_fields

RE: [PATCH 2/3] drm/amdgpu: Set GTT size equal to TTM mem limit

2023-04-25 Thread Chen, Guchun
Looks you can drop macro 'AMDGPU_DEFAULT_GTT_SIZE_MB' as well. Regards, Guchun > -Original Message- > From: amd-gfx On Behalf Of > Mukul Joshi > Sent: Wednesday, April 26, 2023 9:53 AM > To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org > Cc: Joshi, Mukul ; Kuehling,

RE: [PATCH] drm/amdgpu: add a missing lock for AMDGPU_SCHED

2023-04-25 Thread Chen, Guchun
>From coding style's perspective, this lock/unlock handling should be put into >amdgpu_ctx_priority_override. Regards, Guchun > -Original Message- > From: amd-gfx On Behalf Of Chia- > I Wu > Sent: Wednesday, April 26, 2023 8:48 AM > To: dri-devel@lists.freedesktop.org > Cc: Pan, Xinhui

RE: BUG: KASAN: null-ptr-deref in drm_sched_job_cleanup+0x96/0x290 [gpu_sched]

2023-04-25 Thread Chen, Guchun
After reviewing this whole history, maybe attached patch is able to fix your problem. Can you have a try please? Regards, Guchun > -Original Message- > From: amd-gfx On Behalf Of > Mikhail Gavrilov > Sent: Tuesday, April 25, 2023 9:20 PM > To: Koenig, Christian > Cc: Daniel Vetter ;

RE: [PATCH v3 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-10 Thread Chen, Guchun
> -Original Message- > From: Jani Nikula > Sent: Friday, March 10, 2023 8:05 PM > To: Chen, Guchun ; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Deucher, > Alexander ; Zhang, Hawking > ; dmitry.barysh...@linaro.org; > spassw...@web.de;

RE: [PATCH] drm/amdgpu: resove reboot exception for si oland

2023-03-10 Thread Chen, Guchun
> -Original Message- > From: amd-gfx On Behalf Of > Zhenneng Li > Sent: Friday, March 10, 2023 3:40 PM > To: Deucher, Alexander > Cc: David Airlie ; Pan, Xinhui ; > linux-ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; Zhenneng Li > ; amd-...@lists.freedesktop.org; Daniel

RE: [PATCH 2/2] drm/probe_helper: warning on poll_enabled for issue catching

2023-03-09 Thread Chen, Guchun
> -Original Message- > From: Dmitry Baryshkov > Sent: Thursday, March 9, 2023 4:49 PM > To: Chen, Guchun ; amd- > g...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Deucher, > Alexander ; Zhang, Hawking > ; spassw...@web.de; m...@fireburn.co.uk > Subj

RE: [PATCH 1/2] drm/amdgpu: add flag to enable/disable poll in suspend/resume path

2023-03-08 Thread Chen, Guchun
Relying on dc_enabled will be more simple, thanks for your suggestion. I will send v2 to address this. Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Thursday, March 9, 2023 12:29 AM To: Chen, Guchun Cc: amd-...@lists.freedesktop.org; dri-devel

RE: [PATCH v2] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-02-01 Thread Chen, Guchun
-...@igalia.com; Guilherme G. Piccoli ; Chen, Guchun ; Tuikov, Luben ; Limonciello, Mario Subject: [PATCH v2] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini Currently amdgpu calls drm_sched_fini() from the fence driver sw fini routine - such function is expected

RE: [PATCH] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-01-31 Thread Chen, Guchun
age- From: Koenig, Christian Sent: Tuesday, January 31, 2023 6:59 PM To: Chen, Guchun ; Alex Deucher ; Guilherme G. Piccoli Cc: amd-...@lists.freedesktop.org; ker...@gpiccoli.net; Pan, Xinhui ; dri-devel@lists.freedesktop.org; Tuikov, Luben ; Limonciello, Mario ; kernel-...@igalia.com; Deuc

RE: [PATCH] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-01-31 Thread Chen, Guchun
Hi Piccoli, Please ignore my request of full dmesg log. I can reproduce the issue and get the same failure callstack by returning early with an error code prior to amdgpu_device_init_schedulers. Regards, Guchun -Original Message- From: Chen, Guchun Sent: Tuesday, January 31, 2023 2

RE: [PATCH] drm/amdgpu/fence: Fix oops due to non-matching drm_sched init/fini

2023-01-30 Thread Chen, Guchun
AM To: Guilherme G. Piccoli Cc: amd-...@lists.freedesktop.org; ker...@gpiccoli.net; Chen, Guchun ; Pan, Xinhui ; dri-devel@lists.freedesktop.org; Tuikov, Luben ; Limonciello, Mario ; kernel-...@igalia.com; Deucher, Alexander ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu/fence: Fix oops due to

RE: [pull] amdgpu, amdkfd drm-fixes-6.1

2022-10-26 Thread Chen, Guchun
Hello Alex, Regarding below patch, I guess we need to pick "8eb402f16d5b drm/amdgpu: Fix uninitialized warning in mmhub_v2_0_get_clockgating()" together, otherwise, build will possibly fail. Is it true? " Lijo Lazar (1): drm/amdgpu: Remove ATC L2 access for MMHUB 2.1.x" Regards,

RE: [PATCH v1] drivers:amdgpu: check the return value of amdgpu_bo_kmap

2022-09-21 Thread Chen, Guchun
-...@lists.freedesktop.org Cc: jiapeng.ch...@linux.alibaba.com; Powell, Darren ; Chen, Guchun ; Limonciello, Mario ; Quan, Evan ; Lazar, Lijo ; dan...@ffwll.ch; airl...@linux.ie; Pan, Xinhui ; Koenig, Christian ; Deucher, Alexander ; Li Zhong Subject: [PATCH v1] drivers:amdgpu: check the return

RE: [PATCH] drm/amdgpu: Fix GTT size reporting in amdgpu_ioctl

2022-07-05 Thread Chen, Guchun
Hi Alex, I think we need to revert this patch on amd-staging-drm-next branch, as its base commit like " drm/amdgpu: remove GTT accounting v2" does not present on 5.16. Instead, the series is part of upcoming 5.18 based amd-staging-drm-next branch. Otherwise, incorrect GTT size reporting

RE: [PATCH -next 1/2 v2] drm/amdgpu: remove unneeded semicolon

2022-01-13 Thread Chen, Guchun
Series is: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Yang Li Sent: Thursday, January 13, 2022 3:12 PM To: airl...@linux.ie; Chen, Guchun Cc: dan...@ffwll.ch; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; amd-...@lists.freedesktop.org; dri-devel

RE: [PATCH -next 1/2] drm/amdgpu: remove unneeded semicolon

2022-01-12 Thread Chen, Guchun
Thanks for your patch, Yang. Can you pls also fix the original indentation problem as well? if (!adev) - return -EINVAL;; + return -EINVAL; Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Yang Li Sent: Thursday, January 13, 2022 9:22 AM To: airl...@linux.ie

RE: 回复: [PATCH] drm/ttm: Put BO in its memory manager's lru list

2022-01-11 Thread Chen, Guchun
- From: Christian König Sent: Tuesday, January 11, 2022 7:27 PM To: Chen, Guchun ; Pan, Xinhui ; Koenig, Christian ; amd-...@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Subject: Re: 回复: [PATCH] drm/ttm: Put BO in its memory manager's lru list IIRC we have completely dropped

RE: 回复: [PATCH] drm/ttm: Put BO in its memory manager's lru list

2022-01-11 Thread Chen, Guchun
[Public] Hi Christian, Looks this patch still missed in 5.16 kernel. Is it intentional? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/ttm/ttm_bo.c?h=v5.16 Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Pan, Xinhui Sent: Tuesday,

RE: [PATCH] drm/ttm: add a WARN_ON in ttm_set_driver_manager when array bounds (v2)

2021-09-12 Thread Chen, Guchun
[Public] Thanks for your suggestion, Robin. Do you agree with this as well, Christian and Xinhui? Regards, Guchun -Original Message- From: Robin Murphy Sent: Saturday, September 11, 2021 2:25 AM To: Chen, Guchun ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org

RE: [PATCH] drm/ttm: add a BUG_ON in ttm_set_driver_manager when array bounds

2021-09-10 Thread Chen, Guchun
From: Koenig, Christian Sent: Friday, September 10, 2021 2:37 PM To: Pan, Xinhui ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Deucher, Alexander ; Chen, Guchun Cc: Shi, Leslie Subject: Re: [PATCH] drm/ttm: add a BUG_ON in ttm_set_driver_manager when array bounds Yeah

RE: [PATCH] drm/display: fix possible null-pointer dereference in dcn10_set_clock()

2021-08-10 Thread Chen, Guchun
[Public] Thanks for your patch. I suggest moving the check of function pointer dc->clk_mgr->funcs->get_clock earlier, and return early if it's NULL, as if it's NULL, it's meaningless to continue the clock setting. if (!dc->clk_mgr || !dc->clk_mgr->funcs->get_clock) return

RE: [PATCH 1/3] drm/amdgpu: create amdgpu_vkms (v2)

2021-07-23 Thread Chen, Guchun
[Public] Look copy right statement is missed in both amdgpu_vkms.c and amdgpu_vkms.h. Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Friday, July 23, 2021 10:32 PM To: Taylor, Ryan Cc: kernel test robot ; Daniel Vetter ; Siqueira, Rodrigo ; amd-gfx

RE: [PATCH -next] drm/amdgpu: Fix missing unlock on error in amdgpu_ras_debugfs_table_read()

2021-07-05 Thread Chen, Guchun
[Public] Thank you for the patch, Yingliang. There is a similar patch sent out last Saturday and under review. Please check it. [PATCH 3/4] drm/amdgpu: unlock on error in amdgpu_ras_debugfs Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Yang Yingliang Sent: Monday,

RE: [pull] amdgpu, radeon, ttm, sched drm-next-5.13

2021-04-07 Thread Chen, Guchun
[AMD Public Use] Hi Felix and Christian, If the regression you are talking about is the NULL pointer problem when running KFD tests, it should fixed by below patch in this series. drm/amdgpu: fix NULL pointer dereference Regards, Guchun -Original Message- From: amd-gfx On Behalf Of

RE: [PATCH][next] drm/amd/display: Fix sizeof arguments in bw_calcs_init()

2021-03-22 Thread Chen, Guchun
[AMD Public Use] Thanks for your patch, Silva. The issue has been fixed by " a5c6007e20e1 drm/amd/display: fix modprobe failure on vega series". Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Gustavo A. R. Silva Sent: Monday, March 22, 2021 8:51 PM To: Lee Jones ;

RE: [PATCH] drm/ttm: Do not add non-system domain BO into swap list

2021-02-23 Thread Chen, Guchun
[AMD Public Use] Acked-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Alex Deucher Sent: Wednesday, February 24, 2021 11:35 AM To: Pan, Xinhui Cc: Deucher, Alexander ; Maling list - DRI developers ; Koenig, Christian ; amd-gfx list Subject: Re:

RE: [PATCH] drm/amd/display: use div_s64() for 64-bit division

2021-01-25 Thread Chen, Guchun
[AMD Public Use] Hi Arnd Bergmann, Thanks for your patch. This link error during compile has been fixed by below commit and been submitted to drm-next branch already. 5da047444e82 drm/amd/display: fix 64-bit division issue on 32-bit OS Regards, Guchun -Original Message- From: amd-gfx

RE: linux-next: Tree for Jan 22 (amdgpu)

2021-01-24 Thread Chen, Guchun
[AMD Public Use] The link error has been fixed by: 5da047444e82 drm/amd/display: fix 64-bit division issue on 32-bit OS Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Randy Dunlap Sent: Saturday, January 23, 2021 2:02 AM To: Stephen Rothwell ; Linux Next Mailing List

RE: [PATCH] drm/amdgpu:Fixed the wrong macro definition in amdgpu_trace.h

2020-12-23 Thread Chen, Guchun
[AMD Public Use] Nice catch and the patch is: Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: amd-gfx On Behalf Of Chenyang Li Sent: Wednesday, December 23, 2020 9:19 AM To: Deucher, Alexander ; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org

RE: [radeon-alex:amd-20.45 2387/2427] drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of function declared with 'warn_unused_result' attribute

2020-12-14 Thread Chen, Guchun
[AMD Public Use] Hi there, I will fix this soon. The issue is reported on amd-20.45 branch, which was branched out ahead of the fix available on mainline. Regards, Guchun -Original Message- From: kernel test robot Sent: Tuesday, December 15, 2020 1:49 PM To: Chen, Guchun Cc: kbuild

RE: [PATCH][next] drm/amdgpu: Fix sizeof() mismatch in bps_bo kmalloc_array creation

2020-11-25 Thread Chen, Guchun
[AMD Public Use] Reviewed-by: Guchun Chen Regards, Guchun -Original Message- From: Colin King Sent: Wednesday, November 25, 2020 10:18 PM To: Deucher, Alexander ; Koenig, Christian ; David Airlie ; Daniel Vetter ; Zhou1, Tao ; Chen, Guchun ; amd-...@lists.freedesktop.org; dri

RE: [radeon-alex:amd-20.45 2387/2417] drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of function declared with 'warn_unused_result' attribute

2020-11-22 Thread Chen, Guchun
[AMD Public Use] +Alex. We have one following patch to fix this. Please check. a069a9eb73f8 drm/amdgpu: fix a warning in amdgpu_ras.c (v2) Regards, Guchun -Original Message- From: kernel test robot Sent: Saturday, November 21, 2020 2:02 PM To: Chen, Guchun Cc: kbuild-...@lists.01