Re: [Spice-devel] [PATCH] drm/qxl: add spice-devel list to MAINTAINERS

On Wed, Nov 21, 2018 at 10:01:29AM +0100, Gerd Hoffmann wrote: > So qxl kernel patches are sent to the spice-devel list for review. > > Signed-off-by: Gerd Hoffmann > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4caac2f6b0..d9945d5

[PATCH 1/3] qxl: No need for NULL check before calling qxl_bo_unref()

qxl_bo_unref() is already performing a NULL check. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_display.c | 4 +--- drivers/gpu/drm/qxl/qxl_draw.c| 3 +-- drivers/gpu/drm/qxl/qxl_kms.c | 6 ++ 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH 3/3] qxl: Make sure qxl_cursor memory is pinned

neric fix. However, doing this quickly exhausts QXL video memory, so more fixing would be needed before this is workable. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_display.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_disp

[PATCH 2/3] qxl: Remove unused qxl_bo_pin arguments

The 'domain' argument to qxl_bo_pin is redundant with 'bo', and 'gpu_addr' is unused, so we can remove both. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_display.c | 4 ++-- drivers/gpu/drm/qxl/qxl_fb.c | 2 +- drivers/gpu/drm/qxl/qxl_object

[PATCH drm/qxl v4 7/7] qxl: Allow resolution which are not multiple of 8

the client in the drm_display_mode structure rather than keeping the rounded version. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 518333c

[PATCH drm/qxl v4 6/7] qxl: Don't notify userspace when monitors config is unchanged

configuration we received is the same one as the current one, and does not notify userspace about it if that's the case. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_display.c | 62 --- 1 file changed, 52 insertions(+), 10 deletions(-) diff --

[PATCH drm/qxl v4 5/7] qxl: Remove qxl_bo_init() return value

It's always returning 0, and it's always ignored. Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- drivers/gpu/drm/qxl/qxl_drv.h | 2 +- drivers/gpu/drm/qxl/qxl_gem.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h

[PATCH drm/qxl v4 4/7] qxl: Call qxl_gem_{init,fini}

qdev->gem.objects was initialized directly in qxl_device_init() rather than going through qxl_gem_init(), and qxl_gem_fini() was never called. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH drm/qxl v4 3/7] qxl: Add missing '\n' to qxl_io_log() call

The message has to be terminated by a newline as it's not going to get added automatically. Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- drivers/gpu/drm/qxl/qxl_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/dr

[PATCH drm/qxl v4 2/7] qxl: Remove unused prototype

qxl_crtc_set_from_monitors_config() is defined in qxl_drv.h but never implemented. Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h

[PATCH drm/qxl v4 1/7] qxl: Mark some internal functions as static

They are not used outside of their respective source file Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- drivers/gpu/drm/qxl/qxl_cmd.c | 2 +- drivers/gpu/drm/qxl/qxl_display.c | 4 ++-- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 3 files changed, 3 insertions(+), 6

[PATCH drm/qxl v4 0/7] qxl: Various fixes

Hey, Here is what should hopefully be the final version of this series, only change since v3 is that I made sure to keep "PATCH" in the subject line, and I added missing Acked-by/Signed-of-by annotations to the logs. Christophe

[Spice-devel] [drm/qxl v3 6/7] qxl: Don't notify userspace when monitors config is unchanged

On Mon, Nov 07, 2016 at 04:08:48AM -0500, Frediano Ziglio wrote: > > @@ -124,9 +157,18 @@ void qxl_display_read_client_monitors_config(struct > > qxl_device *qdev) > > { > > > > struct drm_device *dev = qdev->ddev; > > - while (qxl_display_copy_rom_client_monitors_config(qdev)) { > > + i

[drm/qxl v3 7/7] qxl: Allow resolution which are not multiple of 8

the client in the drm_display_mode structure rather than keeping the rounded version. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 518333c

[drm/qxl v3 6/7] qxl: Don't notify userspace when monitors config is unchanged

configuration we received is the same one as the current one, and does not notify userspace about it if that's the case. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_display.c | 62 --- 1 file changed, 52 insertions(+), 10 deletions(-) diff --

[drm/qxl v3 5/7] qxl: Remove qxl_bo_init() return value

It's always returning 0, and it's always ignored. --- drivers/gpu/drm/qxl/qxl_drv.h | 2 +- drivers/gpu/drm/qxl/qxl_gem.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index 5a4720a..feac7e6 100644 --- a/driver

[drm/qxl v3 4/7] qxl: Call qxl_gem_{init,fini}

qdev->gem.objects was initialized directly in qxl_device_init() rather than going through qxl_gem_init(), and qxl_gem_fini() was never called. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[drm/qxl v3 3/7] qxl: Add missing '\n' to qxl_io_log() call

The message has to be terminated by a newline as it's not going to get added automatically. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c

[drm/qxl v3 2/7] qxl: Remove unused prototype

qxl_crtc_set_from_monitors_config() is defined in qxl_drv.h but never implemented. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index a3c1131..5a4720a

[drm/qxl v3 1/7] qxl: Mark some internal functions as static

They are not used outside of their respective source file Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_cmd.c | 2 +- drivers/gpu/drm/qxl/qxl_display.c | 4 ++-- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers

[drm/qxl v3 0/7] qxl: Various cleanups/fixes

Hey, Same series as v2 except that I removed the use of camel case in patch 6/7. Now it's only using an anonymous enum + int. Christophe

[Spice-devel] [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

On Thu, Nov 03, 2016 at 06:42:38PM +, Emil Velikov wrote: > Hi guys, > > On 2 November 2016 at 16:31, Christophe Fergeau > wrote: > > Hey, > > > > On Mon, Oct 31, 2016 at 08:00:09AM -0400, Frediano Ziglio wrote: > >> > diff --git a/drivers/gpu/drm/

[Spice-devel] [drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

On Thu, Nov 03, 2016 at 06:08:39PM +0100, Gerd Hoffmann wrote: > > Or maybe other parts of the > > kernel/userspace rely on this rounding down. > > This is where I suspect we could run in trouble. Odd resolutions simply > don't happen on physical hardware, all usual resolutions are a multiple > o

[drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

On Thu, Nov 03, 2016 at 09:53:48AM +0100, Gerd Hoffmann wrote: > On Mi, 2016-11-02 at 18:00 +0100, Christophe Fergeau wrote: > > The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that > > the resolutions we are going to present to user-space are going to be > &

[Spice-devel] [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

On Wed, Nov 02, 2016 at 05:31:28PM +0100, Christophe Fergeau wrote: > > > > > + if (client_head->flags != 0) { > > > + client_head->flags = 0; > > > + changed = true; > > > + } > > > > w

[drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

the client in the drm_display_mode structure rather than keeping the rounded version. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c index 2f1d738

[drm/qxl v2 6/7] qxl: Don't notify userspace when monitors config is unchanged

configuration we received is the same one as the current one, and does not notify userspace about it if that's the case. Signed-off-by: Christophe Fergeau --- Changes since v1: - made qxl_display_copy_rom_client_monitors_config return an enum MonitorsConfigCopyStatus - remove 'bool cha

[drm/qxl v2 5/7] qxl: Remove qxl_bo_init() return value

It's always returning 0, and it's always ignored. Signed-off-by: Christophe Fergeau --- Changes since v1: new patch drivers/gpu/drm/qxl/qxl_drv.h | 2 +- drivers/gpu/drm/qxl/qxl_gem.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/q

[drm/qxl v2 4/7] qxl: Call qxl_gem_{init,fini}

qdev->gem.objects was initialized directly in qxl_device_init() rather than going through qxl_gem_init(), and qxl_gem_fini() was never called. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[drm/qxl v2 3/7] qxl: Add missing '\n' to qxl_io_log() call

The message has to be terminated by a newline as it's not going to get added automatically. Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- drivers/gpu/drm/qxl/qxl_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/dr

[drm/qxl v2 2/7] qxl: Remove unused prototype

qxl_crtc_set_from_monitors_config() is defined in qxl_drv.h but never implemented. Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h

[drm/qxl v2 1/7] qxl: Mark some internal functions as static

They are not used outside of their respective source file Signed-off-by: Christophe Fergeau Acked-by: Frediano Ziglio --- drivers/gpu/drm/qxl/qxl_cmd.c | 2 +- drivers/gpu/drm/qxl/qxl_display.c | 4 ++-- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 3 files changed, 3 insertions(+), 6

[drm/qxl v2 0/7] qxl: Various cleanups/fixes

Hey, Here is the v2 of my patch series. It improves a bit patch 6/7 readability following Frediano's review, and patch 5/7 is new and was suggested during review. The other patches are unchanged. Christophe

[Spice-devel] [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

Hey, On Mon, Oct 31, 2016 at 08:00:09AM -0400, Frediano Ziglio wrote: > > diff --git a/drivers/gpu/drm/qxl/qxl_display.c > > b/drivers/gpu/drm/qxl/qxl_display.c > > index 156b7de..edb90f6 100644 > > --- a/drivers/gpu/drm/qxl/qxl_display.c > > +++ b/drivers/gpu/drm/qxl/qxl_display.c > > @@ -57,11 +

[Spice-devel] [drm/qxl 4/6] qxl: Call qxl_gem_{init,fini}

) was never called" did we have a leak? Maybe, as this forces the freeing of some pending bo's if they are still in use. This would only happen when unloading/reloading the module repeatedly, which I don't expect to happen on production systems. > > > Signed-off-by: Chri

[drm/qxl 6/6] qxl: Allow resolution which are not multiple of 8

the client in the drm_display_mode structure rather than keeping the rounded version. Signed-off-by: Christophe Fergeau --- I know this is very hacky, but I have no idea what is important to be set in the mode struct, if there is a better way to create it without getting the rounding to a

[drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged

configuration we received is the same one as the current one, and does not notify userspace about it if that's the case. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_display.c | 65 +-- 1 file changed, 55 insertions(+), 10 deletions(-) diff --

[drm/qxl 4/6] qxl: Call qxl_gem_{init,fini}

qdev->gem.objects was initialized directly in qxl_device_init() rather than going through qxl_gem_init(), and qxl_gem_fini() was never called. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_kms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[drm/qxl 3/6] qxl: Add missing '\n' to qxl_io_log() call

The message has to be terminated by a newline as it's not going to get added automatically. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c

[drm/qxl 2/6] qxl: Remove unused prototype

qxl_crtc_set_from_monitors_config() is defined in qxl_drv.h but never implemented. Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_drv.h b/drivers/gpu/drm/qxl/qxl_drv.h index da41e1f..590ba25

[drm/qxl 1/6] qxl: Mark some internal functions as static

They are not used outside of their respective source file Signed-off-by: Christophe Fergeau --- drivers/gpu/drm/qxl/qxl_cmd.c | 2 +- drivers/gpu/drm/qxl/qxl_display.c | 4 ++-- drivers/gpu/drm/qxl/qxl_drv.h | 3 --- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers

[drm/qxl 0/6] Various cleanups/fixes

Hey, This patch series starts by doing some various small cleanups (patch 1 to 4), and then there are 2 fixes for issues which were noticed in fedora 25, the more annoying one being the one fixed by patch 5 where the VM screen would constantly flicker when wayland is used. Patch 6 is very hacky,

[Spice-devel] [PATCH] Do not loop on ERESTARTSYS using interruptible waits

Hey, On Fri, May 22, 2015 at 09:58:10AM -0400, Frediano Ziglio wrote: > > > } > > > > > > int qxl_io_update_area(struct qxl_device *qdev, struct qxl_bo *surf, > > > - const struct qxl_rect *area) > > > + const struct qxl_rect *area, bool intr) > > > { > > > i

[Spice-devel] [PATCH] Do not loop on ERESTARTSYS using interruptible waits

Hey, On Tue, May 19, 2015 at 05:54:54AM -0400, Frediano Ziglio wrote: > This problem happens using KMS surfaces and QXL driver. > To easy reproduce use KDE Plasma (which use surfaces a lot) and assure > you are using KMS surfaces (QXL driver on Fedora/RedHat has a patch to > stop using them). Open