[PATCH v2] drm/amdkfd: fixes for HMM mem allocation

2024-01-07 Thread Dafna Hirschfeld
Fix err return value and reset pgmap->type after checking it. Fixes: c83dee9b6394 ("drm/amdkfd: add SPM support for SVM") Reviewed-by: Felix Kuehling Signed-off-by: Dafna Hirschfeld --- v2: remove unrelated DOC fix and add 'Fixes' tag. drivers/gpu/drm/amd/amdkfd/kfd_

[PATCH] drm/amdkfd: fixes for HMM mem allocation

2023-12-31 Thread Dafna Hirschfeld
Few fixes to amdkfd and the doc of devm_request_free_mem_region. Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/amd/amdkfd/kfd_migrate.c | 6 +++--- kernel/resource.c| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd

Re: [PULL] drm-xe-next v2

2023-12-20 Thread Dafna Hirschfeld
break the builds without CONFIG_FAULT_INJECTION - One commit that removes the FW loading for blobs that are not in linux-firmware.git yet. Thanks, Rodrigo. Hi, I reviewed the usage of the gpuvm API, all issues I found were fixed. Acked-by: Dafna Hirschfeld Dafna, The following changes si

Re: [PATCH 5/5 v3] accel/qaic: Fix a leak in map_user_pages()

2023-07-11 Thread Dafna Hirschfeld
Carpenter Reviewed-by: Dafna Hirschfeld --- no change drivers/accel/qaic/qaic_control.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/accel/qaic/qaic_control.c b/drivers/accel/qaic/qaic_control.c index d5ce36cb351f..9a6f80f31c65 100644 --- a/drivers/

Re: [Intel-xe] [PATCH 2/4] drm/xe/ras: Log the GT hw errors.

2023-04-25 Thread Dafna Hirschfeld
On 06.04.2023 14:52, Himal Prasad Ghimiray wrote: From: Aravind Iddamsetty Count the CORRECTABLE and FATAL GT hardware errors as signaled by relevant interrupt and respective registers. For non relevant interrupts count them as driver interrupt error. For platform supporting error vector regi

Re: [PATCH v2 2/8] accel/qaic: Add uapi and core driver file

2023-02-22 Thread Dafna Hirschfeld
On 17.02.2023 11:15, Jeffrey Hugo wrote: On 2/16/2023 7:13 AM, Jacek Lawrynowicz wrote: Hi, On 06.02.2023 16:41, Jeffrey Hugo wrote: Add the QAIC driver uapi file and core driver file that binds to the PCIe device. The core driver file also creates the accel device and manages all the interco

Re: [PATCH v3] media: mtk-vcodec: Align width and height to 64 bytes

2021-11-21 Thread Dafna Hirschfeld
On 04.11.21 14:24, Yunfei Dong wrote: Width and height need to 64 bytes aligned when setting the format. Need to make sure all is 64 bytes align when use width and height to calculate buffer size. Signed-off-by: Yunfei Dong Acked-by: Nicolas Dufresne Tested-by: Steve Cho --- drivers/medi

Re: [PATCH] drm/bridge: parade-ps8640: Assign drm_device to dp aux channel

2021-11-10 Thread Dafna Hirschfeld
og so people can locate it later. Maybe also add 'Fixes' tag? apart of that Reviewed-by: Dafna Hirschfeld Signed-off-by: AngeloGioacchino Del Regno --- drivers/gpu/drm/bridge/parade-ps8640.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c

Re: [PATCH v2 3/3] drm/bridge: parade-ps8640: Perform full poweroff if poweron fails

2021-11-10 Thread Dafna Hirschfeld
Reviewed-by: Dafna Hirschfeld --- drivers/gpu/drm/bridge/parade-ps8640.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index 41f5d511d516..ef1b51d8b676 100644 --- a/drivers/gpu

Re: [PATCH v2 2/3] drm/bridge: parade-ps8640: Move real poweroff action to new function

2021-11-10 Thread Dafna Hirschfeld
On 02.11.21 11:36, AngeloGioacchino Del Regno wrote: In preparation for varying the poweron error handling in function ps8640_bridge_poweron(), move function ps8640_bridge_poweroff() up and also move the actual logic to power off the chip to a new __ps8640_bridge_poweroff() function. Signed-o

Re: [PATCH v2 1/3] drm/bridge: parade-ps8640: Don't try to enable VDO if poweron fails

2021-11-10 Thread Dafna Hirschfeld
() in ps8640_pre_enable() if the poweron sequence fails. Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Dafna Hirschfeld --- drivers/gpu/drm/bridge/parade-ps8640.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/dr

Re: [PATCH v8, 07/17] dt-bindings: media: mtk-vcodec: Separate video encoder and decoder dt-bindings

2021-10-29 Thread Dafna Hirschfeld
On 29.10.21 05:55, Yunfei Dong wrote: Decoder will use component framework to manage hardware, it is big difference with encoder. Reviewed-by: Rob Herring Signed-off-by: Yunfei Dong --- .../media/mediatek,vcodec-decoder.yaml| 176 + .../media/mediatek,vcodec-encode

Re: [PATCH v8, 04/17] media: mtk-vcodec: Build decoder pm file as module

2021-10-29 Thread Dafna Hirschfeld
On 29.10.21 05:55, Yunfei Dong wrote: Need to build decoder pm file as module for master and comp use the same pm interface. Do you still use the component framework in this patchset? In the cover letter you write: "- Use of_platform_populate to manage multi hardware, not component framewor

Re: [PATCH v8, 03/17] media: mtk-vcodec: Refactor vcodec pm interface

2021-10-29 Thread Dafna Hirschfeld
On 29.10.21 05:55, Yunfei Dong wrote: Using the needed param for pm init/release function and remove unused param mtkdev in 'struct mtk_vcodec_pm'. Reviewed-by: Tzung-Bi Shih Reviewed-By: AngeloGioacchino Del Regno Signed-off-by: Yunfei Dong Hi, I already commented on v7 that since the

Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-10-18 Thread Dafna Hirschfeld
On 16.10.21 04:23, Yong Wu wrote: On Mon, 2021-10-11 at 14:36 +0200, Dafna Hirschfeld wrote: On 29.09.21 03:37, Yong Wu wrote: MediaTek IOMMU-SMI diagram is like below. all the consumer connect with smi-larb, then connect with smi-common. M4U | smi-common

Re: [PATCH v7, 03/15] media: mtk-vcodec: Refactor vcodec pm interface

2021-10-14 Thread Dafna Hirschfeld
On 11.10.21 09:02, Yunfei Dong wrote: Using the needed param for pm init/release function and remove unused param mtkdev in 'struct mtk_vcodec_pm'. I see that there is a lot of code duplication between mtk_vcodec_release_dec_pm.c and mtk_vcodec_release_enc_pm.c I think if you bother to fac

Re: [PATCH v8 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-10-11 Thread Dafna Hirschfeld
On 29.09.21 03:37, Yong Wu wrote: MediaTek IOMMU-SMI diagram is like below. all the consumer connect with smi-larb, then connect with smi-common. M4U | smi-common | - | |... | | larb1 larb2 | | vdec

Re: [PATCH v10, 2/5] drm/mediatek: add component POSTMASK

2021-10-01 Thread Dafna Hirschfeld
On 30.09.21 17:52, Yongqiang Niu wrote: This patch add component POSTMASK. Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang Reviewed-by: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 102 ++-- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 + 2 file

Re: [PATCH v8 09/12] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put

2021-09-30 Thread Dafna Hirschfeld
On 30.09.21 05:28, Yong Wu wrote: Hi Dafna, Thanks very much for the review. On Wed, 2021-09-29 at 14:13 +0200, Dafna Hirschfeld wrote: On 29.09.21 03:37, Yong Wu wrote: MediaTek IOMMU has already added the device_link between the consumer and smi-larb device. If the vcodec device call

Re: [PATCH v8 03/12] iommu/mediatek: Add probe_defer for smi-larb

2021-09-29 Thread Dafna Hirschfeld
On 29.09.21 03:37, Yong Wu wrote: Prepare for adding device_link. The iommu consumer should use device_link to connect with the smi-larb(supplier). then the smi-larb should run before the iommu consumer. Here we delay the iommu driver until the smi driver is ready, then all the iommu consumer

Re: [PATCH v8 09/12] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put

2021-09-29 Thread Dafna Hirschfeld
Yong Wu Reviewed-by: Evan Green Acked-by: Tiffany Lin Reviewed-by: Dafna Hirschfeld --- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 37 +++- .../platform/mtk-vcodec/mtk_vcodec_drv.h | 3 -- .../platform/mtk-vcodec/mtk_vcodec_enc.c | 1 - .../platform/mtk-v

Re: [PATCH v6, 15/15] media: mtk-vcodec: Use codec type to separate different hardware

2021-09-03 Thread Dafna Hirschfeld
On 02.09.21 08:05, yunfei.d...@mediatek.com wrote: On Wed, 2021-09-01 at 14:17 +0200, Dafna Hirschfeld wrote: Hi Dafna, Thanks for your suggestion. Hi On 01.09.21 10:32, Yunfei Dong wrote: There are just one core thread, in order to separeate different hardware, using codec type to

Re: [PATCH v6, 15/15] media: mtk-vcodec: Use codec type to separate different hardware

2021-09-01 Thread Dafna Hirschfeld
Hi On 01.09.21 10:32, Yunfei Dong wrote: There are just one core thread, in order to separeate different hardware, using codec type to separeate it in scp driver. this code seems to relate to the vpu driver not the scp driver. Is there a corresponding code added to the vpu driver that test the

Re: [PATCH v7 04/12] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-08-05 Thread Dafna Hirschfeld
://lore.kernel.org/patchwork/patch/1086569/ Suggested-by: Tomasz Figa Signed-off-by: Yong Wu Tested-by: Dafna Hirschfeld # on mt8173 Hi, unfortunately, I have to take back the Tested-by tag. I am now testing the mtk-vcodec with latest kernel + patches sent from the mailing list: https://gi

Re: [PATCH v6 00/11] Clean up "mediatek,larb"

2021-07-14 Thread Dafna Hirschfeld
t the test always passes so I added tested-by: Tested-by: Dafna Hirschfeld Thanks, Dafna On 14.07.21 04:56, Yong Wu wrote: MediaTek IOMMU block diagram always like below: M4U | smi-common | - | | ... | | larb1

Re: [PATCH v6 01/11] dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW

2021-07-14 Thread Dafna Hirschfeld
On 14.07.21 10:13, Dafna Hirschfeld wrote: Hi, thanks for the patch On 14.07.21 04:56, Yong Wu wrote: After adding device_link between the consumer with the smi-larbs, if the consumer call its owner pm_runtime_get(_sync), the pm_runtime_get(_sync) of smi-larb and smi-common will be called

Re: [PATCH v6 06/11] drm/mediatek: Add pm runtime support for ovl and rdma

2021-07-14 Thread Dafna Hirschfeld
On 14.07.21 04:56, Yong Wu wrote: From: Yongqiang Niu Prepare for smi cleaning up "mediatek,larb". Display use the dispsys device to call pm_rumtime_get_sync before. This patch add pm_runtime_xx with ovl and rdma device whose nodes has "iommus" property, then display could help pm_runtime_g

Re: [PATCH v6 09/11] memory: mtk-smi: Get rid of mtk_smi_larb_get/put

2021-07-14 Thread Dafna Hirschfeld
Acked-by: Krzysztof Kozlowski Acked-by: Matthias Brugger Reviewed-by: Dafna Hirschfeld --- drivers/memory/mtk-smi.c | 14 -- include/soc/mediatek/smi.h | 20 2 files changed, 34 deletions(-) diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk

Re: [PATCH v6 08/11] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put

2021-07-14 Thread Dafna Hirschfeld
Yong Wu Reviewed-by: Evan Green Acked-by: Tiffany Lin Reviewed-by: Dafna Hirschfeld --- .../platform/mtk-vcodec/mtk_vcodec_dec_pm.c | 37 +++- .../platform/mtk-vcodec/mtk_vcodec_drv.h | 3 -- .../platform/mtk-vcodec/mtk_vcodec_enc.c | 1 - .../platform/mtk-v

Re: [PATCH v6 07/11] drm/mediatek: Get rid of mtk_smi_larb_get/put

2021-07-14 Thread Dafna Hirschfeld
ng Wu Reviewed-by: Evan Green Acked-by: Chun-Kuang Hu Reviewed-by: Dafna Hirschfeld --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 9 -- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 36 ++--- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 1 - drivers/gpu/drm/med

Re: [PATCH v6 05/11] media: mtk-mdp: Get rid of mtk_smi_larb_get/put

2021-07-14 Thread Dafna Hirschfeld
ff-by: Yong Wu Reviewed-by: Evan Green Reviewed-by: Houlong Wei Reviewed-by: Dafna Hirschfeld --- drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 46 +-- drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 - drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 1 - 3 files chang

Re: [PATCH v6 04/11] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put

2021-07-14 Thread Dafna Hirschfeld
then mtk_jpeg_clk_init is also unnecessary. Remove it too. CC: Rick Chang CC: Xia Jiang Signed-off-by: Yong Wu Reviewed-by: Evan Green Acked-by: Rick Chang Reviewed-by: Dafna Hirschfeld --- .../media/platform/mtk-jpeg/mtk_jpeg_core.c | 45 +-- .../media/platform/mtk

Re: [PATCH v6 03/11] iommu/mediatek: Add device_link between the consumer and the larb devices

2021-07-14 Thread Dafna Hirschfeld
On 14.07.21 04:56, Yong Wu wrote: MediaTek IOMMU-SMI diagram is like below. all the consumer connect with smi-larb, then connect with smi-common. M4U | smi-common | - | |... | | larb1 larb2 | | vdec

Re: [PATCH v6 01/11] dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW

2021-07-14 Thread Dafna Hirschfeld
Hi, thanks for the patch On 14.07.21 04:56, Yong Wu wrote: After adding device_link between the consumer with the smi-larbs, if the consumer call its owner pm_runtime_get(_sync), the pm_runtime_get(_sync) of smi-larb and smi-common will be called automatically. Thus, the consumer don't need the

[PATCH] drm/mediatek: Test component initialization earlier in the function mtk_drm_crtc_create

2021-07-12 Thread Dafna Hirschfeld
The initialization is currently tested in a later stage in the function for no reason. In addition, the test '!comp' will never fail since comp is set with the '&' operator. Instead, test if a comp was not initialized by testing "!comp->dev". Signed-off-by: D

Re: Aw: Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-12 Thread Dafna Hirschfeld
Hi, On 12.07.21 19:16, Frank Wunderlich wrote: Hi, it turns out that problem is the read+or of the new value i reverted my patch and changed reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val; writel_relaxed(reg, mmsys->regs + routes[i].addr); to writel_relaxed(routes[i].val,

Re: [PATCH] soc: mediatek: mmsys: fix HDMI output on mt7623/bananapi-r2

2021-07-12 Thread Dafna Hirschfeld
Hi On 10.07.21 15:24, Frank Wunderlich wrote: From: Frank Wunderlich HDMI output was broken on mt7623/BPI-R2 in 5.13 because function for special output selection (mtk_mmsys_ddp_sout_sel) was dropped. This function wrote 3 registers at one time and so it is not compatible with the array-approa

Re: Aw: Re: BUG: MTK DRM/HDMI broken on 5.13 (mt7623/bpi-r2)

2021-07-08 Thread Dafna Hirschfeld
se i see this on reboot/poweroff: "watchdog: watchdog0: watchdog did not stop!" i see this with my 5.13, 5.12-drm (5.12.0+mtk/core drm-patches) and 5.12.14 too (hdmi is working there), but not 5.12.0! that means something in drm-patches (mtk/core) breaks watchdog. maybe the recursion me

Re: BUG: MTK DRM/HDMI broken on 5.13 (mt7623/bpi-r2)

2021-07-08 Thread Dafna Hirschfeld
Hi Frank, On 06.07.21 11:54, Frank Wunderlich wrote: Hi, i've noticed that HDMI is broken at least on my board (Bananapi-r2,mt7623) on 5.13. after some research i noticed that it is working till commit 2e477391522354e763aa62ee3e281c1ad9e8eb1b Author: Dafna Hirschfeld Date: Tue Mar

Re: [PATCH 10/12] dt-bindings: media: rockchip-vpu: Add PX30 compatible

2021-06-25 Thread Dafna Hirschfeld
Hi, On 24.06.21 21:26, Ezequiel Garcia wrote: From: Paul Kocialkowski The Rockchip PX30 SoC has a Hantro VPU that features a decoder (VDPU2) and an encoder (VEPU2). Signed-off-by: Paul Kocialkowski Signed-off-by: Ezequiel Garcia --- Documentation/devicetree/bindings/media/rockchip-vpu.yam

[PATCH v6 RESEND 0/2] Add support for ANX7688

2021-05-18 Thread Dafna Hirschfeld
an 'mfd' device and an additional 'bridge' device for the HDMI-DP conversion, see [2]. [2] https://lkml.org/lkml/2020/3/18/64 Dafna Hirschfeld (1): dt-bindings: display: add google,cros-ec-anx7688.yaml Enric Balletbo i Serra (1): drm/bridge: Add ChromeOS EC ANX7688 bridge

[PATCH v6 RESEND 1/2] dt-bindings: display: add google, cros-ec-anx7688.yaml

2021-05-18 Thread Dafna Hirschfeld
therefore its node should be a child of an EC I2C tunnel node (See google,cros-ec-i2c-tunnel.yaml). ChromOS EC ANX7688 is found on Acer Chromebook R13 (elm) Signed-off-by: Dafna Hirschfeld Reviewed-by: Rob Herring --- .../bridge/google,cros-ec-anx7688.yaml| 82 +++ 1 file

[PATCH v6 RESEND 2/2] drm/bridge: Add ChromeOS EC ANX7688 bridge driver support

2021-05-18 Thread Dafna Hirschfeld
Signed-off-by: Enric Balletbo i Serra [convert to i2c driver, rename to cros_ec_anx7688, add err checks] Signed-off-by: Dafna Hirschfeld Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/Kconfig | 12 ++ drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge

Re: [PATCH v6 0/2] Add support for ANX7688

2021-04-28 Thread Dafna Hirschfeld
Hi, pinging here, can one of the kernel bridge maintainers review this patchset? Thanks, Dafna On 09.04.21 18:19, Dafna Hirschfeld wrote: ANX7688 is a typec port controller that also converts HDMI to DP. ANX7688 is found on Acer Chromebook R13 (elm) and on Pine64 PinePhone. On Acer Chromebook

[PATCH v6 2/2] drm/bridge: Add ChromeOS EC ANX7688 bridge driver support

2021-04-09 Thread Dafna Hirschfeld
Signed-off-by: Enric Balletbo i Serra [convert to i2c driver, rename to cros_ec_anx7688, add err checks] Signed-off-by: Dafna Hirschfeld Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/Kconfig | 12 ++ drivers/gpu/drm/bridge/Makefile | 1 + drivers/gpu/drm/bridge

[PATCH v6 0/2] Add support for ANX7688

2021-04-09 Thread Dafna Hirschfeld
an additional 'bridge' device for the HDMI-DP conversion, see [2]. [2] https://lkml.org/lkml/2020/3/18/64 Dafna Hirschfeld (1): dt-bindings: display: add google,cros-ec-anx7688.yaml Enric Balletbo i Serra (1): drm/bridge: Add ChromeOS EC ANX7688 bridge driver support .../bridge/

[PATCH v6 1/2] dt-bindings: display: add google,cros-ec-anx7688.yaml

2021-04-09 Thread Dafna Hirschfeld
therefore its node should be a child of an EC I2C tunnel node (See google,cros-ec-i2c-tunnel.yaml). ChromOS EC ANX7688 is found on Acer Chromebook R13 (elm) Signed-off-by: Dafna Hirschfeld --- .../bridge/google,cros-ec-anx7688.yaml| 82 +++ 1 file changed, 82 insertions

Re: [PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-04-07 Thread Dafna Hirschfeld
Hi On 06.04.21 14:40, Laurent Pinchart wrote: Hi Dafna, Thank you for the patch. On Tue, Mar 30, 2021 at 01:52:00PM +0200, Dafna Hirschfeld wrote: drm_bridge_funcs has a function called 'hpd_notify'. The function drm_bridge_hpd_notify does not call 'hpd_notify' but it cal

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-31 Thread Dafna Hirschfeld
Hi, On 05.03.21 18:24, Ondřej Jirman wrote: Hello Dafna, On Fri, Mar 05, 2021 at 04:14:03PM +0100, Dafna Hirschfeld wrote: Hi On 05.03.21 15:34, Laurent Pinchart wrote: Hi Dafna, Thank you for the patch. On Fri, Mar 05, 2021 at 01:43:50PM +0100, Dafna Hirschfeld wrote: ANX7688 is a USB

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-30 Thread Dafna Hirschfeld
Hi, On 05.03.21 16:19, Laurent Pinchart wrote: Hi Dafna, On Fri, Mar 05, 2021 at 04:14:03PM +0100, Dafna Hirschfeld wrote: On 05.03.21 15:34, Laurent Pinchart wrote: On Fri, Mar 05, 2021 at 01:43:50PM +0100, Dafna Hirschfeld wrote: ANX7688 is a USB Type-C port controller with a MUX. It

[PATCH] drm: bridge: rename the function drm_bridge_hpd_notify to drm_bridge_hpd_cb

2021-03-30 Thread Dafna Hirschfeld
drm_bridge_funcs has a function called 'hpd_notify'. The function drm_bridge_hpd_notify does not call 'hpd_notify' but it calls 'hpd_cb'. This is rather confusing. Rename the function to fix this confusion. Signed-off-by: Dafna Hirschfeld --- drivers/gpu/dr

[PATCH v3 2/2] drm/mediatek: Don't support hdmi connector creation

2021-03-30 Thread Dafna Hirschfeld
w-hdmi: Make connector creation optional") But with the difference that in mtk-hdmi only the option of not creating a connector is supported. Fixes: f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") Signed-off-by: Dafna Hirschfeld Reviewed-by: Laurent P

[PATCH v3 1/2] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-30 Thread Dafna Hirschfeld
ng the current connector from the state. This patch switches the bridge to the atomic version to prepare access to the connector in later patches. Signed-off-by: Dafna Hirschfeld Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 23 +++ 1 file chang

[PATCH v3 0/2] drm/mediatek: Don't support hdmi connector creation

2021-03-30 Thread Dafna Hirschfeld
- now the first patch only moves the bridge ops to the atomic API while the replacement of the field 'conn' with the field '*curr_conn' is done in a new third patch. 2. in the function 'get_eld' use the current conn only if 'enabled = true'. Dafna Hirschfeld

Re: [PATCH v2 2/3] drm/mediatek: Don't support hdmi connector creation

2021-03-30 Thread Dafna Hirschfeld
Hi, On 30.03.21 02:08, Laurent Pinchart wrote: Hi Dafna, Thank you for the patch. On Mon, Mar 29, 2021 at 05:36:31PM +0200, Dafna Hirschfeld wrote: commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") broke the display support for elm device since mtk

[PATCH v2 2/3] drm/mediatek: Don't support hdmi connector creation

2021-03-29 Thread Dafna Hirschfeld
.c: commit ec971aaa6775 ("drm: bridge: dw-hdmi: Make connector creation optional") But with the difference that in mtk-hdmi only the option of not creating a connector is supported. Fixes: f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") Signed-off-by: Dafna Hi

[PATCH v2 0/3] drm/mediatek: Don't support hdmi connector creation

2021-03-29 Thread Dafna Hirschfeld
hird patch. 2. in the function 'get_eld' use the current conn only if 'enabled = true'. Dafna Hirschfeld (3): drm/mediatek: Switch the hdmi bridge ops to the atomic versions drm/mediatek: Don't support hdmi connector creation drm/mediatek: in struct mtk_hdmi, replace conn

[PATCH v2 3/3] drm/mediatek: in struct mtk_hdmi, replace conn field with curr_conn ptr

2021-03-29 Thread Dafna Hirschfeld
The mtk_hdmi does not support creating a bridge with a connector. Therefore the field 'conn' should be removed from the mtk_hdmi struct. It is replaced with a pointer curr_conn that points to the current connector which can be access through the global state. Signed-off-by: Dafna

[PATCH v2 1/3] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-29 Thread Dafna Hirschfeld
ng the current connector from the state. This patch switches the bridge to the atomic version to prepare access to the connector in later patches. Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions

[PATCH 2/2] drm/bridge: fix typo in Kconfig

2021-03-26 Thread Dafna Hirschfeld
fix 's/controller/controllers/' in the sentence: Most display controller handle display connectors... Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/bridge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/

[PATCH 1/2] drm: Fix 3 typos in the inline doc

2021-03-26 Thread Dafna Hirschfeld
ort the full/ Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/drm_atomic_helper.c | 15 +++ include/drm/drm_drv.h | 2 +- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 5

[PATCH] MAINTAINERS: Add linux-mediatek ML for drm Mediatek drivers

2021-03-25 Thread Dafna Hirschfeld
Add the linux-mediatek mailing list to drm Mediatek drivers Signed-off-by: Dafna Hirschfeld --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9e876927c60d..8260bc5afe66 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5963,6 +5963,7 @@ DRM DRIVERS

Re: [PATCH 1/2] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-25 Thread Dafna Hirschfeld
mails from get_maintainer.pl. linux-mediatek was not there, I can add it. On 24/3/21 20:12, Dafna Hirschfeld wrote: The bridge operation '.enable' and the audio cb '.get_eld' access hdmi->conn. In the future we will want to support the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR and then

[PATCH 1/2] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-24 Thread Dafna Hirschfeld
ng the current connector from the state. This patch switches the bridge to the atomic version and saves the current connector in a new field 'curr_conn'. Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 41 - 1 file changed, 29 i

[PATCH 2/2] drm/mediatek: Don't support hdmi connector creation

2021-03-24 Thread Dafna Hirschfeld
.c: commit ec971aaa6775 ("drm: bridge: dw-hdmi: Make connector creation optional") But with the difference that in mtk-hdmi only the option of not creating a connector is supported. Fixes: f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") Signed-off-by: Dafna Hi

[PATCH 2/2] drm/mediatek: Don't support hdmi connector creation

2021-03-24 Thread Dafna Hirschfeld
upport for DRM_BRIDGE_ATTACH_NO_CONNECTOR in mtk_hdmi bridge attachment. The first patch moves the mkt-hdmi bridge to the atomic API in order to be able to access the connector through the global state. Dafna Hirschfeld (2): drm/mediatek: Switch the hdmi bridge ops to the atomic versions dr

Re: [PATCH v5 2/2] drm/bridge: anx7688: Add ANX7688 bridge driver support

2021-03-05 Thread Dafna Hirschfeld
Adding meg...@megous.com and linux-...@vger.kernel.org to the list Thanks, Dafna On 05.03.21 13:43, Dafna Hirschfeld wrote: From: Enric Balletbo i Serra This driver adds support for the ANX7688 HDMI to DP converter block of the ANX7688 device. For our use case, the only reason the Linux

Re: [PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-05 Thread Dafna Hirschfeld
Hi On 05.03.21 15:34, Laurent Pinchart wrote: Hi Dafna, Thank you for the patch. On Fri, Mar 05, 2021 at 01:43:50PM +0100, Dafna Hirschfeld wrote: ANX7688 is a USB Type-C port controller with a MUX. It converts HDMI 2.0 to DisplayPort 1.3 Ultra-HDi (4096x2160p60). The integrated crosspoint

[PATCH v5 1/2] dt-bindings: usb: add analogix,anx7688.yaml

2021-03-05 Thread Dafna Hirschfeld
) and on Pine64 PinePhone. Signed-off-by: Dafna Hirschfeld --- .../bindings/usb/analogix,anx7688.yaml| 177 ++ 1 file changed, 177 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7688.yaml diff --git a/Documentation/devicetree/bindings

[PATCH v5 0/2] Add support for ANX7688

2021-03-05 Thread Dafna Hirschfeld
4: Send the device as a typec controller instead of mfd. The bridge driver should therefore convert from a platform driver to an i2c driver. Dafna Hirschfeld (1): dt-bindings: usb: add analogix,anx7688.yaml Enric Balletbo i Serra (1): drm/bridge: anx7688: Add ANX7688 bridge driver support

[PATCH v5 2/2] drm/bridge: anx7688: Add ANX7688 bridge driver support

2021-03-05 Thread Dafna Hirschfeld
: kbuild test robot Signed-off-by: Enric Balletbo i Serra [convert the driver to be a i2c driver] Signed-off-by: Dafna Hirschfeld --- drivers/gpu/drm/bridge/analogix/Kconfig | 11 ++ drivers/gpu/drm/bridge/analogix/Makefile | 1 + .../drm/bridge/analogix/analogix-anx7688.c| 186

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
On 21.01.20 16:11, Johan Jonker wrote: Hi Dafna, On 21.01.20 15:03, Rob Herring wrote: On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld wrote: convert the binding file rockchip-drm.txt to yaml format. This was tested and verified with: make dt_binding_check DT_SCHEMA_FILES

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
On 21.01.20 15:03, Rob Herring wrote: On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld wrote: convert the binding file rockchip-drm.txt to yaml format. This was tested and verified with: make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip

[PATCH v3] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
/rockchip/rockchip-drm.yaml Signed-off-by: Dafna Hirschfeld --- the detail of the ARM tests: export ARCH=arm KBUILD_OUTPUT=../kbuild/arm-test-dtc/ CROSS_COMPILE=arm-linux-gnueabi- make menuconfig # set rockchip system make clean make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings

[PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
-drm.yaml Signed-off-by: Dafna Hirschfeld --- Changes since v1: - fixed worng sign-off - fixed the path of the $id property to be the path of the yaml file .../display/rockchip/rockchip-drm.txt | 19 -- .../display/rockchip/rockchip-drm.yaml| 38 +++ 2 files

[PATCH] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Dafna Hirschfeld
From: Dafna Hirschfeld convert the binding file rockchip-drm.txt to yaml format. This was tested and verified with: make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings