On Mon, Aug 11, 2025 at 07:21:18PM +0200, Louis Chauvet wrote:
>
>
> Le 11/08/2025 à 12:15, José Expósito a écrit :
> > Check that the value returned by the vkms_config_create_*() functions is
> > valid. Otherwise, assert and finish the KUnit test.
> >
> > Repor
so now I'm going
> > through a bunch of old warnings to say that, "Hey, if the author ignores the
> > error checking that's fine, but I'm in the clear."
> >
> > 245 KUNIT_ASSERT_EQ(test, vkms_config_get_num_crtcs(config), 1);
>
> While the "crtc_cfg1" pointer is not checked, we check that the number
> of CRTCs matches the expected value and...
>
Ah yes. That does work... Sorry for the noise.
regards,
dan carpenter
rtc_cfg != crtc_cfg1 && crtc_cfg != crtc_cfg2)
255 KUNIT_FAIL(test, "Unexpected CRTC");
256 }
257
--> 258 vkms_config_destroy_crtc(config, crtc_cfg2);
259 KUNIT_ASSERT_EQ(test, vkms_config_get_num_crtcs(config), 1);
260
The xe_preempt_fence_create() function returns error pointers. It
never returns NULL. Update the error checking to match.
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/xe/xe_vm.c | 4 ++--
1 file
t sun4i_layer_state *layer_state = NULL;
> + struct drm_framebuffer *fb = NULL;
No need to initialize things like this. NULL isn't a valid pointer.
This just disables static checker tools from finding uninitialized
variable warnings so all the expense of writing the checker tools is
now waste
The devm_drm_bridge_alloc() function doesn't return NULL pointers, it
returns error pointers. Update the error checking to match.
Fixes: 48f05c3b4b70 ("drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/bridge/analogix/ana
On Mon, Aug 04, 2025 at 11:08:57AM -0400, Alex Deucher wrote:
> On Mon, Aug 4, 2025 at 10:49 AM Dan Carpenter
> wrote:
> >
> > On Mon, Aug 04, 2025 at 10:32:43AM -0400, Alex Deucher wrote:
> > > On Sat, Aug 2, 2025 at 4:22 AM Ethan Carter Edwards
> > > wrote:
code is
> checking if any bits are set in that register. If not, then we can
> skip that code as there is nothing to do.
>
It's not a null check, but it is a nested check and it's a local
variable so the patch is correct enough. At this point we know that
grbm_soft_reset can't be zero.
regards,
dan carpenter
On Sat, Aug 02, 2025 at 06:12:56AM -0700, Rob Clark wrote:
> On Sat, Aug 2, 2025 at 12:49 AM Dan Carpenter
> wrote:
> >
> > Hello Rob Clark,
> >
> > Commit 2e6a8a1fe2b2 ("drm/msm: Add VM_BIND ioctl") from Jun 29, 2025
> > (linux-next), leads
not mapped then it's non-NULL?
If so then just ignore this warning.
597
598 /* Drop the previous ref: */
599 drm_gpuvm_bo_put(vm_bo);
600
601 return 0;
602 }
regards,
dan carpenter
e this business of declaring variables randomly
throughout the code, unless it's required for __cleanup magic. Anyway,
here it breaks the build.
regards,
dan carpenter
The xe_migrate_alloc() function returns NULL on error. It doesn't return
error pointers. Update the checking to match.
Fixes: a843b9894705 ("drm/xe/vf: Fix VM crash during VF driver release")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/xe/xe_sriov_vf_ccs.c | 4 ++--
1
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202507310854.pzvicswn-...@intel.com/
New smatch warnings:
lib/kunit/test.c:723 kunit_run_tests() error: we previously assumed
'test_case->generate_params' could be null (see line 714)
vim +723 lib/kunit/test.c
914cc63ee
The xe_vram_region_alloc() function returns NULL on error. It never
returns error pointers. Update the error checking to match.
Fixes: 4b0a5f5ce784 ("drm/xe: Unify the initialization of VRAM regions")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/xe/xe_tile.c | 4 ++--
1 file
rr)
171 goto err_out;
172
173 return 0;
174
175 err_out:
176 xe_guc_sanitize(&uc->guc);
177 return err;
178 }
regards,
dan carpenter
The fwnode_create_software_node() function returns error pointers. It
never returns NULL. Update the checks to match.
Fixes: f0e53aadd702 ("drm/xe: Support for I2C attached MCUs")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/xe/xe_i2c.c | 4 ++--
1 file changed, 2 insert
drm_private *priv = dev->dev_private;
330 int ret;
331
332 if (!minor)
^^
But the older code assumes the minor can be NULL
333 return 0;
334
regards,
dan carpenter
The devm_drm_bridge_alloc() function returns error pointers on error. It
never returns NULL.
Fixes: 48f05c3b4b70 ("drm/bridge: analogix_dp: Use devm_drm_bridge_alloc() API")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
1 file
We need to drop a couple locks before returning if the kasprintf() fails.
Fixes: c03ea34cbf88 ("drm/amdgpu: add support of debugfs for mqd information")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 6 --
1 file changed, 4 insertions(+), 2 deletion
f (!IS_ERR_OR_NULL(syncobjs_to_reset)) {
839 for (i = 0; i < args->nr_in_syncobjs; ++i) {
840 if (syncobjs_to_reset[i])
841 drm_syncobj_put(syncobjs_to_reset[i]);
842 }
843 kfree(syncobjs_to_reset);
844 }
845
846 return ret;
847 }
regards,
dan carpenter
This code needs to be indented one more tab.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/display/drm_dp_helper.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/display/drm_dp_helper.c
b/drivers/gpu/drm/display/drm_dp_helper.c
index
return progress;
It's strange to me that we returns progress values which are greater than the
target value.
903 }
regards,
dan carpenter
gesting
it...
This isn't a case where we revert. The patch we applied was acceptable
quality and it worked fine. Just do the additional cleanup on the top.
regards,
dan carpenter
when git was invented in 2005.
It sets you up for failure. These days we have so many other things
that we want in patches.
1) The subsystem prefix in the subject
2) The 12 character hashes
3) A proper commit message
4) A Fixes tag
The automated revert commit messages don't have any of that. It's
always better to hand write them.
regards,
dan carpenter
: fix potential memory leak in fbtft_framebuffer_alloc()"),
> and so reverting the old patch.
>
> Signed-off-by: Abdun Nihaal
> ---
This is the wrong approach. The original patch was fine. Just
write the next patches on top of that.
regards,
dan carpenter
On Sun, Jun 29, 2025 at 08:10:09PM +0530, Abdun Nihaal wrote:
> Fix a potential memory leak and cleanup error handling in
> fbtft_framebuffer_alloc().
>
Thanks!
Reviewed-by: Dan Carpenter
regards,
dan carpenter
if (ret && ret != -EALREADY)
985 return ERR_PTR(ret);
986
987 spin_lock(lru_lock);
988 }
989
990 spin_unlock(lru_lock);
991 return res ? bo : NULL;
So we know res is NULL and we could just change this to "return NULL;"
992 }
regards,
dan carpenter
uess that means you
get authorship credit if you fix that.
So if you want you could resend your patch and you could send these
changes I've suggested as a patch 2/2 and then I think everyone will
be happy.
regards,
dan carpenter
diff --git a/drivers/staging/fbtft/fbtft-core.c
b/drivers/sta
.
>
> Fixes: c296d5f9957c ("staging: fbtft: core support")
> Signed-off-by: Abdun Nihaal
> ---
Reviewed-by: Dan Carpenter
regards,
dan carpenter
it would lead to a NULL pointer
dereference.
To fix this, change the mock_request() function to return error pointers
and update all the callers to expect that.
Fixes: 52c0fdb25c7c ("drm/i915: Replace global breadcrumbs with per-context
interrupt tracking")
Signed-off-by: Dan Carpente
The "return true;" line wasn't indented. Also checkpatch likes when
we align the && conditions.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/a
GCC. Perhaps
Clang would have caught this but I'm not sure because tracking
uninitialized struct members is a bit more complicated than tracking
uninitialized variables.
regards,
dan carpenter
/202506241449.wdiucfjp-...@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https
ines "If you fix the issue in a separate
> patch/commit (i.e. not just a new version of the same patch/commit)"
>
If you're going to fold the fix into the original commit then it
doesn't matter what the commit message says since it will be gone
in the end either way.
regards,
dan carpenter
. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202506141727.fteuy8xn-...@intel.com/
smatch warnings:
drivers/gpu/drm/ttm/ttm_bo_util.c:975 __ttm_bo_lru_cursor_next
On Mon, Jun 16, 2025 at 11:01:08AM -0400, Rodrigo Vivi wrote:
> On Fri, Jun 06, 2025 at 12:04:49PM +0300, Dan Carpenter wrote:
> > --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> > @@ -290,7 +290,12 @@ struct sm
global breadcrumbs with per-context
interrupt tracking")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/selftests/i915_request.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c
b/drivers/gpu/drm/i915/selftes
ma_buf(attach, direction);
1127 if (!sg_table)
1128 sg_table = ERR_PTR(-ENOMEM);
1129 if (IS_ERR(sg_table))
1130 goto error_unpin;
1131
regards,
dan carpenter
On Wed, Jun 04, 2025 at 11:56:57AM -0300, Jason Gunthorpe wrote:
>
> A WARN_ON would be reasonable
Or we could add a WARN_ON(). That's also fine.
regards,
dan carpenter
On Wed, Jun 04, 2025 at 04:54:43PM +0200, Simona Vetter wrote:
> On Tue, Jun 03, 2025 at 07:29:52PM -0300, Jason Gunthorpe wrote:
> > On Mon, May 26, 2025 at 10:15:17PM +0530, Ghimiray, Himal Prasad wrote:
> > >
> > >
> > > On 26-05-2025 20:36, Dan Carpent
have
to look at test results.
#define intentional_warning_marker(type) do { \
pr_err("Triggering intentional %s warning!", type); \
} while (0)
intentional_warning_marker("KASAN");
regards,
dan carpenter
nvert feature". It
would be better to say "Add devicetree parameter to invert the display
on a ili9341 device."
regards,
dan carpenter
: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202505280653.y79jkqdd-...@intel.com
xe_svm_range_debug(svm_range, "PREFETCH - RANGE GET
PAGES DONE");
2927 }
2928
2929 return err;
2930 }
regards,
dan carpenter
to sync bo map/unmap")
Cc: sta...@vger.kernel.org
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index 2c68118fe9fd..0ec
The nvkm_device_tegra_resource() function returns a mix of error pointers
and NULL. The callers only expect it to return NULL on error. Change it
to only return NULL.
Fixes: 76b8f81a5b92 ("drm/nouveau: improve handling of 64-bit BARs")
Signed-off-by: Dan Carpenter
---
drivers/gpu/d
xes: a292fdecd728 ("drm/amdgpu: Implement userqueue signal/wait IOCTL")
Cc: sta...@vger.kernel.org
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amd
The devm_drm_panel_alloc() function returns error pointers, it doesn't
return NULL. Update the check to match.
Fixes: 4fca6849864d ("drm/panel: Add Novatek NT37801 panel driver")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/panel/panel-novatek-nt37801.c | 4 ++--
1
The callers expect to receive error pointers on error but
create_in_format_blob() returns NULL. Change it to return error
pointers.
Fixes: 0d6dcd741c26 ("drm/plane: modify create_in_formats to acommodate async")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/drm_plane.c | 4 ++
/config)
compiler: loongarch64-linux-gcc (GCC) 15.1.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r
On Wed, Apr 30, 2025 at 09:28:59AM +, Sharma, Shashank wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
>
> Hello Dan,
>
> ________
> From: Dan Carpenter
> Sent: Wednesday, April 30, 2025 10:05 AM
> To: Deucher, Alexander
"&chan->cgrp->mutex" and "&cgrp->mutex" are the same thing. Use
"&cgrp->mutex" consistently. It looks nicer and it silences a
Smatch static checker warning.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/nouveau/nvkm/engine/fifo/cha
The "ticket" pointer points to in the middle of the &exec struct so it
can't be NULL. Remove the check.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgp
t for Sitronix ST7571 LCD
controller")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/tiny/st7571-i2c.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/tiny/st7571-i2c.c
b/drivers/gpu/drm/tiny/st7571-i2c.c
index dc410ec41baf..eec846892962 10
rm: bridge: cdns-mhdp8546: Fix possible null pointer
dereference")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
b/drivers
This error path should call amdgpu_bo_unreserve() before returning.
Fixes: d8675102ba32 ("drm/amdgpu: add vm root BO lock before accessing the vm")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/d
si_generic_write_multi(dsi_ctx,
cmd_set_dig_gamma,
615
ARRAY_SIZE(cmd_set_dig_gamma));
616 }
617 }
618 }
regards,
dan carpenter
Return -ENOMEM if udl_alloc_urb_list() fails. Don't return success.
Fixes: fb10144ba426 ("drm/udl: Support adapters without firmware descriptor")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/udl/udl_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/u
definitely be
>
> goto err_unplug_gpu;
>
> Do you plan to send a patch, or should I do it?
>
I'm on vacation.
regards,
dan carpenter
The "pdd->drm_priv" NULL check is reversed so it will lead to a NULL
dereference on the next line.
Fixes: 4172b556fd5b ("drm/amdkfd: add smi events for process start and end")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
1 file cha
it to -ENOMEM.
Fixes: e7cf21fbb277 ("drm/amdgpu: Few optimization and fixes for userq fence
driver")
Signed-off-by: Dan Carpenter
---
v2: No change.
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/dri
The
"fence_drv" is already NULL so no cleanup is necessary.
Signed-off-by: Dan Carpenter
---
v2: New patch
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
b/driv
v);
275 panthor_sched_unplug(ptdev);
276
277 err_unplug_fw:
278 panthor_fw_unplug(ptdev);
279
280 err_unplug_mmu:
281 panthor_mmu_unplug(ptdev);
282
283 err_unplug_gpu:
284 panthor_gpu_unplug(ptdev);
285
286 err_rpm_put:
287 pm_runtime_put_sync_suspend(ptdev->base.dev);
288 return ret;
289 }
regards,
dan carpenter
This fixes a double free on one error path in
amdgpu_userq_fence_driver_alloc() and cleans up another error path.
v2:
Did some additional cleanup
Dan Carpenter (2):
drm/amdgpu: Fix double free in amdgpu_userq_fence_driver_alloc()
drm/amdgpu: Clean up error handling in
makes the patch confusing to add this unrelated
cleanup... I'll send it as a separate patch.
regards,
dan carpenter
it to -ENOMEM.
Fixes: e7cf21fbb277 ("drm/amdgpu: Few optimization and fixes for userq fence
driver")
Signed-off-by: Dan Carpenter
---
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/
We need to cleanup if the chain = dma_fence_chain_alloc() allocation
fails. Now that we have multiple error returns in this function, switch
to using an unwind ladder for cleanup.
Fixes: c2d3a7300695 ("drm/syncobj: Extend EXPORT_SYNC_FILE for timeline
syncobjs")
Signed-off-by: Dan
We re-worked this code a bit in commit af67978ee37e ("drm/display: dp:
use new DCPD access helpers") but there was a little bit of stray
dead code left over. Clean it up.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/display/drm_dp_helper.c | 9 ++---
1 file changed, 2 insert
;< 16) | (id[1] << 8) | (id[2] << 0);
492 }
493
494 static int ltk050h3146w_prepare(struct drm_panel *panel)
495 {
regards,
dan carpenter
Call dma_fence_put(fence) before returning an error if
dma_fence_to_sync_pt() fails. Use an unwind ladder at the
end of the function to do the cleanup.
Fixes: 70e67aaec2f4 ("dma-buf/sw_sync: Add fence deadline support")
Signed-off-by: Dan Carpenter
---
v2: style changes.
drive
t; > uninitialized symbol 'ret'.
> >
> > Reported-by: kernel test robot
> > Reported-by: Dan Carpenter
> > Closes: https://lore.kernel.org/r/202504021500.3am1hkks-...@intel.com/
> > Signed-off-by: sunliming
> > ---
> > drivers/gpu/drm/vc4/vc4_
ch7033: Add a new driver")
Signed-off-by: Dan Carpenter
---
>From static analysis. Not tested!
drivers/gpu/drm/bridge/chrontel-ch7033.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/bridge/chrontel-ch7033.c
b/drivers/gpu/drm/bridge/chro
There was a bug where we should have called rpi_firmware_put(firmware)
if devm_clk_get() failed. Really, it's better and more readable to
move all the firmware code together so that we can release it one
time.
Fixes: 2fa4ef5fb943 ("drm/vc4: hvs: Create hw_init function")
Sig
On Mon, Mar 31, 2025 at 02:02:44PM +0200, Christian König wrote:
> Am 31.03.25 um 11:45 schrieb Dan Carpenter:
> > Call dma_fence_put(fence) before returning an error on this error path.
> >
> > Fixes: 70e67aaec2f4 ("dma-buf/sw_sync: Add fence deadline support")
&
On Wed, Apr 02, 2025 at 11:34:58AM +, Dave Stevenson wrote:
> Hi Dan
>
> On Wed, 2 Apr 2025 at 12:00, Dan Carpenter wrote:
> >
> > Call rpi_firmware_put() on these two error paths before returning.
>
> Ack that there is an issue here, but it seems eas
Call rpi_firmware_put() on these two error paths before returning.
Fixes: 2fa4ef5fb943 ("drm/vc4: hvs: Create hw_init function")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/vc4/vc4_hvs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_hvs.c b/drive
Call dma_fence_put(fence) before returning an error on this error path.
Fixes: 70e67aaec2f4 ("dma-buf/sw_sync: Add fence deadline support")
Signed-off-by: Dan Carpenter
---
drivers/dma-buf/sw_sync.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma-buf
;kunit: add test cases for backtrace warning
> suppression")
>
Yeah. Everyone should configure the default hash length to 12.
git config set --global core.abbrev 12
I generate my fixes tags like so:
#!/bin/bash
git log -1 --format='Fixes: %h ("%s")' $*
regards,
dan carpenter
;t been following the conversation
closely (plus I'm pretty stupid as well) so I'm not sure if it will
trigger here...
regards,
dan carpenter
| Reported-by: kernel test robot
| Reported-by: Dan Carpenter
| Closes: https://lore.kernel.org/r/202503091053.hg9hub8c-...@intel.com/
New smatch warnings:
drivers/gpu/drm/xe/xe_vm.c:3557 fill_faults() warn: iterator 'i' not incremented
vim +/i +3557 drivers/gpu/drm/xe/xe_vm.c
24e54
This line is indented on tab too far. Delete the extra tab.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c
b/drivers/gpu/drm/i915/gt/uc/intel_gsc_fw.c
On Mon, Mar 10, 2025 at 12:56:46PM -0400, Rodrigo Vivi wrote:
> On Mon, Mar 10, 2025 at 01:48:00PM +0300, Dan Carpenter wrote:
> > The error handling assumes that vm_bind_ioctl_check_args() will
> > initialize "bind_ops" but there are a couple early returns where that&#x
The error handling assumes that vm_bind_ioctl_check_args() will
initialize "bind_ops" but there are a couple early returns where that's
not true. Initialize "bind_ops" to NULL from the start.
Fixes: b43e864af0d4 ("drm/xe/uapi: Add DRM_XE_VM_BIND_FLAG_CPU_AD
These lines are indented one tab more than they should be. Delete
the stray tabs.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdkfd/kfd_debug.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_debug.c
b/drivers/gpu/drm
This line has a seven space indent instead of a tab.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c
index
These lines are indented one tab too far. Delete the extra tabs.
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
These are u64 variables that come from the user via
qaic_attach_slice_bo_ioctl(). Use check_add_overflow() to ensure that
the math doesn't have an integer wrapping bug.
Cc: sta...@vger.kernel.org
Fixes: ff13be830333 ("accel/qaic: Add datapath")
Signed-off-by: Dan Carpent
range->notifier_seq = LONG_MAX;
800 range->flags.migrate_devmem = migrate_devmem ? 1 : 0;
801
802 return range;
803 }
regards,
dan carpenter
On Thu, Mar 06, 2025 at 12:12:53PM -0700, Jeff Hugo wrote:
> On 3/5/2025 8:53 AM, Dan Carpenter wrote:
> > These are u64 variables that come from the user via
> > qaic_attach_slice_bo_ioctl(). Ensure that the math doesn't have an
> > integer wrapping bug.
> >
After the loop there is a check for whether "wb_encoder" has been set
to non-NULL, however it was never set to NULL. Initialize it to NULL.
Fixes: ad06972d5365 ("drm/msm/dpu: Reorder encoder kickoff for CWB")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/msm/disp/dpu1/
The __drmm_universal_plane_alloc() function doesn't return NULL, it
returns error pointers. Update the check to match.
Fixes: 332122eba628 ("drm: adp: Add Apple Display Pipe driver")
Signed-off-by: Dan Carpenter
---
drivers/gpu/drm/adp/adp_drv.c | 4 ++--
1 file changed, 2 i
These are u64 variables that come from the user via
qaic_attach_slice_bo_ioctl(). Ensure that the math doesn't have an
integer wrapping bug.
Cc: sta...@vger.kernel.org
Fixes: ff13be830333 ("accel/qaic: Add datapath")
Signed-off-by: Dan Carpenter
---
drivers/accel/qaic/qaic_da
On Wed, Mar 05, 2025 at 02:17:32PM +, David Laight wrote:
> On Wed, 5 Mar 2025 11:51:59 +0300
> Dan Carpenter wrote:
>
> > On Wed, Mar 05, 2025 at 09:40:43AM +0100, Markus Elfring wrote:
> > > >>> The address of a data structure member was determined befo
Yuri's email is bouncing.
Another related warnings:
drivers/accel/habanalabs/gaudi/gaudi.c:5344 gaudi_parse_cb_mmu()
warn: potential user controlled sizeof overflow
'parser->user_cb_size + gaudi_get_patched_cb_extra_size(parser->user_cb_size)'
'0-u32max + 0-u32max&#x
b_size is a user controlled variable that comes from
cs_ioctl_default(). This addition operation could result in an interger
wrapping bug.
1423 return cacheline_end - user_cb_size +
additional_commands;
1424 else
1425 return additional_commands;
1426 }
regards,
dan carpenter
behavior here.
>
> Is there a need to improve the wording precision?
>
> There are words which denote a special meaning according to aspects of
> the programming language “C”.
> https://en.cppreference.com/w/c/language/behavior
>
> Dereferences of null pointers are treated in special ways.
This not a dereference. It's just pointer math.
regards,
dan carpenter
'm not entirely sure, but I remember that we had this discussion already.
>
> Can you please send patches from the same address as indicated by your SoB?
This is not a bug fix so it shouldn't have a Fixes tag.
regards,
dan carpenter
On Mon, Mar 03, 2025 at 11:30:46AM +0100, Uwe Kleine-König wrote:
> On Mon, Mar 03, 2025 at 01:08:29PM +0300, Dan Carpenter wrote:
> > On Mon, Mar 03, 2025 at 10:19:06AM +0100, Uwe Kleine-König wrote:
> > > Hello,
> > >
> > > On Sun, Mar 02, 2025 at 07
On Mon, Mar 03, 2025 at 01:08:29PM +0300, Dan Carpenter wrote:
> Real bugs where we dereference a pointer and then check for NULL don't
> last long in the kernel. Most of the stuff Markus is sending is false
> positives like this.
Maybe I was too optimistic. Here are the Smatch
org
>
> to ensure this is backported to stable.
It's not a bugfix, it's a cleanup. That's not a dereference, it's
just pointer math. It shouldn't have a Fixes tag.
Real bugs where we dereference a pointer and then check for NULL don't
last long in the kernel. Most of the stuff Markus is sending is false
positives like this.
regards,
dan carpenter
1 - 100 of 1205 matches
Mail list logo
